commit dc358af75d5804ce32112a2463cb0036f7aaf79e
author Jamie Madill <jmadill@chromium.org> Tue Jul 31 11:22:13 2018 -0400
committer Commit Bot <commit-bot@chromium.org> Tue Jul 31 16:28:00 2018 +0000
tree c684e49e2edeabef4973f1731eff505077e5185f
parent 97f45b7b7245e6812c02dbc644855ad38178dc65

Context: Cache attributes masks.

This cache is updated in the following locations:

1. GLES1: clientActiveTexture.
2. GLES1: disableClientState/enableClientState.
3. Context: linkProgram/useProgram/programBinary.
4. Context: bindVertexArray.
5. Vertex Array: most state changes.

Improves performance by about 6% in the GL no-op test. Also includes
fixes for keeping the client memory attribs mask in sync. The cache
also includes a boolean if there are any enabled client attributes.

Bug: angleproject:1391
Change-Id: I93b6a2c8492355958fd5483f14b70535729091d6
Reviewed-on: https://chromium-review.googlesource.com/1147437
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/libANGLE/validationES.cpp

diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index da6f989..a3e2c62 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -83,13 +83,11 @@
 {
     const gl::State &state     = context->getGLState();
     const gl::Program *program = state.getProgram();
+    const VertexArray *vao     = state.getVertexArray();
 
     bool webglCompatibility = context->getExtensions().webglCompatibility;
 
-    const VertexArray *vao              = state.getVertexArray();
-    const AttributesMask &clientAttribs = vao->getEnabledClientMemoryAttribsMask();
-
-    if (clientAttribs.any())
+    if (context->getStateCache().hasAnyEnabledClientAttrib())
     {
         if (webglCompatibility || !state.areClientArraysEnabled())
         {
@@ -118,7 +116,7 @@
     const auto &vertexAttribs  = vao->getVertexAttributes();
     const auto &vertexBindings = vao->getVertexBindings();
 
-    const AttributesMask &activeAttribs = context->getActiveBufferedAttribsMask();
+    const AttributesMask &activeAttribs = context->getStateCache().getActiveBufferedAttribsMask();
 
     for (size_t attributeIndex : activeAttribs)
     {