commit e4faae213dfd8bd6ab4464922c8fe54d44fc47b9
author Jamie Madill <jmadill@chromium.org> Fri May 10 08:27:00 2019 -0400
committer Commit Bot <commit-bot@chromium.org> Fri May 10 15:08:22 2019 +0000
tree 8c1faa4f8c9d1c9009060a83ebb9c64a6c3a3b4c
parent fdbece20b6b91cf55ddc389e1b3735517873476e

Rename state change notification messages.

This makes the style use CamelCase instead of ALL_CAPS. It also cleans
up some of the naming. It also changes some uses of the messages in
some of the objects to hopefully be more consistent. See the comments
added to the enum SubjectMessage in Observer.h for more details.

Bug: angleproject:3427
Change-Id: I6dff4f6d335ecf1a27e48df65743b1490bd3025a
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1600411
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

src/libANGLE/Framebuffer.cpp

diff --git a/src/libANGLE/Framebuffer.cpp b/src/libANGLE/Framebuffer.cpp
index cfc8cd0..407d573 100644
--- a/src/libANGLE/Framebuffer.cpp
+++ b/src/libANGLE/Framebuffer.cpp
@@ -955,7 +955,7 @@
     if (mState.mId != 0)
     {
         mCachedStatus.reset();
-        onStateChange(context, angle::SubjectMessage::CONTENTS_CHANGED);
+        onStateChange(context, angle::SubjectMessage::SubjectChanged);
     }
 }
 
@@ -1853,16 +1853,16 @@
                                        angle::SubjectIndex index,
                                        angle::SubjectMessage message)
 {
-    if (message != angle::SubjectMessage::STORAGE_CHANGED)
+    if (message != angle::SubjectMessage::SubjectChanged)
     {
         // This can be triggered by the GL back-end TextureGL class.
-        ASSERT(message == angle::SubjectMessage::DEPENDENT_DIRTY_BITS);
+        ASSERT(message == angle::SubjectMessage::DirtyBitsFlagged);
         return;
     }
 
     ASSERT(!mDirtyBitsGuard.valid() || mDirtyBitsGuard.value().test(index));
     mDirtyBits.set(index);
-    onStateChange(context, angle::SubjectMessage::STORAGE_CHANGED);
+    onStateChange(context, angle::SubjectMessage::DirtyBitsFlagged);
 
     invalidateCompletenessCache(context);