commit e815afbf88a606b6ce95a53eee4f09d632ee93d8
author Trevor David Black <vantablack@google.com> Mon Sep 07 22:09:22 2020 +0000
committer Commit Bot <commit-bot@chromium.org> Fri Oct 02 19:49:38 2020 +0000
tree 090c738810b16d995b66ec485d4bcde709a052a2
parent 7a92d958902f8d939f352237b3a20a7374d2b53d

First pass at increasing inclusivity

Link to the inclusivity rules
https://source.android.com/setup/contribute/respectful-code

Bug: b/162834212
Bug: chromium:1097198
Change-Id: Ied5a9e3879d72bff3f77ea6fcda9b82f30c32c2f
Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2396737
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Trevor Black <vantablack@google.com>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index e7ac94e..c94dd94 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -60,7 +60,7 @@
     def _CheckTabInCommit(lines):
         return all([line.find("\t") == -1 for line in lines])
 
-    whitelist_strings = ['Revert "', 'Roll ', 'Reland ', 'Re-land ']
+    allowlist_strings = ['Revert "', 'Roll ', 'Reland ', 'Re-land ']
     summary_linelength_warning_lower_limit = 65
     summary_linelength_warning_upper_limit = 70
     description_linelength_limit = 72
@@ -79,13 +79,13 @@
             commit_msg_line_numbers[commit_msg_lines[i]] = i + 1
         _PopBlankLines(commit_msg_lines, True)
         _PopBlankLines(commit_msg_lines, False)
-        whitelisted = False
+        allowlisted = False
         if len(commit_msg_lines) > 0:
-            for whitelist_string in whitelist_strings:
-                if commit_msg_lines[0].startswith(whitelist_string):
-                    whitelisted = True
+            for allowlist_string in allowlist_strings:
+                if commit_msg_lines[0].startswith(allowlist_string):
+                    allowlisted = True
                     break
-        if whitelisted:
+        if allowlisted:
             continue
 
         if not _CheckTabInCommit(commit_msg_lines):
@@ -252,7 +252,7 @@
   """
 
     def headers(f):
-        return input_api.FilterSourceFile(f, white_list=(r'.+%s' % _HEADER_EXTENSIONS,))
+        return input_api.FilterSourceFile(f, allow_list=(r'.+%s' % _HEADER_EXTENSIONS,))
 
     new_headers = []
     for f in input_api.AffectedSourceFiles(headers):
@@ -261,7 +261,7 @@
         new_headers.append(f.LocalPath())
 
     def gn_files(f):
-        return input_api.FilterSourceFile(f, white_list=(r'.+\.gn',))
+        return input_api.FilterSourceFile(f, allow_list=(r'.+\.gn',))
 
     all_gn_changed_contents = ''
     for f in input_api.AffectedSourceFiles(gn_files):
@@ -325,7 +325,7 @@
 
     def implementation_and_headers(f):
         return input_api.FilterSourceFile(
-            f, white_list=(r'.+%s' % _IMPLEMENTATION_AND_HEADER_EXTENSIONS,))
+            f, allow_list=(r'.+%s' % _IMPLEMENTATION_AND_HEADER_EXTENSIONS,))
 
     files_with_tabs = []
     for f in input_api.AffectedSourceFiles(implementation_and_headers):
@@ -357,7 +357,7 @@
 
     def implementation_and_headers(f):
         return input_api.FilterSourceFile(
-            f, white_list=(r'.+%s' % _IMPLEMENTATION_AND_HEADER_EXTENSIONS,))
+            f, allow_list=(r'.+%s' % _IMPLEMENTATION_AND_HEADER_EXTENSIONS,))
 
     files_with_non_ascii = []
     for f in input_api.AffectedSourceFiles(implementation_and_headers):