Changed the rectangle arguments of Renderer11::blitRect from pointers to const references since they are never null or modified.
TRAC #22416
Signed-off-by: Jamie Madill
Signed-off-by: Shannon Woods
Author: Geoff Lang
git-svn-id: https://angleproject.googlecode.com/svn/branches/dx11proto@1869 736b8ea6-26fd-11df-bfd4-992fa37f6226
diff --git a/src/libGLESv2/renderer/Renderer11.cpp b/src/libGLESv2/renderer/Renderer11.cpp
index c5d4612..935b182 100644
--- a/src/libGLESv2/renderer/Renderer11.cpp
+++ b/src/libGLESv2/renderer/Renderer11.cpp
@@ -2727,15 +2727,15 @@
return false;
}
-bool Renderer11::blitRect(gl::Framebuffer *readTarget, gl::Rectangle *readRect, gl::Framebuffer *drawTarget, gl::Rectangle *drawRect,
+bool Renderer11::blitRect(gl::Framebuffer *readTarget, const gl::Rectangle &readRect, gl::Framebuffer *drawTarget, const gl::Rectangle &drawRect,
bool blitRenderTarget, bool blitDepthStencil)
{
- if (blitRenderTarget && !blitRect(readTarget, *readRect, drawTarget, *drawRect, BLIT_RENDERTARGET))
+ if (blitRenderTarget && !blitRect(readTarget, readRect, drawTarget, drawRect, BLIT_RENDERTARGET))
{
return false;
}
- if (blitDepthStencil && !blitRect(readTarget, *readRect, drawTarget, *drawRect, BLIT_DEPTHSTENCIL))
+ if (blitDepthStencil && !blitRect(readTarget, readRect, drawTarget, drawRect, BLIT_DEPTHSTENCIL))
{
return false;
}
@@ -3182,7 +3182,7 @@
if (!readBuffer)
{
ERR("Failed to retrieve the color buffer from the read target.");
- return error(GL_OUT_OF_MEMORY, false);
+ return gl::error(GL_OUT_OF_MEMORY, false);
}
RenderTarget11 *sourceRenderTarget = NULL;
@@ -3199,7 +3199,7 @@
if (!sourceRenderTarget)
{
ERR("Failed to retrieve the render target from the frame buffer.");
- return error(GL_OUT_OF_MEMORY, false);
+ return gl::error(GL_OUT_OF_MEMORY, false);
}
ID3D11Texture2D *source = NULL;
@@ -3222,7 +3222,7 @@
if (!source)
{
ERR("Failed to retrieve the render target view from the render target.");
- return error(GL_OUT_OF_MEMORY, false);
+ return gl::error(GL_OUT_OF_MEMORY, false);
}
@@ -3241,7 +3241,7 @@
{
source->Release();
ERR("Failed to retrieve the color buffer from the draw buffer.");
- return error(GL_OUT_OF_MEMORY, false);
+ return gl::error(GL_OUT_OF_MEMORY, false);
}
RenderTarget11 *drawRenderTarget = NULL;
@@ -3259,7 +3259,7 @@
{
source->Release();
ERR("Failed to retrieve the render target from the render buffer.");
- return error(GL_OUT_OF_MEMORY, false);
+ return gl::error(GL_OUT_OF_MEMORY, false);
}
ID3D11Texture2D *dest = drawRenderTarget->getTexture();