commit ee6884e7be666efc9e06b77eab7f4ead2779f46b
author Geoff Lang <geofflang@chromium.org> Thu Nov 09 16:51:11 2017 -0500
committer Commit Bot <commit-bot@chromium.org> Fri Nov 10 00:03:58 2017 +0000
tree 511d68ed1e5409bb91385f0d169628732579893b
parent 9e888a46f04dad0f40539ce5f0c241f6e6d6080a

Generate generic error messages for Error objects without messages.

Makes sure that the debug output is fired for all generated errors.

BUG=783054

Change-Id: Ia30870cd950c53da892554e0862276d4be5360ac
Reviewed-on: https://chromium-review.googlesource.com/761760
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>

src/libANGLE/Context.cpp

diff --git a/src/libANGLE/Context.cpp b/src/libANGLE/Context.cpp
index 07bbb5a..337cb9d 100644
--- a/src/libANGLE/Context.cpp
+++ b/src/libANGLE/Context.cpp
@@ -2153,12 +2153,9 @@
             markContextLost();
         }
 
-        if (!error.getMessage().empty())
-        {
-            auto *debug = &mGLState.getDebug();
-            debug->insertMessage(GL_DEBUG_SOURCE_API, GL_DEBUG_TYPE_ERROR, error.getID(),
-                                 GL_DEBUG_SEVERITY_HIGH, error.getMessage());
-        }
+        ASSERT(!error.getMessage().empty());
+        mGLState.getDebug().insertMessage(GL_DEBUG_SOURCE_API, GL_DEBUG_TYPE_ERROR, error.getID(),
+                                          GL_DEBUG_SEVERITY_HIGH, error.getMessage());
     }
 }