commit efb6ac66093b3e229ff7ccbf12396e505c7881d4
author Corentin Wallez <cwallez@chromium.org> Wed Sep 02 08:10:09 2015 -0700
committer Corentin Wallez <cwallez@chromium.org> Wed Sep 02 17:00:17 2015 +0000
tree 06897660ade7c4e26c313ba30a608b10455e33b8
parent d4bcfa2cd6c4d575803558d001f273e2dd0d8104

ProgramBinaryTest: fix an unreachable code warning

This warning was found by the GN build on Windows: the FAIL macro contains
a return which caused code after the FAIL to be unreachable.

BUG=angleproject:929

Change-Id: Id4bda39ea9f76d2b59c44391cb2de8a3bfb6947c
Reviewed-on: https://chromium-review.googlesource.com/296950
Tested-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>

src/tests/gl_tests/ProgramBinaryTest.cpp

diff --git a/src/tests/gl_tests/ProgramBinaryTest.cpp b/src/tests/gl_tests/ProgramBinaryTest.cpp
index cd8e0b3..fb175d9 100644
--- a/src/tests/gl_tests/ProgramBinaryTest.cpp
+++ b/src/tests/gl_tests/ProgramBinaryTest.cpp
@@ -377,9 +377,8 @@
 
     if (program == 0)
     {
-        FAIL() << "Failed to create program from source";
         destroyEGLWindow(&eglWindow);
-        return;
+        FAIL() << "Failed to create program from source";
     }
 
     // Draw using the program to ensure it works as expected