commit f7af13c4742d33d692172546e6bc504d906cf3c8
author Qin Jiajia <jiajia.qin@intel.com> Wed Jun 06 14:14:54 2018 +0800
committer Commit Bot <commit-bot@chromium.org> Wed Jun 06 13:53:04 2018 +0000
tree 7869c7a8904245e68a17343f42521e26d57f9526
parent 096a6c8cf13d6f734aa754a814d811ca1f15c4d0

Fix the divide by zero exception in BindBufferRange

This bug is caught because we haven't implemented
caps.shaderStorageBufferOffsetAlignment on D3D backend. So the default
value is 0. This change will set its value for D3D11 backend.

BUG=angleproject:2625
TEST=angle_deqp_gles31_tests

Change-Id: I03c045c08903e4da41659133e7dbd9c4133186cc
Reviewed-on: https://chromium-review.googlesource.com/1088192
Reviewed-by: Yunchao He <yunchao.he@intel.com>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

src/libANGLE/validationES3.cpp

diff --git a/src/libANGLE/validationES3.cpp b/src/libANGLE/validationES3.cpp
index f132e69..b0faa9b 100644
--- a/src/libANGLE/validationES3.cpp
+++ b/src/libANGLE/validationES3.cpp
@@ -1543,6 +1543,7 @@
                 return false;
             }
 
+            ASSERT(caps.uniformBufferOffsetAlignment);
             if (buffer != 0 && (offset % caps.uniformBufferOffsetAlignment) != 0)
             {
                 context->handleError(
@@ -1589,6 +1590,7 @@
                                                        "indexed binding points.");
                 return false;
             }
+            ASSERT(caps.shaderStorageBufferOffsetAlignment);
             if (buffer != 0 && (offset % caps.shaderStorageBufferOffsetAlignment) != 0)
             {
                 context->handleError(InvalidValue() << "offset must be multiple of value of "