commit fb7685f4035e38494aedbb3cb05163427d0daacf
author Geoff Lang <geofflang@chromium.org> Mon Nov 13 11:44:11 2017 -0500
committer Commit Bot <commit-bot@chromium.org> Tue Nov 14 20:34:49 2017 +0000
tree d270bd46bc5682303cf55fce7616142e38bb626f
parent 7caa80e7598930a8663f4bdcfe91285a9460c70a

Validate texture parameters for >0 after rounding.

From the spec (2.3.1 Data Conversion For State-Setting Commands):
"Validation of values performed by state-setting commands is performed
after conversion, unless specified otherwise for a specific command."

BUG=783574

Change-Id: I9edf585a17489ad284bc85a1c3c2236b53ee34d9
Reviewed-on: https://chromium-review.googlesource.com/766569
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

src/libANGLE/validationES.cpp

diff --git a/src/libANGLE/validationES.cpp b/src/libANGLE/validationES.cpp
index 9b2434d..f3679b7 100644
--- a/src/libANGLE/validationES.cpp
+++ b/src/libANGLE/validationES.cpp
@@ -5505,7 +5505,7 @@
             break;
 
         case GL_TEXTURE_BASE_LEVEL:
-            if (params[0] < 0)
+            if (ConvertToGLint(params[0]) < 0)
             {
                 context->handleError(InvalidValue() << "Base level must be at least 0.");
                 return false;
@@ -5531,7 +5531,7 @@
             break;
 
         case GL_TEXTURE_MAX_LEVEL:
-            if (params[0] < 0)
+            if (ConvertToGLint(params[0]) < 0)
             {
                 ANGLE_VALIDATION_ERR(context, InvalidValue(), InvalidMipLevel);
                 return false;