commit fbb1c792150a8d304f20b84a4bf002599be7d97f
author Olli Etuaho <oetuaho@nvidia.com> Fri Jan 19 16:26:59 2018 +0200
committer Commit Bot <commit-bot@chromium.org> Tue Feb 06 21:54:31 2018 +0000
tree e8bfc941ae0535fe656c20bfcb66b7e5d5a49e11
parent d775684a9f88de62f8eca400727bd226fb32bae1

Store symbol names as a ImmutableString

This will enable compile-time initialization of built-in symbols as
well as reducing copying strings.

Most of the code that deals with names is changed to use
ImmutableString where it makes sense to avoid conversions.

The lexer/parser now allocate const char pointers into pool memory
instead of allocating TStrings. These are then converted to
ImmutableString upon entering TParseContext.

BUG=angleproject:2267
TEST=angle_unittests, angle_end2end_tests

Change-Id: I244d6271ea1ecf7150d4f89dfa388a7745a1150c
Reviewed-on: https://chromium-review.googlesource.com/881561
Commit-Queue: Olli Etuaho <oetuaho@nvidia.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>

src/compiler/translator/RemoveUnreferencedVariables.cpp

diff --git a/src/compiler/translator/RemoveUnreferencedVariables.cpp b/src/compiler/translator/RemoveUnreferencedVariables.cpp
index ad14648..6445eb8 100644
--- a/src/compiler/translator/RemoveUnreferencedVariables.cpp
+++ b/src/compiler/translator/RemoveUnreferencedVariables.cpp
@@ -203,8 +203,9 @@
                 // Already an empty declaration - nothing to do.
                 return;
             }
-            TVariable *emptyVariable = new TVariable(
-                mSymbolTable, nullptr, new TType(declarator->getType()), SymbolType::Empty);
+            TVariable *emptyVariable =
+                new TVariable(mSymbolTable, ImmutableString(""), new TType(declarator->getType()),
+                              SymbolType::Empty);
             queueReplacementWithParent(node, declarator, new TIntermSymbol(emptyVariable),
                                        OriginalNode::IS_DROPPED);
             return;