commit febbea8865965244ae5d5abfdad779622db55d69
author apatrick@chromium.org <apatrick@chromium.org@736b8ea6-26fd-11df-bfd4-992fa37f6226> Wed Dec 07 19:10:16 2011 +0000
committer apatrick@chromium.org <apatrick@chromium.org@736b8ea6-26fd-11df-bfd4-992fa37f6226> Wed Dec 07 19:10:16 2011 +0000
tree 1460abb0289c19bfaac1d5a323bc1f770885cd87
parent f4490e220717ee3bdae77a14d1b5d16360190439

Fixed leak of render target associated with ColorBuffer.

Following r853, I am assuming that any render target returned by FrameBuffer::getRenderTarget has to be released. Updating the usage of getRenderTarget to reflect that.

This is not reproducible in Chrome at the moment but it will be once I start rendering to pbuffers.

I ran the WebGL conformance tests. No regressions or crashes.
Review URL: http://codereview.appspot.com/5451110

git-svn-id: https://angleproject.googlecode.com/svn/trunk@903 736b8ea6-26fd-11df-bfd4-992fa37f6226

src/libGLESv2/Context.cpp

diff --git a/src/libGLESv2/Context.cpp b/src/libGLESv2/Context.cpp
index 0de524a..629ca0f 100644
--- a/src/libGLESv2/Context.cpp
+++ b/src/libGLESv2/Context.cpp
@@ -2293,6 +2293,8 @@
 
     result = mDevice->GetRenderTargetData(renderTarget, systemSurface);
 
+    renderTarget->Release();
+
     if (FAILED(result))
     {
         systemSurface->Release();
@@ -2609,6 +2611,8 @@
     D3DSURFACE_DESC desc;
     renderTarget->GetDesc(&desc);
 
+    renderTarget->Release();
+
     bool alphaUnmasked = (dx2es::GetAlphaSize(desc.Format) == 0) || mState.colorMaskAlpha;
 
     const bool needMaskedStencilClear = (flags & D3DCLEAR_STENCIL) &&
@@ -3791,8 +3795,14 @@
 
         if (blitRenderTarget)
         {
-            HRESULT result = mDevice->StretchRect(readFramebuffer->getRenderTarget(), &sourceTrimmedRect, 
-                                                 drawFramebuffer->getRenderTarget(), &destTrimmedRect, D3DTEXF_NONE);
+            IDirect3DSurface9* readRenderTarget = readFramebuffer->getRenderTarget();
+            IDirect3DSurface9* drawRenderTarget = drawFramebuffer->getRenderTarget();
+
+            HRESULT result = mDevice->StretchRect(readRenderTarget, &sourceTrimmedRect, 
+                                                  drawRenderTarget, &destTrimmedRect, D3DTEXF_NONE);
+
+            readRenderTarget->Release();
+            drawRenderTarget->Release();
 
             if (FAILED(result))
             {