daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 12 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 13 | #include "compiler/translator/Cache.h" |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 14 | #include "compiler/translator/glslang.h" |
| 15 | #include "compiler/translator/ValidateSwitch.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 17 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 18 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 19 | /////////////////////////////////////////////////////////////////////// |
| 20 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 21 | // Sub- vector and matrix fields |
| 22 | // |
| 23 | //////////////////////////////////////////////////////////////////////// |
| 24 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 25 | namespace |
| 26 | { |
| 27 | |
| 28 | const int kWebGLMaxStructNesting = 4; |
| 29 | |
| 30 | bool ContainsSampler(const TType &type) |
| 31 | { |
| 32 | if (IsSampler(type.getBasicType())) |
| 33 | return true; |
| 34 | |
| 35 | if (type.getBasicType() == EbtStruct || type.isInterfaceBlock()) |
| 36 | { |
| 37 | const TFieldList &fields = type.getStruct()->fields(); |
| 38 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 39 | { |
| 40 | if (ContainsSampler(*fields[i]->type())) |
| 41 | return true; |
| 42 | } |
| 43 | } |
| 44 | |
| 45 | return false; |
| 46 | } |
| 47 | |
| 48 | bool ContainsImage(const TType &type) |
| 49 | { |
| 50 | if (IsImage(type.getBasicType())) |
| 51 | return true; |
| 52 | |
| 53 | if (type.getBasicType() == EbtStruct || type.isInterfaceBlock()) |
| 54 | { |
| 55 | const TFieldList &fields = type.getStruct()->fields(); |
| 56 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 57 | { |
| 58 | if (ContainsImage(*fields[i]->type())) |
| 59 | return true; |
| 60 | } |
| 61 | } |
| 62 | |
| 63 | return false; |
| 64 | } |
| 65 | |
| 66 | } // namespace |
| 67 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 68 | // |
| 69 | // Look at a '.' field selector string and change it into offsets |
| 70 | // for a vector. |
| 71 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 72 | bool TParseContext::parseVectorFields(const TString &compString, |
| 73 | int vecSize, |
| 74 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 75 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 76 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 77 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 78 | if (fields.num > 4) |
| 79 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 80 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 81 | return false; |
| 82 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 83 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 84 | enum |
| 85 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 86 | exyzw, |
| 87 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 88 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 89 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 90 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 91 | for (int i = 0; i < fields.num; ++i) |
| 92 | { |
| 93 | switch (compString[i]) |
| 94 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 95 | case 'x': |
| 96 | fields.offsets[i] = 0; |
| 97 | fieldSet[i] = exyzw; |
| 98 | break; |
| 99 | case 'r': |
| 100 | fields.offsets[i] = 0; |
| 101 | fieldSet[i] = ergba; |
| 102 | break; |
| 103 | case 's': |
| 104 | fields.offsets[i] = 0; |
| 105 | fieldSet[i] = estpq; |
| 106 | break; |
| 107 | case 'y': |
| 108 | fields.offsets[i] = 1; |
| 109 | fieldSet[i] = exyzw; |
| 110 | break; |
| 111 | case 'g': |
| 112 | fields.offsets[i] = 1; |
| 113 | fieldSet[i] = ergba; |
| 114 | break; |
| 115 | case 't': |
| 116 | fields.offsets[i] = 1; |
| 117 | fieldSet[i] = estpq; |
| 118 | break; |
| 119 | case 'z': |
| 120 | fields.offsets[i] = 2; |
| 121 | fieldSet[i] = exyzw; |
| 122 | break; |
| 123 | case 'b': |
| 124 | fields.offsets[i] = 2; |
| 125 | fieldSet[i] = ergba; |
| 126 | break; |
| 127 | case 'p': |
| 128 | fields.offsets[i] = 2; |
| 129 | fieldSet[i] = estpq; |
| 130 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 131 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 132 | case 'w': |
| 133 | fields.offsets[i] = 3; |
| 134 | fieldSet[i] = exyzw; |
| 135 | break; |
| 136 | case 'a': |
| 137 | fields.offsets[i] = 3; |
| 138 | fieldSet[i] = ergba; |
| 139 | break; |
| 140 | case 'q': |
| 141 | fields.offsets[i] = 3; |
| 142 | fieldSet[i] = estpq; |
| 143 | break; |
| 144 | default: |
| 145 | error(line, "illegal vector field selection", compString.c_str()); |
| 146 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 147 | } |
| 148 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 149 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 150 | for (int i = 0; i < fields.num; ++i) |
| 151 | { |
| 152 | if (fields.offsets[i] >= vecSize) |
| 153 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 154 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 155 | return false; |
| 156 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 157 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 158 | if (i > 0) |
| 159 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 160 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 161 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 162 | error(line, "illegal - vector component fields not from the same set", |
| 163 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 164 | return false; |
| 165 | } |
| 166 | } |
| 167 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 168 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 169 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 170 | } |
| 171 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 172 | /////////////////////////////////////////////////////////////////////// |
| 173 | // |
| 174 | // Errors |
| 175 | // |
| 176 | //////////////////////////////////////////////////////////////////////// |
| 177 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 178 | |
| 179 | // |
| 180 | // Used by flex/bison to output all syntax and parsing errors. |
| 181 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 182 | void TParseContext::error(const TSourceLoc &loc, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 183 | const char *reason, |
| 184 | const char *token, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 185 | const char *extraInfo) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 186 | { |
Olli Etuaho | 1cc598f | 2016-08-18 13:50:30 +0300 | [diff] [blame] | 187 | mDiagnostics.error(loc, reason, token, extraInfo); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 188 | } |
| 189 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 190 | void TParseContext::warning(const TSourceLoc &loc, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 191 | const char *reason, |
| 192 | const char *token, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 193 | const char *extraInfo) |
| 194 | { |
Olli Etuaho | 1cc598f | 2016-08-18 13:50:30 +0300 | [diff] [blame] | 195 | mDiagnostics.warning(loc, reason, token, extraInfo); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 196 | } |
| 197 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 198 | void TParseContext::outOfRangeError(bool isError, |
| 199 | const TSourceLoc &loc, |
| 200 | const char *reason, |
| 201 | const char *token, |
| 202 | const char *extraInfo) |
| 203 | { |
| 204 | if (isError) |
| 205 | { |
| 206 | error(loc, reason, token, extraInfo); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 207 | } |
| 208 | else |
| 209 | { |
| 210 | warning(loc, reason, token, extraInfo); |
| 211 | } |
| 212 | } |
| 213 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 214 | // |
| 215 | // Same error message for all places assignments don't work. |
| 216 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 217 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 218 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 219 | std::stringstream extraInfoStream; |
| 220 | extraInfoStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 221 | std::string extraInfo = extraInfoStream.str(); |
| 222 | error(line, "", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 223 | } |
| 224 | |
| 225 | // |
| 226 | // Same error message for all places unary operations don't work. |
| 227 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 228 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 229 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 230 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 231 | extraInfoStream << "no operation '" << op << "' exists that takes an operand of type " |
| 232 | << operand << " (or there is no acceptable conversion)"; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 233 | std::string extraInfo = extraInfoStream.str(); |
| 234 | error(line, " wrong operand type", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 235 | } |
| 236 | |
| 237 | // |
| 238 | // Same error message for all binary operations don't work. |
| 239 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 240 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 241 | const char *op, |
| 242 | TString left, |
| 243 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 244 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 245 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 246 | extraInfoStream << "no operation '" << op << "' exists that takes a left-hand operand of type '" |
| 247 | << left << "' and a right operand of type '" << right |
| 248 | << "' (or there is no acceptable conversion)"; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 249 | std::string extraInfo = extraInfoStream.str(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 250 | error(line, " wrong operand types ", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 251 | } |
| 252 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 253 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 254 | TPrecision precision, |
| 255 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 256 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 257 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 258 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 259 | |
| 260 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 261 | { |
| 262 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 263 | } |
| 264 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 265 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 266 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 267 | switch (type) |
| 268 | { |
| 269 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 270 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 271 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 272 | case EbtInt: |
| 273 | case EbtUInt: |
| 274 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 275 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 276 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 277 | default: |
| 278 | if (IsSampler(type)) |
| 279 | { |
| 280 | error(line, "No precision specified (sampler)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 281 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 282 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 283 | if (IsImage(type)) |
| 284 | { |
| 285 | error(line, "No precision specified (image)", ""); |
| 286 | return; |
| 287 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 288 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 289 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 290 | } |
| 291 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 292 | // Both test and if necessary, spit out an error, to see if the node is really |
| 293 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 294 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 295 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 296 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 297 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 298 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 299 | |
| 300 | if (swizzleNode) |
| 301 | { |
| 302 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 303 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 304 | { |
| 305 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 306 | return false; |
| 307 | } |
| 308 | return ok; |
| 309 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 310 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 311 | if (binaryNode) |
| 312 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 313 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 314 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 315 | case EOpIndexDirect: |
| 316 | case EOpIndexIndirect: |
| 317 | case EOpIndexDirectStruct: |
| 318 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 319 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 320 | default: |
| 321 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 322 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 323 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 324 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 325 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 326 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 327 | const char *symbol = 0; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 328 | if (symNode != 0) |
| 329 | symbol = symNode->getSymbol().c_str(); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 330 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 331 | const char *message = 0; |
| 332 | switch (node->getQualifier()) |
| 333 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 334 | case EvqConst: |
| 335 | message = "can't modify a const"; |
| 336 | break; |
| 337 | case EvqConstReadOnly: |
| 338 | message = "can't modify a const"; |
| 339 | break; |
| 340 | case EvqAttribute: |
| 341 | message = "can't modify an attribute"; |
| 342 | break; |
| 343 | case EvqFragmentIn: |
| 344 | message = "can't modify an input"; |
| 345 | break; |
| 346 | case EvqVertexIn: |
| 347 | message = "can't modify an input"; |
| 348 | break; |
| 349 | case EvqUniform: |
| 350 | message = "can't modify a uniform"; |
| 351 | break; |
| 352 | case EvqVaryingIn: |
| 353 | message = "can't modify a varying"; |
| 354 | break; |
| 355 | case EvqFragCoord: |
| 356 | message = "can't modify gl_FragCoord"; |
| 357 | break; |
| 358 | case EvqFrontFacing: |
| 359 | message = "can't modify gl_FrontFacing"; |
| 360 | break; |
| 361 | case EvqPointCoord: |
| 362 | message = "can't modify gl_PointCoord"; |
| 363 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 364 | case EvqNumWorkGroups: |
| 365 | message = "can't modify gl_NumWorkGroups"; |
| 366 | break; |
| 367 | case EvqWorkGroupSize: |
| 368 | message = "can't modify gl_WorkGroupSize"; |
| 369 | break; |
| 370 | case EvqWorkGroupID: |
| 371 | message = "can't modify gl_WorkGroupID"; |
| 372 | break; |
| 373 | case EvqLocalInvocationID: |
| 374 | message = "can't modify gl_LocalInvocationID"; |
| 375 | break; |
| 376 | case EvqGlobalInvocationID: |
| 377 | message = "can't modify gl_GlobalInvocationID"; |
| 378 | break; |
| 379 | case EvqLocalInvocationIndex: |
| 380 | message = "can't modify gl_LocalInvocationIndex"; |
| 381 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 382 | case EvqComputeIn: |
| 383 | message = "can't modify work group size variable"; |
| 384 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 385 | default: |
| 386 | // |
| 387 | // Type that can't be written to? |
| 388 | // |
| 389 | if (node->getBasicType() == EbtVoid) |
| 390 | { |
| 391 | message = "can't modify void"; |
| 392 | } |
| 393 | if (IsSampler(node->getBasicType())) |
| 394 | { |
| 395 | message = "can't modify a sampler"; |
| 396 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 397 | if (IsImage(node->getBasicType())) |
| 398 | { |
| 399 | message = "can't modify an image"; |
| 400 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 401 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 402 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 403 | if (message == 0 && binaryNode == 0 && symNode == 0) |
| 404 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 405 | error(line, " l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 406 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 407 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 408 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 409 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 410 | // |
| 411 | // Everything else is okay, no error. |
| 412 | // |
| 413 | if (message == 0) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 414 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 415 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 416 | // |
| 417 | // If we get here, we have an error and a message. |
| 418 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 419 | if (symNode) |
| 420 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 421 | std::stringstream extraInfoStream; |
| 422 | extraInfoStream << "\"" << symbol << "\" (" << message << ")"; |
| 423 | std::string extraInfo = extraInfoStream.str(); |
| 424 | error(line, " l-value required", op, extraInfo.c_str()); |
| 425 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 426 | else |
| 427 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 428 | std::stringstream extraInfoStream; |
| 429 | extraInfoStream << "(" << message << ")"; |
| 430 | std::string extraInfo = extraInfoStream.str(); |
| 431 | error(line, " l-value required", op, extraInfo.c_str()); |
| 432 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 433 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 434 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 435 | } |
| 436 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 437 | // Both test, and if necessary spit out an error, to see if the node is really |
| 438 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 439 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 440 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 441 | if (node->getQualifier() != EvqConst) |
| 442 | { |
| 443 | error(node->getLine(), "constant expression required", ""); |
| 444 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 445 | } |
| 446 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 447 | // Both test, and if necessary spit out an error, to see if the node is really |
| 448 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 449 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 450 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 451 | if (!node->isScalarInt()) |
| 452 | { |
| 453 | error(node->getLine(), "integer expression required", token); |
| 454 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 455 | } |
| 456 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 457 | // Both test, and if necessary spit out an error, to see if we are currently |
| 458 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 459 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 460 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 461 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 462 | { |
| 463 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 464 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 465 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 466 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 467 | } |
| 468 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 469 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 470 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 471 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 472 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 473 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 474 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 475 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 476 | static const char *reservedErrMsg = "reserved built-in name"; |
| 477 | if (!symbolTable.atBuiltInLevel()) |
| 478 | { |
| 479 | if (identifier.compare(0, 3, "gl_") == 0) |
| 480 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 481 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 482 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 483 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 484 | if (IsWebGLBasedSpec(mShaderSpec)) |
| 485 | { |
| 486 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 487 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 488 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 489 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 490 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 491 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 492 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 493 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 494 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 495 | } |
| 496 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 497 | if (identifier.find("__") != TString::npos) |
| 498 | { |
| 499 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 500 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 501 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 502 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 503 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 504 | } |
| 505 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 506 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 507 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 508 | } |
| 509 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 510 | // Make sure there is enough data provided to the constructor to build |
| 511 | // something of the type of the constructor. Also returns the type of |
| 512 | // the constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 513 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
| 514 | TIntermNode *argumentsNode, |
| 515 | const TFunction &function, |
| 516 | TOperator op, |
| 517 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 518 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 519 | bool constructingMatrix = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 520 | switch (op) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 521 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 522 | case EOpConstructMat2: |
| 523 | case EOpConstructMat2x3: |
| 524 | case EOpConstructMat2x4: |
| 525 | case EOpConstructMat3x2: |
| 526 | case EOpConstructMat3: |
| 527 | case EOpConstructMat3x4: |
| 528 | case EOpConstructMat4x2: |
| 529 | case EOpConstructMat4x3: |
| 530 | case EOpConstructMat4: |
| 531 | constructingMatrix = true; |
| 532 | break; |
| 533 | default: |
| 534 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 535 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 536 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 537 | // |
| 538 | // Note: It's okay to have too many components available, but not okay to have unused |
| 539 | // arguments. 'full' will go to true when enough args have been seen. If we loop |
| 540 | // again, there is an extra argument, so 'overfull' will become true. |
| 541 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 542 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 543 | size_t size = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 544 | bool full = false; |
| 545 | bool overFull = false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 546 | bool matrixInMatrix = false; |
| 547 | bool arrayArg = false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 548 | for (size_t i = 0; i < function.getParamCount(); ++i) |
| 549 | { |
Dmitry Skiba | efa3d8e | 2015-06-22 14:52:10 -0700 | [diff] [blame] | 550 | const TConstParameter ¶m = function.getParam(i); |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 551 | size += param.type->getObjectSize(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 552 | |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 553 | if (constructingMatrix && param.type->isMatrix()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 554 | matrixInMatrix = true; |
| 555 | if (full) |
| 556 | overFull = true; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 557 | if (op != EOpConstructStruct && !type.isArray() && size >= type.getObjectSize()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 558 | full = true; |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 559 | if (param.type->isArray()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 560 | arrayArg = true; |
| 561 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 562 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 563 | if (type.isArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 564 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 565 | // The size of an unsized constructor should already have been determined. |
| 566 | ASSERT(!type.isUnsizedArray()); |
| 567 | if (static_cast<size_t>(type.getArraySize()) != function.getParamCount()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 568 | { |
| 569 | error(line, "array constructor needs one argument per array element", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 570 | return false; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 571 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 572 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 573 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 574 | if (arrayArg && op != EOpConstructStruct) |
| 575 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 576 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 577 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 578 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 579 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 580 | if (matrixInMatrix && !type.isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 581 | { |
| 582 | if (function.getParamCount() != 1) |
| 583 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 584 | error(line, "constructing matrix from matrix can only take one argument", |
| 585 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 586 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 587 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 588 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 589 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 590 | if (overFull) |
| 591 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 592 | error(line, "too many arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 593 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 594 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 595 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 596 | if (op == EOpConstructStruct && !type.isArray() && |
| 597 | type.getStruct()->fields().size() != function.getParamCount()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 598 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 599 | error(line, |
| 600 | "Number of constructor parameters does not match the number of structure fields", |
| 601 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 602 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 603 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 604 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 605 | if (!type.isMatrix() || !matrixInMatrix) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 606 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 607 | if ((op != EOpConstructStruct && size != 1 && size < type.getObjectSize()) || |
| 608 | (op == EOpConstructStruct && size < type.getObjectSize())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 609 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 610 | error(line, "not enough data provided for construction", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 611 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 612 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 613 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 614 | |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 615 | if (argumentsNode == nullptr) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 616 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 617 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 618 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 619 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 620 | |
| 621 | TIntermAggregate *argumentsAgg = argumentsNode->getAsAggregate(); |
| 622 | for (TIntermNode *&argNode : *argumentsAgg->getSequence()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 623 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 624 | TIntermTyped *argTyped = argNode->getAsTyped(); |
| 625 | ASSERT(argTyped != nullptr); |
| 626 | if (op != EOpConstructStruct && IsSampler(argTyped->getBasicType())) |
| 627 | { |
| 628 | error(line, "cannot convert a sampler", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 629 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 630 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 631 | if (op != EOpConstructStruct && IsImage(argTyped->getBasicType())) |
| 632 | { |
| 633 | error(line, "cannot convert an image", "constructor"); |
| 634 | return false; |
| 635 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 636 | if (argTyped->getBasicType() == EbtVoid) |
| 637 | { |
| 638 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 639 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 640 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 641 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 642 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 643 | if (type.isArray()) |
| 644 | { |
| 645 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 646 | // the array. |
| 647 | for (TIntermNode *&argNode : *argumentsAgg->getSequence()) |
| 648 | { |
| 649 | const TType &argType = argNode->getAsTyped()->getType(); |
| 650 | // It has already been checked that the argument is not an array. |
| 651 | ASSERT(!argType.isArray()); |
| 652 | if (!argType.sameElementType(type)) |
| 653 | { |
| 654 | error(line, "Array constructor argument has an incorrect type", "Error"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 655 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 656 | } |
| 657 | } |
| 658 | } |
| 659 | else if (op == EOpConstructStruct) |
| 660 | { |
| 661 | const TFieldList &fields = type.getStruct()->fields(); |
| 662 | TIntermSequence *args = argumentsAgg->getSequence(); |
| 663 | |
| 664 | for (size_t i = 0; i < fields.size(); i++) |
| 665 | { |
| 666 | if (i >= args->size() || (*args)[i]->getAsTyped()->getType() != *fields[i]->type()) |
| 667 | { |
| 668 | error(line, "Structure constructor arguments do not match structure fields", |
| 669 | "Error"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 670 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 671 | } |
| 672 | } |
| 673 | } |
| 674 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 675 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 676 | } |
| 677 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 678 | // This function checks to see if a void variable has been declared and raise an error message for |
| 679 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 680 | // |
| 681 | // returns true in case of an error |
| 682 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 683 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 684 | const TString &identifier, |
| 685 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 686 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 687 | if (type == EbtVoid) |
| 688 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 689 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 690 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 691 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 692 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 693 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 694 | } |
| 695 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 696 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 697 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 698 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 699 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 700 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 701 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 702 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 703 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 704 | } |
| 705 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 706 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 707 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 708 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 709 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 710 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 711 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 712 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 713 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 714 | } |
| 715 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 716 | bool TParseContext::checkIsNotSampler(const TSourceLoc &line, |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 717 | const TTypeSpecifierNonArray &pType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 718 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 719 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 720 | if (pType.type == EbtStruct) |
| 721 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 722 | if (ContainsSampler(*pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 723 | { |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 724 | error(line, reason, getBasicString(pType.type), "(structure contains a sampler)"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 725 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 726 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 727 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 728 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 729 | } |
| 730 | else if (IsSampler(pType.type)) |
| 731 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 732 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 733 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 734 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 735 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 736 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 737 | } |
| 738 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 739 | bool TParseContext::checkIsNotImage(const TSourceLoc &line, |
| 740 | const TTypeSpecifierNonArray &pType, |
| 741 | const char *reason) |
| 742 | { |
| 743 | if (pType.type == EbtStruct) |
| 744 | { |
| 745 | if (ContainsImage(*pType.userDef)) |
| 746 | { |
| 747 | error(line, reason, getBasicString(pType.type), "(structure contains an image)"); |
| 748 | |
| 749 | return false; |
| 750 | } |
| 751 | |
| 752 | return true; |
| 753 | } |
| 754 | else if (IsImage(pType.type)) |
| 755 | { |
| 756 | error(line, reason, getBasicString(pType.type)); |
| 757 | |
| 758 | return false; |
| 759 | } |
| 760 | |
| 761 | return true; |
| 762 | } |
| 763 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 764 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 765 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 766 | { |
| 767 | if (pType.layoutQualifier.location != -1) |
| 768 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 769 | error(line, "location must only be specified for a single input or output variable", |
| 770 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 771 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 772 | } |
| 773 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 774 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 775 | const TLayoutQualifier &layoutQualifier) |
| 776 | { |
| 777 | if (layoutQualifier.location != -1) |
| 778 | { |
| 779 | error(location, "invalid layout qualifier:", "location", |
| 780 | "only valid on program inputs and outputs"); |
| 781 | } |
| 782 | } |
| 783 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 784 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 785 | TQualifier qualifier, |
| 786 | const TType &type) |
| 787 | { |
| 788 | checkOutParameterIsNotSampler(line, qualifier, type); |
| 789 | checkOutParameterIsNotImage(line, qualifier, type); |
| 790 | } |
| 791 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 792 | void TParseContext::checkOutParameterIsNotSampler(const TSourceLoc &line, |
| 793 | TQualifier qualifier, |
| 794 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 795 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 796 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
| 797 | if (IsSampler(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 798 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 799 | error(line, "samplers cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 800 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 801 | } |
| 802 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 803 | void TParseContext::checkOutParameterIsNotImage(const TSourceLoc &line, |
| 804 | TQualifier qualifier, |
| 805 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 806 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 807 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
| 808 | if (IsImage(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 809 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 810 | error(line, "images cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 811 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 812 | } |
| 813 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 814 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 815 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 816 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 817 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 818 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 819 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 820 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 821 | // fold as array size. |
| 822 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 823 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 824 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 825 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 826 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 827 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 828 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 829 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 830 | if (constant->getBasicType() == EbtUInt) |
| 831 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 832 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 833 | } |
| 834 | else |
| 835 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 836 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 837 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 838 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 839 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 840 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 841 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 842 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 843 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 844 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 845 | } |
| 846 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 847 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 848 | { |
| 849 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 850 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 851 | } |
| 852 | |
| 853 | // The size of arrays is restricted here to prevent issues further down the |
| 854 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 855 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 856 | const unsigned int sizeLimit = 65536; |
| 857 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 858 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 859 | { |
| 860 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 861 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 862 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 863 | |
| 864 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 865 | } |
| 866 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 867 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 868 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 869 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 870 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 871 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 872 | (elementQualifier.qualifier == EvqVertexIn) || |
| 873 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 874 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 875 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 876 | TType(elementQualifier).getQualifierString()); |
| 877 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 878 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 879 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 880 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 881 | } |
| 882 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 883 | // See if this element type can be formed into an array. |
| 884 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 885 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 886 | // |
| 887 | // Can the type be an array? |
| 888 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 889 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 890 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 891 | error(line, "cannot declare arrays of arrays", |
| 892 | TType(elementType).getCompleteString().c_str()); |
| 893 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 894 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 895 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 896 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 897 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 898 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 899 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 900 | { |
| 901 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 902 | TType(elementType).getCompleteString().c_str()); |
| 903 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 904 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 905 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 906 | return true; |
| 907 | } |
| 908 | |
| 909 | // Check if this qualified element type can be formed into an array. |
| 910 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 911 | const TPublicType &elementType) |
| 912 | { |
| 913 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 914 | { |
| 915 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 916 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 917 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 918 | } |
| 919 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 920 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 921 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 922 | const TString &identifier, |
| 923 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 924 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 925 | ASSERT(type != nullptr); |
| 926 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 927 | { |
| 928 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 929 | type->qualifier = EvqTemporary; |
| 930 | |
| 931 | // Generate informative error messages for ESSL1. |
| 932 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 933 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 934 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 935 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 936 | "structures containing arrays may not be declared constant since they cannot be " |
| 937 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 938 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 939 | } |
| 940 | else |
| 941 | { |
| 942 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 943 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 944 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 945 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 946 | if (type->isUnsizedArray()) |
| 947 | { |
| 948 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 949 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 950 | } |
| 951 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 952 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 953 | // and update the symbol table. |
| 954 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 955 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 956 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 957 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 958 | const TString &identifier, |
| 959 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 960 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 961 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 962 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 963 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 964 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 965 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 966 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 967 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 968 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 969 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 970 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 971 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 972 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 973 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 974 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 975 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 976 | } |
| 977 | } |
| 978 | else |
| 979 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 980 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 981 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 982 | return false; |
| 983 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 984 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 985 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 986 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 987 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 988 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 989 | (*variable) = new TVariable(&identifier, type); |
| 990 | if (!symbolTable.declare(*variable)) |
| 991 | { |
| 992 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 993 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 994 | return false; |
| 995 | } |
| 996 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 997 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 998 | return false; |
| 999 | |
| 1000 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1001 | } |
| 1002 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1003 | void TParseContext::checkIsParameterQualifierValid( |
| 1004 | const TSourceLoc &line, |
| 1005 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1006 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1007 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1008 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(&mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1009 | |
| 1010 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1011 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1012 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1013 | } |
| 1014 | |
| 1015 | if (!IsImage(type->getBasicType())) |
| 1016 | { |
| 1017 | checkIsMemoryQualifierNotSpecified(typeQualifier.memoryQualifier, line); |
| 1018 | } |
| 1019 | else |
| 1020 | { |
| 1021 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1022 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1023 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1024 | type->setQualifier(typeQualifier.qualifier); |
| 1025 | |
| 1026 | if (typeQualifier.precision != EbpUndefined) |
| 1027 | { |
| 1028 | type->setPrecision(typeQualifier.precision); |
| 1029 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1030 | } |
| 1031 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1032 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1033 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1034 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1035 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1036 | if (iter == extBehavior.end()) |
| 1037 | { |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1038 | error(line, "extension", extension.c_str(), "is not supported"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1039 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1040 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1041 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1042 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1043 | { |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1044 | error(line, "extension", extension.c_str(), "is disabled"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1045 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1046 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1047 | if (iter->second == EBhWarn) |
| 1048 | { |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1049 | warning(line, "extension", extension.c_str(), "is being used"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1050 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1051 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1052 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1053 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1054 | } |
| 1055 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1056 | // These checks are common for all declarations starting a declarator list, and declarators that |
| 1057 | // follow an empty declaration. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1058 | void TParseContext::singleDeclarationErrorCheck(const TPublicType &publicType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1059 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1060 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1061 | switch (publicType.qualifier) |
| 1062 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1063 | case EvqVaryingIn: |
| 1064 | case EvqVaryingOut: |
| 1065 | case EvqAttribute: |
| 1066 | case EvqVertexIn: |
| 1067 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1068 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1069 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1070 | { |
| 1071 | error(identifierLocation, "cannot be used with a structure", |
| 1072 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1073 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1074 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1075 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1076 | default: |
| 1077 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1078 | } |
| 1079 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1080 | if (publicType.qualifier != EvqUniform && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1081 | !checkIsNotSampler(identifierLocation, publicType.typeSpecifierNonArray, |
| 1082 | "samplers must be uniform")) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1083 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1084 | return; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1085 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1086 | if (publicType.qualifier != EvqUniform && |
| 1087 | !checkIsNotImage(identifierLocation, publicType.typeSpecifierNonArray, |
| 1088 | "images must be uniform")) |
| 1089 | { |
| 1090 | return; |
| 1091 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1092 | |
| 1093 | // check for layout qualifier issues |
| 1094 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
| 1095 | |
| 1096 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1097 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1098 | error(identifierLocation, "layout qualifier", |
| 1099 | getMatrixPackingString(layoutQualifier.matrixPacking), |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1100 | "only valid for interface blocks"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1101 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1102 | } |
| 1103 | |
| 1104 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1105 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1106 | error(identifierLocation, "layout qualifier", |
| 1107 | getBlockStorageString(layoutQualifier.blockStorage), |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1108 | "only valid for interface blocks"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1109 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1110 | } |
| 1111 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1112 | if (publicType.qualifier != EvqVertexIn && publicType.qualifier != EvqFragmentOut) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1113 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1114 | checkLocationIsNotSpecified(identifierLocation, publicType.layoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1115 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1116 | |
| 1117 | if (IsImage(publicType.getBasicType())) |
| 1118 | { |
| 1119 | |
| 1120 | switch (layoutQualifier.imageInternalFormat) |
| 1121 | { |
| 1122 | case EiifRGBA32F: |
| 1123 | case EiifRGBA16F: |
| 1124 | case EiifR32F: |
| 1125 | case EiifRGBA8: |
| 1126 | case EiifRGBA8_SNORM: |
| 1127 | if (!IsFloatImage(publicType.getBasicType())) |
| 1128 | { |
| 1129 | error(identifierLocation, |
| 1130 | "internal image format requires a floating image type", |
| 1131 | getBasicString(publicType.getBasicType())); |
| 1132 | return; |
| 1133 | } |
| 1134 | break; |
| 1135 | case EiifRGBA32I: |
| 1136 | case EiifRGBA16I: |
| 1137 | case EiifRGBA8I: |
| 1138 | case EiifR32I: |
| 1139 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1140 | { |
| 1141 | error(identifierLocation, |
| 1142 | "internal image format requires an integer image type", |
| 1143 | getBasicString(publicType.getBasicType())); |
| 1144 | return; |
| 1145 | } |
| 1146 | break; |
| 1147 | case EiifRGBA32UI: |
| 1148 | case EiifRGBA16UI: |
| 1149 | case EiifRGBA8UI: |
| 1150 | case EiifR32UI: |
| 1151 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1152 | { |
| 1153 | error(identifierLocation, |
| 1154 | "internal image format requires an unsigned image type", |
| 1155 | getBasicString(publicType.getBasicType())); |
| 1156 | return; |
| 1157 | } |
| 1158 | break; |
| 1159 | case EiifUnspecified: |
| 1160 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1161 | return; |
| 1162 | default: |
| 1163 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1164 | return; |
| 1165 | } |
| 1166 | |
| 1167 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1168 | switch (layoutQualifier.imageInternalFormat) |
| 1169 | { |
| 1170 | case EiifR32F: |
| 1171 | case EiifR32I: |
| 1172 | case EiifR32UI: |
| 1173 | break; |
| 1174 | default: |
| 1175 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1176 | { |
| 1177 | error(identifierLocation, "layout qualifier", |
| 1178 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1179 | "image variables must be qualified readonly and/or writeonly"); |
| 1180 | return; |
| 1181 | } |
| 1182 | break; |
| 1183 | } |
| 1184 | } |
| 1185 | else |
| 1186 | { |
| 1187 | |
| 1188 | if (!checkInternalFormatIsNotSpecified(identifierLocation, |
| 1189 | layoutQualifier.imageInternalFormat)) |
| 1190 | { |
| 1191 | return; |
| 1192 | } |
| 1193 | |
| 1194 | if (!checkIsMemoryQualifierNotSpecified(publicType.memoryQualifier, identifierLocation)) |
| 1195 | { |
| 1196 | return; |
| 1197 | } |
| 1198 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1199 | } |
| 1200 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1201 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1202 | const TString &layoutQualifierName, |
| 1203 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1204 | { |
| 1205 | |
| 1206 | if (mShaderVersion < versionRequired) |
| 1207 | { |
| 1208 | error(location, "invalid layout qualifier:", layoutQualifierName.c_str(), "not supported"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1209 | } |
| 1210 | } |
| 1211 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1212 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1213 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1214 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1215 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1216 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1217 | { |
| 1218 | if (localSize[i] != -1) |
| 1219 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1220 | error(location, "invalid layout qualifier:", getWorkGroupSizeString(i), |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1221 | "only valid when used with 'in' in a compute shader global layout declaration"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1222 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1223 | } |
| 1224 | } |
| 1225 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1226 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1227 | } |
| 1228 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1229 | bool TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
| 1230 | TLayoutImageInternalFormat internalFormat) |
| 1231 | { |
| 1232 | if (internalFormat != EiifUnspecified) |
| 1233 | { |
| 1234 | error(location, "invalid layout qualifier:", getImageInternalFormatString(internalFormat), |
| 1235 | "only valid when used with images"); |
| 1236 | return false; |
| 1237 | } |
| 1238 | return true; |
| 1239 | } |
| 1240 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1241 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1242 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1243 | { |
| 1244 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1245 | { |
| 1246 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1247 | if (qual == EvqOut || qual == EvqInOut) |
| 1248 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1249 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1250 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1251 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1252 | error(argument->getLine(), |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1253 | "Constant value cannot be passed for 'out' or 'inout' parameters.", "Error"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1254 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1255 | } |
| 1256 | } |
| 1257 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1258 | } |
| 1259 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1260 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1261 | const TQualifier qualifier, |
| 1262 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1263 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1264 | if (!invariant) |
| 1265 | return; |
| 1266 | |
| 1267 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1268 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1269 | // input variables in the fragment shader can be also qualified as invariant |
| 1270 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1271 | { |
| 1272 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1273 | } |
| 1274 | } |
| 1275 | else |
| 1276 | { |
| 1277 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1278 | { |
| 1279 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1280 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1281 | } |
| 1282 | } |
| 1283 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1284 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1285 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1286 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1287 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1288 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1289 | } |
| 1290 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1291 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1292 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1293 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1294 | } |
| 1295 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1296 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1297 | const char *extName, |
| 1298 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1299 | { |
| 1300 | pp::SourceLocation srcLoc; |
| 1301 | srcLoc.file = loc.first_file; |
| 1302 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1303 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1304 | } |
| 1305 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1306 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1307 | const char *name, |
| 1308 | const char *value, |
| 1309 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1310 | { |
| 1311 | pp::SourceLocation srcLoc; |
| 1312 | srcLoc.file = loc.first_file; |
| 1313 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1314 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1315 | } |
| 1316 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1317 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1318 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1319 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1320 | for (size_t i = 0u; i < result.size(); ++i) |
| 1321 | { |
| 1322 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1323 | { |
| 1324 | result[i] = 1; |
| 1325 | } |
| 1326 | else |
| 1327 | { |
| 1328 | result[i] = mComputeShaderLocalSize[i]; |
| 1329 | } |
| 1330 | } |
| 1331 | return result; |
| 1332 | } |
| 1333 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1334 | ///////////////////////////////////////////////////////////////////////////////// |
| 1335 | // |
| 1336 | // Non-Errors. |
| 1337 | // |
| 1338 | ///////////////////////////////////////////////////////////////////////////////// |
| 1339 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1340 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1341 | const TString *name, |
| 1342 | const TSymbol *symbol) |
| 1343 | { |
| 1344 | const TVariable *variable = NULL; |
| 1345 | |
| 1346 | if (!symbol) |
| 1347 | { |
| 1348 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1349 | } |
| 1350 | else if (!symbol->isVariable()) |
| 1351 | { |
| 1352 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1353 | } |
| 1354 | else |
| 1355 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1356 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1357 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1358 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1359 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1360 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1361 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1362 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1363 | |
| 1364 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1365 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1366 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1367 | { |
| 1368 | mUsesFragData = true; |
| 1369 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1370 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1371 | { |
| 1372 | mUsesFragColor = true; |
| 1373 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1374 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1375 | { |
| 1376 | mUsesSecondaryOutputs = true; |
| 1377 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1378 | |
| 1379 | // This validation is not quite correct - it's only an error to write to |
| 1380 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1381 | // be rewarded for reading from undefined varaibles, return an error |
| 1382 | // if they are both referenced, rather than assigned. |
| 1383 | if (mUsesFragData && mUsesFragColor) |
| 1384 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1385 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1386 | if (mUsesSecondaryOutputs) |
| 1387 | { |
| 1388 | errorMessage = |
| 1389 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1390 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1391 | } |
| 1392 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1393 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1394 | |
| 1395 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1396 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1397 | qualifier == EvqWorkGroupSize) |
| 1398 | { |
| 1399 | error(location, |
| 1400 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1401 | "gl_WorkGroupSize"); |
| 1402 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1403 | } |
| 1404 | |
| 1405 | if (!variable) |
| 1406 | { |
| 1407 | TType type(EbtFloat, EbpUndefined); |
| 1408 | TVariable *fakeVariable = new TVariable(name, type); |
| 1409 | symbolTable.declare(fakeVariable); |
| 1410 | variable = fakeVariable; |
| 1411 | } |
| 1412 | |
| 1413 | return variable; |
| 1414 | } |
| 1415 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1416 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1417 | const TString *name, |
| 1418 | const TSymbol *symbol) |
| 1419 | { |
| 1420 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1421 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1422 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1423 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1424 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1425 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1426 | } |
| 1427 | else |
| 1428 | { |
| 1429 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1430 | variable->getType(), location); |
| 1431 | } |
| 1432 | } |
| 1433 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1434 | // |
| 1435 | // Look up a function name in the symbol table, and make sure it is a function. |
| 1436 | // |
| 1437 | // Return the function symbol if found, otherwise 0. |
| 1438 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1439 | const TFunction *TParseContext::findFunction(const TSourceLoc &line, |
| 1440 | TFunction *call, |
| 1441 | int inputShaderVersion, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1442 | bool *builtIn) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1443 | { |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1444 | // First find by unmangled name to check whether the function name has been |
| 1445 | // hidden by a variable name or struct typename. |
Nicolas Capens | d4a9b8d | 2013-07-18 11:01:22 -0400 | [diff] [blame] | 1446 | // If a function is found, check for one with a matching argument list. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1447 | const TSymbol *symbol = symbolTable.find(call->getName(), inputShaderVersion, builtIn); |
| 1448 | if (symbol == 0 || symbol->isFunction()) |
| 1449 | { |
Austin Kinross | 3ae6465 | 2015-01-26 15:51:39 -0800 | [diff] [blame] | 1450 | symbol = symbolTable.find(call->getMangledName(), inputShaderVersion, builtIn); |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1451 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1452 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1453 | if (symbol == 0) |
| 1454 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1455 | error(line, "no matching overloaded function found", call->getName().c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1456 | return 0; |
| 1457 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1458 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1459 | if (!symbol->isFunction()) |
| 1460 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1461 | error(line, "function name expected", call->getName().c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1462 | return 0; |
| 1463 | } |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1464 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1465 | return static_cast<const TFunction *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1466 | } |
| 1467 | |
| 1468 | // |
| 1469 | // Initializers show up in several places in the grammar. Have one set of |
| 1470 | // code to handle them here. |
| 1471 | // |
Jamie Madill | 3b5c2da | 2014-08-19 15:23:32 -0400 | [diff] [blame] | 1472 | // Returns true on error, false if no error |
| 1473 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1474 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1475 | const TString &identifier, |
| 1476 | const TPublicType &pType, |
| 1477 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1478 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1479 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1480 | ASSERT(initNode != nullptr); |
| 1481 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1482 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1483 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1484 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1485 | if (type.isUnsizedArray()) |
| 1486 | { |
| 1487 | type.setArraySize(initializer->getArraySize()); |
| 1488 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1489 | if (!declareVariable(line, identifier, type, &variable)) |
| 1490 | { |
| 1491 | return true; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1492 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1493 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1494 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1495 | if (symbolTable.atGlobalLevel() && |
| 1496 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1497 | { |
| 1498 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1499 | // we want to steer developers towards only using constant expressions. |
| 1500 | error(line, "global variable initializers must be constant expressions", "="); |
| 1501 | return true; |
| 1502 | } |
| 1503 | if (globalInitWarning) |
| 1504 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1505 | warning( |
| 1506 | line, |
| 1507 | "global variable initializers should be constant expressions " |
| 1508 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1509 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1510 | } |
| 1511 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1512 | // |
| 1513 | // identifier must be of type constant, a global, or a temporary |
| 1514 | // |
| 1515 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1516 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1517 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1518 | error(line, " cannot initialize this type of qualifier ", |
| 1519 | variable->getType().getQualifierString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1520 | return true; |
| 1521 | } |
| 1522 | // |
| 1523 | // test for and propagate constant |
| 1524 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1525 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1526 | if (qualifier == EvqConst) |
| 1527 | { |
| 1528 | if (qualifier != initializer->getType().getQualifier()) |
| 1529 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1530 | std::stringstream extraInfoStream; |
| 1531 | extraInfoStream << "'" << variable->getType().getCompleteString() << "'"; |
| 1532 | std::string extraInfo = extraInfoStream.str(); |
| 1533 | error(line, " assigning non-constant to", "=", extraInfo.c_str()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1534 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1535 | return true; |
| 1536 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1537 | if (type != initializer->getType()) |
| 1538 | { |
| 1539 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1540 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1541 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1542 | return true; |
| 1543 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1544 | |
| 1545 | // Save the constant folded value to the variable if possible. For example array |
| 1546 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1547 | // in the shader is avoided. |
| 1548 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1549 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1550 | if (initializer->getAsConstantUnion()) |
| 1551 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1552 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1553 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1554 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1555 | } |
| 1556 | else if (initializer->getAsSymbolNode()) |
| 1557 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1558 | const TSymbol *symbol = |
| 1559 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1560 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1561 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1562 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1563 | if (constArray) |
| 1564 | { |
| 1565 | variable->shareConstPointer(constArray); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1566 | *initNode = nullptr; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1567 | return false; |
| 1568 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1569 | } |
| 1570 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1571 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1572 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1573 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1574 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1575 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1576 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1577 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
| 1578 | return true; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1579 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1580 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1581 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1582 | } |
| 1583 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 1584 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 1585 | { |
| 1586 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 1587 | typeSpecifier->getBasicType()); |
| 1588 | |
| 1589 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 1590 | { |
| 1591 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 1592 | typeSpecifier->clearArrayness(); |
| 1593 | } |
| 1594 | } |
| 1595 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1596 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1597 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1598 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1599 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1600 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1601 | TPublicType returnType = typeSpecifier; |
| 1602 | returnType.qualifier = typeQualifier.qualifier; |
| 1603 | returnType.invariant = typeQualifier.invariant; |
| 1604 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1605 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1606 | returnType.precision = typeSpecifier.precision; |
| 1607 | |
| 1608 | if (typeQualifier.precision != EbpUndefined) |
| 1609 | { |
| 1610 | returnType.precision = typeQualifier.precision; |
| 1611 | } |
| 1612 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1613 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1614 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1615 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1616 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1617 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1618 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1619 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1620 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1621 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1622 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1623 | if (typeSpecifier.array) |
| 1624 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1625 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1626 | returnType.clearArrayness(); |
| 1627 | } |
| 1628 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1629 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1630 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1631 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1632 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1633 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1634 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1635 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1636 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1637 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1638 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1639 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1640 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1641 | } |
| 1642 | } |
| 1643 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1644 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1645 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1646 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1647 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1648 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1649 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1650 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1651 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1652 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1653 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1654 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1655 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1656 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1657 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1658 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1659 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1660 | } |
| 1661 | |
| 1662 | return returnType; |
| 1663 | } |
| 1664 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1665 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 1666 | const TPublicType &type, |
| 1667 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1668 | { |
| 1669 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1670 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1671 | { |
| 1672 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1673 | } |
| 1674 | |
| 1675 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 1676 | switch (qualifier) |
| 1677 | { |
| 1678 | case EvqVertexIn: |
| 1679 | // ESSL 3.00 section 4.3.4 |
| 1680 | if (type.array) |
| 1681 | { |
| 1682 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1683 | } |
| 1684 | // Vertex inputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1685 | return; |
| 1686 | case EvqFragmentOut: |
| 1687 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1688 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1689 | { |
| 1690 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1691 | } |
| 1692 | // Fragment outputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1693 | return; |
| 1694 | default: |
| 1695 | break; |
| 1696 | } |
| 1697 | |
| 1698 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 1699 | // restrictions. |
| 1700 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1701 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 1702 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1703 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 1704 | { |
| 1705 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 1706 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1707 | } |
| 1708 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1709 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1710 | { |
| 1711 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 1712 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 1713 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 1714 | if (type.array) |
| 1715 | { |
| 1716 | error(qualifierLocation, "cannot be an array of structures", |
| 1717 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1718 | } |
| 1719 | if (type.isStructureContainingArrays()) |
| 1720 | { |
| 1721 | error(qualifierLocation, "cannot be a structure containing an array", |
| 1722 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1723 | } |
| 1724 | if (type.isStructureContainingType(EbtStruct)) |
| 1725 | { |
| 1726 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 1727 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1728 | } |
| 1729 | if (type.isStructureContainingType(EbtBool)) |
| 1730 | { |
| 1731 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 1732 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1733 | } |
| 1734 | } |
| 1735 | } |
| 1736 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1737 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 1738 | { |
| 1739 | if (qualifier.getType() == QtStorage) |
| 1740 | { |
| 1741 | const TStorageQualifierWrapper &storageQualifier = |
| 1742 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 1743 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 1744 | !symbolTable.atGlobalLevel()) |
| 1745 | { |
| 1746 | error(storageQualifier.getLine(), |
| 1747 | "Local variables can only use the const storage qualifier.", |
| 1748 | storageQualifier.getQualifierString().c_str()); |
| 1749 | } |
| 1750 | } |
| 1751 | } |
| 1752 | |
| 1753 | bool TParseContext::checkIsMemoryQualifierNotSpecified(const TMemoryQualifier &memoryQualifier, |
| 1754 | const TSourceLoc &location) |
| 1755 | { |
| 1756 | if (memoryQualifier.readonly) |
| 1757 | { |
| 1758 | error(location, "Only allowed with images.", "readonly"); |
| 1759 | return false; |
| 1760 | } |
| 1761 | if (memoryQualifier.writeonly) |
| 1762 | { |
| 1763 | error(location, "Only allowed with images.", "writeonly"); |
| 1764 | return false; |
| 1765 | } |
| 1766 | return true; |
| 1767 | } |
| 1768 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1769 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 1770 | TPublicType &publicType, |
| 1771 | const TSourceLoc &identifierOrTypeLocation, |
| 1772 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1773 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1774 | TType type(publicType); |
| 1775 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 1776 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 1777 | { |
| 1778 | TQualifier qualifier = type.getQualifier(); |
| 1779 | |
| 1780 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 1781 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 1782 | // affected variable declarations: |
| 1783 | // |
| 1784 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 1785 | // elsewhere, in TranslatorGLSL.) |
| 1786 | // |
| 1787 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 1788 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 1789 | // the way this is currently implemented we have to enable this compiler option before |
| 1790 | // parsing the shader and determining the shading language version it uses. If this were |
| 1791 | // implemented as a post-pass, the workaround could be more targeted. |
| 1792 | // |
| 1793 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 1794 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 1795 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 1796 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 1797 | { |
| 1798 | type.setInvariant(true); |
| 1799 | } |
| 1800 | } |
| 1801 | |
| 1802 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1803 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1804 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1805 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1806 | mDeferredSingleDeclarationErrorCheck = emptyDeclaration; |
| 1807 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1808 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1809 | declaration->setLine(identifierOrTypeLocation); |
| 1810 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1811 | if (emptyDeclaration) |
| 1812 | { |
| 1813 | if (publicType.isUnsizedArray()) |
| 1814 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1815 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1816 | // error. It is assumed that this applies to empty declarations as well. |
| 1817 | error(identifierOrTypeLocation, "empty array declaration needs to specify a size", |
| 1818 | identifier.c_str()); |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1819 | } |
| 1820 | } |
| 1821 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1822 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1823 | singleDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1824 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1825 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1826 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1827 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1828 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1829 | |
| 1830 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1831 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1832 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1833 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1834 | } |
| 1835 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1836 | // We append the symbol even if the declaration is empty, mainly because of struct declarations |
| 1837 | // that may just declare a type. |
| 1838 | declaration->appendDeclarator(symbol); |
| 1839 | |
| 1840 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1841 | } |
| 1842 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1843 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 1844 | const TSourceLoc &identifierLocation, |
| 1845 | const TString &identifier, |
| 1846 | const TSourceLoc &indexLocation, |
| 1847 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1848 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1849 | mDeferredSingleDeclarationErrorCheck = false; |
| 1850 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1851 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1852 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1853 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1854 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1855 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1856 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1857 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1858 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1859 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1860 | // Make the type an array even if size check failed. |
| 1861 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1862 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1863 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1864 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1865 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1866 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1867 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1868 | declaration->setLine(identifierLocation); |
| 1869 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1870 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1871 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1872 | { |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1873 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1874 | declaration->appendDeclarator(symbol); |
| 1875 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1876 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1877 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1878 | } |
| 1879 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1880 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 1881 | const TSourceLoc &identifierLocation, |
| 1882 | const TString &identifier, |
| 1883 | const TSourceLoc &initLocation, |
| 1884 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1885 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1886 | mDeferredSingleDeclarationErrorCheck = false; |
| 1887 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1888 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1889 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1890 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1891 | declaration->setLine(identifierLocation); |
| 1892 | |
| 1893 | TIntermBinary *initNode = nullptr; |
| 1894 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1895 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1896 | if (initNode) |
| 1897 | { |
| 1898 | declaration->appendDeclarator(initNode); |
| 1899 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1900 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1901 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1902 | } |
| 1903 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1904 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1905 | TPublicType &publicType, |
| 1906 | const TSourceLoc &identifierLocation, |
| 1907 | const TString &identifier, |
| 1908 | const TSourceLoc &indexLocation, |
| 1909 | TIntermTyped *indexExpression, |
| 1910 | const TSourceLoc &initLocation, |
| 1911 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1912 | { |
| 1913 | mDeferredSingleDeclarationErrorCheck = false; |
| 1914 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1915 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1916 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1917 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1918 | |
| 1919 | TPublicType arrayType(publicType); |
| 1920 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1921 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1922 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 1923 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1924 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1925 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1926 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1927 | } |
| 1928 | // Make the type an array even if size check failed. |
| 1929 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1930 | arrayType.setArraySize(size); |
| 1931 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1932 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1933 | declaration->setLine(identifierLocation); |
| 1934 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1935 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1936 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1937 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 1938 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1939 | if (initNode) |
| 1940 | { |
| 1941 | declaration->appendDeclarator(initNode); |
| 1942 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1943 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1944 | |
| 1945 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1946 | } |
| 1947 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1948 | TIntermAggregate *TParseContext::parseInvariantDeclaration( |
| 1949 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1950 | const TSourceLoc &identifierLoc, |
| 1951 | const TString *identifier, |
| 1952 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1953 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1954 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1955 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1956 | if (!typeQualifier.invariant) |
| 1957 | { |
| 1958 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 1959 | return nullptr; |
| 1960 | } |
| 1961 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 1962 | { |
| 1963 | return nullptr; |
| 1964 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1965 | if (!symbol) |
| 1966 | { |
| 1967 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1968 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1969 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1970 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1971 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1972 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 1973 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1974 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1975 | if (typeQualifier.precision != EbpUndefined) |
| 1976 | { |
| 1977 | error(identifierLoc, "invariant declaration specifies precision", |
| 1978 | getPrecisionString(typeQualifier.precision)); |
| 1979 | } |
| 1980 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 1981 | { |
| 1982 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 1983 | } |
| 1984 | |
| 1985 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 1986 | ASSERT(variable); |
| 1987 | const TType &type = variable->getType(); |
| 1988 | |
| 1989 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 1990 | typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1991 | checkIsMemoryQualifierNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1992 | |
| 1993 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 1994 | |
| 1995 | TIntermSymbol *intermSymbol = |
| 1996 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 1997 | |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1998 | TIntermAggregate *aggregate = TIntermediate::MakeAggregate(intermSymbol, identifierLoc); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1999 | aggregate->setOp(EOpInvariantDeclaration); |
| 2000 | return aggregate; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2001 | } |
| 2002 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2003 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2004 | const TSourceLoc &identifierLocation, |
| 2005 | const TString &identifier, |
| 2006 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2007 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2008 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2009 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2010 | if (mDeferredSingleDeclarationErrorCheck) |
| 2011 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2012 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2013 | mDeferredSingleDeclarationErrorCheck = false; |
| 2014 | } |
| 2015 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2016 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2017 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2018 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2019 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2020 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2021 | declareVariable(identifierLocation, identifier, TType(publicType), &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2022 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2023 | TIntermSymbol *symbol = |
| 2024 | intermediate.addSymbol(0, identifier, TType(publicType), identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2025 | if (variable && symbol) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2026 | { |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2027 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2028 | declarationOut->appendDeclarator(symbol); |
| 2029 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2030 | } |
| 2031 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2032 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2033 | const TSourceLoc &identifierLocation, |
| 2034 | const TString &identifier, |
| 2035 | const TSourceLoc &arrayLocation, |
| 2036 | TIntermTyped *indexExpression, |
| 2037 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2038 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2039 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2040 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2041 | if (mDeferredSingleDeclarationErrorCheck) |
| 2042 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2043 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2044 | mDeferredSingleDeclarationErrorCheck = false; |
| 2045 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2046 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2047 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2048 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2049 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2050 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2051 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2052 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2053 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2054 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 2055 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2056 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2057 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2058 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2059 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2060 | TIntermSymbol *symbol = |
| 2061 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2062 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2063 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2064 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2065 | declarationOut->appendDeclarator(symbol); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2066 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2067 | } |
| 2068 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2069 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2070 | const TSourceLoc &identifierLocation, |
| 2071 | const TString &identifier, |
| 2072 | const TSourceLoc &initLocation, |
| 2073 | TIntermTyped *initializer, |
| 2074 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2075 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2076 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2077 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2078 | if (mDeferredSingleDeclarationErrorCheck) |
| 2079 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2080 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2081 | mDeferredSingleDeclarationErrorCheck = false; |
| 2082 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2083 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2084 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2085 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2086 | TIntermBinary *initNode = nullptr; |
| 2087 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2088 | { |
| 2089 | // |
| 2090 | // build the intermediate representation |
| 2091 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2092 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2093 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2094 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2095 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2096 | } |
| 2097 | } |
| 2098 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2099 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2100 | const TSourceLoc &identifierLocation, |
| 2101 | const TString &identifier, |
| 2102 | const TSourceLoc &indexLocation, |
| 2103 | TIntermTyped *indexExpression, |
| 2104 | const TSourceLoc &initLocation, |
| 2105 | TIntermTyped *initializer, |
| 2106 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2107 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2108 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2109 | // not performed. |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2110 | if (mDeferredSingleDeclarationErrorCheck) |
| 2111 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2112 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2113 | mDeferredSingleDeclarationErrorCheck = false; |
| 2114 | } |
| 2115 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2116 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2117 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2118 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2119 | |
| 2120 | TPublicType arrayType(publicType); |
| 2121 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2122 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2123 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2124 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2125 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2126 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2127 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2128 | } |
| 2129 | // Make the type an array even if size check failed. |
| 2130 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2131 | arrayType.setArraySize(size); |
| 2132 | |
| 2133 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2134 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2135 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 2136 | { |
| 2137 | if (initNode) |
| 2138 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2139 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2140 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2141 | } |
| 2142 | } |
| 2143 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2144 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2145 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 2146 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2147 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2148 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2149 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2150 | typeQualifier.line); |
| 2151 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2152 | // It should never be the case, but some strange parser errors can send us here. |
| 2153 | if (layoutQualifier.isEmpty()) |
| 2154 | { |
| 2155 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2156 | return; |
| 2157 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2158 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2159 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2160 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2161 | error(typeQualifier.line, "invalid combination:", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2162 | return; |
| 2163 | } |
| 2164 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2165 | checkIsMemoryQualifierNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 2166 | |
| 2167 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2168 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2169 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2170 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2171 | if (mComputeShaderLocalSizeDeclared && |
| 2172 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2173 | { |
| 2174 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2175 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2176 | return; |
| 2177 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2178 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2179 | if (mShaderVersion < 310) |
| 2180 | { |
| 2181 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2182 | return; |
| 2183 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2184 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2185 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2186 | { |
| 2187 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2188 | return; |
| 2189 | } |
| 2190 | |
| 2191 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2192 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2193 | |
| 2194 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2195 | maxComputeWorkGroupSize->getConstPointer(); |
| 2196 | |
| 2197 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2198 | { |
| 2199 | if (layoutQualifier.localSize[i] != -1) |
| 2200 | { |
| 2201 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2202 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2203 | if (mComputeShaderLocalSize[i] < 1 || |
| 2204 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2205 | { |
| 2206 | std::stringstream errorMessageStream; |
| 2207 | errorMessageStream << "Value must be at least 1 and no greater than " |
| 2208 | << maxComputeWorkGroupSizeValue; |
| 2209 | const std::string &errorMessage = errorMessageStream.str(); |
| 2210 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2211 | error(typeQualifier.line, "invalid value:", getWorkGroupSizeString(i), |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2212 | errorMessage.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2213 | return; |
| 2214 | } |
| 2215 | } |
| 2216 | } |
| 2217 | |
| 2218 | mComputeShaderLocalSizeDeclared = true; |
| 2219 | } |
| 2220 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2221 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2222 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2223 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2224 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2225 | return; |
| 2226 | } |
| 2227 | |
| 2228 | if (typeQualifier.qualifier != EvqUniform) |
| 2229 | { |
| 2230 | error(typeQualifier.line, "invalid qualifier:", |
| 2231 | getQualifierString(typeQualifier.qualifier), "global layout must be uniform"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2232 | return; |
| 2233 | } |
| 2234 | |
| 2235 | if (mShaderVersion < 300) |
| 2236 | { |
| 2237 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2238 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2239 | return; |
| 2240 | } |
| 2241 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2242 | checkLocationIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2243 | |
| 2244 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 2245 | { |
| 2246 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2247 | } |
| 2248 | |
| 2249 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2250 | { |
| 2251 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2252 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2253 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2254 | } |
| 2255 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2256 | TIntermAggregate *TParseContext::addFunctionPrototypeDeclaration(const TFunction &parsedFunction, |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2257 | const TSourceLoc &location) |
| 2258 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2259 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 2260 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 2261 | // function is declared multiple times. |
| 2262 | TFunction *function = static_cast<TFunction *>( |
| 2263 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 2264 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2265 | { |
| 2266 | // ESSL 1.00.17 section 4.2.7. |
| 2267 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2268 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2269 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2270 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2271 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2272 | TIntermAggregate *prototype = new TIntermAggregate; |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2273 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 2274 | // point to the data that already exists in the symbol table. |
| 2275 | prototype->setType(function->getReturnType()); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 2276 | prototype->getFunctionSymbolInfo()->setFromFunction(*function); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2277 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2278 | for (size_t i = 0; i < function->getParamCount(); i++) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2279 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2280 | const TConstParameter ¶m = function->getParam(i); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2281 | if (param.name != 0) |
| 2282 | { |
| 2283 | TVariable variable(param.name, *param.type); |
| 2284 | |
| 2285 | TIntermSymbol *paramSymbol = intermediate.addSymbol( |
| 2286 | variable.getUniqueId(), variable.getName(), variable.getType(), location); |
| 2287 | prototype = intermediate.growAggregate(prototype, paramSymbol, location); |
| 2288 | } |
| 2289 | else |
| 2290 | { |
| 2291 | TIntermSymbol *paramSymbol = intermediate.addSymbol(0, "", *param.type, location); |
| 2292 | prototype = intermediate.growAggregate(prototype, paramSymbol, location); |
| 2293 | } |
| 2294 | } |
| 2295 | |
| 2296 | prototype->setOp(EOpPrototype); |
| 2297 | |
| 2298 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2299 | |
| 2300 | if (!symbolTable.atGlobalLevel()) |
| 2301 | { |
| 2302 | // ESSL 3.00.4 section 4.2.4. |
| 2303 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2304 | } |
| 2305 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2306 | return prototype; |
| 2307 | } |
| 2308 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2309 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
| 2310 | const TFunction &function, |
| 2311 | TIntermAggregate *functionParameters, |
| 2312 | TIntermBlock *functionBody, |
| 2313 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2314 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2315 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2316 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2317 | { |
| 2318 | error(location, "function does not return a value:", "", function.getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2319 | } |
| 2320 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2321 | if (functionBody == nullptr) |
| 2322 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2323 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2324 | functionBody->setLine(location); |
| 2325 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 2326 | TIntermFunctionDefinition *functionNode = |
| 2327 | new TIntermFunctionDefinition(function.getReturnType(), functionParameters, functionBody); |
| 2328 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2329 | |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 2330 | functionNode->getFunctionSymbolInfo()->setFromFunction(function); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2331 | |
| 2332 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2333 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2334 | } |
| 2335 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2336 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 2337 | TFunction **function, |
| 2338 | TIntermAggregate **aggregateOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2339 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2340 | ASSERT(function); |
| 2341 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2342 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2343 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2344 | |
| 2345 | if (builtIn) |
| 2346 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2347 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2348 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2349 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2350 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2351 | TFunction *prevDec = static_cast<TFunction *>( |
| 2352 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 2353 | |
| 2354 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 2355 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 2356 | // occurance. |
| 2357 | if (*function != prevDec) |
| 2358 | { |
| 2359 | // Swap the parameters of the previous declaration to the parameters of the function |
| 2360 | // definition (parameter names may differ). |
| 2361 | prevDec->swapParameters(**function); |
| 2362 | |
| 2363 | // The function definition will share the same symbol as any previous declaration. |
| 2364 | *function = prevDec; |
| 2365 | } |
| 2366 | |
| 2367 | if ((*function)->isDefined()) |
| 2368 | { |
| 2369 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 2370 | } |
| 2371 | |
| 2372 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2373 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2374 | |
| 2375 | // Raise error message if main function takes any parameters or return anything other than void |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2376 | if ((*function)->getName() == "main") |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2377 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2378 | if ((*function)->getParamCount() > 0) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2379 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2380 | error(location, "function cannot take any parameter(s)", |
| 2381 | (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2382 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2383 | if ((*function)->getReturnType().getBasicType() != EbtVoid) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2384 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2385 | error(location, "", (*function)->getReturnType().getBasicString(), |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2386 | "main function cannot return a value"); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2387 | } |
| 2388 | } |
| 2389 | |
| 2390 | // |
| 2391 | // Remember the return type for later checking for RETURN statements. |
| 2392 | // |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2393 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2394 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2395 | |
| 2396 | // |
| 2397 | // Insert parameters into the symbol table. |
| 2398 | // If the parameter has no name, it's not an error, just don't insert it |
| 2399 | // (could be used for unused args). |
| 2400 | // |
| 2401 | // Also, accumulate the list of parameters into the HIL, so lower level code |
| 2402 | // knows where to find parameters. |
| 2403 | // |
| 2404 | TIntermAggregate *paramNodes = new TIntermAggregate; |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2405 | for (size_t i = 0; i < (*function)->getParamCount(); i++) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2406 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2407 | const TConstParameter ¶m = (*function)->getParam(i); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2408 | if (param.name != 0) |
| 2409 | { |
| 2410 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2411 | // |
| 2412 | // Insert the parameters with name in the symbol table. |
| 2413 | // |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 2414 | if (!symbolTable.declare(variable)) |
| 2415 | { |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2416 | error(location, "redefinition", variable->getName().c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 2417 | paramNodes = intermediate.growAggregate( |
| 2418 | paramNodes, intermediate.addSymbol(0, "", *param.type, location), location); |
| 2419 | continue; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2420 | } |
| 2421 | |
| 2422 | // |
| 2423 | // Add the parameter to the HIL |
| 2424 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2425 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2426 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2427 | |
| 2428 | paramNodes = intermediate.growAggregate(paramNodes, symbol, location); |
| 2429 | } |
| 2430 | else |
| 2431 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2432 | paramNodes = intermediate.growAggregate( |
| 2433 | paramNodes, intermediate.addSymbol(0, "", *param.type, location), location); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2434 | } |
| 2435 | } |
| 2436 | intermediate.setAggregateOperator(paramNodes, EOpParameters, location); |
| 2437 | *aggregateOut = paramNodes; |
| 2438 | setLoopNestingLevel(0); |
| 2439 | } |
| 2440 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2441 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2442 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2443 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2444 | // We don't know at this point whether this is a function definition or a prototype. |
| 2445 | // The definition production code will check for redefinitions. |
| 2446 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2447 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2448 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2449 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2450 | // |
| 2451 | TFunction *prevDec = |
| 2452 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2453 | |
| 2454 | if (getShaderVersion() >= 300 && symbolTable.hasUnmangledBuiltIn(function->getName().c_str())) |
| 2455 | { |
| 2456 | // With ESSL 3.00, names of built-in functions cannot be redeclared as functions. |
| 2457 | // Therefore overloading or redefining builtin functions is an error. |
| 2458 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2459 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2460 | } |
| 2461 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2462 | { |
| 2463 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2464 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2465 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2466 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2467 | } |
| 2468 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2469 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2470 | if (prevDec->getParam(i).type->getQualifier() != |
| 2471 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2472 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2473 | error(location, |
| 2474 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2475 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2476 | } |
| 2477 | } |
| 2478 | } |
| 2479 | |
| 2480 | // |
| 2481 | // Check for previously declared variables using the same name. |
| 2482 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2483 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2484 | if (prevSym) |
| 2485 | { |
| 2486 | if (!prevSym->isFunction()) |
| 2487 | { |
| 2488 | error(location, "redefinition", function->getName().c_str(), "function"); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2489 | } |
| 2490 | } |
| 2491 | else |
| 2492 | { |
| 2493 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 2494 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2495 | } |
| 2496 | |
| 2497 | // We're at the inner scope level of the function's arguments and body statement. |
| 2498 | // Add the function prototype to the surrounding scope instead. |
| 2499 | symbolTable.getOuterLevel()->insert(function); |
| 2500 | |
| 2501 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2502 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2503 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2504 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2505 | // |
| 2506 | return function; |
| 2507 | } |
| 2508 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2509 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2510 | const TString *name, |
| 2511 | const TSourceLoc &location) |
| 2512 | { |
| 2513 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2514 | { |
| 2515 | error(location, "no qualifiers allowed for function return", |
| 2516 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2517 | } |
| 2518 | if (!type.layoutQualifier.isEmpty()) |
| 2519 | { |
| 2520 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2521 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2522 | // make sure a sampler or an image is not involved as well... |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2523 | checkIsNotSampler(location, type.typeSpecifierNonArray, |
| 2524 | "samplers can't be function return values"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2525 | checkIsNotImage(location, type.typeSpecifierNonArray, "images can't be function return values"); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2526 | if (mShaderVersion < 300) |
| 2527 | { |
| 2528 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2529 | // return values in ESSL 1.00. |
| 2530 | ASSERT(type.arraySize == 0 || mDiagnostics.numErrors() > 0); |
| 2531 | |
| 2532 | if (type.isStructureContainingArrays()) |
| 2533 | { |
| 2534 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2535 | error(location, "structures containing arrays can't be function return values", |
| 2536 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2537 | } |
| 2538 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2539 | |
| 2540 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2541 | return new TFunction(name, new TType(type)); |
| 2542 | } |
| 2543 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2544 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicTypeIn) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2545 | { |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2546 | TPublicType publicType = publicTypeIn; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2547 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2548 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2549 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 2550 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2551 | } |
| 2552 | |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2553 | TOperator op = EOpNull; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2554 | if (publicType.getUserDef()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2555 | { |
| 2556 | op = EOpConstructStruct; |
| 2557 | } |
| 2558 | else |
| 2559 | { |
Geoff Lang | 156d719 | 2016-07-21 16:11:00 -0400 | [diff] [blame] | 2560 | op = sh::TypeToConstructorOperator(TType(publicType)); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2561 | if (op == EOpNull) |
| 2562 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2563 | error(publicType.getLine(), "cannot construct this type", |
| 2564 | getBasicString(publicType.getBasicType())); |
| 2565 | publicType.setBasicType(EbtFloat); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2566 | op = EOpConstructFloat; |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2567 | } |
| 2568 | } |
| 2569 | |
| 2570 | TString tempString; |
Dmitry Skiba | 7f17a50 | 2015-06-22 15:08:39 -0700 | [diff] [blame] | 2571 | const TType *type = new TType(publicType); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2572 | return new TFunction(&tempString, type, op); |
| 2573 | } |
| 2574 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2575 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 2576 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2577 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2578 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2579 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2580 | TIntermTyped *TParseContext::addConstructor(TIntermNode *arguments, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2581 | TOperator op, |
| 2582 | TFunction *fnCall, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2583 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2584 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2585 | TType type = fnCall->getReturnType(); |
| 2586 | if (type.isUnsizedArray()) |
| 2587 | { |
| 2588 | type.setArraySize(static_cast<unsigned int>(fnCall->getParamCount())); |
| 2589 | } |
| 2590 | bool constType = true; |
| 2591 | for (size_t i = 0; i < fnCall->getParamCount(); ++i) |
| 2592 | { |
| 2593 | const TConstParameter ¶m = fnCall->getParam(i); |
| 2594 | if (param.type->getQualifier() != EvqConst) |
| 2595 | constType = false; |
| 2596 | } |
| 2597 | if (constType) |
| 2598 | type.setQualifier(EvqConst); |
| 2599 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2600 | if (!checkConstructorArguments(line, arguments, *fnCall, op, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2601 | { |
| 2602 | TIntermTyped *dummyNode = intermediate.setAggregateOperator(nullptr, op, line); |
| 2603 | dummyNode->setType(type); |
| 2604 | return dummyNode; |
| 2605 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 2606 | TIntermAggregate *constructor = arguments->getAsAggregate(); |
| 2607 | ASSERT(constructor != nullptr); |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2608 | |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2609 | // Turn the argument list itself into a constructor |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 2610 | constructor->setOp(op); |
| 2611 | constructor->setLine(line); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2612 | ASSERT(constructor->isConstructor()); |
| 2613 | |
| 2614 | // Need to set type before setPrecisionFromChildren() because bool doesn't have precision. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2615 | constructor->setType(type); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2616 | |
Olli Etuaho | 2120370 | 2014-11-13 16:16:21 +0200 | [diff] [blame] | 2617 | // Structs should not be precision qualified, the individual members may be. |
| 2618 | // Built-in types on the other hand should be precision qualified. |
| 2619 | if (op != EOpConstructStruct) |
| 2620 | { |
| 2621 | constructor->setPrecisionFromChildren(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2622 | type.setPrecision(constructor->getPrecision()); |
Olli Etuaho | 2120370 | 2014-11-13 16:16:21 +0200 | [diff] [blame] | 2623 | } |
| 2624 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2625 | constructor->setType(type); |
| 2626 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 2627 | TIntermTyped *constConstructor = intermediate.foldAggregateBuiltIn(constructor, &mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2628 | if (constConstructor) |
| 2629 | { |
| 2630 | return constConstructor; |
| 2631 | } |
| 2632 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 2633 | return constructor; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2634 | } |
| 2635 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2636 | // |
| 2637 | // Interface/uniform blocks |
| 2638 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2639 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2640 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2641 | const TSourceLoc &nameLine, |
| 2642 | const TString &blockName, |
| 2643 | TFieldList *fieldList, |
| 2644 | const TString *instanceName, |
| 2645 | const TSourceLoc &instanceLine, |
| 2646 | TIntermTyped *arrayIndex, |
| 2647 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2648 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2649 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2650 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 2651 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2652 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2653 | if (typeQualifier.qualifier != EvqUniform) |
| 2654 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2655 | error(typeQualifier.line, "invalid qualifier:", getQualifierString(typeQualifier.qualifier), |
| 2656 | "interface blocks must be uniform"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2657 | } |
| 2658 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2659 | if (typeQualifier.invariant) |
| 2660 | { |
| 2661 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 2662 | } |
| 2663 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2664 | checkIsMemoryQualifierNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 2665 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2666 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2667 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2668 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2669 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 2670 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2671 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2672 | } |
| 2673 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2674 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 2675 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2676 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2677 | } |
| 2678 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2679 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2680 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2681 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 2682 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2683 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 2684 | if (!symbolTable.declare(blockNameSymbol)) |
| 2685 | { |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2686 | error(nameLine, "redefinition", blockName.c_str(), "interface block name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2687 | } |
| 2688 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2689 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2690 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2691 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2692 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2693 | TType *fieldType = field->type(); |
| 2694 | if (IsSampler(fieldType->getBasicType())) |
| 2695 | { |
| 2696 | error(field->line(), "unsupported type", fieldType->getBasicString(), |
| 2697 | "sampler types are not allowed in interface blocks"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2698 | } |
| 2699 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2700 | if (IsImage(fieldType->getBasicType())) |
| 2701 | { |
| 2702 | error(field->line(), "unsupported type", fieldType->getBasicString(), |
| 2703 | "image types are not allowed in interface blocks"); |
| 2704 | } |
| 2705 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2706 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2707 | switch (qualifier) |
| 2708 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2709 | case EvqGlobal: |
| 2710 | case EvqUniform: |
| 2711 | break; |
| 2712 | default: |
| 2713 | error(field->line(), "invalid qualifier on interface block member", |
| 2714 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2715 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2716 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2717 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2718 | if (fieldType->isInvariant()) |
| 2719 | { |
| 2720 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 2721 | } |
| 2722 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2723 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2724 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2725 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2726 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2727 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2728 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2729 | error(field->line(), "invalid layout qualifier:", |
| 2730 | getBlockStorageString(fieldLayoutQualifier.blockStorage), "cannot be used here"); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2731 | } |
| 2732 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2733 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2734 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2735 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2736 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2737 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2738 | { |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2739 | warning(field->line(), "extraneous layout qualifier:", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2740 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking), |
| 2741 | "only has an effect on matrix types"); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2742 | } |
| 2743 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2744 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2745 | } |
| 2746 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2747 | // add array index |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2748 | unsigned int arraySize = 0; |
| 2749 | if (arrayIndex != nullptr) |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2750 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2751 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2752 | } |
| 2753 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2754 | TInterfaceBlock *interfaceBlock = |
| 2755 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 2756 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 2757 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2758 | |
| 2759 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2760 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2761 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2762 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2763 | { |
| 2764 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2765 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2766 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2767 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2768 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2769 | |
| 2770 | // set parent pointer of the field variable |
| 2771 | fieldType->setInterfaceBlock(interfaceBlock); |
| 2772 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2773 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2774 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 2775 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2776 | if (!symbolTable.declare(fieldVariable)) |
| 2777 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2778 | error(field->line(), "redefinition", field->name().c_str(), |
| 2779 | "interface block member name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2780 | } |
| 2781 | } |
| 2782 | } |
| 2783 | else |
| 2784 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2785 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 2786 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2787 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2788 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2789 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2790 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2791 | if (!symbolTable.declare(instanceTypeDef)) |
| 2792 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2793 | error(instanceLine, "redefinition", instanceName->c_str(), |
| 2794 | "interface block instance name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2795 | } |
| 2796 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2797 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2798 | symbolName = instanceTypeDef->getName(); |
| 2799 | } |
| 2800 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2801 | TIntermSymbol *blockSymbol = |
| 2802 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line); |
| 2803 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2804 | declaration->appendDeclarator(blockSymbol); |
| 2805 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2806 | |
| 2807 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2808 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2809 | } |
| 2810 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2811 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2812 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2813 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2814 | |
| 2815 | // Embedded structure definitions are not supported per GLSL ES spec. |
| 2816 | // They aren't allowed in GLSL either, but we need to detect this here |
| 2817 | // so we don't rely on the GLSL compiler to catch it. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2818 | if (mStructNestingLevel > 1) |
| 2819 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 2820 | error(line, "", "Embedded struct definitions are not allowed"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2821 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2822 | } |
| 2823 | |
| 2824 | void TParseContext::exitStructDeclaration() |
| 2825 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2826 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2827 | } |
| 2828 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2829 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2830 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2831 | if (!IsWebGLBasedSpec(mShaderSpec)) |
| 2832 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2833 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2834 | } |
| 2835 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2836 | if (field.type()->getBasicType() != EbtStruct) |
| 2837 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2838 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2839 | } |
| 2840 | |
| 2841 | // We're already inside a structure definition at this point, so add |
| 2842 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2843 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 2844 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2845 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2846 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 2847 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2848 | std::string reason = reasonStream.str(); |
| 2849 | error(line, reason.c_str(), field.name().c_str(), ""); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2850 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2851 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2852 | } |
| 2853 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 2854 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2855 | // Parse an array index expression |
| 2856 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2857 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 2858 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2859 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2860 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2861 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 2862 | { |
| 2863 | if (baseExpression->getAsSymbolNode()) |
| 2864 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2865 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 2866 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2867 | } |
| 2868 | else |
| 2869 | { |
| 2870 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 2871 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2872 | |
| 2873 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 2874 | unionArray->setFConst(0.0f); |
| 2875 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 2876 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2877 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 2878 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 2879 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 2880 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2881 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 2882 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 2883 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 2884 | // index is a constant expression. |
| 2885 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 2886 | { |
| 2887 | if (baseExpression->isInterfaceBlock()) |
| 2888 | { |
| 2889 | error( |
| 2890 | location, "", "[", |
| 2891 | "array indexes for interface blocks arrays must be constant integral expressions"); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2892 | } |
| 2893 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 2894 | { |
| 2895 | error(location, "", "[", |
| 2896 | "array indexes for fragment outputs must be constant integral expressions"); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2897 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 2898 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 2899 | { |
| 2900 | error(location, "", "[", "array index for gl_FragData must be constant zero"); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 2901 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2902 | } |
| 2903 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2904 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2905 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2906 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 2907 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 2908 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 2909 | // handle this case is to report a warning instead of an error and force the index to be in |
| 2910 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2911 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 2912 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2913 | |
| 2914 | int safeIndex = -1; |
| 2915 | |
| 2916 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2917 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2918 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2919 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2920 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 2921 | { |
| 2922 | // Error has been already generated if index is not const. |
| 2923 | if (indexExpression->getQualifier() == EvqConst) |
| 2924 | { |
| 2925 | error(location, "", "[", |
| 2926 | "array index for gl_FragData must be constant zero"); |
| 2927 | } |
| 2928 | safeIndex = 0; |
| 2929 | } |
| 2930 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 2931 | { |
| 2932 | outOfRangeError(outOfRangeIndexIsError, location, "", "[", |
| 2933 | "array index for gl_FragData must be zero when " |
| 2934 | "GL_EXT_draw_buffers is disabled"); |
| 2935 | safeIndex = 0; |
| 2936 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2937 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2938 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 2939 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2940 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2941 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 2942 | baseExpression->getArraySize(), |
| 2943 | "array index out of range", "[]"); |
| 2944 | } |
| 2945 | } |
| 2946 | else if (baseExpression->isMatrix()) |
| 2947 | { |
| 2948 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2949 | baseExpression->getType().getCols(), |
| 2950 | "matrix field selection out of range", "[]"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2951 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2952 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2953 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2954 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 2955 | baseExpression->getType().getNominalSize(), |
| 2956 | "vector field selection out of range", "[]"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2957 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2958 | |
| 2959 | ASSERT(safeIndex >= 0); |
| 2960 | // Data of constant unions can't be changed, because it may be shared with other |
| 2961 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 2962 | // sanitized object. |
| 2963 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2964 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2965 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 2966 | safeConstantUnion->setIConst(safeIndex); |
| 2967 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2968 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2969 | |
| 2970 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
| 2971 | &mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2972 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2973 | else |
| 2974 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2975 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
| 2976 | &mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2977 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2978 | } |
| 2979 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2980 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 2981 | const TSourceLoc &location, |
| 2982 | int index, |
| 2983 | int arraySize, |
| 2984 | const char *reason, |
| 2985 | const char *token) |
| 2986 | { |
| 2987 | if (index >= arraySize || index < 0) |
| 2988 | { |
| 2989 | std::stringstream extraInfoStream; |
| 2990 | extraInfoStream << "'" << index << "'"; |
| 2991 | std::string extraInfo = extraInfoStream.str(); |
| 2992 | outOfRangeError(outOfRangeIndexIsError, location, reason, token, extraInfo.c_str()); |
| 2993 | if (index < 0) |
| 2994 | { |
| 2995 | return 0; |
| 2996 | } |
| 2997 | else |
| 2998 | { |
| 2999 | return arraySize - 1; |
| 3000 | } |
| 3001 | } |
| 3002 | return index; |
| 3003 | } |
| 3004 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3005 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3006 | const TSourceLoc &dotLocation, |
| 3007 | const TString &fieldString, |
| 3008 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3009 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3010 | if (baseExpression->isArray()) |
| 3011 | { |
| 3012 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3013 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3014 | } |
| 3015 | |
| 3016 | if (baseExpression->isVector()) |
| 3017 | { |
| 3018 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3019 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 3020 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3021 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3022 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3023 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3024 | } |
| 3025 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 3026 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3027 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3028 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3029 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3030 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3031 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3032 | { |
| 3033 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3034 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3035 | } |
| 3036 | else |
| 3037 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3038 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3039 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3040 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3041 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3042 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3043 | { |
| 3044 | fieldFound = true; |
| 3045 | break; |
| 3046 | } |
| 3047 | } |
| 3048 | if (fieldFound) |
| 3049 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3050 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3051 | index->setLine(fieldLocation); |
| 3052 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
| 3053 | dotLocation, &mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3054 | } |
| 3055 | else |
| 3056 | { |
| 3057 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3058 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3059 | } |
| 3060 | } |
| 3061 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3062 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3063 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3064 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3065 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3066 | { |
| 3067 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3068 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3069 | } |
| 3070 | else |
| 3071 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3072 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3073 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3074 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3075 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3076 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3077 | { |
| 3078 | fieldFound = true; |
| 3079 | break; |
| 3080 | } |
| 3081 | } |
| 3082 | if (fieldFound) |
| 3083 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3084 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 3085 | index->setLine(fieldLocation); |
| 3086 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
| 3087 | dotLocation, &mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3088 | } |
| 3089 | else |
| 3090 | { |
| 3091 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3092 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3093 | } |
| 3094 | } |
| 3095 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3096 | else |
| 3097 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3098 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3099 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3100 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3101 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3102 | } |
| 3103 | else |
| 3104 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3105 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 3106 | " field selection requires structure, vector, or interface block on left hand " |
| 3107 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3108 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3109 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3110 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3111 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3112 | } |
| 3113 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3114 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3115 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3116 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3117 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3118 | |
| 3119 | if (qualifierType == "shared") |
| 3120 | { |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3121 | if (IsWebGLBasedSpec(mShaderSpec)) |
| 3122 | { |
| 3123 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 3124 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3125 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3126 | } |
| 3127 | else if (qualifierType == "packed") |
| 3128 | { |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 3129 | if (IsWebGLBasedSpec(mShaderSpec)) |
| 3130 | { |
| 3131 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 3132 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3133 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3134 | } |
| 3135 | else if (qualifierType == "std140") |
| 3136 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3137 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3138 | } |
| 3139 | else if (qualifierType == "row_major") |
| 3140 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3141 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3142 | } |
| 3143 | else if (qualifierType == "column_major") |
| 3144 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3145 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3146 | } |
| 3147 | else if (qualifierType == "location") |
| 3148 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3149 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str(), |
| 3150 | "location requires an argument"); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3151 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3152 | else if (qualifierType == "rgba32f") |
| 3153 | { |
| 3154 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3155 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 3156 | } |
| 3157 | else if (qualifierType == "rgba16f") |
| 3158 | { |
| 3159 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3160 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 3161 | } |
| 3162 | else if (qualifierType == "r32f") |
| 3163 | { |
| 3164 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3165 | qualifier.imageInternalFormat = EiifR32F; |
| 3166 | } |
| 3167 | else if (qualifierType == "rgba8") |
| 3168 | { |
| 3169 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3170 | qualifier.imageInternalFormat = EiifRGBA8; |
| 3171 | } |
| 3172 | else if (qualifierType == "rgba8_snorm") |
| 3173 | { |
| 3174 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3175 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 3176 | } |
| 3177 | else if (qualifierType == "rgba32i") |
| 3178 | { |
| 3179 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3180 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 3181 | } |
| 3182 | else if (qualifierType == "rgba16i") |
| 3183 | { |
| 3184 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3185 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 3186 | } |
| 3187 | else if (qualifierType == "rgba8i") |
| 3188 | { |
| 3189 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3190 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 3191 | } |
| 3192 | else if (qualifierType == "r32i") |
| 3193 | { |
| 3194 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3195 | qualifier.imageInternalFormat = EiifR32I; |
| 3196 | } |
| 3197 | else if (qualifierType == "rgba32ui") |
| 3198 | { |
| 3199 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3200 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 3201 | } |
| 3202 | else if (qualifierType == "rgba16ui") |
| 3203 | { |
| 3204 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3205 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 3206 | } |
| 3207 | else if (qualifierType == "rgba8ui") |
| 3208 | { |
| 3209 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3210 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 3211 | } |
| 3212 | else if (qualifierType == "r32ui") |
| 3213 | { |
| 3214 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 3215 | qualifier.imageInternalFormat = EiifR32UI; |
| 3216 | } |
| 3217 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3218 | else |
| 3219 | { |
| 3220 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3221 | } |
| 3222 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3223 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3224 | } |
| 3225 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3226 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 3227 | const TSourceLoc &qualifierTypeLine, |
| 3228 | int intValue, |
| 3229 | const TSourceLoc &intValueLine, |
| 3230 | const std::string &intValueString, |
| 3231 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3232 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3233 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3234 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3235 | if (intValue < 1) |
| 3236 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3237 | std::string errorMessage = std::string(getWorkGroupSizeString(index)) + " must be positive"; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3238 | error(intValueLine, "out of range:", intValueString.c_str(), errorMessage.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3239 | } |
| 3240 | (*localSize)[index] = intValue; |
| 3241 | } |
| 3242 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3243 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 3244 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3245 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3246 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3247 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3248 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3249 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3250 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3251 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3252 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3253 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 3254 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3255 | if (intValue < 0) |
| 3256 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3257 | error(intValueLine, "out of range:", intValueString.c_str(), |
| 3258 | "location must be non-negative"); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3259 | } |
| 3260 | else |
| 3261 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3262 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 3263 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3264 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3265 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3266 | else if (qualifierType == "local_size_x") |
| 3267 | { |
| 3268 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 3269 | &qualifier.localSize); |
| 3270 | } |
| 3271 | else if (qualifierType == "local_size_y") |
| 3272 | { |
| 3273 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 3274 | &qualifier.localSize); |
| 3275 | } |
| 3276 | else if (qualifierType == "local_size_z") |
| 3277 | { |
| 3278 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 3279 | &qualifier.localSize); |
| 3280 | } |
| 3281 | else |
| 3282 | { |
| 3283 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3284 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3285 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3286 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3287 | } |
| 3288 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3289 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 3290 | { |
| 3291 | return new TTypeQualifierBuilder( |
| 3292 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 3293 | mShaderVersion); |
| 3294 | } |
| 3295 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3296 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3297 | TLayoutQualifier rightQualifier, |
| 3298 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3299 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3300 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
| 3301 | &mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 3302 | } |
| 3303 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3304 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 3305 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3306 | TPublicType *typeSpecifier, |
| 3307 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3308 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 3309 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3310 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3311 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 3312 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3313 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3314 | typeSpecifier->invariant = typeQualifier.invariant; |
| 3315 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3316 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3317 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3318 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3319 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 3320 | } |
| 3321 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3322 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 3323 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3324 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3325 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 3326 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3327 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3328 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3329 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3330 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3331 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3332 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3333 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3334 | // |
| 3335 | // Careful not to replace already known aspects of type, like array-ness |
| 3336 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3337 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3338 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3339 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3340 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3341 | type->setPrecision(typeSpecifier.precision); |
| 3342 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3343 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3344 | type->setMemoryQualifier(typeSpecifier.memoryQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3345 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3346 | |
| 3347 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3348 | if (type->isArray()) |
| 3349 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3350 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3351 | } |
| 3352 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3353 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3354 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3355 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3356 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3357 | } |
| 3358 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3359 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3360 | } |
| 3361 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3362 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3363 | } |
| 3364 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3365 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3366 | const TSourceLoc &nameLine, |
| 3367 | const TString *structName, |
| 3368 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3369 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3370 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3371 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3372 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3373 | // Store a bool in the struct if we're at global scope, to allow us to |
| 3374 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3375 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 3376 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3377 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3378 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3379 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3380 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 3381 | if (!symbolTable.declare(userTypeDef)) |
| 3382 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3383 | error(nameLine, "redefinition", structName->c_str(), "struct"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3384 | } |
| 3385 | } |
| 3386 | |
| 3387 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3388 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3389 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3390 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3391 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3392 | switch (qualifier) |
| 3393 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3394 | case EvqGlobal: |
| 3395 | case EvqTemporary: |
| 3396 | break; |
| 3397 | default: |
| 3398 | error(field.line(), "invalid qualifier on struct member", |
| 3399 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3400 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3401 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3402 | if (field.type()->isInvariant()) |
| 3403 | { |
| 3404 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 3405 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3406 | if (IsImage(field.type()->getBasicType())) |
| 3407 | { |
| 3408 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 3409 | } |
| 3410 | |
| 3411 | checkIsMemoryQualifierNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3412 | |
| 3413 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3414 | } |
| 3415 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3416 | TTypeSpecifierNonArray typeSpecifierNonArray; |
| 3417 | typeSpecifierNonArray.initialize(EbtStruct, structLine); |
| 3418 | typeSpecifierNonArray.userDef = structureType; |
| 3419 | typeSpecifierNonArray.isStructSpecifier = true; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3420 | exitStructDeclaration(); |
| 3421 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3422 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3423 | } |
| 3424 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3425 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3426 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3427 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3428 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3429 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3430 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3431 | init->isVector()) |
| 3432 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3433 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 3434 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3435 | return nullptr; |
| 3436 | } |
| 3437 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3438 | if (statementList) |
| 3439 | { |
| 3440 | if (!ValidateSwitch::validate(switchType, this, statementList, loc)) |
| 3441 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3442 | return nullptr; |
| 3443 | } |
| 3444 | } |
| 3445 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3446 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 3447 | if (node == nullptr) |
| 3448 | { |
| 3449 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3450 | return nullptr; |
| 3451 | } |
| 3452 | return node; |
| 3453 | } |
| 3454 | |
| 3455 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 3456 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3457 | if (mSwitchNestingLevel == 0) |
| 3458 | { |
| 3459 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3460 | return nullptr; |
| 3461 | } |
| 3462 | if (condition == nullptr) |
| 3463 | { |
| 3464 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3465 | return nullptr; |
| 3466 | } |
| 3467 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3468 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3469 | { |
| 3470 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3471 | } |
| 3472 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3473 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 3474 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 3475 | // fold in case labels. |
| 3476 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3477 | { |
| 3478 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3479 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3480 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 3481 | if (node == nullptr) |
| 3482 | { |
| 3483 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3484 | return nullptr; |
| 3485 | } |
| 3486 | return node; |
| 3487 | } |
| 3488 | |
| 3489 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 3490 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3491 | if (mSwitchNestingLevel == 0) |
| 3492 | { |
| 3493 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3494 | return nullptr; |
| 3495 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3496 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 3497 | if (node == nullptr) |
| 3498 | { |
| 3499 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3500 | return nullptr; |
| 3501 | } |
| 3502 | return node; |
| 3503 | } |
| 3504 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3505 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 3506 | TIntermTyped *child, |
| 3507 | const TSourceLoc &loc, |
| 3508 | const TType *funcReturnType) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3509 | { |
| 3510 | if (child == nullptr) |
| 3511 | { |
| 3512 | return nullptr; |
| 3513 | } |
| 3514 | |
| 3515 | switch (op) |
| 3516 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3517 | case EOpLogicalNot: |
| 3518 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 3519 | child->isVector()) |
| 3520 | { |
| 3521 | return nullptr; |
| 3522 | } |
| 3523 | break; |
| 3524 | case EOpBitwiseNot: |
| 3525 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 3526 | child->isMatrix() || child->isArray()) |
| 3527 | { |
| 3528 | return nullptr; |
| 3529 | } |
| 3530 | break; |
| 3531 | case EOpPostIncrement: |
| 3532 | case EOpPreIncrement: |
| 3533 | case EOpPostDecrement: |
| 3534 | case EOpPreDecrement: |
| 3535 | case EOpNegative: |
| 3536 | case EOpPositive: |
| 3537 | if (child->getBasicType() == EbtStruct || child->getBasicType() == EbtBool || |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3538 | child->isArray() || IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3539 | { |
| 3540 | return nullptr; |
| 3541 | } |
| 3542 | // Operators for built-ins are already type checked against their prototype. |
| 3543 | default: |
| 3544 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3545 | } |
| 3546 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3547 | TIntermUnary *node = new TIntermUnary(op, child); |
| 3548 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3549 | |
| 3550 | TIntermTyped *foldedNode = node->fold(&mDiagnostics); |
| 3551 | if (foldedNode) |
| 3552 | return foldedNode; |
| 3553 | |
| 3554 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3555 | } |
| 3556 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3557 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 3558 | { |
Olli Etuaho | f6c694b | 2015-03-26 14:50:53 +0200 | [diff] [blame] | 3559 | TIntermTyped *node = createUnaryMath(op, child, loc, nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3560 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3561 | { |
| 3562 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3563 | return child; |
| 3564 | } |
| 3565 | return node; |
| 3566 | } |
| 3567 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3568 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 3569 | TIntermTyped *child, |
| 3570 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3571 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3572 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3573 | return addUnaryMath(op, child, loc); |
| 3574 | } |
| 3575 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3576 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 3577 | TIntermTyped *left, |
| 3578 | TIntermTyped *right, |
| 3579 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3580 | { |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3581 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 3582 | { |
| 3583 | switch (op) |
| 3584 | { |
| 3585 | case EOpIndexDirectStruct: |
| 3586 | ASSERT(left->getType().getStruct()); |
| 3587 | break; |
| 3588 | case EOpEqual: |
| 3589 | case EOpNotEqual: |
| 3590 | case EOpAssign: |
| 3591 | case EOpInitialize: |
| 3592 | if (left->getType() != right->getType()) |
| 3593 | { |
| 3594 | return false; |
| 3595 | } |
| 3596 | break; |
| 3597 | default: |
| 3598 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 3599 | return false; |
| 3600 | } |
| 3601 | } |
| 3602 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3603 | if (left->isArray() || right->isArray()) |
| 3604 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3605 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3606 | { |
| 3607 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3608 | return false; |
| 3609 | } |
| 3610 | |
| 3611 | if (left->isArray() != right->isArray()) |
| 3612 | { |
| 3613 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 3614 | return false; |
| 3615 | } |
| 3616 | |
| 3617 | switch (op) |
| 3618 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3619 | case EOpEqual: |
| 3620 | case EOpNotEqual: |
| 3621 | case EOpAssign: |
| 3622 | case EOpInitialize: |
| 3623 | break; |
| 3624 | default: |
| 3625 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3626 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3627 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 3628 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3629 | if (left->getArraySize() != right->getArraySize()) |
| 3630 | { |
| 3631 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 3632 | return false; |
| 3633 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3634 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3635 | |
| 3636 | // Check ops which require integer / ivec parameters |
| 3637 | bool isBitShift = false; |
| 3638 | switch (op) |
| 3639 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3640 | case EOpBitShiftLeft: |
| 3641 | case EOpBitShiftRight: |
| 3642 | case EOpBitShiftLeftAssign: |
| 3643 | case EOpBitShiftRightAssign: |
| 3644 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 3645 | // check that the basic type is an integer type. |
| 3646 | isBitShift = true; |
| 3647 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 3648 | { |
| 3649 | return false; |
| 3650 | } |
| 3651 | break; |
| 3652 | case EOpBitwiseAnd: |
| 3653 | case EOpBitwiseXor: |
| 3654 | case EOpBitwiseOr: |
| 3655 | case EOpBitwiseAndAssign: |
| 3656 | case EOpBitwiseXorAssign: |
| 3657 | case EOpBitwiseOrAssign: |
| 3658 | // It is enough to check the type of only one operand, since later it |
| 3659 | // is checked that the operand types match. |
| 3660 | if (!IsInteger(left->getBasicType())) |
| 3661 | { |
| 3662 | return false; |
| 3663 | } |
| 3664 | break; |
| 3665 | default: |
| 3666 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3667 | } |
| 3668 | |
| 3669 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 3670 | // So the basic type should usually match. |
| 3671 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 3672 | { |
| 3673 | return false; |
| 3674 | } |
| 3675 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3676 | // Check that: |
| 3677 | // 1. Type sizes match exactly on ops that require that. |
| 3678 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 3679 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3680 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3681 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3682 | case EOpAssign: |
| 3683 | case EOpInitialize: |
| 3684 | case EOpEqual: |
| 3685 | case EOpNotEqual: |
| 3686 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 3687 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 3688 | { |
| 3689 | error(loc, "undefined operation for structs containing arrays", |
| 3690 | GetOperatorString(op)); |
| 3691 | return false; |
| 3692 | } |
| 3693 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 3694 | // we interpret the spec so that this extends to structs containing samplers, |
| 3695 | // similarly to ESSL 1.00 spec. |
| 3696 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 3697 | left->getType().isStructureContainingSamplers()) |
| 3698 | { |
| 3699 | error(loc, "undefined operation for structs containing samplers", |
| 3700 | GetOperatorString(op)); |
| 3701 | return false; |
| 3702 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3703 | |
| 3704 | if ((op == EOpAssign || op == EOpInitialize) && |
| 3705 | left->getType().isStructureContainingImages()) |
| 3706 | { |
| 3707 | error(loc, "undefined operation for structs containing images", |
| 3708 | GetOperatorString(op)); |
| 3709 | return false; |
| 3710 | } |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3711 | case EOpLessThan: |
| 3712 | case EOpGreaterThan: |
| 3713 | case EOpLessThanEqual: |
| 3714 | case EOpGreaterThanEqual: |
| 3715 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 3716 | (left->getSecondarySize() != right->getSecondarySize())) |
| 3717 | { |
| 3718 | return false; |
| 3719 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3720 | break; |
| 3721 | case EOpAdd: |
| 3722 | case EOpSub: |
| 3723 | case EOpDiv: |
| 3724 | case EOpIMod: |
| 3725 | case EOpBitShiftLeft: |
| 3726 | case EOpBitShiftRight: |
| 3727 | case EOpBitwiseAnd: |
| 3728 | case EOpBitwiseXor: |
| 3729 | case EOpBitwiseOr: |
| 3730 | case EOpAddAssign: |
| 3731 | case EOpSubAssign: |
| 3732 | case EOpDivAssign: |
| 3733 | case EOpIModAssign: |
| 3734 | case EOpBitShiftLeftAssign: |
| 3735 | case EOpBitShiftRightAssign: |
| 3736 | case EOpBitwiseAndAssign: |
| 3737 | case EOpBitwiseXorAssign: |
| 3738 | case EOpBitwiseOrAssign: |
| 3739 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 3740 | { |
| 3741 | return false; |
| 3742 | } |
| 3743 | |
| 3744 | // Are the sizes compatible? |
| 3745 | if (left->getNominalSize() != right->getNominalSize() || |
| 3746 | left->getSecondarySize() != right->getSecondarySize()) |
| 3747 | { |
| 3748 | // If the nominal sizes of operands do not match: |
| 3749 | // One of them must be a scalar. |
| 3750 | if (!left->isScalar() && !right->isScalar()) |
| 3751 | return false; |
| 3752 | |
| 3753 | // In the case of compound assignment other than multiply-assign, |
| 3754 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 3755 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 3756 | // vector either. |
| 3757 | if (!right->isScalar() && |
| 3758 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 3759 | return false; |
| 3760 | } |
| 3761 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3762 | default: |
| 3763 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3764 | } |
| 3765 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3766 | return true; |
| 3767 | } |
| 3768 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3769 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 3770 | const TType &left, |
| 3771 | const TType &right) |
| 3772 | { |
| 3773 | switch (op) |
| 3774 | { |
| 3775 | case EOpMul: |
| 3776 | case EOpMulAssign: |
| 3777 | return left.getNominalSize() == right.getNominalSize() && |
| 3778 | left.getSecondarySize() == right.getSecondarySize(); |
| 3779 | case EOpVectorTimesScalar: |
| 3780 | return true; |
| 3781 | case EOpVectorTimesScalarAssign: |
| 3782 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 3783 | return left.isVector() && !right.isVector(); |
| 3784 | case EOpVectorTimesMatrix: |
| 3785 | return left.getNominalSize() == right.getRows(); |
| 3786 | case EOpVectorTimesMatrixAssign: |
| 3787 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 3788 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 3789 | left.getNominalSize() == right.getCols(); |
| 3790 | case EOpMatrixTimesVector: |
| 3791 | return left.getCols() == right.getNominalSize(); |
| 3792 | case EOpMatrixTimesScalar: |
| 3793 | return true; |
| 3794 | case EOpMatrixTimesScalarAssign: |
| 3795 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 3796 | return !right.isVector(); |
| 3797 | case EOpMatrixTimesMatrix: |
| 3798 | return left.getCols() == right.getRows(); |
| 3799 | case EOpMatrixTimesMatrixAssign: |
| 3800 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 3801 | // We need to check two things: |
| 3802 | // 1. The matrix multiplication step is valid. |
| 3803 | // 2. The result will have the same number of columns as the lvalue. |
| 3804 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 3805 | |
| 3806 | default: |
| 3807 | UNREACHABLE(); |
| 3808 | return false; |
| 3809 | } |
| 3810 | } |
| 3811 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3812 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 3813 | TIntermTyped *left, |
| 3814 | TIntermTyped *right, |
| 3815 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3816 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3817 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3818 | return nullptr; |
| 3819 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3820 | switch (op) |
| 3821 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3822 | case EOpEqual: |
| 3823 | case EOpNotEqual: |
| 3824 | break; |
| 3825 | case EOpLessThan: |
| 3826 | case EOpGreaterThan: |
| 3827 | case EOpLessThanEqual: |
| 3828 | case EOpGreaterThanEqual: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3829 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3830 | !right->getType().getStruct()); |
| 3831 | if (left->isMatrix() || left->isVector()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3832 | { |
| 3833 | return nullptr; |
| 3834 | } |
| 3835 | break; |
| 3836 | case EOpLogicalOr: |
| 3837 | case EOpLogicalXor: |
| 3838 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3839 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3840 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3841 | if (left->getBasicType() != EbtBool || left->isMatrix() || left->isVector()) |
| 3842 | { |
| 3843 | return nullptr; |
| 3844 | } |
| 3845 | break; |
| 3846 | case EOpAdd: |
| 3847 | case EOpSub: |
| 3848 | case EOpDiv: |
| 3849 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3850 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3851 | !right->getType().getStruct()); |
| 3852 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3853 | { |
| 3854 | return nullptr; |
| 3855 | } |
| 3856 | break; |
| 3857 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3858 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3859 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3860 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3861 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3862 | { |
| 3863 | return nullptr; |
| 3864 | } |
| 3865 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3866 | default: |
| 3867 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3868 | } |
| 3869 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3870 | if (op == EOpMul) |
| 3871 | { |
| 3872 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 3873 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 3874 | { |
| 3875 | return nullptr; |
| 3876 | } |
| 3877 | } |
| 3878 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3879 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 3880 | node->setLine(loc); |
| 3881 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3882 | // See if we can fold constants. |
| 3883 | TIntermTyped *foldedNode = node->fold(&mDiagnostics); |
| 3884 | if (foldedNode) |
| 3885 | return foldedNode; |
| 3886 | |
| 3887 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3888 | } |
| 3889 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3890 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 3891 | TIntermTyped *left, |
| 3892 | TIntermTyped *right, |
| 3893 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3894 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3895 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3896 | if (node == 0) |
| 3897 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3898 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 3899 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3900 | return left; |
| 3901 | } |
| 3902 | return node; |
| 3903 | } |
| 3904 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3905 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 3906 | TIntermTyped *left, |
| 3907 | TIntermTyped *right, |
| 3908 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3909 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3910 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3911 | if (node == 0) |
| 3912 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3913 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 3914 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 3915 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3916 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3917 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 3918 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3919 | } |
| 3920 | return node; |
| 3921 | } |
| 3922 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3923 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 3924 | TIntermTyped *left, |
| 3925 | TIntermTyped *right, |
| 3926 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3927 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3928 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3929 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3930 | if (op == EOpMulAssign) |
| 3931 | { |
| 3932 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 3933 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 3934 | { |
| 3935 | return nullptr; |
| 3936 | } |
| 3937 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3938 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 3939 | node->setLine(loc); |
| 3940 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3941 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3942 | } |
| 3943 | return nullptr; |
| 3944 | } |
| 3945 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3946 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 3947 | TIntermTyped *left, |
| 3948 | TIntermTyped *right, |
| 3949 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3950 | { |
| 3951 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 3952 | if (node == nullptr) |
| 3953 | { |
| 3954 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3955 | return left; |
| 3956 | } |
| 3957 | return node; |
| 3958 | } |
| 3959 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 3960 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 3961 | TIntermTyped *right, |
| 3962 | const TSourceLoc &loc) |
| 3963 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3964 | // WebGL2 section 5.26, the following results in an error: |
| 3965 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
| 3966 | if (mShaderSpec == SH_WEBGL2_SPEC && (left->isArray() || left->getBasicType() == EbtVoid || |
| 3967 | left->getType().isStructureContainingArrays() || |
| 3968 | right->isArray() || right->getBasicType() == EbtVoid || |
| 3969 | right->getType().isStructureContainingArrays())) |
| 3970 | { |
| 3971 | error(loc, |
| 3972 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 3973 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3974 | } |
| 3975 | |
Olli Etuaho | 4db7ded | 2016-10-13 12:23:11 +0100 | [diff] [blame] | 3976 | return TIntermediate::AddComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 3977 | } |
| 3978 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3979 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 3980 | { |
| 3981 | switch (op) |
| 3982 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3983 | case EOpContinue: |
| 3984 | if (mLoopNestingLevel <= 0) |
| 3985 | { |
| 3986 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3987 | } |
| 3988 | break; |
| 3989 | case EOpBreak: |
| 3990 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 3991 | { |
| 3992 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3993 | } |
| 3994 | break; |
| 3995 | case EOpReturn: |
| 3996 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 3997 | { |
| 3998 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3999 | } |
| 4000 | break; |
| 4001 | default: |
| 4002 | // No checks for discard |
| 4003 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4004 | } |
| 4005 | return intermediate.addBranch(op, loc); |
| 4006 | } |
| 4007 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4008 | TIntermBranch *TParseContext::addBranch(TOperator op, |
| 4009 | TIntermTyped *returnValue, |
| 4010 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4011 | { |
| 4012 | ASSERT(op == EOpReturn); |
| 4013 | mFunctionReturnsValue = true; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4014 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4015 | { |
| 4016 | error(loc, "void function cannot return a value", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4017 | } |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4018 | else if (*mCurrentFunctionType != returnValue->getType()) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4019 | { |
| 4020 | error(loc, "function return is not matching type:", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4021 | } |
| 4022 | return intermediate.addBranch(op, returnValue, loc); |
| 4023 | } |
| 4024 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4025 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 4026 | { |
| 4027 | ASSERT(!functionCall->isUserDefined()); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4028 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4029 | TIntermNode *offset = nullptr; |
| 4030 | TIntermSequence *arguments = functionCall->getSequence(); |
| 4031 | if (name.compare(0, 16, "texelFetchOffset") == 0 || |
| 4032 | name.compare(0, 16, "textureLodOffset") == 0 || |
| 4033 | name.compare(0, 20, "textureProjLodOffset") == 0 || |
| 4034 | name.compare(0, 17, "textureGradOffset") == 0 || |
| 4035 | name.compare(0, 21, "textureProjGradOffset") == 0) |
| 4036 | { |
| 4037 | offset = arguments->back(); |
| 4038 | } |
| 4039 | else if (name.compare(0, 13, "textureOffset") == 0 || |
| 4040 | name.compare(0, 17, "textureProjOffset") == 0) |
| 4041 | { |
| 4042 | // A bias parameter might follow the offset parameter. |
| 4043 | ASSERT(arguments->size() >= 3); |
| 4044 | offset = (*arguments)[2]; |
| 4045 | } |
| 4046 | if (offset != nullptr) |
| 4047 | { |
| 4048 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 4049 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 4050 | { |
| 4051 | TString unmangledName = TFunction::unmangleName(name); |
| 4052 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
| 4053 | unmangledName.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4054 | } |
| 4055 | else |
| 4056 | { |
| 4057 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 4058 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 4059 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 4060 | for (size_t i = 0u; i < size; ++i) |
| 4061 | { |
| 4062 | int offsetValue = values[i].getIConst(); |
| 4063 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 4064 | { |
| 4065 | std::stringstream tokenStream; |
| 4066 | tokenStream << offsetValue; |
| 4067 | std::string token = tokenStream.str(); |
| 4068 | error(offset->getLine(), "Texture offset value out of valid range", |
| 4069 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4070 | } |
| 4071 | } |
| 4072 | } |
| 4073 | } |
| 4074 | } |
| 4075 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4076 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 4077 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 4078 | { |
| 4079 | ASSERT(!functionCall->isUserDefined()); |
| 4080 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 4081 | |
| 4082 | if (name.compare(0, 5, "image") == 0) |
| 4083 | { |
| 4084 | TIntermSequence *arguments = functionCall->getSequence(); |
| 4085 | TIntermNode *imageNode = (*arguments)[0]; |
| 4086 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 4087 | |
| 4088 | const TMemoryQualifier &memoryQualifier = imageSymbol->getMemoryQualifier(); |
| 4089 | |
| 4090 | if (name.compare(5, 5, "Store") == 0) |
| 4091 | { |
| 4092 | if (memoryQualifier.readonly) |
| 4093 | { |
| 4094 | error(imageNode->getLine(), |
| 4095 | "'imageStore' cannot be used with images qualified as 'readonly'", |
| 4096 | imageSymbol->getSymbol().c_str()); |
| 4097 | } |
| 4098 | } |
| 4099 | else if (name.compare(5, 4, "Load") == 0) |
| 4100 | { |
| 4101 | if (memoryQualifier.writeonly) |
| 4102 | { |
| 4103 | error(imageNode->getLine(), |
| 4104 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
| 4105 | imageSymbol->getSymbol().c_str()); |
| 4106 | } |
| 4107 | } |
| 4108 | } |
| 4109 | } |
| 4110 | |
| 4111 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 4112 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 4113 | const TFunction *functionDefinition, |
| 4114 | const TIntermAggregate *functionCall) |
| 4115 | { |
| 4116 | ASSERT(functionCall->isUserDefined()); |
| 4117 | |
| 4118 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 4119 | |
| 4120 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 4121 | |
| 4122 | for (size_t i = 0; i < arguments.size(); ++i) |
| 4123 | { |
| 4124 | const TType &functionArgumentType = arguments[i]->getAsTyped()->getType(); |
| 4125 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 4126 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 4127 | |
| 4128 | if (IsImage(functionArgumentType.getBasicType())) |
| 4129 | { |
| 4130 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 4131 | functionArgumentType.getMemoryQualifier(); |
| 4132 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 4133 | functionParameterType.getMemoryQualifier(); |
| 4134 | if (functionArgumentMemoryQualifier.readonly && |
| 4135 | !functionParameterMemoryQualifier.readonly) |
| 4136 | { |
| 4137 | error(functionCall->getLine(), |
| 4138 | "Function call discards the 'readonly' qualifier from image", |
| 4139 | arguments[i]->getAsSymbolNode()->getSymbol().c_str()); |
| 4140 | } |
| 4141 | |
| 4142 | if (functionArgumentMemoryQualifier.writeonly && |
| 4143 | !functionParameterMemoryQualifier.writeonly) |
| 4144 | { |
| 4145 | error(functionCall->getLine(), |
| 4146 | "Function call discards the 'writeonly' qualifier from image", |
| 4147 | arguments[i]->getAsSymbolNode()->getSymbol().c_str()); |
| 4148 | } |
| 4149 | } |
| 4150 | } |
| 4151 | } |
| 4152 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4153 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
| 4154 | TIntermNode *paramNode, |
| 4155 | TIntermNode *thisNode, |
| 4156 | const TSourceLoc &loc, |
| 4157 | bool *fatalError) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4158 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4159 | *fatalError = false; |
| 4160 | TOperator op = fnCall->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4161 | TIntermTyped *callNode = nullptr; |
| 4162 | |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4163 | if (thisNode != nullptr) |
| 4164 | { |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4165 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4166 | int arraySize = 0; |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4167 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 4168 | if (fnCall->getName() != "length") |
| 4169 | { |
| 4170 | error(loc, "invalid method", fnCall->getName().c_str()); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4171 | } |
| 4172 | else if (paramNode != nullptr) |
| 4173 | { |
| 4174 | error(loc, "method takes no parameters", "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4175 | } |
| 4176 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 4177 | { |
| 4178 | error(loc, "length can only be called on arrays", "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4179 | } |
| 4180 | else |
| 4181 | { |
Olli Etuaho | 96e6738 | 2015-04-23 14:27:02 +0300 | [diff] [blame] | 4182 | arraySize = typedThis->getArraySize(); |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 4183 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4184 | { |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 4185 | // This code path can be hit with expressions like these: |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4186 | // (a = b).length() |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 4187 | // (func()).length() |
| 4188 | // (int[3](0, 1, 2)).length() |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4189 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 4190 | // expression. |
| 4191 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 4192 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 4193 | // length method applied". |
| 4194 | error(loc, "length can only be called on array names, not on array expressions", |
| 4195 | "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4196 | } |
| 4197 | } |
Olli Etuaho | 96e6738 | 2015-04-23 14:27:02 +0300 | [diff] [blame] | 4198 | unionArray->setIConst(arraySize); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4199 | callNode = |
| 4200 | intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 4201 | } |
| 4202 | else if (op != EOpNull) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4203 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4204 | // Then this should be a constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4205 | callNode = addConstructor(paramNode, op, fnCall, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4206 | } |
| 4207 | else |
| 4208 | { |
| 4209 | // |
| 4210 | // Not a constructor. Find it in the symbol table. |
| 4211 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4212 | const TFunction *fnCandidate; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4213 | bool builtIn; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4214 | fnCandidate = findFunction(loc, fnCall, mShaderVersion, &builtIn); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4215 | if (fnCandidate) |
| 4216 | { |
| 4217 | // |
| 4218 | // A declared function. |
| 4219 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 4220 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4221 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4222 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4223 | } |
| 4224 | op = fnCandidate->getBuiltInOp(); |
| 4225 | if (builtIn && op != EOpNull) |
| 4226 | { |
| 4227 | // |
| 4228 | // A function call mapped to a built-in operation. |
| 4229 | // |
| 4230 | if (fnCandidate->getParamCount() == 1) |
| 4231 | { |
| 4232 | // |
| 4233 | // Treat it like a built-in unary operator. |
| 4234 | // |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 4235 | TIntermAggregate *paramAgg = paramNode->getAsAggregate(); |
| 4236 | paramNode = paramAgg->getSequence()->front(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4237 | callNode = createUnaryMath(op, paramNode->getAsTyped(), loc, |
| 4238 | &fnCandidate->getReturnType()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4239 | if (callNode == nullptr) |
| 4240 | { |
| 4241 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4242 | extraInfoStream |
| 4243 | << "built in unary operator function. Type: " |
| 4244 | << static_cast<TIntermTyped *>(paramNode)->getCompleteString(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4245 | std::string extraInfo = extraInfoStream.str(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4246 | error(paramNode->getLine(), " wrong operand type", "Internal Error", |
| 4247 | extraInfo.c_str()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4248 | *fatalError = true; |
| 4249 | return nullptr; |
| 4250 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4251 | } |
| 4252 | else |
| 4253 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4254 | TIntermAggregate *aggregate = |
| 4255 | intermediate.setAggregateOperator(paramNode, op, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4256 | aggregate->setType(fnCandidate->getReturnType()); |
| 4257 | aggregate->setPrecisionFromChildren(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 4258 | if (aggregate->areChildrenConstQualified()) |
| 4259 | { |
| 4260 | aggregate->getTypePointer()->setQualifier(EvqConst); |
| 4261 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4262 | |
| 4263 | // Some built-in functions have out parameters too. |
| 4264 | functionCallLValueErrorCheck(fnCandidate, aggregate); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4265 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4266 | // See if we can constant fold a built-in. Note that this may be possible even |
| 4267 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4268 | TIntermTyped *foldedNode = |
| 4269 | intermediate.foldAggregateBuiltIn(aggregate, &mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4270 | if (foldedNode) |
| 4271 | { |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 4272 | callNode = foldedNode; |
| 4273 | } |
Olli Etuaho | b43846e | 2015-06-02 18:18:57 +0300 | [diff] [blame] | 4274 | else |
| 4275 | { |
| 4276 | callNode = aggregate; |
| 4277 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4278 | } |
| 4279 | } |
| 4280 | else |
| 4281 | { |
| 4282 | // This is a real function call |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4283 | TIntermAggregate *aggregate = |
| 4284 | intermediate.setAggregateOperator(paramNode, EOpFunctionCall, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4285 | aggregate->setType(fnCandidate->getReturnType()); |
| 4286 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4287 | // this is how we know whether the given function is a builtIn function or a user |
| 4288 | // defined function |
| 4289 | // if builtIn == false, it's a userDefined -> could be an overloaded |
| 4290 | // builtIn function also |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4291 | // if builtIn == true, it's definitely a builtIn function with EOpNull |
| 4292 | if (!builtIn) |
| 4293 | aggregate->setUserDefined(); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4294 | aggregate->getFunctionSymbolInfo()->setFromFunction(*fnCandidate); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4295 | |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 4296 | // This needs to happen after the function info including name is set |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4297 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4298 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4299 | aggregate->setBuiltInFunctionPrecision(); |
| 4300 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4301 | checkTextureOffsetConst(aggregate); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4302 | |
| 4303 | checkImageMemoryAccessForBuiltinFunctions(aggregate); |
| 4304 | } |
| 4305 | else |
| 4306 | { |
| 4307 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, aggregate); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 4308 | } |
| 4309 | |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4310 | callNode = aggregate; |
| 4311 | |
| 4312 | functionCallLValueErrorCheck(fnCandidate, aggregate); |
| 4313 | } |
| 4314 | } |
| 4315 | else |
| 4316 | { |
| 4317 | // error message was put out by findFunction() |
| 4318 | // Put on a dummy node for error recovery |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 4319 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4320 | unionArray->setFConst(0.0f); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4321 | callNode = intermediate.addConstantUnion(unionArray, |
| 4322 | TType(EbtFloat, EbpUndefined, EvqConst), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4323 | } |
| 4324 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 4325 | return callNode; |
| 4326 | } |
| 4327 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4328 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4329 | TIntermTyped *trueExpression, |
| 4330 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4331 | const TSourceLoc &loc) |
| 4332 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4333 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4334 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4335 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4336 | { |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4337 | binaryOpError(loc, ":", trueExpression->getCompleteString(), |
| 4338 | falseExpression->getCompleteString()); |
| 4339 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4340 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 4341 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 4342 | { |
| 4343 | // ESSL 1.00 section 4.1.7 |
| 4344 | // ESSL 3.00 section 4.1.7 |
| 4345 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 4346 | // Note that structs containing opaque types don't need to be checked as structs are |
| 4347 | // forbidden below. |
| 4348 | error(loc, "ternary operator is not allowed for opaque types", ":"); |
| 4349 | return falseExpression; |
| 4350 | } |
| 4351 | |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4352 | // ESSL1 sections 5.2 and 5.7: |
| 4353 | // ESSL3 section 5.7: |
| 4354 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4355 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4356 | { |
| 4357 | error(loc, "ternary operator is not allowed for structures or arrays", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4358 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 4359 | } |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4360 | // WebGL2 section 5.26, the following results in an error: |
| 4361 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4362 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4363 | { |
| 4364 | error(loc, "ternary operator is not allowed for void", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4365 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 4366 | } |
| 4367 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 4368 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 4369 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 4370 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4371 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4372 | // Parse an array of strings using yyparse. |
| 4373 | // |
| 4374 | // Returns 0 for success. |
| 4375 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4376 | int PaParseStrings(size_t count, |
| 4377 | const char *const string[], |
| 4378 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4379 | TParseContext *context) |
| 4380 | { |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4381 | if ((count == 0) || (string == NULL)) |
| 4382 | return 1; |
| 4383 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4384 | if (glslang_initialize(context)) |
| 4385 | return 1; |
| 4386 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 4387 | int error = glslang_scan(count, string, length, context); |
| 4388 | if (!error) |
| 4389 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4390 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 4391 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 4392 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 4393 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 4394 | } |