daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 12 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 13 | #include "compiler/translator/Cache.h" |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 14 | #include "compiler/translator/glslang.h" |
| 15 | #include "compiler/translator/ValidateSwitch.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 17 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 18 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 19 | /////////////////////////////////////////////////////////////////////// |
| 20 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 21 | // Sub- vector and matrix fields |
| 22 | // |
| 23 | //////////////////////////////////////////////////////////////////////// |
| 24 | |
| 25 | // |
| 26 | // Look at a '.' field selector string and change it into offsets |
| 27 | // for a vector. |
| 28 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 29 | bool TParseContext::parseVectorFields(const TString &compString, |
| 30 | int vecSize, |
| 31 | TVectorFields &fields, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 32 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 33 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 34 | fields.num = (int)compString.size(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 35 | if (fields.num > 4) |
| 36 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 37 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 38 | return false; |
| 39 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 40 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 41 | enum |
| 42 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 43 | exyzw, |
| 44 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 45 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 46 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 47 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 48 | for (int i = 0; i < fields.num; ++i) |
| 49 | { |
| 50 | switch (compString[i]) |
| 51 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 52 | case 'x': |
| 53 | fields.offsets[i] = 0; |
| 54 | fieldSet[i] = exyzw; |
| 55 | break; |
| 56 | case 'r': |
| 57 | fields.offsets[i] = 0; |
| 58 | fieldSet[i] = ergba; |
| 59 | break; |
| 60 | case 's': |
| 61 | fields.offsets[i] = 0; |
| 62 | fieldSet[i] = estpq; |
| 63 | break; |
| 64 | case 'y': |
| 65 | fields.offsets[i] = 1; |
| 66 | fieldSet[i] = exyzw; |
| 67 | break; |
| 68 | case 'g': |
| 69 | fields.offsets[i] = 1; |
| 70 | fieldSet[i] = ergba; |
| 71 | break; |
| 72 | case 't': |
| 73 | fields.offsets[i] = 1; |
| 74 | fieldSet[i] = estpq; |
| 75 | break; |
| 76 | case 'z': |
| 77 | fields.offsets[i] = 2; |
| 78 | fieldSet[i] = exyzw; |
| 79 | break; |
| 80 | case 'b': |
| 81 | fields.offsets[i] = 2; |
| 82 | fieldSet[i] = ergba; |
| 83 | break; |
| 84 | case 'p': |
| 85 | fields.offsets[i] = 2; |
| 86 | fieldSet[i] = estpq; |
| 87 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 88 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 89 | case 'w': |
| 90 | fields.offsets[i] = 3; |
| 91 | fieldSet[i] = exyzw; |
| 92 | break; |
| 93 | case 'a': |
| 94 | fields.offsets[i] = 3; |
| 95 | fieldSet[i] = ergba; |
| 96 | break; |
| 97 | case 'q': |
| 98 | fields.offsets[i] = 3; |
| 99 | fieldSet[i] = estpq; |
| 100 | break; |
| 101 | default: |
| 102 | error(line, "illegal vector field selection", compString.c_str()); |
| 103 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 104 | } |
| 105 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 106 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 107 | for (int i = 0; i < fields.num; ++i) |
| 108 | { |
| 109 | if (fields.offsets[i] >= vecSize) |
| 110 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 111 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 112 | return false; |
| 113 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 114 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 115 | if (i > 0) |
| 116 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 117 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 118 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 119 | error(line, "illegal - vector component fields not from the same set", |
| 120 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 121 | return false; |
| 122 | } |
| 123 | } |
| 124 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 125 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 126 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 127 | } |
| 128 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 129 | /////////////////////////////////////////////////////////////////////// |
| 130 | // |
| 131 | // Errors |
| 132 | // |
| 133 | //////////////////////////////////////////////////////////////////////// |
| 134 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 135 | |
| 136 | // |
| 137 | // Used by flex/bison to output all syntax and parsing errors. |
| 138 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 139 | void TParseContext::error(const TSourceLoc &loc, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 140 | const char *reason, |
| 141 | const char *token, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 142 | const char *extraInfo) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 143 | { |
Olli Etuaho | 1cc598f | 2016-08-18 13:50:30 +0300 | [diff] [blame] | 144 | mDiagnostics.error(loc, reason, token, extraInfo); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 145 | } |
| 146 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 147 | void TParseContext::warning(const TSourceLoc &loc, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 148 | const char *reason, |
| 149 | const char *token, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 150 | const char *extraInfo) |
| 151 | { |
Olli Etuaho | 1cc598f | 2016-08-18 13:50:30 +0300 | [diff] [blame] | 152 | mDiagnostics.warning(loc, reason, token, extraInfo); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 153 | } |
| 154 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 155 | void TParseContext::outOfRangeError(bool isError, |
| 156 | const TSourceLoc &loc, |
| 157 | const char *reason, |
| 158 | const char *token, |
| 159 | const char *extraInfo) |
| 160 | { |
| 161 | if (isError) |
| 162 | { |
| 163 | error(loc, reason, token, extraInfo); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 164 | } |
| 165 | else |
| 166 | { |
| 167 | warning(loc, reason, token, extraInfo); |
| 168 | } |
| 169 | } |
| 170 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 171 | // |
| 172 | // Same error message for all places assignments don't work. |
| 173 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 174 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 175 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 176 | std::stringstream extraInfoStream; |
| 177 | extraInfoStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 178 | std::string extraInfo = extraInfoStream.str(); |
| 179 | error(line, "", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 180 | } |
| 181 | |
| 182 | // |
| 183 | // Same error message for all places unary operations don't work. |
| 184 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 185 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 186 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 187 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 188 | extraInfoStream << "no operation '" << op << "' exists that takes an operand of type " |
| 189 | << operand << " (or there is no acceptable conversion)"; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 190 | std::string extraInfo = extraInfoStream.str(); |
| 191 | error(line, " wrong operand type", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 192 | } |
| 193 | |
| 194 | // |
| 195 | // Same error message for all binary operations don't work. |
| 196 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 197 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 198 | const char *op, |
| 199 | TString left, |
| 200 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 201 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 202 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 203 | extraInfoStream << "no operation '" << op << "' exists that takes a left-hand operand of type '" |
| 204 | << left << "' and a right operand of type '" << right |
| 205 | << "' (or there is no acceptable conversion)"; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 206 | std::string extraInfo = extraInfoStream.str(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 207 | error(line, " wrong operand types ", op, extraInfo.c_str()); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 208 | } |
| 209 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 210 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 211 | TPrecision precision, |
| 212 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 213 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 214 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 215 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 216 | |
| 217 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 218 | { |
| 219 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 220 | } |
| 221 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 222 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 223 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 224 | switch (type) |
| 225 | { |
| 226 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 227 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 228 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 229 | case EbtInt: |
| 230 | case EbtUInt: |
| 231 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 232 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 233 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 234 | default: |
| 235 | if (IsSampler(type)) |
| 236 | { |
| 237 | error(line, "No precision specified (sampler)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 238 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 239 | } |
| 240 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 241 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 242 | } |
| 243 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 244 | // Both test and if necessary, spit out an error, to see if the node is really |
| 245 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 246 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 247 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 248 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 249 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 250 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 251 | |
| 252 | if (swizzleNode) |
| 253 | { |
| 254 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 255 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 256 | { |
| 257 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 258 | return false; |
| 259 | } |
| 260 | return ok; |
| 261 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 262 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 263 | if (binaryNode) |
| 264 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 265 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 266 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 267 | case EOpIndexDirect: |
| 268 | case EOpIndexIndirect: |
| 269 | case EOpIndexDirectStruct: |
| 270 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 271 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 272 | default: |
| 273 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 274 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 275 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 276 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 277 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 278 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 279 | const char *symbol = 0; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 280 | if (symNode != 0) |
| 281 | symbol = symNode->getSymbol().c_str(); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 282 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 283 | const char *message = 0; |
| 284 | switch (node->getQualifier()) |
| 285 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 286 | case EvqConst: |
| 287 | message = "can't modify a const"; |
| 288 | break; |
| 289 | case EvqConstReadOnly: |
| 290 | message = "can't modify a const"; |
| 291 | break; |
| 292 | case EvqAttribute: |
| 293 | message = "can't modify an attribute"; |
| 294 | break; |
| 295 | case EvqFragmentIn: |
| 296 | message = "can't modify an input"; |
| 297 | break; |
| 298 | case EvqVertexIn: |
| 299 | message = "can't modify an input"; |
| 300 | break; |
| 301 | case EvqUniform: |
| 302 | message = "can't modify a uniform"; |
| 303 | break; |
| 304 | case EvqVaryingIn: |
| 305 | message = "can't modify a varying"; |
| 306 | break; |
| 307 | case EvqFragCoord: |
| 308 | message = "can't modify gl_FragCoord"; |
| 309 | break; |
| 310 | case EvqFrontFacing: |
| 311 | message = "can't modify gl_FrontFacing"; |
| 312 | break; |
| 313 | case EvqPointCoord: |
| 314 | message = "can't modify gl_PointCoord"; |
| 315 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 316 | case EvqNumWorkGroups: |
| 317 | message = "can't modify gl_NumWorkGroups"; |
| 318 | break; |
| 319 | case EvqWorkGroupSize: |
| 320 | message = "can't modify gl_WorkGroupSize"; |
| 321 | break; |
| 322 | case EvqWorkGroupID: |
| 323 | message = "can't modify gl_WorkGroupID"; |
| 324 | break; |
| 325 | case EvqLocalInvocationID: |
| 326 | message = "can't modify gl_LocalInvocationID"; |
| 327 | break; |
| 328 | case EvqGlobalInvocationID: |
| 329 | message = "can't modify gl_GlobalInvocationID"; |
| 330 | break; |
| 331 | case EvqLocalInvocationIndex: |
| 332 | message = "can't modify gl_LocalInvocationIndex"; |
| 333 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 334 | case EvqComputeIn: |
| 335 | message = "can't modify work group size variable"; |
| 336 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 337 | default: |
| 338 | // |
| 339 | // Type that can't be written to? |
| 340 | // |
| 341 | if (node->getBasicType() == EbtVoid) |
| 342 | { |
| 343 | message = "can't modify void"; |
| 344 | } |
| 345 | if (IsSampler(node->getBasicType())) |
| 346 | { |
| 347 | message = "can't modify a sampler"; |
| 348 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 349 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 350 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 351 | if (message == 0 && binaryNode == 0 && symNode == 0) |
| 352 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 353 | error(line, " l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 354 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 355 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 356 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 357 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 358 | // |
| 359 | // Everything else is okay, no error. |
| 360 | // |
| 361 | if (message == 0) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 362 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 363 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 364 | // |
| 365 | // If we get here, we have an error and a message. |
| 366 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 367 | if (symNode) |
| 368 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 369 | std::stringstream extraInfoStream; |
| 370 | extraInfoStream << "\"" << symbol << "\" (" << message << ")"; |
| 371 | std::string extraInfo = extraInfoStream.str(); |
| 372 | error(line, " l-value required", op, extraInfo.c_str()); |
| 373 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 374 | else |
| 375 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 376 | std::stringstream extraInfoStream; |
| 377 | extraInfoStream << "(" << message << ")"; |
| 378 | std::string extraInfo = extraInfoStream.str(); |
| 379 | error(line, " l-value required", op, extraInfo.c_str()); |
| 380 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 381 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 382 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 383 | } |
| 384 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 385 | // Both test, and if necessary spit out an error, to see if the node is really |
| 386 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 387 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 388 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 389 | if (node->getQualifier() != EvqConst) |
| 390 | { |
| 391 | error(node->getLine(), "constant expression required", ""); |
| 392 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 393 | } |
| 394 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 395 | // Both test, and if necessary spit out an error, to see if the node is really |
| 396 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 397 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 398 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 399 | if (!node->isScalarInt()) |
| 400 | { |
| 401 | error(node->getLine(), "integer expression required", token); |
| 402 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 403 | } |
| 404 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 405 | // Both test, and if necessary spit out an error, to see if we are currently |
| 406 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 407 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 408 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 409 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 410 | { |
| 411 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 412 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 413 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 414 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 415 | } |
| 416 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 417 | // For now, keep it simple: if it starts "gl_", it's reserved, independent |
| 418 | // of scope. Except, if the symbol table is at the built-in push-level, |
| 419 | // which is when we are parsing built-ins. |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 420 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a |
| 421 | // webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 422 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 423 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 424 | static const char *reservedErrMsg = "reserved built-in name"; |
| 425 | if (!symbolTable.atBuiltInLevel()) |
| 426 | { |
| 427 | if (identifier.compare(0, 3, "gl_") == 0) |
| 428 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 429 | error(line, reservedErrMsg, "gl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 430 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 431 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 432 | if (IsWebGLBasedSpec(mShaderSpec)) |
| 433 | { |
| 434 | if (identifier.compare(0, 6, "webgl_") == 0) |
| 435 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 436 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 437 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 438 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 439 | if (identifier.compare(0, 7, "_webgl_") == 0) |
| 440 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 441 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 442 | return false; |
alokp@chromium.org | 613ef31 | 2010-07-21 18:54:22 +0000 | [diff] [blame] | 443 | } |
| 444 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 445 | if (identifier.find("__") != TString::npos) |
| 446 | { |
| 447 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 448 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 449 | "possible future keywords", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 450 | identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 451 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 452 | } |
| 453 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 454 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 455 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 456 | } |
| 457 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 458 | // Make sure there is enough data provided to the constructor to build |
| 459 | // something of the type of the constructor. Also returns the type of |
| 460 | // the constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 461 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
| 462 | TIntermNode *argumentsNode, |
| 463 | const TFunction &function, |
| 464 | TOperator op, |
| 465 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 466 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 467 | bool constructingMatrix = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 468 | switch (op) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 469 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 470 | case EOpConstructMat2: |
| 471 | case EOpConstructMat2x3: |
| 472 | case EOpConstructMat2x4: |
| 473 | case EOpConstructMat3x2: |
| 474 | case EOpConstructMat3: |
| 475 | case EOpConstructMat3x4: |
| 476 | case EOpConstructMat4x2: |
| 477 | case EOpConstructMat4x3: |
| 478 | case EOpConstructMat4: |
| 479 | constructingMatrix = true; |
| 480 | break; |
| 481 | default: |
| 482 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 483 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 484 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 485 | // |
| 486 | // Note: It's okay to have too many components available, but not okay to have unused |
| 487 | // arguments. 'full' will go to true when enough args have been seen. If we loop |
| 488 | // again, there is an extra argument, so 'overfull' will become true. |
| 489 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 490 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 491 | size_t size = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 492 | bool full = false; |
| 493 | bool overFull = false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 494 | bool matrixInMatrix = false; |
| 495 | bool arrayArg = false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 496 | for (size_t i = 0; i < function.getParamCount(); ++i) |
| 497 | { |
Dmitry Skiba | efa3d8e | 2015-06-22 14:52:10 -0700 | [diff] [blame] | 498 | const TConstParameter ¶m = function.getParam(i); |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 499 | size += param.type->getObjectSize(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 500 | |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 501 | if (constructingMatrix && param.type->isMatrix()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 502 | matrixInMatrix = true; |
| 503 | if (full) |
| 504 | overFull = true; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 505 | if (op != EOpConstructStruct && !type.isArray() && size >= type.getObjectSize()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 506 | full = true; |
alokp@chromium.org | b19403a | 2010-09-08 17:56:26 +0000 | [diff] [blame] | 507 | if (param.type->isArray()) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 508 | arrayArg = true; |
| 509 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 510 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 511 | if (type.isArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 512 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 513 | // The size of an unsized constructor should already have been determined. |
| 514 | ASSERT(!type.isUnsizedArray()); |
| 515 | if (static_cast<size_t>(type.getArraySize()) != function.getParamCount()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 516 | { |
| 517 | error(line, "array constructor needs one argument per array element", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 518 | return false; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 519 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 520 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 521 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 522 | if (arrayArg && op != EOpConstructStruct) |
| 523 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 524 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 525 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 526 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 527 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 528 | if (matrixInMatrix && !type.isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 529 | { |
| 530 | if (function.getParamCount() != 1) |
| 531 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 532 | error(line, "constructing matrix from matrix can only take one argument", |
| 533 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 534 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 535 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 536 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 537 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 538 | if (overFull) |
| 539 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 540 | error(line, "too many arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 541 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 542 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 543 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 544 | if (op == EOpConstructStruct && !type.isArray() && |
| 545 | type.getStruct()->fields().size() != function.getParamCount()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 546 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 547 | error(line, |
| 548 | "Number of constructor parameters does not match the number of structure fields", |
| 549 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 550 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 551 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 552 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 553 | if (!type.isMatrix() || !matrixInMatrix) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 554 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 555 | if ((op != EOpConstructStruct && size != 1 && size < type.getObjectSize()) || |
| 556 | (op == EOpConstructStruct && size < type.getObjectSize())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 557 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 558 | error(line, "not enough data provided for construction", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 559 | return false; |
daniel@transgaming.com | bef0b6d | 2010-04-29 03:32:39 +0000 | [diff] [blame] | 560 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 561 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 562 | |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 563 | if (argumentsNode == nullptr) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 564 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 565 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 566 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 567 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 568 | |
| 569 | TIntermAggregate *argumentsAgg = argumentsNode->getAsAggregate(); |
| 570 | for (TIntermNode *&argNode : *argumentsAgg->getSequence()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 571 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 572 | TIntermTyped *argTyped = argNode->getAsTyped(); |
| 573 | ASSERT(argTyped != nullptr); |
| 574 | if (op != EOpConstructStruct && IsSampler(argTyped->getBasicType())) |
| 575 | { |
| 576 | error(line, "cannot convert a sampler", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 577 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 578 | } |
| 579 | if (argTyped->getBasicType() == EbtVoid) |
| 580 | { |
| 581 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 582 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 583 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 584 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 585 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 586 | if (type.isArray()) |
| 587 | { |
| 588 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 589 | // the array. |
| 590 | for (TIntermNode *&argNode : *argumentsAgg->getSequence()) |
| 591 | { |
| 592 | const TType &argType = argNode->getAsTyped()->getType(); |
| 593 | // It has already been checked that the argument is not an array. |
| 594 | ASSERT(!argType.isArray()); |
| 595 | if (!argType.sameElementType(type)) |
| 596 | { |
| 597 | error(line, "Array constructor argument has an incorrect type", "Error"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 598 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 599 | } |
| 600 | } |
| 601 | } |
| 602 | else if (op == EOpConstructStruct) |
| 603 | { |
| 604 | const TFieldList &fields = type.getStruct()->fields(); |
| 605 | TIntermSequence *args = argumentsAgg->getSequence(); |
| 606 | |
| 607 | for (size_t i = 0; i < fields.size(); i++) |
| 608 | { |
| 609 | if (i >= args->size() || (*args)[i]->getAsTyped()->getType() != *fields[i]->type()) |
| 610 | { |
| 611 | error(line, "Structure constructor arguments do not match structure fields", |
| 612 | "Error"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 613 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 614 | } |
| 615 | } |
| 616 | } |
| 617 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 618 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 619 | } |
| 620 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 621 | // This function checks to see if a void variable has been declared and raise an error message for |
| 622 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 623 | // |
| 624 | // returns true in case of an error |
| 625 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 626 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 627 | const TString &identifier, |
| 628 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 629 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 630 | if (type == EbtVoid) |
| 631 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 632 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 633 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 634 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 635 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 636 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 637 | } |
| 638 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 639 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 640 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 641 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 642 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 643 | if (type->getBasicType() != EbtBool || type->isArray() || type->isMatrix() || type->isVector()) |
| 644 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 645 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 646 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 647 | } |
| 648 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 649 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 650 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 651 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 652 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 653 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 654 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 655 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 656 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 657 | } |
| 658 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 659 | bool TParseContext::checkIsNotSampler(const TSourceLoc &line, |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 660 | const TTypeSpecifierNonArray &pType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 661 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 662 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 663 | if (pType.type == EbtStruct) |
| 664 | { |
| 665 | if (containsSampler(*pType.userDef)) |
| 666 | { |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 667 | error(line, reason, getBasicString(pType.type), "(structure contains a sampler)"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 668 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 669 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 670 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 671 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 672 | } |
| 673 | else if (IsSampler(pType.type)) |
| 674 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 675 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 676 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 677 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 678 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 679 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 680 | } |
| 681 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 682 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 683 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 684 | { |
| 685 | if (pType.layoutQualifier.location != -1) |
| 686 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 687 | error(line, "location must only be specified for a single input or output variable", |
| 688 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 689 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 690 | } |
| 691 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 692 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 693 | const TLayoutQualifier &layoutQualifier) |
| 694 | { |
| 695 | if (layoutQualifier.location != -1) |
| 696 | { |
| 697 | error(location, "invalid layout qualifier:", "location", |
| 698 | "only valid on program inputs and outputs"); |
| 699 | } |
| 700 | } |
| 701 | |
| 702 | void TParseContext::checkOutParameterIsNotSampler(const TSourceLoc &line, |
| 703 | TQualifier qualifier, |
| 704 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 705 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 706 | if ((qualifier == EvqOut || qualifier == EvqInOut) && type.getBasicType() != EbtStruct && |
| 707 | IsSampler(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 708 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 709 | error(line, "samplers cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 710 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 711 | } |
| 712 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 713 | bool TParseContext::containsSampler(const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 714 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 715 | if (IsSampler(type.getBasicType())) |
| 716 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 717 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 718 | if (type.getBasicType() == EbtStruct || type.isInterfaceBlock()) |
| 719 | { |
| 720 | const TFieldList &fields = type.getStruct()->fields(); |
| 721 | for (unsigned int i = 0; i < fields.size(); ++i) |
| 722 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 723 | if (containsSampler(*fields[i]->type())) |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 724 | return true; |
| 725 | } |
| 726 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 727 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 728 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 729 | } |
| 730 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 731 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 732 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 733 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 734 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 735 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 736 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 737 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 738 | // fold as array size. |
| 739 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 740 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 741 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 742 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 743 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 744 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 745 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 746 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 747 | if (constant->getBasicType() == EbtUInt) |
| 748 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 749 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 750 | } |
| 751 | else |
| 752 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 753 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 754 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 755 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 756 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 757 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 758 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 759 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 760 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 761 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 762 | } |
| 763 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 764 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 765 | { |
| 766 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 767 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 768 | } |
| 769 | |
| 770 | // The size of arrays is restricted here to prevent issues further down the |
| 771 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 772 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 773 | const unsigned int sizeLimit = 65536; |
| 774 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 775 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 776 | { |
| 777 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 778 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 779 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 780 | |
| 781 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 782 | } |
| 783 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 784 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 785 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 786 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 787 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 788 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 789 | (elementQualifier.qualifier == EvqVertexIn) || |
| 790 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 791 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 792 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 793 | TType(elementQualifier).getQualifierString()); |
| 794 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 795 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 796 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 797 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 798 | } |
| 799 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 800 | // See if this element type can be formed into an array. |
| 801 | bool TParseContext::checkIsValidTypeForArray(const TSourceLoc &line, const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 802 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 803 | // |
| 804 | // Can the type be an array? |
| 805 | // |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 806 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 807 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 808 | error(line, "cannot declare arrays of arrays", |
| 809 | TType(elementType).getCompleteString().c_str()); |
| 810 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 811 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 812 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 813 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 814 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 815 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 816 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 817 | { |
| 818 | error(line, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 819 | TType(elementType).getCompleteString().c_str()); |
| 820 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 821 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 822 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 823 | return true; |
| 824 | } |
| 825 | |
| 826 | // Check if this qualified element type can be formed into an array. |
| 827 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 828 | const TPublicType &elementType) |
| 829 | { |
| 830 | if (checkIsValidTypeForArray(indexLocation, elementType)) |
| 831 | { |
| 832 | return checkIsValidQualifierForArray(indexLocation, elementType); |
| 833 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 834 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 835 | } |
| 836 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 837 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 838 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 839 | const TString &identifier, |
| 840 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 841 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 842 | ASSERT(type != nullptr); |
| 843 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 844 | { |
| 845 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 846 | type->qualifier = EvqTemporary; |
| 847 | |
| 848 | // Generate informative error messages for ESSL1. |
| 849 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 850 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 851 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 852 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 853 | "structures containing arrays may not be declared constant since they cannot be " |
| 854 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 855 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 856 | } |
| 857 | else |
| 858 | { |
| 859 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 860 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 861 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 862 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 863 | if (type->isUnsizedArray()) |
| 864 | { |
| 865 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 866 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 867 | } |
| 868 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 869 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 870 | // and update the symbol table. |
| 871 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 872 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 873 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 874 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 875 | const TString &identifier, |
| 876 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 877 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 878 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 879 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 880 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 881 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 882 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 883 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 884 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 885 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 886 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 887 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 888 | if (static_cast<int>(type.getArraySize()) == maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 889 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 890 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 891 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 892 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 893 | } |
| 894 | } |
| 895 | else |
| 896 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 897 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 898 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 899 | return false; |
| 900 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 901 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 902 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 903 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 904 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 905 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 906 | (*variable) = new TVariable(&identifier, type); |
| 907 | if (!symbolTable.declare(*variable)) |
| 908 | { |
| 909 | error(line, "redefinition", identifier.c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 910 | *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 911 | return false; |
| 912 | } |
| 913 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 914 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 915 | return false; |
| 916 | |
| 917 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 918 | } |
| 919 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 920 | void TParseContext::checkIsParameterQualifierValid( |
| 921 | const TSourceLoc &line, |
| 922 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 923 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 924 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 925 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(&mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 926 | |
| 927 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 928 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 929 | checkOutParameterIsNotSampler(line, typeQualifier.qualifier, *type); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 930 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 931 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 932 | type->setQualifier(typeQualifier.qualifier); |
| 933 | |
| 934 | if (typeQualifier.precision != EbpUndefined) |
| 935 | { |
| 936 | type->setPrecision(typeQualifier.precision); |
| 937 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 938 | } |
| 939 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 940 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 941 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 942 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 943 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 944 | if (iter == extBehavior.end()) |
| 945 | { |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 946 | error(line, "extension", extension.c_str(), "is not supported"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 947 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 948 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 949 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 950 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 951 | { |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 952 | error(line, "extension", extension.c_str(), "is disabled"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 953 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 954 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 955 | if (iter->second == EBhWarn) |
| 956 | { |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 957 | warning(line, "extension", extension.c_str(), "is being used"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 958 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 959 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 960 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 961 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 962 | } |
| 963 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 964 | // These checks are common for all declarations starting a declarator list, and declarators that |
| 965 | // follow an empty declaration. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 966 | void TParseContext::singleDeclarationErrorCheck(const TPublicType &publicType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 967 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 968 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 969 | switch (publicType.qualifier) |
| 970 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 971 | case EvqVaryingIn: |
| 972 | case EvqVaryingOut: |
| 973 | case EvqAttribute: |
| 974 | case EvqVertexIn: |
| 975 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 976 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 977 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 978 | { |
| 979 | error(identifierLocation, "cannot be used with a structure", |
| 980 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 981 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 982 | } |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 983 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 984 | default: |
| 985 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 986 | } |
| 987 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 988 | if (publicType.qualifier != EvqUniform && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 989 | !checkIsNotSampler(identifierLocation, publicType.typeSpecifierNonArray, |
| 990 | "samplers must be uniform")) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 991 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 992 | return; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 993 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 994 | |
| 995 | // check for layout qualifier issues |
| 996 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
| 997 | |
| 998 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 999 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1000 | error(identifierLocation, "layout qualifier", |
| 1001 | getMatrixPackingString(layoutQualifier.matrixPacking), |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1002 | "only valid for interface blocks"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1003 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1004 | } |
| 1005 | |
| 1006 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1007 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1008 | error(identifierLocation, "layout qualifier", |
| 1009 | getBlockStorageString(layoutQualifier.blockStorage), |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1010 | "only valid for interface blocks"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1011 | return; |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1012 | } |
| 1013 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1014 | if (publicType.qualifier != EvqVertexIn && publicType.qualifier != EvqFragmentOut) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1015 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1016 | checkLocationIsNotSpecified(identifierLocation, publicType.layoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1017 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1018 | } |
| 1019 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1020 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1021 | const TString &layoutQualifierName, |
| 1022 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1023 | { |
| 1024 | |
| 1025 | if (mShaderVersion < versionRequired) |
| 1026 | { |
| 1027 | error(location, "invalid layout qualifier:", layoutQualifierName.c_str(), "not supported"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1028 | } |
| 1029 | } |
| 1030 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1031 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1032 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1033 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1034 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1035 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1036 | { |
| 1037 | if (localSize[i] != -1) |
| 1038 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1039 | error(location, "invalid layout qualifier:", getWorkGroupSizeString(i), |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1040 | "only valid when used with 'in' in a compute shader global layout declaration"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1041 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1042 | } |
| 1043 | } |
| 1044 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1045 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1046 | } |
| 1047 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1048 | void TParseContext::functionCallLValueErrorCheck(const TFunction *fnCandidate, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1049 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1050 | { |
| 1051 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1052 | { |
| 1053 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
| 1054 | if (qual == EvqOut || qual == EvqInOut) |
| 1055 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1056 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1057 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1058 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1059 | error(argument->getLine(), |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1060 | "Constant value cannot be passed for 'out' or 'inout' parameters.", "Error"); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1061 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1062 | } |
| 1063 | } |
| 1064 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1065 | } |
| 1066 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1067 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1068 | const TQualifier qualifier, |
| 1069 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1070 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1071 | if (!invariant) |
| 1072 | return; |
| 1073 | |
| 1074 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1075 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1076 | // input variables in the fragment shader can be also qualified as invariant |
| 1077 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1078 | { |
| 1079 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1080 | } |
| 1081 | } |
| 1082 | else |
| 1083 | { |
| 1084 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1085 | { |
| 1086 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1087 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1088 | } |
| 1089 | } |
| 1090 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1091 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1092 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1093 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1094 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1095 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1096 | } |
| 1097 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1098 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1099 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1100 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1101 | } |
| 1102 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1103 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1104 | const char *extName, |
| 1105 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1106 | { |
| 1107 | pp::SourceLocation srcLoc; |
| 1108 | srcLoc.file = loc.first_file; |
| 1109 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1110 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1111 | } |
| 1112 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1113 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1114 | const char *name, |
| 1115 | const char *value, |
| 1116 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1117 | { |
| 1118 | pp::SourceLocation srcLoc; |
| 1119 | srcLoc.file = loc.first_file; |
| 1120 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1121 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1122 | } |
| 1123 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1124 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1125 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1126 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1127 | for (size_t i = 0u; i < result.size(); ++i) |
| 1128 | { |
| 1129 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1130 | { |
| 1131 | result[i] = 1; |
| 1132 | } |
| 1133 | else |
| 1134 | { |
| 1135 | result[i] = mComputeShaderLocalSize[i]; |
| 1136 | } |
| 1137 | } |
| 1138 | return result; |
| 1139 | } |
| 1140 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1141 | ///////////////////////////////////////////////////////////////////////////////// |
| 1142 | // |
| 1143 | // Non-Errors. |
| 1144 | // |
| 1145 | ///////////////////////////////////////////////////////////////////////////////// |
| 1146 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1147 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1148 | const TString *name, |
| 1149 | const TSymbol *symbol) |
| 1150 | { |
| 1151 | const TVariable *variable = NULL; |
| 1152 | |
| 1153 | if (!symbol) |
| 1154 | { |
| 1155 | error(location, "undeclared identifier", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1156 | } |
| 1157 | else if (!symbol->isVariable()) |
| 1158 | { |
| 1159 | error(location, "variable expected", name->c_str()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1160 | } |
| 1161 | else |
| 1162 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1163 | variable = static_cast<const TVariable *>(symbol); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1164 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1165 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1166 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1167 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1168 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1169 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1170 | |
| 1171 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1172 | TQualifier qualifier = variable->getType().getQualifier(); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1173 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1174 | { |
| 1175 | mUsesFragData = true; |
| 1176 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1177 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1178 | { |
| 1179 | mUsesFragColor = true; |
| 1180 | } |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1181 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1182 | { |
| 1183 | mUsesSecondaryOutputs = true; |
| 1184 | } |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1185 | |
| 1186 | // This validation is not quite correct - it's only an error to write to |
| 1187 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1188 | // be rewarded for reading from undefined varaibles, return an error |
| 1189 | // if they are both referenced, rather than assigned. |
| 1190 | if (mUsesFragData && mUsesFragColor) |
| 1191 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1192 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1193 | if (mUsesSecondaryOutputs) |
| 1194 | { |
| 1195 | errorMessage = |
| 1196 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1197 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1198 | } |
| 1199 | error(location, errorMessage, name->c_str()); |
Jamie Madill | 14e95b3 | 2015-05-07 10:10:41 -0400 | [diff] [blame] | 1200 | } |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 1201 | |
| 1202 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1203 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1204 | qualifier == EvqWorkGroupSize) |
| 1205 | { |
| 1206 | error(location, |
| 1207 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1208 | "gl_WorkGroupSize"); |
| 1209 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1210 | } |
| 1211 | |
| 1212 | if (!variable) |
| 1213 | { |
| 1214 | TType type(EbtFloat, EbpUndefined); |
| 1215 | TVariable *fakeVariable = new TVariable(name, type); |
| 1216 | symbolTable.declare(fakeVariable); |
| 1217 | variable = fakeVariable; |
| 1218 | } |
| 1219 | |
| 1220 | return variable; |
| 1221 | } |
| 1222 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1223 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1224 | const TString *name, |
| 1225 | const TSymbol *symbol) |
| 1226 | { |
| 1227 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1228 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1229 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1230 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1231 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1232 | return intermediate.addConstantUnion(constArray, variable->getType(), location); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1233 | } |
| 1234 | else |
| 1235 | { |
| 1236 | return intermediate.addSymbol(variable->getUniqueId(), variable->getName(), |
| 1237 | variable->getType(), location); |
| 1238 | } |
| 1239 | } |
| 1240 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1241 | // |
| 1242 | // Look up a function name in the symbol table, and make sure it is a function. |
| 1243 | // |
| 1244 | // Return the function symbol if found, otherwise 0. |
| 1245 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1246 | const TFunction *TParseContext::findFunction(const TSourceLoc &line, |
| 1247 | TFunction *call, |
| 1248 | int inputShaderVersion, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1249 | bool *builtIn) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1250 | { |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1251 | // First find by unmangled name to check whether the function name has been |
| 1252 | // hidden by a variable name or struct typename. |
Nicolas Capens | d4a9b8d | 2013-07-18 11:01:22 -0400 | [diff] [blame] | 1253 | // If a function is found, check for one with a matching argument list. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1254 | const TSymbol *symbol = symbolTable.find(call->getName(), inputShaderVersion, builtIn); |
| 1255 | if (symbol == 0 || symbol->isFunction()) |
| 1256 | { |
Austin Kinross | 3ae6465 | 2015-01-26 15:51:39 -0800 | [diff] [blame] | 1257 | symbol = symbolTable.find(call->getMangledName(), inputShaderVersion, builtIn); |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1258 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1259 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1260 | if (symbol == 0) |
| 1261 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1262 | error(line, "no matching overloaded function found", call->getName().c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1263 | return 0; |
| 1264 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1265 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1266 | if (!symbol->isFunction()) |
| 1267 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1268 | error(line, "function name expected", call->getName().c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1269 | return 0; |
| 1270 | } |
alokp@chromium.org | 0a57618 | 2010-08-09 17:16:27 +0000 | [diff] [blame] | 1271 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1272 | return static_cast<const TFunction *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1273 | } |
| 1274 | |
| 1275 | // |
| 1276 | // Initializers show up in several places in the grammar. Have one set of |
| 1277 | // code to handle them here. |
| 1278 | // |
Jamie Madill | 3b5c2da | 2014-08-19 15:23:32 -0400 | [diff] [blame] | 1279 | // Returns true on error, false if no error |
| 1280 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1281 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1282 | const TString &identifier, |
| 1283 | const TPublicType &pType, |
| 1284 | TIntermTyped *initializer, |
| 1285 | TIntermNode **intermNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1286 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1287 | ASSERT(intermNode != nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1288 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1289 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1290 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1291 | if (type.isUnsizedArray()) |
| 1292 | { |
| 1293 | type.setArraySize(initializer->getArraySize()); |
| 1294 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1295 | if (!declareVariable(line, identifier, type, &variable)) |
| 1296 | { |
| 1297 | return true; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1298 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1299 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1300 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1301 | if (symbolTable.atGlobalLevel() && |
| 1302 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1303 | { |
| 1304 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1305 | // we want to steer developers towards only using constant expressions. |
| 1306 | error(line, "global variable initializers must be constant expressions", "="); |
| 1307 | return true; |
| 1308 | } |
| 1309 | if (globalInitWarning) |
| 1310 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1311 | warning( |
| 1312 | line, |
| 1313 | "global variable initializers should be constant expressions " |
| 1314 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1315 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1316 | } |
| 1317 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1318 | // |
| 1319 | // identifier must be of type constant, a global, or a temporary |
| 1320 | // |
| 1321 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1322 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1323 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1324 | error(line, " cannot initialize this type of qualifier ", |
| 1325 | variable->getType().getQualifierString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1326 | return true; |
| 1327 | } |
| 1328 | // |
| 1329 | // test for and propagate constant |
| 1330 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1331 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1332 | if (qualifier == EvqConst) |
| 1333 | { |
| 1334 | if (qualifier != initializer->getType().getQualifier()) |
| 1335 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 1336 | std::stringstream extraInfoStream; |
| 1337 | extraInfoStream << "'" << variable->getType().getCompleteString() << "'"; |
| 1338 | std::string extraInfo = extraInfoStream.str(); |
| 1339 | error(line, " assigning non-constant to", "=", extraInfo.c_str()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1340 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1341 | return true; |
| 1342 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1343 | if (type != initializer->getType()) |
| 1344 | { |
| 1345 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1346 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1347 | variable->getType().setQualifier(EvqTemporary); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1348 | return true; |
| 1349 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1350 | |
| 1351 | // Save the constant folded value to the variable if possible. For example array |
| 1352 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1353 | // in the shader is avoided. |
| 1354 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1355 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1356 | if (initializer->getAsConstantUnion()) |
| 1357 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1358 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1359 | *intermNode = nullptr; |
| 1360 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1361 | } |
| 1362 | else if (initializer->getAsSymbolNode()) |
| 1363 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1364 | const TSymbol *symbol = |
| 1365 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1366 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1367 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1368 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1369 | if (constArray) |
| 1370 | { |
| 1371 | variable->shareConstPointer(constArray); |
| 1372 | *intermNode = nullptr; |
| 1373 | return false; |
| 1374 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1375 | } |
| 1376 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1377 | |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1378 | TIntermSymbol *intermSymbol = intermediate.addSymbol( |
| 1379 | variable->getUniqueId(), variable->getName(), variable->getType(), line); |
| 1380 | *intermNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1381 | if (*intermNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1382 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1383 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
| 1384 | return true; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1385 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1386 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1387 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1388 | } |
| 1389 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1390 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1391 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1392 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1393 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1394 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1395 | TPublicType returnType = typeSpecifier; |
| 1396 | returnType.qualifier = typeQualifier.qualifier; |
| 1397 | returnType.invariant = typeQualifier.invariant; |
| 1398 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
| 1399 | returnType.precision = typeSpecifier.precision; |
| 1400 | |
| 1401 | if (typeQualifier.precision != EbpUndefined) |
| 1402 | { |
| 1403 | returnType.precision = typeQualifier.precision; |
| 1404 | } |
| 1405 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1406 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 1407 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1408 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1409 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 1410 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1411 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1412 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1413 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1414 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1415 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1416 | if (typeSpecifier.array) |
| 1417 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1418 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 1419 | returnType.clearArrayness(); |
| 1420 | } |
| 1421 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1422 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1423 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1424 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1425 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1426 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1427 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1428 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1429 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1430 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1431 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1432 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1433 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1434 | } |
| 1435 | } |
| 1436 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1437 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1438 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1439 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1440 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 1441 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1442 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 1443 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1444 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1445 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 1446 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 1447 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1448 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1449 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1450 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1451 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1452 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 1453 | } |
| 1454 | |
| 1455 | return returnType; |
| 1456 | } |
| 1457 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1458 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 1459 | const TPublicType &type, |
| 1460 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1461 | { |
| 1462 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1463 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1464 | { |
| 1465 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1466 | } |
| 1467 | |
| 1468 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 1469 | switch (qualifier) |
| 1470 | { |
| 1471 | case EvqVertexIn: |
| 1472 | // ESSL 3.00 section 4.3.4 |
| 1473 | if (type.array) |
| 1474 | { |
| 1475 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1476 | } |
| 1477 | // Vertex inputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1478 | return; |
| 1479 | case EvqFragmentOut: |
| 1480 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1481 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1482 | { |
| 1483 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1484 | } |
| 1485 | // Fragment outputs with a struct type are disallowed in singleDeclarationErrorCheck |
| 1486 | return; |
| 1487 | default: |
| 1488 | break; |
| 1489 | } |
| 1490 | |
| 1491 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 1492 | // restrictions. |
| 1493 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1494 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 1495 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1496 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 1497 | { |
| 1498 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 1499 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1500 | } |
| 1501 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1502 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1503 | { |
| 1504 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 1505 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 1506 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 1507 | if (type.array) |
| 1508 | { |
| 1509 | error(qualifierLocation, "cannot be an array of structures", |
| 1510 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1511 | } |
| 1512 | if (type.isStructureContainingArrays()) |
| 1513 | { |
| 1514 | error(qualifierLocation, "cannot be a structure containing an array", |
| 1515 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1516 | } |
| 1517 | if (type.isStructureContainingType(EbtStruct)) |
| 1518 | { |
| 1519 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 1520 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1521 | } |
| 1522 | if (type.isStructureContainingType(EbtBool)) |
| 1523 | { |
| 1524 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 1525 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1526 | } |
| 1527 | } |
| 1528 | } |
| 1529 | |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1530 | TIntermAggregate *TParseContext::parseSingleDeclaration(TPublicType &publicType, |
| 1531 | const TSourceLoc &identifierOrTypeLocation, |
| 1532 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1533 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1534 | TType type(publicType); |
| 1535 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 1536 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 1537 | { |
| 1538 | TQualifier qualifier = type.getQualifier(); |
| 1539 | |
| 1540 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 1541 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 1542 | // affected variable declarations: |
| 1543 | // |
| 1544 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 1545 | // elsewhere, in TranslatorGLSL.) |
| 1546 | // |
| 1547 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 1548 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 1549 | // the way this is currently implemented we have to enable this compiler option before |
| 1550 | // parsing the shader and determining the shading language version it uses. If this were |
| 1551 | // implemented as a post-pass, the workaround could be more targeted. |
| 1552 | // |
| 1553 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 1554 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 1555 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 1556 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 1557 | { |
| 1558 | type.setInvariant(true); |
| 1559 | } |
| 1560 | } |
| 1561 | |
| 1562 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, type, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1563 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1564 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1565 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1566 | mDeferredSingleDeclarationErrorCheck = emptyDeclaration; |
| 1567 | |
| 1568 | if (emptyDeclaration) |
| 1569 | { |
| 1570 | if (publicType.isUnsizedArray()) |
| 1571 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1572 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1573 | // error. It is assumed that this applies to empty declarations as well. |
| 1574 | error(identifierOrTypeLocation, "empty array declaration needs to specify a size", |
| 1575 | identifier.c_str()); |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 1576 | } |
| 1577 | } |
| 1578 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1579 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1580 | singleDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1581 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1582 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1583 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1584 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 1585 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1586 | |
| 1587 | if (variable && symbol) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1588 | symbol->setId(variable->getUniqueId()); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1589 | } |
| 1590 | |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1591 | return TIntermediate::MakeAggregate(symbol, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1592 | } |
| 1593 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1594 | TIntermAggregate *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 1595 | const TSourceLoc &identifierLocation, |
| 1596 | const TString &identifier, |
| 1597 | const TSourceLoc &indexLocation, |
| 1598 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1599 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1600 | mDeferredSingleDeclarationErrorCheck = false; |
| 1601 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1602 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1603 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1604 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1605 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1606 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1607 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1608 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1609 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1610 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1611 | // Make the type an array even if size check failed. |
| 1612 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1613 | arrayType.setArraySize(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1614 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1615 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1616 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1617 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1618 | TIntermSymbol *symbol = intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1619 | if (variable && symbol) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1620 | symbol->setId(variable->getUniqueId()); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1621 | |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1622 | return TIntermediate::MakeAggregate(symbol, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1623 | } |
| 1624 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 1625 | TIntermAggregate *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1626 | const TSourceLoc &identifierLocation, |
| 1627 | const TString &identifier, |
| 1628 | const TSourceLoc &initLocation, |
| 1629 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1630 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1631 | mDeferredSingleDeclarationErrorCheck = false; |
| 1632 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1633 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1634 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1635 | TIntermNode *intermNode = nullptr; |
| 1636 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &intermNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1637 | { |
| 1638 | // |
| 1639 | // Build intermediate representation |
| 1640 | // |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1641 | return intermNode ? TIntermediate::MakeAggregate(intermNode, initLocation) : nullptr; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1642 | } |
| 1643 | else |
| 1644 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1645 | return nullptr; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 1646 | } |
| 1647 | } |
| 1648 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1649 | TIntermAggregate *TParseContext::parseSingleArrayInitDeclaration( |
| 1650 | TPublicType &publicType, |
| 1651 | const TSourceLoc &identifierLocation, |
| 1652 | const TString &identifier, |
| 1653 | const TSourceLoc &indexLocation, |
| 1654 | TIntermTyped *indexExpression, |
| 1655 | const TSourceLoc &initLocation, |
| 1656 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1657 | { |
| 1658 | mDeferredSingleDeclarationErrorCheck = false; |
| 1659 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1660 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1661 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1662 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1663 | |
| 1664 | TPublicType arrayType(publicType); |
| 1665 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1666 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1667 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 1668 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1669 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1670 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1671 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1672 | } |
| 1673 | // Make the type an array even if size check failed. |
| 1674 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1675 | arrayType.setArraySize(size); |
| 1676 | |
| 1677 | // initNode will correspond to the whole of "type b[n] = initializer". |
| 1678 | TIntermNode *initNode = nullptr; |
| 1679 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 1680 | { |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1681 | return initNode ? TIntermediate::MakeAggregate(initNode, initLocation) : nullptr; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1682 | } |
| 1683 | else |
| 1684 | { |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1685 | return nullptr; |
| 1686 | } |
| 1687 | } |
| 1688 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1689 | TIntermAggregate *TParseContext::parseInvariantDeclaration( |
| 1690 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1691 | const TSourceLoc &identifierLoc, |
| 1692 | const TString *identifier, |
| 1693 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1694 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1695 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1696 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1697 | if (!typeQualifier.invariant) |
| 1698 | { |
| 1699 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 1700 | return nullptr; |
| 1701 | } |
| 1702 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 1703 | { |
| 1704 | return nullptr; |
| 1705 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1706 | if (!symbol) |
| 1707 | { |
| 1708 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1709 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1710 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1711 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1712 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1713 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 1714 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1715 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1716 | if (typeQualifier.precision != EbpUndefined) |
| 1717 | { |
| 1718 | error(identifierLoc, "invariant declaration specifies precision", |
| 1719 | getPrecisionString(typeQualifier.precision)); |
| 1720 | } |
| 1721 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 1722 | { |
| 1723 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 1724 | } |
| 1725 | |
| 1726 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
| 1727 | ASSERT(variable); |
| 1728 | const TType &type = variable->getType(); |
| 1729 | |
| 1730 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 1731 | typeQualifier.line); |
| 1732 | |
| 1733 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 1734 | |
| 1735 | TIntermSymbol *intermSymbol = |
| 1736 | intermediate.addSymbol(variable->getUniqueId(), *identifier, type, identifierLoc); |
| 1737 | |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 1738 | TIntermAggregate *aggregate = TIntermediate::MakeAggregate(intermSymbol, identifierLoc); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1739 | aggregate->setOp(EOpInvariantDeclaration); |
| 1740 | return aggregate; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 1741 | } |
| 1742 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1743 | TIntermAggregate *TParseContext::parseDeclarator(TPublicType &publicType, |
| 1744 | TIntermAggregate *aggregateDeclaration, |
| 1745 | const TSourceLoc &identifierLocation, |
| 1746 | const TString &identifier) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1747 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1748 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 1749 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1750 | if (mDeferredSingleDeclarationErrorCheck) |
| 1751 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1752 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1753 | mDeferredSingleDeclarationErrorCheck = false; |
| 1754 | } |
| 1755 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1756 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1757 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1758 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1759 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1760 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1761 | declareVariable(identifierLocation, identifier, TType(publicType), &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1762 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1763 | TIntermSymbol *symbol = |
| 1764 | intermediate.addSymbol(0, identifier, TType(publicType), identifierLocation); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1765 | if (variable && symbol) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1766 | symbol->setId(variable->getUniqueId()); |
| 1767 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1768 | return intermediate.growAggregate(aggregateDeclaration, symbol, identifierLocation); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1769 | } |
| 1770 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1771 | TIntermAggregate *TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 1772 | TIntermAggregate *aggregateDeclaration, |
| 1773 | const TSourceLoc &identifierLocation, |
| 1774 | const TString &identifier, |
| 1775 | const TSourceLoc &arrayLocation, |
| 1776 | TIntermTyped *indexExpression) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1777 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1778 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 1779 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1780 | if (mDeferredSingleDeclarationErrorCheck) |
| 1781 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1782 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1783 | mDeferredSingleDeclarationErrorCheck = false; |
| 1784 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1785 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1786 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1787 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1788 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1789 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1790 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1791 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1792 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1793 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 693c9aa | 2015-04-07 17:50:36 +0300 | [diff] [blame] | 1794 | arrayType.setArraySize(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1795 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1796 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1797 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1798 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1799 | TIntermSymbol *symbol = |
| 1800 | intermediate.addSymbol(0, identifier, arrayType, identifierLocation); |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1801 | if (variable && symbol) |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1802 | symbol->setId(variable->getUniqueId()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1803 | |
| 1804 | return intermediate.growAggregate(aggregateDeclaration, symbol, identifierLocation); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1805 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1806 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 1807 | return nullptr; |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1808 | } |
| 1809 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1810 | TIntermAggregate *TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 1811 | TIntermAggregate *aggregateDeclaration, |
| 1812 | const TSourceLoc &identifierLocation, |
| 1813 | const TString &identifier, |
| 1814 | const TSourceLoc &initLocation, |
| 1815 | TIntermTyped *initializer) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1816 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1817 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 1818 | // not performed. |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1819 | if (mDeferredSingleDeclarationErrorCheck) |
| 1820 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1821 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1822 | mDeferredSingleDeclarationErrorCheck = false; |
| 1823 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1824 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1825 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1826 | |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1827 | TIntermNode *intermNode = nullptr; |
| 1828 | if (!executeInitializer(identifierLocation, identifier, publicType, initializer, &intermNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1829 | { |
| 1830 | // |
| 1831 | // build the intermediate representation |
| 1832 | // |
| 1833 | if (intermNode) |
| 1834 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1835 | return intermediate.growAggregate(aggregateDeclaration, intermNode, initLocation); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1836 | } |
| 1837 | else |
| 1838 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1839 | return aggregateDeclaration; |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1840 | } |
| 1841 | } |
| 1842 | else |
| 1843 | { |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1844 | return nullptr; |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1845 | } |
| 1846 | } |
| 1847 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 1848 | TIntermAggregate *TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1849 | TIntermAggregate *aggregateDeclaration, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1850 | const TSourceLoc &identifierLocation, |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1851 | const TString &identifier, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1852 | const TSourceLoc &indexLocation, |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1853 | TIntermTyped *indexExpression, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1854 | const TSourceLoc &initLocation, |
| 1855 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1856 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1857 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 1858 | // not performed. |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1859 | if (mDeferredSingleDeclarationErrorCheck) |
| 1860 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1861 | singleDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1862 | mDeferredSingleDeclarationErrorCheck = false; |
| 1863 | } |
| 1864 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1865 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1866 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1867 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1868 | |
| 1869 | TPublicType arrayType(publicType); |
| 1870 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1871 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1872 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 1873 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1874 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1875 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1876 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1877 | } |
| 1878 | // Make the type an array even if size check failed. |
| 1879 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 1880 | arrayType.setArraySize(size); |
| 1881 | |
| 1882 | // initNode will correspond to the whole of "b[n] = initializer". |
| 1883 | TIntermNode *initNode = nullptr; |
| 1884 | if (!executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
| 1885 | { |
| 1886 | if (initNode) |
| 1887 | { |
| 1888 | return intermediate.growAggregate(aggregateDeclaration, initNode, initLocation); |
| 1889 | } |
| 1890 | else |
| 1891 | { |
| 1892 | return aggregateDeclaration; |
| 1893 | } |
| 1894 | } |
| 1895 | else |
| 1896 | { |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 1897 | return nullptr; |
| 1898 | } |
| 1899 | } |
| 1900 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1901 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1902 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 1903 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1904 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 1905 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1906 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 1907 | typeQualifier.line); |
| 1908 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 1909 | // It should never be the case, but some strange parser errors can send us here. |
| 1910 | if (layoutQualifier.isEmpty()) |
| 1911 | { |
| 1912 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 1913 | return; |
| 1914 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1915 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1916 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1917 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1918 | error(typeQualifier.line, "invalid combination:", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1919 | return; |
| 1920 | } |
| 1921 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1922 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1923 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1924 | if (mComputeShaderLocalSizeDeclared && |
| 1925 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 1926 | { |
| 1927 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 1928 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1929 | return; |
| 1930 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 1931 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1932 | if (mShaderVersion < 310) |
| 1933 | { |
| 1934 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1935 | return; |
| 1936 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 1937 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1938 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1939 | { |
| 1940 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1941 | return; |
| 1942 | } |
| 1943 | |
| 1944 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 1945 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 1946 | |
| 1947 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 1948 | maxComputeWorkGroupSize->getConstPointer(); |
| 1949 | |
| 1950 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 1951 | { |
| 1952 | if (layoutQualifier.localSize[i] != -1) |
| 1953 | { |
| 1954 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 1955 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 1956 | if (mComputeShaderLocalSize[i] < 1 || |
| 1957 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 1958 | { |
| 1959 | std::stringstream errorMessageStream; |
| 1960 | errorMessageStream << "Value must be at least 1 and no greater than " |
| 1961 | << maxComputeWorkGroupSizeValue; |
| 1962 | const std::string &errorMessage = errorMessageStream.str(); |
| 1963 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1964 | error(typeQualifier.line, "invalid value:", getWorkGroupSizeString(i), |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1965 | errorMessage.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1966 | return; |
| 1967 | } |
| 1968 | } |
| 1969 | } |
| 1970 | |
| 1971 | mComputeShaderLocalSizeDeclared = true; |
| 1972 | } |
| 1973 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 1974 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1975 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1976 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1977 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1978 | return; |
| 1979 | } |
| 1980 | |
| 1981 | if (typeQualifier.qualifier != EvqUniform) |
| 1982 | { |
| 1983 | error(typeQualifier.line, "invalid qualifier:", |
| 1984 | getQualifierString(typeQualifier.qualifier), "global layout must be uniform"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1985 | return; |
| 1986 | } |
| 1987 | |
| 1988 | if (mShaderVersion < 300) |
| 1989 | { |
| 1990 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 1991 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1992 | return; |
| 1993 | } |
| 1994 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1995 | checkLocationIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1996 | |
| 1997 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1998 | { |
| 1999 | mDefaultMatrixPacking = layoutQualifier.matrixPacking; |
| 2000 | } |
| 2001 | |
| 2002 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 2003 | { |
| 2004 | mDefaultBlockStorage = layoutQualifier.blockStorage; |
| 2005 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2006 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2007 | } |
| 2008 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2009 | TIntermAggregate *TParseContext::addFunctionPrototypeDeclaration(const TFunction &function, |
| 2010 | const TSourceLoc &location) |
| 2011 | { |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2012 | // Note: symbolTableFunction could be the same as function if this is the first declaration. |
| 2013 | // Either way the instance in the symbol table is used to track whether the function is declared |
| 2014 | // multiple times. |
| 2015 | TFunction *symbolTableFunction = |
| 2016 | static_cast<TFunction *>(symbolTable.find(function.getMangledName(), getShaderVersion())); |
| 2017 | if (symbolTableFunction->hasPrototypeDeclaration() && mShaderVersion == 100) |
| 2018 | { |
| 2019 | // ESSL 1.00.17 section 4.2.7. |
| 2020 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 2021 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2022 | } |
| 2023 | symbolTableFunction->setHasPrototypeDeclaration(); |
| 2024 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2025 | TIntermAggregate *prototype = new TIntermAggregate; |
| 2026 | prototype->setType(function.getReturnType()); |
| 2027 | prototype->setName(function.getMangledName()); |
| 2028 | prototype->setFunctionId(function.getUniqueId()); |
| 2029 | |
| 2030 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 2031 | { |
| 2032 | const TConstParameter ¶m = function.getParam(i); |
| 2033 | if (param.name != 0) |
| 2034 | { |
| 2035 | TVariable variable(param.name, *param.type); |
| 2036 | |
| 2037 | TIntermSymbol *paramSymbol = intermediate.addSymbol( |
| 2038 | variable.getUniqueId(), variable.getName(), variable.getType(), location); |
| 2039 | prototype = intermediate.growAggregate(prototype, paramSymbol, location); |
| 2040 | } |
| 2041 | else |
| 2042 | { |
| 2043 | TIntermSymbol *paramSymbol = intermediate.addSymbol(0, "", *param.type, location); |
| 2044 | prototype = intermediate.growAggregate(prototype, paramSymbol, location); |
| 2045 | } |
| 2046 | } |
| 2047 | |
| 2048 | prototype->setOp(EOpPrototype); |
| 2049 | |
| 2050 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2051 | |
| 2052 | if (!symbolTable.atGlobalLevel()) |
| 2053 | { |
| 2054 | // ESSL 3.00.4 section 4.2.4. |
| 2055 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 2056 | } |
| 2057 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2058 | return prototype; |
| 2059 | } |
| 2060 | |
| 2061 | TIntermAggregate *TParseContext::addFunctionDefinition(const TFunction &function, |
| 2062 | TIntermAggregate *functionPrototype, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2063 | TIntermBlock *functionBody, |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2064 | const TSourceLoc &location) |
| 2065 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2066 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2067 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 2068 | { |
| 2069 | error(location, "function does not return a value:", "", function.getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2070 | } |
| 2071 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2072 | TIntermAggregate *functionNode = new TIntermAggregate(EOpFunction); |
| 2073 | functionNode->setLine(location); |
| 2074 | |
| 2075 | ASSERT(functionPrototype != nullptr); |
| 2076 | functionNode->getSequence()->push_back(functionPrototype); |
| 2077 | |
| 2078 | if (functionBody == nullptr) |
| 2079 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 2080 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2081 | functionBody->setLine(location); |
| 2082 | } |
| 2083 | functionNode->getSequence()->push_back(functionBody); |
| 2084 | |
| 2085 | functionNode->setName(function.getMangledName().c_str()); |
| 2086 | functionNode->setType(function.getReturnType()); |
| 2087 | functionNode->setFunctionId(function.getUniqueId()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2088 | |
| 2089 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 2090 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2091 | } |
| 2092 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2093 | void TParseContext::parseFunctionPrototype(const TSourceLoc &location, |
| 2094 | TFunction *function, |
| 2095 | TIntermAggregate **aggregateOut) |
| 2096 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2097 | const TSymbol *builtIn = |
| 2098 | symbolTable.findBuiltIn(function->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2099 | |
| 2100 | if (builtIn) |
| 2101 | { |
| 2102 | error(location, "built-in functions cannot be redefined", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2103 | } |
| 2104 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2105 | TFunction *prevDec = |
| 2106 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2107 | // |
| 2108 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function |
| 2109 | // as it would have just been put in the symbol table. Otherwise, we're looking up |
| 2110 | // an earlier occurance. |
| 2111 | // |
| 2112 | if (prevDec->isDefined()) |
| 2113 | { |
| 2114 | // Then this function already has a body. |
| 2115 | error(location, "function already has a body", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2116 | } |
| 2117 | prevDec->setDefined(); |
| 2118 | // |
| 2119 | // Overload the unique ID of the definition to be the same unique ID as the declaration. |
| 2120 | // Eventually we will probably want to have only a single definition and just swap the |
| 2121 | // arguments to be the definition's arguments. |
| 2122 | // |
| 2123 | function->setUniqueId(prevDec->getUniqueId()); |
| 2124 | |
| 2125 | // Raise error message if main function takes any parameters or return anything other than void |
| 2126 | if (function->getName() == "main") |
| 2127 | { |
| 2128 | if (function->getParamCount() > 0) |
| 2129 | { |
| 2130 | error(location, "function cannot take any parameter(s)", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2131 | } |
| 2132 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 2133 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2134 | error(location, "", function->getReturnType().getBasicString(), |
| 2135 | "main function cannot return a value"); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2136 | } |
| 2137 | } |
| 2138 | |
| 2139 | // |
| 2140 | // Remember the return type for later checking for RETURN statements. |
| 2141 | // |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 2142 | mCurrentFunctionType = &(prevDec->getReturnType()); |
| 2143 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2144 | |
| 2145 | // |
| 2146 | // Insert parameters into the symbol table. |
| 2147 | // If the parameter has no name, it's not an error, just don't insert it |
| 2148 | // (could be used for unused args). |
| 2149 | // |
| 2150 | // Also, accumulate the list of parameters into the HIL, so lower level code |
| 2151 | // knows where to find parameters. |
| 2152 | // |
| 2153 | TIntermAggregate *paramNodes = new TIntermAggregate; |
| 2154 | for (size_t i = 0; i < function->getParamCount(); i++) |
| 2155 | { |
| 2156 | const TConstParameter ¶m = function->getParam(i); |
| 2157 | if (param.name != 0) |
| 2158 | { |
| 2159 | TVariable *variable = new TVariable(param.name, *param.type); |
| 2160 | // |
| 2161 | // Insert the parameters with name in the symbol table. |
| 2162 | // |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 2163 | if (!symbolTable.declare(variable)) |
| 2164 | { |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2165 | error(location, "redefinition", variable->getName().c_str()); |
Jamie Madill | 1a4b1b3 | 2015-07-23 18:27:13 -0400 | [diff] [blame] | 2166 | paramNodes = intermediate.growAggregate( |
| 2167 | paramNodes, intermediate.addSymbol(0, "", *param.type, location), location); |
| 2168 | continue; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2169 | } |
| 2170 | |
| 2171 | // |
| 2172 | // Add the parameter to the HIL |
| 2173 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2174 | TIntermSymbol *symbol = intermediate.addSymbol( |
| 2175 | variable->getUniqueId(), variable->getName(), variable->getType(), location); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2176 | |
| 2177 | paramNodes = intermediate.growAggregate(paramNodes, symbol, location); |
| 2178 | } |
| 2179 | else |
| 2180 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2181 | paramNodes = intermediate.growAggregate( |
| 2182 | paramNodes, intermediate.addSymbol(0, "", *param.type, location), location); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2183 | } |
| 2184 | } |
| 2185 | intermediate.setAggregateOperator(paramNodes, EOpParameters, location); |
| 2186 | *aggregateOut = paramNodes; |
| 2187 | setLoopNestingLevel(0); |
| 2188 | } |
| 2189 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2190 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2191 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2192 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2193 | // We don't know at this point whether this is a function definition or a prototype. |
| 2194 | // The definition production code will check for redefinitions. |
| 2195 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2196 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 2197 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 2198 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2199 | // |
| 2200 | TFunction *prevDec = |
| 2201 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2202 | |
| 2203 | if (getShaderVersion() >= 300 && symbolTable.hasUnmangledBuiltIn(function->getName().c_str())) |
| 2204 | { |
| 2205 | // With ESSL 3.00, names of built-in functions cannot be redeclared as functions. |
| 2206 | // Therefore overloading or redefining builtin functions is an error. |
| 2207 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 2208 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 2209 | } |
| 2210 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2211 | { |
| 2212 | if (prevDec->getReturnType() != function->getReturnType()) |
| 2213 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2214 | error(location, "overloaded functions must have the same return type", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2215 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2216 | } |
| 2217 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 2218 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2219 | if (prevDec->getParam(i).type->getQualifier() != |
| 2220 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2221 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2222 | error(location, "overloaded functions must have the same parameter qualifiers", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2223 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2224 | } |
| 2225 | } |
| 2226 | } |
| 2227 | |
| 2228 | // |
| 2229 | // Check for previously declared variables using the same name. |
| 2230 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 2231 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2232 | if (prevSym) |
| 2233 | { |
| 2234 | if (!prevSym->isFunction()) |
| 2235 | { |
| 2236 | error(location, "redefinition", function->getName().c_str(), "function"); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2237 | } |
| 2238 | } |
| 2239 | else |
| 2240 | { |
| 2241 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2242 | TFunction *newFunction = |
| 2243 | new TFunction(NewPoolTString(function->getName().c_str()), &function->getReturnType()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2244 | symbolTable.getOuterLevel()->insertUnmangled(newFunction); |
| 2245 | } |
| 2246 | |
| 2247 | // We're at the inner scope level of the function's arguments and body statement. |
| 2248 | // Add the function prototype to the surrounding scope instead. |
| 2249 | symbolTable.getOuterLevel()->insert(function); |
| 2250 | |
| 2251 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2252 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 2253 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 2254 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 2255 | // |
| 2256 | return function; |
| 2257 | } |
| 2258 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2259 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 2260 | const TString *name, |
| 2261 | const TSourceLoc &location) |
| 2262 | { |
| 2263 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 2264 | { |
| 2265 | error(location, "no qualifiers allowed for function return", |
| 2266 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2267 | } |
| 2268 | if (!type.layoutQualifier.isEmpty()) |
| 2269 | { |
| 2270 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2271 | } |
| 2272 | // make sure a sampler is not involved as well... |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2273 | checkIsNotSampler(location, type.typeSpecifierNonArray, |
| 2274 | "samplers can't be function return values"); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2275 | if (mShaderVersion < 300) |
| 2276 | { |
| 2277 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 2278 | // return values in ESSL 1.00. |
| 2279 | ASSERT(type.arraySize == 0 || mDiagnostics.numErrors() > 0); |
| 2280 | |
| 2281 | if (type.isStructureContainingArrays()) |
| 2282 | { |
| 2283 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 2284 | error(location, "structures containing arrays can't be function return values", |
| 2285 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 2286 | } |
| 2287 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 2288 | |
| 2289 | // Add the function as a prototype after parsing it (we do not support recursion) |
| 2290 | return new TFunction(name, new TType(type)); |
| 2291 | } |
| 2292 | |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2293 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicTypeIn) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2294 | { |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 2295 | TPublicType publicType = publicTypeIn; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2296 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2297 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2298 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 2299 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 2300 | } |
| 2301 | |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2302 | TOperator op = EOpNull; |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2303 | if (publicType.getUserDef()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2304 | { |
| 2305 | op = EOpConstructStruct; |
| 2306 | } |
| 2307 | else |
| 2308 | { |
Geoff Lang | 156d719 | 2016-07-21 16:11:00 -0400 | [diff] [blame] | 2309 | op = sh::TypeToConstructorOperator(TType(publicType)); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2310 | if (op == EOpNull) |
| 2311 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2312 | error(publicType.getLine(), "cannot construct this type", |
| 2313 | getBasicString(publicType.getBasicType())); |
| 2314 | publicType.setBasicType(EbtFloat); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2315 | op = EOpConstructFloat; |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2316 | } |
| 2317 | } |
| 2318 | |
| 2319 | TString tempString; |
Dmitry Skiba | 7f17a50 | 2015-06-22 15:08:39 -0700 | [diff] [blame] | 2320 | const TType *type = new TType(publicType); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 2321 | return new TFunction(&tempString, type, op); |
| 2322 | } |
| 2323 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2324 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 2325 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2326 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2327 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2328 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2329 | TIntermTyped *TParseContext::addConstructor(TIntermNode *arguments, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2330 | TOperator op, |
| 2331 | TFunction *fnCall, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2332 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2333 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2334 | TType type = fnCall->getReturnType(); |
| 2335 | if (type.isUnsizedArray()) |
| 2336 | { |
| 2337 | type.setArraySize(static_cast<unsigned int>(fnCall->getParamCount())); |
| 2338 | } |
| 2339 | bool constType = true; |
| 2340 | for (size_t i = 0; i < fnCall->getParamCount(); ++i) |
| 2341 | { |
| 2342 | const TConstParameter ¶m = fnCall->getParam(i); |
| 2343 | if (param.type->getQualifier() != EvqConst) |
| 2344 | constType = false; |
| 2345 | } |
| 2346 | if (constType) |
| 2347 | type.setQualifier(EvqConst); |
| 2348 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2349 | if (!checkConstructorArguments(line, arguments, *fnCall, op, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2350 | { |
| 2351 | TIntermTyped *dummyNode = intermediate.setAggregateOperator(nullptr, op, line); |
| 2352 | dummyNode->setType(type); |
| 2353 | return dummyNode; |
| 2354 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 2355 | TIntermAggregate *constructor = arguments->getAsAggregate(); |
| 2356 | ASSERT(constructor != nullptr); |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2357 | |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2358 | // Turn the argument list itself into a constructor |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 2359 | constructor->setOp(op); |
| 2360 | constructor->setLine(line); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2361 | ASSERT(constructor->isConstructor()); |
| 2362 | |
| 2363 | // Need to set type before setPrecisionFromChildren() because bool doesn't have precision. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2364 | constructor->setType(type); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2365 | |
Olli Etuaho | 2120370 | 2014-11-13 16:16:21 +0200 | [diff] [blame] | 2366 | // Structs should not be precision qualified, the individual members may be. |
| 2367 | // Built-in types on the other hand should be precision qualified. |
| 2368 | if (op != EOpConstructStruct) |
| 2369 | { |
| 2370 | constructor->setPrecisionFromChildren(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2371 | type.setPrecision(constructor->getPrecision()); |
Olli Etuaho | 2120370 | 2014-11-13 16:16:21 +0200 | [diff] [blame] | 2372 | } |
| 2373 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2374 | constructor->setType(type); |
| 2375 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 2376 | TIntermTyped *constConstructor = intermediate.foldAggregateBuiltIn(constructor, &mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2377 | if (constConstructor) |
| 2378 | { |
| 2379 | return constConstructor; |
| 2380 | } |
| 2381 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 2382 | return constructor; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2383 | } |
| 2384 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2385 | // |
| 2386 | // Interface/uniform blocks |
| 2387 | // |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2388 | TIntermAggregate *TParseContext::addInterfaceBlock( |
| 2389 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2390 | const TSourceLoc &nameLine, |
| 2391 | const TString &blockName, |
| 2392 | TFieldList *fieldList, |
| 2393 | const TString *instanceName, |
| 2394 | const TSourceLoc &instanceLine, |
| 2395 | TIntermTyped *arrayIndex, |
| 2396 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2397 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2398 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2399 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 2400 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2401 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2402 | if (typeQualifier.qualifier != EvqUniform) |
| 2403 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2404 | error(typeQualifier.line, "invalid qualifier:", getQualifierString(typeQualifier.qualifier), |
| 2405 | "interface blocks must be uniform"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2406 | } |
| 2407 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2408 | if (typeQualifier.invariant) |
| 2409 | { |
| 2410 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 2411 | } |
| 2412 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2413 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2414 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2415 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2416 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 2417 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2418 | blockLayoutQualifier.matrixPacking = mDefaultMatrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2419 | } |
| 2420 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2421 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 2422 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2423 | blockLayoutQualifier.blockStorage = mDefaultBlockStorage; |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2424 | } |
| 2425 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2426 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2427 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2428 | TSymbol *blockNameSymbol = new TInterfaceBlockName(&blockName); |
| 2429 | if (!symbolTable.declare(blockNameSymbol)) |
| 2430 | { |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2431 | error(nameLine, "redefinition", blockName.c_str(), "interface block name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2432 | } |
| 2433 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2434 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2435 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2436 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2437 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2438 | TType *fieldType = field->type(); |
| 2439 | if (IsSampler(fieldType->getBasicType())) |
| 2440 | { |
| 2441 | error(field->line(), "unsupported type", fieldType->getBasicString(), |
| 2442 | "sampler types are not allowed in interface blocks"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2443 | } |
| 2444 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2445 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2446 | switch (qualifier) |
| 2447 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2448 | case EvqGlobal: |
| 2449 | case EvqUniform: |
| 2450 | break; |
| 2451 | default: |
| 2452 | error(field->line(), "invalid qualifier on interface block member", |
| 2453 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2454 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2455 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2456 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2457 | if (fieldType->isInvariant()) |
| 2458 | { |
| 2459 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 2460 | } |
| 2461 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2462 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2463 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2464 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2465 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2466 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2467 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2468 | error(field->line(), "invalid layout qualifier:", |
| 2469 | getBlockStorageString(fieldLayoutQualifier.blockStorage), "cannot be used here"); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2470 | } |
| 2471 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2472 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2473 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2474 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2475 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2476 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2477 | { |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 2478 | warning(field->line(), "extraneous layout qualifier:", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2479 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking), |
| 2480 | "only has an effect on matrix types"); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2481 | } |
| 2482 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2483 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2484 | } |
| 2485 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2486 | // add array index |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2487 | unsigned int arraySize = 0; |
| 2488 | if (arrayIndex != nullptr) |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2489 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2490 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2491 | } |
| 2492 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2493 | TInterfaceBlock *interfaceBlock = |
| 2494 | new TInterfaceBlock(&blockName, fieldList, instanceName, arraySize, blockLayoutQualifier); |
| 2495 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier, |
| 2496 | arraySize); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2497 | |
| 2498 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2499 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2500 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2501 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2502 | { |
| 2503 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2504 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 2505 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2506 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2507 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2508 | |
| 2509 | // set parent pointer of the field variable |
| 2510 | fieldType->setInterfaceBlock(interfaceBlock); |
| 2511 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2512 | TVariable *fieldVariable = new TVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2513 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 2514 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2515 | if (!symbolTable.declare(fieldVariable)) |
| 2516 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2517 | error(field->line(), "redefinition", field->name().c_str(), |
| 2518 | "interface block member name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2519 | } |
| 2520 | } |
| 2521 | } |
| 2522 | else |
| 2523 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2524 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 2525 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2526 | // add a symbol for this interface block |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2527 | TVariable *instanceTypeDef = new TVariable(instanceName, interfaceBlockType, false); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2528 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2529 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2530 | if (!symbolTable.declare(instanceTypeDef)) |
| 2531 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2532 | error(instanceLine, "redefinition", instanceName->c_str(), |
| 2533 | "interface block instance name"); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2534 | } |
| 2535 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2536 | symbolId = instanceTypeDef->getUniqueId(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2537 | symbolName = instanceTypeDef->getName(); |
| 2538 | } |
| 2539 | |
Olli Etuaho | 32db19b | 2016-10-04 14:43:16 +0100 | [diff] [blame] | 2540 | TIntermAggregate *aggregate = TIntermediate::MakeAggregate( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2541 | intermediate.addSymbol(symbolId, symbolName, interfaceBlockType, typeQualifier.line), |
| 2542 | nameLine); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2543 | aggregate->setOp(EOpDeclaration); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2544 | |
| 2545 | exitStructDeclaration(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2546 | return aggregate; |
| 2547 | } |
| 2548 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2549 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2550 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2551 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2552 | |
| 2553 | // Embedded structure definitions are not supported per GLSL ES spec. |
| 2554 | // They aren't allowed in GLSL either, but we need to detect this here |
| 2555 | // so we don't rely on the GLSL compiler to catch it. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2556 | if (mStructNestingLevel > 1) |
| 2557 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 2558 | error(line, "", "Embedded struct definitions are not allowed"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2559 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2560 | } |
| 2561 | |
| 2562 | void TParseContext::exitStructDeclaration() |
| 2563 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2564 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2565 | } |
| 2566 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2567 | namespace |
| 2568 | { |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2569 | const int kWebGLMaxStructNesting = 4; |
| 2570 | |
| 2571 | } // namespace |
| 2572 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2573 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2574 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2575 | if (!IsWebGLBasedSpec(mShaderSpec)) |
| 2576 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2577 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2578 | } |
| 2579 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2580 | if (field.type()->getBasicType() != EbtStruct) |
| 2581 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2582 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2583 | } |
| 2584 | |
| 2585 | // We're already inside a structure definition at this point, so add |
| 2586 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2587 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 2588 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2589 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2590 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 2591 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 2592 | std::string reason = reasonStream.str(); |
| 2593 | error(line, reason.c_str(), field.name().c_str(), ""); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2594 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2595 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 2596 | } |
| 2597 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 2598 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2599 | // Parse an array index expression |
| 2600 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2601 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 2602 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2603 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2604 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2605 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 2606 | { |
| 2607 | if (baseExpression->getAsSymbolNode()) |
| 2608 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2609 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 2610 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2611 | } |
| 2612 | else |
| 2613 | { |
| 2614 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 2615 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2616 | |
| 2617 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 2618 | unionArray->setFConst(0.0f); |
| 2619 | return intermediate.addConstantUnion(unionArray, TType(EbtFloat, EbpHigh, EvqConst), |
| 2620 | location); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2621 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 2622 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 2623 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 2624 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2625 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 2626 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 2627 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 2628 | // index is a constant expression. |
| 2629 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 2630 | { |
| 2631 | if (baseExpression->isInterfaceBlock()) |
| 2632 | { |
| 2633 | error( |
| 2634 | location, "", "[", |
| 2635 | "array indexes for interface blocks arrays must be constant integral expressions"); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2636 | } |
| 2637 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 2638 | { |
| 2639 | error(location, "", "[", |
| 2640 | "array indexes for fragment outputs must be constant integral expressions"); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2641 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 2642 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 2643 | { |
| 2644 | error(location, "", "[", "array index for gl_FragData must be constant zero"); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 2645 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 2646 | } |
| 2647 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2648 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2649 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2650 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 2651 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 2652 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 2653 | // handle this case is to report a warning instead of an error and force the index to be in |
| 2654 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 2655 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 2656 | int index = indexConstantUnion->getIConst(0); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2657 | |
| 2658 | int safeIndex = -1; |
| 2659 | |
| 2660 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2661 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2662 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2663 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2664 | if (mShaderSpec == SH_WEBGL2_SPEC) |
| 2665 | { |
| 2666 | // Error has been already generated if index is not const. |
| 2667 | if (indexExpression->getQualifier() == EvqConst) |
| 2668 | { |
| 2669 | error(location, "", "[", |
| 2670 | "array index for gl_FragData must be constant zero"); |
| 2671 | } |
| 2672 | safeIndex = 0; |
| 2673 | } |
| 2674 | else if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
| 2675 | { |
| 2676 | outOfRangeError(outOfRangeIndexIsError, location, "", "[", |
| 2677 | "array index for gl_FragData must be zero when " |
| 2678 | "GL_EXT_draw_buffers is disabled"); |
| 2679 | safeIndex = 0; |
| 2680 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2681 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2682 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 2683 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2684 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2685 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 2686 | baseExpression->getArraySize(), |
| 2687 | "array index out of range", "[]"); |
| 2688 | } |
| 2689 | } |
| 2690 | else if (baseExpression->isMatrix()) |
| 2691 | { |
| 2692 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2693 | baseExpression->getType().getCols(), |
| 2694 | "matrix field selection out of range", "[]"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2695 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2696 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2697 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2698 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 2699 | baseExpression->getType().getNominalSize(), |
| 2700 | "vector field selection out of range", "[]"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2701 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2702 | |
| 2703 | ASSERT(safeIndex >= 0); |
| 2704 | // Data of constant unions can't be changed, because it may be shared with other |
| 2705 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 2706 | // sanitized object. |
| 2707 | if (safeIndex != index) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2708 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2709 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 2710 | safeConstantUnion->setIConst(safeIndex); |
| 2711 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2712 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2713 | |
| 2714 | return intermediate.addIndex(EOpIndexDirect, baseExpression, indexExpression, location, |
| 2715 | &mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2716 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2717 | else |
| 2718 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2719 | return intermediate.addIndex(EOpIndexIndirect, baseExpression, indexExpression, location, |
| 2720 | &mDiagnostics); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 2721 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2722 | } |
| 2723 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 2724 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 2725 | const TSourceLoc &location, |
| 2726 | int index, |
| 2727 | int arraySize, |
| 2728 | const char *reason, |
| 2729 | const char *token) |
| 2730 | { |
| 2731 | if (index >= arraySize || index < 0) |
| 2732 | { |
| 2733 | std::stringstream extraInfoStream; |
| 2734 | extraInfoStream << "'" << index << "'"; |
| 2735 | std::string extraInfo = extraInfoStream.str(); |
| 2736 | outOfRangeError(outOfRangeIndexIsError, location, reason, token, extraInfo.c_str()); |
| 2737 | if (index < 0) |
| 2738 | { |
| 2739 | return 0; |
| 2740 | } |
| 2741 | else |
| 2742 | { |
| 2743 | return arraySize - 1; |
| 2744 | } |
| 2745 | } |
| 2746 | return index; |
| 2747 | } |
| 2748 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2749 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 2750 | const TSourceLoc &dotLocation, |
| 2751 | const TString &fieldString, |
| 2752 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2753 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2754 | if (baseExpression->isArray()) |
| 2755 | { |
| 2756 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2757 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2758 | } |
| 2759 | |
| 2760 | if (baseExpression->isVector()) |
| 2761 | { |
| 2762 | TVectorFields fields; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2763 | if (!parseVectorFields(fieldString, baseExpression->getNominalSize(), fields, |
| 2764 | fieldLocation)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2765 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2766 | fields.num = 1; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2767 | fields.offsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2768 | } |
| 2769 | |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 2770 | return TIntermediate::AddSwizzle(baseExpression, fields, dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2771 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2772 | else if (baseExpression->getBasicType() == EbtStruct) |
| 2773 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2774 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2775 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2776 | { |
| 2777 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2778 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2779 | } |
| 2780 | else |
| 2781 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2782 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2783 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2784 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2785 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2786 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2787 | { |
| 2788 | fieldFound = true; |
| 2789 | break; |
| 2790 | } |
| 2791 | } |
| 2792 | if (fieldFound) |
| 2793 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2794 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 2795 | index->setLine(fieldLocation); |
| 2796 | return intermediate.addIndex(EOpIndexDirectStruct, baseExpression, index, |
| 2797 | dotLocation, &mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2798 | } |
| 2799 | else |
| 2800 | { |
| 2801 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2802 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2803 | } |
| 2804 | } |
| 2805 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2806 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2807 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2808 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2809 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2810 | { |
| 2811 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2812 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2813 | } |
| 2814 | else |
| 2815 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2816 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2817 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2818 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2819 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 2820 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2821 | { |
| 2822 | fieldFound = true; |
| 2823 | break; |
| 2824 | } |
| 2825 | } |
| 2826 | if (fieldFound) |
| 2827 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2828 | TIntermTyped *index = TIntermTyped::CreateIndexNode(i); |
| 2829 | index->setLine(fieldLocation); |
| 2830 | return intermediate.addIndex(EOpIndexDirectInterfaceBlock, baseExpression, index, |
| 2831 | dotLocation, &mDiagnostics); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2832 | } |
| 2833 | else |
| 2834 | { |
| 2835 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2836 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2837 | } |
| 2838 | } |
| 2839 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2840 | else |
| 2841 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2842 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2843 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 2844 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2845 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2846 | } |
| 2847 | else |
| 2848 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2849 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 2850 | " field selection requires structure, vector, or interface block on left hand " |
| 2851 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2852 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 2853 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 2854 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2855 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2856 | } |
| 2857 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2858 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 2859 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2860 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2861 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2862 | |
| 2863 | if (qualifierType == "shared") |
| 2864 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2865 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2866 | } |
| 2867 | else if (qualifierType == "packed") |
| 2868 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2869 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2870 | } |
| 2871 | else if (qualifierType == "std140") |
| 2872 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2873 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2874 | } |
| 2875 | else if (qualifierType == "row_major") |
| 2876 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2877 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2878 | } |
| 2879 | else if (qualifierType == "column_major") |
| 2880 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2881 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2882 | } |
| 2883 | else if (qualifierType == "location") |
| 2884 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2885 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str(), |
| 2886 | "location requires an argument"); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2887 | } |
| 2888 | else |
| 2889 | { |
| 2890 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2891 | } |
| 2892 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2893 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2894 | } |
| 2895 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2896 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 2897 | const TSourceLoc &qualifierTypeLine, |
| 2898 | int intValue, |
| 2899 | const TSourceLoc &intValueLine, |
| 2900 | const std::string &intValueString, |
| 2901 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2902 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2903 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2904 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2905 | if (intValue < 1) |
| 2906 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2907 | std::string errorMessage = std::string(getWorkGroupSizeString(index)) + " must be positive"; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2908 | error(intValueLine, "out of range:", intValueString.c_str(), errorMessage.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2909 | } |
| 2910 | (*localSize)[index] = intValue; |
| 2911 | } |
| 2912 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2913 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 2914 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2915 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2916 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2917 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2918 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2919 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2920 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2921 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2922 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2923 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 2924 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2925 | if (intValue < 0) |
| 2926 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2927 | error(intValueLine, "out of range:", intValueString.c_str(), |
| 2928 | "location must be non-negative"); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2929 | } |
| 2930 | else |
| 2931 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2932 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 2933 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2934 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2935 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2936 | else if (qualifierType == "local_size_x") |
| 2937 | { |
| 2938 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 2939 | &qualifier.localSize); |
| 2940 | } |
| 2941 | else if (qualifierType == "local_size_y") |
| 2942 | { |
| 2943 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 2944 | &qualifier.localSize); |
| 2945 | } |
| 2946 | else if (qualifierType == "local_size_z") |
| 2947 | { |
| 2948 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 2949 | &qualifier.localSize); |
| 2950 | } |
| 2951 | else |
| 2952 | { |
| 2953 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2954 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2955 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 2956 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2957 | } |
| 2958 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 2959 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 2960 | { |
| 2961 | return new TTypeQualifierBuilder( |
| 2962 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 2963 | mShaderVersion); |
| 2964 | } |
| 2965 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2966 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2967 | TLayoutQualifier rightQualifier, |
| 2968 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2969 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2970 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
| 2971 | &mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 2972 | } |
| 2973 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2974 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 2975 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2976 | TPublicType *typeSpecifier, |
| 2977 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 2978 | { |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 2979 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(&mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 2980 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2981 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 2982 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
| 2983 | typeSpecifier->invariant = typeQualifier.invariant; |
| 2984 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2985 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2986 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 2987 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2988 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 2989 | } |
| 2990 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2991 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
| 2992 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2993 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2994 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 2995 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2996 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2997 | checkIsNonVoid(typeSpecifier.getLine(), (*fieldList)[0]->name(), typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 2998 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2999 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3000 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3001 | for (unsigned int i = 0; i < fieldList->size(); ++i) |
| 3002 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3003 | // |
| 3004 | // Careful not to replace already known aspects of type, like array-ness |
| 3005 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3006 | TType *type = (*fieldList)[i]->type(); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3007 | type->setBasicType(typeSpecifier.getBasicType()); |
| 3008 | type->setPrimarySize(typeSpecifier.getPrimarySize()); |
| 3009 | type->setSecondarySize(typeSpecifier.getSecondarySize()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3010 | type->setPrecision(typeSpecifier.precision); |
| 3011 | type->setQualifier(typeSpecifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3012 | type->setLayoutQualifier(typeSpecifier.layoutQualifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3013 | type->setInvariant(typeSpecifier.invariant); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3014 | |
| 3015 | // don't allow arrays of arrays |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3016 | if (type->isArray()) |
| 3017 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3018 | checkIsValidTypeForArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3019 | } |
| 3020 | if (typeSpecifier.array) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3021 | type->setArraySize(static_cast<unsigned int>(typeSpecifier.arraySize)); |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3022 | if (typeSpecifier.getUserDef()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3023 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3024 | type->setStruct(typeSpecifier.getUserDef()->getStruct()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3025 | } |
| 3026 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3027 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*fieldList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3028 | } |
| 3029 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3030 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3031 | } |
| 3032 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3033 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 3034 | const TSourceLoc &nameLine, |
| 3035 | const TString *structName, |
| 3036 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3037 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3038 | TStructure *structure = new TStructure(structName, fieldList); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3039 | TType *structureType = new TType(structure); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3040 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3041 | // Store a bool in the struct if we're at global scope, to allow us to |
| 3042 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 3043 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 3044 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3045 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3046 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3047 | checkIsNotReserved(nameLine, *structName); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3048 | TVariable *userTypeDef = new TVariable(structName, *structureType, true); |
| 3049 | if (!symbolTable.declare(userTypeDef)) |
| 3050 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3051 | error(nameLine, "redefinition", structName->c_str(), "struct"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3052 | } |
| 3053 | } |
| 3054 | |
| 3055 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3056 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3057 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3058 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3059 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3060 | switch (qualifier) |
| 3061 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3062 | case EvqGlobal: |
| 3063 | case EvqTemporary: |
| 3064 | break; |
| 3065 | default: |
| 3066 | error(field.line(), "invalid qualifier on struct member", |
| 3067 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3068 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3069 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3070 | if (field.type()->isInvariant()) |
| 3071 | { |
| 3072 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 3073 | } |
| 3074 | |
| 3075 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3076 | } |
| 3077 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3078 | TTypeSpecifierNonArray typeSpecifierNonArray; |
| 3079 | typeSpecifierNonArray.initialize(EbtStruct, structLine); |
| 3080 | typeSpecifierNonArray.userDef = structureType; |
| 3081 | typeSpecifierNonArray.isStructSpecifier = true; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3082 | exitStructDeclaration(); |
| 3083 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3084 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3085 | } |
| 3086 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3087 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3088 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3089 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3090 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3091 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3092 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3093 | init->isVector()) |
| 3094 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3095 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 3096 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3097 | return nullptr; |
| 3098 | } |
| 3099 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3100 | if (statementList) |
| 3101 | { |
| 3102 | if (!ValidateSwitch::validate(switchType, this, statementList, loc)) |
| 3103 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 3104 | return nullptr; |
| 3105 | } |
| 3106 | } |
| 3107 | |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3108 | TIntermSwitch *node = intermediate.addSwitch(init, statementList, loc); |
| 3109 | if (node == nullptr) |
| 3110 | { |
| 3111 | error(loc, "erroneous switch statement", "switch"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3112 | return nullptr; |
| 3113 | } |
| 3114 | return node; |
| 3115 | } |
| 3116 | |
| 3117 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 3118 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3119 | if (mSwitchNestingLevel == 0) |
| 3120 | { |
| 3121 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3122 | return nullptr; |
| 3123 | } |
| 3124 | if (condition == nullptr) |
| 3125 | { |
| 3126 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3127 | return nullptr; |
| 3128 | } |
| 3129 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3130 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3131 | { |
| 3132 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3133 | } |
| 3134 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3135 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 3136 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 3137 | // fold in case labels. |
| 3138 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3139 | { |
| 3140 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3141 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3142 | TIntermCase *node = intermediate.addCase(condition, loc); |
| 3143 | if (node == nullptr) |
| 3144 | { |
| 3145 | error(loc, "erroneous case statement", "case"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3146 | return nullptr; |
| 3147 | } |
| 3148 | return node; |
| 3149 | } |
| 3150 | |
| 3151 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 3152 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3153 | if (mSwitchNestingLevel == 0) |
| 3154 | { |
| 3155 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 3156 | return nullptr; |
| 3157 | } |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3158 | TIntermCase *node = intermediate.addCase(nullptr, loc); |
| 3159 | if (node == nullptr) |
| 3160 | { |
| 3161 | error(loc, "erroneous default statement", "default"); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 3162 | return nullptr; |
| 3163 | } |
| 3164 | return node; |
| 3165 | } |
| 3166 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3167 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 3168 | TIntermTyped *child, |
| 3169 | const TSourceLoc &loc, |
| 3170 | const TType *funcReturnType) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3171 | { |
| 3172 | if (child == nullptr) |
| 3173 | { |
| 3174 | return nullptr; |
| 3175 | } |
| 3176 | |
| 3177 | switch (op) |
| 3178 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3179 | case EOpLogicalNot: |
| 3180 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 3181 | child->isVector()) |
| 3182 | { |
| 3183 | return nullptr; |
| 3184 | } |
| 3185 | break; |
| 3186 | case EOpBitwiseNot: |
| 3187 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 3188 | child->isMatrix() || child->isArray()) |
| 3189 | { |
| 3190 | return nullptr; |
| 3191 | } |
| 3192 | break; |
| 3193 | case EOpPostIncrement: |
| 3194 | case EOpPreIncrement: |
| 3195 | case EOpPostDecrement: |
| 3196 | case EOpPreDecrement: |
| 3197 | case EOpNegative: |
| 3198 | case EOpPositive: |
| 3199 | if (child->getBasicType() == EbtStruct || child->getBasicType() == EbtBool || |
Olli Etuaho | 558b038 | 2016-08-26 17:54:34 +0300 | [diff] [blame] | 3200 | child->isArray() || IsSampler(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3201 | { |
| 3202 | return nullptr; |
| 3203 | } |
| 3204 | // Operators for built-ins are already type checked against their prototype. |
| 3205 | default: |
| 3206 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3207 | } |
| 3208 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3209 | TIntermUnary *node = new TIntermUnary(op, child); |
| 3210 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3211 | |
| 3212 | TIntermTyped *foldedNode = node->fold(&mDiagnostics); |
| 3213 | if (foldedNode) |
| 3214 | return foldedNode; |
| 3215 | |
| 3216 | return node; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3217 | } |
| 3218 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3219 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 3220 | { |
Olli Etuaho | f6c694b | 2015-03-26 14:50:53 +0200 | [diff] [blame] | 3221 | TIntermTyped *node = createUnaryMath(op, child, loc, nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 3222 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3223 | { |
| 3224 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3225 | return child; |
| 3226 | } |
| 3227 | return node; |
| 3228 | } |
| 3229 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3230 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 3231 | TIntermTyped *child, |
| 3232 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3233 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3234 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3235 | return addUnaryMath(op, child, loc); |
| 3236 | } |
| 3237 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3238 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 3239 | TIntermTyped *left, |
| 3240 | TIntermTyped *right, |
| 3241 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3242 | { |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3243 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 3244 | { |
| 3245 | switch (op) |
| 3246 | { |
| 3247 | case EOpIndexDirectStruct: |
| 3248 | ASSERT(left->getType().getStruct()); |
| 3249 | break; |
| 3250 | case EOpEqual: |
| 3251 | case EOpNotEqual: |
| 3252 | case EOpAssign: |
| 3253 | case EOpInitialize: |
| 3254 | if (left->getType() != right->getType()) |
| 3255 | { |
| 3256 | return false; |
| 3257 | } |
| 3258 | break; |
| 3259 | default: |
| 3260 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 3261 | return false; |
| 3262 | } |
| 3263 | } |
| 3264 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3265 | if (left->isArray() || right->isArray()) |
| 3266 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3267 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3268 | { |
| 3269 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3270 | return false; |
| 3271 | } |
| 3272 | |
| 3273 | if (left->isArray() != right->isArray()) |
| 3274 | { |
| 3275 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 3276 | return false; |
| 3277 | } |
| 3278 | |
| 3279 | switch (op) |
| 3280 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3281 | case EOpEqual: |
| 3282 | case EOpNotEqual: |
| 3283 | case EOpAssign: |
| 3284 | case EOpInitialize: |
| 3285 | break; |
| 3286 | default: |
| 3287 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 3288 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3289 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 3290 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 3291 | if (left->getArraySize() != right->getArraySize()) |
| 3292 | { |
| 3293 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 3294 | return false; |
| 3295 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3296 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3297 | |
| 3298 | // Check ops which require integer / ivec parameters |
| 3299 | bool isBitShift = false; |
| 3300 | switch (op) |
| 3301 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3302 | case EOpBitShiftLeft: |
| 3303 | case EOpBitShiftRight: |
| 3304 | case EOpBitShiftLeftAssign: |
| 3305 | case EOpBitShiftRightAssign: |
| 3306 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 3307 | // check that the basic type is an integer type. |
| 3308 | isBitShift = true; |
| 3309 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 3310 | { |
| 3311 | return false; |
| 3312 | } |
| 3313 | break; |
| 3314 | case EOpBitwiseAnd: |
| 3315 | case EOpBitwiseXor: |
| 3316 | case EOpBitwiseOr: |
| 3317 | case EOpBitwiseAndAssign: |
| 3318 | case EOpBitwiseXorAssign: |
| 3319 | case EOpBitwiseOrAssign: |
| 3320 | // It is enough to check the type of only one operand, since later it |
| 3321 | // is checked that the operand types match. |
| 3322 | if (!IsInteger(left->getBasicType())) |
| 3323 | { |
| 3324 | return false; |
| 3325 | } |
| 3326 | break; |
| 3327 | default: |
| 3328 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3329 | } |
| 3330 | |
| 3331 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 3332 | // So the basic type should usually match. |
| 3333 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 3334 | { |
| 3335 | return false; |
| 3336 | } |
| 3337 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3338 | // Check that: |
| 3339 | // 1. Type sizes match exactly on ops that require that. |
| 3340 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 3341 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3342 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3343 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3344 | case EOpAssign: |
| 3345 | case EOpInitialize: |
| 3346 | case EOpEqual: |
| 3347 | case EOpNotEqual: |
| 3348 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 3349 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 3350 | { |
| 3351 | error(loc, "undefined operation for structs containing arrays", |
| 3352 | GetOperatorString(op)); |
| 3353 | return false; |
| 3354 | } |
| 3355 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 3356 | // we interpret the spec so that this extends to structs containing samplers, |
| 3357 | // similarly to ESSL 1.00 spec. |
| 3358 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 3359 | left->getType().isStructureContainingSamplers()) |
| 3360 | { |
| 3361 | error(loc, "undefined operation for structs containing samplers", |
| 3362 | GetOperatorString(op)); |
| 3363 | return false; |
| 3364 | } |
| 3365 | case EOpLessThan: |
| 3366 | case EOpGreaterThan: |
| 3367 | case EOpLessThanEqual: |
| 3368 | case EOpGreaterThanEqual: |
| 3369 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 3370 | (left->getSecondarySize() != right->getSecondarySize())) |
| 3371 | { |
| 3372 | return false; |
| 3373 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 3374 | break; |
| 3375 | case EOpAdd: |
| 3376 | case EOpSub: |
| 3377 | case EOpDiv: |
| 3378 | case EOpIMod: |
| 3379 | case EOpBitShiftLeft: |
| 3380 | case EOpBitShiftRight: |
| 3381 | case EOpBitwiseAnd: |
| 3382 | case EOpBitwiseXor: |
| 3383 | case EOpBitwiseOr: |
| 3384 | case EOpAddAssign: |
| 3385 | case EOpSubAssign: |
| 3386 | case EOpDivAssign: |
| 3387 | case EOpIModAssign: |
| 3388 | case EOpBitShiftLeftAssign: |
| 3389 | case EOpBitShiftRightAssign: |
| 3390 | case EOpBitwiseAndAssign: |
| 3391 | case EOpBitwiseXorAssign: |
| 3392 | case EOpBitwiseOrAssign: |
| 3393 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 3394 | { |
| 3395 | return false; |
| 3396 | } |
| 3397 | |
| 3398 | // Are the sizes compatible? |
| 3399 | if (left->getNominalSize() != right->getNominalSize() || |
| 3400 | left->getSecondarySize() != right->getSecondarySize()) |
| 3401 | { |
| 3402 | // If the nominal sizes of operands do not match: |
| 3403 | // One of them must be a scalar. |
| 3404 | if (!left->isScalar() && !right->isScalar()) |
| 3405 | return false; |
| 3406 | |
| 3407 | // In the case of compound assignment other than multiply-assign, |
| 3408 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 3409 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 3410 | // vector either. |
| 3411 | if (!right->isScalar() && |
| 3412 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 3413 | return false; |
| 3414 | } |
| 3415 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3416 | default: |
| 3417 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3418 | } |
| 3419 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3420 | return true; |
| 3421 | } |
| 3422 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3423 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 3424 | const TType &left, |
| 3425 | const TType &right) |
| 3426 | { |
| 3427 | switch (op) |
| 3428 | { |
| 3429 | case EOpMul: |
| 3430 | case EOpMulAssign: |
| 3431 | return left.getNominalSize() == right.getNominalSize() && |
| 3432 | left.getSecondarySize() == right.getSecondarySize(); |
| 3433 | case EOpVectorTimesScalar: |
| 3434 | return true; |
| 3435 | case EOpVectorTimesScalarAssign: |
| 3436 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 3437 | return left.isVector() && !right.isVector(); |
| 3438 | case EOpVectorTimesMatrix: |
| 3439 | return left.getNominalSize() == right.getRows(); |
| 3440 | case EOpVectorTimesMatrixAssign: |
| 3441 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 3442 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 3443 | left.getNominalSize() == right.getCols(); |
| 3444 | case EOpMatrixTimesVector: |
| 3445 | return left.getCols() == right.getNominalSize(); |
| 3446 | case EOpMatrixTimesScalar: |
| 3447 | return true; |
| 3448 | case EOpMatrixTimesScalarAssign: |
| 3449 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 3450 | return !right.isVector(); |
| 3451 | case EOpMatrixTimesMatrix: |
| 3452 | return left.getCols() == right.getRows(); |
| 3453 | case EOpMatrixTimesMatrixAssign: |
| 3454 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 3455 | // We need to check two things: |
| 3456 | // 1. The matrix multiplication step is valid. |
| 3457 | // 2. The result will have the same number of columns as the lvalue. |
| 3458 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 3459 | |
| 3460 | default: |
| 3461 | UNREACHABLE(); |
| 3462 | return false; |
| 3463 | } |
| 3464 | } |
| 3465 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3466 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 3467 | TIntermTyped *left, |
| 3468 | TIntermTyped *right, |
| 3469 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3470 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3471 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3472 | return nullptr; |
| 3473 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3474 | switch (op) |
| 3475 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3476 | case EOpEqual: |
| 3477 | case EOpNotEqual: |
| 3478 | break; |
| 3479 | case EOpLessThan: |
| 3480 | case EOpGreaterThan: |
| 3481 | case EOpLessThanEqual: |
| 3482 | case EOpGreaterThanEqual: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3483 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3484 | !right->getType().getStruct()); |
| 3485 | if (left->isMatrix() || left->isVector()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3486 | { |
| 3487 | return nullptr; |
| 3488 | } |
| 3489 | break; |
| 3490 | case EOpLogicalOr: |
| 3491 | case EOpLogicalXor: |
| 3492 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3493 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3494 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3495 | if (left->getBasicType() != EbtBool || left->isMatrix() || left->isVector()) |
| 3496 | { |
| 3497 | return nullptr; |
| 3498 | } |
| 3499 | break; |
| 3500 | case EOpAdd: |
| 3501 | case EOpSub: |
| 3502 | case EOpDiv: |
| 3503 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3504 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3505 | !right->getType().getStruct()); |
| 3506 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3507 | { |
| 3508 | return nullptr; |
| 3509 | } |
| 3510 | break; |
| 3511 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3512 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 3513 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3514 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 3515 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3516 | { |
| 3517 | return nullptr; |
| 3518 | } |
| 3519 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3520 | default: |
| 3521 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3522 | } |
| 3523 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3524 | if (op == EOpMul) |
| 3525 | { |
| 3526 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 3527 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 3528 | { |
| 3529 | return nullptr; |
| 3530 | } |
| 3531 | } |
| 3532 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3533 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 3534 | node->setLine(loc); |
| 3535 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3536 | // See if we can fold constants. |
| 3537 | TIntermTyped *foldedNode = node->fold(&mDiagnostics); |
| 3538 | if (foldedNode) |
| 3539 | return foldedNode; |
| 3540 | |
| 3541 | return node; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3542 | } |
| 3543 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3544 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 3545 | TIntermTyped *left, |
| 3546 | TIntermTyped *right, |
| 3547 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3548 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3549 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3550 | if (node == 0) |
| 3551 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3552 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 3553 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3554 | return left; |
| 3555 | } |
| 3556 | return node; |
| 3557 | } |
| 3558 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3559 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 3560 | TIntermTyped *left, |
| 3561 | TIntermTyped *right, |
| 3562 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3563 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 3564 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3565 | if (node == 0) |
| 3566 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3567 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 3568 | right->getCompleteString()); |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 3569 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3570 | unionArray->setBConst(false); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3571 | return intermediate.addConstantUnion(unionArray, TType(EbtBool, EbpUndefined, EvqConst), |
| 3572 | loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 3573 | } |
| 3574 | return node; |
| 3575 | } |
| 3576 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3577 | TIntermTyped *TParseContext::createAssign(TOperator op, |
| 3578 | TIntermTyped *left, |
| 3579 | TIntermTyped *right, |
| 3580 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3581 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 3582 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3583 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 3584 | if (op == EOpMulAssign) |
| 3585 | { |
| 3586 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 3587 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 3588 | { |
| 3589 | return nullptr; |
| 3590 | } |
| 3591 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3592 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 3593 | node->setLine(loc); |
| 3594 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 3595 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3596 | } |
| 3597 | return nullptr; |
| 3598 | } |
| 3599 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3600 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 3601 | TIntermTyped *left, |
| 3602 | TIntermTyped *right, |
| 3603 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3604 | { |
| 3605 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 3606 | if (node == nullptr) |
| 3607 | { |
| 3608 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 3609 | return left; |
| 3610 | } |
| 3611 | return node; |
| 3612 | } |
| 3613 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 3614 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 3615 | TIntermTyped *right, |
| 3616 | const TSourceLoc &loc) |
| 3617 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3618 | // WebGL2 section 5.26, the following results in an error: |
| 3619 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
| 3620 | if (mShaderSpec == SH_WEBGL2_SPEC && (left->isArray() || left->getBasicType() == EbtVoid || |
| 3621 | left->getType().isStructureContainingArrays() || |
| 3622 | right->isArray() || right->getBasicType() == EbtVoid || |
| 3623 | right->getType().isStructureContainingArrays())) |
| 3624 | { |
| 3625 | error(loc, |
| 3626 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 3627 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3628 | } |
| 3629 | |
Olli Etuaho | 1520004 | 2015-11-04 16:56:31 +0200 | [diff] [blame] | 3630 | return intermediate.addComma(left, right, loc, mShaderVersion); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 3631 | } |
| 3632 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3633 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 3634 | { |
| 3635 | switch (op) |
| 3636 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3637 | case EOpContinue: |
| 3638 | if (mLoopNestingLevel <= 0) |
| 3639 | { |
| 3640 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3641 | } |
| 3642 | break; |
| 3643 | case EOpBreak: |
| 3644 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 3645 | { |
| 3646 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3647 | } |
| 3648 | break; |
| 3649 | case EOpReturn: |
| 3650 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 3651 | { |
| 3652 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3653 | } |
| 3654 | break; |
| 3655 | default: |
| 3656 | // No checks for discard |
| 3657 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3658 | } |
| 3659 | return intermediate.addBranch(op, loc); |
| 3660 | } |
| 3661 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3662 | TIntermBranch *TParseContext::addBranch(TOperator op, |
| 3663 | TIntermTyped *returnValue, |
| 3664 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3665 | { |
| 3666 | ASSERT(op == EOpReturn); |
| 3667 | mFunctionReturnsValue = true; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3668 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3669 | { |
| 3670 | error(loc, "void function cannot return a value", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3671 | } |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3672 | else if (*mCurrentFunctionType != returnValue->getType()) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3673 | { |
| 3674 | error(loc, "function return is not matching type:", "return"); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3675 | } |
| 3676 | return intermediate.addBranch(op, returnValue, loc); |
| 3677 | } |
| 3678 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 3679 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 3680 | { |
| 3681 | ASSERT(!functionCall->isUserDefined()); |
| 3682 | const TString &name = functionCall->getName(); |
| 3683 | TIntermNode *offset = nullptr; |
| 3684 | TIntermSequence *arguments = functionCall->getSequence(); |
| 3685 | if (name.compare(0, 16, "texelFetchOffset") == 0 || |
| 3686 | name.compare(0, 16, "textureLodOffset") == 0 || |
| 3687 | name.compare(0, 20, "textureProjLodOffset") == 0 || |
| 3688 | name.compare(0, 17, "textureGradOffset") == 0 || |
| 3689 | name.compare(0, 21, "textureProjGradOffset") == 0) |
| 3690 | { |
| 3691 | offset = arguments->back(); |
| 3692 | } |
| 3693 | else if (name.compare(0, 13, "textureOffset") == 0 || |
| 3694 | name.compare(0, 17, "textureProjOffset") == 0) |
| 3695 | { |
| 3696 | // A bias parameter might follow the offset parameter. |
| 3697 | ASSERT(arguments->size() >= 3); |
| 3698 | offset = (*arguments)[2]; |
| 3699 | } |
| 3700 | if (offset != nullptr) |
| 3701 | { |
| 3702 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 3703 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 3704 | { |
| 3705 | TString unmangledName = TFunction::unmangleName(name); |
| 3706 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
| 3707 | unmangledName.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 3708 | } |
| 3709 | else |
| 3710 | { |
| 3711 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 3712 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 3713 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 3714 | for (size_t i = 0u; i < size; ++i) |
| 3715 | { |
| 3716 | int offsetValue = values[i].getIConst(); |
| 3717 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 3718 | { |
| 3719 | std::stringstream tokenStream; |
| 3720 | tokenStream << offsetValue; |
| 3721 | std::string token = tokenStream.str(); |
| 3722 | error(offset->getLine(), "Texture offset value out of valid range", |
| 3723 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 3724 | } |
| 3725 | } |
| 3726 | } |
| 3727 | } |
| 3728 | } |
| 3729 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3730 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
| 3731 | TIntermNode *paramNode, |
| 3732 | TIntermNode *thisNode, |
| 3733 | const TSourceLoc &loc, |
| 3734 | bool *fatalError) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3735 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3736 | *fatalError = false; |
| 3737 | TOperator op = fnCall->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3738 | TIntermTyped *callNode = nullptr; |
| 3739 | |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3740 | if (thisNode != nullptr) |
| 3741 | { |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 3742 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3743 | int arraySize = 0; |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3744 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 3745 | if (fnCall->getName() != "length") |
| 3746 | { |
| 3747 | error(loc, "invalid method", fnCall->getName().c_str()); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3748 | } |
| 3749 | else if (paramNode != nullptr) |
| 3750 | { |
| 3751 | error(loc, "method takes no parameters", "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3752 | } |
| 3753 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 3754 | { |
| 3755 | error(loc, "length can only be called on arrays", "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3756 | } |
| 3757 | else |
| 3758 | { |
Olli Etuaho | 96e6738 | 2015-04-23 14:27:02 +0300 | [diff] [blame] | 3759 | arraySize = typedThis->getArraySize(); |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 3760 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3761 | { |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 3762 | // This code path can be hit with expressions like these: |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3763 | // (a = b).length() |
Olli Etuaho | 39282e1 | 2015-04-23 15:41:48 +0300 | [diff] [blame] | 3764 | // (func()).length() |
| 3765 | // (int[3](0, 1, 2)).length() |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3766 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 3767 | // expression. |
| 3768 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 3769 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 3770 | // length method applied". |
| 3771 | error(loc, "length can only be called on array names, not on array expressions", |
| 3772 | "length"); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3773 | } |
| 3774 | } |
Olli Etuaho | 96e6738 | 2015-04-23 14:27:02 +0300 | [diff] [blame] | 3775 | unionArray->setIConst(arraySize); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3776 | callNode = |
| 3777 | intermediate.addConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst), loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 3778 | } |
| 3779 | else if (op != EOpNull) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3780 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3781 | // Then this should be a constructor. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3782 | callNode = addConstructor(paramNode, op, fnCall, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3783 | } |
| 3784 | else |
| 3785 | { |
| 3786 | // |
| 3787 | // Not a constructor. Find it in the symbol table. |
| 3788 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3789 | const TFunction *fnCandidate; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3790 | bool builtIn; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3791 | fnCandidate = findFunction(loc, fnCall, mShaderVersion, &builtIn); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3792 | if (fnCandidate) |
| 3793 | { |
| 3794 | // |
| 3795 | // A declared function. |
| 3796 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 3797 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3798 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3799 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3800 | } |
| 3801 | op = fnCandidate->getBuiltInOp(); |
| 3802 | if (builtIn && op != EOpNull) |
| 3803 | { |
| 3804 | // |
| 3805 | // A function call mapped to a built-in operation. |
| 3806 | // |
| 3807 | if (fnCandidate->getParamCount() == 1) |
| 3808 | { |
| 3809 | // |
| 3810 | // Treat it like a built-in unary operator. |
| 3811 | // |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 3812 | TIntermAggregate *paramAgg = paramNode->getAsAggregate(); |
| 3813 | paramNode = paramAgg->getSequence()->front(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3814 | callNode = createUnaryMath(op, paramNode->getAsTyped(), loc, |
| 3815 | &fnCandidate->getReturnType()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3816 | if (callNode == nullptr) |
| 3817 | { |
| 3818 | std::stringstream extraInfoStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3819 | extraInfoStream |
| 3820 | << "built in unary operator function. Type: " |
| 3821 | << static_cast<TIntermTyped *>(paramNode)->getCompleteString(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3822 | std::string extraInfo = extraInfoStream.str(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3823 | error(paramNode->getLine(), " wrong operand type", "Internal Error", |
| 3824 | extraInfo.c_str()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3825 | *fatalError = true; |
| 3826 | return nullptr; |
| 3827 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3828 | } |
| 3829 | else |
| 3830 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3831 | TIntermAggregate *aggregate = |
| 3832 | intermediate.setAggregateOperator(paramNode, op, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3833 | aggregate->setType(fnCandidate->getReturnType()); |
| 3834 | aggregate->setPrecisionFromChildren(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 3835 | if (aggregate->areChildrenConstQualified()) |
| 3836 | { |
| 3837 | aggregate->getTypePointer()->setQualifier(EvqConst); |
| 3838 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3839 | |
| 3840 | // Some built-in functions have out parameters too. |
| 3841 | functionCallLValueErrorCheck(fnCandidate, aggregate); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 3842 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3843 | // See if we can constant fold a built-in. Note that this may be possible even |
| 3844 | // if it is not const-qualified. |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 3845 | TIntermTyped *foldedNode = |
| 3846 | intermediate.foldAggregateBuiltIn(aggregate, &mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 3847 | if (foldedNode) |
| 3848 | { |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 3849 | callNode = foldedNode; |
| 3850 | } |
Olli Etuaho | b43846e | 2015-06-02 18:18:57 +0300 | [diff] [blame] | 3851 | else |
| 3852 | { |
| 3853 | callNode = aggregate; |
| 3854 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3855 | } |
| 3856 | } |
| 3857 | else |
| 3858 | { |
| 3859 | // This is a real function call |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3860 | TIntermAggregate *aggregate = |
| 3861 | intermediate.setAggregateOperator(paramNode, EOpFunctionCall, loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3862 | aggregate->setType(fnCandidate->getReturnType()); |
| 3863 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3864 | // this is how we know whether the given function is a builtIn function or a user |
| 3865 | // defined function |
| 3866 | // if builtIn == false, it's a userDefined -> could be an overloaded |
| 3867 | // builtIn function also |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3868 | // if builtIn == true, it's definitely a builtIn function with EOpNull |
| 3869 | if (!builtIn) |
| 3870 | aggregate->setUserDefined(); |
| 3871 | aggregate->setName(fnCandidate->getMangledName()); |
Corentin Wallez | 71d147f | 2015-02-11 11:15:24 -0800 | [diff] [blame] | 3872 | aggregate->setFunctionId(fnCandidate->getUniqueId()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3873 | |
| 3874 | // This needs to happen after the name is set |
| 3875 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 3876 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3877 | aggregate->setBuiltInFunctionPrecision(); |
| 3878 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 3879 | checkTextureOffsetConst(aggregate); |
| 3880 | } |
| 3881 | |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3882 | callNode = aggregate; |
| 3883 | |
| 3884 | functionCallLValueErrorCheck(fnCandidate, aggregate); |
| 3885 | } |
| 3886 | } |
| 3887 | else |
| 3888 | { |
| 3889 | // error message was put out by findFunction() |
| 3890 | // Put on a dummy node for error recovery |
Jamie Madill | 6ba6ead | 2015-05-04 14:21:21 -0400 | [diff] [blame] | 3891 | TConstantUnion *unionArray = new TConstantUnion[1]; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3892 | unionArray->setFConst(0.0f); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3893 | callNode = intermediate.addConstantUnion(unionArray, |
| 3894 | TType(EbtFloat, EbpUndefined, EvqConst), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3895 | } |
| 3896 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 3897 | return callNode; |
| 3898 | } |
| 3899 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3900 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3901 | TIntermTyped *trueExpression, |
| 3902 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 3903 | const TSourceLoc &loc) |
| 3904 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3905 | checkIsScalarBool(loc, cond); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 3906 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3907 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 3908 | { |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3909 | binaryOpError(loc, ":", trueExpression->getCompleteString(), |
| 3910 | falseExpression->getCompleteString()); |
| 3911 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 3912 | } |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 3913 | // ESSL1 sections 5.2 and 5.7: |
| 3914 | // ESSL3 section 5.7: |
| 3915 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3916 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 3917 | { |
| 3918 | error(loc, "ternary operator is not allowed for structures or arrays", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3919 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 3920 | } |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3921 | // WebGL2 section 5.26, the following results in an error: |
| 3922 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3923 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3924 | { |
| 3925 | error(loc, "ternary operator is not allowed for void", ":"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3926 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 3927 | } |
| 3928 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 3929 | return TIntermediate::AddTernarySelection(cond, trueExpression, falseExpression, loc); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 3930 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 3931 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3932 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3933 | // Parse an array of strings using yyparse. |
| 3934 | // |
| 3935 | // Returns 0 for success. |
| 3936 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3937 | int PaParseStrings(size_t count, |
| 3938 | const char *const string[], |
| 3939 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3940 | TParseContext *context) |
| 3941 | { |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3942 | if ((count == 0) || (string == NULL)) |
| 3943 | return 1; |
| 3944 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3945 | if (glslang_initialize(context)) |
| 3946 | return 1; |
| 3947 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 3948 | int error = glslang_scan(count, string, length, context); |
| 3949 | if (!error) |
| 3950 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3951 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 3952 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 3953 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 3954 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3955 | } |