Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 1 | // |
| 2 | // Copyright (c) 2013 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 6 | // ValidateOutputs validates fragment shader outputs. It checks for conflicting locations, |
| 7 | // out-of-range locations, that locations are specified when using multiple outputs, and YUV output |
| 8 | // validity. |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 9 | |
Geoff Lang | 1773282 | 2013-08-29 13:46:49 -0400 | [diff] [blame] | 10 | #include "compiler/translator/ValidateOutputs.h" |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 11 | |
| 12 | #include <set> |
| 13 | |
Geoff Lang | 1773282 | 2013-08-29 13:46:49 -0400 | [diff] [blame] | 14 | #include "compiler/translator/InfoSink.h" |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 15 | #include "compiler/translator/IntermNode.h" |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 16 | #include "compiler/translator/ParseContext.h" |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 17 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 18 | namespace sh |
| 19 | { |
| 20 | |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 21 | namespace |
| 22 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 23 | void error(const TIntermSymbol &symbol, const char *reason, TDiagnostics *diagnostics) |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 24 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 25 | diagnostics->error(symbol.getLine(), reason, symbol.getSymbol().c_str()); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 26 | } |
| 27 | |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 28 | class ValidateOutputsTraverser : public TIntermTraverser |
| 29 | { |
| 30 | public: |
| 31 | ValidateOutputsTraverser(const TExtensionBehavior &extBehavior, int maxDrawBuffers); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 32 | |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 33 | void validate(TDiagnostics *diagnostics) const; |
| 34 | |
| 35 | void visitSymbol(TIntermSymbol *) override; |
| 36 | |
| 37 | private: |
| 38 | int mMaxDrawBuffers; |
| 39 | bool mAllowUnspecifiedOutputLocationResolution; |
| 40 | bool mUsesFragDepth; |
| 41 | |
| 42 | typedef std::vector<TIntermSymbol *> OutputVector; |
| 43 | OutputVector mOutputs; |
| 44 | OutputVector mUnspecifiedLocationOutputs; |
| 45 | OutputVector mYuvOutputs; |
| 46 | std::set<std::string> mVisitedSymbols; |
| 47 | }; |
| 48 | |
| 49 | ValidateOutputsTraverser::ValidateOutputsTraverser(const TExtensionBehavior &extBehavior, |
| 50 | int maxDrawBuffers) |
Olli Etuaho | 3d0d9a4 | 2015-06-01 12:16:36 +0300 | [diff] [blame] | 51 | : TIntermTraverser(true, false, false), |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 52 | mMaxDrawBuffers(maxDrawBuffers), |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 53 | mAllowUnspecifiedOutputLocationResolution( |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 54 | IsExtensionEnabled(extBehavior, "GL_EXT_blend_func_extended")), |
| 55 | mUsesFragDepth(false) |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 56 | { |
| 57 | } |
| 58 | |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 59 | void ValidateOutputsTraverser::visitSymbol(TIntermSymbol *symbol) |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 60 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 61 | TString name = symbol->getSymbol(); |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 62 | TQualifier qualifier = symbol->getQualifier(); |
| 63 | |
Jamie Madill | 5ed2398 | 2016-04-22 15:08:57 -0400 | [diff] [blame] | 64 | if (mVisitedSymbols.count(name.c_str()) == 1) |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 65 | return; |
| 66 | |
Jamie Madill | 5ed2398 | 2016-04-22 15:08:57 -0400 | [diff] [blame] | 67 | mVisitedSymbols.insert(name.c_str()); |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 68 | |
Jamie Madill | 1957181 | 2013-08-12 15:26:34 -0700 | [diff] [blame] | 69 | if (qualifier == EvqFragmentOut) |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 70 | { |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 71 | if (symbol->getType().getLayoutQualifier().location != -1) |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 72 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 73 | mOutputs.push_back(symbol); |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 74 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 75 | else if (symbol->getType().getLayoutQualifier().yuv == true) |
| 76 | { |
| 77 | mYuvOutputs.push_back(symbol); |
| 78 | } |
| 79 | else |
| 80 | { |
| 81 | mUnspecifiedLocationOutputs.push_back(symbol); |
| 82 | } |
| 83 | } |
| 84 | else if (qualifier == EvqFragDepth || qualifier == EvqFragDepthEXT) |
| 85 | { |
| 86 | mUsesFragDepth = true; |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 87 | } |
| 88 | } |
| 89 | |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 90 | void ValidateOutputsTraverser::validate(TDiagnostics *diagnostics) const |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 91 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 92 | ASSERT(diagnostics); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 93 | OutputVector validOutputs(mMaxDrawBuffers); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 94 | |
| 95 | for (const auto &symbol : mOutputs) |
| 96 | { |
| 97 | const TType &type = symbol->getType(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 98 | const size_t elementCount = static_cast<size_t>(type.isArray() ? type.getArraySize() : 1u); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 99 | const size_t location = static_cast<size_t>(type.getLayoutQualifier().location); |
| 100 | |
| 101 | ASSERT(type.getLayoutQualifier().location != -1); |
| 102 | |
| 103 | if (location + elementCount <= validOutputs.size()) |
| 104 | { |
| 105 | for (size_t elementIndex = 0; elementIndex < elementCount; elementIndex++) |
| 106 | { |
| 107 | const size_t offsetLocation = location + elementIndex; |
| 108 | if (validOutputs[offsetLocation]) |
| 109 | { |
| 110 | std::stringstream strstr; |
| 111 | strstr << "conflicting output locations with previously defined output '" |
| 112 | << validOutputs[offsetLocation]->getSymbol() << "'"; |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 113 | error(*symbol, strstr.str().c_str(), diagnostics); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 114 | } |
| 115 | else |
| 116 | { |
| 117 | validOutputs[offsetLocation] = symbol; |
| 118 | } |
| 119 | } |
| 120 | } |
| 121 | else |
| 122 | { |
| 123 | if (elementCount > 0) |
| 124 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 125 | error(*symbol, |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 126 | elementCount > 1 ? "output array locations would exceed MAX_DRAW_BUFFERS" |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 127 | : "output location must be < MAX_DRAW_BUFFERS", |
| 128 | diagnostics); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 129 | } |
| 130 | } |
| 131 | } |
| 132 | |
| 133 | if (!mAllowUnspecifiedOutputLocationResolution && |
| 134 | ((!mOutputs.empty() && !mUnspecifiedLocationOutputs.empty()) || |
| 135 | mUnspecifiedLocationOutputs.size() > 1)) |
| 136 | { |
| 137 | for (const auto &symbol : mUnspecifiedLocationOutputs) |
| 138 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 139 | error(*symbol, |
| 140 | "must explicitly specify all locations when using multiple fragment outputs", |
| 141 | diagnostics); |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 142 | } |
| 143 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 144 | |
| 145 | if (!mYuvOutputs.empty() && (mYuvOutputs.size() > 1 || mUsesFragDepth || !mOutputs.empty() || |
| 146 | !mUnspecifiedLocationOutputs.empty())) |
| 147 | { |
| 148 | for (const auto &symbol : mYuvOutputs) |
| 149 | { |
| 150 | error(*symbol, |
| 151 | "not allowed to specify yuv qualifier when using depth or multiple color " |
| 152 | "fragment outputs", |
| 153 | diagnostics); |
| 154 | } |
| 155 | } |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 156 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 157 | |
Olli Etuaho | 12b0b39 | 2017-05-30 13:22:31 +0300 | [diff] [blame^] | 158 | } // anonymous namespace |
| 159 | |
| 160 | bool ValidateOutputs(TIntermBlock *root, |
| 161 | const TExtensionBehavior &extBehavior, |
| 162 | int maxDrawBuffers, |
| 163 | TDiagnostics *diagnostics) |
| 164 | { |
| 165 | ValidateOutputsTraverser validateOutputs(extBehavior, maxDrawBuffers); |
| 166 | root->traverse(&validateOutputs); |
| 167 | int numErrorsBefore = diagnostics->numErrors(); |
| 168 | validateOutputs.validate(diagnostics); |
| 169 | return (diagnostics->numErrors() == numErrorsBefore); |
| 170 | } |
| 171 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 172 | } // namespace sh |