blob: 206cfaa640a3322421c84d8825baad2271a8c0ec [file] [log] [blame]
Jamie Madill9e54b5a2016-05-25 12:57:39 -04001//
2// Copyright 2016 The ANGLE Project Authors. All rights reserved.
3// Use of this source code is governed by a BSD-style license that can be
4// found in the LICENSE file.
5//
6// VertexArrayVk.cpp:
7// Implements the class methods for VertexArrayVk.
8//
9
10#include "libANGLE/renderer/vulkan/VertexArrayVk.h"
11
12#include "common/debug.h"
13
Jamie Madillc564c072017-06-01 12:45:42 -040014#include "libANGLE/Context.h"
Jamie Madillbd159f02017-10-09 19:39:06 -040015#include "libANGLE/renderer/vulkan/BufferVk.h"
Jamie Madill1f46bc12018-02-20 16:09:43 -050016#include "libANGLE/renderer/vulkan/CommandGraph.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040017#include "libANGLE/renderer/vulkan/ContextVk.h"
Jamie Madill316c6062018-05-29 10:49:45 -040018#include "libANGLE/renderer/vulkan/FramebufferVk.h"
Jamie Madillc3755fc2018-04-05 08:39:13 -040019#include "libANGLE/renderer/vulkan/RendererVk.h"
Jamie Madill3c424b42018-01-19 12:35:09 -050020#include "libANGLE/renderer/vulkan/vk_format_utils.h"
Jamie Madilldd43e6c2017-03-24 14:18:49 -040021
Jamie Madill9e54b5a2016-05-25 12:57:39 -040022namespace rx
23{
Jamie Madillc3755fc2018-04-05 08:39:13 -040024namespace
25{
26constexpr size_t kDynamicVertexDataSize = 1024 * 1024;
27constexpr size_t kDynamicIndexDataSize = 1024 * 8;
28} // anonymous namespace
Jamie Madill9e54b5a2016-05-25 12:57:39 -040029
Luc Ferrona9ab0f32018-05-17 17:03:55 -040030VertexArrayVk::VertexArrayVk(const gl::VertexArrayState &state, RendererVk *renderer)
Jamie Madillbd159f02017-10-09 19:39:06 -040031 : VertexArrayImpl(state),
Jamie Madillda854a22017-11-30 17:24:21 -050032 mCurrentArrayBufferHandles{},
Frank Henigman17448952017-01-05 15:48:26 -050033 mCurrentArrayBufferOffsets{},
Jamie Madillda854a22017-11-30 17:24:21 -050034 mCurrentArrayBufferResources{},
Jamie Madillc3755fc2018-04-05 08:39:13 -040035 mCurrentElementArrayBufferHandle(VK_NULL_HANDLE),
36 mCurrentElementArrayBufferOffset(0),
37 mCurrentElementArrayBufferResource(nullptr),
38 mDynamicVertexData(VK_BUFFER_USAGE_VERTEX_BUFFER_BIT, kDynamicVertexDataSize),
39 mDynamicIndexData(VK_BUFFER_USAGE_INDEX_BUFFER_BIT, kDynamicIndexDataSize),
Luc Ferrona9ab0f32018-05-17 17:03:55 -040040 mLineLoopHelper(renderer),
Jamie Madillb8e39662018-04-04 11:41:42 -040041 mDirtyLineLoopTranslation(true),
Jamie Madillc3755fc2018-04-05 08:39:13 -040042 mVertexBuffersDirty(false),
43 mIndexBufferDirty(false)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040044{
Jamie Madillda854a22017-11-30 17:24:21 -050045 mCurrentArrayBufferHandles.fill(VK_NULL_HANDLE);
Frank Henigman17448952017-01-05 15:48:26 -050046 mCurrentArrayBufferOffsets.fill(0);
Jamie Madillda854a22017-11-30 17:24:21 -050047 mCurrentArrayBufferResources.fill(nullptr);
Jamie Madill112a3a82018-01-23 13:04:06 -050048
49 mPackedInputBindings.fill({0, 0});
50 mPackedInputAttributes.fill({0, 0, 0});
Jamie Madillc3755fc2018-04-05 08:39:13 -040051
Luc Ferrona9ab0f32018-05-17 17:03:55 -040052 mDynamicVertexData.init(1, renderer);
53 mDynamicIndexData.init(1, renderer);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040054}
55
Jamie Madillacf2f3a2017-11-21 19:22:44 -050056VertexArrayVk::~VertexArrayVk()
57{
58}
59
Jamie Madill4928b7c2017-06-20 12:57:39 -040060void VertexArrayVk::destroy(const gl::Context *context)
Jamie Madill9e54b5a2016-05-25 12:57:39 -040061{
Jamie Madillc3755fc2018-04-05 08:39:13 -040062 VkDevice device = vk::GetImpl(context)->getRenderer()->getDevice();
Jamie Madillc3755fc2018-04-05 08:39:13 -040063 mDynamicVertexData.destroy(device);
64 mDynamicIndexData.destroy(device);
Jamie Madill22f12fe2018-04-08 14:23:40 -040065 mLineLoopHelper.destroy(device);
Jamie Madill9e54b5a2016-05-25 12:57:39 -040066}
67
Jamie Madillc3755fc2018-04-05 08:39:13 -040068gl::Error VertexArrayVk::streamVertexData(RendererVk *renderer,
69 const gl::AttributesMask &attribsToStream,
Jamie Madill32fd63b2018-03-31 11:20:35 -040070 const gl::DrawCallParams &drawCallParams)
Frank Henigman17448952017-01-05 15:48:26 -050071{
Jamie Madillc3755fc2018-04-05 08:39:13 -040072 ASSERT(!attribsToStream.none());
73
Jamie Madillbcef3222018-04-13 15:19:11 -040074 const auto &attribs = mState.getVertexAttributes();
75 const auto &bindings = mState.getVertexBindings();
Frank Henigman17448952017-01-05 15:48:26 -050076
Jamie Madill32fd63b2018-03-31 11:20:35 -040077 const size_t lastVertex = drawCallParams.firstVertex() + drawCallParams.vertexCount();
78
Frank Henigman17448952017-01-05 15:48:26 -050079 // TODO(fjhenigman): When we have a bunch of interleaved attributes, they end up
80 // un-interleaved, wasting space and copying time. Consider improving on that.
Jamie Madillb8e39662018-04-04 11:41:42 -040081 for (size_t attribIndex : attribsToStream)
Frank Henigman17448952017-01-05 15:48:26 -050082 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050083 const gl::VertexAttribute &attrib = attribs[attribIndex];
84 const gl::VertexBinding &binding = bindings[attrib.bindingIndex];
85 ASSERT(attrib.enabled && binding.getBuffer().get() == nullptr);
Frank Henigman17448952017-01-05 15:48:26 -050086
Frank Henigman6dd4a922018-03-02 16:35:13 -050087 // TODO(fjhenigman): Work with more formats than just GL_FLOAT.
88 if (attrib.type != GL_FLOAT)
Frank Henigman17448952017-01-05 15:48:26 -050089 {
Frank Henigman6dd4a922018-03-02 16:35:13 -050090 UNIMPLEMENTED();
91 return gl::InternalError();
Frank Henigman17448952017-01-05 15:48:26 -050092 }
Frank Henigman6dd4a922018-03-02 16:35:13 -050093
94 // Only [firstVertex, lastVertex] is needed by the upcoming draw so that
95 // is all we copy, but we allocate space for [0, lastVertex] so indexing
96 // will work. If we don't start at zero all the indices will be off.
97 // TODO(fjhenigman): See if we can account for indices being off by adjusting
98 // the offset, thus avoiding wasted memory.
Jamie Madill32fd63b2018-03-31 11:20:35 -040099 const size_t firstByte = drawCallParams.firstVertex() * binding.getStride();
Frank Henigman6dd4a922018-03-02 16:35:13 -0500100 const size_t lastByte =
101 lastVertex * binding.getStride() + gl::ComputeVertexAttributeTypeSize(attrib);
Jamie Madill493f9572018-05-24 19:52:15 -0400102 uint8_t *dst = nullptr;
Luc Ferron7a06ac12018-03-15 10:17:04 -0400103 uint32_t offset = 0;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400104 ANGLE_TRY(mDynamicVertexData.allocate(
105 renderer, lastByte, &dst, &mCurrentArrayBufferHandles[attribIndex], &offset, nullptr));
Luc Ferron7a06ac12018-03-15 10:17:04 -0400106 mCurrentArrayBufferOffsets[attribIndex] = static_cast<VkDeviceSize>(offset);
Frank Henigman6dd4a922018-03-02 16:35:13 -0500107 memcpy(dst + firstByte, static_cast<const uint8_t *>(attrib.pointer) + firstByte,
108 lastByte - firstByte);
Frank Henigman17448952017-01-05 15:48:26 -0500109 }
110
Jamie Madillc3755fc2018-04-05 08:39:13 -0400111 ANGLE_TRY(mDynamicVertexData.flush(renderer->getDevice()));
Luc Ferron61859812018-05-09 14:17:39 -0400112 mDynamicVertexData.releaseRetainedBuffers(renderer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400113 return gl::NoError();
114}
115
116gl::Error VertexArrayVk::streamIndexData(RendererVk *renderer,
117 const gl::DrawCallParams &drawCallParams)
118{
119 ASSERT(!mState.getElementArrayBuffer().get());
120
121 uint32_t offset = 0;
122
123 const GLsizei amount = sizeof(GLushort) * drawCallParams.indexCount();
124 GLubyte *dst = nullptr;
125
126 ANGLE_TRY(mDynamicIndexData.allocate(renderer, amount, &dst, &mCurrentElementArrayBufferHandle,
127 &offset, nullptr));
128 if (drawCallParams.type() == GL_UNSIGNED_BYTE)
129 {
130 // Unsigned bytes don't have direct support in Vulkan so we have to expand the
131 // memory to a GLushort.
132 const GLubyte *in = static_cast<const GLubyte *>(drawCallParams.indices());
133 GLushort *expandedDst = reinterpret_cast<GLushort *>(dst);
134 for (GLsizei index = 0; index < drawCallParams.indexCount(); index++)
135 {
136 expandedDst[index] = static_cast<GLushort>(in[index]);
137 }
138 }
139 else
140 {
141 memcpy(dst, drawCallParams.indices(), amount);
142 }
143 ANGLE_TRY(mDynamicIndexData.flush(renderer->getDevice()));
Luc Ferron61859812018-05-09 14:17:39 -0400144 mDynamicIndexData.releaseRetainedBuffers(renderer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400145 mCurrentElementArrayBufferOffset = offset;
Frank Henigman17448952017-01-05 15:48:26 -0500146 return gl::NoError();
147}
148
Jamie Madilla56467e2018-04-11 16:19:41 -0400149#define ANGLE_VERTEX_DIRTY_ATTRIB_FUNC(INDEX) \
150 case gl::VertexArray::DIRTY_BIT_ATTRIB_0 + INDEX: \
151 syncDirtyAttrib(attribs[INDEX], bindings[attribs[INDEX].bindingIndex], INDEX); \
152 invalidatePipeline = true; \
153 break;
154
155#define ANGLE_VERTEX_DIRTY_BINDING_FUNC(INDEX) \
156 case gl::VertexArray::DIRTY_BIT_BINDING_0 + INDEX: \
157 syncDirtyAttrib(attribs[INDEX], bindings[attribs[INDEX].bindingIndex], INDEX); \
158 invalidatePipeline = true; \
159 break;
160
161#define ANGLE_VERTEX_DIRTY_BUFFER_DATA_FUNC(INDEX) \
162 case gl::VertexArray::DIRTY_BIT_BUFFER_DATA_0 + INDEX: \
163 break;
164
Frank Henigman0af5b862018-03-27 20:19:33 -0400165gl::Error VertexArrayVk::syncState(const gl::Context *context,
166 const gl::VertexArray::DirtyBits &dirtyBits,
167 const gl::VertexArray::DirtyAttribBitsArray &attribBits,
168 const gl::VertexArray::DirtyBindingBitsArray &bindingBits)
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400169{
170 ASSERT(dirtyBits.any());
Jamie Madill72106562017-03-24 14:18:50 -0400171
Jamie Madillc3755fc2018-04-05 08:39:13 -0400172 bool invalidatePipeline = false;
173
Jamie Madillbd159f02017-10-09 19:39:06 -0400174 // Invalidate current pipeline.
Jamie Madillacf2f3a2017-11-21 19:22:44 -0500175 ContextVk *contextVk = vk::GetImpl(context);
Jamie Madillbd159f02017-10-09 19:39:06 -0400176
177 // Rebuild current attribute buffers cache. This will fail horribly if the buffer changes.
178 // TODO(jmadill): Handle buffer storage changes.
179 const auto &attribs = mState.getVertexAttributes();
180 const auto &bindings = mState.getVertexBindings();
181
Jamie Madill09463932018-04-04 05:26:59 -0400182 for (size_t dirtyBit : dirtyBits)
Jamie Madillbd159f02017-10-09 19:39:06 -0400183 {
Jamie Madill09463932018-04-04 05:26:59 -0400184 switch (dirtyBit)
Jamie Madillda854a22017-11-30 17:24:21 -0500185 {
Jamie Madill09463932018-04-04 05:26:59 -0400186 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER:
Jamie Madillda854a22017-11-30 17:24:21 -0500187 {
Jamie Madill09463932018-04-04 05:26:59 -0400188 gl::Buffer *bufferGL = mState.getElementArrayBuffer().get();
189 if (bufferGL)
190 {
Jamie Madillc3755fc2018-04-05 08:39:13 -0400191 BufferVk *bufferVk = vk::GetImpl(bufferGL);
192 mCurrentElementArrayBufferResource = bufferVk;
193 mCurrentElementArrayBufferHandle = bufferVk->getVkBuffer().getHandle();
194 mCurrentElementArrayBufferOffset = 0;
Jamie Madill09463932018-04-04 05:26:59 -0400195 }
196 else
197 {
198 mCurrentElementArrayBufferResource = nullptr;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400199 mCurrentElementArrayBufferHandle = VK_NULL_HANDLE;
200 mCurrentElementArrayBufferOffset = 0;
Jamie Madill09463932018-04-04 05:26:59 -0400201 }
Jamie Madillb8e39662018-04-04 11:41:42 -0400202 mIndexBufferDirty = true;
203 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400204 break;
Jamie Madillda854a22017-11-30 17:24:21 -0500205 }
Jamie Madill09463932018-04-04 05:26:59 -0400206
207 case gl::VertexArray::DIRTY_BIT_ELEMENT_ARRAY_BUFFER_DATA:
Jamie Madillc3755fc2018-04-05 08:39:13 -0400208 mLineLoopBufferFirstIndex.reset();
209 mLineLoopBufferLastIndex.reset();
Jamie Madillb8e39662018-04-04 11:41:42 -0400210 mDirtyLineLoopTranslation = true;
Jamie Madill09463932018-04-04 05:26:59 -0400211 break;
212
Jamie Madilla56467e2018-04-11 16:19:41 -0400213 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_ATTRIB_FUNC);
214 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_BINDING_FUNC);
215 ANGLE_VERTEX_INDEX_CASES(ANGLE_VERTEX_DIRTY_BUFFER_DATA_FUNC);
216
Jamie Madill09463932018-04-04 05:26:59 -0400217 default:
Jamie Madilla56467e2018-04-11 16:19:41 -0400218 UNREACHABLE();
Jamie Madill09463932018-04-04 05:26:59 -0400219 break;
Jamie Madillbd159f02017-10-09 19:39:06 -0400220 }
221 }
Frank Henigman0af5b862018-03-27 20:19:33 -0400222
Jamie Madillc3755fc2018-04-05 08:39:13 -0400223 if (invalidatePipeline)
224 {
225 mVertexBuffersDirty = true;
226 contextVk->invalidateCurrentPipeline();
227 }
228
Frank Henigman0af5b862018-03-27 20:19:33 -0400229 return gl::NoError();
Jamie Madillbd159f02017-10-09 19:39:06 -0400230}
231
Jamie Madilla56467e2018-04-11 16:19:41 -0400232void VertexArrayVk::syncDirtyAttrib(const gl::VertexAttribute &attrib,
233 const gl::VertexBinding &binding,
234 size_t attribIndex)
235{
236 // Invalidate the input description for pipelines.
237 mDirtyPackedInputs.set(attribIndex);
238
239 if (attrib.enabled)
240 {
241 gl::Buffer *bufferGL = binding.getBuffer().get();
242
243 if (bufferGL)
244 {
245 BufferVk *bufferVk = vk::GetImpl(bufferGL);
246 mCurrentArrayBufferResources[attribIndex] = bufferVk;
247 mCurrentArrayBufferHandles[attribIndex] = bufferVk->getVkBuffer().getHandle();
Jamie Madilla56467e2018-04-11 16:19:41 -0400248 }
249 else
250 {
251 mCurrentArrayBufferResources[attribIndex] = nullptr;
252 mCurrentArrayBufferHandles[attribIndex] = VK_NULL_HANDLE;
Jamie Madilla56467e2018-04-11 16:19:41 -0400253 }
254 // TODO(jmadill): Offset handling. Assume zero for now.
255 mCurrentArrayBufferOffsets[attribIndex] = 0;
256 }
257 else
258 {
Jamie Madilla56467e2018-04-11 16:19:41 -0400259 UNIMPLEMENTED();
260 }
261}
262
Jamie Madillda854a22017-11-30 17:24:21 -0500263const gl::AttribArray<VkBuffer> &VertexArrayVk::getCurrentArrayBufferHandles() const
Jamie Madillbd159f02017-10-09 19:39:06 -0400264{
Jamie Madillda854a22017-11-30 17:24:21 -0500265 return mCurrentArrayBufferHandles;
Jamie Madillbd159f02017-10-09 19:39:06 -0400266}
267
Frank Henigman17448952017-01-05 15:48:26 -0500268const gl::AttribArray<VkDeviceSize> &VertexArrayVk::getCurrentArrayBufferOffsets() const
269{
270 return mCurrentArrayBufferOffsets;
271}
272
Jamie Madill316c6062018-05-29 10:49:45 -0400273void VertexArrayVk::updateArrayBufferReadDependencies(vk::CommandGraphResource *drawFramebuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400274 const gl::AttributesMask &activeAttribsMask,
275 Serial serial)
Jamie Madillbd159f02017-10-09 19:39:06 -0400276{
Jamie Madillda854a22017-11-30 17:24:21 -0500277 // Handle the bound array buffers.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400278 for (size_t attribIndex : activeAttribsMask)
Jamie Madillbd159f02017-10-09 19:39:06 -0400279 {
Frank Henigman17448952017-01-05 15:48:26 -0500280 if (mCurrentArrayBufferResources[attribIndex])
Jamie Madill316c6062018-05-29 10:49:45 -0400281 mCurrentArrayBufferResources[attribIndex]->addReadDependency(drawFramebuffer);
Jamie Madillda854a22017-11-30 17:24:21 -0500282 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400283}
Jamie Madillda854a22017-11-30 17:24:21 -0500284
Jamie Madill316c6062018-05-29 10:49:45 -0400285void VertexArrayVk::updateElementArrayBufferReadDependency(
286 vk::CommandGraphResource *drawFramebuffer,
287 Serial serial)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400288{
Jamie Madillda854a22017-11-30 17:24:21 -0500289 // Handle the bound element array buffer.
Jamie Madillc3755fc2018-04-05 08:39:13 -0400290 if (mCurrentElementArrayBufferResource)
Jamie Madillda854a22017-11-30 17:24:21 -0500291 {
Jamie Madill316c6062018-05-29 10:49:45 -0400292 mCurrentElementArrayBufferResource->addReadDependency(drawFramebuffer);
Jamie Madillbd159f02017-10-09 19:39:06 -0400293 }
Jamie Madilldd43e6c2017-03-24 14:18:49 -0400294}
295
Jamie Madill112a3a82018-01-23 13:04:06 -0500296void VertexArrayVk::getPackedInputDescriptions(vk::PipelineDesc *pipelineDesc)
Jamie Madillebf72992017-10-13 14:09:45 -0400297{
Jamie Madill112a3a82018-01-23 13:04:06 -0500298 updatePackedInputDescriptions();
299 pipelineDesc->updateVertexInputInfo(mPackedInputBindings, mPackedInputAttributes);
Jamie Madillebf72992017-10-13 14:09:45 -0400300}
301
Jamie Madill112a3a82018-01-23 13:04:06 -0500302void VertexArrayVk::updatePackedInputDescriptions()
Jamie Madillebf72992017-10-13 14:09:45 -0400303{
Jamie Madill112a3a82018-01-23 13:04:06 -0500304 if (!mDirtyPackedInputs.any())
Jamie Madillebf72992017-10-13 14:09:45 -0400305 {
306 return;
307 }
308
309 const auto &attribs = mState.getVertexAttributes();
310 const auto &bindings = mState.getVertexBindings();
311
Jamie Madill112a3a82018-01-23 13:04:06 -0500312 for (auto attribIndex : mDirtyPackedInputs)
Jamie Madillebf72992017-10-13 14:09:45 -0400313 {
314 const auto &attrib = attribs[attribIndex];
315 const auto &binding = bindings[attrib.bindingIndex];
316 if (attrib.enabled)
317 {
Jamie Madill112a3a82018-01-23 13:04:06 -0500318 updatePackedInputInfo(static_cast<uint32_t>(attribIndex), binding, attrib);
Jamie Madillebf72992017-10-13 14:09:45 -0400319 }
320 else
321 {
322 UNIMPLEMENTED();
323 }
324 }
325
Jamie Madill112a3a82018-01-23 13:04:06 -0500326 mDirtyPackedInputs.reset();
327}
328
329void VertexArrayVk::updatePackedInputInfo(uint32_t attribIndex,
330 const gl::VertexBinding &binding,
331 const gl::VertexAttribute &attrib)
332{
333 vk::PackedVertexInputBindingDesc &bindingDesc = mPackedInputBindings[attribIndex];
334
335 size_t attribSize = gl::ComputeVertexAttributeTypeSize(attrib);
336 ASSERT(attribSize <= std::numeric_limits<uint16_t>::max());
337
Frank Henigmana8e868f2018-01-28 23:32:25 -0500338 bindingDesc.stride = static_cast<uint16_t>(binding.getStride());
Jamie Madill112a3a82018-01-23 13:04:06 -0500339 bindingDesc.inputRate = static_cast<uint16_t>(
340 binding.getDivisor() > 0 ? VK_VERTEX_INPUT_RATE_INSTANCE : VK_VERTEX_INPUT_RATE_VERTEX);
341
342 gl::VertexFormatType vertexFormatType = gl::GetVertexFormatType(attrib);
343 VkFormat vkFormat = vk::GetNativeVertexFormat(vertexFormatType);
344 ASSERT(vkFormat <= std::numeric_limits<uint16_t>::max());
345
346 vk::PackedVertexInputAttributeDesc &attribDesc = mPackedInputAttributes[attribIndex];
347 attribDesc.format = static_cast<uint16_t>(vkFormat);
348 attribDesc.location = static_cast<uint16_t>(attribIndex);
349 attribDesc.offset = static_cast<uint32_t>(ComputeVertexAttributeOffset(attrib, binding));
Jamie Madillebf72992017-10-13 14:09:45 -0400350}
351
Jamie Madillc3755fc2018-04-05 08:39:13 -0400352gl::Error VertexArrayVk::drawArrays(const gl::Context *context,
353 RendererVk *renderer,
354 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400355 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400356 bool newCommandBuffer)
357{
Jamie Madillc3755fc2018-04-05 08:39:13 -0400358 ASSERT(commandBuffer->valid());
359
Jamie Madill316c6062018-05-29 10:49:45 -0400360 ANGLE_TRY(onDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400361
Jamie Madill18e323a2018-05-11 16:54:17 -0400362 // Note: Vertex indexes can be arbitrarily large.
363 uint32_t clampedVertexCount = drawCallParams.getClampedVertexCount<uint32_t>();
364
Jamie Madill493f9572018-05-24 19:52:15 -0400365 if (drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400366 {
Jamie Madill18e323a2018-05-11 16:54:17 -0400367 commandBuffer->draw(clampedVertexCount, 1, drawCallParams.firstVertex(), 0);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400368 return gl::NoError();
369 }
370
371 // Handle GL_LINE_LOOP drawArrays.
Jamie Madill18e323a2018-05-11 16:54:17 -0400372 size_t lastVertex = static_cast<size_t>(drawCallParams.firstVertex() + clampedVertexCount);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400373 if (!mLineLoopBufferFirstIndex.valid() || !mLineLoopBufferLastIndex.valid() ||
374 mLineLoopBufferFirstIndex != drawCallParams.firstVertex() ||
375 mLineLoopBufferLastIndex != lastVertex)
376 {
Jamie Madill22f12fe2018-04-08 14:23:40 -0400377 ANGLE_TRY(mLineLoopHelper.getIndexBufferForDrawArrays(renderer, drawCallParams,
378 &mCurrentElementArrayBufferHandle,
379 &mCurrentElementArrayBufferOffset));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400380
381 mLineLoopBufferFirstIndex = drawCallParams.firstVertex();
382 mLineLoopBufferLastIndex = lastVertex;
383 }
384
385 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
386 mCurrentElementArrayBufferOffset, VK_INDEX_TYPE_UINT32);
387
Jamie Madill18e323a2018-05-11 16:54:17 -0400388 vk::LineLoopHelper::Draw(clampedVertexCount, commandBuffer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400389
390 return gl::NoError();
391}
392
393gl::Error VertexArrayVk::drawElements(const gl::Context *context,
394 RendererVk *renderer,
395 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400396 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400397 bool newCommandBuffer)
398{
Jamie Madillc3755fc2018-04-05 08:39:13 -0400399 ASSERT(commandBuffer->valid());
400
Jamie Madill493f9572018-05-24 19:52:15 -0400401 if (drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400402 {
Jamie Madill316c6062018-05-29 10:49:45 -0400403 ANGLE_TRY(
404 onIndexedDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400405 commandBuffer->drawIndexed(drawCallParams.indexCount(), 1, 0, 0, 0);
406 return gl::NoError();
407 }
408
409 // Handle GL_LINE_LOOP drawElements.
Jamie Madillb8e39662018-04-04 11:41:42 -0400410 if (mDirtyLineLoopTranslation)
411 {
Luc Ferrona9120462018-04-12 13:11:03 -0400412 gl::Buffer *elementArrayBuffer = mState.getElementArrayBuffer().get();
413 VkIndexType indexType = gl_vk::GetIndexType(drawCallParams.type());
414
415 if (!elementArrayBuffer)
416 {
417 ANGLE_TRY(mLineLoopHelper.getIndexBufferForClientElementArray(
418 renderer, drawCallParams.indices(), indexType, drawCallParams.indexCount(),
419 &mCurrentElementArrayBufferHandle, &mCurrentElementArrayBufferOffset));
420 }
421 else
422 {
Luc Ferrona4fa9c22018-04-13 07:00:56 -0400423 // When using an element array buffer, 'indices' is an offset to the first element.
424 intptr_t offset = reinterpret_cast<intptr_t>(drawCallParams.indices());
Luc Ferrona9120462018-04-12 13:11:03 -0400425 BufferVk *elementArrayBufferVk = vk::GetImpl(elementArrayBuffer);
426 ANGLE_TRY(mLineLoopHelper.getIndexBufferForElementArrayBuffer(
Luc Ferrona4fa9c22018-04-13 07:00:56 -0400427 renderer, elementArrayBufferVk, indexType, drawCallParams.indexCount(), offset,
Luc Ferrona9120462018-04-12 13:11:03 -0400428 &mCurrentElementArrayBufferHandle, &mCurrentElementArrayBufferOffset));
429 }
Jamie Madillb8e39662018-04-04 11:41:42 -0400430 }
Jamie Madillc3755fc2018-04-05 08:39:13 -0400431
Jamie Madill316c6062018-05-29 10:49:45 -0400432 ANGLE_TRY(onIndexedDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madill22f12fe2018-04-08 14:23:40 -0400433 vk::LineLoopHelper::Draw(drawCallParams.indexCount(), commandBuffer);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400434
435 return gl::NoError();
436}
437
438gl::Error VertexArrayVk::onDraw(const gl::Context *context,
439 RendererVk *renderer,
440 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400441 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400442 bool newCommandBuffer)
443{
444 const gl::State &state = context->getGLState();
445 const gl::Program *programGL = state.getProgram();
Jamie Madillbcef3222018-04-13 15:19:11 -0400446 const gl::AttributesMask &clientAttribs = mState.getEnabledClientMemoryAttribsMask();
Jamie Madillc3755fc2018-04-05 08:39:13 -0400447 const gl::AttributesMask &activeAttribs = programGL->getActiveAttribLocationsMask();
448 uint32_t maxAttrib = programGL->getState().getMaxActiveAttribLocation();
449
Jamie Madillbcef3222018-04-13 15:19:11 -0400450 if (clientAttribs.any())
Jamie Madillc3755fc2018-04-05 08:39:13 -0400451 {
Jamie Madillbcef3222018-04-13 15:19:11 -0400452 const gl::AttributesMask &attribsToStream = (clientAttribs & activeAttribs);
Jamie Madillc3755fc2018-04-05 08:39:13 -0400453 if (attribsToStream.any())
454 {
455 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
456 ANGLE_TRY(streamVertexData(renderer, attribsToStream, drawCallParams));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400457 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
458 mCurrentArrayBufferOffsets.data());
459 }
460 }
461 else if (mVertexBuffersDirty || newCommandBuffer)
462 {
Luc Ferron44162472018-04-06 13:20:45 -0400463 if (maxAttrib > 0)
464 {
Luc Ferron44162472018-04-06 13:20:45 -0400465 commandBuffer->bindVertexBuffers(0, maxAttrib, mCurrentArrayBufferHandles.data(),
466 mCurrentArrayBufferOffsets.data());
Jamie Madill316c6062018-05-29 10:49:45 -0400467
468 vk::CommandGraphResource *drawFramebuffer = vk::GetImpl(state.getDrawFramebuffer());
469 updateArrayBufferReadDependencies(drawFramebuffer, activeAttribs,
Luc Ferron44162472018-04-06 13:20:45 -0400470 renderer->getCurrentQueueSerial());
471 }
Luc Ferronc1e02682018-04-11 11:02:55 -0400472
Jamie Madillc3755fc2018-04-05 08:39:13 -0400473 mVertexBuffersDirty = false;
Luc Ferronc1e02682018-04-11 11:02:55 -0400474
475 // This forces the binding to happen if we follow a drawElement call from a drawArrays call.
476 mIndexBufferDirty = true;
Luc Ferron983c4292018-04-10 13:05:45 -0400477
478 // If we've had a drawElements call with a line loop before, we want to make sure this is
479 // invalidated the next time drawElements is called since we use the same index buffer for
480 // both calls.
481 mDirtyLineLoopTranslation = true;
Jamie Madillc3755fc2018-04-05 08:39:13 -0400482 }
483
484 return gl::NoError();
485}
486
487gl::Error VertexArrayVk::onIndexedDraw(const gl::Context *context,
488 RendererVk *renderer,
489 const gl::DrawCallParams &drawCallParams,
Jamie Madill316c6062018-05-29 10:49:45 -0400490 vk::CommandBuffer *commandBuffer,
Jamie Madillc3755fc2018-04-05 08:39:13 -0400491 bool newCommandBuffer)
492{
Jamie Madill316c6062018-05-29 10:49:45 -0400493 ANGLE_TRY(onDraw(context, renderer, drawCallParams, commandBuffer, newCommandBuffer));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400494
Jamie Madill493f9572018-05-24 19:52:15 -0400495 if (!mState.getElementArrayBuffer().get() &&
496 drawCallParams.mode() != gl::PrimitiveMode::LineLoop)
Jamie Madillc3755fc2018-04-05 08:39:13 -0400497 {
498 ANGLE_TRY(drawCallParams.ensureIndexRangeResolved(context));
499 ANGLE_TRY(streamIndexData(renderer, drawCallParams));
Jamie Madillc3755fc2018-04-05 08:39:13 -0400500 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
501 mCurrentElementArrayBufferOffset,
502 gl_vk::GetIndexType(drawCallParams.type()));
503 }
504 else if (mIndexBufferDirty || newCommandBuffer)
505 {
506 if (drawCallParams.type() == GL_UNSIGNED_BYTE)
507 {
508 // TODO(fjhenigman): Index format translation.
509 UNIMPLEMENTED();
510 return gl::InternalError()
511 << "Unsigned byte translation is not implemented for indices in a buffer object";
512 }
513
Jamie Madillc3755fc2018-04-05 08:39:13 -0400514 commandBuffer->bindIndexBuffer(mCurrentElementArrayBufferHandle,
515 mCurrentElementArrayBufferOffset,
516 gl_vk::GetIndexType(drawCallParams.type()));
Jamie Madill316c6062018-05-29 10:49:45 -0400517
518 const gl::State &glState = context->getGLState();
519 vk::CommandGraphResource *drawFramebuffer = vk::GetImpl(glState.getDrawFramebuffer());
520 updateElementArrayBufferReadDependency(drawFramebuffer, renderer->getCurrentQueueSerial());
Jamie Madillc3755fc2018-04-05 08:39:13 -0400521 mIndexBufferDirty = false;
Luc Ferron983c4292018-04-10 13:05:45 -0400522
523 // If we've had a drawArrays call with a line loop before, we want to make sure this is
524 // invalidated the next time drawArrays is called since we use the same index buffer for
525 // both calls.
526 mLineLoopBufferFirstIndex.reset();
527 mLineLoopBufferLastIndex.reset();
Jamie Madillc3755fc2018-04-05 08:39:13 -0400528 }
529
530 return gl::NoError();
531}
Jamie Madill9e54b5a2016-05-25 12:57:39 -0400532} // namespace rx