Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 1 | // |
| 2 | // Copyright (c) 2002-2015 The ANGLE Project Authors. All rights reserved. |
| 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 6 | // RemoveSwitchFallThrough.cpp: Remove fall-through from switch statements. |
| 7 | // Note that it is unsafe to do further AST transformations on the AST generated |
| 8 | // by this function. It leaves duplicate nodes in the AST making replacements |
| 9 | // unreliable. |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 10 | |
| 11 | #include "compiler/translator/RemoveSwitchFallThrough.h" |
| 12 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 13 | #include "compiler/translator/IntermTraverse.h" |
| 14 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 15 | namespace sh |
| 16 | { |
| 17 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 18 | namespace |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 19 | { |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 20 | |
| 21 | class RemoveSwitchFallThroughTraverser : public TIntermTraverser |
| 22 | { |
| 23 | public: |
| 24 | static TIntermBlock *removeFallThrough(TIntermBlock *statementList); |
| 25 | |
| 26 | private: |
| 27 | RemoveSwitchFallThroughTraverser(TIntermBlock *statementList); |
| 28 | |
| 29 | void visitSymbol(TIntermSymbol *node) override; |
| 30 | void visitConstantUnion(TIntermConstantUnion *node) override; |
Olli Etuaho | 78507c6 | 2017-10-10 15:06:45 +0300 | [diff] [blame] | 31 | bool visitDeclaration(Visit, TIntermDeclaration *node) override; |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 32 | bool visitBinary(Visit, TIntermBinary *node) override; |
| 33 | bool visitUnary(Visit, TIntermUnary *node) override; |
| 34 | bool visitTernary(Visit visit, TIntermTernary *node) override; |
Olli Etuaho | 78507c6 | 2017-10-10 15:06:45 +0300 | [diff] [blame] | 35 | bool visitSwizzle(Visit, TIntermSwizzle *node) override; |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 36 | bool visitIfElse(Visit visit, TIntermIfElse *node) override; |
| 37 | bool visitSwitch(Visit, TIntermSwitch *node) override; |
| 38 | bool visitCase(Visit, TIntermCase *node) override; |
| 39 | bool visitAggregate(Visit, TIntermAggregate *node) override; |
| 40 | bool visitBlock(Visit, TIntermBlock *node) override; |
| 41 | bool visitLoop(Visit, TIntermLoop *node) override; |
| 42 | bool visitBranch(Visit, TIntermBranch *node) override; |
| 43 | |
| 44 | void outputSequence(TIntermSequence *sequence, size_t startIndex); |
| 45 | void handlePreviousCase(); |
| 46 | |
| 47 | TIntermBlock *mStatementList; |
| 48 | TIntermBlock *mStatementListOut; |
| 49 | bool mLastStatementWasBreak; |
| 50 | TIntermBlock *mPreviousCase; |
| 51 | std::vector<TIntermBlock *> mCasesSharingBreak; |
| 52 | }; |
| 53 | |
| 54 | TIntermBlock *RemoveSwitchFallThroughTraverser::removeFallThrough(TIntermBlock *statementList) |
| 55 | { |
| 56 | RemoveSwitchFallThroughTraverser rm(statementList); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 57 | ASSERT(statementList); |
| 58 | statementList->traverse(&rm); |
Olli Etuaho | 852fe87 | 2017-10-10 15:13:59 +0300 | [diff] [blame] | 59 | ASSERT(rm.mPreviousCase || statementList->getSequence()->empty()); |
| 60 | if (!rm.mLastStatementWasBreak && rm.mPreviousCase) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 61 | { |
Olli Etuaho | 852fe87 | 2017-10-10 15:13:59 +0300 | [diff] [blame] | 62 | // Make sure that there's a branch at the end of the final case inside the switch statement. |
| 63 | // This also ensures that any cases that fall through to the final case will get the break. |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 64 | TIntermBranch *finalBreak = new TIntermBranch(EOpBreak, nullptr); |
Olli Etuaho | 852fe87 | 2017-10-10 15:13:59 +0300 | [diff] [blame] | 65 | rm.mPreviousCase->getSequence()->push_back(finalBreak); |
| 66 | rm.mLastStatementWasBreak = true; |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 67 | } |
Olli Etuaho | 852fe87 | 2017-10-10 15:13:59 +0300 | [diff] [blame] | 68 | rm.handlePreviousCase(); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 69 | return rm.mStatementListOut; |
| 70 | } |
| 71 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 72 | RemoveSwitchFallThroughTraverser::RemoveSwitchFallThroughTraverser(TIntermBlock *statementList) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 73 | : TIntermTraverser(true, false, false), |
| 74 | mStatementList(statementList), |
| 75 | mLastStatementWasBreak(false), |
| 76 | mPreviousCase(nullptr) |
| 77 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 78 | mStatementListOut = new TIntermBlock(); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 79 | } |
| 80 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 81 | void RemoveSwitchFallThroughTraverser::visitSymbol(TIntermSymbol *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 82 | { |
| 83 | // Note that this assumes that switch statements which don't begin by a case statement |
| 84 | // have already been weeded out in validation. |
| 85 | mPreviousCase->getSequence()->push_back(node); |
| 86 | mLastStatementWasBreak = false; |
| 87 | } |
| 88 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 89 | void RemoveSwitchFallThroughTraverser::visitConstantUnion(TIntermConstantUnion *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 90 | { |
| 91 | // Conditions of case labels are not traversed, so this is some other constant |
| 92 | // Could be just a statement like "0;" |
| 93 | mPreviousCase->getSequence()->push_back(node); |
| 94 | mLastStatementWasBreak = false; |
| 95 | } |
| 96 | |
Olli Etuaho | 78507c6 | 2017-10-10 15:06:45 +0300 | [diff] [blame] | 97 | bool RemoveSwitchFallThroughTraverser::visitDeclaration(Visit, TIntermDeclaration *node) |
| 98 | { |
| 99 | mPreviousCase->getSequence()->push_back(node); |
| 100 | mLastStatementWasBreak = false; |
| 101 | return false; |
| 102 | } |
| 103 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 104 | bool RemoveSwitchFallThroughTraverser::visitBinary(Visit, TIntermBinary *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 105 | { |
| 106 | mPreviousCase->getSequence()->push_back(node); |
| 107 | mLastStatementWasBreak = false; |
| 108 | return false; |
| 109 | } |
| 110 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 111 | bool RemoveSwitchFallThroughTraverser::visitUnary(Visit, TIntermUnary *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 112 | { |
| 113 | mPreviousCase->getSequence()->push_back(node); |
| 114 | mLastStatementWasBreak = false; |
| 115 | return false; |
| 116 | } |
| 117 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 118 | bool RemoveSwitchFallThroughTraverser::visitTernary(Visit, TIntermTernary *node) |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 119 | { |
| 120 | mPreviousCase->getSequence()->push_back(node); |
| 121 | mLastStatementWasBreak = false; |
| 122 | return false; |
| 123 | } |
| 124 | |
Olli Etuaho | 78507c6 | 2017-10-10 15:06:45 +0300 | [diff] [blame] | 125 | bool RemoveSwitchFallThroughTraverser::visitSwizzle(Visit, TIntermSwizzle *node) |
| 126 | { |
| 127 | mPreviousCase->getSequence()->push_back(node); |
| 128 | mLastStatementWasBreak = false; |
| 129 | return false; |
| 130 | } |
| 131 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 132 | bool RemoveSwitchFallThroughTraverser::visitIfElse(Visit, TIntermIfElse *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 133 | { |
| 134 | mPreviousCase->getSequence()->push_back(node); |
| 135 | mLastStatementWasBreak = false; |
| 136 | return false; |
| 137 | } |
| 138 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 139 | bool RemoveSwitchFallThroughTraverser::visitSwitch(Visit, TIntermSwitch *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 140 | { |
| 141 | mPreviousCase->getSequence()->push_back(node); |
| 142 | mLastStatementWasBreak = false; |
| 143 | // Don't go into nested switch statements |
| 144 | return false; |
| 145 | } |
| 146 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 147 | void RemoveSwitchFallThroughTraverser::outputSequence(TIntermSequence *sequence, size_t startIndex) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 148 | { |
| 149 | for (size_t i = startIndex; i < sequence->size(); ++i) |
| 150 | { |
| 151 | mStatementListOut->getSequence()->push_back(sequence->at(i)); |
| 152 | } |
| 153 | } |
| 154 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 155 | void RemoveSwitchFallThroughTraverser::handlePreviousCase() |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 156 | { |
| 157 | if (mPreviousCase) |
| 158 | mCasesSharingBreak.push_back(mPreviousCase); |
| 159 | if (mLastStatementWasBreak) |
| 160 | { |
| 161 | bool labelsWithNoStatements = true; |
| 162 | for (size_t i = 0; i < mCasesSharingBreak.size(); ++i) |
| 163 | { |
| 164 | if (mCasesSharingBreak.at(i)->getSequence()->size() > 1) |
| 165 | { |
| 166 | labelsWithNoStatements = false; |
| 167 | } |
| 168 | if (labelsWithNoStatements) |
| 169 | { |
| 170 | // Fall-through is allowed in case the label has no statements. |
| 171 | outputSequence(mCasesSharingBreak.at(i)->getSequence(), 0); |
| 172 | } |
| 173 | else |
| 174 | { |
| 175 | // Include all the statements that this case can fall through under the same label. |
| 176 | for (size_t j = i; j < mCasesSharingBreak.size(); ++j) |
| 177 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 178 | size_t startIndex = |
| 179 | j > i ? 1 : 0; // Add the label only from the first sequence. |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 180 | outputSequence(mCasesSharingBreak.at(j)->getSequence(), startIndex); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 181 | } |
| 182 | } |
| 183 | } |
| 184 | mCasesSharingBreak.clear(); |
| 185 | } |
| 186 | mLastStatementWasBreak = false; |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 187 | mPreviousCase = nullptr; |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 188 | } |
| 189 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 190 | bool RemoveSwitchFallThroughTraverser::visitCase(Visit, TIntermCase *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 191 | { |
| 192 | handlePreviousCase(); |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 193 | mPreviousCase = new TIntermBlock(); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 194 | mPreviousCase->getSequence()->push_back(node); |
| 195 | // Don't traverse the condition of the case statement |
| 196 | return false; |
| 197 | } |
| 198 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 199 | bool RemoveSwitchFallThroughTraverser::visitAggregate(Visit, TIntermAggregate *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 200 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 201 | mPreviousCase->getSequence()->push_back(node); |
| 202 | mLastStatementWasBreak = false; |
| 203 | return false; |
| 204 | } |
| 205 | |
Olli Etuaho | 4bd730c | 2017-10-10 14:14:19 +0300 | [diff] [blame^] | 206 | bool DoesBlockAlwaysBreak(TIntermBlock *node) |
| 207 | { |
| 208 | if (node->getSequence()->empty()) |
| 209 | { |
| 210 | return false; |
| 211 | } |
| 212 | |
| 213 | TIntermBlock *lastStatementAsBlock = node->getSequence()->back()->getAsBlock(); |
| 214 | if (lastStatementAsBlock) |
| 215 | { |
| 216 | return DoesBlockAlwaysBreak(lastStatementAsBlock); |
| 217 | } |
| 218 | |
| 219 | TIntermBranch *lastStatementAsBranch = node->getSequence()->back()->getAsBranchNode(); |
| 220 | return lastStatementAsBranch != nullptr; |
| 221 | } |
| 222 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 223 | bool RemoveSwitchFallThroughTraverser::visitBlock(Visit, TIntermBlock *node) |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 224 | { |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 225 | if (node != mStatementList) |
| 226 | { |
| 227 | mPreviousCase->getSequence()->push_back(node); |
Olli Etuaho | 4bd730c | 2017-10-10 14:14:19 +0300 | [diff] [blame^] | 228 | mLastStatementWasBreak = DoesBlockAlwaysBreak(node); |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 229 | return false; |
| 230 | } |
| 231 | return true; |
| 232 | } |
| 233 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 234 | bool RemoveSwitchFallThroughTraverser::visitLoop(Visit, TIntermLoop *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 235 | { |
| 236 | mPreviousCase->getSequence()->push_back(node); |
| 237 | mLastStatementWasBreak = false; |
| 238 | return false; |
| 239 | } |
| 240 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 241 | bool RemoveSwitchFallThroughTraverser::visitBranch(Visit, TIntermBranch *node) |
Olli Etuaho | 2cd7a0e | 2015-02-27 13:57:32 +0200 | [diff] [blame] | 242 | { |
| 243 | mPreviousCase->getSequence()->push_back(node); |
| 244 | // TODO: Verify that accepting return or continue statements here doesn't cause problems. |
| 245 | mLastStatementWasBreak = true; |
| 246 | return false; |
| 247 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 248 | |
Olli Etuaho | af5070f | 2017-10-10 13:53:25 +0300 | [diff] [blame] | 249 | } // anonymous namespace |
| 250 | |
| 251 | TIntermBlock *RemoveSwitchFallThrough(TIntermBlock *statementList) |
| 252 | { |
| 253 | return RemoveSwitchFallThroughTraverser::removeFallThrough(statementList); |
| 254 | } |
| 255 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 256 | } // namespace sh |