Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1 | // |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 2 | // Copyright (c) 2013-2014 The ANGLE Project Authors. All rights reserved. |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
| 7 | // validationES2.cpp: Validation functions for OpenGL ES 2.0 entry point parameters |
| 8 | |
Geoff Lang | 2b5420c | 2014-11-19 14:20:15 -0500 | [diff] [blame] | 9 | #include "libANGLE/validationES2.h" |
| 10 | #include "libANGLE/validationES.h" |
| 11 | #include "libANGLE/Context.h" |
| 12 | #include "libANGLE/Texture.h" |
| 13 | #include "libANGLE/Framebuffer.h" |
| 14 | #include "libANGLE/Renderbuffer.h" |
| 15 | #include "libANGLE/formatutils.h" |
| 16 | #include "libANGLE/FramebufferAttachment.h" |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 17 | |
| 18 | #include "common/mathutil.h" |
| 19 | #include "common/utilities.h" |
| 20 | |
| 21 | namespace gl |
| 22 | { |
| 23 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 24 | bool ValidateES2TexImageParameters(Context *context, GLenum target, GLint level, GLenum internalformat, bool isCompressed, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 25 | GLint xoffset, GLint yoffset, GLsizei width, GLsizei height, |
| 26 | GLint border, GLenum format, GLenum type, const GLvoid *pixels) |
| 27 | { |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 28 | if (!ValidTexture2DDestinationTarget(context, target)) |
| 29 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 30 | context->recordError(Error(GL_INVALID_ENUM)); |
| 31 | return false; |
Jamie Madill | 6f38f82 | 2014-06-06 17:12:20 -0400 | [diff] [blame] | 32 | } |
| 33 | |
Austin Kinross | 08528e1 | 2015-10-07 16:24:40 -0700 | [diff] [blame] | 34 | if (!ValidImageSizeParameters(context, target, level, width, height, 1, isSubImage)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 35 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 36 | context->recordError(Error(GL_INVALID_VALUE)); |
| 37 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 38 | } |
| 39 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 40 | if (level < 0 || xoffset < 0 || |
| 41 | std::numeric_limits<GLsizei>::max() - xoffset < width || |
| 42 | std::numeric_limits<GLsizei>::max() - yoffset < height) |
| 43 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 44 | context->recordError(Error(GL_INVALID_VALUE)); |
| 45 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 46 | } |
| 47 | |
Geoff Lang | 005df41 | 2013-10-16 14:12:50 -0400 | [diff] [blame] | 48 | if (!isSubImage && !isCompressed && internalformat != format) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 49 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 50 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 51 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 52 | } |
| 53 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 54 | const gl::Caps &caps = context->getCaps(); |
| 55 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 56 | if (target == GL_TEXTURE_2D) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 57 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 58 | if (static_cast<GLuint>(width) > (caps.max2DTextureSize >> level) || |
| 59 | static_cast<GLuint>(height) > (caps.max2DTextureSize >> level)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 60 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 61 | context->recordError(Error(GL_INVALID_VALUE)); |
| 62 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 63 | } |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 64 | } |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 65 | else if (IsCubeMapTextureTarget(target)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 66 | { |
| 67 | if (!isSubImage && width != height) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 68 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 69 | context->recordError(Error(GL_INVALID_VALUE)); |
| 70 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 71 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 72 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 73 | if (static_cast<GLuint>(width) > (caps.maxCubeMapTextureSize >> level) || |
| 74 | static_cast<GLuint>(height) > (caps.maxCubeMapTextureSize >> level)) |
| 75 | { |
| 76 | context->recordError(Error(GL_INVALID_VALUE)); |
| 77 | return false; |
| 78 | } |
| 79 | } |
| 80 | else |
| 81 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 82 | context->recordError(Error(GL_INVALID_ENUM)); |
| 83 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 84 | } |
| 85 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 86 | gl::Texture *texture = context->getTargetTexture(IsCubeMapTextureTarget(target) ? GL_TEXTURE_CUBE_MAP : target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 87 | if (!texture) |
| 88 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 89 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 90 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 91 | } |
| 92 | |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 93 | if (isSubImage) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 94 | { |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 95 | if (format != GL_NONE) |
| 96 | { |
Geoff Lang | 051dbc7 | 2015-01-05 15:48:58 -0500 | [diff] [blame] | 97 | if (gl::GetSizedInternalFormat(format, type) != texture->getInternalFormat(target, level)) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 98 | { |
| 99 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 100 | return false; |
| 101 | } |
| 102 | } |
| 103 | |
| 104 | if (static_cast<size_t>(xoffset + width) > texture->getWidth(target, level) || |
| 105 | static_cast<size_t>(yoffset + height) > texture->getHeight(target, level)) |
| 106 | { |
| 107 | context->recordError(Error(GL_INVALID_VALUE)); |
| 108 | return false; |
| 109 | } |
| 110 | } |
| 111 | else |
| 112 | { |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 113 | if (texture->getImmutableFormat()) |
Geoff Lang | a9be0dc | 2014-12-17 12:34:40 -0500 | [diff] [blame] | 114 | { |
| 115 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 116 | return false; |
| 117 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 118 | } |
| 119 | |
| 120 | // Verify zero border |
| 121 | if (border != 0) |
| 122 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 123 | context->recordError(Error(GL_INVALID_VALUE)); |
| 124 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 125 | } |
| 126 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 127 | if (isCompressed) |
| 128 | { |
tmartino | 0ccd5ae | 2015-10-01 14:33:14 -0400 | [diff] [blame] | 129 | GLenum actualInternalFormat = |
| 130 | isSubImage ? texture->getInternalFormat(target, level) : internalformat; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 131 | switch (actualInternalFormat) |
| 132 | { |
| 133 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 134 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 135 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 136 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 137 | context->recordError(Error(GL_INVALID_ENUM)); |
| 138 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 139 | } |
| 140 | break; |
| 141 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 142 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 143 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 144 | context->recordError(Error(GL_INVALID_ENUM)); |
| 145 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 146 | } |
| 147 | break; |
| 148 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 149 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 150 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 151 | context->recordError(Error(GL_INVALID_ENUM)); |
| 152 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 153 | } |
| 154 | break; |
Geoff Lang | 6ea6f94 | 2015-09-11 13:11:22 -0400 | [diff] [blame] | 155 | case GL_ETC1_RGB8_OES: |
| 156 | if (!context->getExtensions().compressedETC1RGB8Texture) |
| 157 | { |
| 158 | context->recordError(Error(GL_INVALID_ENUM)); |
| 159 | return false; |
| 160 | } |
| 161 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 162 | default: |
tmartino | 0ccd5ae | 2015-10-01 14:33:14 -0400 | [diff] [blame] | 163 | context->recordError(Error( |
| 164 | GL_INVALID_ENUM, "internalformat is not a supported compressed internal format")); |
| 165 | return false; |
| 166 | } |
| 167 | if (!ValidCompressedImageSize(context, actualInternalFormat, width, height)) |
| 168 | { |
| 169 | context->recordError(Error(GL_INVALID_OPERATION)); |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 170 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 171 | } |
| 172 | } |
| 173 | else |
| 174 | { |
| 175 | // validate <type> by itself (used as secondary key below) |
| 176 | switch (type) |
| 177 | { |
| 178 | case GL_UNSIGNED_BYTE: |
| 179 | case GL_UNSIGNED_SHORT_5_6_5: |
| 180 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 181 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 182 | case GL_UNSIGNED_SHORT: |
| 183 | case GL_UNSIGNED_INT: |
| 184 | case GL_UNSIGNED_INT_24_8_OES: |
| 185 | case GL_HALF_FLOAT_OES: |
| 186 | case GL_FLOAT: |
| 187 | break; |
| 188 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 189 | context->recordError(Error(GL_INVALID_ENUM)); |
| 190 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 191 | } |
| 192 | |
| 193 | // validate <format> + <type> combinations |
| 194 | // - invalid <format> -> sets INVALID_ENUM |
| 195 | // - invalid <format>+<type> combination -> sets INVALID_OPERATION |
| 196 | switch (format) |
| 197 | { |
| 198 | case GL_ALPHA: |
| 199 | case GL_LUMINANCE: |
| 200 | case GL_LUMINANCE_ALPHA: |
| 201 | switch (type) |
| 202 | { |
| 203 | case GL_UNSIGNED_BYTE: |
| 204 | case GL_FLOAT: |
| 205 | case GL_HALF_FLOAT_OES: |
| 206 | break; |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 207 | default: |
| 208 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 209 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 210 | } |
| 211 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 212 | case GL_RED: |
Geoff Lang | cec3590 | 2014-04-16 10:52:36 -0400 | [diff] [blame] | 213 | case GL_RG: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 214 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 215 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 216 | context->recordError(Error(GL_INVALID_ENUM)); |
| 217 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 218 | } |
| 219 | switch (type) |
| 220 | { |
| 221 | case GL_UNSIGNED_BYTE: |
| 222 | case GL_FLOAT: |
| 223 | case GL_HALF_FLOAT_OES: |
| 224 | break; |
| 225 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 226 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 227 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 228 | } |
| 229 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 230 | case GL_RGB: |
| 231 | switch (type) |
| 232 | { |
| 233 | case GL_UNSIGNED_BYTE: |
| 234 | case GL_UNSIGNED_SHORT_5_6_5: |
| 235 | case GL_FLOAT: |
| 236 | case GL_HALF_FLOAT_OES: |
| 237 | break; |
| 238 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 239 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 240 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 241 | } |
| 242 | break; |
| 243 | case GL_RGBA: |
| 244 | switch (type) |
| 245 | { |
| 246 | case GL_UNSIGNED_BYTE: |
| 247 | case GL_UNSIGNED_SHORT_4_4_4_4: |
| 248 | case GL_UNSIGNED_SHORT_5_5_5_1: |
| 249 | case GL_FLOAT: |
| 250 | case GL_HALF_FLOAT_OES: |
| 251 | break; |
| 252 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 253 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 254 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 255 | } |
| 256 | break; |
| 257 | case GL_BGRA_EXT: |
| 258 | switch (type) |
| 259 | { |
| 260 | case GL_UNSIGNED_BYTE: |
| 261 | break; |
| 262 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 263 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 264 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 265 | } |
| 266 | break; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 267 | case GL_SRGB_EXT: |
| 268 | case GL_SRGB_ALPHA_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 269 | if (!context->getExtensions().sRGB) |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 270 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 271 | context->recordError(Error(GL_INVALID_ENUM)); |
| 272 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 273 | } |
| 274 | switch (type) |
| 275 | { |
| 276 | case GL_UNSIGNED_BYTE: |
| 277 | break; |
| 278 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 279 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 280 | return false; |
Geoff Lang | 05b0502 | 2014-06-11 15:31:45 -0400 | [diff] [blame] | 281 | } |
| 282 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 283 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: // error cases for compressed textures are handled below |
| 284 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 285 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 286 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
| 287 | break; |
| 288 | case GL_DEPTH_COMPONENT: |
| 289 | switch (type) |
| 290 | { |
| 291 | case GL_UNSIGNED_SHORT: |
| 292 | case GL_UNSIGNED_INT: |
| 293 | break; |
| 294 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 295 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 296 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 297 | } |
| 298 | break; |
| 299 | case GL_DEPTH_STENCIL_OES: |
| 300 | switch (type) |
| 301 | { |
| 302 | case GL_UNSIGNED_INT_24_8_OES: |
| 303 | break; |
| 304 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 305 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 306 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 307 | } |
| 308 | break; |
| 309 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 310 | context->recordError(Error(GL_INVALID_ENUM)); |
| 311 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 312 | } |
| 313 | |
| 314 | switch (format) |
| 315 | { |
| 316 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 317 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 318 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 319 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 320 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 321 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 322 | } |
| 323 | else |
| 324 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 325 | context->recordError(Error(GL_INVALID_ENUM)); |
| 326 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 327 | } |
| 328 | break; |
| 329 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 330 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 331 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 332 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 333 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 334 | } |
| 335 | else |
| 336 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 337 | context->recordError(Error(GL_INVALID_ENUM)); |
| 338 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 339 | } |
| 340 | break; |
| 341 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 342 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 343 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 344 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 345 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 346 | } |
| 347 | else |
| 348 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 349 | context->recordError(Error(GL_INVALID_ENUM)); |
| 350 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 351 | } |
| 352 | break; |
Geoff Lang | 6ea6f94 | 2015-09-11 13:11:22 -0400 | [diff] [blame] | 353 | case GL_ETC1_RGB8_OES: |
| 354 | if (context->getExtensions().compressedETC1RGB8Texture) |
| 355 | { |
| 356 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 357 | return false; |
| 358 | } |
| 359 | else |
| 360 | { |
| 361 | context->recordError(Error(GL_INVALID_ENUM)); |
| 362 | return false; |
| 363 | } |
| 364 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 365 | case GL_DEPTH_COMPONENT: |
| 366 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 367 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 368 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 369 | context->recordError(Error(GL_INVALID_VALUE)); |
| 370 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 371 | } |
| 372 | if (target != GL_TEXTURE_2D) |
| 373 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 374 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 375 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 376 | } |
| 377 | // OES_depth_texture supports loading depth data and multiple levels, |
| 378 | // but ANGLE_depth_texture does not |
| 379 | if (pixels != NULL || level != 0) |
| 380 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 381 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 382 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 383 | } |
| 384 | break; |
| 385 | default: |
| 386 | break; |
| 387 | } |
| 388 | |
| 389 | if (type == GL_FLOAT) |
| 390 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 391 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 392 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 393 | context->recordError(Error(GL_INVALID_ENUM)); |
| 394 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 395 | } |
| 396 | } |
| 397 | else if (type == GL_HALF_FLOAT_OES) |
| 398 | { |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 399 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 400 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 401 | context->recordError(Error(GL_INVALID_ENUM)); |
| 402 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 403 | } |
| 404 | } |
| 405 | } |
| 406 | |
| 407 | return true; |
| 408 | } |
| 409 | |
| 410 | |
| 411 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 412 | bool ValidateES2CopyTexImageParameters(Context* context, GLenum target, GLint level, GLenum internalformat, bool isSubImage, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 413 | GLint xoffset, GLint yoffset, GLint x, GLint y, GLsizei width, GLsizei height, |
| 414 | GLint border) |
| 415 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 416 | GLenum textureInternalFormat = GL_NONE; |
Shannon Woods | 4dfed83 | 2014-03-17 20:03:39 -0400 | [diff] [blame] | 417 | |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 418 | if (!ValidateCopyTexImageParametersBase(context, target, level, internalformat, isSubImage, |
| 419 | xoffset, yoffset, 0, x, y, width, height, border, &textureInternalFormat)) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 420 | { |
Jamie Madill | 560a8d8 | 2014-05-21 13:06:20 -0400 | [diff] [blame] | 421 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 422 | } |
| 423 | |
Shannon Woods | 53a94a8 | 2014-06-24 15:20:36 -0400 | [diff] [blame] | 424 | gl::Framebuffer *framebuffer = context->getState().getReadFramebuffer(); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 425 | GLenum colorbufferFormat = framebuffer->getReadColorbuffer()->getInternalFormat(); |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 426 | const auto &internalFormatInfo = gl::GetInternalFormatInfo(textureInternalFormat); |
| 427 | GLenum textureFormat = internalFormatInfo.format; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 428 | |
| 429 | // [OpenGL ES 2.0.24] table 3.9 |
| 430 | if (isSubImage) |
| 431 | { |
| 432 | switch (textureFormat) |
| 433 | { |
| 434 | case GL_ALPHA: |
| 435 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 436 | colorbufferFormat != GL_RGBA4 && |
| 437 | colorbufferFormat != GL_RGB5_A1 && |
| 438 | colorbufferFormat != GL_RGBA8_OES) |
| 439 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 440 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 441 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 442 | } |
| 443 | break; |
| 444 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 445 | if (colorbufferFormat != GL_R8_EXT && |
| 446 | colorbufferFormat != GL_RG8_EXT && |
| 447 | colorbufferFormat != GL_RGB565 && |
| 448 | colorbufferFormat != GL_RGB8_OES && |
| 449 | colorbufferFormat != GL_RGBA4 && |
| 450 | colorbufferFormat != GL_RGB5_A1 && |
| 451 | colorbufferFormat != GL_RGBA8_OES) |
| 452 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 453 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 454 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 455 | } |
| 456 | break; |
| 457 | case GL_RED_EXT: |
| 458 | if (colorbufferFormat != GL_R8_EXT && |
| 459 | colorbufferFormat != GL_RG8_EXT && |
| 460 | colorbufferFormat != GL_RGB565 && |
| 461 | colorbufferFormat != GL_RGB8_OES && |
| 462 | colorbufferFormat != GL_RGBA4 && |
| 463 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 464 | colorbufferFormat != GL_RGBA8_OES && |
| 465 | colorbufferFormat != GL_R32F && |
| 466 | colorbufferFormat != GL_RG32F && |
| 467 | colorbufferFormat != GL_RGB32F && |
| 468 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 469 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 470 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 471 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 472 | } |
| 473 | break; |
| 474 | case GL_RG_EXT: |
| 475 | if (colorbufferFormat != GL_RG8_EXT && |
| 476 | colorbufferFormat != GL_RGB565 && |
| 477 | colorbufferFormat != GL_RGB8_OES && |
| 478 | colorbufferFormat != GL_RGBA4 && |
| 479 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 480 | colorbufferFormat != GL_RGBA8_OES && |
| 481 | colorbufferFormat != GL_RG32F && |
| 482 | colorbufferFormat != GL_RGB32F && |
| 483 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 484 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 485 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 486 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 487 | } |
| 488 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 489 | case GL_RGB: |
| 490 | if (colorbufferFormat != GL_RGB565 && |
| 491 | colorbufferFormat != GL_RGB8_OES && |
| 492 | colorbufferFormat != GL_RGBA4 && |
| 493 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 494 | colorbufferFormat != GL_RGBA8_OES && |
| 495 | colorbufferFormat != GL_RGB32F && |
| 496 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 497 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 498 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 499 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 500 | } |
| 501 | break; |
| 502 | case GL_LUMINANCE_ALPHA: |
| 503 | case GL_RGBA: |
| 504 | if (colorbufferFormat != GL_RGBA4 && |
| 505 | colorbufferFormat != GL_RGB5_A1 && |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 506 | colorbufferFormat != GL_RGBA8_OES && |
| 507 | colorbufferFormat != GL_RGBA32F) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 508 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 509 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 510 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 511 | } |
| 512 | break; |
| 513 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 514 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
| 515 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
| 516 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | 6ea6f94 | 2015-09-11 13:11:22 -0400 | [diff] [blame] | 517 | case GL_ETC1_RGB8_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 518 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 519 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 520 | case GL_DEPTH_COMPONENT: |
| 521 | case GL_DEPTH_STENCIL_OES: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 522 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 523 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 524 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 525 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 526 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 527 | } |
Jamie Madill | bc393df | 2015-01-29 13:46:07 -0500 | [diff] [blame] | 528 | |
| 529 | if (internalFormatInfo.type == GL_FLOAT && |
| 530 | !context->getExtensions().textureFloat) |
| 531 | { |
| 532 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 533 | return false; |
| 534 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 535 | } |
| 536 | else |
| 537 | { |
| 538 | switch (internalformat) |
| 539 | { |
| 540 | case GL_ALPHA: |
| 541 | if (colorbufferFormat != GL_ALPHA8_EXT && |
| 542 | colorbufferFormat != GL_RGBA4 && |
| 543 | colorbufferFormat != GL_RGB5_A1 && |
| 544 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 545 | colorbufferFormat != GL_RGBA8_OES && |
| 546 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 547 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 548 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 549 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 550 | } |
| 551 | break; |
| 552 | case GL_LUMINANCE: |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 553 | if (colorbufferFormat != GL_R8_EXT && |
| 554 | colorbufferFormat != GL_RG8_EXT && |
| 555 | colorbufferFormat != GL_RGB565 && |
| 556 | colorbufferFormat != GL_RGB8_OES && |
| 557 | colorbufferFormat != GL_RGBA4 && |
| 558 | colorbufferFormat != GL_RGB5_A1 && |
| 559 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 560 | colorbufferFormat != GL_RGBA8_OES && |
| 561 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 562 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 563 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 564 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 565 | } |
| 566 | break; |
| 567 | case GL_RED_EXT: |
| 568 | if (colorbufferFormat != GL_R8_EXT && |
| 569 | colorbufferFormat != GL_RG8_EXT && |
| 570 | colorbufferFormat != GL_RGB565 && |
| 571 | colorbufferFormat != GL_RGB8_OES && |
| 572 | colorbufferFormat != GL_RGBA4 && |
| 573 | colorbufferFormat != GL_RGB5_A1 && |
| 574 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 575 | colorbufferFormat != GL_RGBA8_OES && |
| 576 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 577 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 578 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 579 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 580 | } |
| 581 | break; |
| 582 | case GL_RG_EXT: |
| 583 | if (colorbufferFormat != GL_RG8_EXT && |
| 584 | colorbufferFormat != GL_RGB565 && |
| 585 | colorbufferFormat != GL_RGB8_OES && |
| 586 | colorbufferFormat != GL_RGBA4 && |
| 587 | colorbufferFormat != GL_RGB5_A1 && |
| 588 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 589 | colorbufferFormat != GL_RGBA8_OES && |
| 590 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 591 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 592 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 593 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 594 | } |
| 595 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 596 | case GL_RGB: |
| 597 | if (colorbufferFormat != GL_RGB565 && |
| 598 | colorbufferFormat != GL_RGB8_OES && |
| 599 | colorbufferFormat != GL_RGBA4 && |
| 600 | colorbufferFormat != GL_RGB5_A1 && |
| 601 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 602 | colorbufferFormat != GL_RGBA8_OES && |
| 603 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 604 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 605 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 606 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 607 | } |
| 608 | break; |
| 609 | case GL_LUMINANCE_ALPHA: |
| 610 | case GL_RGBA: |
| 611 | if (colorbufferFormat != GL_RGBA4 && |
| 612 | colorbufferFormat != GL_RGB5_A1 && |
| 613 | colorbufferFormat != GL_BGRA8_EXT && |
Jamie Madill | 054369e | 2015-01-07 10:57:08 -0500 | [diff] [blame] | 614 | colorbufferFormat != GL_RGBA8_OES && |
| 615 | colorbufferFormat != GL_BGR5_A1_ANGLEX) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 616 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 617 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 618 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 619 | } |
| 620 | break; |
| 621 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 622 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 623 | if (context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 624 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 625 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 626 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 627 | } |
| 628 | else |
| 629 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 630 | context->recordError(Error(GL_INVALID_ENUM)); |
| 631 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 632 | } |
| 633 | break; |
| 634 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 635 | if (context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 636 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 637 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 638 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 639 | } |
| 640 | else |
| 641 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 642 | context->recordError(Error(GL_INVALID_ENUM)); |
| 643 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 644 | } |
| 645 | break; |
| 646 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 647 | if (context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 648 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 649 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 650 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 651 | } |
| 652 | else |
| 653 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 654 | context->recordError(Error(GL_INVALID_ENUM)); |
| 655 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 656 | } |
| 657 | break; |
Geoff Lang | 6ea6f94 | 2015-09-11 13:11:22 -0400 | [diff] [blame] | 658 | case GL_ETC1_RGB8_OES: |
| 659 | if (context->getExtensions().compressedETC1RGB8Texture) |
| 660 | { |
| 661 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 662 | return false; |
| 663 | } |
| 664 | else |
| 665 | { |
| 666 | context->recordError(Error(GL_INVALID_ENUM)); |
| 667 | return false; |
| 668 | } |
| 669 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 670 | case GL_DEPTH_COMPONENT: |
| 671 | case GL_DEPTH_COMPONENT16: |
| 672 | case GL_DEPTH_COMPONENT32_OES: |
| 673 | case GL_DEPTH_STENCIL_OES: |
| 674 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 675 | if (context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 676 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 677 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 678 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 679 | } |
| 680 | else |
| 681 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 682 | context->recordError(Error(GL_INVALID_ENUM)); |
| 683 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 684 | } |
| 685 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 686 | context->recordError(Error(GL_INVALID_ENUM)); |
| 687 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 688 | } |
| 689 | } |
| 690 | |
Geoff Lang | 784a8fd | 2013-09-24 12:33:16 -0400 | [diff] [blame] | 691 | // If width or height is zero, it is a no-op. Return false without setting an error. |
| 692 | return (width > 0 && height > 0); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 693 | } |
| 694 | |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 695 | bool ValidateES2TexStorageParameters(Context *context, GLenum target, GLsizei levels, GLenum internalformat, |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 696 | GLsizei width, GLsizei height) |
| 697 | { |
| 698 | if (target != GL_TEXTURE_2D && target != GL_TEXTURE_CUBE_MAP) |
| 699 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 700 | context->recordError(Error(GL_INVALID_ENUM)); |
| 701 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 702 | } |
| 703 | |
| 704 | if (width < 1 || height < 1 || levels < 1) |
| 705 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 706 | context->recordError(Error(GL_INVALID_VALUE)); |
| 707 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 708 | } |
| 709 | |
| 710 | if (target == GL_TEXTURE_CUBE_MAP && width != height) |
| 711 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 712 | context->recordError(Error(GL_INVALID_VALUE)); |
| 713 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 714 | } |
| 715 | |
| 716 | if (levels != 1 && levels != gl::log2(std::max(width, height)) + 1) |
| 717 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 718 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 719 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 720 | } |
| 721 | |
Geoff Lang | 5d60138 | 2014-07-22 15:14:06 -0400 | [diff] [blame] | 722 | const gl::InternalFormat &formatInfo = gl::GetInternalFormatInfo(internalformat); |
| 723 | if (formatInfo.format == GL_NONE || formatInfo.type == GL_NONE) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 724 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 725 | context->recordError(Error(GL_INVALID_ENUM)); |
| 726 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 727 | } |
| 728 | |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 729 | const gl::Caps &caps = context->getCaps(); |
| 730 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 731 | switch (target) |
| 732 | { |
| 733 | case GL_TEXTURE_2D: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 734 | if (static_cast<GLuint>(width) > caps.max2DTextureSize || |
| 735 | static_cast<GLuint>(height) > caps.max2DTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 736 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 737 | context->recordError(Error(GL_INVALID_VALUE)); |
| 738 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 739 | } |
| 740 | break; |
| 741 | case GL_TEXTURE_CUBE_MAP: |
Geoff Lang | aae65a4 | 2014-05-26 12:43:44 -0400 | [diff] [blame] | 742 | if (static_cast<GLuint>(width) > caps.maxCubeMapTextureSize || |
| 743 | static_cast<GLuint>(height) > caps.maxCubeMapTextureSize) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 744 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 745 | context->recordError(Error(GL_INVALID_VALUE)); |
| 746 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 747 | } |
| 748 | break; |
| 749 | default: |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 750 | context->recordError(Error(GL_INVALID_ENUM)); |
| 751 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 752 | } |
| 753 | |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 754 | if (levels != 1 && !context->getExtensions().textureNPOT) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 755 | { |
| 756 | if (!gl::isPow2(width) || !gl::isPow2(height)) |
| 757 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 758 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 759 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 760 | } |
| 761 | } |
| 762 | |
| 763 | switch (internalformat) |
| 764 | { |
| 765 | case GL_COMPRESSED_RGB_S3TC_DXT1_EXT: |
| 766 | case GL_COMPRESSED_RGBA_S3TC_DXT1_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 767 | if (!context->getExtensions().textureCompressionDXT1) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 768 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 769 | context->recordError(Error(GL_INVALID_ENUM)); |
| 770 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 771 | } |
| 772 | break; |
| 773 | case GL_COMPRESSED_RGBA_S3TC_DXT3_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 774 | if (!context->getExtensions().textureCompressionDXT3) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 775 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 776 | context->recordError(Error(GL_INVALID_ENUM)); |
| 777 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 778 | } |
| 779 | break; |
| 780 | case GL_COMPRESSED_RGBA_S3TC_DXT5_ANGLE: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 781 | if (!context->getExtensions().textureCompressionDXT5) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 782 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 783 | context->recordError(Error(GL_INVALID_ENUM)); |
| 784 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 785 | } |
| 786 | break; |
Geoff Lang | 6ea6f94 | 2015-09-11 13:11:22 -0400 | [diff] [blame] | 787 | case GL_ETC1_RGB8_OES: |
| 788 | if (!context->getExtensions().compressedETC1RGB8Texture) |
| 789 | { |
| 790 | context->recordError(Error(GL_INVALID_ENUM)); |
| 791 | return false; |
| 792 | } |
| 793 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 794 | case GL_RGBA32F_EXT: |
| 795 | case GL_RGB32F_EXT: |
| 796 | case GL_ALPHA32F_EXT: |
| 797 | case GL_LUMINANCE32F_EXT: |
| 798 | case GL_LUMINANCE_ALPHA32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 799 | if (!context->getExtensions().textureFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 800 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 801 | context->recordError(Error(GL_INVALID_ENUM)); |
| 802 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 803 | } |
| 804 | break; |
| 805 | case GL_RGBA16F_EXT: |
| 806 | case GL_RGB16F_EXT: |
| 807 | case GL_ALPHA16F_EXT: |
| 808 | case GL_LUMINANCE16F_EXT: |
| 809 | case GL_LUMINANCE_ALPHA16F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 810 | if (!context->getExtensions().textureHalfFloat) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 811 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 812 | context->recordError(Error(GL_INVALID_ENUM)); |
| 813 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 814 | } |
| 815 | break; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 816 | case GL_R8_EXT: |
| 817 | case GL_RG8_EXT: |
| 818 | case GL_R16F_EXT: |
| 819 | case GL_RG16F_EXT: |
| 820 | case GL_R32F_EXT: |
| 821 | case GL_RG32F_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 822 | if (!context->getExtensions().textureRG) |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 823 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 824 | context->recordError(Error(GL_INVALID_ENUM)); |
| 825 | return false; |
Geoff Lang | 632192d | 2013-10-04 13:40:46 -0400 | [diff] [blame] | 826 | } |
| 827 | break; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 828 | case GL_DEPTH_COMPONENT16: |
| 829 | case GL_DEPTH_COMPONENT32_OES: |
| 830 | case GL_DEPTH24_STENCIL8_OES: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 831 | if (!context->getExtensions().depthTextures) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 832 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 833 | context->recordError(Error(GL_INVALID_ENUM)); |
| 834 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 835 | } |
| 836 | if (target != GL_TEXTURE_2D) |
| 837 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 838 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 839 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 840 | } |
| 841 | // ANGLE_depth_texture only supports 1-level textures |
| 842 | if (levels != 1) |
| 843 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 844 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 845 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 846 | } |
| 847 | break; |
| 848 | default: |
| 849 | break; |
| 850 | } |
| 851 | |
Geoff Lang | 691e58c | 2014-12-19 17:03:25 -0500 | [diff] [blame] | 852 | gl::Texture *texture = context->getTargetTexture(target); |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 853 | if (!texture || texture->id() == 0) |
| 854 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 855 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 856 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 857 | } |
| 858 | |
Geoff Lang | 69cce58 | 2015-09-17 13:20:36 -0400 | [diff] [blame] | 859 | if (texture->getImmutableFormat()) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 860 | { |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 861 | context->recordError(Error(GL_INVALID_OPERATION)); |
| 862 | return false; |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 863 | } |
| 864 | |
| 865 | return true; |
| 866 | } |
| 867 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 868 | // check for combinations of format and type that are valid for ReadPixels |
Geoff Lang | b119668 | 2014-07-23 13:47:29 -0400 | [diff] [blame] | 869 | bool ValidES2ReadFormatType(Context *context, GLenum format, GLenum type) |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 870 | { |
| 871 | switch (format) |
| 872 | { |
| 873 | case GL_RGBA: |
| 874 | switch (type) |
| 875 | { |
| 876 | case GL_UNSIGNED_BYTE: |
| 877 | break; |
| 878 | default: |
| 879 | return false; |
| 880 | } |
| 881 | break; |
| 882 | case GL_BGRA_EXT: |
| 883 | switch (type) |
| 884 | { |
| 885 | case GL_UNSIGNED_BYTE: |
| 886 | case GL_UNSIGNED_SHORT_4_4_4_4_REV_EXT: |
| 887 | case GL_UNSIGNED_SHORT_1_5_5_5_REV_EXT: |
| 888 | break; |
| 889 | default: |
| 890 | return false; |
| 891 | } |
| 892 | break; |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 893 | case GL_RG_EXT: |
| 894 | case GL_RED_EXT: |
Geoff Lang | c0b9ef4 | 2014-07-02 10:02:37 -0400 | [diff] [blame] | 895 | if (!context->getExtensions().textureRG) |
Geoff Lang | bdc9b2f | 2014-04-16 14:41:54 -0400 | [diff] [blame] | 896 | { |
| 897 | return false; |
| 898 | } |
| 899 | switch (type) |
| 900 | { |
| 901 | case GL_UNSIGNED_BYTE: |
| 902 | break; |
| 903 | default: |
| 904 | return false; |
| 905 | } |
| 906 | break; |
| 907 | |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 908 | default: |
| 909 | return false; |
| 910 | } |
| 911 | return true; |
| 912 | } |
| 913 | |
Austin Kinross | 0833263 | 2015-05-05 13:35:47 -0700 | [diff] [blame] | 914 | bool ValidateDiscardFramebufferEXT(Context *context, GLenum target, GLsizei numAttachments, |
| 915 | const GLenum *attachments) |
| 916 | { |
| 917 | bool defaultFramebuffer = false; |
| 918 | |
| 919 | switch (target) |
| 920 | { |
| 921 | case GL_FRAMEBUFFER: |
| 922 | defaultFramebuffer = (context->getState().getTargetFramebuffer(GL_FRAMEBUFFER)->id() == 0); |
| 923 | break; |
| 924 | default: |
| 925 | context->recordError(Error(GL_INVALID_ENUM, "Invalid framebuffer target")); |
| 926 | return false; |
| 927 | } |
| 928 | |
| 929 | return ValidateDiscardFramebufferBase(context, target, numAttachments, attachments, defaultFramebuffer); |
| 930 | } |
| 931 | |
Dian Xiang | bf18ed0 | 2015-09-11 10:50:04 -0700 | [diff] [blame] | 932 | bool ValidateDrawBuffers(Context *context, GLsizei n, const GLenum *bufs) |
| 933 | { |
| 934 | // INVALID_VALUE is generated if n is negative or greater than value of MAX_DRAW_BUFFERS |
| 935 | if (n < 0 || static_cast<GLuint>(n) > context->getCaps().maxDrawBuffers) |
| 936 | { |
| 937 | context->recordError( |
| 938 | Error(GL_INVALID_VALUE, "n must be non-negative and no greater than MAX_DRAW_BUFFERS")); |
| 939 | return false; |
| 940 | } |
| 941 | |
| 942 | ASSERT(context->getState().getDrawFramebuffer()); |
| 943 | GLuint frameBufferId = context->getState().getDrawFramebuffer()->id(); |
| 944 | GLuint maxColorAttachment = GL_COLOR_ATTACHMENT0_EXT + context->getCaps().maxColorAttachments; |
| 945 | |
| 946 | // This should come first before the check for the default frame buffer |
| 947 | // because when we switch to ES3.1+, invalid enums will return INVALID_ENUM |
| 948 | // rather than INVALID_OPERATION |
| 949 | for (int colorAttachment = 0; colorAttachment < n; colorAttachment++) |
| 950 | { |
| 951 | const GLenum attachment = GL_COLOR_ATTACHMENT0_EXT + colorAttachment; |
| 952 | |
| 953 | if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != GL_BACK && |
| 954 | (bufs[colorAttachment] < GL_COLOR_ATTACHMENT0_EXT || |
| 955 | bufs[colorAttachment] >= maxColorAttachment)) |
| 956 | { |
| 957 | // Value in bufs is not NONE, BACK, or GL_COLOR_ATTACHMENTi |
| 958 | // In the 3.0 specs, the error should return GL_INVALID_OPERATION. |
| 959 | // When we move to 3.1 specs, we should change the error to be GL_INVALID_ENUM |
| 960 | context->recordError(Error(GL_INVALID_OPERATION, "Invalid buffer value")); |
| 961 | return false; |
| 962 | } |
| 963 | else if (bufs[colorAttachment] != GL_NONE && bufs[colorAttachment] != attachment && |
| 964 | frameBufferId != 0) |
| 965 | { |
| 966 | // INVALID_OPERATION-GL is bound to buffer and ith argument |
| 967 | // is not COLOR_ATTACHMENTi or NONE |
| 968 | context->recordError( |
| 969 | Error(GL_INVALID_OPERATION, "Ith value does not match COLOR_ATTACHMENTi or NONE")); |
| 970 | return false; |
| 971 | } |
| 972 | } |
| 973 | |
| 974 | // INVALID_OPERATION is generated if GL is bound to the default framebuffer |
| 975 | // and n is not 1 or bufs is bound to value other than BACK and NONE |
| 976 | if (frameBufferId == 0) |
| 977 | { |
| 978 | if (n != 1) |
| 979 | { |
| 980 | context->recordError(Error(GL_INVALID_OPERATION, |
| 981 | "n must be 1 when GL is bound to the default framebuffer")); |
| 982 | return false; |
| 983 | } |
| 984 | |
| 985 | if (bufs[0] != GL_NONE && bufs[0] != GL_BACK) |
| 986 | { |
| 987 | context->recordError(Error( |
| 988 | GL_INVALID_OPERATION, |
| 989 | "Only NONE or BACK are valid values when drawing to the default framebuffer")); |
| 990 | return false; |
| 991 | } |
| 992 | } |
| 993 | |
| 994 | return true; |
| 995 | } |
Austin Kinross | bc781f3 | 2015-10-26 09:27:38 -0700 | [diff] [blame] | 996 | |
| 997 | bool ValidateBindVertexArrayOES(Context *context, GLuint array) |
| 998 | { |
| 999 | if (!context->getExtensions().vertexArrayObject) |
| 1000 | { |
| 1001 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1002 | return false; |
| 1003 | } |
| 1004 | |
| 1005 | return ValidateBindVertexArrayBase(context, array); |
| 1006 | } |
| 1007 | |
| 1008 | bool ValidateDeleteVertexArraysOES(Context *context, GLsizei n) |
| 1009 | { |
| 1010 | if (!context->getExtensions().vertexArrayObject) |
| 1011 | { |
| 1012 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1013 | return false; |
| 1014 | } |
| 1015 | |
| 1016 | return ValidateDeleteVertexArraysBase(context, n); |
| 1017 | } |
| 1018 | |
| 1019 | bool ValidateGenVertexArraysOES(Context *context, GLsizei n) |
| 1020 | { |
| 1021 | if (!context->getExtensions().vertexArrayObject) |
| 1022 | { |
| 1023 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1024 | return false; |
| 1025 | } |
| 1026 | |
| 1027 | return ValidateGenVertexArraysBase(context, n); |
| 1028 | } |
| 1029 | |
| 1030 | bool ValidateIsVertexArrayOES(Context *context) |
| 1031 | { |
| 1032 | if (!context->getExtensions().vertexArrayObject) |
| 1033 | { |
| 1034 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1035 | return false; |
| 1036 | } |
| 1037 | |
| 1038 | return true; |
| 1039 | } |
Geoff Lang | c562975 | 2015-12-07 16:29:04 -0500 | [diff] [blame^] | 1040 | |
| 1041 | bool ValidateProgramBinaryOES(Context *context, |
| 1042 | GLuint program, |
| 1043 | GLenum binaryFormat, |
| 1044 | const void *binary, |
| 1045 | GLint length) |
| 1046 | { |
| 1047 | if (!context->getExtensions().getProgramBinary) |
| 1048 | { |
| 1049 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1050 | return false; |
| 1051 | } |
| 1052 | |
| 1053 | return ValidateProgramBinaryBase(context, program, binaryFormat, binary, length); |
| 1054 | } |
| 1055 | |
| 1056 | bool ValidateGetProgramBinaryOES(Context *context, |
| 1057 | GLuint program, |
| 1058 | GLsizei bufSize, |
| 1059 | GLsizei *length, |
| 1060 | GLenum *binaryFormat, |
| 1061 | void *binary) |
| 1062 | { |
| 1063 | if (!context->getExtensions().getProgramBinary) |
| 1064 | { |
| 1065 | context->recordError(Error(GL_INVALID_OPERATION, "Extension not enabled")); |
| 1066 | return false; |
| 1067 | } |
| 1068 | |
| 1069 | return ValidateGetProgramBinaryBase(context, program, bufSize, length, binaryFormat, binary); |
| 1070 | } |
Geoff Lang | e8ebe7f | 2013-08-05 15:03:13 -0400 | [diff] [blame] | 1071 | } |