daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 12 | #include "common/mathutil.h" |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 13 | #include "compiler/preprocessor/SourceLocation.h" |
Dmitry Skiba | 0197111 | 2015-07-10 14:54:00 -0400 | [diff] [blame] | 14 | #include "compiler/translator/Cache.h" |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 15 | #include "compiler/translator/IntermNode_util.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 16 | #include "compiler/translator/ValidateGlobalInitializer.h" |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 17 | #include "compiler/translator/ValidateSwitch.h" |
| 18 | #include "compiler/translator/glslang.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 19 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 20 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 21 | namespace sh |
| 22 | { |
| 23 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 24 | /////////////////////////////////////////////////////////////////////// |
| 25 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 26 | // Sub- vector and matrix fields |
| 27 | // |
| 28 | //////////////////////////////////////////////////////////////////////// |
| 29 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 30 | namespace |
| 31 | { |
| 32 | |
| 33 | const int kWebGLMaxStructNesting = 4; |
| 34 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 35 | bool ContainsSampler(const TStructure *structType); |
| 36 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 37 | bool ContainsSampler(const TType &type) |
| 38 | { |
| 39 | if (IsSampler(type.getBasicType())) |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 40 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 41 | return true; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 42 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 43 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 44 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 45 | return ContainsSampler(type.getStruct()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 46 | } |
| 47 | |
| 48 | return false; |
| 49 | } |
| 50 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 51 | bool ContainsSampler(const TStructure *structType) |
| 52 | { |
| 53 | for (const auto &field : structType->fields()) |
| 54 | { |
| 55 | if (ContainsSampler(*field->type())) |
| 56 | return true; |
| 57 | } |
| 58 | return false; |
| 59 | } |
| 60 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 61 | // Get a token from an image argument to use as an error message token. |
| 62 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 63 | { |
| 64 | ASSERT(IsImage(imageNode->getBasicType())); |
| 65 | while (imageNode->getAsBinaryNode() && |
| 66 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 67 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 68 | { |
| 69 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 70 | } |
| 71 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 72 | if (imageSymbol) |
| 73 | { |
| 74 | return imageSymbol->getSymbol().c_str(); |
| 75 | } |
| 76 | return "image"; |
| 77 | } |
| 78 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 79 | bool CanSetDefaultPrecisionOnType(const TPublicType &type) |
| 80 | { |
| 81 | if (!SupportsPrecision(type.getBasicType())) |
| 82 | { |
| 83 | return false; |
| 84 | } |
| 85 | if (type.getBasicType() == EbtUInt) |
| 86 | { |
| 87 | // ESSL 3.00.4 section 4.5.4 |
| 88 | return false; |
| 89 | } |
| 90 | if (type.isAggregate()) |
| 91 | { |
| 92 | // Not allowed to set for aggregate types |
| 93 | return false; |
| 94 | } |
| 95 | return true; |
| 96 | } |
| 97 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 98 | // Map input primitive types to input array sizes in a geometry shader. |
| 99 | GLuint GetGeometryShaderInputArraySize(TLayoutPrimitiveType primitiveType) |
| 100 | { |
| 101 | switch (primitiveType) |
| 102 | { |
| 103 | case EptPoints: |
| 104 | return 1u; |
| 105 | case EptLines: |
| 106 | return 2u; |
| 107 | case EptTriangles: |
| 108 | return 3u; |
| 109 | case EptLinesAdjacency: |
| 110 | return 4u; |
| 111 | case EptTrianglesAdjacency: |
| 112 | return 6u; |
| 113 | default: |
| 114 | UNREACHABLE(); |
| 115 | return 0u; |
| 116 | } |
| 117 | } |
| 118 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 119 | } // namespace |
| 120 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 121 | // This tracks each binding point's current default offset for inheritance of subsequent |
| 122 | // variables using the same binding, and keeps offsets unique and non overlapping. |
| 123 | // See GLSL ES 3.1, section 4.4.6. |
| 124 | class TParseContext::AtomicCounterBindingState |
| 125 | { |
| 126 | public: |
| 127 | AtomicCounterBindingState() : mDefaultOffset(0) {} |
| 128 | // Inserts a new span and returns -1 if overlapping, else returns the starting offset of |
| 129 | // newly inserted span. |
| 130 | int insertSpan(int start, size_t length) |
| 131 | { |
| 132 | gl::RangeI newSpan(start, start + static_cast<int>(length)); |
| 133 | for (const auto &span : mSpans) |
| 134 | { |
| 135 | if (newSpan.intersects(span)) |
| 136 | { |
| 137 | return -1; |
| 138 | } |
| 139 | } |
| 140 | mSpans.push_back(newSpan); |
| 141 | mDefaultOffset = newSpan.high(); |
| 142 | return start; |
| 143 | } |
| 144 | // Inserts a new span starting from the default offset. |
| 145 | int appendSpan(size_t length) { return insertSpan(mDefaultOffset, length); } |
| 146 | void setDefaultOffset(int offset) { mDefaultOffset = offset; } |
| 147 | |
| 148 | private: |
| 149 | int mDefaultOffset; |
| 150 | std::vector<gl::RangeI> mSpans; |
| 151 | }; |
| 152 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 153 | TParseContext::TParseContext(TSymbolTable &symt, |
| 154 | TExtensionBehavior &ext, |
| 155 | sh::GLenum type, |
| 156 | ShShaderSpec spec, |
| 157 | ShCompileOptions options, |
| 158 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 159 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 160 | const ShBuiltInResources &resources) |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 161 | : symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 162 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 163 | mShaderType(type), |
| 164 | mShaderSpec(spec), |
| 165 | mCompileOptions(options), |
| 166 | mShaderVersion(100), |
| 167 | mTreeRoot(nullptr), |
| 168 | mLoopNestingLevel(0), |
| 169 | mStructNestingLevel(0), |
| 170 | mSwitchNestingLevel(0), |
| 171 | mCurrentFunctionType(nullptr), |
| 172 | mFunctionReturnsValue(false), |
| 173 | mChecksPrecisionErrors(checksPrecErrors), |
| 174 | mFragmentPrecisionHighOnESSL1(false), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 175 | mDefaultUniformMatrixPacking(EmpColumnMajor), |
| 176 | mDefaultUniformBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
| 177 | mDefaultBufferMatrixPacking(EmpColumnMajor), |
| 178 | mDefaultBufferBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 179 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 180 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 181 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 182 | mShaderVersion, |
| 183 | mShaderType, |
| 184 | resources.WEBGL_debug_shader_precision == 1), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 185 | mPreprocessor(mDiagnostics, &mDirectiveHandler, pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 186 | mScanner(nullptr), |
| 187 | mUsesFragData(false), |
| 188 | mUsesFragColor(false), |
| 189 | mUsesSecondaryOutputs(false), |
| 190 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 191 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 192 | mMultiviewAvailable(resources.OVR_multiview == 1), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 193 | mComputeShaderLocalSizeDeclared(false), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 194 | mNumViews(-1), |
| 195 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 196 | mMaxImageUnits(resources.MaxImageUnits), |
| 197 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 198 | mMaxUniformLocations(resources.MaxUniformLocations), |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 199 | mMaxUniformBufferBindings(resources.MaxUniformBufferBindings), |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 200 | mMaxAtomicCounterBindings(resources.MaxAtomicCounterBindings), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 201 | mMaxShaderStorageBufferBindings(resources.MaxShaderStorageBufferBindings), |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 202 | mDeclaringFunction(false), |
| 203 | mGeometryShaderInputPrimitiveType(EptUndefined), |
| 204 | mGeometryShaderOutputPrimitiveType(EptUndefined), |
| 205 | mGeometryShaderInvocations(0), |
| 206 | mGeometryShaderMaxVertices(-1), |
| 207 | mMaxGeometryShaderInvocations(resources.MaxGeometryShaderInvocations), |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 208 | mMaxGeometryShaderMaxVertices(resources.MaxGeometryOutputVertices), |
| 209 | mGeometryShaderInputArraySize(0) |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 210 | { |
| 211 | mComputeShaderLocalSize.fill(-1); |
| 212 | } |
| 213 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 214 | TParseContext::~TParseContext() |
| 215 | { |
| 216 | } |
| 217 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 218 | bool TParseContext::parseVectorFields(const TSourceLoc &line, |
| 219 | const TString &compString, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 220 | int vecSize, |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 221 | TVector<int> *fieldOffsets) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 222 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 223 | ASSERT(fieldOffsets); |
| 224 | size_t fieldCount = compString.size(); |
| 225 | if (fieldCount > 4u) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 226 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 227 | error(line, "illegal vector field selection", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 228 | return false; |
| 229 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 230 | fieldOffsets->resize(fieldCount); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 231 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 232 | enum |
| 233 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 234 | exyzw, |
| 235 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 236 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 237 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 238 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 239 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 240 | { |
| 241 | switch (compString[i]) |
| 242 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 243 | case 'x': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 244 | (*fieldOffsets)[i] = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 245 | fieldSet[i] = exyzw; |
| 246 | break; |
| 247 | case 'r': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 248 | (*fieldOffsets)[i] = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 249 | fieldSet[i] = ergba; |
| 250 | break; |
| 251 | case 's': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 252 | (*fieldOffsets)[i] = 0; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 253 | fieldSet[i] = estpq; |
| 254 | break; |
| 255 | case 'y': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 256 | (*fieldOffsets)[i] = 1; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 257 | fieldSet[i] = exyzw; |
| 258 | break; |
| 259 | case 'g': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 260 | (*fieldOffsets)[i] = 1; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 261 | fieldSet[i] = ergba; |
| 262 | break; |
| 263 | case 't': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 264 | (*fieldOffsets)[i] = 1; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 265 | fieldSet[i] = estpq; |
| 266 | break; |
| 267 | case 'z': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 268 | (*fieldOffsets)[i] = 2; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 269 | fieldSet[i] = exyzw; |
| 270 | break; |
| 271 | case 'b': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 272 | (*fieldOffsets)[i] = 2; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 273 | fieldSet[i] = ergba; |
| 274 | break; |
| 275 | case 'p': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 276 | (*fieldOffsets)[i] = 2; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 277 | fieldSet[i] = estpq; |
| 278 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 279 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 280 | case 'w': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 281 | (*fieldOffsets)[i] = 3; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 282 | fieldSet[i] = exyzw; |
| 283 | break; |
| 284 | case 'a': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 285 | (*fieldOffsets)[i] = 3; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 286 | fieldSet[i] = ergba; |
| 287 | break; |
| 288 | case 'q': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 289 | (*fieldOffsets)[i] = 3; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 290 | fieldSet[i] = estpq; |
| 291 | break; |
| 292 | default: |
| 293 | error(line, "illegal vector field selection", compString.c_str()); |
| 294 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 295 | } |
| 296 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 297 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 298 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 299 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 300 | if ((*fieldOffsets)[i] >= vecSize) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 301 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 302 | error(line, "vector field selection out of range", compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 303 | return false; |
| 304 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 305 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 306 | if (i > 0) |
| 307 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 308 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 309 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 310 | error(line, "illegal - vector component fields not from the same set", |
| 311 | compString.c_str()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 312 | return false; |
| 313 | } |
| 314 | } |
| 315 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 316 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 317 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 318 | } |
| 319 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 320 | /////////////////////////////////////////////////////////////////////// |
| 321 | // |
| 322 | // Errors |
| 323 | // |
| 324 | //////////////////////////////////////////////////////////////////////// |
| 325 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 326 | // |
| 327 | // Used by flex/bison to output all syntax and parsing errors. |
| 328 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 329 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 330 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 331 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 332 | } |
| 333 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 334 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 335 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 336 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 337 | } |
| 338 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 339 | void TParseContext::outOfRangeError(bool isError, |
| 340 | const TSourceLoc &loc, |
| 341 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 342 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 343 | { |
| 344 | if (isError) |
| 345 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 346 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 347 | } |
| 348 | else |
| 349 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 350 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 351 | } |
| 352 | } |
| 353 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 354 | // |
| 355 | // Same error message for all places assignments don't work. |
| 356 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 357 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 358 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 359 | std::stringstream reasonStream; |
| 360 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 361 | std::string reason = reasonStream.str(); |
| 362 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 363 | } |
| 364 | |
| 365 | // |
| 366 | // Same error message for all places unary operations don't work. |
| 367 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 368 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 369 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 370 | std::stringstream reasonStream; |
| 371 | reasonStream << "wrong operand type - no operation '" << op |
| 372 | << "' exists that takes an operand of type " << operand |
| 373 | << " (or there is no acceptable conversion)"; |
| 374 | std::string reason = reasonStream.str(); |
| 375 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 376 | } |
| 377 | |
| 378 | // |
| 379 | // Same error message for all binary operations don't work. |
| 380 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 381 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 382 | const char *op, |
| 383 | TString left, |
| 384 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 385 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 386 | std::stringstream reasonStream; |
| 387 | reasonStream << "wrong operand types - no operation '" << op |
| 388 | << "' exists that takes a left-hand operand of type '" << left |
| 389 | << "' and a right operand of type '" << right |
| 390 | << "' (or there is no acceptable conversion)"; |
| 391 | std::string reason = reasonStream.str(); |
| 392 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 393 | } |
| 394 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 395 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 396 | TPrecision precision, |
| 397 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 398 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 399 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 400 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 401 | |
| 402 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 403 | { |
| 404 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 405 | } |
| 406 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 407 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 408 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 409 | switch (type) |
| 410 | { |
| 411 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 412 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 413 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 414 | case EbtInt: |
| 415 | case EbtUInt: |
| 416 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 417 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 418 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 419 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 420 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 421 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 422 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 423 | return; |
| 424 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 425 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 426 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 427 | } |
| 428 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 429 | // Both test and if necessary, spit out an error, to see if the node is really |
| 430 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 431 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 432 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 433 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 434 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 435 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 436 | |
| 437 | if (swizzleNode) |
| 438 | { |
| 439 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 440 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 441 | { |
| 442 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 443 | return false; |
| 444 | } |
| 445 | return ok; |
| 446 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 447 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 448 | if (binaryNode) |
| 449 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 450 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 451 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 452 | case EOpIndexDirect: |
| 453 | case EOpIndexIndirect: |
| 454 | case EOpIndexDirectStruct: |
| 455 | case EOpIndexDirectInterfaceBlock: |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 456 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 457 | default: |
| 458 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 459 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 460 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 461 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 462 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 463 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 464 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 465 | switch (node->getQualifier()) |
| 466 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 467 | case EvqConst: |
| 468 | message = "can't modify a const"; |
| 469 | break; |
| 470 | case EvqConstReadOnly: |
| 471 | message = "can't modify a const"; |
| 472 | break; |
| 473 | case EvqAttribute: |
| 474 | message = "can't modify an attribute"; |
| 475 | break; |
| 476 | case EvqFragmentIn: |
| 477 | message = "can't modify an input"; |
| 478 | break; |
| 479 | case EvqVertexIn: |
| 480 | message = "can't modify an input"; |
| 481 | break; |
| 482 | case EvqUniform: |
| 483 | message = "can't modify a uniform"; |
| 484 | break; |
| 485 | case EvqVaryingIn: |
| 486 | message = "can't modify a varying"; |
| 487 | break; |
| 488 | case EvqFragCoord: |
| 489 | message = "can't modify gl_FragCoord"; |
| 490 | break; |
| 491 | case EvqFrontFacing: |
| 492 | message = "can't modify gl_FrontFacing"; |
| 493 | break; |
| 494 | case EvqPointCoord: |
| 495 | message = "can't modify gl_PointCoord"; |
| 496 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 497 | case EvqNumWorkGroups: |
| 498 | message = "can't modify gl_NumWorkGroups"; |
| 499 | break; |
| 500 | case EvqWorkGroupSize: |
| 501 | message = "can't modify gl_WorkGroupSize"; |
| 502 | break; |
| 503 | case EvqWorkGroupID: |
| 504 | message = "can't modify gl_WorkGroupID"; |
| 505 | break; |
| 506 | case EvqLocalInvocationID: |
| 507 | message = "can't modify gl_LocalInvocationID"; |
| 508 | break; |
| 509 | case EvqGlobalInvocationID: |
| 510 | message = "can't modify gl_GlobalInvocationID"; |
| 511 | break; |
| 512 | case EvqLocalInvocationIndex: |
| 513 | message = "can't modify gl_LocalInvocationIndex"; |
| 514 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 515 | case EvqViewIDOVR: |
| 516 | message = "can't modify gl_ViewID_OVR"; |
| 517 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 518 | case EvqComputeIn: |
| 519 | message = "can't modify work group size variable"; |
| 520 | break; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 521 | case EvqPerVertexIn: |
| 522 | message = "can't modify any member in gl_in"; |
| 523 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 524 | default: |
| 525 | // |
| 526 | // Type that can't be written to? |
| 527 | // |
| 528 | if (node->getBasicType() == EbtVoid) |
| 529 | { |
| 530 | message = "can't modify void"; |
| 531 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 532 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 533 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 534 | message = "can't modify a variable with type "; |
| 535 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 536 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 537 | else if (node->getMemoryQualifier().readonly) |
| 538 | { |
| 539 | message = "can't modify a readonly variable"; |
| 540 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 541 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 542 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 543 | if (message.empty() && binaryNode == 0 && symNode == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 544 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 545 | error(line, "l-value required", op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 546 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 547 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 548 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 549 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 550 | // |
| 551 | // Everything else is okay, no error. |
| 552 | // |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 553 | if (message.empty()) |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 554 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 555 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 556 | // |
| 557 | // If we get here, we have an error and a message. |
| 558 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 559 | if (symNode) |
| 560 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 561 | const char *symbol = symNode->getSymbol().c_str(); |
| 562 | std::stringstream reasonStream; |
| 563 | reasonStream << "l-value required (" << message << " \"" << symbol << "\")"; |
| 564 | std::string reason = reasonStream.str(); |
| 565 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 566 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 567 | else |
| 568 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 569 | std::stringstream reasonStream; |
| 570 | reasonStream << "l-value required (" << message << ")"; |
| 571 | std::string reason = reasonStream.str(); |
| 572 | error(line, reason.c_str(), op); |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 573 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 574 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 575 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 576 | } |
| 577 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 578 | // Both test, and if necessary spit out an error, to see if the node is really |
| 579 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 580 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 581 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 582 | if (node->getQualifier() != EvqConst) |
| 583 | { |
| 584 | error(node->getLine(), "constant expression required", ""); |
| 585 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 586 | } |
| 587 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 588 | // Both test, and if necessary spit out an error, to see if the node is really |
| 589 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 590 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 591 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 592 | if (!node->isScalarInt()) |
| 593 | { |
| 594 | error(node->getLine(), "integer expression required", token); |
| 595 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 596 | } |
| 597 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 598 | // Both test, and if necessary spit out an error, to see if we are currently |
| 599 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 600 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 601 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 602 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 603 | { |
| 604 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 605 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 606 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 607 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 608 | } |
| 609 | |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 610 | // ESSL 3.00.5 sections 3.8 and 3.9. |
| 611 | // If it starts "gl_" or contains two consecutive underscores, it's reserved. |
| 612 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a webgl shader. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 613 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const TString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 614 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 615 | static const char *reservedErrMsg = "reserved built-in name"; |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 616 | if (identifier.compare(0, 3, "gl_") == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 617 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 618 | error(line, reservedErrMsg, "gl_"); |
| 619 | return false; |
| 620 | } |
| 621 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
| 622 | { |
| 623 | if (identifier.compare(0, 6, "webgl_") == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 624 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 625 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 626 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 627 | } |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 628 | if (identifier.compare(0, 7, "_webgl_") == 0) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 629 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 630 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 631 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 632 | } |
| 633 | } |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 634 | if (identifier.find("__") != TString::npos) |
| 635 | { |
| 636 | error(line, |
| 637 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 638 | "possible future keywords", |
| 639 | identifier.c_str()); |
| 640 | return false; |
| 641 | } |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 642 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 643 | } |
| 644 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 645 | // Make sure the argument types are correct for constructing a specific type. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 646 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 647 | const TIntermSequence *arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 648 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 649 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 650 | if (arguments->empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 651 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 652 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 653 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 654 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 655 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 656 | for (TIntermNode *arg : *arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 657 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 658 | const TIntermTyped *argTyped = arg->getAsTyped(); |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 659 | ASSERT(argTyped != nullptr); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 660 | if (type.getBasicType() != EbtStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 661 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 662 | std::string reason("cannot convert a variable with type "); |
| 663 | reason += getBasicString(argTyped->getBasicType()); |
| 664 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 665 | return false; |
| 666 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 667 | else if (argTyped->getMemoryQualifier().writeonly) |
| 668 | { |
| 669 | error(line, "cannot convert a variable with writeonly", "constructor"); |
| 670 | return false; |
| 671 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 672 | if (argTyped->getBasicType() == EbtVoid) |
| 673 | { |
| 674 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 675 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 676 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 677 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 678 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 679 | if (type.isArray()) |
| 680 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 681 | // The size of an unsized constructor should already have been determined. |
| 682 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 683 | if (static_cast<size_t>(type.getOutermostArraySize()) != arguments->size()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 684 | { |
| 685 | error(line, "array constructor needs one argument per array element", "constructor"); |
| 686 | return false; |
| 687 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 688 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 689 | // the array. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 690 | for (TIntermNode *const &argNode : *arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 691 | { |
| 692 | const TType &argType = argNode->getAsTyped()->getType(); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 693 | if (argType.isArray()) |
| 694 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 695 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 696 | return false; |
| 697 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 698 | if (!argType.isElementTypeOf(type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 699 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 700 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 701 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 702 | } |
| 703 | } |
| 704 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 705 | else if (type.getBasicType() == EbtStruct) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 706 | { |
| 707 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 708 | if (fields.size() != arguments->size()) |
| 709 | { |
| 710 | error(line, |
| 711 | "Number of constructor parameters does not match the number of structure fields", |
| 712 | "constructor"); |
| 713 | return false; |
| 714 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 715 | |
| 716 | for (size_t i = 0; i < fields.size(); i++) |
| 717 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 718 | if (i >= arguments->size() || |
| 719 | (*arguments)[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 720 | { |
| 721 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 722 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 723 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 724 | } |
| 725 | } |
| 726 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 727 | else |
| 728 | { |
| 729 | // We're constructing a scalar, vector, or matrix. |
| 730 | |
| 731 | // Note: It's okay to have too many components available, but not okay to have unused |
| 732 | // arguments. 'full' will go to true when enough args have been seen. If we loop again, |
| 733 | // there is an extra argument, so 'overFull' will become true. |
| 734 | |
| 735 | size_t size = 0; |
| 736 | bool full = false; |
| 737 | bool overFull = false; |
| 738 | bool matrixArg = false; |
| 739 | for (TIntermNode *arg : *arguments) |
| 740 | { |
| 741 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 742 | ASSERT(argTyped != nullptr); |
| 743 | |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 744 | if (argTyped->getBasicType() == EbtStruct) |
| 745 | { |
| 746 | error(line, "a struct cannot be used as a constructor argument for this type", |
| 747 | "constructor"); |
| 748 | return false; |
| 749 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 750 | if (argTyped->getType().isArray()) |
| 751 | { |
| 752 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 753 | return false; |
| 754 | } |
| 755 | if (argTyped->getType().isMatrix()) |
| 756 | { |
| 757 | matrixArg = true; |
| 758 | } |
| 759 | |
| 760 | size += argTyped->getType().getObjectSize(); |
| 761 | if (full) |
| 762 | { |
| 763 | overFull = true; |
| 764 | } |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 765 | if (size >= type.getObjectSize()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 766 | { |
| 767 | full = true; |
| 768 | } |
| 769 | } |
| 770 | |
| 771 | if (type.isMatrix() && matrixArg) |
| 772 | { |
| 773 | if (arguments->size() != 1) |
| 774 | { |
| 775 | error(line, "constructing matrix from matrix can only take one argument", |
| 776 | "constructor"); |
| 777 | return false; |
| 778 | } |
| 779 | } |
| 780 | else |
| 781 | { |
| 782 | if (size != 1 && size < type.getObjectSize()) |
| 783 | { |
| 784 | error(line, "not enough data provided for construction", "constructor"); |
| 785 | return false; |
| 786 | } |
| 787 | if (overFull) |
| 788 | { |
| 789 | error(line, "too many arguments", "constructor"); |
| 790 | return false; |
| 791 | } |
| 792 | } |
| 793 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 794 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 795 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 796 | } |
| 797 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 798 | // This function checks to see if a void variable has been declared and raise an error message for |
| 799 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 800 | // |
| 801 | // returns true in case of an error |
| 802 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 803 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 804 | const TString &identifier, |
| 805 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 806 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 807 | if (type == EbtVoid) |
| 808 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 809 | error(line, "illegal use of type 'void'", identifier.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 810 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 811 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 812 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 813 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 814 | } |
| 815 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 816 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 817 | // or not. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 818 | bool TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 819 | { |
Olli Etuaho | 37d96cc | 2017-07-11 14:14:03 +0300 | [diff] [blame] | 820 | if (type->getBasicType() != EbtBool || !type->isScalar()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 821 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 822 | error(line, "boolean expression expected", ""); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 823 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 824 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 825 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 826 | } |
| 827 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 828 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 829 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 830 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 831 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 832 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 833 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 834 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 835 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 836 | } |
| 837 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 838 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 839 | const TTypeSpecifierNonArray &pType, |
| 840 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 841 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 842 | if (pType.type == EbtStruct) |
| 843 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 844 | if (ContainsSampler(pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 845 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 846 | std::stringstream reasonStream; |
| 847 | reasonStream << reason << " (structure contains a sampler)"; |
| 848 | std::string reasonStr = reasonStream.str(); |
| 849 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 850 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 851 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 852 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 853 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 854 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 855 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 856 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 857 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 858 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 859 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 860 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 861 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 862 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 863 | } |
| 864 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 865 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 866 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 867 | { |
| 868 | if (pType.layoutQualifier.location != -1) |
| 869 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 870 | error(line, "location must only be specified for a single input or output variable", |
| 871 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 872 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 873 | } |
| 874 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 875 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 876 | const TLayoutQualifier &layoutQualifier) |
| 877 | { |
| 878 | if (layoutQualifier.location != -1) |
| 879 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 880 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 881 | if (mShaderVersion >= 310) |
| 882 | { |
| 883 | errorMsg = |
| 884 | "invalid layout qualifier: only valid on program inputs, outputs, and uniforms"; |
| 885 | } |
| 886 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 887 | } |
| 888 | } |
| 889 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 890 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 891 | TQualifier qualifier, |
| 892 | const TType &type) |
| 893 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 894 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 895 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 896 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 897 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 898 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 899 | } |
| 900 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 901 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 902 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 903 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 904 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 905 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 906 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 907 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 908 | // fold as array size. |
| 909 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 910 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 911 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 912 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 913 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 914 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 915 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 916 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 917 | if (constant->getBasicType() == EbtUInt) |
| 918 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 919 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 920 | } |
| 921 | else |
| 922 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 923 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 924 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 925 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 926 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 927 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 928 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 929 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 930 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 931 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 932 | } |
| 933 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 934 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 935 | { |
| 936 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 937 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 938 | } |
| 939 | |
| 940 | // The size of arrays is restricted here to prevent issues further down the |
| 941 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 942 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 943 | const unsigned int sizeLimit = 65536; |
| 944 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 945 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 946 | { |
| 947 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 948 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 949 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 950 | |
| 951 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 952 | } |
| 953 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 954 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 955 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 956 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 957 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 958 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 959 | (elementQualifier.qualifier == EvqVertexIn) || |
| 960 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 961 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 962 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 963 | TType(elementQualifier).getQualifierString()); |
| 964 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 965 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 966 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 967 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 968 | } |
| 969 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 970 | // See if this element type can be formed into an array. |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 971 | bool TParseContext::checkArrayElementIsNotArray(const TSourceLoc &line, |
| 972 | const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 973 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 974 | if (elementType.array) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 975 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 976 | error(line, "cannot declare arrays of arrays", |
| 977 | TType(elementType).getCompleteString().c_str()); |
| 978 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 979 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 980 | return true; |
| 981 | } |
| 982 | |
| 983 | // Check if this qualified element type can be formed into an array. This is only called when array |
| 984 | // brackets are associated with an identifier in a declaration, like this: |
| 985 | // float a[2]; |
| 986 | // Similar checks are done in addFullySpecifiedType for array declarations where the array brackets |
| 987 | // are associated with the type, like this: |
| 988 | // float[2] a; |
| 989 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 990 | const TPublicType &elementType) |
| 991 | { |
| 992 | if (!checkArrayElementIsNotArray(indexLocation, elementType)) |
| 993 | { |
| 994 | return false; |
| 995 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 996 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 997 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 998 | // 4.3.4). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 999 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1000 | sh::IsVarying(elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1001 | { |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1002 | error(indexLocation, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1003 | TType(elementType).getCompleteString().c_str()); |
| 1004 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1005 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1006 | return checkIsValidQualifierForArray(indexLocation, elementType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1007 | } |
| 1008 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1009 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1010 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
| 1011 | const TString &identifier, |
| 1012 | TPublicType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1013 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1014 | ASSERT(type != nullptr); |
| 1015 | if (type->qualifier == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1016 | { |
| 1017 | // Make the qualifier make sense. |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1018 | type->qualifier = EvqTemporary; |
| 1019 | |
| 1020 | // Generate informative error messages for ESSL1. |
| 1021 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1022 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1023 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1024 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1025 | "structures containing arrays may not be declared constant since they cannot be " |
| 1026 | "initialized", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1027 | identifier.c_str()); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1028 | } |
| 1029 | else |
| 1030 | { |
| 1031 | error(line, "variables with qualifier 'const' must be initialized", identifier.c_str()); |
| 1032 | } |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1033 | return; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1034 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1035 | if (type->isUnsizedArray()) |
| 1036 | { |
| 1037 | error(line, "implicitly sized arrays need to be initialized", identifier.c_str()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1038 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1039 | } |
| 1040 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1041 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1042 | // and update the symbol table. |
| 1043 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1044 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1045 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1046 | bool TParseContext::declareVariable(const TSourceLoc &line, |
| 1047 | const TString &identifier, |
| 1048 | const TType &type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1049 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1050 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1051 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1052 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1053 | checkBindingIsValid(line, type); |
| 1054 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1055 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1056 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1057 | // gl_LastFragData may be redeclared with a new precision qualifier |
| 1058 | if (type.isArray() && identifier.compare(0, 15, "gl_LastFragData") == 0) |
| 1059 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1060 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
| 1061 | symbolTable.findBuiltIn("gl_MaxDrawBuffers", mShaderVersion)); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1062 | if (type.isArrayOfArrays()) |
| 1063 | { |
| 1064 | error(line, "redeclaration of gl_LastFragData as an array of arrays", |
| 1065 | identifier.c_str()); |
| 1066 | return false; |
| 1067 | } |
| 1068 | else if (static_cast<int>(type.getOutermostArraySize()) == |
| 1069 | maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1070 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1071 | if (TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1072 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1073 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->getExtension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1074 | } |
| 1075 | } |
| 1076 | else |
| 1077 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1078 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
| 1079 | identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1080 | return false; |
| 1081 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1082 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1083 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1084 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1085 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1086 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1087 | (*variable) = symbolTable.declareVariable(&identifier, type); |
| 1088 | if (!(*variable)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1089 | { |
| 1090 | error(line, "redefinition", identifier.c_str()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1091 | return false; |
| 1092 | } |
| 1093 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1094 | if (!checkIsNonVoid(line, identifier, type.getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1095 | return false; |
| 1096 | |
| 1097 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1098 | } |
| 1099 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1100 | void TParseContext::checkIsParameterQualifierValid( |
| 1101 | const TSourceLoc &line, |
| 1102 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1103 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1104 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 1105 | // The only parameter qualifiers a parameter can have are in, out, inout or const. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1106 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1107 | |
| 1108 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1109 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1110 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1111 | } |
| 1112 | |
| 1113 | if (!IsImage(type->getBasicType())) |
| 1114 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1115 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1116 | } |
| 1117 | else |
| 1118 | { |
| 1119 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1120 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1121 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1122 | type->setQualifier(typeQualifier.qualifier); |
| 1123 | |
| 1124 | if (typeQualifier.precision != EbpUndefined) |
| 1125 | { |
| 1126 | type->setPrecision(typeQualifier.precision); |
| 1127 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1128 | } |
| 1129 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1130 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, const TString &extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1131 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1132 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1133 | TExtensionBehavior::const_iterator iter = extBehavior.find(extension.c_str()); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1134 | if (iter == extBehavior.end()) |
| 1135 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1136 | error(line, "extension is not supported", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1137 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1138 | } |
zmo@google.com | f545091 | 2011-09-09 01:37:19 +0000 | [diff] [blame] | 1139 | // In GLSL ES, an extension's default behavior is "disable". |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1140 | if (iter->second == EBhDisable || iter->second == EBhUndefined) |
| 1141 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1142 | // TODO(oetuaho@nvidia.com): This is slightly hacky. Might be better if symbols could be |
| 1143 | // associated with more than one extension. |
| 1144 | if (extension == "GL_OVR_multiview") |
| 1145 | { |
| 1146 | return checkCanUseExtension(line, "GL_OVR_multiview2"); |
| 1147 | } |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1148 | error(line, "extension is disabled", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1149 | return false; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1150 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1151 | if (iter->second == EBhWarn) |
| 1152 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1153 | warning(line, "extension is being used", extension.c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1154 | return true; |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1155 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1156 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1157 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1158 | } |
| 1159 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1160 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1161 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1162 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1163 | // declaration is empty. |
| 1164 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1165 | const sh::TLayoutQualifier &layoutQualifier, |
| 1166 | const TSourceLoc &location) |
| 1167 | { |
| 1168 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1169 | { |
| 1170 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1171 | } |
| 1172 | |
| 1173 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1174 | { |
| 1175 | error(location, "layout qualifier only valid for interface blocks", |
| 1176 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1177 | return; |
| 1178 | } |
| 1179 | |
| 1180 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1181 | { |
| 1182 | error(location, "layout qualifier only valid for interface blocks", |
| 1183 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1184 | return; |
| 1185 | } |
| 1186 | |
| 1187 | if (qualifier == EvqFragmentOut) |
| 1188 | { |
| 1189 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1190 | { |
| 1191 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1192 | return; |
| 1193 | } |
| 1194 | } |
| 1195 | else |
| 1196 | { |
| 1197 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1198 | } |
| 1199 | |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1200 | // If multiview extension is enabled, "in" qualifier is allowed in the vertex shader in previous |
| 1201 | // parsing steps. So it needs to be checked here. |
| 1202 | if (isMultiviewExtensionEnabled() && mShaderVersion < 300 && qualifier == EvqVertexIn) |
| 1203 | { |
| 1204 | error(location, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 1205 | } |
| 1206 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1207 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
| 1208 | if (mShaderVersion >= 310 && qualifier == EvqUniform) |
| 1209 | { |
| 1210 | canHaveLocation = true; |
| 1211 | // We're not checking whether the uniform location is in range here since that depends on |
| 1212 | // the type of the variable. |
| 1213 | // The type can only be fully determined for non-empty declarations. |
| 1214 | } |
| 1215 | if (!canHaveLocation) |
| 1216 | { |
| 1217 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1218 | } |
| 1219 | } |
| 1220 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1221 | void TParseContext::atomicCounterQualifierErrorCheck(const TPublicType &publicType, |
| 1222 | const TSourceLoc &location) |
| 1223 | { |
| 1224 | if (publicType.precision != EbpHigh) |
| 1225 | { |
| 1226 | error(location, "Can only be highp", "atomic counter"); |
| 1227 | } |
| 1228 | // dEQP enforces compile error if location is specified. See uniform_location.test. |
| 1229 | if (publicType.layoutQualifier.location != -1) |
| 1230 | { |
| 1231 | error(location, "location must not be set for atomic_uint", "layout"); |
| 1232 | } |
| 1233 | if (publicType.layoutQualifier.binding == -1) |
| 1234 | { |
| 1235 | error(location, "no binding specified", "atomic counter"); |
| 1236 | } |
| 1237 | } |
| 1238 | |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1239 | void TParseContext::emptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1240 | const TSourceLoc &location) |
| 1241 | { |
| 1242 | if (publicType.isUnsizedArray()) |
| 1243 | { |
| 1244 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1245 | // error. It is assumed that this applies to empty declarations as well. |
| 1246 | error(location, "empty array declaration needs to specify a size", ""); |
| 1247 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1248 | } |
| 1249 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1250 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1251 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1252 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1253 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1254 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1255 | switch (publicType.qualifier) |
| 1256 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1257 | case EvqVaryingIn: |
| 1258 | case EvqVaryingOut: |
| 1259 | case EvqAttribute: |
| 1260 | case EvqVertexIn: |
| 1261 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1262 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1263 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1264 | { |
| 1265 | error(identifierLocation, "cannot be used with a structure", |
| 1266 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1267 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1268 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1269 | break; |
| 1270 | case EvqBuffer: |
| 1271 | if (publicType.getBasicType() != EbtInterfaceBlock) |
| 1272 | { |
| 1273 | error(identifierLocation, |
| 1274 | "cannot declare buffer variables at global scope(outside a block)", |
| 1275 | getQualifierString(publicType.qualifier)); |
| 1276 | return; |
| 1277 | } |
| 1278 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1279 | default: |
| 1280 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1281 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1282 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1283 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1284 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1285 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1286 | { |
| 1287 | return; |
| 1288 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1289 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1290 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1291 | publicType.qualifier != EvqConst) && |
| 1292 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1293 | { |
| 1294 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1295 | getQualifierString(publicType.qualifier)); |
| 1296 | return; |
| 1297 | } |
| 1298 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1299 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1300 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1301 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1302 | // But invalid shaders may still reach here with an unsized array declaration. |
| 1303 | if (!publicType.isUnsizedArray()) |
| 1304 | { |
| 1305 | TType type(publicType); |
| 1306 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1307 | publicType.layoutQualifier); |
| 1308 | } |
| 1309 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1310 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1311 | // check for layout qualifier issues |
| 1312 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1313 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1314 | if (IsImage(publicType.getBasicType())) |
| 1315 | { |
| 1316 | |
| 1317 | switch (layoutQualifier.imageInternalFormat) |
| 1318 | { |
| 1319 | case EiifRGBA32F: |
| 1320 | case EiifRGBA16F: |
| 1321 | case EiifR32F: |
| 1322 | case EiifRGBA8: |
| 1323 | case EiifRGBA8_SNORM: |
| 1324 | if (!IsFloatImage(publicType.getBasicType())) |
| 1325 | { |
| 1326 | error(identifierLocation, |
| 1327 | "internal image format requires a floating image type", |
| 1328 | getBasicString(publicType.getBasicType())); |
| 1329 | return; |
| 1330 | } |
| 1331 | break; |
| 1332 | case EiifRGBA32I: |
| 1333 | case EiifRGBA16I: |
| 1334 | case EiifRGBA8I: |
| 1335 | case EiifR32I: |
| 1336 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1337 | { |
| 1338 | error(identifierLocation, |
| 1339 | "internal image format requires an integer image type", |
| 1340 | getBasicString(publicType.getBasicType())); |
| 1341 | return; |
| 1342 | } |
| 1343 | break; |
| 1344 | case EiifRGBA32UI: |
| 1345 | case EiifRGBA16UI: |
| 1346 | case EiifRGBA8UI: |
| 1347 | case EiifR32UI: |
| 1348 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1349 | { |
| 1350 | error(identifierLocation, |
| 1351 | "internal image format requires an unsigned image type", |
| 1352 | getBasicString(publicType.getBasicType())); |
| 1353 | return; |
| 1354 | } |
| 1355 | break; |
| 1356 | case EiifUnspecified: |
| 1357 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1358 | return; |
| 1359 | default: |
| 1360 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1361 | return; |
| 1362 | } |
| 1363 | |
| 1364 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1365 | switch (layoutQualifier.imageInternalFormat) |
| 1366 | { |
| 1367 | case EiifR32F: |
| 1368 | case EiifR32I: |
| 1369 | case EiifR32UI: |
| 1370 | break; |
| 1371 | default: |
| 1372 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1373 | { |
| 1374 | error(identifierLocation, "layout qualifier", |
| 1375 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1376 | "image variables must be qualified readonly and/or writeonly"); |
| 1377 | return; |
| 1378 | } |
| 1379 | break; |
| 1380 | } |
| 1381 | } |
| 1382 | else |
| 1383 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1384 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1385 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1386 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1387 | |
| 1388 | if (IsAtomicCounter(publicType.getBasicType())) |
| 1389 | { |
| 1390 | atomicCounterQualifierErrorCheck(publicType, identifierLocation); |
| 1391 | } |
| 1392 | else |
| 1393 | { |
| 1394 | checkOffsetIsNotSpecified(identifierLocation, layoutQualifier.offset); |
| 1395 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1396 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1397 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1398 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1399 | { |
| 1400 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1401 | // Note that the ESSL 3.10 section 4.4.5 is not particularly clear on how the binding qualifier |
| 1402 | // on arrays of arrays should be handled. We interpret the spec so that the binding value is |
| 1403 | // incremented for each element of the innermost nested arrays. This is in line with how arrays |
| 1404 | // of arrays of blocks are specified to behave in GLSL 4.50 and a conservative interpretation |
| 1405 | // when it comes to which shaders are accepted by the compiler. |
| 1406 | int arrayTotalElementCount = type.getArraySizeProduct(); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1407 | if (IsImage(type.getBasicType())) |
| 1408 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1409 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1410 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1411 | } |
| 1412 | else if (IsSampler(type.getBasicType())) |
| 1413 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1414 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1415 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1416 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1417 | else if (IsAtomicCounter(type.getBasicType())) |
| 1418 | { |
| 1419 | checkAtomicCounterBindingIsValid(identifierLocation, layoutQualifier.binding); |
| 1420 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1421 | else |
| 1422 | { |
| 1423 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1424 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1425 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1426 | } |
| 1427 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1428 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
| 1429 | const TString &layoutQualifierName, |
| 1430 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1431 | { |
| 1432 | |
| 1433 | if (mShaderVersion < versionRequired) |
| 1434 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1435 | error(location, "invalid layout qualifier: not supported", layoutQualifierName.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1436 | } |
| 1437 | } |
| 1438 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1439 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1440 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1441 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1442 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1443 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1444 | { |
| 1445 | if (localSize[i] != -1) |
| 1446 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1447 | error(location, |
| 1448 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1449 | "global layout declaration", |
| 1450 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1451 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1452 | } |
| 1453 | } |
| 1454 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1455 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1456 | } |
| 1457 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1458 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1459 | TLayoutImageInternalFormat internalFormat) |
| 1460 | { |
| 1461 | if (internalFormat != EiifUnspecified) |
| 1462 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1463 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1464 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1465 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1466 | } |
| 1467 | |
| 1468 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1469 | { |
| 1470 | if (binding != -1) |
| 1471 | { |
| 1472 | error(location, |
| 1473 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1474 | "binding"); |
| 1475 | } |
| 1476 | } |
| 1477 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1478 | void TParseContext::checkOffsetIsNotSpecified(const TSourceLoc &location, int offset) |
| 1479 | { |
| 1480 | if (offset != -1) |
| 1481 | { |
| 1482 | error(location, "invalid layout qualifier: only valid when used with atomic counters", |
| 1483 | "offset"); |
| 1484 | } |
| 1485 | } |
| 1486 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1487 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, |
| 1488 | int binding, |
| 1489 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1490 | { |
| 1491 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1492 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1493 | { |
| 1494 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1495 | } |
| 1496 | } |
| 1497 | |
| 1498 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1499 | int binding, |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1500 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1501 | { |
| 1502 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1503 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxCombinedTextureImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1504 | { |
| 1505 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1506 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1507 | } |
| 1508 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1509 | void TParseContext::checkBlockBindingIsValid(const TSourceLoc &location, |
| 1510 | const TQualifier &qualifier, |
| 1511 | int binding, |
| 1512 | int arraySize) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1513 | { |
| 1514 | int size = (arraySize == 0 ? 1 : arraySize); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1515 | if (qualifier == EvqUniform) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1516 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1517 | if (binding + size > mMaxUniformBufferBindings) |
| 1518 | { |
| 1519 | error(location, "uniform block binding greater than MAX_UNIFORM_BUFFER_BINDINGS", |
| 1520 | "binding"); |
| 1521 | } |
| 1522 | } |
| 1523 | else if (qualifier == EvqBuffer) |
| 1524 | { |
| 1525 | if (binding + size > mMaxShaderStorageBufferBindings) |
| 1526 | { |
| 1527 | error(location, |
| 1528 | "shader storage block binding greater than MAX_SHADER_STORAGE_BUFFER_BINDINGS", |
| 1529 | "binding"); |
| 1530 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1531 | } |
| 1532 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1533 | void TParseContext::checkAtomicCounterBindingIsValid(const TSourceLoc &location, int binding) |
| 1534 | { |
| 1535 | if (binding >= mMaxAtomicCounterBindings) |
| 1536 | { |
| 1537 | error(location, "atomic counter binding greater than gl_MaxAtomicCounterBindings", |
| 1538 | "binding"); |
| 1539 | } |
| 1540 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1541 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1542 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1543 | int objectLocationCount, |
| 1544 | const TLayoutQualifier &layoutQualifier) |
| 1545 | { |
| 1546 | int loc = layoutQualifier.location; |
| 1547 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1548 | { |
| 1549 | error(location, "Uniform location out of range", "location"); |
| 1550 | } |
| 1551 | } |
| 1552 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1553 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1554 | { |
| 1555 | if (yuv != false) |
| 1556 | { |
| 1557 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1558 | } |
| 1559 | } |
| 1560 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1561 | void TParseContext::functionCallRValueLValueErrorCheck(const TFunction *fnCandidate, |
| 1562 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1563 | { |
| 1564 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1565 | { |
| 1566 | TQualifier qual = fnCandidate->getParam(i).type->getQualifier(); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1567 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
| 1568 | if (!IsImage(argument->getBasicType()) && (IsQualifierUnspecified(qual) || qual == EvqIn || |
| 1569 | qual == EvqInOut || qual == EvqConstReadOnly)) |
| 1570 | { |
| 1571 | if (argument->getMemoryQualifier().writeonly) |
| 1572 | { |
| 1573 | error(argument->getLine(), |
| 1574 | "Writeonly value cannot be passed for 'in' or 'inout' parameters.", |
| 1575 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
| 1576 | return; |
| 1577 | } |
| 1578 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1579 | if (qual == EvqOut || qual == EvqInOut) |
| 1580 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1581 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1582 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1583 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1584 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 1585 | fnCall->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1586 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1587 | } |
| 1588 | } |
| 1589 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1590 | } |
| 1591 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1592 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1593 | const TQualifier qualifier, |
| 1594 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1595 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1596 | if (!invariant) |
| 1597 | return; |
| 1598 | |
| 1599 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1600 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1601 | // input variables in the fragment shader can be also qualified as invariant |
| 1602 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1603 | { |
| 1604 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1605 | } |
| 1606 | } |
| 1607 | else |
| 1608 | { |
| 1609 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1610 | { |
| 1611 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1612 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1613 | } |
| 1614 | } |
| 1615 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1616 | bool TParseContext::supportsExtension(const char *extension) |
zmo@google.com | 09c323a | 2011-08-12 18:22:25 +0000 | [diff] [blame] | 1617 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1618 | const TExtensionBehavior &extbehavior = extensionBehavior(); |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 1619 | TExtensionBehavior::const_iterator iter = extbehavior.find(extension); |
| 1620 | return (iter != extbehavior.end()); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 1621 | } |
| 1622 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1623 | bool TParseContext::isExtensionEnabled(const char *extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1624 | { |
Kimmo Kinnunen | b18609b | 2015-07-16 14:13:11 +0300 | [diff] [blame] | 1625 | return ::IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1626 | } |
| 1627 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1628 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1629 | const char *extName, |
| 1630 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1631 | { |
| 1632 | pp::SourceLocation srcLoc; |
| 1633 | srcLoc.file = loc.first_file; |
| 1634 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1635 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1636 | } |
| 1637 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1638 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1639 | const char *name, |
| 1640 | const char *value, |
| 1641 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1642 | { |
| 1643 | pp::SourceLocation srcLoc; |
| 1644 | srcLoc.file = loc.first_file; |
| 1645 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1646 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1647 | } |
| 1648 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1649 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1650 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1651 | sh::WorkGroupSize result; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1652 | for (size_t i = 0u; i < result.size(); ++i) |
| 1653 | { |
| 1654 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1655 | { |
| 1656 | result[i] = 1; |
| 1657 | } |
| 1658 | else |
| 1659 | { |
| 1660 | result[i] = mComputeShaderLocalSize[i]; |
| 1661 | } |
| 1662 | } |
| 1663 | return result; |
| 1664 | } |
| 1665 | |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1666 | TIntermConstantUnion *TParseContext::addScalarLiteral(const TConstantUnion *constantUnion, |
| 1667 | const TSourceLoc &line) |
| 1668 | { |
| 1669 | TIntermConstantUnion *node = new TIntermConstantUnion( |
| 1670 | constantUnion, TType(constantUnion->getType(), EbpUndefined, EvqConst)); |
| 1671 | node->setLine(line); |
| 1672 | return node; |
| 1673 | } |
| 1674 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1675 | ///////////////////////////////////////////////////////////////////////////////// |
| 1676 | // |
| 1677 | // Non-Errors. |
| 1678 | // |
| 1679 | ///////////////////////////////////////////////////////////////////////////////// |
| 1680 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1681 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
| 1682 | const TString *name, |
| 1683 | const TSymbol *symbol) |
| 1684 | { |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1685 | if (!symbol) |
| 1686 | { |
| 1687 | error(location, "undeclared identifier", name->c_str()); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1688 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1689 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1690 | |
| 1691 | if (!symbol->isVariable()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1692 | { |
| 1693 | error(location, "variable expected", name->c_str()); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1694 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1695 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1696 | |
| 1697 | const TVariable *variable = static_cast<const TVariable *>(symbol); |
| 1698 | |
| 1699 | if (symbolTable.findBuiltIn(variable->getName(), mShaderVersion) && |
| 1700 | !variable->getExtension().empty()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1701 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1702 | checkCanUseExtension(location, variable->getExtension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1703 | } |
| 1704 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1705 | // Reject shaders using both gl_FragData and gl_FragColor |
| 1706 | TQualifier qualifier = variable->getType().getQualifier(); |
| 1707 | if (qualifier == EvqFragData || qualifier == EvqSecondaryFragDataEXT) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1708 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1709 | mUsesFragData = true; |
| 1710 | } |
| 1711 | else if (qualifier == EvqFragColor || qualifier == EvqSecondaryFragColorEXT) |
| 1712 | { |
| 1713 | mUsesFragColor = true; |
| 1714 | } |
| 1715 | if (qualifier == EvqSecondaryFragDataEXT || qualifier == EvqSecondaryFragColorEXT) |
| 1716 | { |
| 1717 | mUsesSecondaryOutputs = true; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1718 | } |
| 1719 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1720 | // This validation is not quite correct - it's only an error to write to |
| 1721 | // both FragData and FragColor. For simplicity, and because users shouldn't |
| 1722 | // be rewarded for reading from undefined varaibles, return an error |
| 1723 | // if they are both referenced, rather than assigned. |
| 1724 | if (mUsesFragData && mUsesFragColor) |
| 1725 | { |
| 1726 | const char *errorMessage = "cannot use both gl_FragData and gl_FragColor"; |
| 1727 | if (mUsesSecondaryOutputs) |
| 1728 | { |
| 1729 | errorMessage = |
| 1730 | "cannot use both output variable sets (gl_FragData, gl_SecondaryFragDataEXT)" |
| 1731 | " and (gl_FragColor, gl_SecondaryFragColorEXT)"; |
| 1732 | } |
| 1733 | error(location, errorMessage, name->c_str()); |
| 1734 | } |
| 1735 | |
| 1736 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1737 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
| 1738 | qualifier == EvqWorkGroupSize) |
| 1739 | { |
| 1740 | error(location, |
| 1741 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1742 | "gl_WorkGroupSize"); |
| 1743 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1744 | return variable; |
| 1745 | } |
| 1746 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1747 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
| 1748 | const TString *name, |
| 1749 | const TSymbol *symbol) |
| 1750 | { |
| 1751 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1752 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1753 | if (!variable) |
| 1754 | { |
| 1755 | TIntermTyped *node = CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 1756 | node->setLine(location); |
| 1757 | return node; |
| 1758 | } |
| 1759 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 1760 | if (variable->getType().getQualifier() == EvqViewIDOVR && IsWebGLBasedSpec(mShaderSpec) && |
| 1761 | mShaderType == GL_FRAGMENT_SHADER && !isExtensionEnabled("GL_OVR_multiview2")) |
| 1762 | { |
| 1763 | // WEBGL_multiview spec |
| 1764 | error(location, "Need to enable OVR_multiview2 to use gl_ViewID_OVR in fragment shader", |
| 1765 | "gl_ViewID_OVR"); |
| 1766 | } |
| 1767 | |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1768 | TIntermTyped *node = nullptr; |
| 1769 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 1770 | if (variable->getConstPointer()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1771 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1772 | const TConstantUnion *constArray = variable->getConstPointer(); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1773 | node = new TIntermConstantUnion(constArray, variable->getType()); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1774 | } |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1775 | else if (variable->getType().getQualifier() == EvqWorkGroupSize && |
| 1776 | mComputeShaderLocalSizeDeclared) |
| 1777 | { |
| 1778 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1779 | // needs to be added to the AST as a constant and not as a symbol. |
| 1780 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1781 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1782 | for (size_t i = 0; i < 3; ++i) |
| 1783 | { |
| 1784 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1785 | } |
| 1786 | |
| 1787 | ASSERT(variable->getType().getBasicType() == EbtUInt); |
| 1788 | ASSERT(variable->getType().getObjectSize() == 3); |
| 1789 | |
| 1790 | TType type(variable->getType()); |
| 1791 | type.setQualifier(EvqConst); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1792 | node = new TIntermConstantUnion(constArray, type); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1793 | } |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1794 | // TODO(jiawei.shao@intel.com): set array sizes for user-defined geometry shader inputs. |
| 1795 | else if (variable->getType().getQualifier() == EvqPerVertexIn) |
| 1796 | { |
| 1797 | TType type(variable->getType()); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1798 | type.setArraySize(0, mGeometryShaderInputArraySize); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1799 | node = new TIntermSymbol(variable->getUniqueId(), variable->getName(), type); |
| 1800 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1801 | else |
| 1802 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1803 | node = new TIntermSymbol(variable->getUniqueId(), variable->getName(), variable->getType()); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1804 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1805 | ASSERT(node != nullptr); |
| 1806 | node->setLine(location); |
| 1807 | return node; |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1808 | } |
| 1809 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1810 | // Initializers show up in several places in the grammar. Have one set of |
| 1811 | // code to handle them here. |
| 1812 | // |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1813 | // Returns true on success. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1814 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
| 1815 | const TString &identifier, |
| 1816 | const TPublicType &pType, |
| 1817 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1818 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1819 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1820 | ASSERT(initNode != nullptr); |
| 1821 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1822 | TType type = TType(pType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1823 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1824 | TVariable *variable = nullptr; |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1825 | if (type.isUnsizedArray()) |
| 1826 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1827 | // In case initializer is not an array or type has more dimensions than initializer, this |
| 1828 | // will default to setting array sizes to 1. We have not checked yet whether the initializer |
| 1829 | // actually is an array or not. Having a non-array initializer for an unsized array will |
| 1830 | // result in an error later, so we don't generate an error message here. |
| 1831 | type.sizeUnsizedArrays(initializer->getType().getArraySizes()); |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1832 | } |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1833 | if (!declareVariable(line, identifier, type, &variable)) |
| 1834 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1835 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1836 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1837 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1838 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1839 | if (symbolTable.atGlobalLevel() && |
| 1840 | !ValidateGlobalInitializer(initializer, this, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1841 | { |
| 1842 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1843 | // we want to steer developers towards only using constant expressions. |
| 1844 | error(line, "global variable initializers must be constant expressions", "="); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1845 | return false; |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1846 | } |
| 1847 | if (globalInitWarning) |
| 1848 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1849 | warning( |
| 1850 | line, |
| 1851 | "global variable initializers should be constant expressions " |
| 1852 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1853 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1854 | } |
| 1855 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1856 | // |
| 1857 | // identifier must be of type constant, a global, or a temporary |
| 1858 | // |
| 1859 | TQualifier qualifier = variable->getType().getQualifier(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1860 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1861 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1862 | error(line, " cannot initialize this type of qualifier ", |
| 1863 | variable->getType().getQualifierString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1864 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1865 | } |
| 1866 | // |
| 1867 | // test for and propagate constant |
| 1868 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1869 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1870 | if (qualifier == EvqConst) |
| 1871 | { |
| 1872 | if (qualifier != initializer->getType().getQualifier()) |
| 1873 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1874 | std::stringstream reasonStream; |
| 1875 | reasonStream << "assigning non-constant to '" << variable->getType().getCompleteString() |
| 1876 | << "'"; |
| 1877 | std::string reason = reasonStream.str(); |
| 1878 | error(line, reason.c_str(), "="); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1879 | variable->getType().setQualifier(EvqTemporary); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1880 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1881 | } |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1882 | if (type != initializer->getType()) |
| 1883 | { |
| 1884 | error(line, " non-matching types for const initializer ", |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1885 | variable->getType().getQualifierString()); |
alokp@chromium.org | 58e5429 | 2010-08-24 21:40:03 +0000 | [diff] [blame] | 1886 | variable->getType().setQualifier(EvqTemporary); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1887 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1888 | } |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1889 | |
| 1890 | // Save the constant folded value to the variable if possible. For example array |
| 1891 | // initializers are not folded, since that way copying the array literal to multiple places |
| 1892 | // in the shader is avoided. |
| 1893 | // TODO(oetuaho@nvidia.com): Consider constant folding array initialization in cases where |
| 1894 | // it would be beneficial. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1895 | if (initializer->getAsConstantUnion()) |
| 1896 | { |
Jamie Madill | 94bf7f2 | 2013-07-08 13:31:15 -0400 | [diff] [blame] | 1897 | variable->shareConstPointer(initializer->getAsConstantUnion()->getUnionArrayPointer()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1898 | ASSERT(*initNode == nullptr); |
| 1899 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1900 | } |
| 1901 | else if (initializer->getAsSymbolNode()) |
| 1902 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1903 | const TSymbol *symbol = |
| 1904 | symbolTable.find(initializer->getAsSymbolNode()->getSymbol(), 0); |
| 1905 | const TVariable *tVar = static_cast<const TVariable *>(symbol); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1906 | |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1907 | const TConstantUnion *constArray = tVar->getConstPointer(); |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1908 | if (constArray) |
| 1909 | { |
| 1910 | variable->shareConstPointer(constArray); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1911 | ASSERT(*initNode == nullptr); |
| 1912 | return true; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1913 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1914 | } |
| 1915 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1916 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 1917 | TIntermSymbol *intermSymbol = |
| 1918 | new TIntermSymbol(variable->getUniqueId(), variable->getName(), variable->getType()); |
| 1919 | intermSymbol->setLine(line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1920 | *initNode = createAssign(EOpInitialize, intermSymbol, initializer, line); |
| 1921 | if (*initNode == nullptr) |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1922 | { |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1923 | assignError(line, "=", intermSymbol->getCompleteString(), initializer->getCompleteString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1924 | return false; |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1925 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1926 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1927 | return true; |
| 1928 | } |
| 1929 | |
| 1930 | TIntermNode *TParseContext::addConditionInitializer(const TPublicType &pType, |
| 1931 | const TString &identifier, |
| 1932 | TIntermTyped *initializer, |
| 1933 | const TSourceLoc &loc) |
| 1934 | { |
| 1935 | checkIsScalarBool(loc, pType); |
| 1936 | TIntermBinary *initNode = nullptr; |
| 1937 | if (executeInitializer(loc, identifier, pType, initializer, &initNode)) |
| 1938 | { |
| 1939 | // The initializer is valid. The init condition needs to have a node - either the |
| 1940 | // initializer node, or a constant node in case the initialized variable is const and won't |
| 1941 | // be recorded in the AST. |
| 1942 | if (initNode == nullptr) |
| 1943 | { |
| 1944 | return initializer; |
| 1945 | } |
| 1946 | else |
| 1947 | { |
| 1948 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 1949 | declaration->appendDeclarator(initNode); |
| 1950 | return declaration; |
| 1951 | } |
| 1952 | } |
| 1953 | return nullptr; |
| 1954 | } |
| 1955 | |
| 1956 | TIntermNode *TParseContext::addLoop(TLoopType type, |
| 1957 | TIntermNode *init, |
| 1958 | TIntermNode *cond, |
| 1959 | TIntermTyped *expr, |
| 1960 | TIntermNode *body, |
| 1961 | const TSourceLoc &line) |
| 1962 | { |
| 1963 | TIntermNode *node = nullptr; |
| 1964 | TIntermTyped *typedCond = nullptr; |
| 1965 | if (cond) |
| 1966 | { |
| 1967 | typedCond = cond->getAsTyped(); |
| 1968 | } |
| 1969 | if (cond == nullptr || typedCond) |
| 1970 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 1971 | if (type == ELoopDoWhile) |
| 1972 | { |
| 1973 | checkIsScalarBool(line, typedCond); |
| 1974 | } |
| 1975 | // In the case of other loops, it was checked before that the condition is a scalar boolean. |
| 1976 | ASSERT(mDiagnostics->numErrors() > 0 || typedCond == nullptr || |
| 1977 | (typedCond->getBasicType() == EbtBool && !typedCond->isArray() && |
| 1978 | !typedCond->isVector())); |
| 1979 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 1980 | node = new TIntermLoop(type, init, typedCond, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1981 | node->setLine(line); |
| 1982 | return node; |
| 1983 | } |
| 1984 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 1985 | ASSERT(type != ELoopDoWhile); |
| 1986 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1987 | TIntermDeclaration *declaration = cond->getAsDeclarationNode(); |
| 1988 | ASSERT(declaration); |
| 1989 | TIntermBinary *declarator = declaration->getSequence()->front()->getAsBinaryNode(); |
| 1990 | ASSERT(declarator->getLeft()->getAsSymbolNode()); |
| 1991 | |
| 1992 | // The condition is a declaration. In the AST representation we don't support declarations as |
| 1993 | // loop conditions. Wrap the loop to a block that declares the condition variable and contains |
| 1994 | // the loop. |
| 1995 | TIntermBlock *block = new TIntermBlock(); |
| 1996 | |
| 1997 | TIntermDeclaration *declareCondition = new TIntermDeclaration(); |
| 1998 | declareCondition->appendDeclarator(declarator->getLeft()->deepCopy()); |
| 1999 | block->appendStatement(declareCondition); |
| 2000 | |
| 2001 | TIntermBinary *conditionInit = new TIntermBinary(EOpAssign, declarator->getLeft()->deepCopy(), |
| 2002 | declarator->getRight()->deepCopy()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2003 | TIntermLoop *loop = new TIntermLoop(type, init, conditionInit, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2004 | block->appendStatement(loop); |
| 2005 | loop->setLine(line); |
| 2006 | block->setLine(line); |
| 2007 | return block; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2008 | } |
| 2009 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2010 | TIntermNode *TParseContext::addIfElse(TIntermTyped *cond, |
| 2011 | TIntermNodePair code, |
| 2012 | const TSourceLoc &loc) |
| 2013 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2014 | bool isScalarBool = checkIsScalarBool(loc, cond); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2015 | |
| 2016 | // For compile time constant conditions, prune the code now. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2017 | if (isScalarBool && cond->getAsConstantUnion()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2018 | { |
| 2019 | if (cond->getAsConstantUnion()->getBConst(0) == true) |
| 2020 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2021 | return EnsureBlock(code.node1); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2022 | } |
| 2023 | else |
| 2024 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2025 | return EnsureBlock(code.node2); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2026 | } |
| 2027 | } |
| 2028 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2029 | TIntermIfElse *node = new TIntermIfElse(cond, EnsureBlock(code.node1), EnsureBlock(code.node2)); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2030 | node->setLine(loc); |
| 2031 | |
| 2032 | return node; |
| 2033 | } |
| 2034 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 2035 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 2036 | { |
| 2037 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 2038 | typeSpecifier->getBasicType()); |
| 2039 | |
| 2040 | if (mShaderVersion < 300 && typeSpecifier->array) |
| 2041 | { |
| 2042 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 2043 | typeSpecifier->clearArrayness(); |
| 2044 | } |
| 2045 | } |
| 2046 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2047 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2048 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2049 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2050 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2051 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2052 | TPublicType returnType = typeSpecifier; |
| 2053 | returnType.qualifier = typeQualifier.qualifier; |
| 2054 | returnType.invariant = typeQualifier.invariant; |
| 2055 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2056 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2057 | returnType.precision = typeSpecifier.precision; |
| 2058 | |
| 2059 | if (typeQualifier.precision != EbpUndefined) |
| 2060 | { |
| 2061 | returnType.precision = typeQualifier.precision; |
| 2062 | } |
| 2063 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2064 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 2065 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2066 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2067 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 2068 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2069 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2070 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2071 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2072 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2073 | { |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2074 | if (typeSpecifier.array) |
| 2075 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2076 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2077 | returnType.clearArrayness(); |
| 2078 | } |
| 2079 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2080 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2081 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2082 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2083 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2084 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2085 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2086 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2087 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2088 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2089 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2090 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2091 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2092 | } |
| 2093 | } |
| 2094 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2095 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2096 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2097 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2098 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2099 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2100 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 2101 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2102 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2103 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 2104 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2105 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2106 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2107 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2108 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2109 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2110 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2111 | } |
| 2112 | |
| 2113 | return returnType; |
| 2114 | } |
| 2115 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2116 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 2117 | const TPublicType &type, |
| 2118 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2119 | { |
| 2120 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2121 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2122 | { |
| 2123 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2124 | } |
| 2125 | |
| 2126 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 2127 | switch (qualifier) |
| 2128 | { |
| 2129 | case EvqVertexIn: |
| 2130 | // ESSL 3.00 section 4.3.4 |
| 2131 | if (type.array) |
| 2132 | { |
| 2133 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2134 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2135 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2136 | return; |
| 2137 | case EvqFragmentOut: |
| 2138 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2139 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2140 | { |
| 2141 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2142 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2143 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2144 | return; |
| 2145 | default: |
| 2146 | break; |
| 2147 | } |
| 2148 | |
| 2149 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 2150 | // restrictions. |
| 2151 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2152 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 2153 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2154 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 2155 | { |
| 2156 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 2157 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2158 | } |
| 2159 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2160 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2161 | { |
| 2162 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 2163 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 2164 | // the ESSL 3.10 spec lists these restrictions explicitly. |
| 2165 | if (type.array) |
| 2166 | { |
| 2167 | error(qualifierLocation, "cannot be an array of structures", |
| 2168 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2169 | } |
| 2170 | if (type.isStructureContainingArrays()) |
| 2171 | { |
| 2172 | error(qualifierLocation, "cannot be a structure containing an array", |
| 2173 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2174 | } |
| 2175 | if (type.isStructureContainingType(EbtStruct)) |
| 2176 | { |
| 2177 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 2178 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2179 | } |
| 2180 | if (type.isStructureContainingType(EbtBool)) |
| 2181 | { |
| 2182 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 2183 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2184 | } |
| 2185 | } |
| 2186 | } |
| 2187 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2188 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 2189 | { |
| 2190 | if (qualifier.getType() == QtStorage) |
| 2191 | { |
| 2192 | const TStorageQualifierWrapper &storageQualifier = |
| 2193 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 2194 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 2195 | !symbolTable.atGlobalLevel()) |
| 2196 | { |
| 2197 | error(storageQualifier.getLine(), |
| 2198 | "Local variables can only use the const storage qualifier.", |
| 2199 | storageQualifier.getQualifierString().c_str()); |
| 2200 | } |
| 2201 | } |
| 2202 | } |
| 2203 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2204 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2205 | const TSourceLoc &location) |
| 2206 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2207 | const std::string reason( |
| 2208 | "Only allowed with shader storage blocks, variables declared within shader storage blocks " |
| 2209 | "and variables declared as image types."); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2210 | if (memoryQualifier.readonly) |
| 2211 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2212 | error(location, reason.c_str(), "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2213 | } |
| 2214 | if (memoryQualifier.writeonly) |
| 2215 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2216 | error(location, reason.c_str(), "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2217 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2218 | if (memoryQualifier.coherent) |
| 2219 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2220 | error(location, reason.c_str(), "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2221 | } |
| 2222 | if (memoryQualifier.restrictQualifier) |
| 2223 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2224 | error(location, reason.c_str(), "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2225 | } |
| 2226 | if (memoryQualifier.volatileQualifier) |
| 2227 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2228 | error(location, reason.c_str(), "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2229 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2230 | } |
| 2231 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2232 | // Make sure there is no offset overlapping, and store the newly assigned offset to "type" in |
| 2233 | // intermediate tree. |
| 2234 | void TParseContext::checkAtomicCounterOffsetIsNotOverlapped(TPublicType &publicType, |
| 2235 | size_t size, |
| 2236 | bool forceAppend, |
| 2237 | const TSourceLoc &loc, |
| 2238 | TType &type) |
| 2239 | { |
| 2240 | auto &bindingState = mAtomicCounterBindingStates[publicType.layoutQualifier.binding]; |
| 2241 | int offset; |
| 2242 | if (publicType.layoutQualifier.offset == -1 || forceAppend) |
| 2243 | { |
| 2244 | offset = bindingState.appendSpan(size); |
| 2245 | } |
| 2246 | else |
| 2247 | { |
| 2248 | offset = bindingState.insertSpan(publicType.layoutQualifier.offset, size); |
| 2249 | } |
| 2250 | if (offset == -1) |
| 2251 | { |
| 2252 | error(loc, "Offset overlapping", "atomic counter"); |
| 2253 | return; |
| 2254 | } |
| 2255 | TLayoutQualifier qualifier = type.getLayoutQualifier(); |
| 2256 | qualifier.offset = offset; |
| 2257 | type.setLayoutQualifier(qualifier); |
| 2258 | } |
| 2259 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2260 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 2261 | TPublicType &publicType, |
| 2262 | const TSourceLoc &identifierOrTypeLocation, |
| 2263 | const TString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2264 | { |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2265 | TType type(publicType); |
| 2266 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 2267 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 2268 | { |
| 2269 | TQualifier qualifier = type.getQualifier(); |
| 2270 | |
| 2271 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 2272 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 2273 | // affected variable declarations: |
| 2274 | // |
| 2275 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 2276 | // elsewhere, in TranslatorGLSL.) |
| 2277 | // |
| 2278 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 2279 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 2280 | // the way this is currently implemented we have to enable this compiler option before |
| 2281 | // parsing the shader and determining the shading language version it uses. If this were |
| 2282 | // implemented as a post-pass, the workaround could be more targeted. |
| 2283 | // |
| 2284 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 2285 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 2286 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 2287 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 2288 | { |
| 2289 | type.setInvariant(true); |
| 2290 | } |
| 2291 | } |
| 2292 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2293 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2294 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2295 | |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2296 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2297 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2298 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2299 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2300 | if (emptyDeclaration) |
| 2301 | { |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 2302 | emptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2303 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 2304 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
| 2305 | if (type.getBasicType() == EbtStruct) |
| 2306 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2307 | symbol = new TIntermSymbol(0, "", type); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2308 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2309 | else if (IsAtomicCounter(publicType.getBasicType())) |
| 2310 | { |
| 2311 | setAtomicCounterBindingDefaultOffset(publicType, identifierOrTypeLocation); |
| 2312 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2313 | } |
| 2314 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2315 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2316 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2317 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2318 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2319 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2320 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2321 | { |
| 2322 | |
| 2323 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterSize, false, |
| 2324 | identifierOrTypeLocation, type); |
| 2325 | } |
| 2326 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2327 | TVariable *variable = nullptr; |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2328 | declareVariable(identifierOrTypeLocation, identifier, type, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2329 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2330 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2331 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2332 | symbol = new TIntermSymbol(variable->getUniqueId(), identifier, type); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2333 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2334 | } |
| 2335 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2336 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2337 | declaration->setLine(identifierOrTypeLocation); |
| 2338 | if (symbol) |
| 2339 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2340 | symbol->setLine(identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2341 | declaration->appendDeclarator(symbol); |
| 2342 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2343 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2344 | } |
| 2345 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2346 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration(TPublicType &publicType, |
| 2347 | const TSourceLoc &identifierLocation, |
| 2348 | const TString &identifier, |
| 2349 | const TSourceLoc &indexLocation, |
| 2350 | TIntermTyped *indexExpression) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2351 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2352 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2353 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2354 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2355 | identifierLocation); |
| 2356 | |
| 2357 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2358 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2359 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2360 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2361 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2362 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2363 | TType arrayType(publicType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2364 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2365 | unsigned int size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2366 | // Make the type an array even if size check failed. |
| 2367 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 2368 | arrayType.makeArray(size); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2369 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2370 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2371 | { |
| 2372 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterArrayStride * size, false, |
| 2373 | identifierLocation, arrayType); |
| 2374 | } |
| 2375 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2376 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2377 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2378 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2379 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2380 | declaration->setLine(identifierLocation); |
| 2381 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2382 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2383 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2384 | TIntermSymbol *symbol = new TIntermSymbol(variable->getUniqueId(), identifier, arrayType); |
| 2385 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2386 | declaration->appendDeclarator(symbol); |
| 2387 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2388 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2389 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2390 | } |
| 2391 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2392 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2393 | const TSourceLoc &identifierLocation, |
| 2394 | const TString &identifier, |
| 2395 | const TSourceLoc &initLocation, |
| 2396 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2397 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2398 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2399 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2400 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2401 | identifierLocation); |
| 2402 | |
| 2403 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2404 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2405 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2406 | declaration->setLine(identifierLocation); |
| 2407 | |
| 2408 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2409 | if (executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2410 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2411 | if (initNode) |
| 2412 | { |
| 2413 | declaration->appendDeclarator(initNode); |
| 2414 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2415 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2416 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2417 | } |
| 2418 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2419 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2420 | TPublicType &publicType, |
| 2421 | const TSourceLoc &identifierLocation, |
| 2422 | const TString &identifier, |
| 2423 | const TSourceLoc &indexLocation, |
| 2424 | TIntermTyped *indexExpression, |
| 2425 | const TSourceLoc &initLocation, |
| 2426 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2427 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2428 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2429 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2430 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2431 | identifierLocation); |
| 2432 | |
| 2433 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2434 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2435 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2436 | |
| 2437 | TPublicType arrayType(publicType); |
| 2438 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2439 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2440 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2441 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2442 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2443 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2444 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2445 | } |
| 2446 | // Make the type an array even if size check failed. |
| 2447 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2448 | arrayType.setArraySize(size); |
| 2449 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2450 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2451 | declaration->setLine(identifierLocation); |
| 2452 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2453 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2454 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2455 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2456 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2457 | if (initNode) |
| 2458 | { |
| 2459 | declaration->appendDeclarator(initNode); |
| 2460 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2461 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2462 | |
| 2463 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2464 | } |
| 2465 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2466 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2467 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2468 | const TSourceLoc &identifierLoc, |
| 2469 | const TString *identifier, |
| 2470 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2471 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2472 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2473 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2474 | if (!typeQualifier.invariant) |
| 2475 | { |
| 2476 | error(identifierLoc, "Expected invariant", identifier->c_str()); |
| 2477 | return nullptr; |
| 2478 | } |
| 2479 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2480 | { |
| 2481 | return nullptr; |
| 2482 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2483 | if (!symbol) |
| 2484 | { |
| 2485 | error(identifierLoc, "undeclared identifier declared as invariant", identifier->c_str()); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2486 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2487 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2488 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2489 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2490 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2491 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2492 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2493 | if (typeQualifier.precision != EbpUndefined) |
| 2494 | { |
| 2495 | error(identifierLoc, "invariant declaration specifies precision", |
| 2496 | getPrecisionString(typeQualifier.precision)); |
| 2497 | } |
| 2498 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2499 | { |
| 2500 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2501 | } |
| 2502 | |
| 2503 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 2504 | if (!variable) |
| 2505 | { |
| 2506 | return nullptr; |
| 2507 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2508 | const TType &type = variable->getType(); |
| 2509 | |
| 2510 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2511 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2512 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2513 | |
| 2514 | symbolTable.addInvariantVarying(std::string(identifier->c_str())); |
| 2515 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2516 | TIntermSymbol *intermSymbol = new TIntermSymbol(variable->getUniqueId(), *identifier, type); |
| 2517 | intermSymbol->setLine(identifierLoc); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2518 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2519 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2520 | } |
| 2521 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2522 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2523 | const TSourceLoc &identifierLocation, |
| 2524 | const TString &identifier, |
| 2525 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2526 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2527 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2528 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2529 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2530 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2531 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2532 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2533 | } |
| 2534 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2535 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2536 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2537 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2538 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2539 | TVariable *variable = nullptr; |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2540 | TType type(publicType); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2541 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2542 | { |
| 2543 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterSize, true, |
| 2544 | identifierLocation, type); |
| 2545 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2546 | declareVariable(identifierLocation, identifier, type, &variable); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2547 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2548 | if (variable) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2549 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2550 | TIntermSymbol *symbol = new TIntermSymbol(variable->getUniqueId(), identifier, type); |
| 2551 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2552 | declarationOut->appendDeclarator(symbol); |
| 2553 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2554 | } |
| 2555 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2556 | void TParseContext::parseArrayDeclarator(TPublicType &publicType, |
| 2557 | const TSourceLoc &identifierLocation, |
| 2558 | const TString &identifier, |
| 2559 | const TSourceLoc &arrayLocation, |
| 2560 | TIntermTyped *indexExpression, |
| 2561 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2562 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2563 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2564 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2565 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2566 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2567 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2568 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2569 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2570 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2571 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2572 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2573 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, &publicType); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2574 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2575 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, publicType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2576 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 2577 | TType arrayType = TType(publicType); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2578 | unsigned int size = checkIsValidArraySize(arrayLocation, indexExpression); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 2579 | arrayType.makeArray(size); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2580 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2581 | if (IsAtomicCounter(publicType.getBasicType())) |
| 2582 | { |
| 2583 | checkAtomicCounterOffsetIsNotOverlapped(publicType, kAtomicCounterArrayStride * size, |
| 2584 | true, identifierLocation, arrayType); |
| 2585 | } |
| 2586 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2587 | TVariable *variable = nullptr; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2588 | declareVariable(identifierLocation, identifier, arrayType, &variable); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2589 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2590 | if (variable) |
Olli Etuaho | d7ceaa1 | 2017-07-12 17:46:35 +0300 | [diff] [blame] | 2591 | { |
| 2592 | TIntermSymbol *symbol = |
| 2593 | new TIntermSymbol(variable->getUniqueId(), identifier, arrayType); |
| 2594 | symbol->setLine(identifierLocation); |
| 2595 | declarationOut->appendDeclarator(symbol); |
| 2596 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2597 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2598 | } |
| 2599 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2600 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2601 | const TSourceLoc &identifierLocation, |
| 2602 | const TString &identifier, |
| 2603 | const TSourceLoc &initLocation, |
| 2604 | TIntermTyped *initializer, |
| 2605 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2606 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2607 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2608 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2609 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2610 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2611 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2612 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2613 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2614 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2615 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2616 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2617 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2618 | if (executeInitializer(identifierLocation, identifier, publicType, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2619 | { |
| 2620 | // |
| 2621 | // build the intermediate representation |
| 2622 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2623 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2624 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2625 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2626 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2627 | } |
| 2628 | } |
| 2629 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2630 | void TParseContext::parseArrayInitDeclarator(const TPublicType &publicType, |
| 2631 | const TSourceLoc &identifierLocation, |
| 2632 | const TString &identifier, |
| 2633 | const TSourceLoc &indexLocation, |
| 2634 | TIntermTyped *indexExpression, |
| 2635 | const TSourceLoc &initLocation, |
| 2636 | TIntermTyped *initializer, |
| 2637 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2638 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2639 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2640 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2641 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2642 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2643 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2644 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2645 | } |
| 2646 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2647 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2648 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 2649 | checkIsValidTypeAndQualifierForArray(indexLocation, publicType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2650 | |
| 2651 | TPublicType arrayType(publicType); |
| 2652 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2653 | unsigned int size = 0u; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2654 | // If indexExpression is nullptr, then the array will eventually get its size implicitly from |
| 2655 | // the initializer. |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 2656 | if (indexExpression != nullptr) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2657 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2658 | size = checkIsValidArraySize(identifierLocation, indexExpression); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2659 | } |
| 2660 | // Make the type an array even if size check failed. |
| 2661 | // This ensures useless error messages regarding the variable's non-arrayness won't follow. |
| 2662 | arrayType.setArraySize(size); |
| 2663 | |
| 2664 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2665 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2666 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2667 | { |
| 2668 | if (initNode) |
| 2669 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2670 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2671 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2672 | } |
| 2673 | } |
| 2674 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2675 | void TParseContext::setAtomicCounterBindingDefaultOffset(const TPublicType &publicType, |
| 2676 | const TSourceLoc &location) |
| 2677 | { |
| 2678 | const TLayoutQualifier &layoutQualifier = publicType.layoutQualifier; |
| 2679 | checkAtomicCounterBindingIsValid(location, layoutQualifier.binding); |
| 2680 | if (layoutQualifier.binding == -1 || layoutQualifier.offset == -1) |
| 2681 | { |
| 2682 | error(location, "Requires both binding and offset", "layout"); |
| 2683 | return; |
| 2684 | } |
| 2685 | mAtomicCounterBindingStates[layoutQualifier.binding].setDefaultOffset(layoutQualifier.offset); |
| 2686 | } |
| 2687 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2688 | void TParseContext::parseDefaultPrecisionQualifier(const TPrecision precision, |
| 2689 | const TPublicType &type, |
| 2690 | const TSourceLoc &loc) |
| 2691 | { |
| 2692 | if ((precision == EbpHigh) && (getShaderType() == GL_FRAGMENT_SHADER) && |
| 2693 | !getFragmentPrecisionHigh()) |
| 2694 | { |
| 2695 | error(loc, "precision is not supported in fragment shader", "highp"); |
| 2696 | } |
| 2697 | |
| 2698 | if (!CanSetDefaultPrecisionOnType(type)) |
| 2699 | { |
| 2700 | error(loc, "illegal type argument for default precision qualifier", |
| 2701 | getBasicString(type.getBasicType())); |
| 2702 | return; |
| 2703 | } |
| 2704 | symbolTable.setDefaultPrecision(type.getBasicType(), precision); |
| 2705 | } |
| 2706 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2707 | bool TParseContext::checkPrimitiveTypeMatchesTypeQualifier(const TTypeQualifier &typeQualifier) |
| 2708 | { |
| 2709 | switch (typeQualifier.layoutQualifier.primitiveType) |
| 2710 | { |
| 2711 | case EptLines: |
| 2712 | case EptLinesAdjacency: |
| 2713 | case EptTriangles: |
| 2714 | case EptTrianglesAdjacency: |
| 2715 | return typeQualifier.qualifier == EvqGeometryIn; |
| 2716 | |
| 2717 | case EptLineStrip: |
| 2718 | case EptTriangleStrip: |
| 2719 | return typeQualifier.qualifier == EvqGeometryOut; |
| 2720 | |
| 2721 | case EptPoints: |
| 2722 | return true; |
| 2723 | |
| 2724 | default: |
| 2725 | UNREACHABLE(); |
| 2726 | return false; |
| 2727 | } |
| 2728 | } |
| 2729 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2730 | void TParseContext::setGeometryShaderInputArraySizes() |
| 2731 | { |
| 2732 | // TODO(jiawei.shao@intel.com): check former input array sizes match the input primitive |
| 2733 | // declaration. |
| 2734 | ASSERT(mGeometryShaderInputArraySize == 0); |
| 2735 | mGeometryShaderInputArraySize = |
| 2736 | GetGeometryShaderInputArraySize(mGeometryShaderInputPrimitiveType); |
| 2737 | } |
| 2738 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2739 | bool TParseContext::parseGeometryShaderInputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2740 | { |
| 2741 | ASSERT(typeQualifier.qualifier == EvqGeometryIn); |
| 2742 | |
| 2743 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2744 | |
| 2745 | if (layoutQualifier.maxVertices != -1) |
| 2746 | { |
| 2747 | error(typeQualifier.line, |
| 2748 | "max_vertices can only be declared in 'out' layout in a geometry shader", "layout"); |
| 2749 | return false; |
| 2750 | } |
| 2751 | |
| 2752 | // Set mGeometryInputPrimitiveType if exists |
| 2753 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2754 | { |
| 2755 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2756 | { |
| 2757 | error(typeQualifier.line, "invalid primitive type for 'in' layout", "layout"); |
| 2758 | return false; |
| 2759 | } |
| 2760 | |
| 2761 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 2762 | { |
| 2763 | mGeometryShaderInputPrimitiveType = layoutQualifier.primitiveType; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2764 | setGeometryShaderInputArraySizes(); |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2765 | } |
| 2766 | else if (mGeometryShaderInputPrimitiveType != layoutQualifier.primitiveType) |
| 2767 | { |
| 2768 | error(typeQualifier.line, "primitive doesn't match earlier input primitive declaration", |
| 2769 | "layout"); |
| 2770 | return false; |
| 2771 | } |
| 2772 | } |
| 2773 | |
| 2774 | // Set mGeometryInvocations if exists |
| 2775 | if (layoutQualifier.invocations > 0) |
| 2776 | { |
| 2777 | if (mGeometryShaderInvocations == 0) |
| 2778 | { |
| 2779 | mGeometryShaderInvocations = layoutQualifier.invocations; |
| 2780 | } |
| 2781 | else if (mGeometryShaderInvocations != layoutQualifier.invocations) |
| 2782 | { |
| 2783 | error(typeQualifier.line, "invocations contradicts to the earlier declaration", |
| 2784 | "layout"); |
| 2785 | return false; |
| 2786 | } |
| 2787 | } |
| 2788 | |
| 2789 | return true; |
| 2790 | } |
| 2791 | |
| 2792 | bool TParseContext::parseGeometryShaderOutputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2793 | { |
| 2794 | ASSERT(typeQualifier.qualifier == EvqGeometryOut); |
| 2795 | |
| 2796 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2797 | |
| 2798 | if (layoutQualifier.invocations > 0) |
| 2799 | { |
| 2800 | error(typeQualifier.line, |
| 2801 | "invocations can only be declared in 'in' layout in a geometry shader", "layout"); |
| 2802 | return false; |
| 2803 | } |
| 2804 | |
| 2805 | // Set mGeometryOutputPrimitiveType if exists |
| 2806 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2807 | { |
| 2808 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2809 | { |
| 2810 | error(typeQualifier.line, "invalid primitive type for 'out' layout", "layout"); |
| 2811 | return false; |
| 2812 | } |
| 2813 | |
| 2814 | if (mGeometryShaderOutputPrimitiveType == EptUndefined) |
| 2815 | { |
| 2816 | mGeometryShaderOutputPrimitiveType = layoutQualifier.primitiveType; |
| 2817 | } |
| 2818 | else if (mGeometryShaderOutputPrimitiveType != layoutQualifier.primitiveType) |
| 2819 | { |
| 2820 | error(typeQualifier.line, |
| 2821 | "primitive doesn't match earlier output primitive declaration", "layout"); |
| 2822 | return false; |
| 2823 | } |
| 2824 | } |
| 2825 | |
| 2826 | // Set mGeometryMaxVertices if exists |
| 2827 | if (layoutQualifier.maxVertices > -1) |
| 2828 | { |
| 2829 | if (mGeometryShaderMaxVertices == -1) |
| 2830 | { |
| 2831 | mGeometryShaderMaxVertices = layoutQualifier.maxVertices; |
| 2832 | } |
| 2833 | else if (mGeometryShaderMaxVertices != layoutQualifier.maxVertices) |
| 2834 | { |
| 2835 | error(typeQualifier.line, "max_vertices contradicts to the earlier declaration", |
| 2836 | "layout"); |
| 2837 | return false; |
| 2838 | } |
| 2839 | } |
| 2840 | |
| 2841 | return true; |
| 2842 | } |
| 2843 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2844 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2845 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2846 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2847 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2848 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2849 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2850 | typeQualifier.line); |
| 2851 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2852 | // It should never be the case, but some strange parser errors can send us here. |
| 2853 | if (layoutQualifier.isEmpty()) |
| 2854 | { |
| 2855 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2856 | return; |
| 2857 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2858 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2859 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2860 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2861 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2862 | return; |
| 2863 | } |
| 2864 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2865 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2866 | |
| 2867 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2868 | |
| 2869 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2870 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2871 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2872 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2873 | checkOffsetIsNotSpecified(typeQualifier.line, layoutQualifier.offset); |
| 2874 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2875 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2876 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2877 | if (mComputeShaderLocalSizeDeclared && |
| 2878 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 2879 | { |
| 2880 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 2881 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2882 | return; |
| 2883 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2884 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2885 | if (mShaderVersion < 310) |
| 2886 | { |
| 2887 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2888 | return; |
| 2889 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2890 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 2891 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2892 | { |
| 2893 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2894 | return; |
| 2895 | } |
| 2896 | |
| 2897 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
| 2898 | symbolTable.findBuiltIn("gl_MaxComputeWorkGroupSize", mShaderVersion)); |
| 2899 | |
| 2900 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 2901 | maxComputeWorkGroupSize->getConstPointer(); |
| 2902 | |
| 2903 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 2904 | { |
| 2905 | if (layoutQualifier.localSize[i] != -1) |
| 2906 | { |
| 2907 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 2908 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 2909 | if (mComputeShaderLocalSize[i] < 1 || |
| 2910 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 2911 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2912 | std::stringstream reasonStream; |
| 2913 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 2914 | << maxComputeWorkGroupSizeValue; |
| 2915 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2916 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2917 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2918 | return; |
| 2919 | } |
| 2920 | } |
| 2921 | } |
| 2922 | |
| 2923 | mComputeShaderLocalSizeDeclared = true; |
| 2924 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2925 | else if (typeQualifier.qualifier == EvqGeometryIn) |
| 2926 | { |
| 2927 | if (mShaderVersion < 310) |
| 2928 | { |
| 2929 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
| 2930 | return; |
| 2931 | } |
| 2932 | |
| 2933 | if (!parseGeometryShaderInputLayoutQualifier(typeQualifier)) |
| 2934 | { |
| 2935 | return; |
| 2936 | } |
| 2937 | } |
| 2938 | else if (typeQualifier.qualifier == EvqGeometryOut) |
| 2939 | { |
| 2940 | if (mShaderVersion < 310) |
| 2941 | { |
| 2942 | error(typeQualifier.line, "out type qualifier supported in GLSL ES 3.10 only", |
| 2943 | "layout"); |
| 2944 | return; |
| 2945 | } |
| 2946 | |
| 2947 | if (!parseGeometryShaderOutputLayoutQualifier(typeQualifier)) |
| 2948 | { |
| 2949 | return; |
| 2950 | } |
| 2951 | } |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 2952 | else if (isMultiviewExtensionEnabled() && typeQualifier.qualifier == EvqVertexIn) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2953 | { |
| 2954 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 2955 | // specification. |
| 2956 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 2957 | { |
| 2958 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 2959 | "layout"); |
| 2960 | return; |
| 2961 | } |
| 2962 | |
| 2963 | if (layoutQualifier.numViews == -1) |
| 2964 | { |
| 2965 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 2966 | return; |
| 2967 | } |
| 2968 | |
| 2969 | if (layoutQualifier.numViews > mMaxNumViews) |
| 2970 | { |
| 2971 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 2972 | "layout"); |
| 2973 | return; |
| 2974 | } |
| 2975 | |
| 2976 | mNumViews = layoutQualifier.numViews; |
| 2977 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2978 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 2979 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2980 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2981 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2982 | return; |
| 2983 | } |
| 2984 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2985 | if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2986 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2987 | error(typeQualifier.line, "invalid qualifier: global layout can only be set for blocks", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 2988 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2989 | return; |
| 2990 | } |
| 2991 | |
| 2992 | if (mShaderVersion < 300) |
| 2993 | { |
| 2994 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 2995 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2996 | return; |
| 2997 | } |
| 2998 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 2999 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3000 | |
| 3001 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 3002 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3003 | if (typeQualifier.qualifier == EvqUniform) |
| 3004 | { |
| 3005 | mDefaultUniformMatrixPacking = layoutQualifier.matrixPacking; |
| 3006 | } |
| 3007 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3008 | { |
| 3009 | mDefaultBufferMatrixPacking = layoutQualifier.matrixPacking; |
| 3010 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3011 | } |
| 3012 | |
| 3013 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 3014 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3015 | if (typeQualifier.qualifier == EvqUniform) |
| 3016 | { |
| 3017 | mDefaultUniformBlockStorage = layoutQualifier.blockStorage; |
| 3018 | } |
| 3019 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3020 | { |
| 3021 | mDefaultBufferBlockStorage = layoutQualifier.blockStorage; |
| 3022 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3023 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3024 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3025 | } |
| 3026 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3027 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 3028 | const TFunction &function, |
| 3029 | const TSourceLoc &location, |
| 3030 | bool insertParametersToSymbolTable) |
| 3031 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 3032 | checkIsNotReserved(location, function.getName()); |
| 3033 | |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 3034 | TIntermFunctionPrototype *prototype = |
| 3035 | new TIntermFunctionPrototype(function.getReturnType(), TSymbolUniqueId(function)); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3036 | // TODO(oetuaho@nvidia.com): Instead of converting the function information here, the node could |
| 3037 | // point to the data that already exists in the symbol table. |
| 3038 | prototype->getFunctionSymbolInfo()->setFromFunction(function); |
| 3039 | prototype->setLine(location); |
| 3040 | |
| 3041 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 3042 | { |
| 3043 | const TConstParameter ¶m = function.getParam(i); |
| 3044 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3045 | TIntermSymbol *symbol = nullptr; |
| 3046 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3047 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 3048 | // be used for unused args). |
| 3049 | if (param.name != nullptr) |
| 3050 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3051 | // Insert the parameter in the symbol table. |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3052 | if (insertParametersToSymbolTable) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3053 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3054 | TVariable *variable = symbolTable.declareVariable(param.name, *param.type); |
| 3055 | if (variable) |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3056 | { |
| 3057 | symbol = new TIntermSymbol(variable->getUniqueId(), variable->getName(), |
| 3058 | variable->getType()); |
| 3059 | } |
| 3060 | else |
| 3061 | { |
Olli Etuaho | 85d624a | 2017-08-07 13:42:33 +0300 | [diff] [blame] | 3062 | error(location, "redefinition", param.name->c_str()); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3063 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3064 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3065 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3066 | if (!symbol) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3067 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3068 | // The parameter had no name or declaring the symbol failed - either way, add a nameless |
| 3069 | // symbol. |
| 3070 | symbol = new TIntermSymbol(0, "", *param.type); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3071 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3072 | symbol->setLine(location); |
| 3073 | prototype->appendParameter(symbol); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3074 | } |
| 3075 | return prototype; |
| 3076 | } |
| 3077 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 3078 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 3079 | const TFunction &parsedFunction, |
| 3080 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3081 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3082 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 3083 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 3084 | // function is declared multiple times. |
| 3085 | TFunction *function = static_cast<TFunction *>( |
| 3086 | symbolTable.find(parsedFunction.getMangledName(), getShaderVersion())); |
| 3087 | if (function->hasPrototypeDeclaration() && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3088 | { |
| 3089 | // ESSL 1.00.17 section 4.2.7. |
| 3090 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 3091 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3092 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3093 | function->setHasPrototypeDeclaration(); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3094 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3095 | TIntermFunctionPrototype *prototype = |
| 3096 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3097 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3098 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3099 | |
| 3100 | if (!symbolTable.atGlobalLevel()) |
| 3101 | { |
| 3102 | // ESSL 3.00.4 section 4.2.4. |
| 3103 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3104 | } |
| 3105 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3106 | return prototype; |
| 3107 | } |
| 3108 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3109 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3110 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3111 | TIntermBlock *functionBody, |
| 3112 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3113 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3114 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3115 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 3116 | { |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3117 | error(location, "function does not return a value:", |
| 3118 | functionPrototype->getFunctionSymbolInfo()->getName().c_str()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3119 | } |
| 3120 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3121 | if (functionBody == nullptr) |
| 3122 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3123 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3124 | functionBody->setLine(location); |
| 3125 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3126 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3127 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3128 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3129 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3130 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3131 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3132 | } |
| 3133 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3134 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
| 3135 | TFunction **function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3136 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3137 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3138 | ASSERT(function); |
| 3139 | ASSERT(*function); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3140 | const TSymbol *builtIn = |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3141 | symbolTable.findBuiltIn((*function)->getMangledName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3142 | |
| 3143 | if (builtIn) |
| 3144 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3145 | error(location, "built-in functions cannot be redefined", (*function)->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3146 | } |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3147 | else |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3148 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3149 | TFunction *prevDec = static_cast<TFunction *>( |
| 3150 | symbolTable.find((*function)->getMangledName(), getShaderVersion())); |
| 3151 | |
| 3152 | // Note: 'prevDec' could be 'function' if this is the first time we've seen function as it |
| 3153 | // would have just been put in the symbol table. Otherwise, we're looking up an earlier |
| 3154 | // occurance. |
| 3155 | if (*function != prevDec) |
| 3156 | { |
| 3157 | // Swap the parameters of the previous declaration to the parameters of the function |
| 3158 | // definition (parameter names may differ). |
| 3159 | prevDec->swapParameters(**function); |
| 3160 | |
| 3161 | // The function definition will share the same symbol as any previous declaration. |
| 3162 | *function = prevDec; |
| 3163 | } |
| 3164 | |
| 3165 | if ((*function)->isDefined()) |
| 3166 | { |
| 3167 | error(location, "function already has a body", (*function)->getName().c_str()); |
| 3168 | } |
| 3169 | |
| 3170 | (*function)->setDefined(); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3171 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3172 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3173 | // Remember the return type for later checking for return statements. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3174 | mCurrentFunctionType = &((*function)->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3175 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3176 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3177 | *prototypeOut = createPrototypeNodeFromFunction(**function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3178 | setLoopNestingLevel(0); |
| 3179 | } |
| 3180 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3181 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3182 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3183 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3184 | // We don't know at this point whether this is a function definition or a prototype. |
| 3185 | // The definition production code will check for redefinitions. |
| 3186 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3187 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3188 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 3189 | // here. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3190 | // |
| 3191 | TFunction *prevDec = |
| 3192 | static_cast<TFunction *>(symbolTable.find(function->getMangledName(), getShaderVersion())); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3193 | |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 3194 | if (getShaderVersion() >= 300 && |
| 3195 | symbolTable.hasUnmangledBuiltInForShaderVersion(function->getName().c_str(), |
| 3196 | getShaderVersion())) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3197 | { |
Martin Radev | da6254b | 2016-12-14 17:00:36 +0200 | [diff] [blame] | 3198 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as functions. |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3199 | // Therefore overloading or redefining builtin functions is an error. |
| 3200 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 3201 | function->getName().c_str()); |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3202 | } |
| 3203 | else if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3204 | { |
| 3205 | if (prevDec->getReturnType() != function->getReturnType()) |
| 3206 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3207 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3208 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3209 | } |
| 3210 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 3211 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3212 | if (prevDec->getParam(i).type->getQualifier() != |
| 3213 | function->getParam(i).type->getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3214 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3215 | error(location, |
| 3216 | "function must have the same parameter qualifiers in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3217 | function->getParam(i).type->getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3218 | } |
| 3219 | } |
| 3220 | } |
| 3221 | |
| 3222 | // |
| 3223 | // Check for previously declared variables using the same name. |
| 3224 | // |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3225 | TSymbol *prevSym = symbolTable.find(function->getName(), getShaderVersion()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3226 | if (prevSym) |
| 3227 | { |
| 3228 | if (!prevSym->isFunction()) |
| 3229 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3230 | error(location, "redefinition of a function", function->getName().c_str()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3231 | } |
| 3232 | } |
| 3233 | else |
| 3234 | { |
| 3235 | // Insert the unmangled name to detect potential future redefinition as a variable. |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3236 | symbolTable.getOuterLevel()->insertUnmangled(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3237 | } |
| 3238 | |
| 3239 | // We're at the inner scope level of the function's arguments and body statement. |
| 3240 | // Add the function prototype to the surrounding scope instead. |
| 3241 | symbolTable.getOuterLevel()->insert(function); |
| 3242 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 3243 | // Raise error message if main function takes any parameters or return anything other than void |
| 3244 | if (function->getName() == "main") |
| 3245 | { |
| 3246 | if (function->getParamCount() > 0) |
| 3247 | { |
| 3248 | error(location, "function cannot take any parameter(s)", "main"); |
| 3249 | } |
| 3250 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 3251 | { |
| 3252 | error(location, "main function cannot return a value", |
| 3253 | function->getReturnType().getBasicString()); |
| 3254 | } |
| 3255 | } |
| 3256 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3257 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3258 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 3259 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3260 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 3261 | // |
| 3262 | return function; |
| 3263 | } |
| 3264 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3265 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
| 3266 | const TString *name, |
| 3267 | const TSourceLoc &location) |
| 3268 | { |
| 3269 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 3270 | { |
| 3271 | error(location, "no qualifiers allowed for function return", |
| 3272 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3273 | } |
| 3274 | if (!type.layoutQualifier.isEmpty()) |
| 3275 | { |
| 3276 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3277 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3278 | // make sure an opaque type is not involved as well... |
| 3279 | std::string reason(getBasicString(type.getBasicType())); |
| 3280 | reason += "s can't be function return values"; |
| 3281 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3282 | if (mShaderVersion < 300) |
| 3283 | { |
| 3284 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 3285 | // return values in ESSL 1.00. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3286 | ASSERT(type.arraySize == 0 || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3287 | |
| 3288 | if (type.isStructureContainingArrays()) |
| 3289 | { |
| 3290 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 3291 | error(location, "structures containing arrays can't be function return values", |
| 3292 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3293 | } |
| 3294 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3295 | |
| 3296 | // Add the function as a prototype after parsing it (we do not support recursion) |
Olli Etuaho | a5e693a | 2017-07-13 16:07:26 +0300 | [diff] [blame] | 3297 | return new TFunction(&symbolTable, name, new TType(type)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3298 | } |
| 3299 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3300 | TFunction *TParseContext::addNonConstructorFunc(const TString *name, const TSourceLoc &loc) |
| 3301 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3302 | const TType *returnType = TCache::getType(EbtVoid, EbpUndefined); |
Olli Etuaho | a5e693a | 2017-07-13 16:07:26 +0300 | [diff] [blame] | 3303 | return new TFunction(&symbolTable, name, returnType); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3304 | } |
| 3305 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3306 | TFunction *TParseContext::addConstructorFunc(const TPublicType &publicType) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3307 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3308 | if (mShaderVersion < 300 && publicType.array) |
| 3309 | { |
| 3310 | error(publicType.getLine(), "array constructor supported in GLSL ES 3.00 and above only", |
| 3311 | "[]"); |
| 3312 | } |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3313 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3314 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3315 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 3316 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3317 | } |
| 3318 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3319 | TType *type = new TType(publicType); |
| 3320 | if (!type->canBeConstructed()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3321 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3322 | error(publicType.getLine(), "cannot construct this type", |
| 3323 | getBasicString(publicType.getBasicType())); |
| 3324 | type->setBasicType(EbtFloat); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3325 | } |
| 3326 | |
Olli Etuaho | a5e693a | 2017-07-13 16:07:26 +0300 | [diff] [blame] | 3327 | return new TFunction(&symbolTable, nullptr, type, EOpConstruct); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3328 | } |
| 3329 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3330 | TParameter TParseContext::parseParameterDeclarator(const TPublicType &publicType, |
| 3331 | const TString *name, |
| 3332 | const TSourceLoc &nameLoc) |
| 3333 | { |
| 3334 | if (publicType.getBasicType() == EbtVoid) |
| 3335 | { |
| 3336 | error(nameLoc, "illegal use of type 'void'", name->c_str()); |
| 3337 | } |
| 3338 | checkIsNotReserved(nameLoc, *name); |
| 3339 | TType *type = new TType(publicType); |
| 3340 | TParameter param = {name, type}; |
| 3341 | return param; |
| 3342 | } |
| 3343 | |
| 3344 | TParameter TParseContext::parseParameterArrayDeclarator(const TString *identifier, |
| 3345 | const TSourceLoc &identifierLoc, |
| 3346 | TIntermTyped *arraySize, |
| 3347 | const TSourceLoc &arrayLoc, |
| 3348 | TPublicType *type) |
| 3349 | { |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 3350 | checkArrayElementIsNotArray(arrayLoc, *type); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3351 | unsigned int size = checkIsValidArraySize(arrayLoc, arraySize); |
| 3352 | type->setArraySize(size); |
| 3353 | return parseParameterDeclarator(*type, identifier, identifierLoc); |
| 3354 | } |
| 3355 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3356 | bool TParseContext::checkUnsizedArrayConstructorArgumentDimensionality(TIntermSequence *arguments, |
| 3357 | TType type, |
| 3358 | const TSourceLoc &line) |
| 3359 | { |
| 3360 | if (arguments->empty()) |
| 3361 | { |
| 3362 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 3363 | return false; |
| 3364 | } |
| 3365 | for (TIntermNode *arg : *arguments) |
| 3366 | { |
| 3367 | TIntermTyped *element = arg->getAsTyped(); |
| 3368 | ASSERT(element); |
| 3369 | size_t dimensionalityFromElement = element->getType().getArraySizes().size() + 1u; |
| 3370 | if (dimensionalityFromElement > type.getArraySizes().size()) |
| 3371 | { |
| 3372 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 3373 | return false; |
| 3374 | } |
| 3375 | else if (dimensionalityFromElement < type.getArraySizes().size()) |
| 3376 | { |
| 3377 | if (dimensionalityFromElement == 1u) |
| 3378 | { |
| 3379 | error(line, "implicitly sized array of arrays constructor argument is not an array", |
| 3380 | "constructor"); |
| 3381 | } |
| 3382 | else |
| 3383 | { |
| 3384 | error(line, |
| 3385 | "implicitly sized array of arrays constructor argument dimensionality is too " |
| 3386 | "low", |
| 3387 | "constructor"); |
| 3388 | } |
| 3389 | return false; |
| 3390 | } |
| 3391 | } |
| 3392 | return true; |
| 3393 | } |
| 3394 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3395 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 3396 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3397 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3398 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3399 | // |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3400 | TIntermTyped *TParseContext::addConstructor(TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 3401 | TType type, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3402 | const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3403 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3404 | if (type.isUnsizedArray()) |
| 3405 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3406 | if (!checkUnsizedArrayConstructorArgumentDimensionality(arguments, type, line)) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3407 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3408 | type.sizeUnsizedArrays(TVector<unsigned int>()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3409 | return CreateZeroNode(type); |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3410 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3411 | TIntermTyped *firstElement = arguments->at(0)->getAsTyped(); |
| 3412 | ASSERT(firstElement); |
| 3413 | type.setArraySize(type.getArraySizes().size() - 1u, |
| 3414 | static_cast<unsigned int>(arguments->size())); |
| 3415 | for (size_t i = 0; i < firstElement->getType().getArraySizes().size(); ++i) |
| 3416 | { |
| 3417 | if (type.getArraySizes()[i] == 0u) |
| 3418 | { |
| 3419 | type.setArraySize(i, firstElement->getType().getArraySizes().at(i)); |
| 3420 | } |
| 3421 | } |
| 3422 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3423 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3424 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3425 | if (!checkConstructorArguments(line, arguments, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3426 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3427 | return CreateZeroNode(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3428 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3429 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3430 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3431 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3432 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3433 | // TODO(oetuaho@nvidia.com): Add support for folding array constructors. |
| 3434 | if (!constructorNode->isArray()) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3435 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3436 | return constructorNode->fold(mDiagnostics); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3437 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3438 | return constructorNode; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3439 | } |
| 3440 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3441 | // |
| 3442 | // Interface/uniform blocks |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3443 | // TODO(jiawei.shao@intel.com): implement GL_OES_shader_io_blocks. |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3444 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3445 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3446 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3447 | const TSourceLoc &nameLine, |
| 3448 | const TString &blockName, |
| 3449 | TFieldList *fieldList, |
| 3450 | const TString *instanceName, |
| 3451 | const TSourceLoc &instanceLine, |
| 3452 | TIntermTyped *arrayIndex, |
| 3453 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3454 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3455 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3456 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3457 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3458 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3459 | if (mShaderVersion < 310 && typeQualifier.qualifier != EvqUniform) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3460 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3461 | error(typeQualifier.line, |
| 3462 | "invalid qualifier: interface blocks must be uniform in version lower than GLSL ES " |
| 3463 | "3.10", |
| 3464 | getQualifierString(typeQualifier.qualifier)); |
| 3465 | } |
| 3466 | else if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
| 3467 | { |
| 3468 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform or buffer", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3469 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3470 | } |
| 3471 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3472 | if (typeQualifier.invariant) |
| 3473 | { |
| 3474 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 3475 | } |
| 3476 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3477 | if (typeQualifier.qualifier != EvqBuffer) |
| 3478 | { |
| 3479 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 3480 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3481 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3482 | // add array index |
| 3483 | unsigned int arraySize = 0; |
| 3484 | if (arrayIndex != nullptr) |
| 3485 | { |
| 3486 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
| 3487 | } |
| 3488 | |
| 3489 | if (mShaderVersion < 310) |
| 3490 | { |
| 3491 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
| 3492 | } |
| 3493 | else |
| 3494 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3495 | checkBlockBindingIsValid(typeQualifier.line, typeQualifier.qualifier, |
| 3496 | typeQualifier.layoutQualifier.binding, arraySize); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3497 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3498 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3499 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 3500 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3501 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3502 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3503 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3504 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 3505 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3506 | if (typeQualifier.qualifier == EvqUniform) |
| 3507 | { |
| 3508 | blockLayoutQualifier.matrixPacking = mDefaultUniformMatrixPacking; |
| 3509 | } |
| 3510 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3511 | { |
| 3512 | blockLayoutQualifier.matrixPacking = mDefaultBufferMatrixPacking; |
| 3513 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3514 | } |
| 3515 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3516 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 3517 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3518 | if (typeQualifier.qualifier == EvqUniform) |
| 3519 | { |
| 3520 | blockLayoutQualifier.blockStorage = mDefaultUniformBlockStorage; |
| 3521 | } |
| 3522 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3523 | { |
| 3524 | blockLayoutQualifier.blockStorage = mDefaultBufferBlockStorage; |
| 3525 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3526 | } |
| 3527 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3528 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3529 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3530 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 3531 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3532 | if (!symbolTable.declareInterfaceBlockName(&blockName)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3533 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3534 | error(nameLine, "redefinition of an interface block name", blockName.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3535 | } |
| 3536 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3537 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3538 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3539 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3540 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3541 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3542 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3543 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3544 | std::string reason("unsupported type - "); |
| 3545 | reason += fieldType->getBasicString(); |
| 3546 | reason += " types are not allowed in interface blocks"; |
| 3547 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3548 | } |
| 3549 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3550 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3551 | switch (qualifier) |
| 3552 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3553 | case EvqGlobal: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3554 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3555 | case EvqUniform: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3556 | if (typeQualifier.qualifier == EvqBuffer) |
| 3557 | { |
| 3558 | error(field->line(), "invalid qualifier on shader storage block member", |
| 3559 | getQualifierString(qualifier)); |
| 3560 | } |
| 3561 | break; |
| 3562 | case EvqBuffer: |
| 3563 | if (typeQualifier.qualifier == EvqUniform) |
| 3564 | { |
| 3565 | error(field->line(), "invalid qualifier on uniform block member", |
| 3566 | getQualifierString(qualifier)); |
| 3567 | } |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3568 | break; |
| 3569 | default: |
| 3570 | error(field->line(), "invalid qualifier on interface block member", |
| 3571 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3572 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3573 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3574 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3575 | if (fieldType->isInvariant()) |
| 3576 | { |
| 3577 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 3578 | } |
| 3579 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3580 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3581 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3582 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3583 | checkBindingIsNotSpecified(field->line(), fieldLayoutQualifier.binding); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3584 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3585 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3586 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3587 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 3588 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3589 | } |
| 3590 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3591 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3592 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3593 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3594 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 3595 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3596 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3597 | warning(field->line(), |
| 3598 | "extraneous layout qualifier: only has an effect on matrix types", |
| 3599 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3600 | } |
| 3601 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3602 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3603 | |
| 3604 | if (typeQualifier.qualifier == EvqBuffer) |
| 3605 | { |
| 3606 | // set memory qualifiers |
| 3607 | // GLSL ES 3.10 session 4.9 [Memory Access Qualifiers]. When a block declaration is |
| 3608 | // qualified with a memory qualifier, it is as if all of its members were declared with |
| 3609 | // the same memory qualifier. |
| 3610 | const TMemoryQualifier &blockMemoryQualifier = typeQualifier.memoryQualifier; |
| 3611 | TMemoryQualifier fieldMemoryQualifier = fieldType->getMemoryQualifier(); |
| 3612 | fieldMemoryQualifier.readonly |= blockMemoryQualifier.readonly; |
| 3613 | fieldMemoryQualifier.writeonly |= blockMemoryQualifier.writeonly; |
| 3614 | fieldMemoryQualifier.coherent |= blockMemoryQualifier.coherent; |
| 3615 | fieldMemoryQualifier.restrictQualifier |= blockMemoryQualifier.restrictQualifier; |
| 3616 | fieldMemoryQualifier.volatileQualifier |= blockMemoryQualifier.volatileQualifier; |
| 3617 | // TODO(jiajia.qin@intel.com): Decide whether if readonly and writeonly buffer variable |
| 3618 | // is legal. See bug https://github.com/KhronosGroup/OpenGL-API/issues/7 |
| 3619 | fieldType->setMemoryQualifier(fieldMemoryQualifier); |
| 3620 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3621 | } |
| 3622 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3623 | TInterfaceBlock *interfaceBlock = |
Shao | b18c33e | 2017-08-16 12:37:51 +0800 | [diff] [blame] | 3624 | new TInterfaceBlock(&blockName, fieldList, instanceName, blockLayoutQualifier); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3625 | TType interfaceBlockType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier); |
| 3626 | if (arrayIndex != nullptr) |
| 3627 | { |
| 3628 | interfaceBlockType.makeArray(arraySize); |
| 3629 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3630 | |
| 3631 | TString symbolName = ""; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3632 | int symbolId = 0; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3633 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3634 | if (!instanceName) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3635 | { |
| 3636 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3637 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3638 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3639 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3640 | TType *fieldType = field->type(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3641 | |
| 3642 | // set parent pointer of the field variable |
| 3643 | fieldType->setInterfaceBlock(interfaceBlock); |
| 3644 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3645 | TVariable *fieldVariable = symbolTable.declareVariable(&field->name(), *fieldType); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3646 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3647 | if (fieldVariable) |
| 3648 | { |
| 3649 | fieldVariable->setQualifier(typeQualifier.qualifier); |
| 3650 | } |
| 3651 | else |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3652 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3653 | error(field->line(), "redefinition of an interface block member name", |
| 3654 | field->name().c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3655 | } |
| 3656 | } |
| 3657 | } |
| 3658 | else |
| 3659 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3660 | checkIsNotReserved(instanceLine, *instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 3661 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3662 | // add a symbol for this interface block |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3663 | TVariable *instanceTypeDef = symbolTable.declareVariable(instanceName, interfaceBlockType); |
| 3664 | if (instanceTypeDef) |
| 3665 | { |
| 3666 | instanceTypeDef->setQualifier(typeQualifier.qualifier); |
| 3667 | symbolId = instanceTypeDef->getUniqueId(); |
| 3668 | } |
| 3669 | else |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3670 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3671 | error(instanceLine, "redefinition of an interface block instance name", |
| 3672 | instanceName->c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3673 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 3674 | symbolName = *instanceName; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3675 | } |
| 3676 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3677 | TIntermSymbol *blockSymbol = new TIntermSymbol(symbolId, symbolName, interfaceBlockType); |
| 3678 | blockSymbol->setLine(typeQualifier.line); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3679 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 3680 | declaration->appendDeclarator(blockSymbol); |
| 3681 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3682 | |
| 3683 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3684 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3685 | } |
| 3686 | |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 3687 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, const TString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3688 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3689 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3690 | |
| 3691 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3692 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3693 | if (mStructNestingLevel > 1) |
| 3694 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3695 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3696 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3697 | } |
| 3698 | |
| 3699 | void TParseContext::exitStructDeclaration() |
| 3700 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3701 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3702 | } |
| 3703 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3704 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3705 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3706 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3707 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3708 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3709 | } |
| 3710 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3711 | if (field.type()->getBasicType() != EbtStruct) |
| 3712 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3713 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3714 | } |
| 3715 | |
| 3716 | // We're already inside a structure definition at this point, so add |
| 3717 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3718 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 3719 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3720 | std::stringstream reasonStream; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3721 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name().c_str() |
| 3722 | << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3723 | std::string reason = reasonStream.str(); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3724 | error(line, reason.c_str(), field.name().c_str()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3725 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3726 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3727 | } |
| 3728 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3729 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3730 | // Parse an array index expression |
| 3731 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3732 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 3733 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3734 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3735 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3736 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 3737 | { |
| 3738 | if (baseExpression->getAsSymbolNode()) |
| 3739 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3740 | error(location, " left of '[' is not of type array, matrix, or vector ", |
| 3741 | baseExpression->getAsSymbolNode()->getSymbol().c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3742 | } |
| 3743 | else |
| 3744 | { |
| 3745 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3746 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3747 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3748 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3749 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3750 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3751 | if (baseExpression->getQualifier() == EvqPerVertexIn) |
| 3752 | { |
| 3753 | ASSERT(mShaderType == GL_GEOMETRY_SHADER_OES); |
| 3754 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 3755 | { |
| 3756 | error(location, "missing input primitive declaration before indexing gl_in.", "["); |
| 3757 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 3758 | } |
| 3759 | } |
| 3760 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3761 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3762 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3763 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 3764 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 3765 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 3766 | // index is a constant expression. |
| 3767 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3768 | { |
| 3769 | if (baseExpression->isInterfaceBlock()) |
| 3770 | { |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3771 | // TODO(jiawei.shao@intel.com): implement GL_OES_shader_io_blocks. |
| 3772 | switch (baseExpression->getQualifier()) |
| 3773 | { |
| 3774 | case EvqPerVertexIn: |
| 3775 | break; |
| 3776 | case EvqUniform: |
| 3777 | case EvqBuffer: |
| 3778 | error(location, |
| 3779 | "array indexes for uniform block arrays and shader storage block arrays " |
| 3780 | "must be constant integral expressions", |
| 3781 | "["); |
| 3782 | break; |
| 3783 | default: |
| 3784 | UNREACHABLE(); |
| 3785 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3786 | } |
| 3787 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3788 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3789 | error(location, |
| 3790 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3791 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3792 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3793 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3794 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3795 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3796 | } |
| 3797 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3798 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3799 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3800 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3801 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3802 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3803 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3804 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3805 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 3806 | int index = 0; |
| 3807 | if (indexConstantUnion->getBasicType() == EbtInt) |
| 3808 | { |
| 3809 | index = indexConstantUnion->getIConst(0); |
| 3810 | } |
| 3811 | else if (indexConstantUnion->getBasicType() == EbtUInt) |
| 3812 | { |
| 3813 | index = static_cast<int>(indexConstantUnion->getUConst(0)); |
| 3814 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3815 | |
| 3816 | int safeIndex = -1; |
| 3817 | |
| 3818 | if (baseExpression->isArray()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3819 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3820 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3821 | { |
Olli Etuaho | daaff1c | 2017-07-05 18:03:26 +0300 | [diff] [blame] | 3822 | if (!isExtensionEnabled("GL_EXT_draw_buffers")) |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3823 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3824 | outOfRangeError(outOfRangeIndexIsError, location, |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3825 | "array index for gl_FragData must be zero when " |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3826 | "GL_EXT_draw_buffers is disabled", |
| 3827 | "["); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3828 | safeIndex = 0; |
| 3829 | } |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3830 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3831 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3832 | if (safeIndex < 0) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3833 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3834 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3835 | baseExpression->getOutermostArraySize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3836 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3837 | } |
| 3838 | } |
| 3839 | else if (baseExpression->isMatrix()) |
| 3840 | { |
| 3841 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3842 | baseExpression->getType().getCols(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3843 | "matrix field selection out of range"); |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3844 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3845 | else if (baseExpression->isVector()) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3846 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3847 | safeIndex = checkIndexOutOfRange(outOfRangeIndexIsError, location, index, |
| 3848 | baseExpression->getType().getNominalSize(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3849 | "vector field selection out of range"); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3850 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3851 | |
| 3852 | ASSERT(safeIndex >= 0); |
| 3853 | // Data of constant unions can't be changed, because it may be shared with other |
| 3854 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 3855 | // sanitized object. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 3856 | if (safeIndex != index || indexConstantUnion->getBasicType() != EbtInt) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3857 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3858 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 3859 | safeConstantUnion->setIConst(safeIndex); |
| 3860 | indexConstantUnion->replaceConstantUnion(safeConstantUnion); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 3861 | indexConstantUnion->getTypePointer()->setBasicType(EbtInt); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3862 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3863 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3864 | TIntermBinary *node = new TIntermBinary(EOpIndexDirect, baseExpression, indexExpression); |
| 3865 | node->setLine(location); |
| 3866 | return node->fold(mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3867 | } |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3868 | else |
| 3869 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3870 | TIntermBinary *node = new TIntermBinary(EOpIndexIndirect, baseExpression, indexExpression); |
| 3871 | node->setLine(location); |
| 3872 | // Indirect indexing can never be constant folded. |
| 3873 | return node; |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3874 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3875 | } |
| 3876 | |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3877 | int TParseContext::checkIndexOutOfRange(bool outOfRangeIndexIsError, |
| 3878 | const TSourceLoc &location, |
| 3879 | int index, |
| 3880 | int arraySize, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3881 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3882 | { |
| 3883 | if (index >= arraySize || index < 0) |
| 3884 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3885 | std::stringstream reasonStream; |
| 3886 | reasonStream << reason << " '" << index << "'"; |
| 3887 | std::string token = reasonStream.str(); |
| 3888 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3889 | if (index < 0) |
| 3890 | { |
| 3891 | return 0; |
| 3892 | } |
| 3893 | else |
| 3894 | { |
| 3895 | return arraySize - 1; |
| 3896 | } |
| 3897 | } |
| 3898 | return index; |
| 3899 | } |
| 3900 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3901 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 3902 | const TSourceLoc &dotLocation, |
| 3903 | const TString &fieldString, |
| 3904 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3905 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3906 | if (baseExpression->isArray()) |
| 3907 | { |
| 3908 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3909 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3910 | } |
| 3911 | |
| 3912 | if (baseExpression->isVector()) |
| 3913 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3914 | TVector<int> fieldOffsets; |
| 3915 | if (!parseVectorFields(fieldLocation, fieldString, baseExpression->getNominalSize(), |
| 3916 | &fieldOffsets)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3917 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3918 | fieldOffsets.resize(1); |
| 3919 | fieldOffsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3920 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3921 | TIntermSwizzle *node = new TIntermSwizzle(baseExpression, fieldOffsets); |
| 3922 | node->setLine(dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3923 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3924 | return node->fold(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3925 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3926 | else if (baseExpression->getBasicType() == EbtStruct) |
| 3927 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3928 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3929 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3930 | { |
| 3931 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3932 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3933 | } |
| 3934 | else |
| 3935 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3936 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3937 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3938 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3939 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3940 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3941 | { |
| 3942 | fieldFound = true; |
| 3943 | break; |
| 3944 | } |
| 3945 | } |
| 3946 | if (fieldFound) |
| 3947 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3948 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3949 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3950 | TIntermBinary *node = |
| 3951 | new TIntermBinary(EOpIndexDirectStruct, baseExpression, index); |
| 3952 | node->setLine(dotLocation); |
| 3953 | return node->fold(mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3954 | } |
| 3955 | else |
| 3956 | { |
| 3957 | error(dotLocation, " no such field in structure", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3958 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3959 | } |
| 3960 | } |
| 3961 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3962 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3963 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3964 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3965 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3966 | { |
| 3967 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3968 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3969 | } |
| 3970 | else |
| 3971 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3972 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3973 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3974 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3975 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3976 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3977 | { |
| 3978 | fieldFound = true; |
| 3979 | break; |
| 3980 | } |
| 3981 | } |
| 3982 | if (fieldFound) |
| 3983 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3984 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3985 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3986 | TIntermBinary *node = |
| 3987 | new TIntermBinary(EOpIndexDirectInterfaceBlock, baseExpression, index); |
| 3988 | node->setLine(dotLocation); |
| 3989 | // Indexing interface blocks can never be constant folded. |
| 3990 | return node; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3991 | } |
| 3992 | else |
| 3993 | { |
| 3994 | error(dotLocation, " no such field in interface block", fieldString.c_str()); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3995 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3996 | } |
| 3997 | } |
| 3998 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3999 | else |
| 4000 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4001 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4002 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4003 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4004 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4005 | } |
| 4006 | else |
| 4007 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4008 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4009 | " field selection requires structure, vector, or interface block on left hand " |
| 4010 | "side", |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4011 | fieldString.c_str()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4012 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4013 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4014 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4015 | } |
| 4016 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4017 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 4018 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4019 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4020 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4021 | |
| 4022 | if (qualifierType == "shared") |
| 4023 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4024 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4025 | { |
| 4026 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 4027 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4028 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4029 | } |
| 4030 | else if (qualifierType == "packed") |
| 4031 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4032 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4033 | { |
| 4034 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 4035 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4036 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4037 | } |
| 4038 | else if (qualifierType == "std140") |
| 4039 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4040 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4041 | } |
| 4042 | else if (qualifierType == "row_major") |
| 4043 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4044 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4045 | } |
| 4046 | else if (qualifierType == "column_major") |
| 4047 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4048 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4049 | } |
| 4050 | else if (qualifierType == "location") |
| 4051 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4052 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
| 4053 | qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4054 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 4055 | else if (qualifierType == "yuv" && isExtensionEnabled("GL_EXT_YUV_target") && |
| 4056 | mShaderType == GL_FRAGMENT_SHADER) |
| 4057 | { |
| 4058 | qualifier.yuv = true; |
| 4059 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4060 | else if (qualifierType == "rgba32f") |
| 4061 | { |
| 4062 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4063 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 4064 | } |
| 4065 | else if (qualifierType == "rgba16f") |
| 4066 | { |
| 4067 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4068 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 4069 | } |
| 4070 | else if (qualifierType == "r32f") |
| 4071 | { |
| 4072 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4073 | qualifier.imageInternalFormat = EiifR32F; |
| 4074 | } |
| 4075 | else if (qualifierType == "rgba8") |
| 4076 | { |
| 4077 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4078 | qualifier.imageInternalFormat = EiifRGBA8; |
| 4079 | } |
| 4080 | else if (qualifierType == "rgba8_snorm") |
| 4081 | { |
| 4082 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4083 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 4084 | } |
| 4085 | else if (qualifierType == "rgba32i") |
| 4086 | { |
| 4087 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4088 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 4089 | } |
| 4090 | else if (qualifierType == "rgba16i") |
| 4091 | { |
| 4092 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4093 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 4094 | } |
| 4095 | else if (qualifierType == "rgba8i") |
| 4096 | { |
| 4097 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4098 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 4099 | } |
| 4100 | else if (qualifierType == "r32i") |
| 4101 | { |
| 4102 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4103 | qualifier.imageInternalFormat = EiifR32I; |
| 4104 | } |
| 4105 | else if (qualifierType == "rgba32ui") |
| 4106 | { |
| 4107 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4108 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 4109 | } |
| 4110 | else if (qualifierType == "rgba16ui") |
| 4111 | { |
| 4112 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4113 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 4114 | } |
| 4115 | else if (qualifierType == "rgba8ui") |
| 4116 | { |
| 4117 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4118 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 4119 | } |
| 4120 | else if (qualifierType == "r32ui") |
| 4121 | { |
| 4122 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4123 | qualifier.imageInternalFormat = EiifR32UI; |
| 4124 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4125 | else if (qualifierType == "points" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4126 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4127 | { |
| 4128 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4129 | qualifier.primitiveType = EptPoints; |
| 4130 | } |
| 4131 | else if (qualifierType == "lines" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4132 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4133 | { |
| 4134 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4135 | qualifier.primitiveType = EptLines; |
| 4136 | } |
| 4137 | else if (qualifierType == "lines_adjacency" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4138 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4139 | { |
| 4140 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4141 | qualifier.primitiveType = EptLinesAdjacency; |
| 4142 | } |
| 4143 | else if (qualifierType == "triangles" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4144 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4145 | { |
| 4146 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4147 | qualifier.primitiveType = EptTriangles; |
| 4148 | } |
| 4149 | else if (qualifierType == "triangles_adjacency" && |
| 4150 | isExtensionEnabled("GL_OES_geometry_shader") && mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4151 | { |
| 4152 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4153 | qualifier.primitiveType = EptTrianglesAdjacency; |
| 4154 | } |
| 4155 | else if (qualifierType == "line_strip" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4156 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4157 | { |
| 4158 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4159 | qualifier.primitiveType = EptLineStrip; |
| 4160 | } |
| 4161 | else if (qualifierType == "triangle_strip" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4162 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4163 | { |
| 4164 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4165 | qualifier.primitiveType = EptTriangleStrip; |
| 4166 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4167 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4168 | else |
| 4169 | { |
| 4170 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4171 | } |
| 4172 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4173 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4174 | } |
| 4175 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4176 | void TParseContext::parseLocalSize(const TString &qualifierType, |
| 4177 | const TSourceLoc &qualifierTypeLine, |
| 4178 | int intValue, |
| 4179 | const TSourceLoc &intValueLine, |
| 4180 | const std::string &intValueString, |
| 4181 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 4182 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4183 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4184 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4185 | if (intValue < 1) |
| 4186 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4187 | std::stringstream reasonStream; |
| 4188 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 4189 | std::string reason = reasonStream.str(); |
| 4190 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4191 | } |
| 4192 | (*localSize)[index] = intValue; |
| 4193 | } |
| 4194 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4195 | void TParseContext::parseNumViews(int intValue, |
| 4196 | const TSourceLoc &intValueLine, |
| 4197 | const std::string &intValueString, |
| 4198 | int *numViews) |
| 4199 | { |
| 4200 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 4201 | // specification. |
| 4202 | if (intValue < 1) |
| 4203 | { |
| 4204 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 4205 | } |
| 4206 | *numViews = intValue; |
| 4207 | } |
| 4208 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4209 | void TParseContext::parseInvocations(int intValue, |
| 4210 | const TSourceLoc &intValueLine, |
| 4211 | const std::string &intValueString, |
| 4212 | int *numInvocations) |
| 4213 | { |
| 4214 | // Although SPEC isn't clear whether invocations can be less than 1, we add this limit because |
| 4215 | // it doesn't make sense to accept invocations <= 0. |
| 4216 | if (intValue < 1 || intValue > mMaxGeometryShaderInvocations) |
| 4217 | { |
| 4218 | error(intValueLine, |
| 4219 | "out of range: invocations must be in the range of [1, " |
| 4220 | "MAX_GEOMETRY_SHADER_INVOCATIONS_OES]", |
| 4221 | intValueString.c_str()); |
| 4222 | } |
| 4223 | else |
| 4224 | { |
| 4225 | *numInvocations = intValue; |
| 4226 | } |
| 4227 | } |
| 4228 | |
| 4229 | void TParseContext::parseMaxVertices(int intValue, |
| 4230 | const TSourceLoc &intValueLine, |
| 4231 | const std::string &intValueString, |
| 4232 | int *maxVertices) |
| 4233 | { |
| 4234 | // Although SPEC isn't clear whether max_vertices can be less than 0, we add this limit because |
| 4235 | // it doesn't make sense to accept max_vertices < 0. |
| 4236 | if (intValue < 0 || intValue > mMaxGeometryShaderMaxVertices) |
| 4237 | { |
| 4238 | error( |
| 4239 | intValueLine, |
| 4240 | "out of range: max_vertices must be in the range of [0, gl_MaxGeometryOutputVertices]", |
| 4241 | intValueString.c_str()); |
| 4242 | } |
| 4243 | else |
| 4244 | { |
| 4245 | *maxVertices = intValue; |
| 4246 | } |
| 4247 | } |
| 4248 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4249 | TLayoutQualifier TParseContext::parseLayoutQualifier(const TString &qualifierType, |
| 4250 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4251 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4252 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4253 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4254 | TLayoutQualifier qualifier = TLayoutQualifier::create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4255 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4256 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4257 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4258 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4259 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 4260 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4261 | if (intValue < 0) |
| 4262 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4263 | error(intValueLine, "out of range: location must be non-negative", |
| 4264 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4265 | } |
| 4266 | else |
| 4267 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4268 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 4269 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4270 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4271 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4272 | else if (qualifierType == "binding") |
| 4273 | { |
| 4274 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4275 | if (intValue < 0) |
| 4276 | { |
| 4277 | error(intValueLine, "out of range: binding must be non-negative", |
| 4278 | intValueString.c_str()); |
| 4279 | } |
| 4280 | else |
| 4281 | { |
| 4282 | qualifier.binding = intValue; |
| 4283 | } |
| 4284 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4285 | else if (qualifierType == "offset") |
| 4286 | { |
| 4287 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4288 | if (intValue < 0) |
| 4289 | { |
| 4290 | error(intValueLine, "out of range: offset must be non-negative", |
| 4291 | intValueString.c_str()); |
| 4292 | } |
| 4293 | else |
| 4294 | { |
| 4295 | qualifier.offset = intValue; |
| 4296 | } |
| 4297 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4298 | else if (qualifierType == "local_size_x") |
| 4299 | { |
| 4300 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 4301 | &qualifier.localSize); |
| 4302 | } |
| 4303 | else if (qualifierType == "local_size_y") |
| 4304 | { |
| 4305 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 4306 | &qualifier.localSize); |
| 4307 | } |
| 4308 | else if (qualifierType == "local_size_z") |
| 4309 | { |
| 4310 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 4311 | &qualifier.localSize); |
| 4312 | } |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 4313 | else if (qualifierType == "num_views" && isMultiviewExtensionEnabled() && |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4314 | mShaderType == GL_VERTEX_SHADER) |
| 4315 | { |
| 4316 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 4317 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4318 | else if (qualifierType == "invocations" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4319 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4320 | { |
| 4321 | parseInvocations(intValue, intValueLine, intValueString, &qualifier.invocations); |
| 4322 | } |
| 4323 | else if (qualifierType == "max_vertices" && isExtensionEnabled("GL_OES_geometry_shader") && |
| 4324 | mShaderType == GL_GEOMETRY_SHADER_OES) |
| 4325 | { |
| 4326 | parseMaxVertices(intValue, intValueLine, intValueString, &qualifier.maxVertices); |
| 4327 | } |
| 4328 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4329 | else |
| 4330 | { |
| 4331 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4332 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4333 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4334 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4335 | } |
| 4336 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 4337 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 4338 | { |
| 4339 | return new TTypeQualifierBuilder( |
| 4340 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 4341 | mShaderVersion); |
| 4342 | } |
| 4343 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4344 | TStorageQualifierWrapper *TParseContext::parseGlobalStorageQualifier(TQualifier qualifier, |
| 4345 | const TSourceLoc &loc) |
| 4346 | { |
| 4347 | checkIsAtGlobalLevel(loc, getQualifierString(qualifier)); |
| 4348 | return new TStorageQualifierWrapper(qualifier, loc); |
| 4349 | } |
| 4350 | |
| 4351 | TStorageQualifierWrapper *TParseContext::parseVaryingQualifier(const TSourceLoc &loc) |
| 4352 | { |
| 4353 | if (getShaderType() == GL_VERTEX_SHADER) |
| 4354 | { |
| 4355 | return parseGlobalStorageQualifier(EvqVaryingOut, loc); |
| 4356 | } |
| 4357 | return parseGlobalStorageQualifier(EvqVaryingIn, loc); |
| 4358 | } |
| 4359 | |
| 4360 | TStorageQualifierWrapper *TParseContext::parseInQualifier(const TSourceLoc &loc) |
| 4361 | { |
| 4362 | if (declaringFunction()) |
| 4363 | { |
| 4364 | return new TStorageQualifierWrapper(EvqIn, loc); |
| 4365 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4366 | |
| 4367 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4368 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4369 | case GL_VERTEX_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4370 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4371 | if (mShaderVersion < 300 && !isMultiviewExtensionEnabled()) |
| 4372 | { |
| 4373 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4374 | } |
| 4375 | return new TStorageQualifierWrapper(EvqVertexIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4376 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4377 | case GL_FRAGMENT_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4378 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4379 | if (mShaderVersion < 300) |
| 4380 | { |
| 4381 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4382 | } |
| 4383 | return new TStorageQualifierWrapper(EvqFragmentIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4384 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4385 | case GL_COMPUTE_SHADER: |
| 4386 | { |
| 4387 | return new TStorageQualifierWrapper(EvqComputeIn, loc); |
| 4388 | } |
| 4389 | case GL_GEOMETRY_SHADER_OES: |
| 4390 | { |
| 4391 | return new TStorageQualifierWrapper(EvqGeometryIn, loc); |
| 4392 | } |
| 4393 | default: |
| 4394 | { |
| 4395 | UNREACHABLE(); |
| 4396 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4397 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4398 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4399 | } |
| 4400 | |
| 4401 | TStorageQualifierWrapper *TParseContext::parseOutQualifier(const TSourceLoc &loc) |
| 4402 | { |
| 4403 | if (declaringFunction()) |
| 4404 | { |
| 4405 | return new TStorageQualifierWrapper(EvqOut, loc); |
| 4406 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4407 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4408 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4409 | case GL_VERTEX_SHADER: |
| 4410 | { |
| 4411 | if (mShaderVersion < 300) |
| 4412 | { |
| 4413 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4414 | } |
| 4415 | return new TStorageQualifierWrapper(EvqVertexOut, loc); |
| 4416 | } |
| 4417 | case GL_FRAGMENT_SHADER: |
| 4418 | { |
| 4419 | if (mShaderVersion < 300) |
| 4420 | { |
| 4421 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4422 | } |
| 4423 | return new TStorageQualifierWrapper(EvqFragmentOut, loc); |
| 4424 | } |
| 4425 | case GL_COMPUTE_SHADER: |
| 4426 | { |
| 4427 | error(loc, "storage qualifier isn't supported in compute shaders", "out"); |
| 4428 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4429 | } |
| 4430 | case GL_GEOMETRY_SHADER_OES: |
| 4431 | { |
| 4432 | return new TStorageQualifierWrapper(EvqGeometryOut, loc); |
| 4433 | } |
| 4434 | default: |
| 4435 | { |
| 4436 | UNREACHABLE(); |
| 4437 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4438 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4439 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4440 | } |
| 4441 | |
| 4442 | TStorageQualifierWrapper *TParseContext::parseInOutQualifier(const TSourceLoc &loc) |
| 4443 | { |
| 4444 | if (!declaringFunction()) |
| 4445 | { |
| 4446 | error(loc, "invalid qualifier: can be only used with function parameters", "inout"); |
| 4447 | } |
| 4448 | return new TStorageQualifierWrapper(EvqInOut, loc); |
| 4449 | } |
| 4450 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4451 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4452 | TLayoutQualifier rightQualifier, |
| 4453 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4454 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4455 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4456 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4457 | } |
| 4458 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4459 | TField *TParseContext::parseStructDeclarator(TString *identifier, const TSourceLoc &loc) |
| 4460 | { |
| 4461 | checkIsNotReserved(loc, *identifier); |
| 4462 | TType *type = new TType(EbtVoid, EbpUndefined); |
| 4463 | return new TField(type, identifier, loc); |
| 4464 | } |
| 4465 | |
| 4466 | TField *TParseContext::parseStructArrayDeclarator(TString *identifier, |
| 4467 | const TSourceLoc &loc, |
| 4468 | TIntermTyped *arraySize, |
| 4469 | const TSourceLoc &arraySizeLoc) |
| 4470 | { |
| 4471 | checkIsNotReserved(loc, *identifier); |
| 4472 | |
| 4473 | TType *type = new TType(EbtVoid, EbpUndefined); |
| 4474 | unsigned int size = checkIsValidArraySize(arraySizeLoc, arraySize); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4475 | type->makeArray(size); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4476 | |
| 4477 | return new TField(type, identifier, loc); |
| 4478 | } |
| 4479 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4480 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 4481 | const TFieldList *newlyAddedFields, |
| 4482 | const TSourceLoc &location) |
| 4483 | { |
| 4484 | for (TField *field : *newlyAddedFields) |
| 4485 | { |
| 4486 | for (TField *oldField : *processedFields) |
| 4487 | { |
| 4488 | if (oldField->name() == field->name()) |
| 4489 | { |
| 4490 | error(location, "duplicate field name in structure", field->name().c_str()); |
| 4491 | } |
| 4492 | } |
| 4493 | processedFields->push_back(field); |
| 4494 | } |
| 4495 | return processedFields; |
| 4496 | } |
| 4497 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4498 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 4499 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 4500 | TPublicType *typeSpecifier, |
| 4501 | TFieldList *fieldList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4502 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4503 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4504 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4505 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 4506 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4507 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4508 | typeSpecifier->invariant = typeQualifier.invariant; |
| 4509 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4510 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4511 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4512 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4513 | return addStructDeclaratorList(*typeSpecifier, fieldList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4514 | } |
| 4515 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4516 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4517 | TFieldList *declaratorList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4518 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4519 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 4520 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4521 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4522 | checkIsNonVoid(typeSpecifier.getLine(), (*declaratorList)[0]->name(), |
| 4523 | typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4524 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4525 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4526 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4527 | for (unsigned int i = 0; i < declaratorList->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4528 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4529 | auto declaratorArraySizes = (*declaratorList)[i]->type()->getArraySizes(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4530 | // don't allow arrays of arrays |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4531 | if (!declaratorArraySizes.empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4532 | { |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 4533 | checkArrayElementIsNotArray(typeSpecifier.getLine(), typeSpecifier); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4534 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4535 | |
| 4536 | TType *type = (*declaratorList)[i]->type(); |
| 4537 | *type = TType(typeSpecifier); |
| 4538 | for (unsigned int arraySize : declaratorArraySizes) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4539 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4540 | type->makeArray(arraySize); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4541 | } |
| 4542 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4543 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *(*declaratorList)[i]); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4544 | } |
| 4545 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4546 | return declaratorList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4547 | } |
| 4548 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4549 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 4550 | const TSourceLoc &nameLine, |
| 4551 | const TString *structName, |
| 4552 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4553 | { |
Olli Etuaho | a5e693a | 2017-07-13 16:07:26 +0300 | [diff] [blame] | 4554 | TStructure *structure = new TStructure(&symbolTable, structName, fieldList); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4555 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4556 | // Store a bool in the struct if we're at global scope, to allow us to |
| 4557 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4558 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 4559 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4560 | if (!structName->empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4561 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4562 | checkIsNotReserved(nameLine, *structName); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 4563 | if (!symbolTable.declareStructType(structure)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4564 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4565 | error(nameLine, "redefinition of a struct", structName->c_str()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4566 | } |
| 4567 | } |
| 4568 | |
| 4569 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4570 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4571 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4572 | const TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4573 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4574 | switch (qualifier) |
| 4575 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4576 | case EvqGlobal: |
| 4577 | case EvqTemporary: |
| 4578 | break; |
| 4579 | default: |
| 4580 | error(field.line(), "invalid qualifier on struct member", |
| 4581 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4582 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4583 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4584 | if (field.type()->isInvariant()) |
| 4585 | { |
| 4586 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 4587 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4588 | // ESSL 3.10 section 4.1.8 -- atomic_uint or images are not allowed as structure member. |
| 4589 | if (IsImage(field.type()->getBasicType()) || IsAtomicCounter(field.type()->getBasicType())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4590 | { |
| 4591 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 4592 | } |
| 4593 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4594 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 4595 | |
| 4596 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4597 | |
| 4598 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4599 | } |
| 4600 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4601 | TTypeSpecifierNonArray typeSpecifierNonArray; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 4602 | typeSpecifierNonArray.initializeStruct(structure, true, structLine); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4603 | exitStructDeclaration(); |
| 4604 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4605 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4606 | } |
| 4607 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4608 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 4609 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4610 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4611 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4612 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4613 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4614 | init->isVector()) |
| 4615 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4616 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 4617 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4618 | return nullptr; |
| 4619 | } |
| 4620 | |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4621 | if (statementList) |
| 4622 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4623 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4624 | { |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4625 | return nullptr; |
| 4626 | } |
| 4627 | } |
| 4628 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4629 | TIntermSwitch *node = new TIntermSwitch(init, statementList); |
| 4630 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4631 | return node; |
| 4632 | } |
| 4633 | |
| 4634 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 4635 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4636 | if (mSwitchNestingLevel == 0) |
| 4637 | { |
| 4638 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4639 | return nullptr; |
| 4640 | } |
| 4641 | if (condition == nullptr) |
| 4642 | { |
| 4643 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4644 | return nullptr; |
| 4645 | } |
| 4646 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4647 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4648 | { |
| 4649 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4650 | } |
| 4651 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4652 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 4653 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 4654 | // fold in case labels. |
| 4655 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4656 | { |
| 4657 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4658 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4659 | TIntermCase *node = new TIntermCase(condition); |
| 4660 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4661 | return node; |
| 4662 | } |
| 4663 | |
| 4664 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 4665 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4666 | if (mSwitchNestingLevel == 0) |
| 4667 | { |
| 4668 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4669 | return nullptr; |
| 4670 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4671 | TIntermCase *node = new TIntermCase(nullptr); |
| 4672 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4673 | return node; |
| 4674 | } |
| 4675 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4676 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 4677 | TIntermTyped *child, |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4678 | const TSourceLoc &loc) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4679 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4680 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4681 | |
| 4682 | switch (op) |
| 4683 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4684 | case EOpLogicalNot: |
| 4685 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 4686 | child->isVector()) |
| 4687 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4688 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4689 | return nullptr; |
| 4690 | } |
| 4691 | break; |
| 4692 | case EOpBitwiseNot: |
| 4693 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 4694 | child->isMatrix() || child->isArray()) |
| 4695 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4696 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4697 | return nullptr; |
| 4698 | } |
| 4699 | break; |
| 4700 | case EOpPostIncrement: |
| 4701 | case EOpPreIncrement: |
| 4702 | case EOpPostDecrement: |
| 4703 | case EOpPreDecrement: |
| 4704 | case EOpNegative: |
| 4705 | case EOpPositive: |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4706 | if (child->getBasicType() == EbtStruct || child->isInterfaceBlock() || |
| 4707 | child->getBasicType() == EbtBool || child->isArray() || |
| 4708 | IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4709 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4710 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4711 | return nullptr; |
| 4712 | } |
| 4713 | // Operators for built-ins are already type checked against their prototype. |
| 4714 | default: |
| 4715 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4716 | } |
| 4717 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4718 | if (child->getMemoryQualifier().writeonly) |
| 4719 | { |
| 4720 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
| 4721 | return nullptr; |
| 4722 | } |
| 4723 | |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4724 | TIntermUnary *node = new TIntermUnary(op, child); |
| 4725 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4726 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4727 | return node->fold(mDiagnostics); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4728 | } |
| 4729 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4730 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 4731 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4732 | ASSERT(op != EOpNull); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4733 | TIntermTyped *node = createUnaryMath(op, child, loc); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4734 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4735 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4736 | return child; |
| 4737 | } |
| 4738 | return node; |
| 4739 | } |
| 4740 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4741 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 4742 | TIntermTyped *child, |
| 4743 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4744 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4745 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4746 | return addUnaryMath(op, child, loc); |
| 4747 | } |
| 4748 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4749 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 4750 | TIntermTyped *left, |
| 4751 | TIntermTyped *right, |
| 4752 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4753 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 4754 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 4755 | // and structure member selection. |
| 4756 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 4757 | { |
| 4758 | switch (op) |
| 4759 | { |
| 4760 | case EOpIndexDirect: |
| 4761 | case EOpIndexIndirect: |
| 4762 | break; |
| 4763 | case EOpIndexDirectStruct: |
| 4764 | UNREACHABLE(); |
| 4765 | |
| 4766 | default: |
| 4767 | error(loc, "Invalid operation for variables with an opaque type", |
| 4768 | GetOperatorString(op)); |
| 4769 | return false; |
| 4770 | } |
| 4771 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 4772 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4773 | if (right->getMemoryQualifier().writeonly) |
| 4774 | { |
| 4775 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 4776 | return false; |
| 4777 | } |
| 4778 | |
| 4779 | if (left->getMemoryQualifier().writeonly) |
| 4780 | { |
| 4781 | switch (op) |
| 4782 | { |
| 4783 | case EOpAssign: |
| 4784 | case EOpInitialize: |
| 4785 | case EOpIndexDirect: |
| 4786 | case EOpIndexIndirect: |
| 4787 | case EOpIndexDirectStruct: |
| 4788 | case EOpIndexDirectInterfaceBlock: |
| 4789 | break; |
| 4790 | default: |
| 4791 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 4792 | return false; |
| 4793 | } |
| 4794 | } |
| 4795 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 4796 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 4797 | { |
| 4798 | switch (op) |
| 4799 | { |
| 4800 | case EOpIndexDirectStruct: |
| 4801 | ASSERT(left->getType().getStruct()); |
| 4802 | break; |
| 4803 | case EOpEqual: |
| 4804 | case EOpNotEqual: |
| 4805 | case EOpAssign: |
| 4806 | case EOpInitialize: |
| 4807 | if (left->getType() != right->getType()) |
| 4808 | { |
| 4809 | return false; |
| 4810 | } |
| 4811 | break; |
| 4812 | default: |
| 4813 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 4814 | return false; |
| 4815 | } |
| 4816 | } |
| 4817 | |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4818 | if (left->isInterfaceBlock() || right->isInterfaceBlock()) |
| 4819 | { |
| 4820 | switch (op) |
| 4821 | { |
| 4822 | case EOpIndexDirectInterfaceBlock: |
| 4823 | ASSERT(left->getType().getInterfaceBlock()); |
| 4824 | break; |
| 4825 | default: |
| 4826 | error(loc, "Invalid operation for interface blocks", GetOperatorString(op)); |
| 4827 | return false; |
| 4828 | } |
| 4829 | } |
| 4830 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4831 | if (left->isArray() || right->isArray()) |
| 4832 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4833 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4834 | { |
| 4835 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 4836 | return false; |
| 4837 | } |
| 4838 | |
| 4839 | if (left->isArray() != right->isArray()) |
| 4840 | { |
| 4841 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 4842 | return false; |
| 4843 | } |
| 4844 | |
| 4845 | switch (op) |
| 4846 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4847 | case EOpEqual: |
| 4848 | case EOpNotEqual: |
| 4849 | case EOpAssign: |
| 4850 | case EOpInitialize: |
| 4851 | break; |
| 4852 | default: |
| 4853 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 4854 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4855 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 4856 | // At this point, size of implicitly sized arrays should be resolved. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4857 | if (left->getType().getArraySizes() != right->getType().getArraySizes()) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 4858 | { |
| 4859 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 4860 | return false; |
| 4861 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4862 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4863 | |
| 4864 | // Check ops which require integer / ivec parameters |
| 4865 | bool isBitShift = false; |
| 4866 | switch (op) |
| 4867 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4868 | case EOpBitShiftLeft: |
| 4869 | case EOpBitShiftRight: |
| 4870 | case EOpBitShiftLeftAssign: |
| 4871 | case EOpBitShiftRightAssign: |
| 4872 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 4873 | // check that the basic type is an integer type. |
| 4874 | isBitShift = true; |
| 4875 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 4876 | { |
| 4877 | return false; |
| 4878 | } |
| 4879 | break; |
| 4880 | case EOpBitwiseAnd: |
| 4881 | case EOpBitwiseXor: |
| 4882 | case EOpBitwiseOr: |
| 4883 | case EOpBitwiseAndAssign: |
| 4884 | case EOpBitwiseXorAssign: |
| 4885 | case EOpBitwiseOrAssign: |
| 4886 | // It is enough to check the type of only one operand, since later it |
| 4887 | // is checked that the operand types match. |
| 4888 | if (!IsInteger(left->getBasicType())) |
| 4889 | { |
| 4890 | return false; |
| 4891 | } |
| 4892 | break; |
| 4893 | default: |
| 4894 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4895 | } |
| 4896 | |
| 4897 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 4898 | // So the basic type should usually match. |
| 4899 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 4900 | { |
| 4901 | return false; |
| 4902 | } |
| 4903 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 4904 | // Check that: |
| 4905 | // 1. Type sizes match exactly on ops that require that. |
| 4906 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 4907 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4908 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4909 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4910 | case EOpAssign: |
| 4911 | case EOpInitialize: |
| 4912 | case EOpEqual: |
| 4913 | case EOpNotEqual: |
| 4914 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 4915 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 4916 | { |
| 4917 | error(loc, "undefined operation for structs containing arrays", |
| 4918 | GetOperatorString(op)); |
| 4919 | return false; |
| 4920 | } |
| 4921 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 4922 | // we interpret the spec so that this extends to structs containing samplers, |
| 4923 | // similarly to ESSL 1.00 spec. |
| 4924 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 4925 | left->getType().isStructureContainingSamplers()) |
| 4926 | { |
| 4927 | error(loc, "undefined operation for structs containing samplers", |
| 4928 | GetOperatorString(op)); |
| 4929 | return false; |
| 4930 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4931 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4932 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 4933 | (left->getSecondarySize() != right->getSecondarySize())) |
| 4934 | { |
| 4935 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 4936 | return false; |
| 4937 | } |
| 4938 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4939 | case EOpLessThan: |
| 4940 | case EOpGreaterThan: |
| 4941 | case EOpLessThanEqual: |
| 4942 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4943 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4944 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 4945 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4946 | return false; |
| 4947 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 4948 | break; |
| 4949 | case EOpAdd: |
| 4950 | case EOpSub: |
| 4951 | case EOpDiv: |
| 4952 | case EOpIMod: |
| 4953 | case EOpBitShiftLeft: |
| 4954 | case EOpBitShiftRight: |
| 4955 | case EOpBitwiseAnd: |
| 4956 | case EOpBitwiseXor: |
| 4957 | case EOpBitwiseOr: |
| 4958 | case EOpAddAssign: |
| 4959 | case EOpSubAssign: |
| 4960 | case EOpDivAssign: |
| 4961 | case EOpIModAssign: |
| 4962 | case EOpBitShiftLeftAssign: |
| 4963 | case EOpBitShiftRightAssign: |
| 4964 | case EOpBitwiseAndAssign: |
| 4965 | case EOpBitwiseXorAssign: |
| 4966 | case EOpBitwiseOrAssign: |
| 4967 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 4968 | { |
| 4969 | return false; |
| 4970 | } |
| 4971 | |
| 4972 | // Are the sizes compatible? |
| 4973 | if (left->getNominalSize() != right->getNominalSize() || |
| 4974 | left->getSecondarySize() != right->getSecondarySize()) |
| 4975 | { |
| 4976 | // If the nominal sizes of operands do not match: |
| 4977 | // One of them must be a scalar. |
| 4978 | if (!left->isScalar() && !right->isScalar()) |
| 4979 | return false; |
| 4980 | |
| 4981 | // In the case of compound assignment other than multiply-assign, |
| 4982 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 4983 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 4984 | // vector either. |
| 4985 | if (!right->isScalar() && |
| 4986 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 4987 | return false; |
| 4988 | } |
| 4989 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4990 | default: |
| 4991 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 4992 | } |
| 4993 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4994 | return true; |
| 4995 | } |
| 4996 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 4997 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 4998 | const TType &left, |
| 4999 | const TType &right) |
| 5000 | { |
| 5001 | switch (op) |
| 5002 | { |
| 5003 | case EOpMul: |
| 5004 | case EOpMulAssign: |
| 5005 | return left.getNominalSize() == right.getNominalSize() && |
| 5006 | left.getSecondarySize() == right.getSecondarySize(); |
| 5007 | case EOpVectorTimesScalar: |
| 5008 | return true; |
| 5009 | case EOpVectorTimesScalarAssign: |
| 5010 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 5011 | return left.isVector() && !right.isVector(); |
| 5012 | case EOpVectorTimesMatrix: |
| 5013 | return left.getNominalSize() == right.getRows(); |
| 5014 | case EOpVectorTimesMatrixAssign: |
| 5015 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 5016 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 5017 | left.getNominalSize() == right.getCols(); |
| 5018 | case EOpMatrixTimesVector: |
| 5019 | return left.getCols() == right.getNominalSize(); |
| 5020 | case EOpMatrixTimesScalar: |
| 5021 | return true; |
| 5022 | case EOpMatrixTimesScalarAssign: |
| 5023 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 5024 | return !right.isVector(); |
| 5025 | case EOpMatrixTimesMatrix: |
| 5026 | return left.getCols() == right.getRows(); |
| 5027 | case EOpMatrixTimesMatrixAssign: |
| 5028 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 5029 | // We need to check two things: |
| 5030 | // 1. The matrix multiplication step is valid. |
| 5031 | // 2. The result will have the same number of columns as the lvalue. |
| 5032 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 5033 | |
| 5034 | default: |
| 5035 | UNREACHABLE(); |
| 5036 | return false; |
| 5037 | } |
| 5038 | } |
| 5039 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5040 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 5041 | TIntermTyped *left, |
| 5042 | TIntermTyped *right, |
| 5043 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5044 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5045 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5046 | return nullptr; |
| 5047 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5048 | switch (op) |
| 5049 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5050 | case EOpEqual: |
| 5051 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5052 | case EOpLessThan: |
| 5053 | case EOpGreaterThan: |
| 5054 | case EOpLessThanEqual: |
| 5055 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5056 | break; |
| 5057 | case EOpLogicalOr: |
| 5058 | case EOpLogicalXor: |
| 5059 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5060 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5061 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5062 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5063 | { |
| 5064 | return nullptr; |
| 5065 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5066 | // Basic types matching should have been already checked. |
| 5067 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5068 | break; |
| 5069 | case EOpAdd: |
| 5070 | case EOpSub: |
| 5071 | case EOpDiv: |
| 5072 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5073 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5074 | !right->getType().getStruct()); |
| 5075 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5076 | { |
| 5077 | return nullptr; |
| 5078 | } |
| 5079 | break; |
| 5080 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5081 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5082 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5083 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5084 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5085 | { |
| 5086 | return nullptr; |
| 5087 | } |
| 5088 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5089 | default: |
| 5090 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5091 | } |
| 5092 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5093 | if (op == EOpMul) |
| 5094 | { |
| 5095 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 5096 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5097 | { |
| 5098 | return nullptr; |
| 5099 | } |
| 5100 | } |
| 5101 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5102 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 5103 | node->setLine(loc); |
| 5104 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5105 | // See if we can fold constants. |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5106 | return node->fold(mDiagnostics); |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5107 | } |
| 5108 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5109 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 5110 | TIntermTyped *left, |
| 5111 | TIntermTyped *right, |
| 5112 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5113 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5114 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5115 | if (node == 0) |
| 5116 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5117 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 5118 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5119 | return left; |
| 5120 | } |
| 5121 | return node; |
| 5122 | } |
| 5123 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5124 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 5125 | TIntermTyped *left, |
| 5126 | TIntermTyped *right, |
| 5127 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5128 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5129 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5130 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5131 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5132 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 5133 | right->getCompleteString()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5134 | node = CreateBoolNode(false); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5135 | node->setLine(loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5136 | } |
| 5137 | return node; |
| 5138 | } |
| 5139 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 5140 | TIntermBinary *TParseContext::createAssign(TOperator op, |
| 5141 | TIntermTyped *left, |
| 5142 | TIntermTyped *right, |
| 5143 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5144 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5145 | if (binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5146 | { |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5147 | if (op == EOpMulAssign) |
| 5148 | { |
| 5149 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 5150 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5151 | { |
| 5152 | return nullptr; |
| 5153 | } |
| 5154 | } |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5155 | TIntermBinary *node = new TIntermBinary(op, left, right); |
| 5156 | node->setLine(loc); |
| 5157 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5158 | return node; |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5159 | } |
| 5160 | return nullptr; |
| 5161 | } |
| 5162 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5163 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 5164 | TIntermTyped *left, |
| 5165 | TIntermTyped *right, |
| 5166 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5167 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5168 | checkCanBeLValue(loc, "assign", left); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5169 | TIntermTyped *node = createAssign(op, left, right, loc); |
| 5170 | if (node == nullptr) |
| 5171 | { |
| 5172 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5173 | return left; |
| 5174 | } |
| 5175 | return node; |
| 5176 | } |
| 5177 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5178 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 5179 | TIntermTyped *right, |
| 5180 | const TSourceLoc &loc) |
| 5181 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5182 | // WebGL2 section 5.26, the following results in an error: |
| 5183 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 5184 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 5185 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 5186 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 5187 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5188 | { |
| 5189 | error(loc, |
| 5190 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 5191 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5192 | } |
| 5193 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5194 | TIntermBinary *commaNode = new TIntermBinary(EOpComma, left, right); |
| 5195 | TQualifier resultQualifier = TIntermBinary::GetCommaQualifier(mShaderVersion, left, right); |
| 5196 | commaNode->getTypePointer()->setQualifier(resultQualifier); |
| 5197 | return commaNode->fold(mDiagnostics); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5198 | } |
| 5199 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5200 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 5201 | { |
| 5202 | switch (op) |
| 5203 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5204 | case EOpContinue: |
| 5205 | if (mLoopNestingLevel <= 0) |
| 5206 | { |
| 5207 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5208 | } |
| 5209 | break; |
| 5210 | case EOpBreak: |
| 5211 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 5212 | { |
| 5213 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5214 | } |
| 5215 | break; |
| 5216 | case EOpReturn: |
| 5217 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 5218 | { |
| 5219 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5220 | } |
| 5221 | break; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5222 | case EOpKill: |
| 5223 | if (mShaderType != GL_FRAGMENT_SHADER) |
| 5224 | { |
| 5225 | error(loc, "discard supported in fragment shaders only", "discard"); |
| 5226 | } |
| 5227 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5228 | default: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5229 | UNREACHABLE(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5230 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5231 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5232 | return addBranch(op, nullptr, loc); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5233 | } |
| 5234 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5235 | TIntermBranch *TParseContext::addBranch(TOperator op, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5236 | TIntermTyped *expression, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5237 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5238 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5239 | if (expression != nullptr) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5240 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5241 | ASSERT(op == EOpReturn); |
| 5242 | mFunctionReturnsValue = true; |
| 5243 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
| 5244 | { |
| 5245 | error(loc, "void function cannot return a value", "return"); |
| 5246 | } |
| 5247 | else if (*mCurrentFunctionType != expression->getType()) |
| 5248 | { |
| 5249 | error(loc, "function return is not matching type:", "return"); |
| 5250 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5251 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5252 | TIntermBranch *node = new TIntermBranch(op, expression); |
| 5253 | node->setLine(loc); |
| 5254 | return node; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5255 | } |
| 5256 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5257 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 5258 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5259 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | bd67455 | 2016-10-06 13:28:42 +0100 | [diff] [blame] | 5260 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5261 | TIntermNode *offset = nullptr; |
| 5262 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 5263 | if (name == "texelFetchOffset" || name == "textureLodOffset" || |
| 5264 | name == "textureProjLodOffset" || name == "textureGradOffset" || |
| 5265 | name == "textureProjGradOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5266 | { |
| 5267 | offset = arguments->back(); |
| 5268 | } |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 5269 | else if (name == "textureOffset" || name == "textureProjOffset") |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5270 | { |
| 5271 | // A bias parameter might follow the offset parameter. |
| 5272 | ASSERT(arguments->size() >= 3); |
| 5273 | offset = (*arguments)[2]; |
| 5274 | } |
| 5275 | if (offset != nullptr) |
| 5276 | { |
| 5277 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 5278 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 5279 | { |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5280 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
Olli Etuaho | ec9232b | 2017-03-27 17:01:37 +0300 | [diff] [blame] | 5281 | name.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5282 | } |
| 5283 | else |
| 5284 | { |
| 5285 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 5286 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
| 5287 | const TConstantUnion *values = offsetConstantUnion->getUnionArrayPointer(); |
| 5288 | for (size_t i = 0u; i < size; ++i) |
| 5289 | { |
| 5290 | int offsetValue = values[i].getIConst(); |
| 5291 | if (offsetValue > mMaxProgramTexelOffset || offsetValue < mMinProgramTexelOffset) |
| 5292 | { |
| 5293 | std::stringstream tokenStream; |
| 5294 | tokenStream << offsetValue; |
| 5295 | std::string token = tokenStream.str(); |
| 5296 | error(offset->getLine(), "Texture offset value out of valid range", |
| 5297 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5298 | } |
| 5299 | } |
| 5300 | } |
| 5301 | } |
| 5302 | } |
| 5303 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5304 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 5305 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 5306 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5307 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5308 | const TString &name = functionCall->getFunctionSymbolInfo()->getName(); |
| 5309 | |
| 5310 | if (name.compare(0, 5, "image") == 0) |
| 5311 | { |
| 5312 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5313 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5314 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5315 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5316 | |
| 5317 | if (name.compare(5, 5, "Store") == 0) |
| 5318 | { |
| 5319 | if (memoryQualifier.readonly) |
| 5320 | { |
| 5321 | error(imageNode->getLine(), |
| 5322 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5323 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5324 | } |
| 5325 | } |
| 5326 | else if (name.compare(5, 4, "Load") == 0) |
| 5327 | { |
| 5328 | if (memoryQualifier.writeonly) |
| 5329 | { |
| 5330 | error(imageNode->getLine(), |
| 5331 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5332 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5333 | } |
| 5334 | } |
| 5335 | } |
| 5336 | } |
| 5337 | |
| 5338 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 5339 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 5340 | const TFunction *functionDefinition, |
| 5341 | const TIntermAggregate *functionCall) |
| 5342 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5343 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5344 | |
| 5345 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 5346 | |
| 5347 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 5348 | |
| 5349 | for (size_t i = 0; i < arguments.size(); ++i) |
| 5350 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5351 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 5352 | const TType &functionArgumentType = typedArgument->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5353 | const TType &functionParameterType = *functionDefinition->getParam(i).type; |
| 5354 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 5355 | |
| 5356 | if (IsImage(functionArgumentType.getBasicType())) |
| 5357 | { |
| 5358 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 5359 | functionArgumentType.getMemoryQualifier(); |
| 5360 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 5361 | functionParameterType.getMemoryQualifier(); |
| 5362 | if (functionArgumentMemoryQualifier.readonly && |
| 5363 | !functionParameterMemoryQualifier.readonly) |
| 5364 | { |
| 5365 | error(functionCall->getLine(), |
| 5366 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5367 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5368 | } |
| 5369 | |
| 5370 | if (functionArgumentMemoryQualifier.writeonly && |
| 5371 | !functionParameterMemoryQualifier.writeonly) |
| 5372 | { |
| 5373 | error(functionCall->getLine(), |
| 5374 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5375 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5376 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5377 | |
| 5378 | if (functionArgumentMemoryQualifier.coherent && |
| 5379 | !functionParameterMemoryQualifier.coherent) |
| 5380 | { |
| 5381 | error(functionCall->getLine(), |
| 5382 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5383 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5384 | } |
| 5385 | |
| 5386 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 5387 | !functionParameterMemoryQualifier.volatileQualifier) |
| 5388 | { |
| 5389 | error(functionCall->getLine(), |
| 5390 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5391 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5392 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5393 | } |
| 5394 | } |
| 5395 | } |
| 5396 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5397 | TIntermSequence *TParseContext::createEmptyArgumentsList() |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5398 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5399 | return new TIntermSequence(); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5400 | } |
| 5401 | |
| 5402 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunction *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5403 | TIntermSequence *arguments, |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5404 | TIntermNode *thisNode, |
| 5405 | const TSourceLoc &loc) |
| 5406 | { |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 5407 | if (thisNode != nullptr) |
| 5408 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5409 | return addMethod(fnCall, arguments, thisNode, loc); |
Olli Etuaho | ffe6edf | 2015-04-13 17:32:03 +0300 | [diff] [blame] | 5410 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5411 | |
| 5412 | TOperator op = fnCall->getBuiltInOp(); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 5413 | if (op == EOpConstruct) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5414 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 5415 | return addConstructor(arguments, fnCall->getReturnType(), loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5416 | } |
| 5417 | else |
| 5418 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 5419 | ASSERT(op == EOpNull); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5420 | return addNonConstructorFunctionCall(fnCall, arguments, loc); |
| 5421 | } |
| 5422 | } |
| 5423 | |
| 5424 | TIntermTyped *TParseContext::addMethod(TFunction *fnCall, |
| 5425 | TIntermSequence *arguments, |
| 5426 | TIntermNode *thisNode, |
| 5427 | const TSourceLoc &loc) |
| 5428 | { |
| 5429 | TConstantUnion *unionArray = new TConstantUnion[1]; |
| 5430 | int arraySize = 0; |
| 5431 | TIntermTyped *typedThis = thisNode->getAsTyped(); |
| 5432 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 5433 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 5434 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
| 5435 | // So accessing fnCall->getName() below is safe. |
| 5436 | if (fnCall->getName() != "length") |
| 5437 | { |
| 5438 | error(loc, "invalid method", fnCall->getName().c_str()); |
| 5439 | } |
| 5440 | else if (!arguments->empty()) |
| 5441 | { |
| 5442 | error(loc, "method takes no parameters", "length"); |
| 5443 | } |
| 5444 | else if (typedThis == nullptr || !typedThis->isArray()) |
| 5445 | { |
| 5446 | error(loc, "length can only be called on arrays", "length"); |
| 5447 | } |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 5448 | else if (typedThis->getQualifier() == EvqPerVertexIn && |
| 5449 | mGeometryShaderInputPrimitiveType == EptUndefined) |
| 5450 | { |
| 5451 | error(loc, "missing input primitive declaration before calling length on gl_in", "length"); |
| 5452 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5453 | else |
| 5454 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 5455 | arraySize = typedThis->getOutermostArraySize(); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5456 | if (typedThis->getAsSymbolNode() == nullptr) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5457 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5458 | // This code path can be hit with expressions like these: |
| 5459 | // (a = b).length() |
| 5460 | // (func()).length() |
| 5461 | // (int[3](0, 1, 2)).length() |
| 5462 | // ESSL 3.00 section 5.9 defines expressions so that this is not actually a valid |
| 5463 | // expression. |
| 5464 | // It allows "An array name with the length method applied" in contrast to GLSL 4.4 |
| 5465 | // spec section 5.9 which allows "An array, vector or matrix expression with the |
| 5466 | // length method applied". |
| 5467 | error(loc, "length can only be called on array names, not on array expressions", |
| 5468 | "length"); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5469 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5470 | } |
| 5471 | unionArray->setIConst(arraySize); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5472 | TIntermConstantUnion *node = |
| 5473 | new TIntermConstantUnion(unionArray, TType(EbtInt, EbpUndefined, EvqConst)); |
| 5474 | node->setLine(loc); |
| 5475 | return node; |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5476 | } |
| 5477 | |
| 5478 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunction *fnCall, |
| 5479 | TIntermSequence *arguments, |
| 5480 | const TSourceLoc &loc) |
| 5481 | { |
| 5482 | // First find by unmangled name to check whether the function name has been |
| 5483 | // hidden by a variable name or struct typename. |
| 5484 | // If a function is found, check for one with a matching argument list. |
| 5485 | bool builtIn; |
| 5486 | const TSymbol *symbol = symbolTable.find(fnCall->getName(), mShaderVersion, &builtIn); |
| 5487 | if (symbol != nullptr && !symbol->isFunction()) |
| 5488 | { |
| 5489 | error(loc, "function name expected", fnCall->getName().c_str()); |
| 5490 | } |
| 5491 | else |
| 5492 | { |
| 5493 | symbol = symbolTable.find(TFunction::GetMangledNameFromCall(fnCall->getName(), *arguments), |
| 5494 | mShaderVersion, &builtIn); |
| 5495 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5496 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5497 | error(loc, "no matching overloaded function found", fnCall->getName().c_str()); |
| 5498 | } |
| 5499 | else |
| 5500 | { |
| 5501 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5502 | // |
| 5503 | // A declared function. |
| 5504 | // |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 5505 | if (builtIn && !fnCandidate->getExtension().empty()) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5506 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 5507 | checkCanUseExtension(loc, fnCandidate->getExtension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5508 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5509 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5510 | if (builtIn && op != EOpNull) |
| 5511 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5512 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5513 | if (fnCandidate->getParamCount() == 1) |
| 5514 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5515 | // Treat it like a built-in unary operator. |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5516 | TIntermNode *unaryParamNode = arguments->front(); |
| 5517 | TIntermTyped *callNode = createUnaryMath(op, unaryParamNode->getAsTyped(), loc); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 5518 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5519 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5520 | } |
| 5521 | else |
| 5522 | { |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5523 | TIntermAggregate *callNode = |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 5524 | TIntermAggregate::Create(fnCandidate->getReturnType(), op, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5525 | callNode->setLine(loc); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5526 | |
| 5527 | // Some built-in functions have out parameters too. |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5528 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 5529 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5530 | if (TIntermAggregate::CanFoldAggregateBuiltInOp(callNode->getOp())) |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 5531 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5532 | // See if we can constant fold a built-in. Note that this may be possible |
| 5533 | // even if it is not const-qualified. |
| 5534 | return callNode->fold(mDiagnostics); |
Arun Patole | 274f070 | 2015-05-05 13:33:30 +0530 | [diff] [blame] | 5535 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5536 | else |
| 5537 | { |
| 5538 | return callNode; |
| 5539 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5540 | } |
| 5541 | } |
| 5542 | else |
| 5543 | { |
| 5544 | // This is a real function call |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5545 | TIntermAggregate *callNode = nullptr; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5546 | |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5547 | // If builtIn == false, the function is user defined - could be an overloaded |
| 5548 | // built-in as well. |
| 5549 | // if builtIn == true, it's a builtIn function with no op associated with it. |
| 5550 | // This needs to happen after the function info including name is set. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5551 | if (builtIn) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5552 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 5553 | callNode = TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5554 | checkTextureOffsetConst(callNode); |
| 5555 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5556 | } |
| 5557 | else |
| 5558 | { |
Olli Etuaho | fe48632 | 2017-03-21 09:30:54 +0000 | [diff] [blame] | 5559 | callNode = TIntermAggregate::CreateFunctionCall(*fnCandidate, arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5560 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5561 | } |
| 5562 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5563 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5564 | |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5565 | callNode->setLine(loc); |
| 5566 | |
| 5567 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5568 | } |
| 5569 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5570 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5571 | |
| 5572 | // Error message was already written. Put on a dummy node for error recovery. |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5573 | return CreateZeroNode(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5574 | } |
| 5575 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5576 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5577 | TIntermTyped *trueExpression, |
| 5578 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5579 | const TSourceLoc &loc) |
| 5580 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5581 | if (!checkIsScalarBool(loc, cond)) |
| 5582 | { |
| 5583 | return falseExpression; |
| 5584 | } |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5585 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5586 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5587 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5588 | std::stringstream reasonStream; |
| 5589 | reasonStream << "mismatching ternary operator operand types '" |
| 5590 | << trueExpression->getCompleteString() << " and '" |
| 5591 | << falseExpression->getCompleteString() << "'"; |
| 5592 | std::string reason = reasonStream.str(); |
| 5593 | error(loc, reason.c_str(), "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5594 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5595 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5596 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 5597 | { |
| 5598 | // ESSL 1.00 section 4.1.7 |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5599 | // ESSL 3.00.6 section 4.1.7 |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5600 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 5601 | // Note that structs containing opaque types don't need to be checked as structs are |
| 5602 | // forbidden below. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5603 | error(loc, "ternary operator is not allowed for opaque types", "?:"); |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5604 | return falseExpression; |
| 5605 | } |
| 5606 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5607 | if (cond->getMemoryQualifier().writeonly || trueExpression->getMemoryQualifier().writeonly || |
| 5608 | falseExpression->getMemoryQualifier().writeonly) |
| 5609 | { |
| 5610 | error(loc, "ternary operator is not allowed for variables with writeonly", "?:"); |
| 5611 | return falseExpression; |
| 5612 | } |
| 5613 | |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5614 | // ESSL 1.00.17 sections 5.2 and 5.7: |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5615 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5616 | // ESSL 3.00.6 section 5.7: |
| 5617 | // Ternary operator support is optional for arrays. No certainty that it works across all |
| 5618 | // devices with struct either, so we err on the side of caution here. TODO (oetuaho@nvidia.com): |
| 5619 | // Would be nice to make the spec and implementation agree completely here. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5620 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5621 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5622 | error(loc, "ternary operator is not allowed for structures or arrays", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5623 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5624 | } |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5625 | if (trueExpression->getBasicType() == EbtInterfaceBlock) |
| 5626 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5627 | error(loc, "ternary operator is not allowed for interface blocks", "?:"); |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5628 | return falseExpression; |
| 5629 | } |
| 5630 | |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5631 | // WebGL2 section 5.26, the following results in an error: |
| 5632 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5633 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5634 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5635 | error(loc, "ternary operator is not allowed for void", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5636 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5637 | } |
| 5638 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5639 | // Note that the node resulting from here can be a constant union without being qualified as |
| 5640 | // constant. |
| 5641 | TIntermTernary *node = new TIntermTernary(cond, trueExpression, falseExpression); |
| 5642 | node->setLine(loc); |
| 5643 | |
| 5644 | return node->fold(); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5645 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5646 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 5647 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5648 | // Parse an array of strings using yyparse. |
| 5649 | // |
| 5650 | // Returns 0 for success. |
| 5651 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5652 | int PaParseStrings(size_t count, |
| 5653 | const char *const string[], |
| 5654 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 5655 | TParseContext *context) |
| 5656 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 5657 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5658 | return 1; |
| 5659 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5660 | if (glslang_initialize(context)) |
| 5661 | return 1; |
| 5662 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 5663 | int error = glslang_scan(count, string, length, context); |
| 5664 | if (!error) |
| 5665 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5666 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 5667 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 5668 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 5669 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5670 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 5671 | |
| 5672 | } // namespace sh |