daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1 | // |
Nicolas Capens | 6ed8d8a | 2014-06-11 11:25:20 -0400 | [diff] [blame] | 2 | // Copyright (c) 2002-2014 The ANGLE Project Authors. All rights reserved. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3 | // Use of this source code is governed by a BSD-style license that can be |
| 4 | // found in the LICENSE file. |
| 5 | // |
| 6 | |
Jamie Madill | 6b9cb25 | 2013-10-17 10:45:47 -0400 | [diff] [blame] | 7 | #include "compiler/translator/ParseContext.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 8 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 9 | #include <stdarg.h> |
apatrick@chromium.org | 8187fa8 | 2010-06-15 22:09:28 +0000 | [diff] [blame] | 10 | #include <stdio.h> |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 11 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 12 | #include "common/mathutil.h" |
daniel@transgaming.com | b401a92 | 2012-10-26 18:58:24 +0000 | [diff] [blame] | 13 | #include "compiler/preprocessor/SourceLocation.h" |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 14 | #include "compiler/translator/Declarator.h" |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 15 | #include "compiler/translator/ParseContext_autogen.h" |
Kai Ninomiya | 614dd0f | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 16 | #include "compiler/translator/StaticType.h" |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 17 | #include "compiler/translator/ValidateGlobalInitializer.h" |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 18 | #include "compiler/translator/ValidateSwitch.h" |
| 19 | #include "compiler/translator/glslang.h" |
Olli Etuaho | c26214d | 2018-03-16 10:43:11 +0200 | [diff] [blame] | 20 | #include "compiler/translator/tree_util/IntermNode_util.h" |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 21 | #include "compiler/translator/util.h" |
daniel@transgaming.com | bbf56f7 | 2010-04-20 18:52:13 +0000 | [diff] [blame] | 22 | |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 23 | namespace sh |
| 24 | { |
| 25 | |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 26 | /////////////////////////////////////////////////////////////////////// |
| 27 | // |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 28 | // Sub- vector and matrix fields |
| 29 | // |
| 30 | //////////////////////////////////////////////////////////////////////// |
| 31 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 32 | namespace |
| 33 | { |
| 34 | |
| 35 | const int kWebGLMaxStructNesting = 4; |
| 36 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 37 | bool ContainsSampler(const TStructure *structType); |
| 38 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 39 | bool ContainsSampler(const TType &type) |
| 40 | { |
| 41 | if (IsSampler(type.getBasicType())) |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 42 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 43 | return true; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 44 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 45 | if (type.getBasicType() == EbtStruct) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 46 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 47 | return ContainsSampler(type.getStruct()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 48 | } |
| 49 | |
| 50 | return false; |
| 51 | } |
| 52 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 53 | bool ContainsSampler(const TStructure *structType) |
| 54 | { |
| 55 | for (const auto &field : structType->fields()) |
| 56 | { |
| 57 | if (ContainsSampler(*field->type())) |
| 58 | return true; |
| 59 | } |
| 60 | return false; |
| 61 | } |
| 62 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 63 | // Get a token from an image argument to use as an error message token. |
| 64 | const char *GetImageArgumentToken(TIntermTyped *imageNode) |
| 65 | { |
| 66 | ASSERT(IsImage(imageNode->getBasicType())); |
| 67 | while (imageNode->getAsBinaryNode() && |
| 68 | (imageNode->getAsBinaryNode()->getOp() == EOpIndexIndirect || |
| 69 | imageNode->getAsBinaryNode()->getOp() == EOpIndexDirect)) |
| 70 | { |
| 71 | imageNode = imageNode->getAsBinaryNode()->getLeft(); |
| 72 | } |
| 73 | TIntermSymbol *imageSymbol = imageNode->getAsSymbolNode(); |
| 74 | if (imageSymbol) |
| 75 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 76 | return imageSymbol->getName().data(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 77 | } |
| 78 | return "image"; |
| 79 | } |
| 80 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 81 | bool CanSetDefaultPrecisionOnType(const TPublicType &type) |
| 82 | { |
| 83 | if (!SupportsPrecision(type.getBasicType())) |
| 84 | { |
| 85 | return false; |
| 86 | } |
| 87 | if (type.getBasicType() == EbtUInt) |
| 88 | { |
| 89 | // ESSL 3.00.4 section 4.5.4 |
| 90 | return false; |
| 91 | } |
| 92 | if (type.isAggregate()) |
| 93 | { |
| 94 | // Not allowed to set for aggregate types |
| 95 | return false; |
| 96 | } |
| 97 | return true; |
| 98 | } |
| 99 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 100 | // Map input primitive types to input array sizes in a geometry shader. |
| 101 | GLuint GetGeometryShaderInputArraySize(TLayoutPrimitiveType primitiveType) |
| 102 | { |
| 103 | switch (primitiveType) |
| 104 | { |
| 105 | case EptPoints: |
| 106 | return 1u; |
| 107 | case EptLines: |
| 108 | return 2u; |
| 109 | case EptTriangles: |
| 110 | return 3u; |
| 111 | case EptLinesAdjacency: |
| 112 | return 4u; |
| 113 | case EptTrianglesAdjacency: |
| 114 | return 6u; |
| 115 | default: |
| 116 | UNREACHABLE(); |
| 117 | return 0u; |
| 118 | } |
| 119 | } |
| 120 | |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 121 | bool IsBufferOrSharedVariable(TIntermTyped *var) |
| 122 | { |
| 123 | if (var->isInterfaceBlock() || var->getQualifier() == EvqBuffer || |
| 124 | var->getQualifier() == EvqShared) |
| 125 | { |
| 126 | return true; |
| 127 | } |
| 128 | return false; |
| 129 | } |
| 130 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 131 | } // namespace |
| 132 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 133 | // This tracks each binding point's current default offset for inheritance of subsequent |
| 134 | // variables using the same binding, and keeps offsets unique and non overlapping. |
| 135 | // See GLSL ES 3.1, section 4.4.6. |
| 136 | class TParseContext::AtomicCounterBindingState |
| 137 | { |
| 138 | public: |
| 139 | AtomicCounterBindingState() : mDefaultOffset(0) {} |
| 140 | // Inserts a new span and returns -1 if overlapping, else returns the starting offset of |
| 141 | // newly inserted span. |
| 142 | int insertSpan(int start, size_t length) |
| 143 | { |
| 144 | gl::RangeI newSpan(start, start + static_cast<int>(length)); |
| 145 | for (const auto &span : mSpans) |
| 146 | { |
| 147 | if (newSpan.intersects(span)) |
| 148 | { |
| 149 | return -1; |
| 150 | } |
| 151 | } |
| 152 | mSpans.push_back(newSpan); |
| 153 | mDefaultOffset = newSpan.high(); |
| 154 | return start; |
| 155 | } |
| 156 | // Inserts a new span starting from the default offset. |
| 157 | int appendSpan(size_t length) { return insertSpan(mDefaultOffset, length); } |
| 158 | void setDefaultOffset(int offset) { mDefaultOffset = offset; } |
| 159 | |
| 160 | private: |
| 161 | int mDefaultOffset; |
| 162 | std::vector<gl::RangeI> mSpans; |
| 163 | }; |
| 164 | |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 165 | TParseContext::TParseContext(TSymbolTable &symt, |
| 166 | TExtensionBehavior &ext, |
| 167 | sh::GLenum type, |
| 168 | ShShaderSpec spec, |
| 169 | ShCompileOptions options, |
| 170 | bool checksPrecErrors, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 171 | TDiagnostics *diagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 172 | const ShBuiltInResources &resources) |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 173 | : symbolTable(symt), |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 174 | mDeferredNonEmptyDeclarationErrorCheck(false), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 175 | mShaderType(type), |
| 176 | mShaderSpec(spec), |
| 177 | mCompileOptions(options), |
| 178 | mShaderVersion(100), |
| 179 | mTreeRoot(nullptr), |
| 180 | mLoopNestingLevel(0), |
| 181 | mStructNestingLevel(0), |
| 182 | mSwitchNestingLevel(0), |
| 183 | mCurrentFunctionType(nullptr), |
| 184 | mFunctionReturnsValue(false), |
| 185 | mChecksPrecisionErrors(checksPrecErrors), |
| 186 | mFragmentPrecisionHighOnESSL1(false), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 187 | mDefaultUniformMatrixPacking(EmpColumnMajor), |
| 188 | mDefaultUniformBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
| 189 | mDefaultBufferMatrixPacking(EmpColumnMajor), |
| 190 | mDefaultBufferBlockStorage(sh::IsWebGLBasedSpec(spec) ? EbsStd140 : EbsShared), |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 191 | mDiagnostics(diagnostics), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 192 | mDirectiveHandler(ext, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 193 | *mDiagnostics, |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 194 | mShaderVersion, |
| 195 | mShaderType, |
| 196 | resources.WEBGL_debug_shader_precision == 1), |
Geoff Lang | 197d529 | 2018-04-25 14:29:00 -0400 | [diff] [blame] | 197 | mPreprocessor(mDiagnostics, &mDirectiveHandler, angle::pp::PreprocessorSettings()), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 198 | mScanner(nullptr), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 199 | mMinProgramTexelOffset(resources.MinProgramTexelOffset), |
| 200 | mMaxProgramTexelOffset(resources.MaxProgramTexelOffset), |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 201 | mMinProgramTextureGatherOffset(resources.MinProgramTextureGatherOffset), |
| 202 | mMaxProgramTextureGatherOffset(resources.MaxProgramTextureGatherOffset), |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 203 | mComputeShaderLocalSizeDeclared(false), |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 204 | mComputeShaderLocalSize(-1), |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 205 | mNumViews(-1), |
| 206 | mMaxNumViews(resources.MaxViewsOVR), |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 207 | mMaxImageUnits(resources.MaxImageUnits), |
| 208 | mMaxCombinedTextureImageUnits(resources.MaxCombinedTextureImageUnits), |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 209 | mMaxUniformLocations(resources.MaxUniformLocations), |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 210 | mMaxUniformBufferBindings(resources.MaxUniformBufferBindings), |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 211 | mMaxAtomicCounterBindings(resources.MaxAtomicCounterBindings), |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 212 | mMaxShaderStorageBufferBindings(resources.MaxShaderStorageBufferBindings), |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 213 | mDeclaringFunction(false), |
| 214 | mGeometryShaderInputPrimitiveType(EptUndefined), |
| 215 | mGeometryShaderOutputPrimitiveType(EptUndefined), |
| 216 | mGeometryShaderInvocations(0), |
| 217 | mGeometryShaderMaxVertices(-1), |
| 218 | mMaxGeometryShaderInvocations(resources.MaxGeometryShaderInvocations), |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 219 | mMaxGeometryShaderMaxVertices(resources.MaxGeometryOutputVertices) |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 220 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 221 | } |
| 222 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 223 | TParseContext::~TParseContext() |
| 224 | { |
| 225 | } |
| 226 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 227 | bool TParseContext::parseVectorFields(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 228 | const ImmutableString &compString, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 229 | int vecSize, |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 230 | TVector<int> *fieldOffsets) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 231 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 232 | ASSERT(fieldOffsets); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 233 | size_t fieldCount = compString.length(); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 234 | if (fieldCount > 4u) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 235 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 236 | error(line, "illegal vector field selection", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 237 | return false; |
| 238 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 239 | fieldOffsets->resize(fieldCount); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 240 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 241 | enum |
| 242 | { |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 243 | exyzw, |
| 244 | ergba, |
daniel@transgaming.com | b3077d0 | 2013-01-11 04:12:09 +0000 | [diff] [blame] | 245 | estpq |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 246 | } fieldSet[4]; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 247 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 248 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 249 | { |
| 250 | switch (compString[i]) |
| 251 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 252 | case 'x': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 253 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 254 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 255 | break; |
| 256 | case 'r': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 257 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 258 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 259 | break; |
| 260 | case 's': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 261 | (*fieldOffsets)[i] = 0; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 262 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 263 | break; |
| 264 | case 'y': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 265 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 266 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 267 | break; |
| 268 | case 'g': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 269 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 270 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 271 | break; |
| 272 | case 't': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 273 | (*fieldOffsets)[i] = 1; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 274 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 275 | break; |
| 276 | case 'z': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 277 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 278 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 279 | break; |
| 280 | case 'b': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 281 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 282 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 283 | break; |
| 284 | case 'p': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 285 | (*fieldOffsets)[i] = 2; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 286 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 287 | break; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 288 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 289 | case 'w': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 290 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 291 | fieldSet[i] = exyzw; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 292 | break; |
| 293 | case 'a': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 294 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 295 | fieldSet[i] = ergba; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 296 | break; |
| 297 | case 'q': |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 298 | (*fieldOffsets)[i] = 3; |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 299 | fieldSet[i] = estpq; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 300 | break; |
| 301 | default: |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 302 | error(line, "illegal vector field selection", compString); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 303 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 304 | } |
| 305 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 306 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 307 | for (unsigned int i = 0u; i < fieldOffsets->size(); ++i) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 308 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 309 | if ((*fieldOffsets)[i] >= vecSize) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 310 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 311 | error(line, "vector field selection out of range", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 312 | return false; |
| 313 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 314 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 315 | if (i > 0) |
| 316 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 317 | if (fieldSet[i] != fieldSet[i - 1]) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 318 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 319 | error(line, "illegal - vector component fields not from the same set", compString); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 320 | return false; |
| 321 | } |
| 322 | } |
| 323 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 324 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 325 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 326 | } |
| 327 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 328 | /////////////////////////////////////////////////////////////////////// |
| 329 | // |
| 330 | // Errors |
| 331 | // |
| 332 | //////////////////////////////////////////////////////////////////////// |
| 333 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 334 | // |
| 335 | // Used by flex/bison to output all syntax and parsing errors. |
| 336 | // |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 337 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 338 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 339 | mDiagnostics->error(loc, reason, token); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 340 | } |
| 341 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 342 | void TParseContext::error(const TSourceLoc &loc, const char *reason, const ImmutableString &token) |
| 343 | { |
| 344 | mDiagnostics->error(loc, reason, token.data()); |
| 345 | } |
| 346 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 347 | void TParseContext::warning(const TSourceLoc &loc, const char *reason, const char *token) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 348 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 349 | mDiagnostics->warning(loc, reason, token); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 350 | } |
| 351 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 352 | void TParseContext::outOfRangeError(bool isError, |
| 353 | const TSourceLoc &loc, |
| 354 | const char *reason, |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 355 | const char *token) |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 356 | { |
| 357 | if (isError) |
| 358 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 359 | error(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 360 | } |
| 361 | else |
| 362 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 363 | warning(loc, reason, token); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 364 | } |
| 365 | } |
| 366 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 367 | // |
| 368 | // Same error message for all places assignments don't work. |
| 369 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 370 | void TParseContext::assignError(const TSourceLoc &line, const char *op, TString left, TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 371 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 372 | std::stringstream reasonStream; |
| 373 | reasonStream << "cannot convert from '" << right << "' to '" << left << "'"; |
| 374 | std::string reason = reasonStream.str(); |
| 375 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 376 | } |
| 377 | |
| 378 | // |
| 379 | // Same error message for all places unary operations don't work. |
| 380 | // |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 381 | void TParseContext::unaryOpError(const TSourceLoc &line, const char *op, TString operand) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 382 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 383 | std::stringstream reasonStream; |
| 384 | reasonStream << "wrong operand type - no operation '" << op |
| 385 | << "' exists that takes an operand of type " << operand |
| 386 | << " (or there is no acceptable conversion)"; |
| 387 | std::string reason = reasonStream.str(); |
| 388 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 389 | } |
| 390 | |
| 391 | // |
| 392 | // Same error message for all binary operations don't work. |
| 393 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 394 | void TParseContext::binaryOpError(const TSourceLoc &line, |
| 395 | const char *op, |
| 396 | TString left, |
| 397 | TString right) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 398 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 399 | std::stringstream reasonStream; |
| 400 | reasonStream << "wrong operand types - no operation '" << op |
| 401 | << "' exists that takes a left-hand operand of type '" << left |
| 402 | << "' and a right operand of type '" << right |
| 403 | << "' (or there is no acceptable conversion)"; |
| 404 | std::string reason = reasonStream.str(); |
| 405 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 406 | } |
| 407 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 408 | void TParseContext::checkPrecisionSpecified(const TSourceLoc &line, |
| 409 | TPrecision precision, |
| 410 | TBasicType type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 411 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 412 | if (!mChecksPrecisionErrors) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 413 | return; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 414 | |
| 415 | if (precision != EbpUndefined && !SupportsPrecision(type)) |
| 416 | { |
| 417 | error(line, "illegal type for precision qualifier", getBasicString(type)); |
| 418 | } |
| 419 | |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 420 | if (precision == EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 421 | { |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 422 | switch (type) |
| 423 | { |
| 424 | case EbtFloat: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 425 | error(line, "No precision specified for (float)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 426 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 427 | case EbtInt: |
| 428 | case EbtUInt: |
| 429 | UNREACHABLE(); // there's always a predeclared qualifier |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 430 | error(line, "No precision specified (int)", ""); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 431 | return; |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 432 | default: |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 433 | if (IsOpaqueType(type)) |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 434 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 435 | error(line, "No precision specified", getBasicString(type)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 436 | return; |
| 437 | } |
Olli Etuaho | 183d7e2 | 2015-11-20 15:59:09 +0200 | [diff] [blame] | 438 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 439 | } |
daniel@transgaming.com | a5d7623 | 2010-05-17 09:58:47 +0000 | [diff] [blame] | 440 | } |
| 441 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 442 | void TParseContext::markStaticReadIfSymbol(TIntermNode *node) |
| 443 | { |
| 444 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
| 445 | if (swizzleNode) |
| 446 | { |
| 447 | markStaticReadIfSymbol(swizzleNode->getOperand()); |
| 448 | return; |
| 449 | } |
| 450 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
| 451 | if (binaryNode) |
| 452 | { |
| 453 | switch (binaryNode->getOp()) |
| 454 | { |
| 455 | case EOpIndexDirect: |
| 456 | case EOpIndexIndirect: |
| 457 | case EOpIndexDirectStruct: |
| 458 | case EOpIndexDirectInterfaceBlock: |
| 459 | markStaticReadIfSymbol(binaryNode->getLeft()); |
| 460 | return; |
| 461 | default: |
| 462 | return; |
| 463 | } |
| 464 | } |
| 465 | TIntermSymbol *symbolNode = node->getAsSymbolNode(); |
| 466 | if (symbolNode) |
| 467 | { |
| 468 | symbolTable.markStaticRead(symbolNode->variable()); |
| 469 | } |
| 470 | } |
| 471 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 472 | // Both test and if necessary, spit out an error, to see if the node is really |
| 473 | // an l-value that can be operated on this way. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 474 | bool TParseContext::checkCanBeLValue(const TSourceLoc &line, const char *op, TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 475 | { |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 476 | TIntermSwizzle *swizzleNode = node->getAsSwizzleNode(); |
Olli Etuaho | b6fa043 | 2016-09-28 16:28:05 +0100 | [diff] [blame] | 477 | if (swizzleNode) |
| 478 | { |
| 479 | bool ok = checkCanBeLValue(line, op, swizzleNode->getOperand()); |
| 480 | if (ok && swizzleNode->hasDuplicateOffsets()) |
| 481 | { |
| 482 | error(line, " l-value of swizzle cannot have duplicate components", op); |
| 483 | return false; |
| 484 | } |
| 485 | return ok; |
| 486 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 487 | |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 488 | TIntermBinary *binaryNode = node->getAsBinaryNode(); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 489 | if (binaryNode) |
| 490 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 491 | switch (binaryNode->getOp()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 492 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 493 | case EOpIndexDirect: |
| 494 | case EOpIndexIndirect: |
| 495 | case EOpIndexDirectStruct: |
| 496 | case EOpIndexDirectInterfaceBlock: |
Qin Jiajia | 76bf01d | 2018-02-22 14:11:34 +0800 | [diff] [blame] | 497 | if (node->getMemoryQualifier().readonly) |
| 498 | { |
| 499 | error(line, "can't modify a readonly variable", op); |
| 500 | return false; |
| 501 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 502 | return checkCanBeLValue(line, op, binaryNode->getLeft()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 503 | default: |
| 504 | break; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 505 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 506 | error(line, " l-value required", op); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 507 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 508 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 509 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 510 | std::string message; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 511 | switch (node->getQualifier()) |
| 512 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 513 | case EvqConst: |
| 514 | message = "can't modify a const"; |
| 515 | break; |
| 516 | case EvqConstReadOnly: |
| 517 | message = "can't modify a const"; |
| 518 | break; |
| 519 | case EvqAttribute: |
| 520 | message = "can't modify an attribute"; |
| 521 | break; |
| 522 | case EvqFragmentIn: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 523 | case EvqVertexIn: |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 524 | case EvqGeometryIn: |
Jiawei Shao | e8ef2bc | 2017-08-29 13:38:57 +0800 | [diff] [blame] | 525 | case EvqFlatIn: |
| 526 | case EvqSmoothIn: |
| 527 | case EvqCentroidIn: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 528 | message = "can't modify an input"; |
| 529 | break; |
| 530 | case EvqUniform: |
| 531 | message = "can't modify a uniform"; |
| 532 | break; |
| 533 | case EvqVaryingIn: |
| 534 | message = "can't modify a varying"; |
| 535 | break; |
| 536 | case EvqFragCoord: |
| 537 | message = "can't modify gl_FragCoord"; |
| 538 | break; |
| 539 | case EvqFrontFacing: |
| 540 | message = "can't modify gl_FrontFacing"; |
| 541 | break; |
| 542 | case EvqPointCoord: |
| 543 | message = "can't modify gl_PointCoord"; |
| 544 | break; |
Martin Radev | b088360 | 2016-08-04 17:48:58 +0300 | [diff] [blame] | 545 | case EvqNumWorkGroups: |
| 546 | message = "can't modify gl_NumWorkGroups"; |
| 547 | break; |
| 548 | case EvqWorkGroupSize: |
| 549 | message = "can't modify gl_WorkGroupSize"; |
| 550 | break; |
| 551 | case EvqWorkGroupID: |
| 552 | message = "can't modify gl_WorkGroupID"; |
| 553 | break; |
| 554 | case EvqLocalInvocationID: |
| 555 | message = "can't modify gl_LocalInvocationID"; |
| 556 | break; |
| 557 | case EvqGlobalInvocationID: |
| 558 | message = "can't modify gl_GlobalInvocationID"; |
| 559 | break; |
| 560 | case EvqLocalInvocationIndex: |
| 561 | message = "can't modify gl_LocalInvocationIndex"; |
| 562 | break; |
Olli Etuaho | 7142f6c | 2017-05-05 17:07:26 +0300 | [diff] [blame] | 563 | case EvqViewIDOVR: |
| 564 | message = "can't modify gl_ViewID_OVR"; |
| 565 | break; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 566 | case EvqComputeIn: |
| 567 | message = "can't modify work group size variable"; |
| 568 | break; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 569 | case EvqPerVertexIn: |
| 570 | message = "can't modify any member in gl_in"; |
| 571 | break; |
Jiawei Shao | d27f5c8 | 2017-08-23 09:38:08 +0800 | [diff] [blame] | 572 | case EvqPrimitiveIDIn: |
| 573 | message = "can't modify gl_PrimitiveIDIn"; |
| 574 | break; |
| 575 | case EvqInvocationID: |
| 576 | message = "can't modify gl_InvocationID"; |
| 577 | break; |
| 578 | case EvqPrimitiveID: |
| 579 | if (mShaderType == GL_FRAGMENT_SHADER) |
| 580 | { |
| 581 | message = "can't modify gl_PrimitiveID in a fragment shader"; |
| 582 | } |
| 583 | break; |
| 584 | case EvqLayer: |
| 585 | if (mShaderType == GL_FRAGMENT_SHADER) |
| 586 | { |
| 587 | message = "can't modify gl_Layer in a fragment shader"; |
| 588 | } |
| 589 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 590 | default: |
| 591 | // |
| 592 | // Type that can't be written to? |
| 593 | // |
| 594 | if (node->getBasicType() == EbtVoid) |
| 595 | { |
| 596 | message = "can't modify void"; |
| 597 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 598 | if (IsOpaqueType(node->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 599 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 600 | message = "can't modify a variable with type "; |
| 601 | message += getBasicString(node->getBasicType()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 602 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 603 | else if (node->getMemoryQualifier().readonly) |
| 604 | { |
| 605 | message = "can't modify a readonly variable"; |
| 606 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 607 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 608 | |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 609 | ASSERT(binaryNode == nullptr && swizzleNode == nullptr); |
| 610 | TIntermSymbol *symNode = node->getAsSymbolNode(); |
| 611 | if (message.empty() && symNode != nullptr) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 612 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 613 | symbolTable.markStaticWrite(symNode->variable()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 614 | return true; |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 615 | } |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 616 | |
| 617 | std::stringstream reasonStream; |
| 618 | reasonStream << "l-value required"; |
| 619 | if (!message.empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 620 | { |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 621 | if (symNode) |
| 622 | { |
| 623 | // Symbol inside an expression can't be nameless. |
| 624 | ASSERT(symNode->variable().symbolType() != SymbolType::Empty); |
| 625 | const ImmutableString &symbol = symNode->getName(); |
| 626 | reasonStream << " (" << message << " \"" << symbol << "\")"; |
| 627 | } |
| 628 | else |
| 629 | { |
| 630 | reasonStream << " (" << message << ")"; |
| 631 | } |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 632 | } |
Olli Etuaho | daf120b | 2018-03-20 14:21:10 +0200 | [diff] [blame] | 633 | std::string reason = reasonStream.str(); |
| 634 | error(line, reason.c_str(), op); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 635 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 636 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 637 | } |
| 638 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 639 | // Both test, and if necessary spit out an error, to see if the node is really |
| 640 | // a constant. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 641 | void TParseContext::checkIsConst(TIntermTyped *node) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 642 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 643 | if (node->getQualifier() != EvqConst) |
| 644 | { |
| 645 | error(node->getLine(), "constant expression required", ""); |
| 646 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 647 | } |
| 648 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 649 | // Both test, and if necessary spit out an error, to see if the node is really |
| 650 | // an integer. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 651 | void TParseContext::checkIsScalarInteger(TIntermTyped *node, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 652 | { |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 653 | if (!node->isScalarInt()) |
| 654 | { |
| 655 | error(node->getLine(), "integer expression required", token); |
| 656 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 657 | } |
| 658 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 659 | // Both test, and if necessary spit out an error, to see if we are currently |
| 660 | // globally scoped. |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 661 | bool TParseContext::checkIsAtGlobalLevel(const TSourceLoc &line, const char *token) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 662 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 663 | if (!symbolTable.atGlobalLevel()) |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 664 | { |
| 665 | error(line, "only allowed at global scope", token); |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 666 | return false; |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 667 | } |
Qiankun Miao | f69682b | 2016-08-16 14:50:42 +0800 | [diff] [blame] | 668 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 669 | } |
| 670 | |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 671 | // ESSL 3.00.5 sections 3.8 and 3.9. |
| 672 | // If it starts "gl_" or contains two consecutive underscores, it's reserved. |
| 673 | // Also checks for "webgl_" and "_webgl_" reserved identifiers if parsing a webgl shader. |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 674 | bool TParseContext::checkIsNotReserved(const TSourceLoc &line, const ImmutableString &identifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 675 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 676 | static const char *reservedErrMsg = "reserved built-in name"; |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 677 | if (identifier.beginsWith("gl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 678 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 679 | error(line, reservedErrMsg, "gl_"); |
| 680 | return false; |
| 681 | } |
| 682 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
| 683 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 684 | if (identifier.beginsWith("webgl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 685 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 686 | error(line, reservedErrMsg, "webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 687 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 688 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 689 | if (identifier.beginsWith("_webgl_")) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 690 | { |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 691 | error(line, reservedErrMsg, "_webgl_"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 692 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 693 | } |
| 694 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 695 | if (identifier.contains("__")) |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 696 | { |
| 697 | error(line, |
| 698 | "identifiers containing two consecutive underscores (__) are reserved as " |
| 699 | "possible future keywords", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 700 | identifier); |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 701 | return false; |
| 702 | } |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 703 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 704 | } |
| 705 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 706 | // Make sure the argument types are correct for constructing a specific type. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 707 | bool TParseContext::checkConstructorArguments(const TSourceLoc &line, |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 708 | const TIntermSequence &arguments, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 709 | const TType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 710 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 711 | if (arguments.empty()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 712 | { |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 713 | error(line, "constructor does not have any arguments", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 714 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 715 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 716 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 717 | for (TIntermNode *arg : arguments) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 718 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 719 | markStaticReadIfSymbol(arg); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 720 | const TIntermTyped *argTyped = arg->getAsTyped(); |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 721 | ASSERT(argTyped != nullptr); |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 722 | if (type.getBasicType() != EbtStruct && IsOpaqueType(argTyped->getBasicType())) |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 723 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 724 | std::string reason("cannot convert a variable with type "); |
| 725 | reason += getBasicString(argTyped->getBasicType()); |
| 726 | error(line, reason.c_str(), "constructor"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 727 | return false; |
| 728 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 729 | else if (argTyped->getMemoryQualifier().writeonly) |
| 730 | { |
| 731 | error(line, "cannot convert a variable with writeonly", "constructor"); |
| 732 | return false; |
| 733 | } |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 734 | if (argTyped->getBasicType() == EbtVoid) |
| 735 | { |
| 736 | error(line, "cannot convert a void", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 737 | return false; |
Olli Etuaho | 15c2ac3 | 2015-11-09 15:51:43 +0200 | [diff] [blame] | 738 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 739 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 740 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 741 | if (type.isArray()) |
| 742 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 743 | // The size of an unsized constructor should already have been determined. |
| 744 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 745 | if (static_cast<size_t>(type.getOutermostArraySize()) != arguments.size()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 746 | { |
| 747 | error(line, "array constructor needs one argument per array element", "constructor"); |
| 748 | return false; |
| 749 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 750 | // GLSL ES 3.00 section 5.4.4: Each argument must be the same type as the element type of |
| 751 | // the array. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 752 | for (TIntermNode *const &argNode : arguments) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 753 | { |
| 754 | const TType &argType = argNode->getAsTyped()->getType(); |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 755 | if (mShaderVersion < 310 && argType.isArray()) |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 756 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 757 | error(line, "constructing from a non-dereferenced array", "constructor"); |
Jamie Madill | 34bf2d9 | 2017-02-06 13:40:59 -0500 | [diff] [blame] | 758 | return false; |
| 759 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 760 | if (!argType.isElementTypeOf(type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 761 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 762 | error(line, "Array constructor argument has an incorrect type", "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 763 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 764 | } |
| 765 | } |
| 766 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 767 | else if (type.getBasicType() == EbtStruct) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 768 | { |
| 769 | const TFieldList &fields = type.getStruct()->fields(); |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 770 | if (fields.size() != arguments.size()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 771 | { |
| 772 | error(line, |
| 773 | "Number of constructor parameters does not match the number of structure fields", |
| 774 | "constructor"); |
| 775 | return false; |
| 776 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 777 | |
| 778 | for (size_t i = 0; i < fields.size(); i++) |
| 779 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 780 | if (i >= arguments.size() || |
| 781 | arguments[i]->getAsTyped()->getType() != *fields[i]->type()) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 782 | { |
| 783 | error(line, "Structure constructor arguments do not match structure fields", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 784 | "constructor"); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 785 | return false; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 786 | } |
| 787 | } |
| 788 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 789 | else |
| 790 | { |
| 791 | // We're constructing a scalar, vector, or matrix. |
| 792 | |
| 793 | // Note: It's okay to have too many components available, but not okay to have unused |
| 794 | // arguments. 'full' will go to true when enough args have been seen. If we loop again, |
| 795 | // there is an extra argument, so 'overFull' will become true. |
| 796 | |
| 797 | size_t size = 0; |
| 798 | bool full = false; |
| 799 | bool overFull = false; |
| 800 | bool matrixArg = false; |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 801 | for (TIntermNode *arg : arguments) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 802 | { |
| 803 | const TIntermTyped *argTyped = arg->getAsTyped(); |
| 804 | ASSERT(argTyped != nullptr); |
| 805 | |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 806 | if (argTyped->getBasicType() == EbtStruct) |
| 807 | { |
| 808 | error(line, "a struct cannot be used as a constructor argument for this type", |
| 809 | "constructor"); |
| 810 | return false; |
| 811 | } |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 812 | if (argTyped->getType().isArray()) |
| 813 | { |
| 814 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 815 | return false; |
| 816 | } |
| 817 | if (argTyped->getType().isMatrix()) |
| 818 | { |
| 819 | matrixArg = true; |
| 820 | } |
| 821 | |
| 822 | size += argTyped->getType().getObjectSize(); |
| 823 | if (full) |
| 824 | { |
| 825 | overFull = true; |
| 826 | } |
Olli Etuaho | 487b63a | 2017-05-23 15:55:09 +0300 | [diff] [blame] | 827 | if (size >= type.getObjectSize()) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 828 | { |
| 829 | full = true; |
| 830 | } |
| 831 | } |
| 832 | |
| 833 | if (type.isMatrix() && matrixArg) |
| 834 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 835 | if (arguments.size() != 1) |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 836 | { |
| 837 | error(line, "constructing matrix from matrix can only take one argument", |
| 838 | "constructor"); |
| 839 | return false; |
| 840 | } |
| 841 | } |
| 842 | else |
| 843 | { |
| 844 | if (size != 1 && size < type.getObjectSize()) |
| 845 | { |
| 846 | error(line, "not enough data provided for construction", "constructor"); |
| 847 | return false; |
| 848 | } |
| 849 | if (overFull) |
| 850 | { |
| 851 | error(line, "too many arguments", "constructor"); |
| 852 | return false; |
| 853 | } |
| 854 | } |
| 855 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 856 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 857 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 858 | } |
| 859 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 860 | // This function checks to see if a void variable has been declared and raise an error message for |
| 861 | // such a case |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 862 | // |
| 863 | // returns true in case of an error |
| 864 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 865 | bool TParseContext::checkIsNonVoid(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 866 | const ImmutableString &identifier, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 867 | const TBasicType &type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 868 | { |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 869 | if (type == EbtVoid) |
| 870 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 871 | error(line, "illegal use of type 'void'", identifier); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 872 | return false; |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 873 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 874 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 875 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 876 | } |
| 877 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 878 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 879 | // or not. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 880 | bool TParseContext::checkIsScalarBool(const TSourceLoc &line, const TIntermTyped *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 881 | { |
Olli Etuaho | 37d96cc | 2017-07-11 14:14:03 +0300 | [diff] [blame] | 882 | if (type->getBasicType() != EbtBool || !type->isScalar()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 883 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 884 | error(line, "boolean expression expected", ""); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 885 | return false; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 886 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 887 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 888 | } |
| 889 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 890 | // This function checks to see if the node (for the expression) contains a scalar boolean expression |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 891 | // or not. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 892 | void TParseContext::checkIsScalarBool(const TSourceLoc &line, const TPublicType &pType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 893 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 894 | if (pType.getBasicType() != EbtBool || pType.isAggregate()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 895 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 896 | error(line, "boolean expression expected", ""); |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 897 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 898 | } |
| 899 | |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 900 | bool TParseContext::checkIsNotOpaqueType(const TSourceLoc &line, |
| 901 | const TTypeSpecifierNonArray &pType, |
| 902 | const char *reason) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 903 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 904 | if (pType.type == EbtStruct) |
| 905 | { |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 906 | if (ContainsSampler(pType.userDef)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 907 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 908 | std::stringstream reasonStream; |
| 909 | reasonStream << reason << " (structure contains a sampler)"; |
| 910 | std::string reasonStr = reasonStream.str(); |
| 911 | error(line, reasonStr.c_str(), getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 912 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 913 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 914 | // only samplers need to be checked from structs, since other opaque types can't be struct |
| 915 | // members. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 916 | return true; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 917 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 918 | else if (IsOpaqueType(pType.type)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 919 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 920 | error(line, reason, getBasicString(pType.type)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 921 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 922 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 923 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 924 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 925 | } |
| 926 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 927 | void TParseContext::checkDeclaratorLocationIsNotSpecified(const TSourceLoc &line, |
| 928 | const TPublicType &pType) |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 929 | { |
| 930 | if (pType.layoutQualifier.location != -1) |
| 931 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 932 | error(line, "location must only be specified for a single input or output variable", |
| 933 | "location"); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 934 | } |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 935 | } |
| 936 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 937 | void TParseContext::checkLocationIsNotSpecified(const TSourceLoc &location, |
| 938 | const TLayoutQualifier &layoutQualifier) |
| 939 | { |
| 940 | if (layoutQualifier.location != -1) |
| 941 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 942 | const char *errorMsg = "invalid layout qualifier: only valid on program inputs and outputs"; |
| 943 | if (mShaderVersion >= 310) |
| 944 | { |
| 945 | errorMsg = |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 946 | "invalid layout qualifier: only valid on shader inputs, outputs, and uniforms"; |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 947 | } |
| 948 | error(location, errorMsg, "location"); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 949 | } |
| 950 | } |
| 951 | |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 952 | void TParseContext::checkStd430IsForShaderStorageBlock(const TSourceLoc &location, |
| 953 | const TLayoutBlockStorage &blockStorage, |
| 954 | const TQualifier &qualifier) |
| 955 | { |
| 956 | if (blockStorage == EbsStd430 && qualifier != EvqBuffer) |
| 957 | { |
| 958 | error(location, "The std430 layout is supported only for shader storage blocks.", "std430"); |
| 959 | } |
| 960 | } |
| 961 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 962 | void TParseContext::checkOutParameterIsNotOpaqueType(const TSourceLoc &line, |
| 963 | TQualifier qualifier, |
| 964 | const TType &type) |
| 965 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 966 | ASSERT(qualifier == EvqOut || qualifier == EvqInOut); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 967 | if (IsOpaqueType(type.getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 968 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 969 | error(line, "opaque types cannot be output parameters", type.getBasicString()); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 970 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 971 | } |
| 972 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 973 | // Do size checking for an array type's size. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 974 | unsigned int TParseContext::checkIsValidArraySize(const TSourceLoc &line, TIntermTyped *expr) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 975 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 976 | TIntermConstantUnion *constant = expr->getAsConstantUnion(); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 977 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 978 | // TODO(oetuaho@nvidia.com): Get rid of the constant == nullptr check here once all constant |
| 979 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 980 | // fold as array size. |
| 981 | if (expr->getQualifier() != EvqConst || constant == nullptr || !constant->isScalarInt()) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 982 | { |
maxvujovic@gmail.com | c6b3b3c | 2012-06-27 22:49:39 +0000 | [diff] [blame] | 983 | error(line, "array size must be a constant integer expression", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 984 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 985 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 986 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 987 | unsigned int size = 0u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 988 | |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 989 | if (constant->getBasicType() == EbtUInt) |
| 990 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 991 | size = constant->getUConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 992 | } |
| 993 | else |
| 994 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 995 | int signedSize = constant->getIConst(0); |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 996 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 997 | if (signedSize < 0) |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 998 | { |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 999 | error(line, "array size must be non-negative", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1000 | return 1u; |
shannonwoods@chromium.org | 6b70991 | 2013-05-30 00:20:04 +0000 | [diff] [blame] | 1001 | } |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1002 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1003 | size = static_cast<unsigned int>(signedSize); |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1004 | } |
| 1005 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1006 | if (size == 0u) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1007 | { |
| 1008 | error(line, "array size must be greater than zero", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1009 | return 1u; |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1010 | } |
| 1011 | |
| 1012 | // The size of arrays is restricted here to prevent issues further down the |
| 1013 | // compiler/translator/driver stack. Shader Model 5 generation hardware is limited to |
| 1014 | // 4096 registers so this should be reasonable even for aggressively optimizable code. |
| 1015 | const unsigned int sizeLimit = 65536; |
| 1016 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1017 | if (size > sizeLimit) |
Nicolas Capens | 906744a | 2014-06-06 15:18:07 -0400 | [diff] [blame] | 1018 | { |
| 1019 | error(line, "array size too large", ""); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1020 | return 1u; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1021 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1022 | |
| 1023 | return size; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1024 | } |
| 1025 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1026 | // See if this qualifier can be an array. |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1027 | bool TParseContext::checkIsValidQualifierForArray(const TSourceLoc &line, |
| 1028 | const TPublicType &elementQualifier) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1029 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1030 | if ((elementQualifier.qualifier == EvqAttribute) || |
| 1031 | (elementQualifier.qualifier == EvqVertexIn) || |
| 1032 | (elementQualifier.qualifier == EvqConst && mShaderVersion < 300)) |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1033 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1034 | error(line, "cannot declare arrays of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1035 | TType(elementQualifier).getQualifierString()); |
| 1036 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1037 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1038 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1039 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1040 | } |
| 1041 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1042 | // See if this element type can be formed into an array. |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1043 | bool TParseContext::checkArrayElementIsNotArray(const TSourceLoc &line, |
| 1044 | const TPublicType &elementType) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1045 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 1046 | if (mShaderVersion < 310 && elementType.isArray()) |
Jamie Madill | 0614523 | 2015-05-13 13:10:01 -0400 | [diff] [blame] | 1047 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1048 | error(line, "cannot declare arrays of arrays", |
| 1049 | TType(elementType).getCompleteString().c_str()); |
| 1050 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1051 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1052 | return true; |
| 1053 | } |
| 1054 | |
| 1055 | // Check if this qualified element type can be formed into an array. This is only called when array |
| 1056 | // brackets are associated with an identifier in a declaration, like this: |
| 1057 | // float a[2]; |
| 1058 | // Similar checks are done in addFullySpecifiedType for array declarations where the array brackets |
| 1059 | // are associated with the type, like this: |
| 1060 | // float[2] a; |
| 1061 | bool TParseContext::checkIsValidTypeAndQualifierForArray(const TSourceLoc &indexLocation, |
| 1062 | const TPublicType &elementType) |
| 1063 | { |
| 1064 | if (!checkArrayElementIsNotArray(indexLocation, elementType)) |
| 1065 | { |
| 1066 | return false; |
| 1067 | } |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1068 | // In ESSL1.00 shaders, structs cannot be varying (section 4.3.5). This is checked elsewhere. |
| 1069 | // In ESSL3.00 shaders, struct inputs/outputs are allowed but not arrays of structs (section |
| 1070 | // 4.3.4). |
Jiawei Shao | 492b5f5 | 2017-12-13 09:39:27 +0800 | [diff] [blame] | 1071 | // Geometry shader requires each user-defined input be declared as arrays or inside input |
| 1072 | // blocks declared as arrays (GL_EXT_geometry_shader section 11.1gs.4.3). For the purposes of |
| 1073 | // interface matching, such variables and blocks are treated as though they were not declared |
| 1074 | // as arrays (GL_EXT_geometry_shader section 7.4.1). |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1075 | if (mShaderVersion >= 300 && elementType.getBasicType() == EbtStruct && |
Jiawei Shao | 492b5f5 | 2017-12-13 09:39:27 +0800 | [diff] [blame] | 1076 | sh::IsVarying(elementType.qualifier) && |
| 1077 | !IsGeometryShaderInput(mShaderType, elementType.qualifier)) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1078 | { |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1079 | error(indexLocation, "cannot declare arrays of structs of this qualifier", |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1080 | TType(elementType).getCompleteString().c_str()); |
| 1081 | return false; |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 1082 | } |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 1083 | return checkIsValidQualifierForArray(indexLocation, elementType); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1084 | } |
| 1085 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1086 | // Enforce non-initializer type/qualifier rules. |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1087 | void TParseContext::checkCanBeDeclaredWithoutInitializer(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1088 | const ImmutableString &identifier, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1089 | TType *type) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1090 | { |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1091 | ASSERT(type != nullptr); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1092 | if (type->getQualifier() == EvqConst) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1093 | { |
| 1094 | // Make the qualifier make sense. |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1095 | type->setQualifier(EvqTemporary); |
Olli Etuaho | 3739d23 | 2015-04-08 12:23:44 +0300 | [diff] [blame] | 1096 | |
| 1097 | // Generate informative error messages for ESSL1. |
| 1098 | // In ESSL3 arrays and structures containing arrays can be constant. |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1099 | if (mShaderVersion < 300 && type->isStructureContainingArrays()) |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1100 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1101 | error(line, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1102 | "structures containing arrays may not be declared constant since they cannot be " |
| 1103 | "initialized", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1104 | identifier); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1105 | } |
| 1106 | else |
| 1107 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1108 | error(line, "variables with qualifier 'const' must be initialized", identifier); |
daniel@transgaming.com | 8abd0b7 | 2012-09-27 17:46:07 +0000 | [diff] [blame] | 1109 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1110 | } |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1111 | // This will make the type sized if it isn't sized yet. |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1112 | checkIsNotUnsizedArray(line, "implicitly sized arrays need to be initialized", identifier, |
| 1113 | type); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1114 | } |
| 1115 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1116 | // Do some simple checks that are shared between all variable declarations, |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1117 | // and update the symbol table. |
| 1118 | // |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1119 | // Returns true if declaring the variable succeeded. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1120 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1121 | bool TParseContext::declareVariable(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1122 | const ImmutableString &identifier, |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1123 | const TType *type, |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1124 | TVariable **variable) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1125 | { |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1126 | ASSERT((*variable) == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1127 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1128 | (*variable) = new TVariable(&symbolTable, identifier, type, SymbolType::UserDefined); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1129 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1130 | checkBindingIsValid(line, *type); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1131 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1132 | bool needsReservedCheck = true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1133 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1134 | // gl_LastFragData may be redeclared with a new precision qualifier |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1135 | if (type->isArray() && identifier.beginsWith("gl_LastFragData")) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1136 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1137 | const TVariable *maxDrawBuffers = static_cast<const TVariable *>( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1138 | symbolTable.findBuiltIn(ImmutableString("gl_MaxDrawBuffers"), mShaderVersion)); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1139 | if (type->isArrayOfArrays()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1140 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1141 | error(line, "redeclaration of gl_LastFragData as an array of arrays", identifier); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1142 | return false; |
| 1143 | } |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1144 | else if (static_cast<int>(type->getOutermostArraySize()) == |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1145 | maxDrawBuffers->getConstPointer()->getIConst()) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1146 | { |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 1147 | if (const TSymbol *builtInSymbol = symbolTable.findBuiltIn(identifier, mShaderVersion)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1148 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1149 | needsReservedCheck = !checkCanUseExtension(line, builtInSymbol->extension()); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1150 | } |
| 1151 | } |
| 1152 | else |
| 1153 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1154 | error(line, "redeclaration of gl_LastFragData with size != gl_MaxDrawBuffers", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1155 | identifier); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1156 | return false; |
| 1157 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1158 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1159 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1160 | if (needsReservedCheck && !checkIsNotReserved(line, identifier)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1161 | return false; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1162 | |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 1163 | if (!symbolTable.declare(*variable)) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1164 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1165 | error(line, "redefinition", identifier); |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1166 | return false; |
| 1167 | } |
| 1168 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1169 | if (!checkIsNonVoid(line, identifier, type->getBasicType())) |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1170 | return false; |
| 1171 | |
| 1172 | return true; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1173 | } |
| 1174 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1175 | void TParseContext::checkIsParameterQualifierValid( |
| 1176 | const TSourceLoc &line, |
| 1177 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 1178 | TType *type) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1179 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 1180 | // The only parameter qualifiers a parameter can have are in, out, inout or const. |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 1181 | TTypeQualifier typeQualifier = typeQualifierBuilder.getParameterTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1182 | |
| 1183 | if (typeQualifier.qualifier == EvqOut || typeQualifier.qualifier == EvqInOut) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1184 | { |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1185 | checkOutParameterIsNotOpaqueType(line, typeQualifier.qualifier, *type); |
| 1186 | } |
| 1187 | |
| 1188 | if (!IsImage(type->getBasicType())) |
| 1189 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1190 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1191 | } |
| 1192 | else |
| 1193 | { |
| 1194 | type->setMemoryQualifier(typeQualifier.memoryQualifier); |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1195 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1196 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1197 | type->setQualifier(typeQualifier.qualifier); |
| 1198 | |
| 1199 | if (typeQualifier.precision != EbpUndefined) |
| 1200 | { |
| 1201 | type->setPrecision(typeQualifier.precision); |
| 1202 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1203 | } |
| 1204 | |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 1205 | template <size_t size> |
| 1206 | bool TParseContext::checkCanUseOneOfExtensions(const TSourceLoc &line, |
| 1207 | const std::array<TExtension, size> &extensions) |
| 1208 | { |
| 1209 | ASSERT(!extensions.empty()); |
| 1210 | const TExtensionBehavior &extBehavior = extensionBehavior(); |
| 1211 | |
| 1212 | bool canUseWithWarning = false; |
| 1213 | bool canUseWithoutWarning = false; |
| 1214 | |
| 1215 | const char *errorMsgString = ""; |
| 1216 | TExtension errorMsgExtension = TExtension::UNDEFINED; |
| 1217 | |
| 1218 | for (TExtension extension : extensions) |
| 1219 | { |
| 1220 | auto extIter = extBehavior.find(extension); |
| 1221 | if (canUseWithWarning) |
| 1222 | { |
| 1223 | // We already have an extension that we can use, but with a warning. |
| 1224 | // See if we can use the alternative extension without a warning. |
| 1225 | if (extIter == extBehavior.end()) |
| 1226 | { |
| 1227 | continue; |
| 1228 | } |
| 1229 | if (extIter->second == EBhEnable || extIter->second == EBhRequire) |
| 1230 | { |
| 1231 | canUseWithoutWarning = true; |
| 1232 | break; |
| 1233 | } |
| 1234 | continue; |
| 1235 | } |
| 1236 | if (extIter == extBehavior.end()) |
| 1237 | { |
| 1238 | errorMsgString = "extension is not supported"; |
| 1239 | errorMsgExtension = extension; |
| 1240 | } |
| 1241 | else if (extIter->second == EBhUndefined || extIter->second == EBhDisable) |
| 1242 | { |
| 1243 | errorMsgString = "extension is disabled"; |
| 1244 | errorMsgExtension = extension; |
| 1245 | } |
| 1246 | else if (extIter->second == EBhWarn) |
| 1247 | { |
| 1248 | errorMsgExtension = extension; |
| 1249 | canUseWithWarning = true; |
| 1250 | } |
| 1251 | else |
| 1252 | { |
| 1253 | ASSERT(extIter->second == EBhEnable || extIter->second == EBhRequire); |
| 1254 | canUseWithoutWarning = true; |
| 1255 | break; |
| 1256 | } |
| 1257 | } |
| 1258 | |
| 1259 | if (canUseWithoutWarning) |
| 1260 | { |
| 1261 | return true; |
| 1262 | } |
| 1263 | if (canUseWithWarning) |
| 1264 | { |
| 1265 | warning(line, "extension is being used", GetExtensionNameString(errorMsgExtension)); |
| 1266 | return true; |
| 1267 | } |
| 1268 | error(line, errorMsgString, GetExtensionNameString(errorMsgExtension)); |
| 1269 | return false; |
| 1270 | } |
| 1271 | |
| 1272 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1273 | const TSourceLoc &line, |
| 1274 | const std::array<TExtension, 1> &extensions); |
| 1275 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1276 | const TSourceLoc &line, |
| 1277 | const std::array<TExtension, 2> &extensions); |
| 1278 | template bool TParseContext::checkCanUseOneOfExtensions( |
| 1279 | const TSourceLoc &line, |
| 1280 | const std::array<TExtension, 3> &extensions); |
| 1281 | |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1282 | bool TParseContext::checkCanUseExtension(const TSourceLoc &line, TExtension extension) |
alokp@chromium.org | 8815d7f | 2010-09-09 17:30:03 +0000 | [diff] [blame] | 1283 | { |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1284 | ASSERT(extension != TExtension::UNDEFINED); |
Corentin Wallez | 1d33c21 | 2017-11-13 10:21:39 -0800 | [diff] [blame] | 1285 | return checkCanUseOneOfExtensions(line, std::array<TExtension, 1u>{{extension}}); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1286 | } |
| 1287 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1288 | // ESSL 3.00.6 section 4.8 Empty Declarations: "The combinations of qualifiers that cause |
| 1289 | // compile-time or link-time errors are the same whether or not the declaration is empty". |
| 1290 | // This function implements all the checks that are done on qualifiers regardless of if the |
| 1291 | // declaration is empty. |
| 1292 | void TParseContext::declarationQualifierErrorCheck(const sh::TQualifier qualifier, |
| 1293 | const sh::TLayoutQualifier &layoutQualifier, |
| 1294 | const TSourceLoc &location) |
| 1295 | { |
| 1296 | if (qualifier == EvqShared && !layoutQualifier.isEmpty()) |
| 1297 | { |
| 1298 | error(location, "Shared memory declarations cannot have layout specified", "layout"); |
| 1299 | } |
| 1300 | |
| 1301 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 1302 | { |
| 1303 | error(location, "layout qualifier only valid for interface blocks", |
| 1304 | getMatrixPackingString(layoutQualifier.matrixPacking)); |
| 1305 | return; |
| 1306 | } |
| 1307 | |
| 1308 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 1309 | { |
| 1310 | error(location, "layout qualifier only valid for interface blocks", |
| 1311 | getBlockStorageString(layoutQualifier.blockStorage)); |
| 1312 | return; |
| 1313 | } |
| 1314 | |
| 1315 | if (qualifier == EvqFragmentOut) |
| 1316 | { |
| 1317 | if (layoutQualifier.location != -1 && layoutQualifier.yuv == true) |
| 1318 | { |
| 1319 | error(location, "invalid layout qualifier combination", "yuv"); |
| 1320 | return; |
| 1321 | } |
| 1322 | } |
| 1323 | else |
| 1324 | { |
| 1325 | checkYuvIsNotSpecified(location, layoutQualifier.yuv); |
| 1326 | } |
| 1327 | |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1328 | // If multiview extension is enabled, "in" qualifier is allowed in the vertex shader in previous |
| 1329 | // parsing steps. So it needs to be checked here. |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1330 | if (isExtensionEnabled(TExtension::OVR_multiview) && mShaderVersion < 300 && |
| 1331 | qualifier == EvqVertexIn) |
Olli Etuaho | 95468d1 | 2017-05-04 11:14:34 +0300 | [diff] [blame] | 1332 | { |
| 1333 | error(location, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 1334 | } |
| 1335 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1336 | bool canHaveLocation = qualifier == EvqVertexIn || qualifier == EvqFragmentOut; |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 1337 | if (mShaderVersion >= 310) |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1338 | { |
Jiawei Shao | 4cc89e2 | 2017-08-31 14:25:54 +0800 | [diff] [blame] | 1339 | canHaveLocation = canHaveLocation || qualifier == EvqUniform || IsVarying(qualifier); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1340 | // We're not checking whether the uniform location is in range here since that depends on |
| 1341 | // the type of the variable. |
| 1342 | // The type can only be fully determined for non-empty declarations. |
| 1343 | } |
| 1344 | if (!canHaveLocation) |
| 1345 | { |
| 1346 | checkLocationIsNotSpecified(location, layoutQualifier); |
| 1347 | } |
| 1348 | } |
| 1349 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1350 | void TParseContext::atomicCounterQualifierErrorCheck(const TPublicType &publicType, |
| 1351 | const TSourceLoc &location) |
| 1352 | { |
| 1353 | if (publicType.precision != EbpHigh) |
| 1354 | { |
| 1355 | error(location, "Can only be highp", "atomic counter"); |
| 1356 | } |
| 1357 | // dEQP enforces compile error if location is specified. See uniform_location.test. |
| 1358 | if (publicType.layoutQualifier.location != -1) |
| 1359 | { |
| 1360 | error(location, "location must not be set for atomic_uint", "layout"); |
| 1361 | } |
| 1362 | if (publicType.layoutQualifier.binding == -1) |
| 1363 | { |
| 1364 | error(location, "no binding specified", "atomic counter"); |
| 1365 | } |
| 1366 | } |
| 1367 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1368 | void TParseContext::emptyDeclarationErrorCheck(const TType &type, const TSourceLoc &location) |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1369 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1370 | if (type.isUnsizedArray()) |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1371 | { |
| 1372 | // ESSL3 spec section 4.1.9: Array declaration which leaves the size unspecified is an |
| 1373 | // error. It is assumed that this applies to empty declarations as well. |
| 1374 | error(location, "empty array declaration needs to specify a size", ""); |
| 1375 | } |
Martin Radev | b8b0122 | 2016-11-20 23:25:53 +0200 | [diff] [blame] | 1376 | } |
| 1377 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1378 | // These checks are done for all declarations that are non-empty. They're done for non-empty |
| 1379 | // declarations starting a declarator list, and declarators that follow an empty declaration. |
| 1380 | void TParseContext::nonEmptyDeclarationErrorCheck(const TPublicType &publicType, |
| 1381 | const TSourceLoc &identifierLocation) |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1382 | { |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1383 | switch (publicType.qualifier) |
| 1384 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1385 | case EvqVaryingIn: |
| 1386 | case EvqVaryingOut: |
| 1387 | case EvqAttribute: |
| 1388 | case EvqVertexIn: |
| 1389 | case EvqFragmentOut: |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1390 | case EvqComputeIn: |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 1391 | if (publicType.getBasicType() == EbtStruct) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1392 | { |
| 1393 | error(identifierLocation, "cannot be used with a structure", |
| 1394 | getQualifierString(publicType.qualifier)); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1395 | return; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1396 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1397 | break; |
| 1398 | case EvqBuffer: |
| 1399 | if (publicType.getBasicType() != EbtInterfaceBlock) |
| 1400 | { |
| 1401 | error(identifierLocation, |
| 1402 | "cannot declare buffer variables at global scope(outside a block)", |
| 1403 | getQualifierString(publicType.qualifier)); |
| 1404 | return; |
| 1405 | } |
| 1406 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1407 | default: |
| 1408 | break; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 1409 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1410 | std::string reason(getBasicString(publicType.getBasicType())); |
| 1411 | reason += "s must be uniform"; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1412 | if (publicType.qualifier != EvqUniform && |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 1413 | !checkIsNotOpaqueType(identifierLocation, publicType.typeSpecifierNonArray, reason.c_str())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1414 | { |
| 1415 | return; |
| 1416 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1417 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1418 | if ((publicType.qualifier != EvqTemporary && publicType.qualifier != EvqGlobal && |
| 1419 | publicType.qualifier != EvqConst) && |
| 1420 | publicType.getBasicType() == EbtYuvCscStandardEXT) |
| 1421 | { |
| 1422 | error(identifierLocation, "cannot be used with a yuvCscStandardEXT", |
| 1423 | getQualifierString(publicType.qualifier)); |
| 1424 | return; |
| 1425 | } |
| 1426 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1427 | if (mShaderVersion >= 310 && publicType.qualifier == EvqUniform) |
| 1428 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1429 | // Valid uniform declarations can't be unsized arrays since uniforms can't be initialized. |
| 1430 | // But invalid shaders may still reach here with an unsized array declaration. |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 1431 | TType type(publicType); |
| 1432 | if (!type.isUnsizedArray()) |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1433 | { |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1434 | checkUniformLocationInRange(identifierLocation, type.getLocationCount(), |
| 1435 | publicType.layoutQualifier); |
| 1436 | } |
| 1437 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1438 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 1439 | // check for layout qualifier issues |
| 1440 | const TLayoutQualifier layoutQualifier = publicType.layoutQualifier; |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1441 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1442 | if (IsImage(publicType.getBasicType())) |
| 1443 | { |
| 1444 | |
| 1445 | switch (layoutQualifier.imageInternalFormat) |
| 1446 | { |
| 1447 | case EiifRGBA32F: |
| 1448 | case EiifRGBA16F: |
| 1449 | case EiifR32F: |
| 1450 | case EiifRGBA8: |
| 1451 | case EiifRGBA8_SNORM: |
| 1452 | if (!IsFloatImage(publicType.getBasicType())) |
| 1453 | { |
| 1454 | error(identifierLocation, |
| 1455 | "internal image format requires a floating image type", |
| 1456 | getBasicString(publicType.getBasicType())); |
| 1457 | return; |
| 1458 | } |
| 1459 | break; |
| 1460 | case EiifRGBA32I: |
| 1461 | case EiifRGBA16I: |
| 1462 | case EiifRGBA8I: |
| 1463 | case EiifR32I: |
| 1464 | if (!IsIntegerImage(publicType.getBasicType())) |
| 1465 | { |
| 1466 | error(identifierLocation, |
| 1467 | "internal image format requires an integer image type", |
| 1468 | getBasicString(publicType.getBasicType())); |
| 1469 | return; |
| 1470 | } |
| 1471 | break; |
| 1472 | case EiifRGBA32UI: |
| 1473 | case EiifRGBA16UI: |
| 1474 | case EiifRGBA8UI: |
| 1475 | case EiifR32UI: |
| 1476 | if (!IsUnsignedImage(publicType.getBasicType())) |
| 1477 | { |
| 1478 | error(identifierLocation, |
| 1479 | "internal image format requires an unsigned image type", |
| 1480 | getBasicString(publicType.getBasicType())); |
| 1481 | return; |
| 1482 | } |
| 1483 | break; |
| 1484 | case EiifUnspecified: |
| 1485 | error(identifierLocation, "layout qualifier", "No image internal format specified"); |
| 1486 | return; |
| 1487 | default: |
| 1488 | error(identifierLocation, "layout qualifier", "unrecognized token"); |
| 1489 | return; |
| 1490 | } |
| 1491 | |
| 1492 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 1493 | switch (layoutQualifier.imageInternalFormat) |
| 1494 | { |
| 1495 | case EiifR32F: |
| 1496 | case EiifR32I: |
| 1497 | case EiifR32UI: |
| 1498 | break; |
| 1499 | default: |
| 1500 | if (!publicType.memoryQualifier.readonly && !publicType.memoryQualifier.writeonly) |
| 1501 | { |
| 1502 | error(identifierLocation, "layout qualifier", |
| 1503 | "Except for images with the r32f, r32i and r32ui format qualifiers, " |
| 1504 | "image variables must be qualified readonly and/or writeonly"); |
| 1505 | return; |
| 1506 | } |
| 1507 | break; |
| 1508 | } |
| 1509 | } |
| 1510 | else |
| 1511 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1512 | checkInternalFormatIsNotSpecified(identifierLocation, layoutQualifier.imageInternalFormat); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1513 | checkMemoryQualifierIsNotSpecified(publicType.memoryQualifier, identifierLocation); |
| 1514 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1515 | |
| 1516 | if (IsAtomicCounter(publicType.getBasicType())) |
| 1517 | { |
| 1518 | atomicCounterQualifierErrorCheck(publicType, identifierLocation); |
| 1519 | } |
| 1520 | else |
| 1521 | { |
| 1522 | checkOffsetIsNotSpecified(identifierLocation, layoutQualifier.offset); |
| 1523 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1524 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1525 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1526 | void TParseContext::checkBindingIsValid(const TSourceLoc &identifierLocation, const TType &type) |
| 1527 | { |
| 1528 | TLayoutQualifier layoutQualifier = type.getLayoutQualifier(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1529 | // Note that the ESSL 3.10 section 4.4.5 is not particularly clear on how the binding qualifier |
| 1530 | // on arrays of arrays should be handled. We interpret the spec so that the binding value is |
| 1531 | // incremented for each element of the innermost nested arrays. This is in line with how arrays |
| 1532 | // of arrays of blocks are specified to behave in GLSL 4.50 and a conservative interpretation |
| 1533 | // when it comes to which shaders are accepted by the compiler. |
| 1534 | int arrayTotalElementCount = type.getArraySizeProduct(); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1535 | if (IsImage(type.getBasicType())) |
| 1536 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1537 | checkImageBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1538 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1539 | } |
| 1540 | else if (IsSampler(type.getBasicType())) |
| 1541 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1542 | checkSamplerBindingIsValid(identifierLocation, layoutQualifier.binding, |
| 1543 | arrayTotalElementCount); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1544 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1545 | else if (IsAtomicCounter(type.getBasicType())) |
| 1546 | { |
| 1547 | checkAtomicCounterBindingIsValid(identifierLocation, layoutQualifier.binding); |
| 1548 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1549 | else |
| 1550 | { |
| 1551 | ASSERT(!IsOpaqueType(type.getBasicType())); |
| 1552 | checkBindingIsNotSpecified(identifierLocation, layoutQualifier.binding); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1553 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 1554 | } |
| 1555 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1556 | void TParseContext::checkLayoutQualifierSupported(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1557 | const ImmutableString &layoutQualifierName, |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1558 | int versionRequired) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1559 | { |
| 1560 | |
| 1561 | if (mShaderVersion < versionRequired) |
| 1562 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1563 | error(location, "invalid layout qualifier: not supported", layoutQualifierName); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1564 | } |
| 1565 | } |
| 1566 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1567 | bool TParseContext::checkWorkGroupSizeIsNotSpecified(const TSourceLoc &location, |
| 1568 | const TLayoutQualifier &layoutQualifier) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1569 | { |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1570 | const sh::WorkGroupSize &localSize = layoutQualifier.localSize; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1571 | for (size_t i = 0u; i < localSize.size(); ++i) |
| 1572 | { |
| 1573 | if (localSize[i] != -1) |
| 1574 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1575 | error(location, |
| 1576 | "invalid layout qualifier: only valid when used with 'in' in a compute shader " |
| 1577 | "global layout declaration", |
| 1578 | getWorkGroupSizeString(i)); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1579 | return false; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1580 | } |
| 1581 | } |
| 1582 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1583 | return true; |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1584 | } |
| 1585 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1586 | void TParseContext::checkInternalFormatIsNotSpecified(const TSourceLoc &location, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1587 | TLayoutImageInternalFormat internalFormat) |
| 1588 | { |
| 1589 | if (internalFormat != EiifUnspecified) |
| 1590 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1591 | error(location, "invalid layout qualifier: only valid when used with images", |
| 1592 | getImageInternalFormatString(internalFormat)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1593 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1594 | } |
| 1595 | |
| 1596 | void TParseContext::checkBindingIsNotSpecified(const TSourceLoc &location, int binding) |
| 1597 | { |
| 1598 | if (binding != -1) |
| 1599 | { |
| 1600 | error(location, |
| 1601 | "invalid layout qualifier: only valid when used with opaque types or blocks", |
| 1602 | "binding"); |
| 1603 | } |
| 1604 | } |
| 1605 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1606 | void TParseContext::checkOffsetIsNotSpecified(const TSourceLoc &location, int offset) |
| 1607 | { |
| 1608 | if (offset != -1) |
| 1609 | { |
| 1610 | error(location, "invalid layout qualifier: only valid when used with atomic counters", |
| 1611 | "offset"); |
| 1612 | } |
| 1613 | } |
| 1614 | |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1615 | void TParseContext::checkImageBindingIsValid(const TSourceLoc &location, |
| 1616 | int binding, |
| 1617 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1618 | { |
| 1619 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1620 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1621 | { |
| 1622 | error(location, "image binding greater than gl_MaxImageUnits", "binding"); |
| 1623 | } |
| 1624 | } |
| 1625 | |
| 1626 | void TParseContext::checkSamplerBindingIsValid(const TSourceLoc &location, |
| 1627 | int binding, |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1628 | int arrayTotalElementCount) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1629 | { |
| 1630 | // Expects arraySize to be 1 when setting binding for only a single variable. |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1631 | if (binding >= 0 && binding + arrayTotalElementCount > mMaxCombinedTextureImageUnits) |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 1632 | { |
| 1633 | error(location, "sampler binding greater than maximum texture units", "binding"); |
| 1634 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 1635 | } |
| 1636 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1637 | void TParseContext::checkBlockBindingIsValid(const TSourceLoc &location, |
| 1638 | const TQualifier &qualifier, |
| 1639 | int binding, |
| 1640 | int arraySize) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1641 | { |
| 1642 | int size = (arraySize == 0 ? 1 : arraySize); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1643 | if (qualifier == EvqUniform) |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1644 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1645 | if (binding + size > mMaxUniformBufferBindings) |
| 1646 | { |
| 1647 | error(location, "uniform block binding greater than MAX_UNIFORM_BUFFER_BINDINGS", |
| 1648 | "binding"); |
| 1649 | } |
| 1650 | } |
| 1651 | else if (qualifier == EvqBuffer) |
| 1652 | { |
| 1653 | if (binding + size > mMaxShaderStorageBufferBindings) |
| 1654 | { |
| 1655 | error(location, |
| 1656 | "shader storage block binding greater than MAX_SHADER_STORAGE_BUFFER_BINDINGS", |
| 1657 | "binding"); |
| 1658 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1659 | } |
| 1660 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 1661 | void TParseContext::checkAtomicCounterBindingIsValid(const TSourceLoc &location, int binding) |
| 1662 | { |
| 1663 | if (binding >= mMaxAtomicCounterBindings) |
| 1664 | { |
| 1665 | error(location, "atomic counter binding greater than gl_MaxAtomicCounterBindings", |
| 1666 | "binding"); |
| 1667 | } |
| 1668 | } |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 1669 | |
Olli Etuaho | 6ca2b65 | 2017-02-19 18:05:10 +0000 | [diff] [blame] | 1670 | void TParseContext::checkUniformLocationInRange(const TSourceLoc &location, |
| 1671 | int objectLocationCount, |
| 1672 | const TLayoutQualifier &layoutQualifier) |
| 1673 | { |
| 1674 | int loc = layoutQualifier.location; |
| 1675 | if (loc >= 0 && loc + objectLocationCount > mMaxUniformLocations) |
| 1676 | { |
| 1677 | error(location, "Uniform location out of range", "location"); |
| 1678 | } |
| 1679 | } |
| 1680 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 1681 | void TParseContext::checkYuvIsNotSpecified(const TSourceLoc &location, bool yuv) |
| 1682 | { |
| 1683 | if (yuv != false) |
| 1684 | { |
| 1685 | error(location, "invalid layout qualifier: only valid on program outputs", "yuv"); |
| 1686 | } |
| 1687 | } |
| 1688 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1689 | void TParseContext::functionCallRValueLValueErrorCheck(const TFunction *fnCandidate, |
| 1690 | TIntermAggregate *fnCall) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1691 | { |
| 1692 | for (size_t i = 0; i < fnCandidate->getParamCount(); ++i) |
| 1693 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 1694 | TQualifier qual = fnCandidate->getParam(i)->getType().getQualifier(); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1695 | TIntermTyped *argument = (*(fnCall->getSequence()))[i]->getAsTyped(); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1696 | bool argumentIsRead = (IsQualifierUnspecified(qual) || qual == EvqIn || qual == EvqInOut || |
| 1697 | qual == EvqConstReadOnly); |
| 1698 | if (argumentIsRead) |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1699 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1700 | markStaticReadIfSymbol(argument); |
| 1701 | if (!IsImage(argument->getBasicType())) |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1702 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1703 | if (argument->getMemoryQualifier().writeonly) |
| 1704 | { |
| 1705 | error(argument->getLine(), |
| 1706 | "Writeonly value cannot be passed for 'in' or 'inout' parameters.", |
| 1707 | fnCall->functionName()); |
| 1708 | return; |
| 1709 | } |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 1710 | } |
| 1711 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1712 | if (qual == EvqOut || qual == EvqInOut) |
| 1713 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 1714 | if (!checkCanBeLValue(argument->getLine(), "assign", argument)) |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1715 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 1716 | error(argument->getLine(), |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 1717 | "Constant value cannot be passed for 'out' or 'inout' parameters.", |
Olli Etuaho | 0c37100 | 2017-12-13 17:00:25 +0400 | [diff] [blame] | 1718 | fnCall->functionName()); |
Olli Etuaho | 383b791 | 2016-08-05 11:22:59 +0300 | [diff] [blame] | 1719 | return; |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1720 | } |
| 1721 | } |
| 1722 | } |
Olli Etuaho | b6e07a6 | 2015-02-16 12:22:10 +0200 | [diff] [blame] | 1723 | } |
| 1724 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1725 | void TParseContext::checkInvariantVariableQualifier(bool invariant, |
| 1726 | const TQualifier qualifier, |
| 1727 | const TSourceLoc &invariantLocation) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1728 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1729 | if (!invariant) |
| 1730 | return; |
| 1731 | |
| 1732 | if (mShaderVersion < 300) |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1733 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 1734 | // input variables in the fragment shader can be also qualified as invariant |
| 1735 | if (!sh::CanBeInvariantESSL1(qualifier)) |
| 1736 | { |
| 1737 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1738 | } |
| 1739 | } |
| 1740 | else |
| 1741 | { |
| 1742 | if (!sh::CanBeInvariantESSL3OrGreater(qualifier)) |
| 1743 | { |
| 1744 | error(invariantLocation, "Cannot be qualified as invariant.", "invariant"); |
| 1745 | } |
Olli Etuaho | 37ad474 | 2015-04-27 13:18:50 +0300 | [diff] [blame] | 1746 | } |
| 1747 | } |
| 1748 | |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1749 | bool TParseContext::isExtensionEnabled(TExtension extension) const |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1750 | { |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 1751 | return IsExtensionEnabled(extensionBehavior(), extension); |
Jamie Madill | 5d287f5 | 2013-07-12 15:38:19 -0400 | [diff] [blame] | 1752 | } |
| 1753 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1754 | void TParseContext::handleExtensionDirective(const TSourceLoc &loc, |
| 1755 | const char *extName, |
| 1756 | const char *behavior) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1757 | { |
Geoff Lang | 197d529 | 2018-04-25 14:29:00 -0400 | [diff] [blame] | 1758 | angle::pp::SourceLocation srcLoc; |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1759 | srcLoc.file = loc.first_file; |
| 1760 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1761 | mDirectiveHandler.handleExtension(srcLoc, extName, behavior); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1762 | } |
| 1763 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1764 | void TParseContext::handlePragmaDirective(const TSourceLoc &loc, |
| 1765 | const char *name, |
| 1766 | const char *value, |
| 1767 | bool stdgl) |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1768 | { |
Geoff Lang | 197d529 | 2018-04-25 14:29:00 -0400 | [diff] [blame] | 1769 | angle::pp::SourceLocation srcLoc; |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1770 | srcLoc.file = loc.first_file; |
| 1771 | srcLoc.line = loc.first_line; |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 1772 | mDirectiveHandler.handlePragma(srcLoc, name, value, stdgl); |
Jamie Madill | 075edd8 | 2013-07-08 13:30:19 -0400 | [diff] [blame] | 1773 | } |
| 1774 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 1775 | sh::WorkGroupSize TParseContext::getComputeShaderLocalSize() const |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1776 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 1777 | sh::WorkGroupSize result(-1); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 1778 | for (size_t i = 0u; i < result.size(); ++i) |
| 1779 | { |
| 1780 | if (mComputeShaderLocalSizeDeclared && mComputeShaderLocalSize[i] == -1) |
| 1781 | { |
| 1782 | result[i] = 1; |
| 1783 | } |
| 1784 | else |
| 1785 | { |
| 1786 | result[i] = mComputeShaderLocalSize[i]; |
| 1787 | } |
| 1788 | } |
| 1789 | return result; |
| 1790 | } |
| 1791 | |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1792 | TIntermConstantUnion *TParseContext::addScalarLiteral(const TConstantUnion *constantUnion, |
| 1793 | const TSourceLoc &line) |
| 1794 | { |
| 1795 | TIntermConstantUnion *node = new TIntermConstantUnion( |
| 1796 | constantUnion, TType(constantUnion->getType(), EbpUndefined, EvqConst)); |
| 1797 | node->setLine(line); |
| 1798 | return node; |
| 1799 | } |
| 1800 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1801 | ///////////////////////////////////////////////////////////////////////////////// |
| 1802 | // |
| 1803 | // Non-Errors. |
| 1804 | // |
| 1805 | ///////////////////////////////////////////////////////////////////////////////// |
| 1806 | |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1807 | const TVariable *TParseContext::getNamedVariable(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1808 | const ImmutableString &name, |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1809 | const TSymbol *symbol) |
| 1810 | { |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1811 | if (!symbol) |
| 1812 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1813 | error(location, "undeclared identifier", name); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1814 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1815 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1816 | |
| 1817 | if (!symbol->isVariable()) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1818 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1819 | error(location, "variable expected", name); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1820 | return nullptr; |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1821 | } |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1822 | |
| 1823 | const TVariable *variable = static_cast<const TVariable *>(symbol); |
| 1824 | |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1825 | if (variable->extension() != TExtension::UNDEFINED) |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1826 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 1827 | checkCanUseExtension(location, variable->extension()); |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1828 | } |
| 1829 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1830 | // GLSL ES 3.1 Revision 4, 7.1.3 Compute Shader Special Variables |
| 1831 | if (getShaderType() == GL_COMPUTE_SHADER && !mComputeShaderLocalSizeDeclared && |
Olli Etuaho | 59c5b89 | 2018-04-03 11:44:50 +0300 | [diff] [blame] | 1832 | variable->getType().getQualifier() == EvqWorkGroupSize) |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1833 | { |
| 1834 | error(location, |
| 1835 | "It is an error to use gl_WorkGroupSize before declaring the local group size", |
| 1836 | "gl_WorkGroupSize"); |
| 1837 | } |
Jamie Madill | 5c09702 | 2014-08-20 16:38:32 -0400 | [diff] [blame] | 1838 | return variable; |
| 1839 | } |
| 1840 | |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1841 | TIntermTyped *TParseContext::parseVariableIdentifier(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1842 | const ImmutableString &name, |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1843 | const TSymbol *symbol) |
| 1844 | { |
| 1845 | const TVariable *variable = getNamedVariable(location, name, symbol); |
| 1846 | |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 1847 | if (!variable) |
| 1848 | { |
| 1849 | TIntermTyped *node = CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 1850 | node->setLine(location); |
| 1851 | return node; |
| 1852 | } |
| 1853 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1854 | const TType &variableType = variable->getType(); |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 1855 | TIntermTyped *node = nullptr; |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1856 | |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 1857 | if (variable->getConstPointer() && variableType.canReplaceWithConstantUnion()) |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1858 | { |
Olli Etuaho | 5c0e023 | 2015-11-11 15:55:59 +0200 | [diff] [blame] | 1859 | const TConstantUnion *constArray = variable->getConstPointer(); |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1860 | node = new TIntermConstantUnion(constArray, variableType); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1861 | } |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1862 | else if (variableType.getQualifier() == EvqWorkGroupSize && mComputeShaderLocalSizeDeclared) |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1863 | { |
| 1864 | // gl_WorkGroupSize can be used to size arrays according to the ESSL 3.10.4 spec, so it |
| 1865 | // needs to be added to the AST as a constant and not as a symbol. |
| 1866 | sh::WorkGroupSize workGroupSize = getComputeShaderLocalSize(); |
| 1867 | TConstantUnion *constArray = new TConstantUnion[3]; |
| 1868 | for (size_t i = 0; i < 3; ++i) |
| 1869 | { |
| 1870 | constArray[i].setUConst(static_cast<unsigned int>(workGroupSize[i])); |
| 1871 | } |
| 1872 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1873 | ASSERT(variableType.getBasicType() == EbtUInt); |
| 1874 | ASSERT(variableType.getObjectSize() == 3); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1875 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1876 | TType type(variableType); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1877 | type.setQualifier(EvqConst); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1878 | node = new TIntermConstantUnion(constArray, type); |
Olli Etuaho | aecfa8e | 2016-12-09 12:47:26 +0000 | [diff] [blame] | 1879 | } |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 1880 | else if ((mGeometryShaderInputPrimitiveType != EptUndefined) && |
| 1881 | (variableType.getQualifier() == EvqPerVertexIn)) |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1882 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1883 | ASSERT(symbolTable.getGlInVariableWithArraySize() != nullptr); |
| 1884 | node = new TIntermSymbol(symbolTable.getGlInVariableWithArraySize()); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 1885 | } |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1886 | else |
| 1887 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1888 | node = new TIntermSymbol(variable); |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1889 | } |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 1890 | ASSERT(node != nullptr); |
| 1891 | node->setLine(location); |
| 1892 | return node; |
Olli Etuaho | 82c29ed | 2015-11-03 13:06:54 +0200 | [diff] [blame] | 1893 | } |
| 1894 | |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1895 | // Initializers show up in several places in the grammar. Have one set of |
| 1896 | // code to handle them here. |
| 1897 | // |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1898 | // Returns true on success. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1899 | bool TParseContext::executeInitializer(const TSourceLoc &line, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 1900 | const ImmutableString &identifier, |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1901 | TType *type, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1902 | TIntermTyped *initializer, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1903 | TIntermBinary **initNode) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1904 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 1905 | ASSERT(initNode != nullptr); |
| 1906 | ASSERT(*initNode == nullptr); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1907 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1908 | if (type->isUnsizedArray()) |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1909 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 1910 | // In case initializer is not an array or type has more dimensions than initializer, this |
| 1911 | // will default to setting array sizes to 1. We have not checked yet whether the initializer |
| 1912 | // actually is an array or not. Having a non-array initializer for an unsized array will |
| 1913 | // result in an error later, so we don't generate an error message here. |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 1914 | auto *arraySizes = initializer->getType().getArraySizes(); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1915 | type->sizeUnsizedArrays(arraySizes); |
| 1916 | } |
| 1917 | |
| 1918 | const TQualifier qualifier = type->getQualifier(); |
| 1919 | |
| 1920 | bool constError = false; |
| 1921 | if (qualifier == EvqConst) |
| 1922 | { |
| 1923 | if (EvqConst != initializer->getType().getQualifier()) |
| 1924 | { |
| 1925 | std::stringstream reasonStream; |
| 1926 | reasonStream << "assigning non-constant to '" << type->getCompleteString() << "'"; |
| 1927 | std::string reason = reasonStream.str(); |
| 1928 | error(line, reason.c_str(), "="); |
| 1929 | |
| 1930 | // We're still going to declare the variable to avoid extra error messages. |
| 1931 | type->setQualifier(EvqTemporary); |
| 1932 | constError = true; |
| 1933 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 1934 | } |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 1935 | |
| 1936 | TVariable *variable = nullptr; |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 1937 | if (!declareVariable(line, identifier, type, &variable)) |
| 1938 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1939 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1940 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1941 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1942 | if (constError) |
| 1943 | { |
| 1944 | return false; |
| 1945 | } |
| 1946 | |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1947 | bool globalInitWarning = false; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1948 | if (symbolTable.atGlobalLevel() && |
Olli Etuaho | a2d9814 | 2017-12-15 14:18:55 +0200 | [diff] [blame] | 1949 | !ValidateGlobalInitializer(initializer, mShaderVersion, &globalInitWarning)) |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1950 | { |
| 1951 | // Error message does not completely match behavior with ESSL 1.00, but |
| 1952 | // we want to steer developers towards only using constant expressions. |
| 1953 | error(line, "global variable initializers must be constant expressions", "="); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1954 | return false; |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1955 | } |
| 1956 | if (globalInitWarning) |
| 1957 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1958 | warning( |
| 1959 | line, |
| 1960 | "global variable initializers should be constant expressions " |
| 1961 | "(uniforms and globals are allowed in global initializers for legacy compatibility)", |
| 1962 | "="); |
Olli Etuaho | b0c645e | 2015-05-12 14:25:36 +0300 | [diff] [blame] | 1963 | } |
| 1964 | |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1965 | // identifier must be of type constant, a global, or a temporary |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1966 | if ((qualifier != EvqTemporary) && (qualifier != EvqGlobal) && (qualifier != EvqConst)) |
| 1967 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 1968 | error(line, " cannot initialize this type of qualifier ", |
| 1969 | variable->getType().getQualifierString()); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1970 | return false; |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1971 | } |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1972 | |
| 1973 | TIntermSymbol *intermSymbol = new TIntermSymbol(variable); |
| 1974 | intermSymbol->setLine(line); |
| 1975 | |
| 1976 | if (!binaryOpCommonCheck(EOpInitialize, intermSymbol, initializer, line)) |
| 1977 | { |
| 1978 | assignError(line, "=", variable->getType().getCompleteString(), |
| 1979 | initializer->getCompleteString()); |
| 1980 | return false; |
| 1981 | } |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 1982 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1983 | if (qualifier == EvqConst) |
| 1984 | { |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 1985 | // Save the constant folded value to the variable if possible. |
| 1986 | const TConstantUnion *constArray = initializer->getConstantValue(); |
| 1987 | if (constArray) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 1988 | { |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 1989 | variable->shareConstPointer(constArray); |
| 1990 | if (initializer->getType().canReplaceWithConstantUnion()) |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1991 | { |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 1992 | ASSERT(*initNode == nullptr); |
| 1993 | return true; |
Olli Etuaho | b1edc4f | 2015-11-02 17:20:03 +0200 | [diff] [blame] | 1994 | } |
daniel@transgaming.com | ea15b0e | 2010-04-29 03:32:36 +0000 | [diff] [blame] | 1995 | } |
| 1996 | } |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 1997 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 1998 | *initNode = new TIntermBinary(EOpInitialize, intermSymbol, initializer); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 1999 | markStaticReadIfSymbol(initializer); |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2000 | (*initNode)->setLine(line); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2001 | return true; |
| 2002 | } |
| 2003 | |
| 2004 | TIntermNode *TParseContext::addConditionInitializer(const TPublicType &pType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2005 | const ImmutableString &identifier, |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2006 | TIntermTyped *initializer, |
| 2007 | const TSourceLoc &loc) |
| 2008 | { |
| 2009 | checkIsScalarBool(loc, pType); |
| 2010 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2011 | TType *type = new TType(pType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2012 | if (executeInitializer(loc, identifier, type, initializer, &initNode)) |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2013 | { |
| 2014 | // The initializer is valid. The init condition needs to have a node - either the |
| 2015 | // initializer node, or a constant node in case the initialized variable is const and won't |
| 2016 | // be recorded in the AST. |
| 2017 | if (initNode == nullptr) |
| 2018 | { |
| 2019 | return initializer; |
| 2020 | } |
| 2021 | else |
| 2022 | { |
| 2023 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2024 | declaration->appendDeclarator(initNode); |
| 2025 | return declaration; |
| 2026 | } |
| 2027 | } |
| 2028 | return nullptr; |
| 2029 | } |
| 2030 | |
| 2031 | TIntermNode *TParseContext::addLoop(TLoopType type, |
| 2032 | TIntermNode *init, |
| 2033 | TIntermNode *cond, |
| 2034 | TIntermTyped *expr, |
| 2035 | TIntermNode *body, |
| 2036 | const TSourceLoc &line) |
| 2037 | { |
| 2038 | TIntermNode *node = nullptr; |
| 2039 | TIntermTyped *typedCond = nullptr; |
| 2040 | if (cond) |
| 2041 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2042 | markStaticReadIfSymbol(cond); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2043 | typedCond = cond->getAsTyped(); |
| 2044 | } |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2045 | if (expr) |
| 2046 | { |
| 2047 | markStaticReadIfSymbol(expr); |
| 2048 | } |
| 2049 | // In case the loop body was not parsed as a block and contains a statement that simply refers |
| 2050 | // to a variable, we need to mark it as statically used. |
| 2051 | if (body) |
| 2052 | { |
| 2053 | markStaticReadIfSymbol(body); |
| 2054 | } |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2055 | if (cond == nullptr || typedCond) |
| 2056 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2057 | if (type == ELoopDoWhile) |
| 2058 | { |
| 2059 | checkIsScalarBool(line, typedCond); |
| 2060 | } |
| 2061 | // In the case of other loops, it was checked before that the condition is a scalar boolean. |
| 2062 | ASSERT(mDiagnostics->numErrors() > 0 || typedCond == nullptr || |
| 2063 | (typedCond->getBasicType() == EbtBool && !typedCond->isArray() && |
| 2064 | !typedCond->isVector())); |
| 2065 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2066 | node = new TIntermLoop(type, init, typedCond, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2067 | node->setLine(line); |
| 2068 | return node; |
| 2069 | } |
| 2070 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2071 | ASSERT(type != ELoopDoWhile); |
| 2072 | |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2073 | TIntermDeclaration *declaration = cond->getAsDeclarationNode(); |
| 2074 | ASSERT(declaration); |
| 2075 | TIntermBinary *declarator = declaration->getSequence()->front()->getAsBinaryNode(); |
| 2076 | ASSERT(declarator->getLeft()->getAsSymbolNode()); |
| 2077 | |
| 2078 | // The condition is a declaration. In the AST representation we don't support declarations as |
| 2079 | // loop conditions. Wrap the loop to a block that declares the condition variable and contains |
| 2080 | // the loop. |
| 2081 | TIntermBlock *block = new TIntermBlock(); |
| 2082 | |
| 2083 | TIntermDeclaration *declareCondition = new TIntermDeclaration(); |
| 2084 | declareCondition->appendDeclarator(declarator->getLeft()->deepCopy()); |
| 2085 | block->appendStatement(declareCondition); |
| 2086 | |
| 2087 | TIntermBinary *conditionInit = new TIntermBinary(EOpAssign, declarator->getLeft()->deepCopy(), |
| 2088 | declarator->getRight()->deepCopy()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2089 | TIntermLoop *loop = new TIntermLoop(type, init, conditionInit, expr, EnsureBlock(body)); |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2090 | block->appendStatement(loop); |
| 2091 | loop->setLine(line); |
| 2092 | block->setLine(line); |
| 2093 | return block; |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 2094 | } |
| 2095 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2096 | TIntermNode *TParseContext::addIfElse(TIntermTyped *cond, |
| 2097 | TIntermNodePair code, |
| 2098 | const TSourceLoc &loc) |
| 2099 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2100 | bool isScalarBool = checkIsScalarBool(loc, cond); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2101 | // In case the conditional statements were not parsed as blocks and contain a statement that |
| 2102 | // simply refers to a variable, we need to mark them as statically used. |
| 2103 | if (code.node1) |
| 2104 | { |
| 2105 | markStaticReadIfSymbol(code.node1); |
| 2106 | } |
| 2107 | if (code.node2) |
| 2108 | { |
| 2109 | markStaticReadIfSymbol(code.node2); |
| 2110 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2111 | |
| 2112 | // For compile time constant conditions, prune the code now. |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 2113 | if (isScalarBool && cond->getAsConstantUnion()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2114 | { |
| 2115 | if (cond->getAsConstantUnion()->getBConst(0) == true) |
| 2116 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2117 | return EnsureBlock(code.node1); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2118 | } |
| 2119 | else |
| 2120 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2121 | return EnsureBlock(code.node2); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2122 | } |
| 2123 | } |
| 2124 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 2125 | TIntermIfElse *node = new TIntermIfElse(cond, EnsureBlock(code.node1), EnsureBlock(code.node2)); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2126 | markStaticReadIfSymbol(cond); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2127 | node->setLine(loc); |
| 2128 | |
| 2129 | return node; |
| 2130 | } |
| 2131 | |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 2132 | void TParseContext::addFullySpecifiedType(TPublicType *typeSpecifier) |
| 2133 | { |
| 2134 | checkPrecisionSpecified(typeSpecifier->getLine(), typeSpecifier->precision, |
| 2135 | typeSpecifier->getBasicType()); |
| 2136 | |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2137 | if (mShaderVersion < 300 && typeSpecifier->isArray()) |
Olli Etuaho | 0e3aee3 | 2016-10-27 12:56:38 +0100 | [diff] [blame] | 2138 | { |
| 2139 | error(typeSpecifier->getLine(), "not supported", "first-class array"); |
| 2140 | typeSpecifier->clearArrayness(); |
| 2141 | } |
| 2142 | } |
| 2143 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2144 | TPublicType TParseContext::addFullySpecifiedType(const TTypeQualifierBuilder &typeQualifierBuilder, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 2145 | const TPublicType &typeSpecifier) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2146 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2147 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2148 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2149 | TPublicType returnType = typeSpecifier; |
| 2150 | returnType.qualifier = typeQualifier.qualifier; |
| 2151 | returnType.invariant = typeQualifier.invariant; |
| 2152 | returnType.layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2153 | returnType.memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2154 | returnType.precision = typeSpecifier.precision; |
| 2155 | |
| 2156 | if (typeQualifier.precision != EbpUndefined) |
| 2157 | { |
| 2158 | returnType.precision = typeQualifier.precision; |
| 2159 | } |
| 2160 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2161 | checkPrecisionSpecified(typeSpecifier.getLine(), returnType.precision, |
| 2162 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2163 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2164 | checkInvariantVariableQualifier(returnType.invariant, returnType.qualifier, |
| 2165 | typeSpecifier.getLine()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2166 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2167 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), returnType.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2168 | |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 2169 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2170 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2171 | if (typeSpecifier.isArray()) |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2172 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2173 | error(typeSpecifier.getLine(), "not supported", "first-class array"); |
Olli Etuaho | c1ac41b | 2015-07-10 13:53:46 +0300 | [diff] [blame] | 2174 | returnType.clearArrayness(); |
| 2175 | } |
| 2176 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2177 | if (returnType.qualifier == EvqAttribute && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2178 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2179 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2180 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2181 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2182 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2183 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2184 | if ((returnType.qualifier == EvqVaryingIn || returnType.qualifier == EvqVaryingOut) && |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2185 | (typeSpecifier.getBasicType() == EbtBool || typeSpecifier.getBasicType() == EbtInt)) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2186 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2187 | error(typeSpecifier.getLine(), "cannot be bool or int", |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2188 | getQualifierString(returnType.qualifier)); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2189 | } |
| 2190 | } |
| 2191 | else |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2192 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2193 | if (!returnType.layoutQualifier.isEmpty()) |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2194 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2195 | checkIsAtGlobalLevel(typeSpecifier.getLine(), "layout"); |
Olli Etuaho | abb0c38 | 2015-07-13 12:01:12 +0300 | [diff] [blame] | 2196 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2197 | if (sh::IsVarying(returnType.qualifier) || returnType.qualifier == EvqVertexIn || |
| 2198 | returnType.qualifier == EvqFragmentOut) |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2199 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2200 | checkInputOutputTypeIsValidES3(returnType.qualifier, typeSpecifier, |
| 2201 | typeSpecifier.getLine()); |
shannonwoods@chromium.org | 5703d88 | 2013-05-30 00:19:38 +0000 | [diff] [blame] | 2202 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2203 | if (returnType.qualifier == EvqComputeIn) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2204 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2205 | error(typeSpecifier.getLine(), "'in' can be only used to specify the local group size", |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2206 | "in"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2207 | } |
shannonwoods@chromium.org | 0f376ca | 2013-05-30 00:19:23 +0000 | [diff] [blame] | 2208 | } |
| 2209 | |
| 2210 | return returnType; |
| 2211 | } |
| 2212 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2213 | void TParseContext::checkInputOutputTypeIsValidES3(const TQualifier qualifier, |
| 2214 | const TPublicType &type, |
| 2215 | const TSourceLoc &qualifierLocation) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2216 | { |
| 2217 | // An input/output variable can never be bool or a sampler. Samplers are checked elsewhere. |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2218 | if (type.getBasicType() == EbtBool) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2219 | { |
| 2220 | error(qualifierLocation, "cannot be bool", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2221 | } |
| 2222 | |
| 2223 | // Specific restrictions apply for vertex shader inputs and fragment shader outputs. |
| 2224 | switch (qualifier) |
| 2225 | { |
| 2226 | case EvqVertexIn: |
| 2227 | // ESSL 3.00 section 4.3.4 |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2228 | if (type.isArray()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2229 | { |
| 2230 | error(qualifierLocation, "cannot be array", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2231 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2232 | // Vertex inputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2233 | return; |
| 2234 | case EvqFragmentOut: |
| 2235 | // ESSL 3.00 section 4.3.6 |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2236 | if (type.typeSpecifierNonArray.isMatrix()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2237 | { |
| 2238 | error(qualifierLocation, "cannot be matrix", getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2239 | } |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2240 | // Fragment outputs with a struct type are disallowed in nonEmptyDeclarationErrorCheck |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2241 | return; |
| 2242 | default: |
| 2243 | break; |
| 2244 | } |
| 2245 | |
| 2246 | // Vertex shader outputs / fragment shader inputs have a different, slightly more lenient set of |
| 2247 | // restrictions. |
| 2248 | bool typeContainsIntegers = |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2249 | (type.getBasicType() == EbtInt || type.getBasicType() == EbtUInt || |
| 2250 | type.isStructureContainingType(EbtInt) || type.isStructureContainingType(EbtUInt)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2251 | if (typeContainsIntegers && qualifier != EvqFlatIn && qualifier != EvqFlatOut) |
| 2252 | { |
| 2253 | error(qualifierLocation, "must use 'flat' interpolation here", |
| 2254 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2255 | } |
| 2256 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 2257 | if (type.getBasicType() == EbtStruct) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2258 | { |
| 2259 | // ESSL 3.00 sections 4.3.4 and 4.3.6. |
| 2260 | // These restrictions are only implied by the ESSL 3.00 spec, but |
| 2261 | // the ESSL 3.10 spec lists these restrictions explicitly. |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2262 | if (type.isArray()) |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2263 | { |
| 2264 | error(qualifierLocation, "cannot be an array of structures", |
| 2265 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2266 | } |
| 2267 | if (type.isStructureContainingArrays()) |
| 2268 | { |
| 2269 | error(qualifierLocation, "cannot be a structure containing an array", |
| 2270 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2271 | } |
| 2272 | if (type.isStructureContainingType(EbtStruct)) |
| 2273 | { |
| 2274 | error(qualifierLocation, "cannot be a structure containing a structure", |
| 2275 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2276 | } |
| 2277 | if (type.isStructureContainingType(EbtBool)) |
| 2278 | { |
| 2279 | error(qualifierLocation, "cannot be a structure containing a bool", |
| 2280 | getQualifierString(qualifier)); |
Olli Etuaho | cc36b98 | 2015-07-10 14:14:18 +0300 | [diff] [blame] | 2281 | } |
| 2282 | } |
| 2283 | } |
| 2284 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2285 | void TParseContext::checkLocalVariableConstStorageQualifier(const TQualifierWrapperBase &qualifier) |
| 2286 | { |
| 2287 | if (qualifier.getType() == QtStorage) |
| 2288 | { |
| 2289 | const TStorageQualifierWrapper &storageQualifier = |
| 2290 | static_cast<const TStorageQualifierWrapper &>(qualifier); |
| 2291 | if (!declaringFunction() && storageQualifier.getQualifier() != EvqConst && |
| 2292 | !symbolTable.atGlobalLevel()) |
| 2293 | { |
| 2294 | error(storageQualifier.getLine(), |
| 2295 | "Local variables can only use the const storage qualifier.", |
| 2296 | storageQualifier.getQualifierString().c_str()); |
| 2297 | } |
| 2298 | } |
| 2299 | } |
| 2300 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2301 | void TParseContext::checkMemoryQualifierIsNotSpecified(const TMemoryQualifier &memoryQualifier, |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2302 | const TSourceLoc &location) |
| 2303 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2304 | const std::string reason( |
| 2305 | "Only allowed with shader storage blocks, variables declared within shader storage blocks " |
| 2306 | "and variables declared as image types."); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2307 | if (memoryQualifier.readonly) |
| 2308 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2309 | error(location, reason.c_str(), "readonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2310 | } |
| 2311 | if (memoryQualifier.writeonly) |
| 2312 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2313 | error(location, reason.c_str(), "writeonly"); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2314 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2315 | if (memoryQualifier.coherent) |
| 2316 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2317 | error(location, reason.c_str(), "coherent"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2318 | } |
| 2319 | if (memoryQualifier.restrictQualifier) |
| 2320 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2321 | error(location, reason.c_str(), "restrict"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2322 | } |
| 2323 | if (memoryQualifier.volatileQualifier) |
| 2324 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 2325 | error(location, reason.c_str(), "volatile"); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 2326 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2327 | } |
| 2328 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2329 | // Make sure there is no offset overlapping, and store the newly assigned offset to "type" in |
| 2330 | // intermediate tree. |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2331 | void TParseContext::checkAtomicCounterOffsetDoesNotOverlap(bool forceAppend, |
| 2332 | const TSourceLoc &loc, |
| 2333 | TType *type) |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2334 | { |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2335 | if (!IsAtomicCounter(type->getBasicType())) |
| 2336 | { |
| 2337 | return; |
| 2338 | } |
| 2339 | |
| 2340 | const size_t size = type->isArray() ? kAtomicCounterArrayStride * type->getArraySizeProduct() |
| 2341 | : kAtomicCounterSize; |
| 2342 | TLayoutQualifier layoutQualifier = type->getLayoutQualifier(); |
| 2343 | auto &bindingState = mAtomicCounterBindingStates[layoutQualifier.binding]; |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2344 | int offset; |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2345 | if (layoutQualifier.offset == -1 || forceAppend) |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2346 | { |
| 2347 | offset = bindingState.appendSpan(size); |
| 2348 | } |
| 2349 | else |
| 2350 | { |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2351 | offset = bindingState.insertSpan(layoutQualifier.offset, size); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2352 | } |
| 2353 | if (offset == -1) |
| 2354 | { |
| 2355 | error(loc, "Offset overlapping", "atomic counter"); |
| 2356 | return; |
| 2357 | } |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2358 | layoutQualifier.offset = offset; |
| 2359 | type->setLayoutQualifier(layoutQualifier); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2360 | } |
| 2361 | |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2362 | void TParseContext::checkGeometryShaderInputAndSetArraySize(const TSourceLoc &location, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2363 | const ImmutableString &token, |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2364 | TType *type) |
| 2365 | { |
| 2366 | if (IsGeometryShaderInput(mShaderType, type->getQualifier())) |
| 2367 | { |
| 2368 | if (type->isArray() && type->getOutermostArraySize() == 0u) |
| 2369 | { |
| 2370 | // Set size for the unsized geometry shader inputs if they are declared after a valid |
| 2371 | // input primitive declaration. |
| 2372 | if (mGeometryShaderInputPrimitiveType != EptUndefined) |
| 2373 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2374 | ASSERT(symbolTable.getGlInVariableWithArraySize() != nullptr); |
Olli Etuaho | c74ec1a | 2018-01-09 15:23:28 +0200 | [diff] [blame] | 2375 | type->sizeOutermostUnsizedArray( |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2376 | symbolTable.getGlInVariableWithArraySize()->getType().getOutermostArraySize()); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2377 | } |
| 2378 | else |
| 2379 | { |
| 2380 | // [GLSL ES 3.2 SPEC Chapter 4.4.1.2] |
| 2381 | // An input can be declared without an array size if there is a previous layout |
| 2382 | // which specifies the size. |
| 2383 | error(location, |
| 2384 | "Missing a valid input primitive declaration before declaring an unsized " |
| 2385 | "array input", |
| 2386 | token); |
| 2387 | } |
| 2388 | } |
| 2389 | else if (type->isArray()) |
| 2390 | { |
| 2391 | setGeometryShaderInputArraySize(type->getOutermostArraySize(), location); |
| 2392 | } |
| 2393 | else |
| 2394 | { |
| 2395 | error(location, "Geometry shader input variable must be declared as an array", token); |
| 2396 | } |
| 2397 | } |
| 2398 | } |
| 2399 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2400 | TIntermDeclaration *TParseContext::parseSingleDeclaration( |
| 2401 | TPublicType &publicType, |
| 2402 | const TSourceLoc &identifierOrTypeLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2403 | const ImmutableString &identifier) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2404 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2405 | TType *type = new TType(publicType); |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2406 | if ((mCompileOptions & SH_FLATTEN_PRAGMA_STDGL_INVARIANT_ALL) && |
| 2407 | mDirectiveHandler.pragma().stdgl.invariantAll) |
| 2408 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2409 | TQualifier qualifier = type->getQualifier(); |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2410 | |
| 2411 | // The directive handler has already taken care of rejecting invalid uses of this pragma |
| 2412 | // (for example, in ESSL 3.00 fragment shaders), so at this point, flatten it into all |
| 2413 | // affected variable declarations: |
| 2414 | // |
| 2415 | // 1. Built-in special variables which are inputs to the fragment shader. (These are handled |
| 2416 | // elsewhere, in TranslatorGLSL.) |
| 2417 | // |
| 2418 | // 2. Outputs from vertex shaders in ESSL 1.00 and 3.00 (EvqVaryingOut and EvqVertexOut). It |
| 2419 | // is actually less likely that there will be bugs in the handling of ESSL 3.00 shaders, but |
| 2420 | // the way this is currently implemented we have to enable this compiler option before |
| 2421 | // parsing the shader and determining the shading language version it uses. If this were |
| 2422 | // implemented as a post-pass, the workaround could be more targeted. |
| 2423 | // |
| 2424 | // 3. Inputs in ESSL 1.00 fragment shaders (EvqVaryingIn). This is somewhat in violation of |
| 2425 | // the specification, but there are desktop OpenGL drivers that expect that this is the |
| 2426 | // behavior of the #pragma when specified in ESSL 1.00 fragment shaders. |
| 2427 | if (qualifier == EvqVaryingOut || qualifier == EvqVertexOut || qualifier == EvqVaryingIn) |
| 2428 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2429 | type->setInvariant(true); |
Kenneth Russell | bccc65d | 2016-07-19 16:48:43 -0700 | [diff] [blame] | 2430 | } |
| 2431 | } |
| 2432 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2433 | checkGeometryShaderInputAndSetArraySize(identifierOrTypeLocation, identifier, type); |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2434 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2435 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2436 | identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2437 | |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 2438 | bool emptyDeclaration = (identifier == ""); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2439 | mDeferredNonEmptyDeclarationErrorCheck = emptyDeclaration; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2440 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2441 | TIntermSymbol *symbol = nullptr; |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2442 | if (emptyDeclaration) |
| 2443 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2444 | emptyDeclarationErrorCheck(*type, identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2445 | // In most cases we don't need to create a symbol node for an empty declaration. |
| 2446 | // But if the empty declaration is declaring a struct type, the symbol node will store that. |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2447 | if (type->getBasicType() == EbtStruct) |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2448 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2449 | TVariable *emptyVariable = |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2450 | new TVariable(&symbolTable, ImmutableString(""), type, SymbolType::Empty); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2451 | symbol = new TIntermSymbol(emptyVariable); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2452 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2453 | else if (IsAtomicCounter(publicType.getBasicType())) |
| 2454 | { |
| 2455 | setAtomicCounterBindingDefaultOffset(publicType, identifierOrTypeLocation); |
| 2456 | } |
Olli Etuaho | bab4c08 | 2015-04-24 16:38:49 +0300 | [diff] [blame] | 2457 | } |
| 2458 | else |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2459 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2460 | nonEmptyDeclarationErrorCheck(publicType, identifierOrTypeLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2461 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2462 | checkCanBeDeclaredWithoutInitializer(identifierOrTypeLocation, identifier, type); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2463 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2464 | checkAtomicCounterOffsetDoesNotOverlap(false, identifierOrTypeLocation, type); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2465 | |
Olli Etuaho | 2935c58 | 2015-04-08 14:32:06 +0300 | [diff] [blame] | 2466 | TVariable *variable = nullptr; |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2467 | if (declareVariable(identifierOrTypeLocation, identifier, type, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2468 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2469 | symbol = new TIntermSymbol(variable); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2470 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2471 | } |
| 2472 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2473 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2474 | declaration->setLine(identifierOrTypeLocation); |
| 2475 | if (symbol) |
| 2476 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2477 | symbol->setLine(identifierOrTypeLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2478 | declaration->appendDeclarator(symbol); |
| 2479 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2480 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2481 | } |
| 2482 | |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2483 | TIntermDeclaration *TParseContext::parseSingleArrayDeclaration( |
| 2484 | TPublicType &elementType, |
| 2485 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2486 | const ImmutableString &identifier, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2487 | const TSourceLoc &indexLocation, |
| 2488 | const TVector<unsigned int> &arraySizes) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2489 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2490 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2491 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2492 | declarationQualifierErrorCheck(elementType.qualifier, elementType.layoutQualifier, |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2493 | identifierLocation); |
| 2494 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2495 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2496 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2497 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2498 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2499 | TType *arrayType = new TType(elementType); |
| 2500 | arrayType->makeArrays(arraySizes); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2501 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2502 | checkGeometryShaderInputAndSetArraySize(indexLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2503 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2504 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2505 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2506 | checkAtomicCounterOffsetDoesNotOverlap(false, identifierLocation, arrayType); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2507 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2508 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2509 | declaration->setLine(identifierLocation); |
| 2510 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2511 | TVariable *variable = nullptr; |
| 2512 | if (declareVariable(identifierLocation, identifier, arrayType, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2513 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2514 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2515 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2516 | declaration->appendDeclarator(symbol); |
| 2517 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2518 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2519 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2520 | } |
| 2521 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2522 | TIntermDeclaration *TParseContext::parseSingleInitDeclaration(const TPublicType &publicType, |
| 2523 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2524 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2525 | const TSourceLoc &initLocation, |
| 2526 | TIntermTyped *initializer) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2527 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2528 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2529 | |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2530 | declarationQualifierErrorCheck(publicType.qualifier, publicType.layoutQualifier, |
| 2531 | identifierLocation); |
| 2532 | |
| 2533 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2534 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2535 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2536 | declaration->setLine(identifierLocation); |
| 2537 | |
| 2538 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2539 | TType *type = new TType(publicType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2540 | if (executeInitializer(identifierLocation, identifier, type, initializer, &initNode)) |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2541 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2542 | if (initNode) |
| 2543 | { |
| 2544 | declaration->appendDeclarator(initNode); |
| 2545 | } |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2546 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2547 | return declaration; |
Jamie Madill | 60ed981 | 2013-06-06 11:56:46 -0400 | [diff] [blame] | 2548 | } |
| 2549 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2550 | TIntermDeclaration *TParseContext::parseSingleArrayInitDeclaration( |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2551 | TPublicType &elementType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2552 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2553 | const ImmutableString &identifier, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2554 | const TSourceLoc &indexLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2555 | const TVector<unsigned int> &arraySizes, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2556 | const TSourceLoc &initLocation, |
| 2557 | TIntermTyped *initializer) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2558 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2559 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2560 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2561 | declarationQualifierErrorCheck(elementType.qualifier, elementType.layoutQualifier, |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2562 | identifierLocation); |
| 2563 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2564 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2565 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2566 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2567 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2568 | TType *arrayType = new TType(elementType); |
| 2569 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2570 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2571 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 2572 | declaration->setLine(identifierLocation); |
| 2573 | |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2574 | // initNode will correspond to the whole of "type b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2575 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2576 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2577 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2578 | if (initNode) |
| 2579 | { |
| 2580 | declaration->appendDeclarator(initNode); |
| 2581 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2582 | } |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2583 | |
| 2584 | return declaration; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2585 | } |
| 2586 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2587 | TIntermInvariantDeclaration *TParseContext::parseInvariantDeclaration( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2588 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 2589 | const TSourceLoc &identifierLoc, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2590 | const ImmutableString &identifier, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2591 | const TSymbol *symbol) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2592 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2593 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2594 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2595 | if (!typeQualifier.invariant) |
| 2596 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2597 | error(identifierLoc, "Expected invariant", identifier); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2598 | return nullptr; |
| 2599 | } |
| 2600 | if (!checkIsAtGlobalLevel(identifierLoc, "invariant varying")) |
| 2601 | { |
| 2602 | return nullptr; |
| 2603 | } |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2604 | if (!symbol) |
| 2605 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2606 | error(identifierLoc, "undeclared identifier declared as invariant", identifier); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2607 | return nullptr; |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2608 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2609 | if (!IsQualifierUnspecified(typeQualifier.qualifier)) |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2610 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2611 | error(identifierLoc, "invariant declaration specifies qualifier", |
| 2612 | getQualifierString(typeQualifier.qualifier)); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2613 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2614 | if (typeQualifier.precision != EbpUndefined) |
| 2615 | { |
| 2616 | error(identifierLoc, "invariant declaration specifies precision", |
| 2617 | getPrecisionString(typeQualifier.precision)); |
| 2618 | } |
| 2619 | if (!typeQualifier.layoutQualifier.isEmpty()) |
| 2620 | { |
| 2621 | error(identifierLoc, "invariant declaration specifies layout", "'layout'"); |
| 2622 | } |
| 2623 | |
| 2624 | const TVariable *variable = getNamedVariable(identifierLoc, identifier, symbol); |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 2625 | if (!variable) |
| 2626 | { |
| 2627 | return nullptr; |
| 2628 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2629 | const TType &type = variable->getType(); |
| 2630 | |
| 2631 | checkInvariantVariableQualifier(typeQualifier.invariant, type.getQualifier(), |
| 2632 | typeQualifier.line); |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2633 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2634 | |
Olli Etuaho | 76b2c38 | 2018-03-19 15:51:29 +0200 | [diff] [blame] | 2635 | symbolTable.addInvariantVarying(*variable); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2636 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2637 | TIntermSymbol *intermSymbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2638 | intermSymbol->setLine(identifierLoc); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2639 | |
Olli Etuaho | bf4e1b7 | 2016-12-09 11:30:15 +0000 | [diff] [blame] | 2640 | return new TIntermInvariantDeclaration(intermSymbol, identifierLoc); |
Jamie Madill | 47e3ec0 | 2014-08-20 16:38:33 -0400 | [diff] [blame] | 2641 | } |
| 2642 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2643 | void TParseContext::parseDeclarator(TPublicType &publicType, |
| 2644 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2645 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2646 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2647 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2648 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2649 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2650 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2651 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2652 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2653 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2654 | } |
| 2655 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2656 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2657 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2658 | TType *type = new TType(publicType); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2659 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2660 | checkGeometryShaderInputAndSetArraySize(identifierLocation, identifier, type); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2661 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2662 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, type); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2663 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2664 | checkAtomicCounterOffsetDoesNotOverlap(true, identifierLocation, type); |
Olli Etuaho | 55bc905 | 2017-10-25 17:33:06 +0300 | [diff] [blame] | 2665 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2666 | TVariable *variable = nullptr; |
| 2667 | if (declareVariable(identifierLocation, identifier, type, &variable)) |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2668 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2669 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 2670 | symbol->setLine(identifierLocation); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2671 | declarationOut->appendDeclarator(symbol); |
| 2672 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2673 | } |
| 2674 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2675 | void TParseContext::parseArrayDeclarator(TPublicType &elementType, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2676 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2677 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2678 | const TSourceLoc &arrayLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2679 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2680 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2681 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2682 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2683 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2684 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2685 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2686 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2687 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2688 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2689 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2690 | checkDeclaratorLocationIsNotSpecified(identifierLocation, elementType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2691 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2692 | if (checkIsValidTypeAndQualifierForArray(arrayLocation, elementType)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2693 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2694 | TType *arrayType = new TType(elementType); |
| 2695 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | e7847b0 | 2015-03-16 11:56:12 +0200 | [diff] [blame] | 2696 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2697 | checkGeometryShaderInputAndSetArraySize(identifierLocation, identifier, arrayType); |
Olli Etuaho | 454c34c | 2017-10-25 16:35:56 +0300 | [diff] [blame] | 2698 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2699 | checkCanBeDeclaredWithoutInitializer(identifierLocation, identifier, arrayType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2700 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2701 | checkAtomicCounterOffsetDoesNotOverlap(true, identifierLocation, arrayType); |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2702 | |
Olli Etuaho | 6ed7bbe | 2015-04-07 18:08:46 +0300 | [diff] [blame] | 2703 | TVariable *variable = nullptr; |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2704 | if (declareVariable(identifierLocation, identifier, arrayType, &variable)) |
Olli Etuaho | d7ceaa1 | 2017-07-12 17:46:35 +0300 | [diff] [blame] | 2705 | { |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 2706 | TIntermSymbol *symbol = new TIntermSymbol(variable); |
Olli Etuaho | d7ceaa1 | 2017-07-12 17:46:35 +0300 | [diff] [blame] | 2707 | symbol->setLine(identifierLocation); |
| 2708 | declarationOut->appendDeclarator(symbol); |
| 2709 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2710 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2711 | } |
| 2712 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2713 | void TParseContext::parseInitDeclarator(const TPublicType &publicType, |
| 2714 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2715 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2716 | const TSourceLoc &initLocation, |
| 2717 | TIntermTyped *initializer, |
| 2718 | TIntermDeclaration *declarationOut) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2719 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2720 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2721 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2722 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2723 | { |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2724 | nonEmptyDeclarationErrorCheck(publicType, identifierLocation); |
| 2725 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | fa33d58 | 2015-04-09 14:33:12 +0300 | [diff] [blame] | 2726 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2727 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 2728 | checkDeclaratorLocationIsNotSpecified(identifierLocation, publicType); |
Jamie Madill | 0bd18df | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2729 | |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2730 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2731 | TType *type = new TType(publicType); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2732 | if (executeInitializer(identifierLocation, identifier, type, initializer, &initNode)) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2733 | { |
| 2734 | // |
| 2735 | // build the intermediate representation |
| 2736 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2737 | if (initNode) |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2738 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2739 | declarationOut->appendDeclarator(initNode); |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2740 | } |
Jamie Madill | 502d66f | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 2741 | } |
| 2742 | } |
| 2743 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2744 | void TParseContext::parseArrayInitDeclarator(const TPublicType &elementType, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2745 | const TSourceLoc &identifierLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 2746 | const ImmutableString &identifier, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2747 | const TSourceLoc &indexLocation, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 2748 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2749 | const TSourceLoc &initLocation, |
| 2750 | TIntermTyped *initializer, |
| 2751 | TIntermDeclaration *declarationOut) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2752 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 2753 | // If the declaration starting this declarator list was empty (example: int,), some checks were |
| 2754 | // not performed. |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2755 | if (mDeferredNonEmptyDeclarationErrorCheck) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2756 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2757 | nonEmptyDeclarationErrorCheck(elementType, identifierLocation); |
Olli Etuaho | bb7e5a7 | 2017-04-24 10:16:44 +0300 | [diff] [blame] | 2758 | mDeferredNonEmptyDeclarationErrorCheck = false; |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2759 | } |
| 2760 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2761 | checkDeclaratorLocationIsNotSpecified(identifierLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2762 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 2763 | checkIsValidTypeAndQualifierForArray(indexLocation, elementType); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2764 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 2765 | TType *arrayType = new TType(elementType); |
| 2766 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2767 | |
| 2768 | // initNode will correspond to the whole of "b[n] = initializer". |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2769 | TIntermBinary *initNode = nullptr; |
Olli Etuaho | 914b79a | 2017-06-19 16:03:19 +0300 | [diff] [blame] | 2770 | if (executeInitializer(identifierLocation, identifier, arrayType, initializer, &initNode)) |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2771 | { |
| 2772 | if (initNode) |
| 2773 | { |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 2774 | declarationOut->appendDeclarator(initNode); |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2775 | } |
Olli Etuaho | 3875ffd | 2015-04-10 16:45:14 +0300 | [diff] [blame] | 2776 | } |
| 2777 | } |
| 2778 | |
Olli Etuaho | b8ee9dd | 2017-10-30 12:43:27 +0200 | [diff] [blame] | 2779 | TIntermNode *TParseContext::addEmptyStatement(const TSourceLoc &location) |
| 2780 | { |
| 2781 | // It's simpler to parse an empty statement as a constant expression rather than having a |
| 2782 | // different type of node just for empty statements, that will be pruned from the AST anyway. |
| 2783 | TIntermNode *node = CreateZeroNode(TType(EbtInt, EbpMedium)); |
| 2784 | node->setLine(location); |
| 2785 | return node; |
| 2786 | } |
| 2787 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2788 | void TParseContext::setAtomicCounterBindingDefaultOffset(const TPublicType &publicType, |
| 2789 | const TSourceLoc &location) |
| 2790 | { |
| 2791 | const TLayoutQualifier &layoutQualifier = publicType.layoutQualifier; |
| 2792 | checkAtomicCounterBindingIsValid(location, layoutQualifier.binding); |
| 2793 | if (layoutQualifier.binding == -1 || layoutQualifier.offset == -1) |
| 2794 | { |
| 2795 | error(location, "Requires both binding and offset", "layout"); |
| 2796 | return; |
| 2797 | } |
| 2798 | mAtomicCounterBindingStates[layoutQualifier.binding].setDefaultOffset(layoutQualifier.offset); |
| 2799 | } |
| 2800 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 2801 | void TParseContext::parseDefaultPrecisionQualifier(const TPrecision precision, |
| 2802 | const TPublicType &type, |
| 2803 | const TSourceLoc &loc) |
| 2804 | { |
| 2805 | if ((precision == EbpHigh) && (getShaderType() == GL_FRAGMENT_SHADER) && |
| 2806 | !getFragmentPrecisionHigh()) |
| 2807 | { |
| 2808 | error(loc, "precision is not supported in fragment shader", "highp"); |
| 2809 | } |
| 2810 | |
| 2811 | if (!CanSetDefaultPrecisionOnType(type)) |
| 2812 | { |
| 2813 | error(loc, "illegal type argument for default precision qualifier", |
| 2814 | getBasicString(type.getBasicType())); |
| 2815 | return; |
| 2816 | } |
| 2817 | symbolTable.setDefaultPrecision(type.getBasicType(), precision); |
| 2818 | } |
| 2819 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2820 | bool TParseContext::checkPrimitiveTypeMatchesTypeQualifier(const TTypeQualifier &typeQualifier) |
| 2821 | { |
| 2822 | switch (typeQualifier.layoutQualifier.primitiveType) |
| 2823 | { |
| 2824 | case EptLines: |
| 2825 | case EptLinesAdjacency: |
| 2826 | case EptTriangles: |
| 2827 | case EptTrianglesAdjacency: |
| 2828 | return typeQualifier.qualifier == EvqGeometryIn; |
| 2829 | |
| 2830 | case EptLineStrip: |
| 2831 | case EptTriangleStrip: |
| 2832 | return typeQualifier.qualifier == EvqGeometryOut; |
| 2833 | |
| 2834 | case EptPoints: |
| 2835 | return true; |
| 2836 | |
| 2837 | default: |
| 2838 | UNREACHABLE(); |
| 2839 | return false; |
| 2840 | } |
| 2841 | } |
| 2842 | |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2843 | void TParseContext::setGeometryShaderInputArraySize(unsigned int inputArraySize, |
| 2844 | const TSourceLoc &line) |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2845 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 2846 | if (!symbolTable.setGlInArraySize(inputArraySize)) |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2847 | { |
| 2848 | error(line, |
| 2849 | "Array size or input primitive declaration doesn't match the size of earlier sized " |
| 2850 | "array inputs.", |
| 2851 | "layout"); |
| 2852 | } |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 2853 | } |
| 2854 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2855 | bool TParseContext::parseGeometryShaderInputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2856 | { |
| 2857 | ASSERT(typeQualifier.qualifier == EvqGeometryIn); |
| 2858 | |
| 2859 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2860 | |
| 2861 | if (layoutQualifier.maxVertices != -1) |
| 2862 | { |
| 2863 | error(typeQualifier.line, |
| 2864 | "max_vertices can only be declared in 'out' layout in a geometry shader", "layout"); |
| 2865 | return false; |
| 2866 | } |
| 2867 | |
| 2868 | // Set mGeometryInputPrimitiveType if exists |
| 2869 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2870 | { |
| 2871 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2872 | { |
| 2873 | error(typeQualifier.line, "invalid primitive type for 'in' layout", "layout"); |
| 2874 | return false; |
| 2875 | } |
| 2876 | |
| 2877 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 2878 | { |
| 2879 | mGeometryShaderInputPrimitiveType = layoutQualifier.primitiveType; |
Jiawei Shao | 8e4b355 | 2017-08-30 14:20:58 +0800 | [diff] [blame] | 2880 | setGeometryShaderInputArraySize( |
| 2881 | GetGeometryShaderInputArraySize(mGeometryShaderInputPrimitiveType), |
| 2882 | typeQualifier.line); |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 2883 | } |
| 2884 | else if (mGeometryShaderInputPrimitiveType != layoutQualifier.primitiveType) |
| 2885 | { |
| 2886 | error(typeQualifier.line, "primitive doesn't match earlier input primitive declaration", |
| 2887 | "layout"); |
| 2888 | return false; |
| 2889 | } |
| 2890 | } |
| 2891 | |
| 2892 | // Set mGeometryInvocations if exists |
| 2893 | if (layoutQualifier.invocations > 0) |
| 2894 | { |
| 2895 | if (mGeometryShaderInvocations == 0) |
| 2896 | { |
| 2897 | mGeometryShaderInvocations = layoutQualifier.invocations; |
| 2898 | } |
| 2899 | else if (mGeometryShaderInvocations != layoutQualifier.invocations) |
| 2900 | { |
| 2901 | error(typeQualifier.line, "invocations contradicts to the earlier declaration", |
| 2902 | "layout"); |
| 2903 | return false; |
| 2904 | } |
| 2905 | } |
| 2906 | |
| 2907 | return true; |
| 2908 | } |
| 2909 | |
| 2910 | bool TParseContext::parseGeometryShaderOutputLayoutQualifier(const TTypeQualifier &typeQualifier) |
| 2911 | { |
| 2912 | ASSERT(typeQualifier.qualifier == EvqGeometryOut); |
| 2913 | |
| 2914 | const TLayoutQualifier &layoutQualifier = typeQualifier.layoutQualifier; |
| 2915 | |
| 2916 | if (layoutQualifier.invocations > 0) |
| 2917 | { |
| 2918 | error(typeQualifier.line, |
| 2919 | "invocations can only be declared in 'in' layout in a geometry shader", "layout"); |
| 2920 | return false; |
| 2921 | } |
| 2922 | |
| 2923 | // Set mGeometryOutputPrimitiveType if exists |
| 2924 | if (layoutQualifier.primitiveType != EptUndefined) |
| 2925 | { |
| 2926 | if (!checkPrimitiveTypeMatchesTypeQualifier(typeQualifier)) |
| 2927 | { |
| 2928 | error(typeQualifier.line, "invalid primitive type for 'out' layout", "layout"); |
| 2929 | return false; |
| 2930 | } |
| 2931 | |
| 2932 | if (mGeometryShaderOutputPrimitiveType == EptUndefined) |
| 2933 | { |
| 2934 | mGeometryShaderOutputPrimitiveType = layoutQualifier.primitiveType; |
| 2935 | } |
| 2936 | else if (mGeometryShaderOutputPrimitiveType != layoutQualifier.primitiveType) |
| 2937 | { |
| 2938 | error(typeQualifier.line, |
| 2939 | "primitive doesn't match earlier output primitive declaration", "layout"); |
| 2940 | return false; |
| 2941 | } |
| 2942 | } |
| 2943 | |
| 2944 | // Set mGeometryMaxVertices if exists |
| 2945 | if (layoutQualifier.maxVertices > -1) |
| 2946 | { |
| 2947 | if (mGeometryShaderMaxVertices == -1) |
| 2948 | { |
| 2949 | mGeometryShaderMaxVertices = layoutQualifier.maxVertices; |
| 2950 | } |
| 2951 | else if (mGeometryShaderMaxVertices != layoutQualifier.maxVertices) |
| 2952 | { |
| 2953 | error(typeQualifier.line, "max_vertices contradicts to the earlier declaration", |
| 2954 | "layout"); |
| 2955 | return false; |
| 2956 | } |
| 2957 | } |
| 2958 | |
| 2959 | return true; |
| 2960 | } |
| 2961 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2962 | void TParseContext::parseGlobalLayoutQualifier(const TTypeQualifierBuilder &typeQualifierBuilder) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2963 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 2964 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2965 | const TLayoutQualifier layoutQualifier = typeQualifier.layoutQualifier; |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2966 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 2967 | checkInvariantVariableQualifier(typeQualifier.invariant, typeQualifier.qualifier, |
| 2968 | typeQualifier.line); |
| 2969 | |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2970 | // It should never be the case, but some strange parser errors can send us here. |
| 2971 | if (layoutQualifier.isEmpty()) |
| 2972 | { |
| 2973 | error(typeQualifier.line, "Error during layout qualifier parsing.", "?"); |
Jamie Madill | c2128ff | 2016-07-04 10:26:17 -0400 | [diff] [blame] | 2974 | return; |
| 2975 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2976 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2977 | if (!layoutQualifier.isCombinationValid()) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2978 | { |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2979 | error(typeQualifier.line, "invalid layout qualifier combination", "layout"); |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2980 | return; |
| 2981 | } |
| 2982 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 2983 | checkBindingIsNotSpecified(typeQualifier.line, layoutQualifier.binding); |
| 2984 | |
| 2985 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 2986 | |
| 2987 | checkInternalFormatIsNotSpecified(typeQualifier.line, layoutQualifier.imageInternalFormat); |
| 2988 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 2989 | checkYuvIsNotSpecified(typeQualifier.line, layoutQualifier.yuv); |
| 2990 | |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 2991 | checkOffsetIsNotSpecified(typeQualifier.line, layoutQualifier.offset); |
| 2992 | |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 2993 | checkStd430IsForShaderStorageBlock(typeQualifier.line, layoutQualifier.blockStorage, |
| 2994 | typeQualifier.qualifier); |
| 2995 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2996 | if (typeQualifier.qualifier == EvqComputeIn) |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 2997 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 2998 | if (mComputeShaderLocalSizeDeclared && |
| 2999 | !layoutQualifier.isLocalSizeEqual(mComputeShaderLocalSize)) |
| 3000 | { |
| 3001 | error(typeQualifier.line, "Work group size does not match the previous declaration", |
| 3002 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3003 | return; |
| 3004 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3005 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3006 | if (mShaderVersion < 310) |
| 3007 | { |
| 3008 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3009 | return; |
| 3010 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3011 | |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 3012 | if (!layoutQualifier.localSize.isAnyValueSet()) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3013 | { |
| 3014 | error(typeQualifier.line, "No local work group size specified", "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3015 | return; |
| 3016 | } |
| 3017 | |
| 3018 | const TVariable *maxComputeWorkGroupSize = static_cast<const TVariable *>( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3019 | symbolTable.findBuiltIn(ImmutableString("gl_MaxComputeWorkGroupSize"), mShaderVersion)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3020 | |
| 3021 | const TConstantUnion *maxComputeWorkGroupSizeData = |
| 3022 | maxComputeWorkGroupSize->getConstPointer(); |
| 3023 | |
| 3024 | for (size_t i = 0u; i < layoutQualifier.localSize.size(); ++i) |
| 3025 | { |
| 3026 | if (layoutQualifier.localSize[i] != -1) |
| 3027 | { |
| 3028 | mComputeShaderLocalSize[i] = layoutQualifier.localSize[i]; |
| 3029 | const int maxComputeWorkGroupSizeValue = maxComputeWorkGroupSizeData[i].getIConst(); |
| 3030 | if (mComputeShaderLocalSize[i] < 1 || |
| 3031 | mComputeShaderLocalSize[i] > maxComputeWorkGroupSizeValue) |
| 3032 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3033 | std::stringstream reasonStream; |
| 3034 | reasonStream << "invalid value: Value must be at least 1 and no greater than " |
| 3035 | << maxComputeWorkGroupSizeValue; |
| 3036 | const std::string &reason = reasonStream.str(); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3037 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3038 | error(typeQualifier.line, reason.c_str(), getWorkGroupSizeString(i)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3039 | return; |
| 3040 | } |
| 3041 | } |
| 3042 | } |
| 3043 | |
| 3044 | mComputeShaderLocalSizeDeclared = true; |
| 3045 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 3046 | else if (typeQualifier.qualifier == EvqGeometryIn) |
| 3047 | { |
| 3048 | if (mShaderVersion < 310) |
| 3049 | { |
| 3050 | error(typeQualifier.line, "in type qualifier supported in GLSL ES 3.10 only", "layout"); |
| 3051 | return; |
| 3052 | } |
| 3053 | |
| 3054 | if (!parseGeometryShaderInputLayoutQualifier(typeQualifier)) |
| 3055 | { |
| 3056 | return; |
| 3057 | } |
| 3058 | } |
| 3059 | else if (typeQualifier.qualifier == EvqGeometryOut) |
| 3060 | { |
| 3061 | if (mShaderVersion < 310) |
| 3062 | { |
| 3063 | error(typeQualifier.line, "out type qualifier supported in GLSL ES 3.10 only", |
| 3064 | "layout"); |
| 3065 | return; |
| 3066 | } |
| 3067 | |
| 3068 | if (!parseGeometryShaderOutputLayoutQualifier(typeQualifier)) |
| 3069 | { |
| 3070 | return; |
| 3071 | } |
| 3072 | } |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 3073 | else if (isExtensionEnabled(TExtension::OVR_multiview) && |
| 3074 | typeQualifier.qualifier == EvqVertexIn) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3075 | { |
| 3076 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 3077 | // specification. |
| 3078 | if (mNumViews != -1 && layoutQualifier.numViews != mNumViews) |
| 3079 | { |
| 3080 | error(typeQualifier.line, "Number of views does not match the previous declaration", |
| 3081 | "layout"); |
| 3082 | return; |
| 3083 | } |
| 3084 | |
| 3085 | if (layoutQualifier.numViews == -1) |
| 3086 | { |
| 3087 | error(typeQualifier.line, "No num_views specified", "layout"); |
| 3088 | return; |
| 3089 | } |
| 3090 | |
| 3091 | if (layoutQualifier.numViews > mMaxNumViews) |
| 3092 | { |
| 3093 | error(typeQualifier.line, "num_views greater than the value of GL_MAX_VIEWS_OVR", |
| 3094 | "layout"); |
| 3095 | return; |
| 3096 | } |
| 3097 | |
| 3098 | mNumViews = layoutQualifier.numViews; |
| 3099 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3100 | else |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3101 | { |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3102 | if (!checkWorkGroupSizeIsNotSpecified(typeQualifier.line, layoutQualifier)) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3103 | { |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3104 | return; |
| 3105 | } |
| 3106 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3107 | if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3108 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3109 | error(typeQualifier.line, "invalid qualifier: global layout can only be set for blocks", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3110 | getQualifierString(typeQualifier.qualifier)); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3111 | return; |
| 3112 | } |
| 3113 | |
| 3114 | if (mShaderVersion < 300) |
| 3115 | { |
| 3116 | error(typeQualifier.line, "layout qualifiers supported in GLSL ES 3.00 and above", |
| 3117 | "layout"); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3118 | return; |
| 3119 | } |
| 3120 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 3121 | checkLocationIsNotSpecified(typeQualifier.line, layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3122 | |
| 3123 | if (layoutQualifier.matrixPacking != EmpUnspecified) |
| 3124 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3125 | if (typeQualifier.qualifier == EvqUniform) |
| 3126 | { |
| 3127 | mDefaultUniformMatrixPacking = layoutQualifier.matrixPacking; |
| 3128 | } |
| 3129 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3130 | { |
| 3131 | mDefaultBufferMatrixPacking = layoutQualifier.matrixPacking; |
| 3132 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3133 | } |
| 3134 | |
| 3135 | if (layoutQualifier.blockStorage != EbsUnspecified) |
| 3136 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3137 | if (typeQualifier.qualifier == EvqUniform) |
| 3138 | { |
| 3139 | mDefaultUniformBlockStorage = layoutQualifier.blockStorage; |
| 3140 | } |
| 3141 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3142 | { |
| 3143 | mDefaultBufferBlockStorage = layoutQualifier.blockStorage; |
| 3144 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3145 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3146 | } |
Jamie Madill | a295edf | 2013-06-06 11:56:48 -0400 | [diff] [blame] | 3147 | } |
| 3148 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3149 | TIntermFunctionPrototype *TParseContext::createPrototypeNodeFromFunction( |
| 3150 | const TFunction &function, |
| 3151 | const TSourceLoc &location, |
| 3152 | bool insertParametersToSymbolTable) |
| 3153 | { |
Olli Etuaho | bed35d7 | 2017-12-20 16:36:26 +0200 | [diff] [blame] | 3154 | checkIsNotReserved(location, function.name()); |
Olli Etuaho | d7cd4ae | 2017-07-06 15:52:49 +0300 | [diff] [blame] | 3155 | |
Olli Etuaho | beb6dc7 | 2017-12-14 16:03:03 +0200 | [diff] [blame] | 3156 | TIntermFunctionPrototype *prototype = new TIntermFunctionPrototype(&function); |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3157 | prototype->setLine(location); |
| 3158 | |
| 3159 | for (size_t i = 0; i < function.getParamCount(); i++) |
| 3160 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3161 | const TVariable *param = function.getParam(i); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3162 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3163 | // If the parameter has no name, it's not an error, just don't add it to symbol table (could |
| 3164 | // be used for unused args). |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3165 | if (param->symbolType() != SymbolType::Empty) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3166 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3167 | if (insertParametersToSymbolTable) |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3168 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3169 | if (!symbolTable.declare(const_cast<TVariable *>(param))) |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3170 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3171 | error(location, "redefinition", param->name()); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 3172 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3173 | } |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3174 | // Unsized type of a named parameter should have already been checked and sanitized. |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3175 | ASSERT(!param->getType().isUnsizedArray()); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3176 | } |
| 3177 | else |
| 3178 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3179 | if (param->getType().isUnsizedArray()) |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3180 | { |
| 3181 | error(location, "function parameter array must be sized at compile time", "[]"); |
| 3182 | // We don't need to size the arrays since the parameter is unnamed and hence |
| 3183 | // inaccessible. |
| 3184 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3185 | } |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3186 | } |
| 3187 | return prototype; |
| 3188 | } |
| 3189 | |
Olli Etuaho | 16c745a | 2017-01-16 17:02:27 +0000 | [diff] [blame] | 3190 | TIntermFunctionPrototype *TParseContext::addFunctionPrototypeDeclaration( |
| 3191 | const TFunction &parsedFunction, |
| 3192 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3193 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3194 | // Note: function found from the symbol table could be the same as parsedFunction if this is the |
| 3195 | // first declaration. Either way the instance in the symbol table is used to track whether the |
| 3196 | // function is declared multiple times. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3197 | bool hadPrototypeDeclaration = false; |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3198 | const TFunction *function = symbolTable.markFunctionHasPrototypeDeclaration( |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3199 | parsedFunction.getMangledName(), &hadPrototypeDeclaration); |
| 3200 | |
| 3201 | if (hadPrototypeDeclaration && mShaderVersion == 100) |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3202 | { |
| 3203 | // ESSL 1.00.17 section 4.2.7. |
| 3204 | // Doesn't apply to ESSL 3.00.4: see section 4.2.3. |
| 3205 | error(location, "duplicate function prototype declarations are not allowed", "function"); |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3206 | } |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3207 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3208 | TIntermFunctionPrototype *prototype = |
| 3209 | createPrototypeNodeFromFunction(*function, location, false); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3210 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3211 | symbolTable.pop(); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3212 | |
| 3213 | if (!symbolTable.atGlobalLevel()) |
| 3214 | { |
| 3215 | // ESSL 3.00.4 section 4.2.4. |
| 3216 | error(location, "local function prototype declarations are not allowed", "function"); |
Olli Etuaho | 8d8b108 | 2016-01-04 16:44:57 +0200 | [diff] [blame] | 3217 | } |
| 3218 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3219 | return prototype; |
| 3220 | } |
| 3221 | |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3222 | TIntermFunctionDefinition *TParseContext::addFunctionDefinition( |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3223 | TIntermFunctionPrototype *functionPrototype, |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3224 | TIntermBlock *functionBody, |
| 3225 | const TSourceLoc &location) |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3226 | { |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3227 | // Check that non-void functions have at least one return statement. |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3228 | if (mCurrentFunctionType->getBasicType() != EbtVoid && !mFunctionReturnsValue) |
| 3229 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3230 | error(location, |
| 3231 | "function does not return a value:", functionPrototype->getFunction()->name()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3232 | } |
| 3233 | |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3234 | if (functionBody == nullptr) |
| 3235 | { |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 3236 | functionBody = new TIntermBlock(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3237 | functionBody->setLine(location); |
| 3238 | } |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3239 | TIntermFunctionDefinition *functionNode = |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3240 | new TIntermFunctionDefinition(functionPrototype, functionBody); |
Olli Etuaho | 336b147 | 2016-10-05 16:37:55 +0100 | [diff] [blame] | 3241 | functionNode->setLine(location); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3242 | |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3243 | symbolTable.pop(); |
Olli Etuaho | f51fdd2 | 2016-10-03 10:03:40 +0100 | [diff] [blame] | 3244 | return functionNode; |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3245 | } |
| 3246 | |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3247 | void TParseContext::parseFunctionDefinitionHeader(const TSourceLoc &location, |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3248 | const TFunction *function, |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3249 | TIntermFunctionPrototype **prototypeOut) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3250 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3251 | ASSERT(function); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3252 | |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3253 | bool wasDefined = false; |
| 3254 | function = symbolTable.setFunctionParameterNamesFromDefinition(function, &wasDefined); |
| 3255 | if (wasDefined) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3256 | { |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3257 | error(location, "function already has a body", function->name()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3258 | } |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3259 | |
Olli Etuaho | 8ad9e75 | 2017-01-16 19:55:20 +0000 | [diff] [blame] | 3260 | // Remember the return type for later checking for return statements. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3261 | mCurrentFunctionType = &(function->getReturnType()); |
Olli Etuaho | ee63f5d | 2016-01-04 11:34:54 +0200 | [diff] [blame] | 3262 | mFunctionReturnsValue = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3263 | |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3264 | *prototypeOut = createPrototypeNodeFromFunction(*function, location, true); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3265 | setLoopNestingLevel(0); |
| 3266 | } |
| 3267 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3268 | TFunction *TParseContext::parseFunctionDeclarator(const TSourceLoc &location, TFunction *function) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3269 | { |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3270 | // |
Olli Etuaho | 5d65318 | 2016-01-04 14:43:28 +0200 | [diff] [blame] | 3271 | // We don't know at this point whether this is a function definition or a prototype. |
| 3272 | // The definition production code will check for redefinitions. |
| 3273 | // In the case of ESSL 1.00 the prototype production code will also check for redeclarations. |
Geoff Lang | 13e7c7e | 2015-07-30 14:17:29 +0000 | [diff] [blame] | 3274 | // |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3275 | |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3276 | for (size_t i = 0u; i < function->getParamCount(); ++i) |
| 3277 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3278 | const TVariable *param = function->getParam(i); |
| 3279 | if (param->getType().isStructSpecifier()) |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3280 | { |
| 3281 | // ESSL 3.00.6 section 12.10. |
| 3282 | error(location, "Function parameter type cannot be a structure definition", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3283 | function->name()); |
Olli Etuaho | d80f294 | 2017-11-06 12:44:45 +0200 | [diff] [blame] | 3284 | } |
| 3285 | } |
| 3286 | |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3287 | if (getShaderVersion() >= 300) |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3288 | { |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3289 | const UnmangledBuiltIn *builtIn = |
| 3290 | symbolTable.getUnmangledBuiltInForShaderVersion(function->name(), getShaderVersion()); |
| 3291 | if (builtIn && |
| 3292 | (builtIn->extension == TExtension::UNDEFINED || isExtensionEnabled(builtIn->extension))) |
| 3293 | { |
| 3294 | // With ESSL 3.00 and above, names of built-in functions cannot be redeclared as |
| 3295 | // functions. Therefore overloading or redefining builtin functions is an error. |
| 3296 | error(location, "Name of a built-in function cannot be redeclared as function", |
| 3297 | function->name()); |
| 3298 | } |
Olli Etuaho | c4a96d6 | 2015-07-23 17:37:39 +0530 | [diff] [blame] | 3299 | } |
Olli Etuaho | 7c8567a | 2018-02-20 15:44:07 +0200 | [diff] [blame] | 3300 | else |
| 3301 | { |
| 3302 | // ESSL 1.00.17 section 4.2.6: built-ins can be overloaded but not redefined. We assume that |
| 3303 | // this applies to redeclarations as well. |
| 3304 | const TSymbol *builtIn = |
| 3305 | symbolTable.findBuiltIn(function->getMangledName(), getShaderVersion()); |
| 3306 | if (builtIn) |
| 3307 | { |
| 3308 | error(location, "built-in functions cannot be redefined", function->name()); |
| 3309 | } |
| 3310 | } |
| 3311 | |
| 3312 | // Return types and parameter qualifiers must match in all redeclarations, so those are checked |
| 3313 | // here. |
| 3314 | const TFunction *prevDec = |
| 3315 | static_cast<const TFunction *>(symbolTable.findGlobal(function->getMangledName())); |
| 3316 | if (prevDec) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3317 | { |
| 3318 | if (prevDec->getReturnType() != function->getReturnType()) |
| 3319 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3320 | error(location, "function must have the same return type in all of its declarations", |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3321 | function->getReturnType().getBasicString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3322 | } |
| 3323 | for (size_t i = 0; i < prevDec->getParamCount(); ++i) |
| 3324 | { |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3325 | if (prevDec->getParam(i)->getType().getQualifier() != |
| 3326 | function->getParam(i)->getType().getQualifier()) |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3327 | { |
Olli Etuaho | 476197f | 2016-10-11 13:59:08 +0100 | [diff] [blame] | 3328 | error(location, |
| 3329 | "function must have the same parameter qualifiers in all of its declarations", |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 3330 | function->getParam(i)->getType().getQualifierString()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3331 | } |
| 3332 | } |
| 3333 | } |
| 3334 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3335 | // Check for previously declared variables using the same name. |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3336 | const TSymbol *prevSym = symbolTable.find(function->name(), getShaderVersion()); |
| 3337 | bool insertUnmangledName = true; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3338 | if (prevSym) |
| 3339 | { |
| 3340 | if (!prevSym->isFunction()) |
| 3341 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3342 | error(location, "redefinition of a function", function->name()); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3343 | } |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3344 | insertUnmangledName = false; |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3345 | } |
Olli Etuaho | dd21ecf | 2018-01-10 12:42:09 +0200 | [diff] [blame] | 3346 | // Parsing is at the inner scope level of the function's arguments and body statement at this |
| 3347 | // point, but declareUserDefinedFunction takes care of declaring the function at the global |
| 3348 | // scope. |
| 3349 | symbolTable.declareUserDefinedFunction(function, insertUnmangledName); |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3350 | |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 3351 | // Raise error message if main function takes any parameters or return anything other than void |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3352 | if (function->isMain()) |
Olli Etuaho | 78d1374 | 2017-01-18 13:06:10 +0000 | [diff] [blame] | 3353 | { |
| 3354 | if (function->getParamCount() > 0) |
| 3355 | { |
| 3356 | error(location, "function cannot take any parameter(s)", "main"); |
| 3357 | } |
| 3358 | if (function->getReturnType().getBasicType() != EbtVoid) |
| 3359 | { |
| 3360 | error(location, "main function cannot return a value", |
| 3361 | function->getReturnType().getBasicString()); |
| 3362 | } |
| 3363 | } |
| 3364 | |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3365 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3366 | // If this is a redeclaration, it could also be a definition, in which case, we want to use the |
| 3367 | // variable names from this one, and not the one that's |
Jamie Madill | 185fb40 | 2015-06-12 15:48:48 -0400 | [diff] [blame] | 3368 | // being redeclared. So, pass back up this declaration, not the one in the symbol table. |
| 3369 | // |
| 3370 | return function; |
| 3371 | } |
| 3372 | |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3373 | TFunction *TParseContext::parseFunctionHeader(const TPublicType &type, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3374 | const ImmutableString &name, |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3375 | const TSourceLoc &location) |
| 3376 | { |
| 3377 | if (type.qualifier != EvqGlobal && type.qualifier != EvqTemporary) |
| 3378 | { |
| 3379 | error(location, "no qualifiers allowed for function return", |
| 3380 | getQualifierString(type.qualifier)); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3381 | } |
| 3382 | if (!type.layoutQualifier.isEmpty()) |
| 3383 | { |
| 3384 | error(location, "no qualifiers allowed for function return", "layout"); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3385 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3386 | // make sure an opaque type is not involved as well... |
| 3387 | std::string reason(getBasicString(type.getBasicType())); |
| 3388 | reason += "s can't be function return values"; |
| 3389 | checkIsNotOpaqueType(location, type.typeSpecifierNonArray, reason.c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3390 | if (mShaderVersion < 300) |
| 3391 | { |
| 3392 | // Array return values are forbidden, but there's also no valid syntax for declaring array |
| 3393 | // return values in ESSL 1.00. |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3394 | ASSERT(!type.isArray() || mDiagnostics->numErrors() > 0); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3395 | |
| 3396 | if (type.isStructureContainingArrays()) |
| 3397 | { |
| 3398 | // ESSL 1.00.17 section 6.1 Function Definitions |
| 3399 | error(location, "structures containing arrays can't be function return values", |
| 3400 | TType(type).getCompleteString().c_str()); |
Olli Etuaho | e29324f | 2016-06-15 10:58:03 +0300 | [diff] [blame] | 3401 | } |
| 3402 | } |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3403 | |
| 3404 | // Add the function as a prototype after parsing it (we do not support recursion) |
Olli Etuaho | 029e8ca | 2018-02-16 14:06:49 +0200 | [diff] [blame] | 3405 | return new TFunction(&symbolTable, name, SymbolType::UserDefined, new TType(type), false); |
Olli Etuaho | 9de84a5 | 2016-06-14 17:36:01 +0300 | [diff] [blame] | 3406 | } |
| 3407 | |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 3408 | TFunctionLookup *TParseContext::addNonConstructorFunc(const ImmutableString &name, |
| 3409 | const TSymbol *symbol) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3410 | { |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 3411 | return TFunctionLookup::CreateFunctionCall(name, symbol); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3412 | } |
| 3413 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3414 | TFunctionLookup *TParseContext::addConstructorFunc(const TPublicType &publicType) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3415 | { |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3416 | if (mShaderVersion < 300 && publicType.isArray()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3417 | { |
| 3418 | error(publicType.getLine(), "array constructor supported in GLSL ES 3.00 and above only", |
| 3419 | "[]"); |
| 3420 | } |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3421 | if (publicType.isStructSpecifier()) |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3422 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 3423 | error(publicType.getLine(), "constructor can't be a structure definition", |
| 3424 | getBasicString(publicType.getBasicType())); |
Olli Etuaho | bd163f6 | 2015-11-13 12:15:38 +0200 | [diff] [blame] | 3425 | } |
| 3426 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3427 | TType *type = new TType(publicType); |
| 3428 | if (!type->canBeConstructed()) |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3429 | { |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3430 | error(publicType.getLine(), "cannot construct this type", |
| 3431 | getBasicString(publicType.getBasicType())); |
| 3432 | type->setBasicType(EbtFloat); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3433 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3434 | return TFunctionLookup::CreateConstructor(type); |
shannonwoods@chromium.org | 1885113 | 2013-05-30 00:19:54 +0000 | [diff] [blame] | 3435 | } |
| 3436 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3437 | void TParseContext::checkIsNotUnsizedArray(const TSourceLoc &line, |
| 3438 | const char *errorMessage, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3439 | const ImmutableString &token, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3440 | TType *arrayType) |
| 3441 | { |
| 3442 | if (arrayType->isUnsizedArray()) |
| 3443 | { |
| 3444 | error(line, errorMessage, token); |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3445 | arrayType->sizeUnsizedArrays(nullptr); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3446 | } |
| 3447 | } |
| 3448 | |
| 3449 | TParameter TParseContext::parseParameterDeclarator(TType *type, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3450 | const ImmutableString &name, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3451 | const TSourceLoc &nameLoc) |
| 3452 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3453 | ASSERT(type); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3454 | checkIsNotUnsizedArray(nameLoc, "function parameter array must specify a size", name, type); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3455 | if (type->getBasicType() == EbtVoid) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3456 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3457 | error(nameLoc, "illegal use of type 'void'", name); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3458 | } |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3459 | checkIsNotReserved(nameLoc, name); |
| 3460 | TParameter param = {name.data(), type}; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3461 | return param; |
| 3462 | } |
| 3463 | |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3464 | TParameter TParseContext::parseParameterDeclarator(const TPublicType &publicType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3465 | const ImmutableString &name, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3466 | const TSourceLoc &nameLoc) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3467 | { |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3468 | TType *type = new TType(publicType); |
| 3469 | return parseParameterDeclarator(type, name, nameLoc); |
| 3470 | } |
| 3471 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3472 | TParameter TParseContext::parseParameterArrayDeclarator(const ImmutableString &name, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3473 | const TSourceLoc &nameLoc, |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3474 | const TVector<unsigned int> &arraySizes, |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3475 | const TSourceLoc &arrayLoc, |
| 3476 | TPublicType *elementType) |
| 3477 | { |
| 3478 | checkArrayElementIsNotArray(arrayLoc, *elementType); |
| 3479 | TType *arrayType = new TType(*elementType); |
Olli Etuaho | 7881cfd | 2017-08-23 18:00:21 +0300 | [diff] [blame] | 3480 | arrayType->makeArrays(arraySizes); |
Olli Etuaho | 55bde91 | 2017-10-25 13:41:13 +0300 | [diff] [blame] | 3481 | return parseParameterDeclarator(arrayType, name, nameLoc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 3482 | } |
| 3483 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3484 | bool TParseContext::checkUnsizedArrayConstructorArgumentDimensionality( |
| 3485 | const TIntermSequence &arguments, |
| 3486 | TType type, |
| 3487 | const TSourceLoc &line) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3488 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3489 | if (arguments.empty()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3490 | { |
| 3491 | error(line, "implicitly sized array constructor must have at least one argument", "[]"); |
| 3492 | return false; |
| 3493 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3494 | for (TIntermNode *arg : arguments) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3495 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3496 | const TIntermTyped *element = arg->getAsTyped(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3497 | ASSERT(element); |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3498 | size_t dimensionalityFromElement = element->getType().getNumArraySizes() + 1u; |
| 3499 | if (dimensionalityFromElement > type.getNumArraySizes()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3500 | { |
| 3501 | error(line, "constructing from a non-dereferenced array", "constructor"); |
| 3502 | return false; |
| 3503 | } |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3504 | else if (dimensionalityFromElement < type.getNumArraySizes()) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3505 | { |
| 3506 | if (dimensionalityFromElement == 1u) |
| 3507 | { |
| 3508 | error(line, "implicitly sized array of arrays constructor argument is not an array", |
| 3509 | "constructor"); |
| 3510 | } |
| 3511 | else |
| 3512 | { |
| 3513 | error(line, |
| 3514 | "implicitly sized array of arrays constructor argument dimensionality is too " |
| 3515 | "low", |
| 3516 | "constructor"); |
| 3517 | } |
| 3518 | return false; |
| 3519 | } |
| 3520 | } |
| 3521 | return true; |
| 3522 | } |
| 3523 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3524 | // This function is used to test for the correctness of the parameters passed to various constructor |
| 3525 | // functions and also convert them to the right datatype if it is allowed and required. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3526 | // |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3527 | // Returns a node to add to the tree regardless of if an error was generated or not. |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3528 | // |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3529 | TIntermTyped *TParseContext::addConstructor(TFunctionLookup *fnCall, const TSourceLoc &line) |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3530 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3531 | TType type = fnCall->constructorType(); |
| 3532 | TIntermSequence &arguments = fnCall->arguments(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3533 | if (type.isUnsizedArray()) |
| 3534 | { |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3535 | if (!checkUnsizedArrayConstructorArgumentDimensionality(arguments, type, line)) |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3536 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3537 | type.sizeUnsizedArrays(nullptr); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3538 | return CreateZeroNode(type); |
Olli Etuaho | bbe9fb5 | 2016-11-03 17:16:05 +0000 | [diff] [blame] | 3539 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3540 | TIntermTyped *firstElement = arguments.at(0)->getAsTyped(); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3541 | ASSERT(firstElement); |
Olli Etuaho | 9cd7163 | 2017-10-26 14:43:20 +0300 | [diff] [blame] | 3542 | if (type.getOutermostArraySize() == 0u) |
| 3543 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3544 | type.sizeOutermostUnsizedArray(static_cast<unsigned int>(arguments.size())); |
Olli Etuaho | 9cd7163 | 2017-10-26 14:43:20 +0300 | [diff] [blame] | 3545 | } |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3546 | for (size_t i = 0; i < firstElement->getType().getNumArraySizes(); ++i) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3547 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3548 | if ((*type.getArraySizes())[i] == 0u) |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3549 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 3550 | type.setArraySize(i, (*firstElement->getType().getArraySizes())[i]); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3551 | } |
| 3552 | } |
| 3553 | ASSERT(!type.isUnsizedArray()); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3554 | } |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3555 | |
Olli Etuaho | a7ecec3 | 2017-05-08 17:43:55 +0300 | [diff] [blame] | 3556 | if (!checkConstructorArguments(line, arguments, type)) |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3557 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3558 | return CreateZeroNode(type); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3559 | } |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3560 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 3561 | TIntermAggregate *constructorNode = TIntermAggregate::CreateConstructor(type, &arguments); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 3562 | constructorNode->setLine(line); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3563 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 3564 | return constructorNode->fold(mDiagnostics); |
daniel@transgaming.com | 4f39fd9 | 2010-03-08 20:26:45 +0000 | [diff] [blame] | 3565 | } |
| 3566 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3567 | // |
| 3568 | // Interface/uniform blocks |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3569 | // TODO(jiawei.shao@intel.com): implement GL_EXT_shader_io_blocks. |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3570 | // |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3571 | TIntermDeclaration *TParseContext::addInterfaceBlock( |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3572 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 3573 | const TSourceLoc &nameLine, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3574 | const ImmutableString &blockName, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3575 | TFieldList *fieldList, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3576 | const ImmutableString &instanceName, |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3577 | const TSourceLoc &instanceLine, |
| 3578 | TIntermTyped *arrayIndex, |
| 3579 | const TSourceLoc &arrayIndexLine) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3580 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3581 | checkIsNotReserved(nameLine, blockName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3582 | |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 3583 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3584 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3585 | if (mShaderVersion < 310 && typeQualifier.qualifier != EvqUniform) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3586 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3587 | error(typeQualifier.line, |
| 3588 | "invalid qualifier: interface blocks must be uniform in version lower than GLSL ES " |
| 3589 | "3.10", |
| 3590 | getQualifierString(typeQualifier.qualifier)); |
| 3591 | } |
| 3592 | else if (typeQualifier.qualifier != EvqUniform && typeQualifier.qualifier != EvqBuffer) |
| 3593 | { |
| 3594 | error(typeQualifier.line, "invalid qualifier: interface blocks must be uniform or buffer", |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3595 | getQualifierString(typeQualifier.qualifier)); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3596 | } |
| 3597 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3598 | if (typeQualifier.invariant) |
| 3599 | { |
| 3600 | error(typeQualifier.line, "invalid qualifier on interface block member", "invariant"); |
| 3601 | } |
| 3602 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3603 | if (typeQualifier.qualifier != EvqBuffer) |
| 3604 | { |
| 3605 | checkMemoryQualifierIsNotSpecified(typeQualifier.memoryQualifier, typeQualifier.line); |
| 3606 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 3607 | |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3608 | // add array index |
| 3609 | unsigned int arraySize = 0; |
| 3610 | if (arrayIndex != nullptr) |
| 3611 | { |
| 3612 | arraySize = checkIsValidArraySize(arrayIndexLine, arrayIndex); |
| 3613 | } |
| 3614 | |
| 3615 | if (mShaderVersion < 310) |
| 3616 | { |
| 3617 | checkBindingIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.binding); |
| 3618 | } |
| 3619 | else |
| 3620 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3621 | checkBlockBindingIsValid(typeQualifier.line, typeQualifier.qualifier, |
| 3622 | typeQualifier.layoutQualifier.binding, arraySize); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3623 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3624 | |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 3625 | checkYuvIsNotSpecified(typeQualifier.line, typeQualifier.layoutQualifier.yuv); |
| 3626 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3627 | TLayoutQualifier blockLayoutQualifier = typeQualifier.layoutQualifier; |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3628 | checkLocationIsNotSpecified(typeQualifier.line, blockLayoutQualifier); |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 3629 | checkStd430IsForShaderStorageBlock(typeQualifier.line, blockLayoutQualifier.blockStorage, |
| 3630 | typeQualifier.qualifier); |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3631 | |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3632 | if (blockLayoutQualifier.matrixPacking == EmpUnspecified) |
| 3633 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3634 | if (typeQualifier.qualifier == EvqUniform) |
| 3635 | { |
| 3636 | blockLayoutQualifier.matrixPacking = mDefaultUniformMatrixPacking; |
| 3637 | } |
| 3638 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3639 | { |
| 3640 | blockLayoutQualifier.matrixPacking = mDefaultBufferMatrixPacking; |
| 3641 | } |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3642 | } |
| 3643 | |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3644 | if (blockLayoutQualifier.blockStorage == EbsUnspecified) |
| 3645 | { |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3646 | if (typeQualifier.qualifier == EvqUniform) |
| 3647 | { |
| 3648 | blockLayoutQualifier.blockStorage = mDefaultUniformBlockStorage; |
| 3649 | } |
| 3650 | else if (typeQualifier.qualifier == EvqBuffer) |
| 3651 | { |
| 3652 | blockLayoutQualifier.blockStorage = mDefaultBufferBlockStorage; |
| 3653 | } |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3654 | } |
| 3655 | |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3656 | checkWorkGroupSizeIsNotSpecified(nameLine, blockLayoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 3657 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3658 | checkInternalFormatIsNotSpecified(nameLine, blockLayoutQualifier.imageInternalFormat); |
| 3659 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3660 | // check for sampler types and apply layout qualifiers |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3661 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3662 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3663 | TField *field = (*fieldList)[memberIndex]; |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3664 | TType *fieldType = field->type(); |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3665 | if (IsOpaqueType(fieldType->getBasicType())) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3666 | { |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 3667 | std::string reason("unsupported type - "); |
| 3668 | reason += fieldType->getBasicString(); |
| 3669 | reason += " types are not allowed in interface blocks"; |
| 3670 | error(field->line(), reason.c_str(), fieldType->getBasicString()); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 3671 | } |
| 3672 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3673 | const TQualifier qualifier = fieldType->getQualifier(); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3674 | switch (qualifier) |
| 3675 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3676 | case EvqGlobal: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3677 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3678 | case EvqUniform: |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3679 | if (typeQualifier.qualifier == EvqBuffer) |
| 3680 | { |
| 3681 | error(field->line(), "invalid qualifier on shader storage block member", |
| 3682 | getQualifierString(qualifier)); |
| 3683 | } |
| 3684 | break; |
| 3685 | case EvqBuffer: |
| 3686 | if (typeQualifier.qualifier == EvqUniform) |
| 3687 | { |
| 3688 | error(field->line(), "invalid qualifier on uniform block member", |
| 3689 | getQualifierString(qualifier)); |
| 3690 | } |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3691 | break; |
| 3692 | default: |
| 3693 | error(field->line(), "invalid qualifier on interface block member", |
| 3694 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3695 | break; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3696 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3697 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 3698 | if (fieldType->isInvariant()) |
| 3699 | { |
| 3700 | error(field->line(), "invalid qualifier on interface block member", "invariant"); |
| 3701 | } |
| 3702 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 3703 | // check layout qualifiers |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3704 | TLayoutQualifier fieldLayoutQualifier = fieldType->getLayoutQualifier(); |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 3705 | checkLocationIsNotSpecified(field->line(), fieldLayoutQualifier); |
jchen10 | af713a2 | 2017-04-19 09:10:56 +0800 | [diff] [blame] | 3706 | checkBindingIsNotSpecified(field->line(), fieldLayoutQualifier.binding); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3707 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3708 | if (fieldLayoutQualifier.blockStorage != EbsUnspecified) |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3709 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3710 | error(field->line(), "invalid layout qualifier: cannot be used here", |
| 3711 | getBlockStorageString(fieldLayoutQualifier.blockStorage)); |
Jamie Madill | 1566ef7 | 2013-06-20 11:55:54 -0400 | [diff] [blame] | 3712 | } |
| 3713 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3714 | if (fieldLayoutQualifier.matrixPacking == EmpUnspecified) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3715 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3716 | fieldLayoutQualifier.matrixPacking = blockLayoutQualifier.matrixPacking; |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3717 | } |
Olli Etuaho | fb6ab2c | 2015-07-09 20:55:28 +0300 | [diff] [blame] | 3718 | else if (!fieldType->isMatrix() && fieldType->getBasicType() != EbtStruct) |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3719 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3720 | warning(field->line(), |
| 3721 | "extraneous layout qualifier: only has an effect on matrix types", |
| 3722 | getMatrixPackingString(fieldLayoutQualifier.matrixPacking)); |
Jamie Madill | 099c0f3 | 2013-06-20 11:55:52 -0400 | [diff] [blame] | 3723 | } |
| 3724 | |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3725 | fieldType->setLayoutQualifier(fieldLayoutQualifier); |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3726 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3727 | if (mShaderVersion < 310 || memberIndex != fieldList->size() - 1u || |
| 3728 | typeQualifier.qualifier != EvqBuffer) |
| 3729 | { |
| 3730 | // ESSL 3.10 spec section 4.1.9 allows for runtime-sized arrays. |
| 3731 | checkIsNotUnsizedArray(field->line(), |
| 3732 | "array members of interface blocks must specify a size", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3733 | field->name(), field->type()); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3734 | } |
| 3735 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 3736 | if (typeQualifier.qualifier == EvqBuffer) |
| 3737 | { |
| 3738 | // set memory qualifiers |
| 3739 | // GLSL ES 3.10 session 4.9 [Memory Access Qualifiers]. When a block declaration is |
| 3740 | // qualified with a memory qualifier, it is as if all of its members were declared with |
| 3741 | // the same memory qualifier. |
| 3742 | const TMemoryQualifier &blockMemoryQualifier = typeQualifier.memoryQualifier; |
| 3743 | TMemoryQualifier fieldMemoryQualifier = fieldType->getMemoryQualifier(); |
| 3744 | fieldMemoryQualifier.readonly |= blockMemoryQualifier.readonly; |
| 3745 | fieldMemoryQualifier.writeonly |= blockMemoryQualifier.writeonly; |
| 3746 | fieldMemoryQualifier.coherent |= blockMemoryQualifier.coherent; |
| 3747 | fieldMemoryQualifier.restrictQualifier |= blockMemoryQualifier.restrictQualifier; |
| 3748 | fieldMemoryQualifier.volatileQualifier |= blockMemoryQualifier.volatileQualifier; |
| 3749 | // TODO(jiajia.qin@intel.com): Decide whether if readonly and writeonly buffer variable |
| 3750 | // is legal. See bug https://github.com/KhronosGroup/OpenGL-API/issues/7 |
| 3751 | fieldType->setMemoryQualifier(fieldMemoryQualifier); |
| 3752 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3753 | } |
| 3754 | |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 3755 | TInterfaceBlock *interfaceBlock = new TInterfaceBlock( |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3756 | &symbolTable, blockName, fieldList, blockLayoutQualifier, SymbolType::UserDefined); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3757 | if (!symbolTable.declare(interfaceBlock)) |
Olli Etuaho | 378c3a5 | 2017-12-04 11:32:13 +0200 | [diff] [blame] | 3758 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3759 | error(nameLine, "redefinition of an interface block name", blockName); |
Olli Etuaho | 378c3a5 | 2017-12-04 11:32:13 +0200 | [diff] [blame] | 3760 | } |
| 3761 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3762 | TType *interfaceBlockType = |
| 3763 | new TType(interfaceBlock, typeQualifier.qualifier, blockLayoutQualifier); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3764 | if (arrayIndex != nullptr) |
| 3765 | { |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3766 | interfaceBlockType->makeArray(arraySize); |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 3767 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3768 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3769 | // The instance variable gets created to refer to the interface block type from the AST |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3770 | // regardless of if there's an instance name. It's created as an empty symbol if there is no |
| 3771 | // instance name. |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3772 | TVariable *instanceVariable = |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3773 | new TVariable(&symbolTable, instanceName, interfaceBlockType, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3774 | instanceName.empty() ? SymbolType::Empty : SymbolType::UserDefined); |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3775 | |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 3776 | if (instanceVariable->symbolType() == SymbolType::Empty) |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3777 | { |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3778 | // define symbols for the members of the interface block |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3779 | for (size_t memberIndex = 0; memberIndex < fieldList->size(); ++memberIndex) |
| 3780 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3781 | TField *field = (*fieldList)[memberIndex]; |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3782 | TType *fieldType = new TType(*field->type()); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3783 | |
| 3784 | // set parent pointer of the field variable |
| 3785 | fieldType->setInterfaceBlock(interfaceBlock); |
| 3786 | |
Olli Etuaho | b60d30f | 2018-01-16 12:31:06 +0200 | [diff] [blame] | 3787 | fieldType->setQualifier(typeQualifier.qualifier); |
| 3788 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3789 | TVariable *fieldVariable = |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3790 | new TVariable(&symbolTable, field->name(), fieldType, SymbolType::UserDefined); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3791 | if (!symbolTable.declare(fieldVariable)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3792 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3793 | error(field->line(), "redefinition of an interface block member name", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3794 | field->name()); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3795 | } |
| 3796 | } |
| 3797 | } |
| 3798 | else |
| 3799 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3800 | checkIsNotReserved(instanceLine, instanceName); |
Olli Etuaho | e0f623a | 2015-07-10 11:58:30 +0300 | [diff] [blame] | 3801 | |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3802 | // add a symbol for this interface block |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 3803 | if (!symbolTable.declare(instanceVariable)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3804 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3805 | error(instanceLine, "redefinition of an interface block instance name", instanceName); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3806 | } |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3807 | } |
| 3808 | |
Olli Etuaho | 195be94 | 2017-12-04 23:40:14 +0200 | [diff] [blame] | 3809 | TIntermSymbol *blockSymbol = new TIntermSymbol(instanceVariable); |
| 3810 | blockSymbol->setLine(typeQualifier.line); |
| 3811 | TIntermDeclaration *declaration = new TIntermDeclaration(); |
| 3812 | declaration->appendDeclarator(blockSymbol); |
| 3813 | declaration->setLine(nameLine); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 3814 | |
| 3815 | exitStructDeclaration(); |
Olli Etuaho | 13389b6 | 2016-10-16 11:48:18 +0100 | [diff] [blame] | 3816 | return declaration; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 3817 | } |
| 3818 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3819 | void TParseContext::enterStructDeclaration(const TSourceLoc &line, |
| 3820 | const ImmutableString &identifier) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3821 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3822 | ++mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3823 | |
| 3824 | // Embedded structure definitions are not supported per GLSL ES spec. |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3825 | // ESSL 1.00.17 section 10.9. ESSL 3.00.6 section 12.11. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3826 | if (mStructNestingLevel > 1) |
| 3827 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3828 | error(line, "Embedded struct definitions are not allowed", "struct"); |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3829 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3830 | } |
| 3831 | |
| 3832 | void TParseContext::exitStructDeclaration() |
| 3833 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 3834 | --mStructNestingLevel; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3835 | } |
| 3836 | |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3837 | void TParseContext::checkIsBelowStructNestingLimit(const TSourceLoc &line, const TField &field) |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3838 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 3839 | if (!sh::IsWebGLBasedSpec(mShaderSpec)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3840 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3841 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3842 | } |
| 3843 | |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3844 | if (field.type()->getBasicType() != EbtStruct) |
| 3845 | { |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3846 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3847 | } |
| 3848 | |
| 3849 | // We're already inside a structure definition at this point, so add |
| 3850 | // one to the field's struct nesting. |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3851 | if (1 + field.type()->getDeepestStructNesting() > kWebGLMaxStructNesting) |
| 3852 | { |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3853 | std::stringstream reasonStream; |
Olli Etuaho | f095799 | 2017-12-22 11:10:04 +0200 | [diff] [blame] | 3854 | if (field.type()->getStruct()->symbolType() == SymbolType::Empty) |
| 3855 | { |
| 3856 | // This may happen in case there are nested struct definitions. While they are also |
| 3857 | // invalid GLSL, they don't cause a syntax error. |
| 3858 | reasonStream << "Struct nesting"; |
| 3859 | } |
| 3860 | else |
| 3861 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3862 | reasonStream << "Reference of struct type " << field.type()->getStruct()->name(); |
Olli Etuaho | f095799 | 2017-12-22 11:10:04 +0200 | [diff] [blame] | 3863 | } |
| 3864 | reasonStream << " exceeds maximum allowed nesting level of " << kWebGLMaxStructNesting; |
Jamie Madill | 41a4927 | 2014-03-18 16:10:13 -0400 | [diff] [blame] | 3865 | std::string reason = reasonStream.str(); |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3866 | error(line, reason.c_str(), field.name()); |
Olli Etuaho | 8a17626 | 2016-08-16 14:23:01 +0300 | [diff] [blame] | 3867 | return; |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3868 | } |
kbr@chromium.org | 476541f | 2011-10-27 21:14:51 +0000 | [diff] [blame] | 3869 | } |
| 3870 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 3871 | // |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3872 | // Parse an array index expression |
| 3873 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 3874 | TIntermTyped *TParseContext::addIndexExpression(TIntermTyped *baseExpression, |
| 3875 | const TSourceLoc &location, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3876 | TIntermTyped *indexExpression) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3877 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3878 | if (!baseExpression->isArray() && !baseExpression->isMatrix() && !baseExpression->isVector()) |
| 3879 | { |
| 3880 | if (baseExpression->getAsSymbolNode()) |
| 3881 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 3882 | error(location, " left of '[' is not of type array, matrix, or vector ", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 3883 | baseExpression->getAsSymbolNode()->getName()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3884 | } |
| 3885 | else |
| 3886 | { |
| 3887 | error(location, " left of '[' is not of type array, matrix, or vector ", "expression"); |
| 3888 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3889 | |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 3890 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 3891 | } |
shannonwoods@chromium.org | 09e0988 | 2013-05-30 00:18:25 +0000 | [diff] [blame] | 3892 | |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3893 | if (baseExpression->getQualifier() == EvqPerVertexIn) |
| 3894 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3895 | ASSERT(mShaderType == GL_GEOMETRY_SHADER_EXT); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3896 | if (mGeometryShaderInputPrimitiveType == EptUndefined) |
| 3897 | { |
| 3898 | error(location, "missing input primitive declaration before indexing gl_in.", "["); |
| 3899 | return CreateZeroNode(TType(EbtFloat, EbpHigh, EvqConst)); |
| 3900 | } |
| 3901 | } |
| 3902 | |
Jamie Madill | 21c1e45 | 2014-12-29 11:33:41 -0500 | [diff] [blame] | 3903 | TIntermConstantUnion *indexConstantUnion = indexExpression->getAsConstantUnion(); |
| 3904 | |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3905 | // TODO(oetuaho@nvidia.com): Get rid of indexConstantUnion == nullptr below once ANGLE is able |
| 3906 | // to constant fold all constant expressions. Right now we don't allow indexing interface blocks |
| 3907 | // or fragment outputs with expressions that ANGLE is not able to constant fold, even if the |
| 3908 | // index is a constant expression. |
| 3909 | if (indexExpression->getQualifier() != EvqConst || indexConstantUnion == nullptr) |
| 3910 | { |
| 3911 | if (baseExpression->isInterfaceBlock()) |
| 3912 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 3913 | // TODO(jiawei.shao@intel.com): implement GL_EXT_shader_io_blocks. |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3914 | switch (baseExpression->getQualifier()) |
| 3915 | { |
| 3916 | case EvqPerVertexIn: |
| 3917 | break; |
| 3918 | case EvqUniform: |
| 3919 | case EvqBuffer: |
| 3920 | error(location, |
| 3921 | "array indexes for uniform block arrays and shader storage block arrays " |
| 3922 | "must be constant integral expressions", |
| 3923 | "["); |
| 3924 | break; |
| 3925 | default: |
Jiawei Shao | 7e1197e | 2017-08-24 15:48:38 +0800 | [diff] [blame] | 3926 | // We can reach here only in error cases. |
| 3927 | ASSERT(mDiagnostics->numErrors() > 0); |
| 3928 | break; |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 3929 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3930 | } |
| 3931 | else if (baseExpression->getQualifier() == EvqFragmentOut) |
| 3932 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3933 | error(location, |
| 3934 | "array indexes for fragment outputs must be constant integral expressions", "["); |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3935 | } |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3936 | else if (mShaderSpec == SH_WEBGL2_SPEC && baseExpression->getQualifier() == EvqFragData) |
| 3937 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 3938 | error(location, "array index for gl_FragData must be constant zero", "["); |
Olli Etuaho | 3e96046 | 2015-11-12 15:58:39 +0200 | [diff] [blame] | 3939 | } |
Olli Etuaho | 36b0514 | 2015-11-12 13:10:42 +0200 | [diff] [blame] | 3940 | } |
| 3941 | |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3942 | if (indexConstantUnion) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3943 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3944 | // If an out-of-range index is not qualified as constant, the behavior in the spec is |
| 3945 | // undefined. This applies even if ANGLE has been able to constant fold it (ANGLE may |
| 3946 | // constant fold expressions that are not constant expressions). The most compatible way to |
| 3947 | // handle this case is to report a warning instead of an error and force the index to be in |
| 3948 | // the correct range. |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 3949 | bool outOfRangeIndexIsError = indexExpression->getQualifier() == EvqConst; |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 3950 | int index = 0; |
| 3951 | if (indexConstantUnion->getBasicType() == EbtInt) |
| 3952 | { |
| 3953 | index = indexConstantUnion->getIConst(0); |
| 3954 | } |
| 3955 | else if (indexConstantUnion->getBasicType() == EbtUInt) |
| 3956 | { |
| 3957 | index = static_cast<int>(indexConstantUnion->getUConst(0)); |
| 3958 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3959 | |
| 3960 | int safeIndex = -1; |
| 3961 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3962 | if (index < 0) |
Jamie Madill | 7164cf4 | 2013-07-08 13:30:59 -0400 | [diff] [blame] | 3963 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3964 | outOfRangeError(outOfRangeIndexIsError, location, "index expression is negative", "[]"); |
| 3965 | safeIndex = 0; |
| 3966 | } |
| 3967 | |
| 3968 | if (!baseExpression->getType().isUnsizedArray()) |
| 3969 | { |
| 3970 | if (baseExpression->isArray()) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 3971 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3972 | if (baseExpression->getQualifier() == EvqFragData && index > 0) |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3973 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3974 | if (!isExtensionEnabled(TExtension::EXT_draw_buffers)) |
| 3975 | { |
| 3976 | outOfRangeError(outOfRangeIndexIsError, location, |
| 3977 | "array index for gl_FragData must be zero when " |
| 3978 | "GL_EXT_draw_buffers is disabled", |
| 3979 | "[]"); |
| 3980 | safeIndex = 0; |
| 3981 | } |
| 3982 | } |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 3983 | } |
| 3984 | // Only do generic out-of-range check if similar error hasn't already been reported. |
| 3985 | if (safeIndex < 0) |
| 3986 | { |
| 3987 | if (baseExpression->isArray()) |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 3988 | { |
| 3989 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 3990 | baseExpression->getOutermostArraySize(), |
| 3991 | "array index out of range"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 3992 | } |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 3993 | else if (baseExpression->isMatrix()) |
| 3994 | { |
| 3995 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 3996 | baseExpression->getType().getCols(), |
| 3997 | "matrix field selection out of range"); |
| 3998 | } |
| 3999 | else |
| 4000 | { |
| 4001 | ASSERT(baseExpression->isVector()); |
| 4002 | safeIndex = checkIndexLessThan(outOfRangeIndexIsError, location, index, |
| 4003 | baseExpression->getType().getNominalSize(), |
| 4004 | "vector field selection out of range"); |
| 4005 | } |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4006 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4007 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4008 | ASSERT(safeIndex >= 0); |
| 4009 | // Data of constant unions can't be changed, because it may be shared with other |
| 4010 | // constant unions or even builtins, like gl_MaxDrawBuffers. Instead use a new |
| 4011 | // sanitized object. |
| 4012 | if (safeIndex != index || indexConstantUnion->getBasicType() != EbtInt) |
| 4013 | { |
| 4014 | TConstantUnion *safeConstantUnion = new TConstantUnion(); |
| 4015 | safeConstantUnion->setIConst(safeIndex); |
Olli Etuaho | 0e99b7a | 2018-01-12 12:05:48 +0200 | [diff] [blame] | 4016 | indexExpression = new TIntermConstantUnion( |
| 4017 | safeConstantUnion, TType(EbtInt, indexExpression->getPrecision(), |
| 4018 | indexExpression->getQualifier())); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4019 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4020 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4021 | TIntermBinary *node = |
| 4022 | new TIntermBinary(EOpIndexDirect, baseExpression, indexExpression); |
| 4023 | node->setLine(location); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 4024 | return expressionOrFoldedResult(node); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4025 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4026 | } |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4027 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4028 | markStaticReadIfSymbol(indexExpression); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4029 | TIntermBinary *node = new TIntermBinary(EOpIndexIndirect, baseExpression, indexExpression); |
| 4030 | node->setLine(location); |
| 4031 | // Indirect indexing can never be constant folded. |
| 4032 | return node; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4033 | } |
| 4034 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4035 | int TParseContext::checkIndexLessThan(bool outOfRangeIndexIsError, |
| 4036 | const TSourceLoc &location, |
| 4037 | int index, |
| 4038 | int arraySize, |
| 4039 | const char *reason) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4040 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4041 | // Should not reach here with an unsized / runtime-sized array. |
| 4042 | ASSERT(arraySize > 0); |
Olli Etuaho | f13cadd | 2017-11-28 10:53:09 +0200 | [diff] [blame] | 4043 | // A negative index should already have been checked. |
| 4044 | ASSERT(index >= 0); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4045 | if (index >= arraySize) |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4046 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4047 | std::stringstream reasonStream; |
| 4048 | reasonStream << reason << " '" << index << "'"; |
| 4049 | std::string token = reasonStream.str(); |
| 4050 | outOfRangeError(outOfRangeIndexIsError, location, reason, "[]"); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4051 | return arraySize - 1; |
Olli Etuaho | 90892fb | 2016-07-14 14:44:51 +0300 | [diff] [blame] | 4052 | } |
| 4053 | return index; |
| 4054 | } |
| 4055 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4056 | TIntermTyped *TParseContext::addFieldSelectionExpression(TIntermTyped *baseExpression, |
| 4057 | const TSourceLoc &dotLocation, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4058 | const ImmutableString &fieldString, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4059 | const TSourceLoc &fieldLocation) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4060 | { |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4061 | if (baseExpression->isArray()) |
| 4062 | { |
| 4063 | error(fieldLocation, "cannot apply dot operator to an array", "."); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4064 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4065 | } |
| 4066 | |
| 4067 | if (baseExpression->isVector()) |
| 4068 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4069 | TVector<int> fieldOffsets; |
| 4070 | if (!parseVectorFields(fieldLocation, fieldString, baseExpression->getNominalSize(), |
| 4071 | &fieldOffsets)) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4072 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4073 | fieldOffsets.resize(1); |
| 4074 | fieldOffsets[0] = 0; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4075 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4076 | TIntermSwizzle *node = new TIntermSwizzle(baseExpression, fieldOffsets); |
| 4077 | node->setLine(dotLocation); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4078 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 4079 | return node->fold(mDiagnostics); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4080 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4081 | else if (baseExpression->getBasicType() == EbtStruct) |
| 4082 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4083 | const TFieldList &fields = baseExpression->getType().getStruct()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4084 | if (fields.empty()) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4085 | { |
| 4086 | error(dotLocation, "structure has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4087 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4088 | } |
| 4089 | else |
| 4090 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4091 | bool fieldFound = false; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4092 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4093 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4094 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4095 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4096 | { |
| 4097 | fieldFound = true; |
| 4098 | break; |
| 4099 | } |
| 4100 | } |
| 4101 | if (fieldFound) |
| 4102 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 4103 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4104 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4105 | TIntermBinary *node = |
| 4106 | new TIntermBinary(EOpIndexDirectStruct, baseExpression, index); |
| 4107 | node->setLine(dotLocation); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 4108 | return expressionOrFoldedResult(node); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4109 | } |
| 4110 | else |
| 4111 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4112 | error(dotLocation, " no such field in structure", fieldString); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4113 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4114 | } |
| 4115 | } |
| 4116 | } |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4117 | else if (baseExpression->isInterfaceBlock()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4118 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4119 | const TFieldList &fields = baseExpression->getType().getInterfaceBlock()->fields(); |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4120 | if (fields.empty()) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4121 | { |
| 4122 | error(dotLocation, "interface block has no fields", "Internal Error"); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4123 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4124 | } |
| 4125 | else |
| 4126 | { |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4127 | bool fieldFound = false; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4128 | unsigned int i; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4129 | for (i = 0; i < fields.size(); ++i) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4130 | { |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4131 | if (fields[i]->name() == fieldString) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4132 | { |
| 4133 | fieldFound = true; |
| 4134 | break; |
| 4135 | } |
| 4136 | } |
| 4137 | if (fieldFound) |
| 4138 | { |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 4139 | TIntermTyped *index = CreateIndexNode(i); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4140 | index->setLine(fieldLocation); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4141 | TIntermBinary *node = |
| 4142 | new TIntermBinary(EOpIndexDirectInterfaceBlock, baseExpression, index); |
| 4143 | node->setLine(dotLocation); |
| 4144 | // Indexing interface blocks can never be constant folded. |
| 4145 | return node; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4146 | } |
| 4147 | else |
| 4148 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4149 | error(dotLocation, " no such field in interface block", fieldString); |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4150 | return baseExpression; |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4151 | } |
| 4152 | } |
| 4153 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4154 | else |
| 4155 | { |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 4156 | if (mShaderVersion < 300) |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4157 | { |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4158 | error(dotLocation, " field selection requires structure or vector on left hand side", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4159 | fieldString); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4160 | } |
| 4161 | else |
| 4162 | { |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4163 | error(dotLocation, |
Olli Etuaho | 56193ce | 2015-08-12 15:55:09 +0300 | [diff] [blame] | 4164 | " field selection requires structure, vector, or interface block on left hand " |
| 4165 | "side", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4166 | fieldString); |
shannonwoods@chromium.org | 5668c5d | 2013-05-30 00:11:48 +0000 | [diff] [blame] | 4167 | } |
Olli Etuaho | 3272a6d | 2016-08-29 17:54:50 +0300 | [diff] [blame] | 4168 | return baseExpression; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4169 | } |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4170 | } |
| 4171 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4172 | TLayoutQualifier TParseContext::parseLayoutQualifier(const ImmutableString &qualifierType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4173 | const TSourceLoc &qualifierTypeLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4174 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 4175 | TLayoutQualifier qualifier = TLayoutQualifier::Create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4176 | |
| 4177 | if (qualifierType == "shared") |
| 4178 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4179 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4180 | { |
| 4181 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "shared"); |
| 4182 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4183 | qualifier.blockStorage = EbsShared; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4184 | } |
| 4185 | else if (qualifierType == "packed") |
| 4186 | { |
Jamie Madill | acb4b81 | 2016-11-07 13:50:29 -0500 | [diff] [blame] | 4187 | if (sh::IsWebGLBasedSpec(mShaderSpec)) |
Olli Etuaho | f017315 | 2016-10-17 09:05:03 -0700 | [diff] [blame] | 4188 | { |
| 4189 | error(qualifierTypeLine, "Only std140 layout is allowed in WebGL", "packed"); |
| 4190 | } |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4191 | qualifier.blockStorage = EbsPacked; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4192 | } |
Qin Jiajia | ca68d98 | 2017-09-18 16:41:56 +0800 | [diff] [blame] | 4193 | else if (qualifierType == "std430") |
| 4194 | { |
| 4195 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4196 | qualifier.blockStorage = EbsStd430; |
| 4197 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4198 | else if (qualifierType == "std140") |
| 4199 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4200 | qualifier.blockStorage = EbsStd140; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4201 | } |
| 4202 | else if (qualifierType == "row_major") |
| 4203 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4204 | qualifier.matrixPacking = EmpRowMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4205 | } |
| 4206 | else if (qualifierType == "column_major") |
| 4207 | { |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4208 | qualifier.matrixPacking = EmpColumnMajor; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4209 | } |
| 4210 | else if (qualifierType == "location") |
| 4211 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4212 | error(qualifierTypeLine, "invalid layout qualifier: location requires an argument", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4213 | qualifierType); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4214 | } |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4215 | else if (qualifierType == "yuv" && mShaderType == GL_FRAGMENT_SHADER) |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 4216 | { |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4217 | if (checkCanUseExtension(qualifierTypeLine, TExtension::EXT_YUV_target)) |
| 4218 | { |
| 4219 | qualifier.yuv = true; |
| 4220 | } |
Andrei Volykhin | a552707 | 2017-03-22 16:46:30 +0300 | [diff] [blame] | 4221 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4222 | else if (qualifierType == "rgba32f") |
| 4223 | { |
| 4224 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4225 | qualifier.imageInternalFormat = EiifRGBA32F; |
| 4226 | } |
| 4227 | else if (qualifierType == "rgba16f") |
| 4228 | { |
| 4229 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4230 | qualifier.imageInternalFormat = EiifRGBA16F; |
| 4231 | } |
| 4232 | else if (qualifierType == "r32f") |
| 4233 | { |
| 4234 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4235 | qualifier.imageInternalFormat = EiifR32F; |
| 4236 | } |
| 4237 | else if (qualifierType == "rgba8") |
| 4238 | { |
| 4239 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4240 | qualifier.imageInternalFormat = EiifRGBA8; |
| 4241 | } |
| 4242 | else if (qualifierType == "rgba8_snorm") |
| 4243 | { |
| 4244 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4245 | qualifier.imageInternalFormat = EiifRGBA8_SNORM; |
| 4246 | } |
| 4247 | else if (qualifierType == "rgba32i") |
| 4248 | { |
| 4249 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4250 | qualifier.imageInternalFormat = EiifRGBA32I; |
| 4251 | } |
| 4252 | else if (qualifierType == "rgba16i") |
| 4253 | { |
| 4254 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4255 | qualifier.imageInternalFormat = EiifRGBA16I; |
| 4256 | } |
| 4257 | else if (qualifierType == "rgba8i") |
| 4258 | { |
| 4259 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4260 | qualifier.imageInternalFormat = EiifRGBA8I; |
| 4261 | } |
| 4262 | else if (qualifierType == "r32i") |
| 4263 | { |
| 4264 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4265 | qualifier.imageInternalFormat = EiifR32I; |
| 4266 | } |
| 4267 | else if (qualifierType == "rgba32ui") |
| 4268 | { |
| 4269 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4270 | qualifier.imageInternalFormat = EiifRGBA32UI; |
| 4271 | } |
| 4272 | else if (qualifierType == "rgba16ui") |
| 4273 | { |
| 4274 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4275 | qualifier.imageInternalFormat = EiifRGBA16UI; |
| 4276 | } |
| 4277 | else if (qualifierType == "rgba8ui") |
| 4278 | { |
| 4279 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4280 | qualifier.imageInternalFormat = EiifRGBA8UI; |
| 4281 | } |
| 4282 | else if (qualifierType == "r32ui") |
| 4283 | { |
| 4284 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4285 | qualifier.imageInternalFormat = EiifR32UI; |
| 4286 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4287 | else if (qualifierType == "points" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4288 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4289 | { |
| 4290 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4291 | qualifier.primitiveType = EptPoints; |
| 4292 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4293 | else if (qualifierType == "lines" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4294 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4295 | { |
| 4296 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4297 | qualifier.primitiveType = EptLines; |
| 4298 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4299 | else if (qualifierType == "lines_adjacency" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4300 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4301 | { |
| 4302 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4303 | qualifier.primitiveType = EptLinesAdjacency; |
| 4304 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4305 | else if (qualifierType == "triangles" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4306 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4307 | { |
| 4308 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4309 | qualifier.primitiveType = EptTriangles; |
| 4310 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4311 | else if (qualifierType == "triangles_adjacency" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4312 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4313 | { |
| 4314 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4315 | qualifier.primitiveType = EptTrianglesAdjacency; |
| 4316 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4317 | else if (qualifierType == "line_strip" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4318 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4319 | { |
| 4320 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4321 | qualifier.primitiveType = EptLineStrip; |
| 4322 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4323 | else if (qualifierType == "triangle_strip" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4324 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4325 | { |
| 4326 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4327 | qualifier.primitiveType = EptTriangleStrip; |
| 4328 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4329 | |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4330 | else |
| 4331 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4332 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4333 | } |
| 4334 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4335 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4336 | } |
| 4337 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4338 | void TParseContext::parseLocalSize(const ImmutableString &qualifierType, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4339 | const TSourceLoc &qualifierTypeLine, |
| 4340 | int intValue, |
| 4341 | const TSourceLoc &intValueLine, |
| 4342 | const std::string &intValueString, |
| 4343 | size_t index, |
Martin Radev | 4c4c8e7 | 2016-08-04 12:25:34 +0300 | [diff] [blame] | 4344 | sh::WorkGroupSize *localSize) |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4345 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4346 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4347 | if (intValue < 1) |
| 4348 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4349 | std::stringstream reasonStream; |
| 4350 | reasonStream << "out of range: " << getWorkGroupSizeString(index) << " must be positive"; |
| 4351 | std::string reason = reasonStream.str(); |
| 4352 | error(intValueLine, reason.c_str(), intValueString.c_str()); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4353 | } |
| 4354 | (*localSize)[index] = intValue; |
| 4355 | } |
| 4356 | |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4357 | void TParseContext::parseNumViews(int intValue, |
| 4358 | const TSourceLoc &intValueLine, |
| 4359 | const std::string &intValueString, |
| 4360 | int *numViews) |
| 4361 | { |
| 4362 | // This error is only specified in WebGL, but tightens unspecified behavior in the native |
| 4363 | // specification. |
| 4364 | if (intValue < 1) |
| 4365 | { |
| 4366 | error(intValueLine, "out of range: num_views must be positive", intValueString.c_str()); |
| 4367 | } |
| 4368 | *numViews = intValue; |
| 4369 | } |
| 4370 | |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4371 | void TParseContext::parseInvocations(int intValue, |
| 4372 | const TSourceLoc &intValueLine, |
| 4373 | const std::string &intValueString, |
| 4374 | int *numInvocations) |
| 4375 | { |
| 4376 | // Although SPEC isn't clear whether invocations can be less than 1, we add this limit because |
| 4377 | // it doesn't make sense to accept invocations <= 0. |
| 4378 | if (intValue < 1 || intValue > mMaxGeometryShaderInvocations) |
| 4379 | { |
| 4380 | error(intValueLine, |
| 4381 | "out of range: invocations must be in the range of [1, " |
| 4382 | "MAX_GEOMETRY_SHADER_INVOCATIONS_OES]", |
| 4383 | intValueString.c_str()); |
| 4384 | } |
| 4385 | else |
| 4386 | { |
| 4387 | *numInvocations = intValue; |
| 4388 | } |
| 4389 | } |
| 4390 | |
| 4391 | void TParseContext::parseMaxVertices(int intValue, |
| 4392 | const TSourceLoc &intValueLine, |
| 4393 | const std::string &intValueString, |
| 4394 | int *maxVertices) |
| 4395 | { |
| 4396 | // Although SPEC isn't clear whether max_vertices can be less than 0, we add this limit because |
| 4397 | // it doesn't make sense to accept max_vertices < 0. |
| 4398 | if (intValue < 0 || intValue > mMaxGeometryShaderMaxVertices) |
| 4399 | { |
| 4400 | error( |
| 4401 | intValueLine, |
| 4402 | "out of range: max_vertices must be in the range of [0, gl_MaxGeometryOutputVertices]", |
| 4403 | intValueString.c_str()); |
| 4404 | } |
| 4405 | else |
| 4406 | { |
| 4407 | *maxVertices = intValue; |
| 4408 | } |
| 4409 | } |
| 4410 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4411 | TLayoutQualifier TParseContext::parseLayoutQualifier(const ImmutableString &qualifierType, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4412 | const TSourceLoc &qualifierTypeLine, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4413 | int intValue, |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4414 | const TSourceLoc &intValueLine) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4415 | { |
Jamie Madill | 2f294c9 | 2017-11-20 14:47:26 -0500 | [diff] [blame] | 4416 | TLayoutQualifier qualifier = TLayoutQualifier::Create(); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4417 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4418 | std::string intValueString = Str(intValue); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4419 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4420 | if (qualifierType == "location") |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4421 | { |
Jamie Madill | 05a80ce | 2013-06-20 11:55:49 -0400 | [diff] [blame] | 4422 | // must check that location is non-negative |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4423 | if (intValue < 0) |
| 4424 | { |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4425 | error(intValueLine, "out of range: location must be non-negative", |
| 4426 | intValueString.c_str()); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4427 | } |
| 4428 | else |
| 4429 | { |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 4430 | qualifier.location = intValue; |
Olli Etuaho | 87d410c | 2016-09-05 13:33:26 +0300 | [diff] [blame] | 4431 | qualifier.locationsSpecified = 1; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4432 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4433 | } |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4434 | else if (qualifierType == "binding") |
| 4435 | { |
| 4436 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4437 | if (intValue < 0) |
| 4438 | { |
| 4439 | error(intValueLine, "out of range: binding must be non-negative", |
| 4440 | intValueString.c_str()); |
| 4441 | } |
| 4442 | else |
| 4443 | { |
| 4444 | qualifier.binding = intValue; |
| 4445 | } |
| 4446 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4447 | else if (qualifierType == "offset") |
| 4448 | { |
| 4449 | checkLayoutQualifierSupported(qualifierTypeLine, qualifierType, 310); |
| 4450 | if (intValue < 0) |
| 4451 | { |
| 4452 | error(intValueLine, "out of range: offset must be non-negative", |
| 4453 | intValueString.c_str()); |
| 4454 | } |
| 4455 | else |
| 4456 | { |
| 4457 | qualifier.offset = intValue; |
| 4458 | } |
| 4459 | } |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4460 | else if (qualifierType == "local_size_x") |
| 4461 | { |
| 4462 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 0u, |
| 4463 | &qualifier.localSize); |
| 4464 | } |
| 4465 | else if (qualifierType == "local_size_y") |
| 4466 | { |
| 4467 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 1u, |
| 4468 | &qualifier.localSize); |
| 4469 | } |
| 4470 | else if (qualifierType == "local_size_z") |
| 4471 | { |
| 4472 | parseLocalSize(qualifierType, qualifierTypeLine, intValue, intValueLine, intValueString, 2u, |
| 4473 | &qualifier.localSize); |
| 4474 | } |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4475 | else if (qualifierType == "num_views" && mShaderType == GL_VERTEX_SHADER) |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4476 | { |
Olli Etuaho | 703671e | 2017-11-08 17:47:18 +0200 | [diff] [blame] | 4477 | if (checkCanUseExtension(qualifierTypeLine, TExtension::OVR_multiview)) |
| 4478 | { |
| 4479 | parseNumViews(intValue, intValueLine, intValueString, &qualifier.numViews); |
| 4480 | } |
Olli Etuaho | 09b04a2 | 2016-12-15 13:30:26 +0000 | [diff] [blame] | 4481 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4482 | else if (qualifierType == "invocations" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4483 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4484 | { |
| 4485 | parseInvocations(intValue, intValueLine, intValueString, &qualifier.invocations); |
| 4486 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4487 | else if (qualifierType == "max_vertices" && mShaderType == GL_GEOMETRY_SHADER_EXT && |
| 4488 | checkCanUseExtension(qualifierTypeLine, TExtension::EXT_geometry_shader)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4489 | { |
| 4490 | parseMaxVertices(intValue, intValueLine, intValueString, &qualifier.maxVertices); |
| 4491 | } |
| 4492 | |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4493 | else |
| 4494 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4495 | error(qualifierTypeLine, "invalid layout qualifier", qualifierType); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4496 | } |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4497 | |
Jamie Madill | a5efff9 | 2013-06-06 11:56:47 -0400 | [diff] [blame] | 4498 | return qualifier; |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4499 | } |
| 4500 | |
Olli Etuaho | 613b959 | 2016-09-05 12:05:53 +0300 | [diff] [blame] | 4501 | TTypeQualifierBuilder *TParseContext::createTypeQualifierBuilder(const TSourceLoc &loc) |
| 4502 | { |
| 4503 | return new TTypeQualifierBuilder( |
| 4504 | new TStorageQualifierWrapper(symbolTable.atGlobalLevel() ? EvqGlobal : EvqTemporary, loc), |
| 4505 | mShaderVersion); |
| 4506 | } |
| 4507 | |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4508 | TStorageQualifierWrapper *TParseContext::parseGlobalStorageQualifier(TQualifier qualifier, |
| 4509 | const TSourceLoc &loc) |
| 4510 | { |
| 4511 | checkIsAtGlobalLevel(loc, getQualifierString(qualifier)); |
| 4512 | return new TStorageQualifierWrapper(qualifier, loc); |
| 4513 | } |
| 4514 | |
| 4515 | TStorageQualifierWrapper *TParseContext::parseVaryingQualifier(const TSourceLoc &loc) |
| 4516 | { |
| 4517 | if (getShaderType() == GL_VERTEX_SHADER) |
| 4518 | { |
| 4519 | return parseGlobalStorageQualifier(EvqVaryingOut, loc); |
| 4520 | } |
| 4521 | return parseGlobalStorageQualifier(EvqVaryingIn, loc); |
| 4522 | } |
| 4523 | |
| 4524 | TStorageQualifierWrapper *TParseContext::parseInQualifier(const TSourceLoc &loc) |
| 4525 | { |
| 4526 | if (declaringFunction()) |
| 4527 | { |
| 4528 | return new TStorageQualifierWrapper(EvqIn, loc); |
| 4529 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4530 | |
| 4531 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4532 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4533 | case GL_VERTEX_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4534 | { |
Olli Etuaho | 2a1e8f9 | 2017-07-14 11:49:36 +0300 | [diff] [blame] | 4535 | if (mShaderVersion < 300 && !isExtensionEnabled(TExtension::OVR_multiview)) |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4536 | { |
| 4537 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4538 | } |
| 4539 | return new TStorageQualifierWrapper(EvqVertexIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4540 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4541 | case GL_FRAGMENT_SHADER: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4542 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4543 | if (mShaderVersion < 300) |
| 4544 | { |
| 4545 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "in"); |
| 4546 | } |
| 4547 | return new TStorageQualifierWrapper(EvqFragmentIn, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4548 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4549 | case GL_COMPUTE_SHADER: |
| 4550 | { |
| 4551 | return new TStorageQualifierWrapper(EvqComputeIn, loc); |
| 4552 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4553 | case GL_GEOMETRY_SHADER_EXT: |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4554 | { |
| 4555 | return new TStorageQualifierWrapper(EvqGeometryIn, loc); |
| 4556 | } |
| 4557 | default: |
| 4558 | { |
| 4559 | UNREACHABLE(); |
| 4560 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4561 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4562 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4563 | } |
| 4564 | |
| 4565 | TStorageQualifierWrapper *TParseContext::parseOutQualifier(const TSourceLoc &loc) |
| 4566 | { |
| 4567 | if (declaringFunction()) |
| 4568 | { |
| 4569 | return new TStorageQualifierWrapper(EvqOut, loc); |
| 4570 | } |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4571 | switch (getShaderType()) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4572 | { |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4573 | case GL_VERTEX_SHADER: |
| 4574 | { |
| 4575 | if (mShaderVersion < 300) |
| 4576 | { |
| 4577 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4578 | } |
| 4579 | return new TStorageQualifierWrapper(EvqVertexOut, loc); |
| 4580 | } |
| 4581 | case GL_FRAGMENT_SHADER: |
| 4582 | { |
| 4583 | if (mShaderVersion < 300) |
| 4584 | { |
| 4585 | error(loc, "storage qualifier supported in GLSL ES 3.00 and above only", "out"); |
| 4586 | } |
| 4587 | return new TStorageQualifierWrapper(EvqFragmentOut, loc); |
| 4588 | } |
| 4589 | case GL_COMPUTE_SHADER: |
| 4590 | { |
| 4591 | error(loc, "storage qualifier isn't supported in compute shaders", "out"); |
| 4592 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4593 | } |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 4594 | case GL_GEOMETRY_SHADER_EXT: |
Shao | b5cc119 | 2017-07-06 10:47:20 +0800 | [diff] [blame] | 4595 | { |
| 4596 | return new TStorageQualifierWrapper(EvqGeometryOut, loc); |
| 4597 | } |
| 4598 | default: |
| 4599 | { |
| 4600 | UNREACHABLE(); |
| 4601 | return new TStorageQualifierWrapper(EvqLast, loc); |
| 4602 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4603 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4604 | } |
| 4605 | |
| 4606 | TStorageQualifierWrapper *TParseContext::parseInOutQualifier(const TSourceLoc &loc) |
| 4607 | { |
| 4608 | if (!declaringFunction()) |
| 4609 | { |
| 4610 | error(loc, "invalid qualifier: can be only used with function parameters", "inout"); |
| 4611 | } |
| 4612 | return new TStorageQualifierWrapper(EvqInOut, loc); |
| 4613 | } |
| 4614 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4615 | TLayoutQualifier TParseContext::joinLayoutQualifiers(TLayoutQualifier leftQualifier, |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4616 | TLayoutQualifier rightQualifier, |
| 4617 | const TSourceLoc &rightQualifierLocation) |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4618 | { |
Martin Radev | c28888b | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4619 | return sh::JoinLayoutQualifiers(leftQualifier, rightQualifier, rightQualifierLocation, |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4620 | mDiagnostics); |
shannonwoods@chromium.org | 302adfe | 2013-05-30 00:21:06 +0000 | [diff] [blame] | 4621 | } |
| 4622 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4623 | TDeclarator *TParseContext::parseStructDeclarator(const ImmutableString &identifier, |
| 4624 | const TSourceLoc &loc) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4625 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4626 | checkIsNotReserved(loc, identifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4627 | return new TDeclarator(identifier, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4628 | } |
| 4629 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4630 | TDeclarator *TParseContext::parseStructArrayDeclarator(const ImmutableString &identifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4631 | const TSourceLoc &loc, |
| 4632 | const TVector<unsigned int> *arraySizes) |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4633 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4634 | checkIsNotReserved(loc, identifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4635 | return new TDeclarator(identifier, arraySizes, loc); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4636 | } |
| 4637 | |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4638 | void TParseContext::checkDoesNotHaveDuplicateFieldName(const TFieldList::const_iterator begin, |
| 4639 | const TFieldList::const_iterator end, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4640 | const ImmutableString &name, |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4641 | const TSourceLoc &location) |
| 4642 | { |
| 4643 | for (auto fieldIter = begin; fieldIter != end; ++fieldIter) |
| 4644 | { |
| 4645 | if ((*fieldIter)->name() == name) |
| 4646 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4647 | error(location, "duplicate field name in structure", name); |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4648 | } |
| 4649 | } |
| 4650 | } |
| 4651 | |
| 4652 | TFieldList *TParseContext::addStructFieldList(TFieldList *fields, const TSourceLoc &location) |
| 4653 | { |
| 4654 | for (TFieldList::const_iterator fieldIter = fields->begin(); fieldIter != fields->end(); |
| 4655 | ++fieldIter) |
| 4656 | { |
| 4657 | checkDoesNotHaveDuplicateFieldName(fields->begin(), fieldIter, (*fieldIter)->name(), |
| 4658 | location); |
| 4659 | } |
| 4660 | return fields; |
| 4661 | } |
| 4662 | |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4663 | TFieldList *TParseContext::combineStructFieldLists(TFieldList *processedFields, |
| 4664 | const TFieldList *newlyAddedFields, |
| 4665 | const TSourceLoc &location) |
| 4666 | { |
| 4667 | for (TField *field : *newlyAddedFields) |
| 4668 | { |
Olli Etuaho | 722bfb5 | 2017-10-26 17:00:11 +0300 | [diff] [blame] | 4669 | checkDoesNotHaveDuplicateFieldName(processedFields->begin(), processedFields->end(), |
| 4670 | field->name(), location); |
Olli Etuaho | 4de340a | 2016-12-16 09:32:03 +0000 | [diff] [blame] | 4671 | processedFields->push_back(field); |
| 4672 | } |
| 4673 | return processedFields; |
| 4674 | } |
| 4675 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4676 | TFieldList *TParseContext::addStructDeclaratorListWithQualifiers( |
| 4677 | const TTypeQualifierBuilder &typeQualifierBuilder, |
| 4678 | TPublicType *typeSpecifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4679 | const TDeclaratorList *declaratorList) |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4680 | { |
Olli Etuaho | 77ba408 | 2016-12-16 12:01:18 +0000 | [diff] [blame] | 4681 | TTypeQualifier typeQualifier = typeQualifierBuilder.getVariableTypeQualifier(mDiagnostics); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4682 | |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4683 | typeSpecifier->qualifier = typeQualifier.qualifier; |
| 4684 | typeSpecifier->layoutQualifier = typeQualifier.layoutQualifier; |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4685 | typeSpecifier->memoryQualifier = typeQualifier.memoryQualifier; |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4686 | typeSpecifier->invariant = typeQualifier.invariant; |
| 4687 | if (typeQualifier.precision != EbpUndefined) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4688 | { |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4689 | typeSpecifier->precision = typeQualifier.precision; |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4690 | } |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4691 | return addStructDeclaratorList(*typeSpecifier, declaratorList); |
Jamie Madill | f2e0f9b | 2013-08-26 16:39:42 -0400 | [diff] [blame] | 4692 | } |
| 4693 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4694 | TFieldList *TParseContext::addStructDeclaratorList(const TPublicType &typeSpecifier, |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4695 | const TDeclaratorList *declaratorList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4696 | { |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4697 | checkPrecisionSpecified(typeSpecifier.getLine(), typeSpecifier.precision, |
| 4698 | typeSpecifier.getBasicType()); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4699 | |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4700 | checkIsNonVoid(typeSpecifier.getLine(), (*declaratorList)[0]->name(), |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4701 | typeSpecifier.getBasicType()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4702 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4703 | checkWorkGroupSizeIsNotSpecified(typeSpecifier.getLine(), typeSpecifier.layoutQualifier); |
Martin Radev | 802abe0 | 2016-08-04 17:48:32 +0300 | [diff] [blame] | 4704 | |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4705 | TFieldList *fieldList = new TFieldList(); |
| 4706 | |
| 4707 | for (const TDeclarator *declarator : *declaratorList) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4708 | { |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4709 | TType *type = new TType(typeSpecifier); |
| 4710 | if (declarator->isArray()) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4711 | { |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4712 | // Don't allow arrays of arrays in ESSL < 3.10. |
Olli Etuaho | e080387 | 2017-08-23 15:30:23 +0300 | [diff] [blame] | 4713 | checkArrayElementIsNotArray(typeSpecifier.getLine(), typeSpecifier); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4714 | type->makeArrays(*declarator->arraySizes()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4715 | } |
Olli Etuaho | 96f6adf | 2017-08-16 11:18:54 +0300 | [diff] [blame] | 4716 | |
Jamie Madill | f5557ac | 2018-06-15 09:46:58 -0400 | [diff] [blame^] | 4717 | TField *field = |
| 4718 | new TField(type, declarator->name(), declarator->line(), SymbolType::UserDefined); |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4719 | checkIsBelowStructNestingLimit(typeSpecifier.getLine(), *field); |
| 4720 | fieldList->push_back(field); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4721 | } |
| 4722 | |
Olli Etuaho | d5f44c9 | 2017-11-29 17:15:40 +0200 | [diff] [blame] | 4723 | return fieldList; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4724 | } |
| 4725 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4726 | TTypeSpecifierNonArray TParseContext::addStructure(const TSourceLoc &structLine, |
| 4727 | const TSourceLoc &nameLine, |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4728 | const ImmutableString &structName, |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4729 | TFieldList *fieldList) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4730 | { |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4731 | SymbolType structSymbolType = SymbolType::UserDefined; |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4732 | if (structName.empty()) |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4733 | { |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4734 | structSymbolType = SymbolType::Empty; |
| 4735 | } |
| 4736 | TStructure *structure = new TStructure(&symbolTable, structName, fieldList, structSymbolType); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4737 | |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4738 | // Store a bool in the struct if we're at global scope, to allow us to |
| 4739 | // skip the local struct scoping workaround in HLSL. |
Jamie Madill | 9b82084 | 2015-02-12 10:40:10 -0500 | [diff] [blame] | 4740 | structure->setAtGlobalScope(symbolTable.atGlobalLevel()); |
Jamie Madill | bfa91f4 | 2014-06-05 15:45:18 -0400 | [diff] [blame] | 4741 | |
Olli Etuaho | 9d4d7f0 | 2017-12-07 17:11:41 +0100 | [diff] [blame] | 4742 | if (structSymbolType != SymbolType::Empty) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4743 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4744 | checkIsNotReserved(nameLine, structName); |
Olli Etuaho | 437664b | 2018-02-28 15:38:14 +0200 | [diff] [blame] | 4745 | if (!symbolTable.declare(structure)) |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 4746 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4747 | error(nameLine, "redefinition of a struct", structName); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4748 | } |
| 4749 | } |
| 4750 | |
| 4751 | // ensure we do not specify any storage qualifiers on the struct members |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4752 | for (unsigned int typeListIndex = 0; typeListIndex < fieldList->size(); typeListIndex++) |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4753 | { |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4754 | TField &field = *(*fieldList)[typeListIndex]; |
Jamie Madill | 98493dd | 2013-07-08 14:39:03 -0400 | [diff] [blame] | 4755 | const TQualifier qualifier = field.type()->getQualifier(); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4756 | switch (qualifier) |
| 4757 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4758 | case EvqGlobal: |
| 4759 | case EvqTemporary: |
| 4760 | break; |
| 4761 | default: |
| 4762 | error(field.line(), "invalid qualifier on struct member", |
| 4763 | getQualifierString(qualifier)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4764 | break; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4765 | } |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4766 | if (field.type()->isInvariant()) |
| 4767 | { |
| 4768 | error(field.line(), "invalid qualifier on struct member", "invariant"); |
| 4769 | } |
jchen10 | 4cdac9e | 2017-05-08 11:01:20 +0800 | [diff] [blame] | 4770 | // ESSL 3.10 section 4.1.8 -- atomic_uint or images are not allowed as structure member. |
| 4771 | if (IsImage(field.type()->getBasicType()) || IsAtomicCounter(field.type()->getBasicType())) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 4772 | { |
| 4773 | error(field.line(), "disallowed type in struct", field.type()->getBasicString()); |
| 4774 | } |
| 4775 | |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4776 | checkIsNotUnsizedArray(field.line(), "array members of structs must specify a size", |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 4777 | field.name(), field.type()); |
Olli Etuaho | ebee5b3 | 2017-11-23 12:56:32 +0200 | [diff] [blame] | 4778 | |
Olli Etuaho | 4336489 | 2017-02-13 16:00:12 +0000 | [diff] [blame] | 4779 | checkMemoryQualifierIsNotSpecified(field.type()->getMemoryQualifier(), field.line()); |
| 4780 | |
| 4781 | checkBindingIsNotSpecified(field.line(), field.type()->getLayoutQualifier().binding); |
Martin Radev | 70866b8 | 2016-07-22 15:27:42 +0300 | [diff] [blame] | 4782 | |
| 4783 | checkLocationIsNotSpecified(field.line(), field.type()->getLayoutQualifier()); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4784 | } |
| 4785 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4786 | TTypeSpecifierNonArray typeSpecifierNonArray; |
Olli Etuaho | 0f68463 | 2017-07-13 12:42:15 +0300 | [diff] [blame] | 4787 | typeSpecifierNonArray.initializeStruct(structure, true, structLine); |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4788 | exitStructDeclaration(); |
| 4789 | |
Martin Radev | 4a9cd80 | 2016-09-01 16:51:51 +0300 | [diff] [blame] | 4790 | return typeSpecifierNonArray; |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 4791 | } |
| 4792 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4793 | TIntermSwitch *TParseContext::addSwitch(TIntermTyped *init, |
Olli Etuaho | 6d40bbd | 2016-09-30 13:49:38 +0100 | [diff] [blame] | 4794 | TIntermBlock *statementList, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4795 | const TSourceLoc &loc) |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4796 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4797 | TBasicType switchType = init->getBasicType(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4798 | if ((switchType != EbtInt && switchType != EbtUInt) || init->isMatrix() || init->isArray() || |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4799 | init->isVector()) |
| 4800 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4801 | error(init->getLine(), "init-expression in a switch statement must be a scalar integer", |
| 4802 | "switch"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4803 | return nullptr; |
| 4804 | } |
| 4805 | |
Olli Etuaho | 923ecef | 2017-10-11 12:01:38 +0300 | [diff] [blame] | 4806 | ASSERT(statementList); |
Olli Etuaho | d05f964 | 2018-03-05 12:13:26 +0200 | [diff] [blame] | 4807 | if (!ValidateSwitchStatementList(switchType, mDiagnostics, statementList, loc)) |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4808 | { |
Olli Etuaho | cbcb96f | 2017-10-19 14:14:06 +0300 | [diff] [blame] | 4809 | ASSERT(mDiagnostics->numErrors() > 0); |
Olli Etuaho | 923ecef | 2017-10-11 12:01:38 +0300 | [diff] [blame] | 4810 | return nullptr; |
Olli Etuaho | ac5274d | 2015-02-20 10:19:08 +0200 | [diff] [blame] | 4811 | } |
| 4812 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4813 | markStaticReadIfSymbol(init); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4814 | TIntermSwitch *node = new TIntermSwitch(init, statementList); |
| 4815 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4816 | return node; |
| 4817 | } |
| 4818 | |
| 4819 | TIntermCase *TParseContext::addCase(TIntermTyped *condition, const TSourceLoc &loc) |
| 4820 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4821 | if (mSwitchNestingLevel == 0) |
| 4822 | { |
| 4823 | error(loc, "case labels need to be inside switch statements", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4824 | return nullptr; |
| 4825 | } |
| 4826 | if (condition == nullptr) |
| 4827 | { |
| 4828 | error(loc, "case label must have a condition", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4829 | return nullptr; |
| 4830 | } |
| 4831 | if ((condition->getBasicType() != EbtInt && condition->getBasicType() != EbtUInt) || |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4832 | condition->isMatrix() || condition->isArray() || condition->isVector()) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4833 | { |
| 4834 | error(condition->getLine(), "case label must be a scalar integer", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4835 | } |
| 4836 | TIntermConstantUnion *conditionConst = condition->getAsConstantUnion(); |
Olli Etuaho | 7c3848e | 2015-11-04 13:19:17 +0200 | [diff] [blame] | 4837 | // TODO(oetuaho@nvidia.com): Get rid of the conditionConst == nullptr check once all constant |
| 4838 | // expressions can be folded. Right now we don't allow constant expressions that ANGLE can't |
| 4839 | // fold in case labels. |
| 4840 | if (condition->getQualifier() != EvqConst || conditionConst == nullptr) |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4841 | { |
| 4842 | error(condition->getLine(), "case label must be constant", "case"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4843 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4844 | TIntermCase *node = new TIntermCase(condition); |
| 4845 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4846 | return node; |
| 4847 | } |
| 4848 | |
| 4849 | TIntermCase *TParseContext::addDefault(const TSourceLoc &loc) |
| 4850 | { |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4851 | if (mSwitchNestingLevel == 0) |
| 4852 | { |
| 4853 | error(loc, "default labels need to be inside switch statements", "default"); |
Olli Etuaho | 53f076f | 2015-02-20 10:55:14 +0200 | [diff] [blame] | 4854 | return nullptr; |
| 4855 | } |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4856 | TIntermCase *node = new TIntermCase(nullptr); |
| 4857 | node->setLine(loc); |
Olli Etuaho | a3a3666 | 2015-02-17 13:46:51 +0200 | [diff] [blame] | 4858 | return node; |
| 4859 | } |
| 4860 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4861 | TIntermTyped *TParseContext::createUnaryMath(TOperator op, |
| 4862 | TIntermTyped *child, |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4863 | const TSourceLoc &loc, |
| 4864 | const TFunction *func) |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4865 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4866 | ASSERT(child != nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4867 | |
| 4868 | switch (op) |
| 4869 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4870 | case EOpLogicalNot: |
| 4871 | if (child->getBasicType() != EbtBool || child->isMatrix() || child->isArray() || |
| 4872 | child->isVector()) |
| 4873 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4874 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4875 | return nullptr; |
| 4876 | } |
| 4877 | break; |
| 4878 | case EOpBitwiseNot: |
| 4879 | if ((child->getBasicType() != EbtInt && child->getBasicType() != EbtUInt) || |
| 4880 | child->isMatrix() || child->isArray()) |
| 4881 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4882 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4883 | return nullptr; |
| 4884 | } |
| 4885 | break; |
| 4886 | case EOpPostIncrement: |
| 4887 | case EOpPreIncrement: |
| 4888 | case EOpPostDecrement: |
| 4889 | case EOpPreDecrement: |
| 4890 | case EOpNegative: |
| 4891 | case EOpPositive: |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 4892 | if (child->getBasicType() == EbtStruct || child->isInterfaceBlock() || |
| 4893 | child->getBasicType() == EbtBool || child->isArray() || |
| 4894 | IsOpaqueType(child->getBasicType())) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4895 | { |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 4896 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4897 | return nullptr; |
| 4898 | } |
Nico Weber | 41b072b | 2018-02-09 10:01:32 -0500 | [diff] [blame] | 4899 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4900 | // Operators for built-ins are already type checked against their prototype. |
| 4901 | default: |
| 4902 | break; |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4903 | } |
| 4904 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4905 | if (child->getMemoryQualifier().writeonly) |
| 4906 | { |
| 4907 | unaryOpError(loc, GetOperatorString(op), child->getCompleteString()); |
| 4908 | return nullptr; |
| 4909 | } |
| 4910 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 4911 | markStaticReadIfSymbol(child); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4912 | TIntermUnary *node = new TIntermUnary(op, child, func); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4913 | node->setLine(loc); |
Olli Etuaho | f119a26 | 2016-08-19 15:54:22 +0300 | [diff] [blame] | 4914 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 4915 | return node->fold(mDiagnostics); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4916 | } |
| 4917 | |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4918 | TIntermTyped *TParseContext::addUnaryMath(TOperator op, TIntermTyped *child, const TSourceLoc &loc) |
| 4919 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 4920 | ASSERT(op != EOpNull); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 4921 | TIntermTyped *node = createUnaryMath(op, child, loc, nullptr); |
Olli Etuaho | 69c11b5 | 2015-03-26 12:59:00 +0200 | [diff] [blame] | 4922 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4923 | { |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4924 | return child; |
| 4925 | } |
| 4926 | return node; |
| 4927 | } |
| 4928 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4929 | TIntermTyped *TParseContext::addUnaryMathLValue(TOperator op, |
| 4930 | TIntermTyped *child, |
| 4931 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4932 | { |
Olli Etuaho | 856c497 | 2016-08-08 11:38:39 +0300 | [diff] [blame] | 4933 | checkCanBeLValue(loc, GetOperatorString(op), child); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 4934 | return addUnaryMath(op, child, loc); |
| 4935 | } |
| 4936 | |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 4937 | TIntermTyped *TParseContext::expressionOrFoldedResult(TIntermTyped *expression) |
| 4938 | { |
| 4939 | // If we can, we should return the folded version of the expression for subsequent parsing. This |
| 4940 | // enables folding the containing expression during parsing as well, instead of the separate |
| 4941 | // FoldExpressions() step where folding nested expressions requires multiple full AST |
| 4942 | // traversals. |
| 4943 | |
| 4944 | // Even if folding fails the fold() functions return some node representing the expression, |
| 4945 | // typically the original node. So "folded" can be assumed to be non-null. |
| 4946 | TIntermTyped *folded = expression->fold(mDiagnostics); |
| 4947 | ASSERT(folded != nullptr); |
| 4948 | if (folded->getQualifier() == expression->getQualifier()) |
| 4949 | { |
| 4950 | // We need this expression to have the correct qualifier when validating the consuming |
| 4951 | // expression. So we can only return the folded node from here in case it has the same |
| 4952 | // qualifier as the original expression. In this kind of a cases the qualifier of the folded |
| 4953 | // node is EvqConst, whereas the qualifier of the expression is EvqTemporary: |
| 4954 | // 1. (true ? 1.0 : non_constant) |
| 4955 | // 2. (non_constant, 1.0) |
| 4956 | return folded; |
| 4957 | } |
| 4958 | return expression; |
| 4959 | } |
| 4960 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 4961 | bool TParseContext::binaryOpCommonCheck(TOperator op, |
| 4962 | TIntermTyped *left, |
| 4963 | TIntermTyped *right, |
| 4964 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 4965 | { |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 4966 | // Check opaque types are not allowed to be operands in expressions other than array indexing |
| 4967 | // and structure member selection. |
| 4968 | if (IsOpaqueType(left->getBasicType()) || IsOpaqueType(right->getBasicType())) |
| 4969 | { |
| 4970 | switch (op) |
| 4971 | { |
| 4972 | case EOpIndexDirect: |
| 4973 | case EOpIndexIndirect: |
| 4974 | break; |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 4975 | |
| 4976 | default: |
Nico Weber | b5db2b4 | 2018-02-12 15:31:56 -0500 | [diff] [blame] | 4977 | ASSERT(op != EOpIndexDirectStruct); |
jchen10 | b4cf565 | 2017-05-05 18:51:17 +0800 | [diff] [blame] | 4978 | error(loc, "Invalid operation for variables with an opaque type", |
| 4979 | GetOperatorString(op)); |
| 4980 | return false; |
| 4981 | } |
| 4982 | } |
jchen10 | cc2a10e | 2017-05-03 14:05:12 +0800 | [diff] [blame] | 4983 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 4984 | if (right->getMemoryQualifier().writeonly) |
| 4985 | { |
| 4986 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 4987 | return false; |
| 4988 | } |
| 4989 | |
| 4990 | if (left->getMemoryQualifier().writeonly) |
| 4991 | { |
| 4992 | switch (op) |
| 4993 | { |
| 4994 | case EOpAssign: |
| 4995 | case EOpInitialize: |
| 4996 | case EOpIndexDirect: |
| 4997 | case EOpIndexIndirect: |
| 4998 | case EOpIndexDirectStruct: |
| 4999 | case EOpIndexDirectInterfaceBlock: |
| 5000 | break; |
| 5001 | default: |
| 5002 | error(loc, "Invalid operation for variables with writeonly", GetOperatorString(op)); |
| 5003 | return false; |
| 5004 | } |
| 5005 | } |
| 5006 | |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5007 | if (left->getType().getStruct() || right->getType().getStruct()) |
| 5008 | { |
| 5009 | switch (op) |
| 5010 | { |
| 5011 | case EOpIndexDirectStruct: |
| 5012 | ASSERT(left->getType().getStruct()); |
| 5013 | break; |
| 5014 | case EOpEqual: |
| 5015 | case EOpNotEqual: |
| 5016 | case EOpAssign: |
| 5017 | case EOpInitialize: |
| 5018 | if (left->getType() != right->getType()) |
| 5019 | { |
| 5020 | return false; |
| 5021 | } |
| 5022 | break; |
| 5023 | default: |
| 5024 | error(loc, "Invalid operation for structs", GetOperatorString(op)); |
| 5025 | return false; |
| 5026 | } |
| 5027 | } |
| 5028 | |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5029 | if (left->isInterfaceBlock() || right->isInterfaceBlock()) |
| 5030 | { |
| 5031 | switch (op) |
| 5032 | { |
| 5033 | case EOpIndexDirectInterfaceBlock: |
| 5034 | ASSERT(left->getType().getInterfaceBlock()); |
| 5035 | break; |
| 5036 | default: |
| 5037 | error(loc, "Invalid operation for interface blocks", GetOperatorString(op)); |
| 5038 | return false; |
| 5039 | } |
| 5040 | } |
| 5041 | |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5042 | if (left->isArray() != right->isArray()) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5043 | { |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5044 | error(loc, "array / non-array mismatch", GetOperatorString(op)); |
| 5045 | return false; |
| 5046 | } |
| 5047 | |
| 5048 | if (left->isArray()) |
| 5049 | { |
| 5050 | ASSERT(right->isArray()); |
Jamie Madill | 6e06b1f | 2015-05-14 10:01:17 -0400 | [diff] [blame] | 5051 | if (mShaderVersion < 300) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5052 | { |
| 5053 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 5054 | return false; |
| 5055 | } |
| 5056 | |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5057 | switch (op) |
| 5058 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5059 | case EOpEqual: |
| 5060 | case EOpNotEqual: |
| 5061 | case EOpAssign: |
| 5062 | case EOpInitialize: |
| 5063 | break; |
| 5064 | default: |
| 5065 | error(loc, "Invalid operation for arrays", GetOperatorString(op)); |
| 5066 | return false; |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5067 | } |
Olli Etuaho | 376f1b5 | 2015-04-13 13:23:41 +0300 | [diff] [blame] | 5068 | // At this point, size of implicitly sized arrays should be resolved. |
Kai Ninomiya | 57ea533 | 2017-11-22 14:04:48 -0800 | [diff] [blame] | 5069 | if (*left->getType().getArraySizes() != *right->getType().getArraySizes()) |
Olli Etuaho | e79904c | 2015-03-18 16:56:42 +0200 | [diff] [blame] | 5070 | { |
| 5071 | error(loc, "array size mismatch", GetOperatorString(op)); |
| 5072 | return false; |
| 5073 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5074 | } |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5075 | |
| 5076 | // Check ops which require integer / ivec parameters |
| 5077 | bool isBitShift = false; |
| 5078 | switch (op) |
| 5079 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5080 | case EOpBitShiftLeft: |
| 5081 | case EOpBitShiftRight: |
| 5082 | case EOpBitShiftLeftAssign: |
| 5083 | case EOpBitShiftRightAssign: |
| 5084 | // Unsigned can be bit-shifted by signed and vice versa, but we need to |
| 5085 | // check that the basic type is an integer type. |
| 5086 | isBitShift = true; |
| 5087 | if (!IsInteger(left->getBasicType()) || !IsInteger(right->getBasicType())) |
| 5088 | { |
| 5089 | return false; |
| 5090 | } |
| 5091 | break; |
| 5092 | case EOpBitwiseAnd: |
| 5093 | case EOpBitwiseXor: |
| 5094 | case EOpBitwiseOr: |
| 5095 | case EOpBitwiseAndAssign: |
| 5096 | case EOpBitwiseXorAssign: |
| 5097 | case EOpBitwiseOrAssign: |
| 5098 | // It is enough to check the type of only one operand, since later it |
| 5099 | // is checked that the operand types match. |
| 5100 | if (!IsInteger(left->getBasicType())) |
| 5101 | { |
| 5102 | return false; |
| 5103 | } |
| 5104 | break; |
| 5105 | default: |
| 5106 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5107 | } |
| 5108 | |
| 5109 | // GLSL ES 1.00 and 3.00 do not support implicit type casting. |
| 5110 | // So the basic type should usually match. |
| 5111 | if (!isBitShift && left->getBasicType() != right->getBasicType()) |
| 5112 | { |
| 5113 | return false; |
| 5114 | } |
| 5115 | |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 5116 | // Check that: |
| 5117 | // 1. Type sizes match exactly on ops that require that. |
| 5118 | // 2. Restrictions for structs that contain arrays or samplers are respected. |
| 5119 | // 3. Arithmetic op type dimensionality restrictions for ops other than multiply are respected. |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5120 | switch (op) |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5121 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5122 | case EOpAssign: |
| 5123 | case EOpInitialize: |
| 5124 | case EOpEqual: |
| 5125 | case EOpNotEqual: |
| 5126 | // ESSL 1.00 sections 5.7, 5.8, 5.9 |
| 5127 | if (mShaderVersion < 300 && left->getType().isStructureContainingArrays()) |
| 5128 | { |
| 5129 | error(loc, "undefined operation for structs containing arrays", |
| 5130 | GetOperatorString(op)); |
| 5131 | return false; |
| 5132 | } |
| 5133 | // Samplers as l-values are disallowed also in ESSL 3.00, see section 4.1.7, |
| 5134 | // we interpret the spec so that this extends to structs containing samplers, |
| 5135 | // similarly to ESSL 1.00 spec. |
| 5136 | if ((mShaderVersion < 300 || op == EOpAssign || op == EOpInitialize) && |
| 5137 | left->getType().isStructureContainingSamplers()) |
| 5138 | { |
| 5139 | error(loc, "undefined operation for structs containing samplers", |
| 5140 | GetOperatorString(op)); |
| 5141 | return false; |
| 5142 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5143 | |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5144 | if ((left->getNominalSize() != right->getNominalSize()) || |
| 5145 | (left->getSecondarySize() != right->getSecondarySize())) |
| 5146 | { |
| 5147 | error(loc, "dimension mismatch", GetOperatorString(op)); |
| 5148 | return false; |
| 5149 | } |
| 5150 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5151 | case EOpLessThan: |
| 5152 | case EOpGreaterThan: |
| 5153 | case EOpLessThanEqual: |
| 5154 | case EOpGreaterThanEqual: |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5155 | if (!left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5156 | { |
Olli Etuaho | e180559 | 2017-01-02 16:41:20 +0000 | [diff] [blame] | 5157 | error(loc, "comparison operator only defined for scalars", GetOperatorString(op)); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5158 | return false; |
| 5159 | } |
Olli Etuaho | 63e1ec5 | 2016-08-18 22:05:12 +0300 | [diff] [blame] | 5160 | break; |
| 5161 | case EOpAdd: |
| 5162 | case EOpSub: |
| 5163 | case EOpDiv: |
| 5164 | case EOpIMod: |
| 5165 | case EOpBitShiftLeft: |
| 5166 | case EOpBitShiftRight: |
| 5167 | case EOpBitwiseAnd: |
| 5168 | case EOpBitwiseXor: |
| 5169 | case EOpBitwiseOr: |
| 5170 | case EOpAddAssign: |
| 5171 | case EOpSubAssign: |
| 5172 | case EOpDivAssign: |
| 5173 | case EOpIModAssign: |
| 5174 | case EOpBitShiftLeftAssign: |
| 5175 | case EOpBitShiftRightAssign: |
| 5176 | case EOpBitwiseAndAssign: |
| 5177 | case EOpBitwiseXorAssign: |
| 5178 | case EOpBitwiseOrAssign: |
| 5179 | if ((left->isMatrix() && right->isVector()) || (left->isVector() && right->isMatrix())) |
| 5180 | { |
| 5181 | return false; |
| 5182 | } |
| 5183 | |
| 5184 | // Are the sizes compatible? |
| 5185 | if (left->getNominalSize() != right->getNominalSize() || |
| 5186 | left->getSecondarySize() != right->getSecondarySize()) |
| 5187 | { |
| 5188 | // If the nominal sizes of operands do not match: |
| 5189 | // One of them must be a scalar. |
| 5190 | if (!left->isScalar() && !right->isScalar()) |
| 5191 | return false; |
| 5192 | |
| 5193 | // In the case of compound assignment other than multiply-assign, |
| 5194 | // the right side needs to be a scalar. Otherwise a vector/matrix |
| 5195 | // would be assigned to a scalar. A scalar can't be shifted by a |
| 5196 | // vector either. |
| 5197 | if (!right->isScalar() && |
| 5198 | (IsAssignment(op) || op == EOpBitShiftLeft || op == EOpBitShiftRight)) |
| 5199 | return false; |
| 5200 | } |
| 5201 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5202 | default: |
| 5203 | break; |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5204 | } |
| 5205 | |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5206 | return true; |
| 5207 | } |
| 5208 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5209 | bool TParseContext::isMultiplicationTypeCombinationValid(TOperator op, |
| 5210 | const TType &left, |
| 5211 | const TType &right) |
| 5212 | { |
| 5213 | switch (op) |
| 5214 | { |
| 5215 | case EOpMul: |
| 5216 | case EOpMulAssign: |
| 5217 | return left.getNominalSize() == right.getNominalSize() && |
| 5218 | left.getSecondarySize() == right.getSecondarySize(); |
| 5219 | case EOpVectorTimesScalar: |
| 5220 | return true; |
| 5221 | case EOpVectorTimesScalarAssign: |
| 5222 | ASSERT(!left.isMatrix() && !right.isMatrix()); |
| 5223 | return left.isVector() && !right.isVector(); |
| 5224 | case EOpVectorTimesMatrix: |
| 5225 | return left.getNominalSize() == right.getRows(); |
| 5226 | case EOpVectorTimesMatrixAssign: |
| 5227 | ASSERT(!left.isMatrix() && right.isMatrix()); |
| 5228 | return left.isVector() && left.getNominalSize() == right.getRows() && |
| 5229 | left.getNominalSize() == right.getCols(); |
| 5230 | case EOpMatrixTimesVector: |
| 5231 | return left.getCols() == right.getNominalSize(); |
| 5232 | case EOpMatrixTimesScalar: |
| 5233 | return true; |
| 5234 | case EOpMatrixTimesScalarAssign: |
| 5235 | ASSERT(left.isMatrix() && !right.isMatrix()); |
| 5236 | return !right.isVector(); |
| 5237 | case EOpMatrixTimesMatrix: |
| 5238 | return left.getCols() == right.getRows(); |
| 5239 | case EOpMatrixTimesMatrixAssign: |
| 5240 | ASSERT(left.isMatrix() && right.isMatrix()); |
| 5241 | // We need to check two things: |
| 5242 | // 1. The matrix multiplication step is valid. |
| 5243 | // 2. The result will have the same number of columns as the lvalue. |
| 5244 | return left.getCols() == right.getRows() && left.getCols() == right.getCols(); |
| 5245 | |
| 5246 | default: |
| 5247 | UNREACHABLE(); |
| 5248 | return false; |
| 5249 | } |
| 5250 | } |
| 5251 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5252 | TIntermTyped *TParseContext::addBinaryMathInternal(TOperator op, |
| 5253 | TIntermTyped *left, |
| 5254 | TIntermTyped *right, |
| 5255 | const TSourceLoc &loc) |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5256 | { |
Olli Etuaho | 47fd36a | 2015-03-19 14:22:24 +0200 | [diff] [blame] | 5257 | if (!binaryOpCommonCheck(op, left, right, loc)) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5258 | return nullptr; |
| 5259 | |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5260 | switch (op) |
| 5261 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5262 | case EOpEqual: |
| 5263 | case EOpNotEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5264 | case EOpLessThan: |
| 5265 | case EOpGreaterThan: |
| 5266 | case EOpLessThanEqual: |
| 5267 | case EOpGreaterThanEqual: |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5268 | break; |
| 5269 | case EOpLogicalOr: |
| 5270 | case EOpLogicalXor: |
| 5271 | case EOpLogicalAnd: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5272 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5273 | !right->getType().getStruct()); |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5274 | if (left->getBasicType() != EbtBool || !left->isScalar() || !right->isScalar()) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5275 | { |
| 5276 | return nullptr; |
| 5277 | } |
Olli Etuaho | e7dc9d7 | 2016-11-03 16:58:47 +0000 | [diff] [blame] | 5278 | // Basic types matching should have been already checked. |
| 5279 | ASSERT(right->getBasicType() == EbtBool); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5280 | break; |
| 5281 | case EOpAdd: |
| 5282 | case EOpSub: |
| 5283 | case EOpDiv: |
| 5284 | case EOpMul: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5285 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5286 | !right->getType().getStruct()); |
| 5287 | if (left->getBasicType() == EbtBool) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5288 | { |
| 5289 | return nullptr; |
| 5290 | } |
| 5291 | break; |
| 5292 | case EOpIMod: |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5293 | ASSERT(!left->isArray() && !right->isArray() && !left->getType().getStruct() && |
| 5294 | !right->getType().getStruct()); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5295 | // Note that this is only for the % operator, not for mod() |
Olli Etuaho | 244be01 | 2016-08-18 15:26:02 +0300 | [diff] [blame] | 5296 | if (left->getBasicType() == EbtBool || left->getBasicType() == EbtFloat) |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5297 | { |
| 5298 | return nullptr; |
| 5299 | } |
| 5300 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5301 | default: |
| 5302 | break; |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5303 | } |
| 5304 | |
Olli Etuaho | 1dded80 | 2016-08-18 18:13:13 +0300 | [diff] [blame] | 5305 | if (op == EOpMul) |
| 5306 | { |
| 5307 | op = TIntermBinary::GetMulOpBasedOnOperands(left->getType(), right->getType()); |
| 5308 | if (!isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5309 | { |
| 5310 | return nullptr; |
| 5311 | } |
| 5312 | } |
| 5313 | |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5314 | TIntermBinary *node = new TIntermBinary(op, left, right); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5315 | ASSERT(op != EOpAssign); |
| 5316 | markStaticReadIfSymbol(left); |
| 5317 | markStaticReadIfSymbol(right); |
Olli Etuaho | 3fdec91 | 2016-08-18 15:08:06 +0300 | [diff] [blame] | 5318 | node->setLine(loc); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 5319 | return expressionOrFoldedResult(node); |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5320 | } |
| 5321 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5322 | TIntermTyped *TParseContext::addBinaryMath(TOperator op, |
| 5323 | TIntermTyped *left, |
| 5324 | TIntermTyped *right, |
| 5325 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5326 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5327 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5328 | if (node == 0) |
| 5329 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5330 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 5331 | right->getCompleteString()); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5332 | return left; |
| 5333 | } |
| 5334 | return node; |
| 5335 | } |
| 5336 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5337 | TIntermTyped *TParseContext::addBinaryMathBooleanResult(TOperator op, |
| 5338 | TIntermTyped *left, |
| 5339 | TIntermTyped *right, |
| 5340 | const TSourceLoc &loc) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5341 | { |
Olli Etuaho | fc1806e | 2015-03-17 13:03:11 +0200 | [diff] [blame] | 5342 | TIntermTyped *node = addBinaryMathInternal(op, left, right, loc); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5343 | if (node == nullptr) |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5344 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5345 | binaryOpError(loc, GetOperatorString(op), left->getCompleteString(), |
| 5346 | right->getCompleteString()); |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5347 | node = CreateBoolNode(false); |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5348 | node->setLine(loc); |
Olli Etuaho | 09b2247 | 2015-02-11 11:47:26 +0200 | [diff] [blame] | 5349 | } |
| 5350 | return node; |
| 5351 | } |
| 5352 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5353 | TIntermTyped *TParseContext::addAssign(TOperator op, |
| 5354 | TIntermTyped *left, |
| 5355 | TIntermTyped *right, |
| 5356 | const TSourceLoc &loc) |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5357 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5358 | checkCanBeLValue(loc, "assign", left); |
Olli Etuaho | 7b7d2e6 | 2018-03-23 16:37:36 +0200 | [diff] [blame] | 5359 | TIntermBinary *node = nullptr; |
| 5360 | if (binaryOpCommonCheck(op, left, right, loc)) |
| 5361 | { |
| 5362 | if (op == EOpMulAssign) |
| 5363 | { |
| 5364 | op = TIntermBinary::GetMulAssignOpBasedOnOperands(left->getType(), right->getType()); |
| 5365 | if (isMultiplicationTypeCombinationValid(op, left->getType(), right->getType())) |
| 5366 | { |
| 5367 | node = new TIntermBinary(op, left, right); |
| 5368 | } |
| 5369 | } |
| 5370 | else |
| 5371 | { |
| 5372 | node = new TIntermBinary(op, left, right); |
| 5373 | } |
| 5374 | } |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5375 | if (node == nullptr) |
| 5376 | { |
| 5377 | assignError(loc, "assign", left->getCompleteString(), right->getCompleteString()); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5378 | return left; |
| 5379 | } |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5380 | if (op != EOpAssign) |
| 5381 | { |
| 5382 | markStaticReadIfSymbol(left); |
| 5383 | } |
| 5384 | markStaticReadIfSymbol(right); |
Olli Etuaho | 7b7d2e6 | 2018-03-23 16:37:36 +0200 | [diff] [blame] | 5385 | node->setLine(loc); |
Olli Etuaho | d6b1428 | 2015-03-17 14:31:35 +0200 | [diff] [blame] | 5386 | return node; |
| 5387 | } |
| 5388 | |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5389 | TIntermTyped *TParseContext::addComma(TIntermTyped *left, |
| 5390 | TIntermTyped *right, |
| 5391 | const TSourceLoc &loc) |
| 5392 | { |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5393 | // WebGL2 section 5.26, the following results in an error: |
| 5394 | // "Sequence operator applied to void, arrays, or structs containing arrays" |
Jamie Madill | d7b1ab5 | 2016-12-12 14:42:19 -0500 | [diff] [blame] | 5395 | if (mShaderSpec == SH_WEBGL2_SPEC && |
| 5396 | (left->isArray() || left->getBasicType() == EbtVoid || |
| 5397 | left->getType().isStructureContainingArrays() || right->isArray() || |
| 5398 | right->getBasicType() == EbtVoid || right->getType().isStructureContainingArrays())) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5399 | { |
| 5400 | error(loc, |
| 5401 | "sequence operator is not allowed for void, arrays, or structs containing arrays", |
| 5402 | ","); |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5403 | } |
| 5404 | |
Olli Etuaho | 0e99b7a | 2018-01-12 12:05:48 +0200 | [diff] [blame] | 5405 | TIntermBinary *commaNode = TIntermBinary::CreateComma(left, right, mShaderVersion); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5406 | markStaticReadIfSymbol(left); |
| 5407 | markStaticReadIfSymbol(right); |
| 5408 | commaNode->setLine(loc); |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 5409 | |
| 5410 | return expressionOrFoldedResult(commaNode); |
Olli Etuaho | 0b2d2dc | 2015-11-04 16:35:32 +0200 | [diff] [blame] | 5411 | } |
| 5412 | |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5413 | TIntermBranch *TParseContext::addBranch(TOperator op, const TSourceLoc &loc) |
| 5414 | { |
| 5415 | switch (op) |
| 5416 | { |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5417 | case EOpContinue: |
| 5418 | if (mLoopNestingLevel <= 0) |
| 5419 | { |
| 5420 | error(loc, "continue statement only allowed in loops", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5421 | } |
| 5422 | break; |
| 5423 | case EOpBreak: |
| 5424 | if (mLoopNestingLevel <= 0 && mSwitchNestingLevel <= 0) |
| 5425 | { |
| 5426 | error(loc, "break statement only allowed in loops and switch statements", ""); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5427 | } |
| 5428 | break; |
| 5429 | case EOpReturn: |
| 5430 | if (mCurrentFunctionType->getBasicType() != EbtVoid) |
| 5431 | { |
| 5432 | error(loc, "non-void function must return a value", "return"); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5433 | } |
| 5434 | break; |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5435 | case EOpKill: |
| 5436 | if (mShaderType != GL_FRAGMENT_SHADER) |
| 5437 | { |
| 5438 | error(loc, "discard supported in fragment shaders only", "discard"); |
| 5439 | } |
| 5440 | break; |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5441 | default: |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5442 | UNREACHABLE(); |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5443 | break; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5444 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5445 | return addBranch(op, nullptr, loc); |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5446 | } |
| 5447 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5448 | TIntermBranch *TParseContext::addBranch(TOperator op, |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5449 | TIntermTyped *expression, |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5450 | const TSourceLoc &loc) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5451 | { |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5452 | if (expression != nullptr) |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5453 | { |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5454 | markStaticReadIfSymbol(expression); |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5455 | ASSERT(op == EOpReturn); |
| 5456 | mFunctionReturnsValue = true; |
| 5457 | if (mCurrentFunctionType->getBasicType() == EbtVoid) |
| 5458 | { |
| 5459 | error(loc, "void function cannot return a value", "return"); |
| 5460 | } |
| 5461 | else if (*mCurrentFunctionType != expression->getType()) |
| 5462 | { |
| 5463 | error(loc, "function return is not matching type:", "return"); |
| 5464 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5465 | } |
Olli Etuaho | cce8965 | 2017-06-19 16:04:09 +0300 | [diff] [blame] | 5466 | TIntermBranch *node = new TIntermBranch(op, expression); |
| 5467 | node->setLine(loc); |
| 5468 | return node; |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5469 | } |
| 5470 | |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5471 | void TParseContext::appendStatement(TIntermBlock *block, TIntermNode *statement) |
| 5472 | { |
| 5473 | if (statement != nullptr) |
| 5474 | { |
| 5475 | markStaticReadIfSymbol(statement); |
| 5476 | block->appendStatement(statement); |
| 5477 | } |
| 5478 | } |
| 5479 | |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5480 | void TParseContext::checkTextureGather(TIntermAggregate *functionCall) |
| 5481 | { |
| 5482 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5483 | const TFunction *func = functionCall->getFunction(); |
| 5484 | if (BuiltInGroup::isTextureGather(func)) |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5485 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5486 | bool isTextureGatherOffset = BuiltInGroup::isTextureGatherOffset(func); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5487 | TIntermNode *componentNode = nullptr; |
| 5488 | TIntermSequence *arguments = functionCall->getSequence(); |
| 5489 | ASSERT(arguments->size() >= 2u && arguments->size() <= 4u); |
| 5490 | const TIntermTyped *sampler = arguments->front()->getAsTyped(); |
| 5491 | ASSERT(sampler != nullptr); |
| 5492 | switch (sampler->getBasicType()) |
| 5493 | { |
| 5494 | case EbtSampler2D: |
| 5495 | case EbtISampler2D: |
| 5496 | case EbtUSampler2D: |
| 5497 | case EbtSampler2DArray: |
| 5498 | case EbtISampler2DArray: |
| 5499 | case EbtUSampler2DArray: |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5500 | if ((!isTextureGatherOffset && arguments->size() == 3u) || |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5501 | (isTextureGatherOffset && arguments->size() == 4u)) |
| 5502 | { |
| 5503 | componentNode = arguments->back(); |
| 5504 | } |
| 5505 | break; |
| 5506 | case EbtSamplerCube: |
| 5507 | case EbtISamplerCube: |
| 5508 | case EbtUSamplerCube: |
| 5509 | ASSERT(!isTextureGatherOffset); |
| 5510 | if (arguments->size() == 3u) |
| 5511 | { |
| 5512 | componentNode = arguments->back(); |
| 5513 | } |
| 5514 | break; |
| 5515 | case EbtSampler2DShadow: |
| 5516 | case EbtSampler2DArrayShadow: |
| 5517 | case EbtSamplerCubeShadow: |
| 5518 | break; |
| 5519 | default: |
| 5520 | UNREACHABLE(); |
| 5521 | break; |
| 5522 | } |
| 5523 | if (componentNode) |
| 5524 | { |
| 5525 | const TIntermConstantUnion *componentConstantUnion = |
| 5526 | componentNode->getAsConstantUnion(); |
| 5527 | if (componentNode->getAsTyped()->getQualifier() != EvqConst || !componentConstantUnion) |
| 5528 | { |
| 5529 | error(functionCall->getLine(), "Texture component must be a constant expression", |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5530 | func->name()); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5531 | } |
| 5532 | else |
| 5533 | { |
| 5534 | int component = componentConstantUnion->getIConst(0); |
| 5535 | if (component < 0 || component > 3) |
| 5536 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5537 | error(functionCall->getLine(), "Component must be in the range [0;3]", |
| 5538 | func->name()); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5539 | } |
| 5540 | } |
| 5541 | } |
| 5542 | } |
| 5543 | } |
| 5544 | |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5545 | void TParseContext::checkTextureOffsetConst(TIntermAggregate *functionCall) |
| 5546 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5547 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5548 | const TFunction *func = functionCall->getFunction(); |
Jamie Madill | 50cf2be | 2018-06-15 09:46:57 -0400 | [diff] [blame] | 5549 | TIntermNode *offset = nullptr; |
| 5550 | TIntermSequence *arguments = functionCall->getSequence(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5551 | bool useTextureGatherOffsetConstraints = false; |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5552 | if (BuiltInGroup::isTextureOffsetNoBias(func)) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5553 | { |
| 5554 | offset = arguments->back(); |
| 5555 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5556 | else if (BuiltInGroup::isTextureOffsetBias(func)) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5557 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5558 | // A bias parameter follows the offset parameter. |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5559 | ASSERT(arguments->size() >= 3); |
| 5560 | offset = (*arguments)[2]; |
| 5561 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5562 | else if (BuiltInGroup::isTextureGatherOffset(func)) |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5563 | { |
| 5564 | ASSERT(arguments->size() >= 3u); |
| 5565 | const TIntermTyped *sampler = arguments->front()->getAsTyped(); |
| 5566 | ASSERT(sampler != nullptr); |
| 5567 | switch (sampler->getBasicType()) |
| 5568 | { |
| 5569 | case EbtSampler2D: |
| 5570 | case EbtISampler2D: |
| 5571 | case EbtUSampler2D: |
| 5572 | case EbtSampler2DArray: |
| 5573 | case EbtISampler2DArray: |
| 5574 | case EbtUSampler2DArray: |
| 5575 | offset = (*arguments)[2]; |
| 5576 | break; |
| 5577 | case EbtSampler2DShadow: |
| 5578 | case EbtSampler2DArrayShadow: |
| 5579 | offset = (*arguments)[3]; |
| 5580 | break; |
| 5581 | default: |
| 5582 | UNREACHABLE(); |
| 5583 | break; |
| 5584 | } |
| 5585 | useTextureGatherOffsetConstraints = true; |
| 5586 | } |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5587 | if (offset != nullptr) |
| 5588 | { |
| 5589 | TIntermConstantUnion *offsetConstantUnion = offset->getAsConstantUnion(); |
| 5590 | if (offset->getAsTyped()->getQualifier() != EvqConst || !offsetConstantUnion) |
| 5591 | { |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5592 | error(functionCall->getLine(), "Texture offset must be a constant expression", |
| 5593 | func->name()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5594 | } |
| 5595 | else |
| 5596 | { |
| 5597 | ASSERT(offsetConstantUnion->getBasicType() == EbtInt); |
| 5598 | size_t size = offsetConstantUnion->getType().getObjectSize(); |
Olli Etuaho | ea22b7a | 2018-01-04 17:09:11 +0200 | [diff] [blame] | 5599 | const TConstantUnion *values = offsetConstantUnion->getConstantValue(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5600 | int minOffsetValue = useTextureGatherOffsetConstraints ? mMinProgramTextureGatherOffset |
| 5601 | : mMinProgramTexelOffset; |
| 5602 | int maxOffsetValue = useTextureGatherOffsetConstraints ? mMaxProgramTextureGatherOffset |
| 5603 | : mMaxProgramTexelOffset; |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5604 | for (size_t i = 0u; i < size; ++i) |
| 5605 | { |
| 5606 | int offsetValue = values[i].getIConst(); |
Martin Radev | 84aa2dc | 2017-09-11 15:51:02 +0300 | [diff] [blame] | 5607 | if (offsetValue > maxOffsetValue || offsetValue < minOffsetValue) |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5608 | { |
| 5609 | std::stringstream tokenStream; |
| 5610 | tokenStream << offsetValue; |
| 5611 | std::string token = tokenStream.str(); |
| 5612 | error(offset->getLine(), "Texture offset value out of valid range", |
| 5613 | token.c_str()); |
Olli Etuaho | e1a94c6 | 2015-11-16 17:35:25 +0200 | [diff] [blame] | 5614 | } |
| 5615 | } |
| 5616 | } |
| 5617 | } |
| 5618 | } |
| 5619 | |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5620 | void TParseContext::checkAtomicMemoryBuiltinFunctions(TIntermAggregate *functionCall) |
| 5621 | { |
Olli Etuaho | 1bb8528 | 2017-12-14 13:39:53 +0200 | [diff] [blame] | 5622 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5623 | const TFunction *func = functionCall->getFunction(); |
| 5624 | if (BuiltInGroup::isAtomicMemory(func)) |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5625 | { |
| 5626 | TIntermSequence *arguments = functionCall->getSequence(); |
| 5627 | TIntermTyped *memNode = (*arguments)[0]->getAsTyped(); |
| 5628 | |
| 5629 | if (IsBufferOrSharedVariable(memNode)) |
| 5630 | { |
| 5631 | return; |
| 5632 | } |
| 5633 | |
| 5634 | while (memNode->getAsBinaryNode()) |
| 5635 | { |
| 5636 | memNode = memNode->getAsBinaryNode()->getLeft(); |
| 5637 | if (IsBufferOrSharedVariable(memNode)) |
| 5638 | { |
| 5639 | return; |
| 5640 | } |
| 5641 | } |
| 5642 | |
| 5643 | error(memNode->getLine(), |
| 5644 | "The value passed to the mem argument of an atomic memory function does not " |
| 5645 | "correspond to a buffer or shared variable.", |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5646 | func->name()); |
Jiajia Qin | a3106c5 | 2017-11-03 09:39:39 +0800 | [diff] [blame] | 5647 | } |
| 5648 | } |
| 5649 | |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5650 | // GLSL ES 3.10 Revision 4, 4.9 Memory Access Qualifiers |
| 5651 | void TParseContext::checkImageMemoryAccessForBuiltinFunctions(TIntermAggregate *functionCall) |
| 5652 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5653 | ASSERT(functionCall->getOp() == EOpCallBuiltInFunction); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5654 | |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5655 | const TFunction *func = functionCall->getFunction(); |
| 5656 | |
| 5657 | if (BuiltInGroup::isImage(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5658 | { |
| 5659 | TIntermSequence *arguments = functionCall->getSequence(); |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5660 | TIntermTyped *imageNode = (*arguments)[0]->getAsTyped(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5661 | |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5662 | const TMemoryQualifier &memoryQualifier = imageNode->getMemoryQualifier(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5663 | |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5664 | if (BuiltInGroup::isImageStore(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5665 | { |
| 5666 | if (memoryQualifier.readonly) |
| 5667 | { |
| 5668 | error(imageNode->getLine(), |
| 5669 | "'imageStore' cannot be used with images qualified as 'readonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5670 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5671 | } |
| 5672 | } |
Olli Etuaho | 2bfe9f6 | 2018-03-02 16:53:29 +0200 | [diff] [blame] | 5673 | else if (BuiltInGroup::isImageLoad(func)) |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5674 | { |
| 5675 | if (memoryQualifier.writeonly) |
| 5676 | { |
| 5677 | error(imageNode->getLine(), |
| 5678 | "'imageLoad' cannot be used with images qualified as 'writeonly'", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5679 | GetImageArgumentToken(imageNode)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5680 | } |
| 5681 | } |
| 5682 | } |
| 5683 | } |
| 5684 | |
| 5685 | // GLSL ES 3.10 Revision 4, 13.51 Matching of Memory Qualifiers in Function Parameters |
| 5686 | void TParseContext::checkImageMemoryAccessForUserDefinedFunctions( |
| 5687 | const TFunction *functionDefinition, |
| 5688 | const TIntermAggregate *functionCall) |
| 5689 | { |
Olli Etuaho | 1ecd14b | 2017-01-26 13:54:15 -0800 | [diff] [blame] | 5690 | ASSERT(functionCall->getOp() == EOpCallFunctionInAST); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5691 | |
| 5692 | const TIntermSequence &arguments = *functionCall->getSequence(); |
| 5693 | |
| 5694 | ASSERT(functionDefinition->getParamCount() == arguments.size()); |
| 5695 | |
| 5696 | for (size_t i = 0; i < arguments.size(); ++i) |
| 5697 | { |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5698 | TIntermTyped *typedArgument = arguments[i]->getAsTyped(); |
| 5699 | const TType &functionArgumentType = typedArgument->getType(); |
Olli Etuaho | d4bd963 | 2018-03-08 16:32:44 +0200 | [diff] [blame] | 5700 | const TType &functionParameterType = functionDefinition->getParam(i)->getType(); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5701 | ASSERT(functionArgumentType.getBasicType() == functionParameterType.getBasicType()); |
| 5702 | |
| 5703 | if (IsImage(functionArgumentType.getBasicType())) |
| 5704 | { |
| 5705 | const TMemoryQualifier &functionArgumentMemoryQualifier = |
| 5706 | functionArgumentType.getMemoryQualifier(); |
| 5707 | const TMemoryQualifier &functionParameterMemoryQualifier = |
| 5708 | functionParameterType.getMemoryQualifier(); |
| 5709 | if (functionArgumentMemoryQualifier.readonly && |
| 5710 | !functionParameterMemoryQualifier.readonly) |
| 5711 | { |
| 5712 | error(functionCall->getLine(), |
| 5713 | "Function call discards the 'readonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5714 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5715 | } |
| 5716 | |
| 5717 | if (functionArgumentMemoryQualifier.writeonly && |
| 5718 | !functionParameterMemoryQualifier.writeonly) |
| 5719 | { |
| 5720 | error(functionCall->getLine(), |
| 5721 | "Function call discards the 'writeonly' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5722 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5723 | } |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5724 | |
| 5725 | if (functionArgumentMemoryQualifier.coherent && |
| 5726 | !functionParameterMemoryQualifier.coherent) |
| 5727 | { |
| 5728 | error(functionCall->getLine(), |
| 5729 | "Function call discards the 'coherent' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5730 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5731 | } |
| 5732 | |
| 5733 | if (functionArgumentMemoryQualifier.volatileQualifier && |
| 5734 | !functionParameterMemoryQualifier.volatileQualifier) |
| 5735 | { |
| 5736 | error(functionCall->getLine(), |
| 5737 | "Function call discards the 'volatile' qualifier from image", |
Olli Etuaho | 485eefd | 2017-02-14 17:40:06 +0000 | [diff] [blame] | 5738 | GetImageArgumentToken(typedArgument)); |
Martin Radev | 049edfa | 2016-11-11 14:35:37 +0200 | [diff] [blame] | 5739 | } |
Martin Radev | 2cc85b3 | 2016-08-05 16:22:53 +0300 | [diff] [blame] | 5740 | } |
| 5741 | } |
| 5742 | } |
| 5743 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5744 | TIntermTyped *TParseContext::addFunctionCallOrMethod(TFunctionLookup *fnCall, const TSourceLoc &loc) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5745 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5746 | if (fnCall->thisNode() != nullptr) |
| 5747 | { |
| 5748 | return addMethod(fnCall, loc); |
| 5749 | } |
| 5750 | if (fnCall->isConstructor()) |
| 5751 | { |
| 5752 | return addConstructor(fnCall, loc); |
| 5753 | } |
| 5754 | return addNonConstructorFunctionCall(fnCall, loc); |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5755 | } |
| 5756 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5757 | TIntermTyped *TParseContext::addMethod(TFunctionLookup *fnCall, const TSourceLoc &loc) |
Olli Etuaho | 72d1020 | 2017-01-19 15:58:30 +0000 | [diff] [blame] | 5758 | { |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5759 | TIntermTyped *thisNode = fnCall->thisNode(); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5760 | // It's possible for the name pointer in the TFunction to be null in case it gets parsed as |
| 5761 | // a constructor. But such a TFunction can't reach here, since the lexer goes into FIELDS |
| 5762 | // mode after a dot, which makes type identifiers to be parsed as FIELD_SELECTION instead. |
Olli Etuaho | ae4dbf3 | 2017-12-08 20:49:00 +0100 | [diff] [blame] | 5763 | // So accessing fnCall->name() below is safe. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5764 | if (fnCall->name() != "length") |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5765 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5766 | error(loc, "invalid method", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5767 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5768 | else if (!fnCall->arguments().empty()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5769 | { |
| 5770 | error(loc, "method takes no parameters", "length"); |
| 5771 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5772 | else if (!thisNode->isArray()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5773 | { |
| 5774 | error(loc, "length can only be called on arrays", "length"); |
| 5775 | } |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5776 | else if (thisNode->getQualifier() == EvqPerVertexIn && |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 5777 | mGeometryShaderInputPrimitiveType == EptUndefined) |
| 5778 | { |
Jiawei Shao | bd924af | 2017-11-16 15:28:04 +0800 | [diff] [blame] | 5779 | ASSERT(mShaderType == GL_GEOMETRY_SHADER_EXT); |
Jiawei Shao | d8105a0 | 2017-08-08 09:54:36 +0800 | [diff] [blame] | 5780 | error(loc, "missing input primitive declaration before calling length on gl_in", "length"); |
| 5781 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5782 | else |
| 5783 | { |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 5784 | TIntermUnary *node = new TIntermUnary(EOpArrayLength, thisNode, nullptr); |
Olli Etuaho | bb2bbfb | 2017-08-24 15:43:33 +0300 | [diff] [blame] | 5785 | node->setLine(loc); |
| 5786 | return node->fold(mDiagnostics); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5787 | } |
Olli Etuaho | bb2bbfb | 2017-08-24 15:43:33 +0300 | [diff] [blame] | 5788 | return CreateZeroNode(TType(EbtInt, EbpUndefined, EvqConst)); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5789 | } |
| 5790 | |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5791 | TIntermTyped *TParseContext::addNonConstructorFunctionCall(TFunctionLookup *fnCall, |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5792 | const TSourceLoc &loc) |
| 5793 | { |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 5794 | // First check whether the function has been hidden by a variable name or struct typename by |
| 5795 | // using the symbol looked up in the lexical phase. If the function is not hidden, look for one |
| 5796 | // with a matching argument list. |
| 5797 | if (fnCall->symbol() != nullptr && !fnCall->symbol()->isFunction()) |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5798 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5799 | error(loc, "function name expected", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5800 | } |
| 5801 | else |
| 5802 | { |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5803 | // There are no inner functions, so it's enough to look for user-defined functions in the |
| 5804 | // global scope. |
Olli Etuaho | 697bf65 | 2018-02-16 11:50:54 +0200 | [diff] [blame] | 5805 | const TSymbol *symbol = symbolTable.findGlobal(fnCall->getMangledName()); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5806 | if (symbol != nullptr) |
| 5807 | { |
| 5808 | // A user-defined function - could be an overloaded built-in as well. |
| 5809 | ASSERT(symbol->symbolType() == SymbolType::UserDefined); |
| 5810 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
| 5811 | TIntermAggregate *callNode = |
| 5812 | TIntermAggregate::CreateFunctionCall(*fnCandidate, &fnCall->arguments()); |
| 5813 | callNode->setLine(loc); |
| 5814 | checkImageMemoryAccessForUserDefinedFunctions(fnCandidate, callNode); |
| 5815 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5816 | return callNode; |
| 5817 | } |
| 5818 | |
| 5819 | symbol = symbolTable.findBuiltIn(fnCall->getMangledName(), mShaderVersion); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5820 | if (symbol == nullptr) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5821 | { |
Olli Etuaho | fbb1c79 | 2018-01-19 16:26:59 +0200 | [diff] [blame] | 5822 | error(loc, "no matching overloaded function found", fnCall->name()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5823 | } |
| 5824 | else |
| 5825 | { |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5826 | // A built-in function. |
| 5827 | ASSERT(symbol->symbolType() == SymbolType::BuiltIn); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5828 | const TFunction *fnCandidate = static_cast<const TFunction *>(symbol); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5829 | |
Olli Etuaho | 37b697e | 2018-01-29 12:19:27 +0200 | [diff] [blame] | 5830 | if (fnCandidate->extension() != TExtension::UNDEFINED) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5831 | { |
Olli Etuaho | 54a29ff | 2017-11-28 17:35:20 +0200 | [diff] [blame] | 5832 | checkCanUseExtension(loc, fnCandidate->extension()); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5833 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5834 | TOperator op = fnCandidate->getBuiltInOp(); |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5835 | if (op != EOpCallBuiltInFunction) |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5836 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5837 | // A function call mapped to a built-in operation. |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5838 | if (fnCandidate->getParamCount() == 1) |
| 5839 | { |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5840 | // Treat it like a built-in unary operator. |
Olli Etuaho | 95ed194 | 2018-02-01 14:01:19 +0200 | [diff] [blame] | 5841 | TIntermNode *unaryParamNode = fnCall->arguments().front(); |
Olli Etuaho | 5fec7ab | 2018-04-04 11:58:33 +0300 | [diff] [blame] | 5842 | TIntermTyped *callNode = |
| 5843 | createUnaryMath(op, unaryParamNode->getAsTyped(), loc, fnCandidate); |
Olli Etuaho | 2be2d5a | 2017-01-26 16:34:30 -0800 | [diff] [blame] | 5844 | ASSERT(callNode != nullptr); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5845 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5846 | } |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5847 | TIntermAggregate *callNode = |
| 5848 | TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, &fnCall->arguments()); |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5849 | callNode->setLine(loc); |
| 5850 | |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5851 | // Some built-in functions have out parameters too. |
| 5852 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5853 | |
| 5854 | // See if we can constant fold a built-in. Note that this may be possible |
| 5855 | // even if it is not const-qualified. |
| 5856 | return callNode->fold(mDiagnostics); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5857 | } |
Olli Etuaho | e80825e | 2018-02-16 10:24:53 +0200 | [diff] [blame] | 5858 | |
| 5859 | // This is a built-in function with no op associated with it. |
| 5860 | TIntermAggregate *callNode = |
| 5861 | TIntermAggregate::CreateBuiltInFunctionCall(*fnCandidate, &fnCall->arguments()); |
| 5862 | callNode->setLine(loc); |
| 5863 | checkTextureOffsetConst(callNode); |
| 5864 | checkTextureGather(callNode); |
| 5865 | checkImageMemoryAccessForBuiltinFunctions(callNode); |
| 5866 | checkAtomicMemoryBuiltinFunctions(callNode); |
| 5867 | functionCallRValueLValueErrorCheck(fnCandidate, callNode); |
| 5868 | return callNode; |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5869 | } |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5870 | } |
Olli Etuaho | af6fc1b | 2017-01-26 17:45:35 -0800 | [diff] [blame] | 5871 | |
| 5872 | // Error message was already written. Put on a dummy node for error recovery. |
Olli Etuaho | 3ec7568 | 2017-07-05 17:02:55 +0300 | [diff] [blame] | 5873 | return CreateZeroNode(TType(EbtFloat, EbpMedium, EvqConst)); |
Olli Etuaho | c4ba3be | 2015-03-02 14:42:24 +0200 | [diff] [blame] | 5874 | } |
| 5875 | |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5876 | TIntermTyped *TParseContext::addTernarySelection(TIntermTyped *cond, |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5877 | TIntermTyped *trueExpression, |
| 5878 | TIntermTyped *falseExpression, |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5879 | const TSourceLoc &loc) |
| 5880 | { |
Olli Etuaho | 56229f1 | 2017-07-10 14:16:33 +0300 | [diff] [blame] | 5881 | if (!checkIsScalarBool(loc, cond)) |
| 5882 | { |
| 5883 | return falseExpression; |
| 5884 | } |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5885 | |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5886 | if (trueExpression->getType() != falseExpression->getType()) |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5887 | { |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5888 | std::stringstream reasonStream; |
| 5889 | reasonStream << "mismatching ternary operator operand types '" |
| 5890 | << trueExpression->getCompleteString() << " and '" |
| 5891 | << falseExpression->getCompleteString() << "'"; |
| 5892 | std::string reason = reasonStream.str(); |
| 5893 | error(loc, reason.c_str(), "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5894 | return falseExpression; |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5895 | } |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5896 | if (IsOpaqueType(trueExpression->getBasicType())) |
| 5897 | { |
| 5898 | // ESSL 1.00 section 4.1.7 |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5899 | // ESSL 3.00.6 section 4.1.7 |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5900 | // Opaque/sampler types are not allowed in most types of expressions, including ternary. |
| 5901 | // Note that structs containing opaque types don't need to be checked as structs are |
| 5902 | // forbidden below. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5903 | error(loc, "ternary operator is not allowed for opaque types", "?:"); |
Olli Etuaho | de318b2 | 2016-10-25 16:18:25 +0100 | [diff] [blame] | 5904 | return falseExpression; |
| 5905 | } |
| 5906 | |
Jiajia Qin | bc58515 | 2017-06-23 15:42:17 +0800 | [diff] [blame] | 5907 | if (cond->getMemoryQualifier().writeonly || trueExpression->getMemoryQualifier().writeonly || |
| 5908 | falseExpression->getMemoryQualifier().writeonly) |
| 5909 | { |
| 5910 | error(loc, "ternary operator is not allowed for variables with writeonly", "?:"); |
| 5911 | return falseExpression; |
| 5912 | } |
| 5913 | |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5914 | // ESSL 1.00.17 sections 5.2 and 5.7: |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5915 | // Ternary operator is not among the operators allowed for structures/arrays. |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5916 | // ESSL 3.00.6 section 5.7: |
| 5917 | // Ternary operator support is optional for arrays. No certainty that it works across all |
| 5918 | // devices with struct either, so we err on the side of caution here. TODO (oetuaho@nvidia.com): |
| 5919 | // Would be nice to make the spec and implementation agree completely here. |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5920 | if (trueExpression->isArray() || trueExpression->getBasicType() == EbtStruct) |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5921 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5922 | error(loc, "ternary operator is not allowed for structures or arrays", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5923 | return falseExpression; |
Olli Etuaho | a2d5303 | 2015-04-15 14:14:44 +0300 | [diff] [blame] | 5924 | } |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5925 | if (trueExpression->getBasicType() == EbtInterfaceBlock) |
| 5926 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5927 | error(loc, "ternary operator is not allowed for interface blocks", "?:"); |
Olli Etuaho | 9405005 | 2017-05-08 14:17:44 +0300 | [diff] [blame] | 5928 | return falseExpression; |
| 5929 | } |
| 5930 | |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5931 | // WebGL2 section 5.26, the following results in an error: |
| 5932 | // "Ternary operator applied to void, arrays, or structs containing arrays" |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5933 | if (mShaderSpec == SH_WEBGL2_SPEC && trueExpression->getBasicType() == EbtVoid) |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5934 | { |
Olli Etuaho | e01c02b | 2017-05-08 14:41:49 +0300 | [diff] [blame] | 5935 | error(loc, "ternary operator is not allowed for void", "?:"); |
Olli Etuaho | d0bad2c | 2016-09-09 18:01:16 +0300 | [diff] [blame] | 5936 | return falseExpression; |
Corentin Wallez | 0d95925 | 2016-07-12 17:26:32 -0400 | [diff] [blame] | 5937 | } |
| 5938 | |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5939 | TIntermTernary *node = new TIntermTernary(cond, trueExpression, falseExpression); |
Olli Etuaho | 94bbed1 | 2018-03-20 14:44:53 +0200 | [diff] [blame] | 5940 | markStaticReadIfSymbol(cond); |
| 5941 | markStaticReadIfSymbol(trueExpression); |
| 5942 | markStaticReadIfSymbol(falseExpression); |
Olli Etuaho | eb7f90f | 2017-07-07 17:25:23 +0300 | [diff] [blame] | 5943 | node->setLine(loc); |
Olli Etuaho | 765924f | 2018-01-04 12:48:36 +0200 | [diff] [blame] | 5944 | return expressionOrFoldedResult(node); |
Olli Etuaho | 5290174 | 2015-04-15 13:42:45 +0300 | [diff] [blame] | 5945 | } |
Olli Etuaho | 4930086 | 2015-02-20 14:54:49 +0200 | [diff] [blame] | 5946 | |
shannonwoods@chromium.org | a910088 | 2013-05-30 00:11:39 +0000 | [diff] [blame] | 5947 | // |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5948 | // Parse an array of strings using yyparse. |
| 5949 | // |
| 5950 | // Returns 0 for success. |
| 5951 | // |
Jamie Madill | b98c3a8 | 2015-07-23 14:26:04 -0400 | [diff] [blame] | 5952 | int PaParseStrings(size_t count, |
| 5953 | const char *const string[], |
| 5954 | const int length[], |
Arun Patole | 7e7e68d | 2015-05-22 12:02:25 +0530 | [diff] [blame] | 5955 | TParseContext *context) |
| 5956 | { |
Yunchao He | 4f28544 | 2017-04-21 12:15:49 +0800 | [diff] [blame] | 5957 | if ((count == 0) || (string == nullptr)) |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5958 | return 1; |
| 5959 | |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5960 | if (glslang_initialize(context)) |
| 5961 | return 1; |
| 5962 | |
alokp@chromium.org | 408c45e | 2012-04-05 15:54:43 +0000 | [diff] [blame] | 5963 | int error = glslang_scan(count, string, length, context); |
| 5964 | if (!error) |
| 5965 | error = glslang_parse(context); |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5966 | |
alokp@chromium.org | 73bc298 | 2012-06-19 18:48:05 +0000 | [diff] [blame] | 5967 | glslang_finalize(context); |
alokp@chromium.org | 8b851c6 | 2012-06-15 16:25:11 +0000 | [diff] [blame] | 5968 | |
alokp@chromium.org | 6b49571 | 2012-06-29 00:06:58 +0000 | [diff] [blame] | 5969 | return (error == 0) && (context->numErrors() == 0) ? 0 : 1; |
alokp@chromium.org | 044a5cf | 2010-11-12 15:42:16 +0000 | [diff] [blame] | 5970 | } |
Jamie Madill | 45bcc78 | 2016-11-07 13:58:48 -0500 | [diff] [blame] | 5971 | |
| 5972 | } // namespace sh |