COMPRESS-290 Fixed error message with large groupid
This is a bit of a simple solution to the issue, since there are obviously lots of other options that
could have similar updates. The reality is that most recent macs that are initialized to run in corporate
networks tend to get large GID's for the users. So I just fixed the one we actually have complaints about
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1651417 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
index ecd364d..1b134af 100644
--- a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveOutputStream.java
@@ -606,7 +606,7 @@
private void failForBigNumbers(TarArchiveEntry entry) {
failForBigNumber("entry size", entry.getSize(), TarConstants.MAXSIZE);
- failForBigNumber("group id", entry.getGroupId(), TarConstants.MAXID);
+ failForBigNumberWithPosixMessage("group id", entry.getGroupId(), TarConstants.MAXID);
failForBigNumber("last modification time",
entry.getModTime().getTime() / 1000,
TarConstants.MAXSIZE);
@@ -619,10 +619,18 @@
}
private void failForBigNumber(String field, long value, long maxValue) {
+ failForBigNumber(field, value, maxValue, "");
+ }
+
+ private void failForBigNumberWithPosixMessage(String field, long value, long maxValue) {
+ failForBigNumber(field, value, maxValue, " Use STAR or POSIX extensions to overcome this limit");
+ }
+
+ private void failForBigNumber(String field, long value, long maxValue, String additionalMsg) {
if (value < 0 || value > maxValue) {
throw new RuntimeException(field + " '" + value
- + "' is too big ( > "
- + maxValue + " )");
+ + "' is too big ( > "
+ + maxValue + " )." + additionalMsg);
}
}