address most issues detected by findbugs
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1154667 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
new file mode 100644
index 0000000..5d67666
--- /dev/null
+++ b/findbugs-exclude-filter.xml
@@ -0,0 +1,65 @@
+<?xml version="1.0"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--
+ This file contains some false positive bugs detected by findbugs. Their
+ false positive nature has been analyzed individually and they have been
+ put here to instruct findbugs it must ignore them.
+-->
+<FindBugsFilter>
+
+ <!-- Reason: References to System.out/err == -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.Lister" />
+ <Or>
+ <Method name="main" />
+ <Method name="usage" />
+ </Or>
+ <Bug pattern="NP_ALWAYS_NULL" />
+ </Match>
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.zip.ZipFile" />
+ <Method name="finalize" />
+ <Bug pattern="NP_ALWAYS_NULL" />
+ </Match>
+
+ <!-- Reason: fallthrough is intended -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.zip.ExtraFieldUtils" />
+ <Method name="parse" />
+ <Bug pattern="SF_SWITCH_FALLTHROUGH" />
+ </Match>
+
+ <!-- Reason: fields unused as documented -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.jar.JarArchiveEntry" />
+ <Or>
+ <Field name="certificates"/>
+ <Field name="manifestAttributes"/>
+ </Or>
+ <Bug pattern="UWF_NULL_FIELD" />
+ </Match>
+
+ <!-- Reason: exception in close swallowed in order to re-throw original -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.zip.ZipFile" />
+ <Method name="<init>" />
+ <Bug pattern="DE_MIGHT_IGNORE" />
+ </Match>
+
+</FindBugsFilter>