| commit | 646e03cbab5d0af719efbb22dcf0ee037aa531cc | [log] [tgz] |
|---|---|---|
| author | Kristian Rosenvold <krosenvold@apache.org> | Sat Jan 10 19:00:31 2015 +0000 |
| committer | Kristian Rosenvold <krosenvold@apache.org> | Sat Jan 10 19:00:31 2015 +0000 |
| tree | 2f3846d46ffe6dfb9f40927660bff21ed87fb3d5 | |
| parent | 09aecce588d736955b803c9df908013960699836 [diff] |
Fixed one findbugs warning, ignored another git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1650794 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml index 7c207b2..f70be02 100644 --- a/findbugs-exclude-filter.xml +++ b/findbugs-exclude-filter.xml
@@ -157,4 +157,12 @@ <Method name="equals" /> <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS" /> </Match> + + <!-- Reason: failure to delete a file that may not exist. And we really don't care that much either --> + <Match> + <Class name="org.apache.commons.compress.archivers.zip.FileBasedScatterGatherBackingStore" /> + <Method name="close" /> + <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE" /> + </Match> + </FindBugsFilter>
diff --git a/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java b/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java index d1a9062..4eba69b 100644 --- a/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java +++ b/src/main/java/org/apache/commons/compress/archivers/zip/StreamCompressor.java
@@ -50,7 +50,7 @@ private long sourcePayloadLength = 0; private long totalWrittenToOutputStream = 0; - private final int bufferSize = 4096; + private static final int bufferSize = 4096; private final byte[] outputBuffer = new byte[bufferSize]; private final byte[] readerBuf = new byte[bufferSize];