Add final modifier to private fields.
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1436881 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/compress/archivers/dump/Dirent.java b/src/main/java/org/apache/commons/compress/archivers/dump/Dirent.java
index 0217e76..34e0ef7 100644
--- a/src/main/java/org/apache/commons/compress/archivers/dump/Dirent.java
+++ b/src/main/java/org/apache/commons/compress/archivers/dump/Dirent.java
@@ -22,10 +22,10 @@
* Directory entry.
*/
class Dirent {
- private int ino;
- private int parentIno;
- private int type;
- private String name;
+ private final int ino;
+ private final int parentIno;
+ private final int type;
+ private final String name;
/**
* Constructor
diff --git a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveEntry.java b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveEntry.java
index eabe73c..31e19af 100644
--- a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveEntry.java
+++ b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveEntry.java
@@ -190,10 +190,10 @@
/**
* Currently unused
*/
- private DumpArchiveSummary summary = null;
+ private final DumpArchiveSummary summary = null;
// this information is available from standard index.
- private TapeSegmentHeader header = new TapeSegmentHeader();
+ private final TapeSegmentHeader header = new TapeSegmentHeader();
private String simpleName;
private String originalName;
@@ -523,7 +523,7 @@
private int ino;
private int count;
private int holes;
- private byte[] cdata = new byte[512]; // map of any 'holes'
+ private final byte[] cdata = new byte[512]; // map of any 'holes'
public DumpArchiveConstants.SEGMENT_TYPE getType() {
return type;
diff --git a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
index 3f31da6..e954a1b 100644
--- a/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/dump/DumpArchiveInputStream.java
@@ -49,17 +49,17 @@
private long entrySize;
private long entryOffset;
private int readIdx;
- private byte[] readBuf = new byte[DumpArchiveConstants.TP_SIZE];
+ private final byte[] readBuf = new byte[DumpArchiveConstants.TP_SIZE];
private byte[] blockBuffer;
private int recordOffset;
private long filepos;
protected TapeInputStream raw;
// map of ino -> dirent entry. We can use this to reconstruct full paths.
- private Map<Integer, Dirent> names = new HashMap<Integer, Dirent>();
+ private final Map<Integer, Dirent> names = new HashMap<Integer, Dirent>();
// map of ino -> (directory) entry when we're missing one or more elements in the path.
- private Map<Integer, DumpArchiveEntry> pending = new HashMap<Integer, DumpArchiveEntry>();
+ private final Map<Integer, DumpArchiveEntry> pending = new HashMap<Integer, DumpArchiveEntry>();
// queue of (directory) entries where we now have the full path.
private Queue<DumpArchiveEntry> queue;
diff --git a/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java b/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
index 870d1b0..997f19a 100644
--- a/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
+++ b/src/main/java/org/apache/commons/compress/archivers/dump/TapeInputStream.java
@@ -37,7 +37,7 @@
private byte[] blockBuffer = new byte[DumpArchiveConstants.TP_SIZE];
private int currBlkIdx = -1;
private int blockSize = DumpArchiveConstants.TP_SIZE;
- private int recordSize = DumpArchiveConstants.TP_SIZE;
+ private final int recordSize = DumpArchiveConstants.TP_SIZE;
private int readOffset = DumpArchiveConstants.TP_SIZE;
private boolean isCompressed = false;
private long bytesRead = 0;
diff --git a/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java b/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
index 007c5f7..c58c9b2 100644
--- a/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
+++ b/src/main/java/org/apache/commons/compress/archivers/jar/JarArchiveEntry.java
@@ -32,8 +32,8 @@
*/
public class JarArchiveEntry extends ZipArchiveEntry {
- private Attributes manifestAttributes = null;
- private Certificate[] certificates = null;
+ private final Attributes manifestAttributes = null;
+ private final Certificate[] certificates = null;
public JarArchiveEntry(ZipEntry entry) throws ZipException {
super(entry);
diff --git a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveSparseEntry.java b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveSparseEntry.java
index f4eabc0..79b36ac 100644
--- a/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveSparseEntry.java
+++ b/src/main/java/org/apache/commons/compress/archivers/tar/TarArchiveSparseEntry.java
@@ -42,7 +42,7 @@
public class TarArchiveSparseEntry implements TarConstants {
/** If an extension sparse header follows. */
- private boolean isExtended;
+ private final boolean isExtended;
/**
* Construct an entry from an archive's header bytes. File is set
diff --git a/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java b/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
index 734cf6b..7408b5b 100644
--- a/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
+++ b/src/main/java/org/apache/commons/compress/compressors/gzip/GzipCompressorInputStream.java
@@ -69,7 +69,7 @@
private Inflater inf = new Inflater(true);
// CRC32 from uncompressed data
- private CRC32 crc = new CRC32();
+ private final CRC32 crc = new CRC32();
private int memberSize;