tame findbugs
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/compress/trunk@1554676 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/findbugs-exclude-filter.xml b/findbugs-exclude-filter.xml
index ec892ca..731a65d 100644
--- a/findbugs-exclude-filter.xml
+++ b/findbugs-exclude-filter.xml
@@ -64,6 +64,13 @@
<Field name="summary"/>
<Bug pattern="UWF_NULL_FIELD" />
</Match>
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.sevenz.Folder" />
+ <Or>
+ <Field name="totalInputStreams"/>
+ </Or>
+ <Bug pattern="URF_UNREAD_FIELD" />
+ </Match>
<!-- Reason: exception in close swallowed in order to re-throw original in caller -->
<Match>
@@ -106,4 +113,48 @@
<Bug pattern="OBL_UNSATISFIED_OBLIGATION" />
</Match>
+ <!-- Reason: the contract is to use default encoding (unless told otherwise) -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.arj.ArjArchiveInputStream" />
+ <Method name="readString" />
+ <Bug pattern="DM_DEFAULT_ENCODING" />
+ </Match>
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.zip.AsiExtraField" />
+ <Or>
+ <Method name="getLocalFileDataData" />
+ <Method name="getLocalFileDataLength" />
+ <Method name="parseFromLocalFileData" />
+ </Or>
+ <Bug pattern="DM_DEFAULT_ENCODING" />
+ </Match>
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.zip.FallbackZipEncoding" />
+ <Or>
+ <Method name="decode" />
+ <Method name="encode" />
+ </Or>
+ <Bug pattern="DM_DEFAULT_ENCODING" />
+ </Match>
+
+ <!-- Reason: default encoding is good enough for exception message -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.tar.TarUtils" />
+ <Method name="exceptionMessage" />
+ <Bug pattern="DM_DEFAULT_ENCODING" />
+ </Match>
+
+ <!-- Reason: unrolled loop, all possible cases are covered -->
+ <Match>
+ <Class name="org.apache.commons.compress.compressors.snappy.PureJavaCrc32C" />
+ <Method name="update" />
+ <Bug pattern="SF_SWITCH_NO_DEFAULT" />
+ </Match>
+
+ <!-- Reason: class only adds unused always-null fields and superclass' equals is sufficient -->
+ <Match>
+ <Class name="org.apache.commons.compress.archivers.jar.JarArchiveEntry" />
+ <Method name="equals" />
+ <Bug pattern="EQ_DOESNT_OVERRIDE_EQUALS" />
+ </Match>
</FindBugsFilter>