Stop setting WANT_ROUNDING=0.
Remove this based on the explanation on
https://github.com/ARM-software/optimized-routines/issues/23.
Also document WANT_ERRNO=0 (which does make sense for us) based on
https://github.com/ARM-software/optimized-routines/issues/16#issuecomment-572009659.
Test: manually ran all the tests with a clang from the future
Change-Id: I37393633416189854f349606c15d67b51cf0f813
diff --git a/Android.bp b/Android.bp
index 33b21ec..04831a4 100755
--- a/Android.bp
+++ b/Android.bp
@@ -5,15 +5,23 @@
"-Werror",
"-Wno-unused-parameter",
"-O2",
+ "-ffp-contract=fast",
+ "-fno-math-errno",
+
+ // bionic configuration.
+
// We're actually implementing bionic here, so we don't want <math.h>
// to try to be helpful by renaming long double routines.
"-D__BIONIC_LP32_USE_LONG_DOUBLE",
- "-DWANT_ROUNDING=0",
- "-DWANT_ERRNO=0",
- "-DWANT_VMATH=0",
"-DFLT_EVAL_METHOD=0",
- "-ffp-contract=fast",
- "-fno-math-errno",
+
+ // arm-optimized-routines configuration.
+
+ // BSD libm doesn't set errno, and bionic was based on the BSDs.
+ // https://github.com/ARM-software/optimized-routines/issues/16#issuecomment-572009659
+ "-DWANT_ERRNO=0",
+ // TODO: we will want the SVE code in future, but it's not ready yet.
+ "-DWANT_VMATH=0",
],
local_include_dirs: ["math/include"],
}