commit 1777f5d5524f464230af02a5f82e78984698b251
author J. Richard Barnette <jrbarnette@chromium.org> Wed Sep 03 15:18:19 2014 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Fri Sep 05 01:17:47 2014 +0000
tree 30c3b353d8a49892284602429fd886f613d59710
parent b28a0a7ae21dda4948c04f41f09042b10b166f61

[autotest] Log servo version at initialization

For debug purposes:  When initializing servo, log the servo
(hardware) version returned by servod.

BUG=None
TEST=run a servo test using test_that with this change present

Change-Id: I1abe8d79ff9f6915a33075511055f6aeee51ab79
Reviewed-on: https://chromium-review.googlesource.com/216283
Commit-Queue: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>

server/cros/servo/servo.py

diff --git a/server/cros/servo/servo.py b/server/cros/servo/servo.py
index 2e55df5..7ec89b4 100644
--- a/server/cros/servo/servo.py
+++ b/server/cros/servo/servo.py
@@ -211,6 +211,8 @@
         self.switch_usbkey('off')
         if cold_reset:
             self._power_state.reset()
+        logging.debug('Servo initialized, version is %s',
+                      self._server.get_version())
 
 
     def is_localhost(self):
@@ -379,13 +381,6 @@
         time.sleep(Servo.BOOT_DELAY)
 
 
-    def get_version(self):
-        """Get the version of servod board.
-
-        """
-        return self._server.get_version()
-
-
     def get_board(self):
         """Get the board connected to servod.
 
@@ -627,7 +622,7 @@
         if self._programmer:
             return
         # Initialize firmware programmer
-        servo_version = self.get_version()
+        servo_version = self._server.get_version()
         if servo_version == 'servo_v2':
             self._programmer = firmware_programmer.ProgrammerV2(self)
         else: