Some small fixes found while doing an e2e test with devserver changes.
1) Alex's change to not exit 0 totally now clobbers you shadow config
even if you say no.
2) Release config should be updated for R27.
3) Site RPC interface -- better logging.
4) Site_Suite didn't actually allow an int override -- kept on casting it
to a string.
BUG=None
TEST=Ran through devserver test using cli/atest suite create and setup
autotest with shadow config.
Change-Id: Ie7f61fe95c3a642455de33416367085e159c3947
Reviewed-on: https://gerrit.chromium.org/gerrit/43429
Commit-Queue: Chris Sosa <sosa@chromium.org>
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Chris Sosa <sosa@chromium.org>
diff --git a/site_utils/setup_dev_autotest.sh b/site_utils/setup_dev_autotest.sh
index 2f6fb2b..f3b39d9 100755
--- a/site_utils/setup_dev_autotest.sh
+++ b/site_utils/setup_dev_autotest.sh
@@ -66,6 +66,7 @@
SHADOW_CONFIG_PATH="${AUTOTEST_DIR}/shadow_config.ini"
echo "Autotest supports local overrides of global configuration through a "
echo "'shadow' configuration file. Setting one up for you now."
+CLOBBER=0
if [ -f ${SHADOW_CONFIG_PATH} ]; then
clobber=
while read -n 1 -p "Clobber existing shadow config? [Y/n]: " clobber; do
@@ -76,12 +77,16 @@
echo "Please enter y or n."
done
if [[ "${clobber}" = 'n' || "${clobber}" = 'N' ]]; then
+ CLOBBER=1
echo "Refusing to clobber existing shadow_config.ini."
+ else
+ echo "Clobbering existing shadow_config.ini."
fi
- echo "Clobbering existing shadow_config.ini."
fi
-cat > "${SHADOW_CONFIG_PATH}" <<EOF
+# Create clean shadow config if we're replacing it/creating a new one.
+if [ $CLOBBER -eq 0 ]; then
+ cat > "${SHADOW_CONFIG_PATH}" <<EOF
[AUTOTEST_WEB]
host: localhost
password: ${PASSWD}
@@ -95,7 +100,8 @@
[SCHEDULER]
drones: localhost
EOF
-echo -e "Done!\n"
+ echo -e "Done!\n"
+fi
echo "Installing needed Ubuntu packages..."
PKG_LIST="mysql-server mysql-common libapache2-mod-python python-mysqldb \