[autotest] Remove unused arguments from create_host() calls.
Many of the callers to hosts.create_host() pass settings for
parameters named 'initialize' and 'auto_monitor'. The parameters
are fictitious, and appear nowhere in source except for these calls.
This removes the bogus parameter settings.
BUG=None
TEST=run_suite with the push_to_prod test suite.
Change-Id: I30c0e00c704d529ebb1767724ee059f1d9a6906d
Reviewed-on: https://chromium-review.googlesource.com/368420
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Dan Shi <dshi@chromium.org>
diff --git a/server/control_segments/cleanup b/server/control_segments/cleanup
index dd05803..adbafc0 100644
--- a/server/control_segments/cleanup
+++ b/server/control_segments/cleanup
@@ -17,8 +17,7 @@
try:
hostname = utils.get_hostname_from_machine(machine)
job.record('START', None, 'cleanup')
- host = hosts.create_host(machine, initialize=False, auto_monitor=False,
- try_lab_servo=True)
+ host = hosts.create_host(machine, try_lab_servo=True)
timer = autotest_stats.Timer('cleanup_time')
timer.start()
diff --git a/server/control_segments/crashdumps b/server/control_segments/crashdumps
index ff9f837..f4be1f8 100644
--- a/server/control_segments/crashdumps
+++ b/server/control_segments/crashdumps
@@ -4,8 +4,7 @@
def crashdumps(machine):
- host = hosts.create_target_machine(machine, initialize=False,
- auto_monitor=False)
+ host = hosts.create_target_machine(machine)
try:
crashcollect.get_crashdumps(host, test_start_time)
except Exception as e:
diff --git a/server/control_segments/crashinfo b/server/control_segments/crashinfo
index 2f02a26..eec6561 100644
--- a/server/control_segments/crashinfo
+++ b/server/control_segments/crashinfo
@@ -7,7 +7,7 @@
logging.info('testbed does not need to get crash info.')
return
- host = hosts.create_host(machine, initialize=False, auto_monitor=False)
+ host = hosts.create_host(machine)
crashcollect.get_crashinfo(host, test_start_time)
diff --git a/server/control_segments/get_network_stats b/server/control_segments/get_network_stats
index 8fea248..eeac989 100644
--- a/server/control_segments/get_network_stats
+++ b/server/control_segments/get_network_stats
@@ -11,7 +11,7 @@
def get_network_stats(machine):
try:
- dut = hosts.create_target_machine(machine, initialize=False)
+ dut = hosts.create_target_machine(machine)
# The information is not critical, so ping the DUT first
# and if it doesn't reply quickly, give up.
diff --git a/server/control_segments/install b/server/control_segments/install
index 9650870..d98c945 100644
--- a/server/control_segments/install
+++ b/server/control_segments/install
@@ -2,8 +2,7 @@
from autotest_lib.server import afe_utils
def install(machine):
- host = hosts.create_target_machine(machine, initialize=False,
- auto_monitor=False)
+ host = hosts.create_target_machine(machine)
afe_utils.machine_install_and_update_labels(host)
diff --git a/server/control_segments/repair b/server/control_segments/repair
index f83b3ce..a13203b 100644
--- a/server/control_segments/repair
+++ b/server/control_segments/repair
@@ -15,9 +15,7 @@
try:
hostname = utils.get_hostname_from_machine(machine)
job.record('START', None, 'repair')
- target = hosts.create_target_machine(machine, initialize=False,
- auto_monitor=False,
- try_lab_servo=True)
+ target = hosts.create_target_machine(machine, try_lab_servo=True)
# We don't need to collect logs or crash info if we're an ADBHost or
# testbed since they're not applicable (yet).
if isinstance(target, hosts.CrosHost):
diff --git a/server/control_segments/reset b/server/control_segments/reset
index fab380f..f4395f0 100644
--- a/server/control_segments/reset
+++ b/server/control_segments/reset
@@ -15,8 +15,7 @@
timer = None
try:
job.record('START', None, 'reset')
- target = hosts.create_target_machine(machine, initialize=False,
- auto_monitor=False)
+ target = hosts.create_target_machine(machine)
timer = autotest_stats.Timer('reset_time')
timer.start()
diff --git a/server/control_segments/stage_server_side_package b/server/control_segments/stage_server_side_package
index 2bf15a3..26f3063 100644
--- a/server/control_segments/stage_server_side_package
+++ b/server/control_segments/stage_server_side_package
@@ -15,7 +15,7 @@
# Only need to stage server side package once.
for machine in machines:
try:
- host = hosts.create_host(machine, initialize=False, auto_monitor=False)
+ host = hosts.create_host(machine)
ssp_url = host.stage_server_side_package(image)
break
except (error.AutoservError, dev_server.DevServerException) as e:
diff --git a/server/control_segments/verify b/server/control_segments/verify
index c2deec0..a5fb643 100644
--- a/server/control_segments/verify
+++ b/server/control_segments/verify
@@ -13,8 +13,8 @@
timer = None
# We set try_lab_servo to True to trigger servo verify and
# servo update if needed.
- target = hosts.create_target_machine(machine, initialize=False,
- auto_monitor=False, try_lab_servo=True)
+ target = hosts.create_target_machine(machine,
+ try_lab_servo=True)
try:
job.record('START', None, 'verify')
timer = autotest_stats.Timer('verify_time')
diff --git a/server/control_segments/verify_job_repo_url b/server/control_segments/verify_job_repo_url
index a073fcc..6f908ce 100644
--- a/server/control_segments/verify_job_repo_url
+++ b/server/control_segments/verify_job_repo_url
@@ -7,7 +7,7 @@
return
logging.info('Verifying job repo url for machine %s', machine)
- host = hosts.create_host(machine, initialize=False, auto_monitor=False)
+ host = hosts.create_host(machine)
host.verify_job_repo_url(job.tag)
diff --git a/server/samples/info.srv b/server/samples/info.srv
index 5bdd2bf..149381b 100644
--- a/server/samples/info.srv
+++ b/server/samples/info.srv
@@ -1,5 +1,5 @@
def run(machine):
- host = hosts.create_host(machine, initialize = False)
+ host = hosts.create_host(machine)
print 'Uptime: ' + host.check_uptime()
print 'Arch: ' + host.get_arch()
print 'Kernel ver: ' + host.get_kernel_ver()
diff --git a/server/samples/profilertest.srv b/server/samples/profilertest.srv
index 2d6fc46..7f9e224 100644
--- a/server/samples/profilertest.srv
+++ b/server/samples/profilertest.srv
@@ -1,6 +1,6 @@
import time
-ssh_hosts = [hosts.create_host(m, initialize=False) for m in machines]
+ssh_hosts = [hosts.create_host(m) for m in machines]
at_hosts = [autotest.Autotest(h) for h in ssh_hosts]
diff --git a/server/samples/uname.srv b/server/samples/uname.srv
index 008cba0..be0a9c7 100644
--- a/server/samples/uname.srv
+++ b/server/samples/uname.srv
@@ -1,4 +1,4 @@
-hosts = [hosts.create_host(h, initialize=False) for h in machines]
+hosts = [hosts.create_host(h) for h in machines]
for host in hosts:
print host.hostname
diff --git a/server/site_tests/provision_AndroidUpdate/control b/server/site_tests/provision_AndroidUpdate/control
index 93d5d53..ba625b3 100644
--- a/server/site_tests/provision_AndroidUpdate/control
+++ b/server/site_tests/provision_AndroidUpdate/control
@@ -32,7 +32,7 @@
def run(machine):
- host = hosts.create_host(machine, initialize=False)
+ host = hosts.create_host(machine)
job.run_test('provision_AndroidBuildUpdate', host=host, value=value)
diff --git a/server/site_tests/provision_AutoUpdate/control b/server/site_tests/provision_AutoUpdate/control
index f6ab4cf..e4edd9a 100644
--- a/server/site_tests/provision_AutoUpdate/control
+++ b/server/site_tests/provision_AutoUpdate/control
@@ -37,7 +37,7 @@
# Save preserved log after autoupdate is completed.
job.sysinfo.add_logdir(constants.AUTOUPDATE_PRESERVE_LOG)
- host = hosts.create_host(machine, initialize=False)
+ host = hosts.create_host(machine)
# Only collect pre-test sysinfo to save time.
job.run_test('provision_AutoUpdate', host=host, value=value,
disable_sysinfo=False,
diff --git a/server/tests/cleanup_test/control b/server/tests/cleanup_test/control
index 84c45e8..451ffde 100644
--- a/server/tests/cleanup_test/control
+++ b/server/tests/cleanup_test/control
@@ -12,7 +12,7 @@
"""
def run(machine):
- host = hosts.create_host(machine, initialize=False)
+ host = hosts.create_host(machine)
job.run_test('cleanup_test', host=host, disable_sysinfo=True)
job.parallel_simple(run, machines)
diff --git a/server/tests/reinstall/control b/server/tests/reinstall/control
index 77f09cb..f7bb56a 100644
--- a/server/tests/reinstall/control
+++ b/server/tests/reinstall/control
@@ -10,7 +10,7 @@
afe_utils.machine_install_and_update_labels()."""
def run(machine):
- host = hosts.create_host(machine, initialize=False)
+ host = hosts.create_host(machine)
job.run_test('reinstall', host=host, disable_sysinfo=True)
job.parallel_simple(run, machines)
diff --git a/server/tests/verify_test/control b/server/tests/verify_test/control
index b5cef0f..8726c0d 100644
--- a/server/tests/verify_test/control
+++ b/server/tests/verify_test/control
@@ -14,7 +14,7 @@
"""
def run(machine):
- host = hosts.create_host(machine, initialize=False)
+ host = hosts.create_host(machine)
job.run_test('verify_test', host=host, disable_sysinfo=True)
job.parallel_simple(run, machines)