tree da390415fd6c0b6123a48b29a6908cbf7c7425c1
parent cd365f5b9037c2cfc2b5e1f3f530b0d50f667a97
author En-Shuo Hsu <enshuo@chromium.org> 1576912481 +0000
committer Commit Bot <commit-bot@chromium.org> 1576928056 +0000

Reland "Reland "[autotest] Consolidate the dump audio diagnostics helper func""

This reverts commit 69199ff6df1e5695a767f13b27718155ddee38e2.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "Reland "[autotest] Consolidate the dump audio diagnostics helper func""
> 
> This reverts commit ccc3c8c9396ea3352701ca145c30cbdb3a649577.
> 
> Reason for revert: <INSERT REASONING HERE>
> 
> Original change's description:
> > Reland "[autotest] Consolidate the dump audio diagnostics helper func"
> > 
> > This is a reland of d4c5c86d0ae4f382cfed02669cb9a010937cf3c8
> > 
> > Fix the wrong dump_diagnostics to dump_audio_diagnostics in
> > audio_facade_native.py.
> > 
> > Original change's description:
> > > [autotest] Consolidate the dump audio diagnostics helper func
> > >
> > > This change is a clean up to remove duplicate and legacy codes.
> > > Removing the log_loopback_dongle_status as we have the loopback latency
> > > check in the audio_LoopbackLatency tests. We can add the jack status
> > > check into it if needed.
> > >
> > > BUG=b/142701772
> > > TEST=Manual verify all modified tests
> > >
> > > Change-Id: I8b0b49baade44438ec069259088221ba671e3798
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1862360
> > > Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> > > Tested-by: En-Shuo Hsu <enshuo@chromium.org>
> > > Commit-Queue: En-Shuo Hsu <enshuo@chromium.org>
> > 
> > Bug=b/142701772, b/146472345
> > TEST=Run audio_AudioBasicInternalSpeaker that use dump_diagnostic
> > Change-Id: I4d410afd22111b0e0245e798bf4a343a67678765
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1973294
> > Tested-by: En-Shuo Hsu <enshuo@chromium.org>
> > Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
> > Commit-Queue: En-Shuo Hsu <enshuo@chromium.org>
> 
> Change-Id: Ie2502fc12bbe4598192118590e1f34d3d064e3f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1978127
> Reviewed-by: En-Shuo Hsu <enshuo@chromium.org>
> Tested-by: En-Shuo Hsu <enshuo@chromium.org>

Change-Id: I0ef869513f2330ae24b5a712cfecabbc914f310b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1978129
Reviewed-by: En-Shuo Hsu <enshuo@chromium.org>
Commit-Queue: En-Shuo Hsu <enshuo@chromium.org>
Tested-by: En-Shuo Hsu <enshuo@chromium.org>