Better PerfControl temperature spew.
Also, only fail tests from now on if we hit critical temperature.
BUG=None.
TEST=Ran graphics_PerfControl, graphics_GLBench, graphics_GLMark2 on link.
Change-Id: If83d3635d0d40decfe8a4e7cca0fc910d3543ed2
Reviewed-on: https://chromium-review.googlesource.com/199240
Commit-Queue: Ilja Friedel <ihf@chromium.org>
Tested-by: Ilja Friedel <ihf@chromium.org>
Reviewed-by: Rohit Makasana <rohitbm@chromium.org>
diff --git a/client/bin/site_utils.py b/client/bin/site_utils.py
index 1fbd20c..fc49351 100644
--- a/client/bin/site_utils.py
+++ b/client/bin/site_utils.py
@@ -614,6 +614,7 @@
# Today typical for Intel is 98'C to 105'C while ARM is 85'C. Clamp to
# the lowest known value.
if ((min_temperature < 60.0) or min_temperature > 150.0):
+ logging.warning('Critical temperature of %.1fC was reset to 85.0C.')
min_temperature = 85.0
min_temperature = min(temperature, min_temperature)
@@ -631,7 +632,8 @@
max_temperature = max(temperature, max_temperature)
# Sanity check for real world values.
assert ((max_temperature > 10.0) and
- (max_temperature < 150.0)), 'Unreasonable temperature.'
+ (max_temperature < 150.0)), ('Unreasonable temperature %.1fC.' %
+ max_temperature)
return max_temperature
@@ -655,7 +657,9 @@
for temperature in temperatures:
# Sanity check for real world values.
assert ((temperature > 10.0) and
- (temperature < 150.0)), 'Unreasonable temperature.'
+ (temperature < 150.0)), ('Unreasonable temperature %.1fC.' %
+ temperature)
+
return temperatures