autotest (wifi): rename LinuxSystem.set_default_antenna_bitmap()
The current name of this method requires a caller to
know what "default" means. Rename the method to make
the purpose of the call more obvious.
BUG=chromium:569205
TEST=test_that chromeos1-row3-rack11-host3.cros network_WiFi_VerifyRouter
Change-Id: Ib925b0e1f3f408e97079abeddbb6f1c666ca5561
Reviewed-on: https://chromium-review.googlesource.com/317881
Commit-Ready: mukesh agrawal <quiche@chromium.org>
Tested-by: mukesh agrawal <quiche@chromium.org>
Reviewed-by: Paul Stewart <pstew@chromium.org>
Reviewed-by: Zeping Qiu <zqiu@chromium.org>
diff --git a/server/site_linux_router.py b/server/site_linux_router.py
index 515e038..dd9c9f3 100644
--- a/server/site_linux_router.py
+++ b/server/site_linux_router.py
@@ -207,8 +207,7 @@
# Place us in the US by default
self.iw_runner.set_regulatory_domain('US')
- # Reset all antennas to be active
- self.set_default_antenna_bitmap()
+ self.enable_all_antennas()
# Some tests want this functionality, but otherwise, it's a distraction.
if self._enable_avahi:
diff --git a/server/site_linux_system.py b/server/site_linux_system.py
index 83157f0..52f02e9 100644
--- a/server/site_linux_system.py
+++ b/server/site_linux_system.py
@@ -697,8 +697,8 @@
self.iw_runner.set_antenna_bitmap(phy.name, tx_bitmap, rx_bitmap)
- def set_default_antenna_bitmap(self):
- """Setup default antenna bitmaps for all the phys."""
+ def enable_all_antennas(self):
+ """Enable all antennas on all phys."""
for phy in self.phy_list:
if not phy.supports_setting_antenna_mask:
continue
diff --git a/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py b/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py
index c400d0b..14cb209 100644
--- a/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py
+++ b/server/site_tests/network_WiFi_VerifyRouter/network_WiFi_VerifyRouter.py
@@ -99,10 +99,10 @@
"""Clean up after the test is completed
Perform additional cleanups after the test, the important thing is
- to restore default antennas bitmap.
+ to re-enable all antennas.
"""
self.context.router.deconfig()
- self.context.router.set_default_antenna_bitmap()
+ self.context.router.enable_all_antennas()
super(network_WiFi_VerifyRouter, self).cleanup()