Increase servo power button LONG_DELAY to 8.5 seconds.
The existing time limit of 8.2 seconds wasn't enough for ZGB;
increased it to 8.5 seconds.
BUG=None
TEST=platform_InstallTestImage on ZGB
Change-Id: I43e48298ad5ac41dbb41d681cdd77c9a4eb2138d
Reviewed-on: https://gerrit.chromium.org/gerrit/28546
Reviewed-by: Chris Sosa <sosa@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
diff --git a/server/cros/servo.py b/server/cros/servo.py
index a849d82..53d2a06 100644
--- a/server/cros/servo.py
+++ b/server/cros/servo.py
@@ -23,20 +23,25 @@
# Power button press delays in seconds.
#
- # TODO(jrbarnette): The EC specification says that 8.0 seconds
- # should be enough for the long power press. However, on
- # existing platforms (e.g. Alex), we need a bit more time.
- # Being generous is the right thing to do for existing platforms,
- # but if this code is to be used for qualification of new hardware,
- # we should be less generous.
- LONG_DELAY = 8.2
+ # The EC specification says that 8.0 seconds should be enough
+ # for the long power press. However, some platforms need a bit
+ # more time. Empirical testing has found these requirements:
+ # Alex: 8.2 seconds
+ # ZGB: 8.5 seconds
+ # The actual value is set to the largest known necessary value.
+ #
+ # TODO(jrbarnette) Being generous is the right thing to do for
+ # existing platforms, but if this code is to be used for
+ # qualification of new hardware, we should be less generous.
+ LONG_DELAY = 8.5
SHORT_DELAY = 0.1
NORMAL_TRANSITION_DELAY = 1.2
+
# Maximum number of times to re-read power button on release.
RELEASE_RETRY_MAX = 5
GET_RETRY_MAX = 10
- # Delays to deal with computer transitions.
+ # Delays to deal with DUT state transitions.
SLEEP_DELAY = 6
BOOT_DELAY = 10
RECOVERY_BOOT_DELAY = 10