There's way too many levels of indirection inbetween job.run_test
and actually excuting the test - makes the code very hard to read.
job.run_test
job.__runtest
test.runtest
test.__runtest
test.run
test.__exec
test.execute
Seven levels seems a bit extreme ;-) Now we're refactored some
bits, we should be able to collapse this down some.
job.run_test
job.__runtest
test.runtest
test._exec
test.execute
Signed-off-by: Martin J. Bligh <mbligh@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@828 592f7852-d20e-0410-864c-8624ca9c26a4
diff --git a/client/bin/job.py b/client/bin/job.py
index 3cda9cf..5841978 100755
--- a/client/bin/job.py
+++ b/client/bin/job.py
@@ -201,7 +201,9 @@
def __runtest(self, url, tag, args, dargs):
try:
- test.runtest(self, url, tag, args, dargs)
+ l = lambda : test.runtest(self, url, tag, args, dargs)
+ pid = fork_start(self.resultdir, l)
+ fork_waitfor(self.resultdir, pid)
except AutotestError:
raise
except:
@@ -209,10 +211,6 @@
self.__class__.__name__ + "\n")
- def runtest(self, tag, url, *args):
- raise "Deprecated call to job.runtest. Use run_test instead"
-
-
def run_test(self, url, *args, **dargs):
"""Summon a test object and run it.