| commit | ef9e0a5f54134128cac76882cc85526d3b849a21 | [log] [tgz] |
|---|---|---|
| author | Douglas Anderson <dianders@chromium.org> | Wed Jan 08 14:46:03 2020 -0800 |
| committer | Ilja H. Friedel <ihf@chromium.org> | Thu Jan 30 01:02:26 2020 +0000 |
| tree | 3edf9cbf70831d3cdf990a47a09669afd2c7c93b | |
| parent | 8ecb14f6d80ba1137ec4f985db4a523848d7bd24 [diff] |
Remove the concept of 'critical' temperature from autotest Some of our perf utilities attempted to tell if the perf data should be invalidated (because the system was thermally throttled during the test) by seeing if the temperature in the system got close to the "critical" temperature. There were a few problems here: 1. It was assumed that we could take the minimum of all "critical" temperatures in the system and compare that to the maximum of all temperatures in the system. If the values crossed then the system was throttled. The problem here is that there could be all sorts of temperatures / throttling devices in the system and it's not valid to compare the temperature from one device to the critical value for another device. We might have both an on-SoC temperature monitor and a thermistor somewhere away from the CPU to measure skin temperature. In that case the on-SoC temperature monitor will throttle the CPU to prevent the SoC from being damaged and the thermistor will throttle the same CPU to keep the user's lap from being too warm. 2. On some ARM devices it appears that the thermal sensors were showing up in the 'thermal_zone' part of sysfs but not in hwmon. Thus we couldn't easily get the 'critical' temperature. We could have attempted to find similar information from the thermal subsystem but see #1. Let's change this code to look at the thermal cooling devices and see if we ever ended up in a state other than 0. I believe this will be what we really want. We'll also get rid of everyone who was trying to log the "critical" temperature since it doesn't really make sense in isolation. BUG=chromium:941638 TEST=graphics_WebGLAquarium Change-Id: I737aa4cb7f32df11c4301f04a57867cf1967e0bb Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1992411 Tested-by: Ilja H. Friedel <ihf@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.