| commit | 710b163f7e688496c6218d9b6da9109a99345cc9 | [log] [tgz] |
|---|---|---|
| author | Yury Khmel <khmel@chromium.org> | Wed Sep 12 21:33:12 2018 +0000 |
| committer | chrome-bot <chrome-bot@chromium.org> | Tue Sep 18 02:25:19 2018 -0700 |
| tree | d2a986046978954843447f2181997c4ceeb235fa | |
| parent | a5192c1af01dbbbd5b59051259f3c2b04536f147 [diff] |
Revert "[Autotest] Make ARC++ login better handle managed users" This reverts commit 8a9afcb9c8c05095e34b4dca72db4b2da50aa74f. Reason for revert: it breaks at least cheets_AuthPerf.managed BUG=chromium:883176 Original change's description: > [Autotest] Make ARC++ login better handle managed users > > The opt_in() function has several use cases: > - regular users where enabled=True: enable arc++, opt in, and wait > - regular users where enabled=False: set arc++ false and do nothing > - managed users: no need to enable or opt in (this is controlled by policy) > - managed users where we wish to ignore policy: passed in as an option > to the function, should behave like a regular user > > Previously we were not skipping the opt in step for managed users > when the policy was True (as users did at one time have to opt in). > That's not true anymore, so this CL corrects the behavior. > > BUG=None > TEST=ran it on several devices, and the termsPage error (raised because > there is no opt in dialog) goes away. > > Change-Id: Ic0ff3212e3c40e6cc695a467f92a4cd2924bd40c > Reviewed-on: https://chromium-review.googlesource.com/1200502 > Commit-Ready: Katherine Threlkeld <kathrelkeld@chromium.org> > Tested-by: Katherine Threlkeld <kathrelkeld@chromium.org> > Reviewed-by: Rohit Makasana <rohitbm@chromium.org> > Reviewed-by: Victor Hsieh <victorhsieh@chromium.org> Bug: None Change-Id: I6b84ed02898c93c5fcbcfca1f7fd71a954cd05e9 Reviewed-on: https://chromium-review.googlesource.com/1222256 Commit-Ready: Yury Khmel <khmel@google.com> Tested-by: Yury Khmel <khmel@google.com> Reviewed-by: Yury Khmel <khmel@google.com>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.