commit 76af802bd80edf50fd34efae25205c3aeaf82f25
author Dan Shi <dshi@chromium.org> Sat Oct 19 01:59:49 2013 -0700
committer chrome-internal-fetch <chrome-internal-fetch@google.com> Tue Dec 03 04:11:33 2013 +0000
tree 5c45c06f6a84e88bee91b16f204242cec9b13258
parent d2eb716ddcc092e37eb36024c43ca7a348606d99

[autotest] abort Starting suite job leads to scheduler crash

abort Starting suite job leads to scheduler crash with error:
AssertionError: self.execution_subdir not found

BUG=chromium:309207,276507
TEST=unittest, and manual test:
1. add |max_hostless_processes: 1| and |max_processes_per_drone: 3| to SCHEDULER
   section of shadow config.
2. restart scheduler
3. add three new suite jobs. When the third job shows status of Starting in afe,
   try to abort it in afe.
4. abort all other suite jobs, and scheduler should abort all suite jobs.

DEPLOY=scheduler

Change-Id: I763918c34569643edb5e0acd94a3ca54cc6e5949
Reviewed-on: https://chromium-review.googlesource.com/173770
Reviewed-by: Dan Shi <dshi@chromium.org>
Commit-Queue: Dan Shi <dshi@chromium.org>
Tested-by: Dan Shi <dshi@chromium.org>

scheduler/scheduler_models_unittest.py

diff --git a/scheduler/scheduler_models_unittest.py b/scheduler/scheduler_models_unittest.py
index 446e960..22e213a 100755
--- a/scheduler/scheduler_models_unittest.py
+++ b/scheduler/scheduler_models_unittest.py
@@ -1,4 +1,5 @@
 #!/usr/bin/python
+#pylint: disable-msg=C0111
 
 import datetime
 import common
@@ -8,6 +9,7 @@
 from autotest_lib.client.common_lib.test_utils import unittest
 from autotest_lib.database import database_connection
 from autotest_lib.frontend.afe import models, model_attributes
+from autotest_lib.scheduler import monitor_db
 from autotest_lib.scheduler import monitor_db_functional_test
 from autotest_lib.scheduler import scheduler_models
 
@@ -245,6 +247,44 @@
         self._check_hqe_labels(hqe, ['label1', 'label3', 'label4'])
 
 
+    def setup_abort_test(self, agent_finished=True):
+        """Setup the variables for testing abort method.
+
+        @param agent_finished: True to mock agent is finished before aborting
+                               the hqe.
+        @return hqe, dispatcher: Mock object of hqe and dispatcher to be used
+                               to test abort method.
+        """
+        hqe = self._create_hqe(hosts=[1])
+        hqe.aborted = True
+        hqe.complete = False
+        hqe.status = models.HostQueueEntry.Status.STARTING
+
+        dispatcher = self.god.create_mock_class(monitor_db.BaseDispatcher,
+                                                'BaseDispatcher')
+        agent = self.god.create_mock_class(monitor_db.Agent, 'Agent')
+        dispatcher.get_agents_for_entry.expect_call(hqe).and_return([agent])
+        agent.is_done.expect_call().and_return(agent_finished)
+        return hqe, dispatcher
+
+
+    def test_abort_fail_with_unfinished_agent(self):
+        """abort should fail if the hqe still has agent not finished.
+        """
+        hqe, dispatcher = self.setup_abort_test(agent_finished=False)
+        with self.assertRaises(AssertionError):
+            hqe.abort(dispatcher)
+        self.god.check_playback()
+
+
+    def test_abort_success(self):
+        """abort should succeed if all agents for the hqe are finished.
+        """
+        hqe, dispatcher = self.setup_abort_test(agent_finished=True)
+        hqe.abort(dispatcher)
+        self.god.check_playback()
+
+
 class JobTest(BaseSchedulerModelsTest):
     def setUp(self):
         super(JobTest, self).setUp()