On Wed, Feb 24, 2010 at 3:44 PM, John Admanski <jadmanski@google.com> wrote:
> logging.error("%s: %s" % (test_name, e))
>
>
> should be:
>
> logging.error("%s: %s", test_name, e)
>
> With the logging you don't do the % interpolation yourself, the logging framework does it.
>
>
Sure. Fixed.
>
> Also, don't use the form "string.find(x) >= 0" when trying to see if a string contains x, use "x in string" (or "x not in string" for the opposite case).
>
>
I assume this was an FYI rather than a review comment given that this
statement wasn't part of this patch. Anyway, fixed it so that it actually
works and doesn't match if a test name happens to contain the substring
"all".
New patch attached. PTAL.
Thanks,
Darin
>
>
> -- John
>
>
> On Wed, Feb 24, 2010 at 3:31 PM, Darin Petkov <petkov@google.com> wrote:
>
>> Fix setup_job so that it doesn't fail at load_all_client_tests if a
>> test in the tree is broken. Collect and print the broken tests (if we were
>> to actually build them).
>>
>>
>> _______________________________________________
>> Autotest mailing list
>> Autotest@test.kernel.org
>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
>>
>>
>
>From 01985433402b69df50934d6050219a8504fe6ab0 Mon Sep 17 00:00:00 2001
From: Darin Petkov <petkov@chromium.org>
Date: Wed, 24 Feb 2010 14:14:21 -0800
Subject: [PATCH] Fix setup_job so that it doesn't fail at load_all_client_tests if a test
in the tree is broken. Collect and print the broken tests (if we were to
actually build them).
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4270 592f7852-d20e-0410-864c-8624ca9c26a4
1 file changed