commit 84a2ecf3422e6b7f52ffd4628e4a8d47dbe53b4e
author Michael Tang <ntang@google.com> Tue Jun 07 15:10:53 2016 -0700
committer chrome-bot <chrome-bot@chromium.org> Tue Jun 14 08:10:48 2016 -0700
tree 1683a63e4343dd5e114ed068eb5abf002521da97
parent f0f0fc17d10f88a70d2b9191dbd2fbeeadf3402d

Enabled create test job out of private test build.

We now allow user to have a test source build containing tests not
present in the moblab and its database. The user could fetch those tests
and select them to create jobs.

BUG=chromium:603774
TEST=manually tests and some unit test.

Change-Id: I4aecb922b006a0743ef4cb223f555fac7343c6c0
Reviewed-on: https://chromium-review.googlesource.com/351480
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>

frontend/afe/rpc_interface.py

diff --git a/frontend/afe/rpc_interface.py b/frontend/afe/rpc_interface.py
index dff4165..116a327 100644
--- a/frontend/afe/rpc_interface.py
+++ b/frontend/afe/rpc_interface.py
@@ -751,7 +751,7 @@
 def generate_control_file(tests=(), kernel=None, label=None, profilers=(),
                           client_control_file='', use_container=False,
                           profile_only=None, upload_kernel_config=False,
-                          db_tests=True):
+                          db_tests=True, test_source_build=None):
     """
     Generates a client-side control file to load a kernel and run tests.
 
@@ -781,6 +781,8 @@
                      of test IDs which are used to retrieve the test objects
                      from the database. If False, tests is a tuple of test
                      dictionaries stored client-side in the AFE.
+    @param test_source_build: Build to be used to retrieve test code. Default
+                              to None.
 
     @returns a dict with the following keys:
         control_file: str, The control file text.
@@ -800,7 +802,8 @@
         tests=test_objects, kernels=kernel, platform=label,
         profilers=profiler_objects, is_server=cf_info['is_server'],
         client_control_file=client_control_file, profile_only=profile_only,
-        upload_kernel_config=upload_kernel_config)
+        upload_kernel_config=upload_kernel_config,
+        test_source_build=test_source_build)
     return cf_info
 
 
@@ -892,7 +895,7 @@
 def create_job_page_handler(name, priority, control_file, control_type,
                             image=None, hostless=False, firmware_rw_build=None,
                             firmware_ro_build=None, test_source_build=None,
-                            is_cloning = False, **kwargs):
+                            is_cloning=False, **kwargs):
     """\
     Create and enqueue a job.
 
@@ -1303,7 +1306,7 @@
         image = get_parameterized_autoupdate_image_url(job)
     else:
         keyvals = job.keyval_dict()
-        image =  keyvals.get('build')
+        image = keyvals.get('build')
         if not image:
             value = keyvals.get('builds')
             builds = None