Change servo-related boilerplate in control files.
Control files for servo tests contained standard boilerplate
needed to help support running tests via run_remote_tests.sh.
The boilerplate posed a minor maintenance hazard, made more
serious by the sheer number of tests that had copied the
boilerplate code.
This change switches the boilerplate to something (hopefully) less
likely to need to change, before the size of the maintenance hazard
gets any bigger.
BUG=chromium-os:35685
TEST=platform_LongPressPower using a remote servod, plus a careful review
Change-Id: Id7da90ec82c7faf60dd6eecfdec5e0734fa8e2a5
Reviewed-on: https://gerrit.chromium.org/gerrit/36521
Reviewed-by: Chris Masone <cmasone@chromium.org>
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Craig Harrison <craigdh@chromium.org>
diff --git a/server/site_tests/firmware_CorruptBothFwBodyAB/control.dev b/server/site_tests/firmware_CorruptBothFwBodyAB/control.dev
index a698f03..c3444d2 100644
--- a/server/site_tests/firmware_CorruptBothFwBodyAB/control.dev
+++ b/server/site_tests/firmware_CorruptBothFwBodyAB/control.dev
@@ -27,12 +27,10 @@
"""
args_dict = utils.args_to_dict(args)
-servo_host = args_dict.get('servo_host', 'localhost')
-servo_port = args_dict.get('servo_port', None)
+servo_args = hosts.SiteHost.get_servo_arguments(args_dict)
def run_corruptbothfwbodyab(machine):
- host = hosts.create_host(machine, servo_host=servo_host,
- servo_port=servo_port)
+ host = hosts.create_host(machine, servo_args=servo_args)
job.run_test("firmware_CorruptBothFwBodyAB", host=host, cmdline_args=args,
use_faft=True, disable_sysinfo=True,
dev_mode=True, tag="dev")