FAFT: Record the servod version
It is easier to tell what version the servod is running in order to
clarify if the servod is too old.
BUG=chromium:529504
TEST=Ran a FAFT test and checked the log and the resulted keyval file.
Change-Id: I9b555ae7360a5888b09d007b138633b1bd789498
Reviewed-on: https://chromium-review.googlesource.com/302673
Commit-Ready: Wai-Hong Tam <waihong@chromium.org>
Tested-by: Wai-Hong Tam <waihong@chromium.org>
Reviewed-by: David Hendricks <dhendrix@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>
diff --git a/server/cros/faft/firmware_test.py b/server/cros/faft/firmware_test.py
index 09fd165..922649c 100644
--- a/server/cros/faft/firmware_test.py
+++ b/server/cros/faft/firmware_test.py
@@ -6,6 +6,7 @@
import ctypes
import logging
import os
+import pprint
import re
import time
import uuid
@@ -172,11 +173,15 @@
This info is used by generate_test_report later.
"""
- self.write_attr_keyval({
+ system_info = {
'fw_version': self.faft_client.ec.get_version(),
'hwid': self.faft_client.system.get_crossystem_value('hwid'),
'fwid': self.faft_client.system.get_crossystem_value('fwid'),
- })
+ 'servod_version': self._client._servo_host.run(
+ 'servod --version').stdout.strip(),
+ }
+ logging.info('System info:\n' + pprint.pformat(system_info))
+ self.write_attr_keyval(system_info)
def invalidate_firmware_setup(self):
"""Invalidate all firmware related setup state.