faftsequence: Workaround keyboard dev mode bug
Currently software sync is not finished yet and we don't know whether
machine will come up after EC reboot. Let's work around this until
software sync is done.
BUG=chrome-os-partner:11694
TEST=Run firmware_CorruptFwSigA/control.normal and pass.
Change-Id: I97a3d26b8221a560325db2f775796863eac1d3b5
Reviewed-on: https://gerrit.chromium.org/gerrit/28376
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Vic Yang <victoryang@chromium.org>
Commit-Ready: Vic Yang <victoryang@chromium.org>
diff --git a/server/cros/faftsequence.py b/server/cros/faftsequence.py
index eae1d0c..d65673a 100644
--- a/server/cros/faftsequence.py
+++ b/server/cros/faftsequence.py
@@ -744,7 +744,11 @@
def disable_keyboard_dev_mode(self):
logging.info("Disabling keyboard controlled developer mode")
self.servo.disable_recovery_mode()
- self.servo.cold_reset()
+ # We don't use servo.cold_reset() here because software sync is not yet
+ # finished, and device may or may not come up after cold reset. Pressing
+ # power button before firmware comes up solves this.
+ self.servo.set('cold_reset', 'on')
+ self.servo.set('cold_reset', 'off')
# Rebooting EC with rec mode off. Software sync should power on AP,
# and then shut down AP after a while.
# TODO(victoryang): Figure out the proper delay period before pressing