| commit | 20336b2921bff2a361c9e8727f1da7c2887ac14a | [log] [tgz] |
|---|---|---|
| author | Hsin-chen Chuang <chharry@google.com> | Fri Jan 17 15:05:15 2020 +0800 |
| committer | Commit Bot <commit-bot@chromium.org> | Wed Jan 22 21:06:27 2020 +0000 |
| tree | 8dd248530d300f7d2b094655bd5ba16025b3beeb | |
| parent | 013bc50e820e121a676764b89bf39cae859bd19e [diff] |
hostapd_config: Add check to prevent generating ill-formed config.
The attribute `_vht_oper_centr_freq_seg0_idx` is used without checking,
so something like `vht_oper_centr_freq_seg0_idx=None` will appear in
hostapd config in those testcases which are 80211ac without setting a
center channel.
The config is ill-formed; however, it is ignored by hostapd parser. Thus,
this CL only prevents generating a eventually ignored config, and does not
change the behaviors of APs.
BUG=None
TEST=test_that --fast --debug -b ${BOARD} ${DUT} network_WiFi_SimpleConnect.wifi_check5VHT20
Change-Id: I3b8925ad73d21df968732f80675f2293af897c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2006849
Reviewed-by: Shuo-Peng Liao <deanliao@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Tested-by: Hsin-chen Chuang <chharry@google.com>
Commit-Queue: Brian Norris <briannorris@chromium.org>
Autotest is a framework for fully automated testing. It was originally designed to test the Linux kernel, and expanded by the Chrome OS team to validate complete system images of Chrome OS and Android.
Autotest is composed of a number of modules that will help you to do stand alone tests or setup a fully automated test grid, depending on what you are up to. A non extensive list of functionality is:
A body of code to run tests on the device under test. In this setup, test logic executes on the machine being tested, and results are written to files for later collection from a development machine or lab infrastructure.
A body of code to run tests against a remote device under test. In this setup, test logic executes on a development machine or piece of lab infrastructure, and the device under test is controlled remotely via SSH/adb/some combination of the above.
Developer tools to execute one or more tests. test_that for Chrome OS and test_droid for Android allow developers to run tests against a device connected to their development machine on their desk. These tools are written so that the same test logic that runs in the lab will run at their desk, reducing the number of configurations under which tests are run.
Lab infrastructure to automate the running of tests. This infrastructure is capable of managing and running tests against thousands of devices in various lab environments. This includes code for both synchronous and asynchronous scheduling of tests. Tests are run against this hardware daily to validate every build of Chrome OS.
Infrastructure to set up miniature replicas of a full lab. A full lab does entail a certain amount of administrative work which isn't appropriate for a work group interested in automated tests against a small set of devices. Since this scale is common during device bringup, a special setup, called Moblab, allows a natural progressing from desk -> mini lab -> full lab.
See the guides to test_that and test_droid:
See the best practices guide, existing tests, and comments in the code.
git clone https://chromium.googlesource.com/chromiumos/third_party/autotest
See the coding style guide for guidance on submitting patches.
You need to run utils/build_externals.py to set up the dependencies for pre-upload hook tests.