Simplify Servo.cold_reset() to be more useful and reliable.
The cold_reset() method would set the 'cold_reset' signal 'on',
but never set it back to 'off'. This was unhelpful at best, and
outright wrong at worst. This change fixes the behavior to Do The
Right Thing.
The change also refactors servo initialization methods, and
adjusts the one caller of cold_reset() to use the new API. Along
the way, it fixes an outstanding TODO, cited below.
CQ-DEPEND=Ief5581e1e453541752ecbea221c0a926c94a364b
BUG=chromium-os:23626
TEST=selected FAFT tests
Change-Id: I018173af9b8f5dda7966644948654b85bf5c01f7
Reviewed-on: https://gerrit.chromium.org/gerrit/27951
Tested-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
Commit-Ready: Richard Barnette <jrbarnette@chromium.org>
2 files changed