commit d876f459fff6cc4994cab329b1f80c99a86edcbd
author mbligh <mbligh@592f7852-d20e-0410-864c-8624ca9c26a4> Wed Dec 03 15:09:17 2008 +0000
committer mbligh <mbligh@592f7852-d20e-0410-864c-8624ca9c26a4> Wed Dec 03 15:09:17 2008 +0000
tree 36b083983aba76507fab57868006c06f2b8eac8d
parent 7b969d5a2d37e2f658aec477a93d5e5743935a74

gps pointed out that "== and != work in most cases but its better to use is
and is not as you'll never run into a case where someone's __eq__ or __ne__
method do the wrong thing."

Signed-off-by: Martin J. Bligh <mbligh@google.com>



git-svn-id: http://test.kernel.org/svn/autotest/trunk@2533 592f7852-d20e-0410-864c-8624ca9c26a4

frontend/afe/json_rpc/proxy.py

diff --git a/frontend/afe/json_rpc/proxy.py b/frontend/afe/json_rpc/proxy.py
index 865ab3c..d0773c8 100644
--- a/frontend/afe/json_rpc/proxy.py
+++ b/frontend/afe/json_rpc/proxy.py
@@ -34,7 +34,7 @@
         self.__headers = headers or {}
 
     def __getattr__(self, name):
-        if self.__serviceName != None:
+        if self.__serviceName is not None:
             name = "%s.%s" % (self.__serviceName, name)
         return ServiceProxy(self.__serviceURL, name, self.__headers)
 
@@ -49,7 +49,7 @@
             resp = json_decoder.decode(respdata)
         except ValueError:
             raise JSONRPCException('Error decoding JSON reponse:\n' + respdata)
-        if resp['error'] != None:
+        if resp['error'] is not None:
             error_message = (resp['error']['name'] + ': ' +
                              resp['error']['message'] + '\n' +
                              resp['error']['traceback'])

frontend/afe/json_rpc/serviceHandler.py

diff --git a/frontend/afe/json_rpc/serviceHandler.py b/frontend/afe/json_rpc/serviceHandler.py
index 630363b..5a6ba29 100644
--- a/frontend/afe/json_rpc/serviceHandler.py
+++ b/frontend/afe/json_rpc/serviceHandler.py
@@ -92,7 +92,7 @@
             except:
                 err = BadServiceRequest(json)
 
-        if err == None:
+        if err is None:
             try:
                 meth = self.findServiceEndpoint(methName)
             except Exception, e:
@@ -100,7 +100,7 @@
                 print err_traceback
                 err = e
 
-        if err == None:
+        if err is None:
             try:
                 result = self.invokeServiceEndpoint(meth, args)
             except Exception, e:
@@ -134,7 +134,7 @@
         return meth(*args)
 
     def translateResult(self, rslt, err, err_traceback, id_):
-        if err != None:
+        if err is not None:
             err = {"name": err.__class__.__name__, "message":str(err),
                    "traceback": err_traceback}
             rslt = None