[autotest] Fix unittest for JobStatus
testWaitForResults was actually never checking to be sure that the test
statuses we inject were really being reported by job_status.wait_for_results()
This was because wait_for_results() was actually side-effecting the list of
jobs passed in and emptying it out as it ran. Thus, we'd get to the end of the
test and loop through 'jobs'...which was now an empty list!
This isn't biting us in practice because the real code never looks at the list
of jobs again after it passes it into wait_for_results(). This CL fixes the
code to use a local copy of the job list, as well.
BUG=None
TEST=unit
TEST=use run_suite.py to run a real suite
Change-Id: Ib35188502803b6ea4828d9514e419e900d8f999b
Reviewed-on: https://gerrit.chromium.org/gerrit/28840
Tested-by: Chris Masone <cmasone@chromium.org>
Reviewed-by: Scott Zawalski <scottz@chromium.org>
Commit-Ready: Chris Masone <cmasone@chromium.org>
diff --git a/server/cros/dynamic_suite_fakes.py b/server/cros/dynamic_suite_fakes.py
index fd396f5..6ba07c76 100644
--- a/server/cros/dynamic_suite_fakes.py
+++ b/server/cros/dynamic_suite_fakes.py
@@ -64,18 +64,21 @@
if hostname:
self.entry['host'] = {'hostname': hostname}
+
def __repr__(self):
return '%s\t%s\t%s: %s' % (self.status, self.test_name, self.reason,
self.hostname)
+
def equals_record(self, status):
"""Compares this object to a recorded status."""
if 'aborted' in self.entry and self.entry['aborted']:
- return status == 'ABORT'
+ return status._status == 'ABORT'
return (self.status == status._status and
self.test_name == status._test_name and
self.reason == status._reason)
+
def equals_hostname_record(self, status):
"""Compares this object to a recorded status.