tree 3edf9cbf70831d3cdf990a47a09669afd2c7c93b
parent 8ecb14f6d80ba1137ec4f985db4a523848d7bd24
author Douglas Anderson <dianders@chromium.org> 1578523563 -0800
committer Ilja H. Friedel <ihf@chromium.org> 1580346146 +0000

Remove the concept of 'critical' temperature from autotest

Some of our perf utilities attempted to tell if the perf data should
be invalidated (because the system was thermally throttled during the
test) by seeing if the temperature in the system got close to the
"critical" temperature.  There were a few problems here:

1. It was assumed that we could take the minimum of all "critical"
   temperatures in the system and compare that to the maximum of all
   temperatures in the system.  If the values crossed then the system
   was throttled.  The problem here is that there could be all sorts
   of temperatures / throttling devices in the system and it's not
   valid to compare the temperature from one device to the critical
   value for another device.  We might have both an on-SoC temperature
   monitor and a thermistor somewhere away from the CPU to measure
   skin temperature.  In that case the on-SoC temperature monitor will
   throttle the CPU to prevent the SoC from being damaged and the
   thermistor will throttle the same CPU to keep the user's lap from
   being too warm.

2. On some ARM devices it appears that the thermal sensors were
   showing up in the 'thermal_zone' part of sysfs but not in hwmon.
   Thus we couldn't easily get the 'critical' temperature.  We could
   have attempted to find similar information from the thermal
   subsystem but see #1.

Let's change this code to look at the thermal cooling devices and see
if we ever ended up in a state other than 0.  I believe this will be
what we really want.

We'll also get rid of everyone who was trying to log the "critical"
temperature since it doesn't really make sense in isolation.

BUG=chromium:941638
TEST=graphics_WebGLAquarium

Change-Id: I737aa4cb7f32df11c4301f04a57867cf1967e0bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/1992411
Tested-by: Ilja H. Friedel <ihf@chromium.org>
Reviewed-by: Ilja H. Friedel <ihf@chromium.org>