commit 868db2a514bbb02e166fb55b1592b27de8c9680c
author Tao Bao <tbao@google.com> Mon Sep 09 13:35:05 2019 -0700
committer Tao Bao <tbao@google.com> Mon Sep 09 13:38:05 2019 -0700
tree 7d8162a5ea8a866471a1e88d9047a23f11103d91
parent f164134c8d03fefbb379b58a5c6ce1d347b4d9cf

Don't call generate_fec_data when the result is not used.

Bug: 120058143
Test: atest libavb_host_unittest
Change-Id: I08c83f148ef47b8a12bdc6ba3a8fcab416a2ff8e

avbtool

diff --git a/avbtool b/avbtool
index 6960101..ce48155 100755
--- a/avbtool
+++ b/avbtool
@@ -3435,9 +3435,10 @@
 
       # Generate FEC codes, if requested.
       if generate_fec:
-        fec_data = generate_fec_data(image_filename, fec_num_roots)
         if no_hashtree:
           fec_data = bytearray()
+        else:
+          fec_data = generate_fec_data(image_filename, fec_num_roots)
         padding_needed = (round_to_multiple(len(fec_data), image.block_size) -
                           len(fec_data))
         fec_data_with_padding = fec_data + '\0'*padding_needed