commit 5d436193355b46c5c3a4a375f02d3378e8b3ec0f
author Gavin Howard <yzena.tech@gmail.com> Wed Feb 21 15:48:40 2018 -0700
committer Gavin Howard <yzena.tech@gmail.com> Tue Aug 28 17:10:28 2018 -0600
tree 4a224e64ad59297447542172066417672d921d65
parent 3cfa045a8af2462630c12e0ba8203c29432adb04

Fix a possible out of bounds bug in vectors

include/bc.h

diff --git a/include/bc.h b/include/bc.h
index 959a275..4eaec14 100644
--- a/include/bc.h
+++ b/include/bc.h
@@ -60,6 +60,8 @@
   BC_STATUS_NO_LIMIT,
   BC_STATUS_INVALID_LIMIT,
 
+  BC_STATUS_VEC_OUT_OF_BOUNDS,
+
   BC_STATUS_VECO_OUT_OF_BOUNDS,
   BC_STATUS_VECO_ITEM_EXISTS,
 

src/bc/bc.c

diff --git a/src/bc/bc.c b/src/bc/bc.c
index caa7f4f..3552e2c 100644
--- a/src/bc/bc.c
+++ b/src/bc/bc.c
@@ -48,6 +48,9 @@
 
   "vector",
 
+  "ordered vector",
+  "ordered vector",
+
   "Lex",
   "Lex",
   "Lex",
@@ -123,6 +126,9 @@
   "one or more limits not specified",
   "invalid limit; this is a bug in bc",
 
+  "index is out of bounds for the vector and error was not caught; "
+    "this is probably a bug in bc",
+
   "index is out of bounds for the ordered vector and error was not caught; "
     "this is probably a bug in bc",
   "item already exists in ordered vector and error was not caught; "

src/bc/vector.c

diff --git a/src/bc/vector.c b/src/bc/vector.c
index 94d4af7..71a88bc 100644
--- a/src/bc/vector.c
+++ b/src/bc/vector.c
@@ -161,6 +161,8 @@
     return BC_STATUS_INVALID_PARAM;
   }
 
+  if (!vec->len) return BC_STATUS_VEC_OUT_OF_BOUNDS,
+
   --vec->len;
 
   if (vec->dtor) vec->dtor(vec->array + (vec->size * vec->len));