commit 70610174b4052139347e5403a82e3e992e6bd830
author Gavin Howard <yzena.tech@gmail.com> Wed Sep 05 20:30:08 2018 -0600
committer Gavin Howard <yzena.tech@gmail.com> Wed Sep 05 20:30:08 2018 -0600
tree ff51bc99a691741e28a560fe192b0fa5e587fcb0
parent 21427f5202b90844abb484e76760b924d0892bc0

Remove all defects found by Coverity Scan

src/program.c

diff --git a/src/program.c b/src/program.c
index f877cd1..dc789f6 100644
--- a/src/program.c
+++ b/src/program.c
@@ -750,7 +750,7 @@
     status = bc_num_ulong2num(&result.data.num, (unsigned long) vec->len);
   }
   else {
-    assert(result.type != BC_RESULT_ARRAY);
+    assert(operand->type != BC_RESULT_ARRAY);
     BcProgramBuiltIn f = inst == BC_INST_LENGTH ? bc_program_len :
                                                   bc_program_scale;
     status = bc_num_ulong2num(&result.data.num, f(num1));
@@ -787,6 +787,7 @@
   BcStatus status;
   BcResult *ptr, result, copy;
   BcNum *num;
+  uint8_t inst2 = inst;
 
   if ((status = bc_program_unaryOpPrep(p, &ptr, &num))) return status;
 
@@ -802,7 +803,7 @@
   if ((status = bc_vec_push(&p->results, &result))) goto err;
   if ((status = bc_program_assign(p, inst))) goto err;
 
-  if (inst == BC_INST_INC_POST || inst == BC_INST_DEC_POST) {
+  if (inst2 == BC_INST_INC_POST || inst2 == BC_INST_DEC_POST) {
     bc_vec_pop(&p->results);
     if ((status = bc_vec_push(&p->results, &copy))) goto err;
   }
@@ -811,7 +812,7 @@
 
 err:
 
-  if (inst == BC_INST_INC_POST || inst == BC_INST_DEC_POST)
+  if (inst2 == BC_INST_INC_POST || inst2 == BC_INST_DEC_POST)
     bc_num_free(&copy.data.num);
 
   return status;
@@ -863,8 +864,8 @@
 
   strcpy(main_name, bc_lang_func_main);
   s = bc_program_addFunc(p, main_name, &idx);
-  main_name = NULL;
   if (s || idx != BC_PROGRAM_MAIN) goto read_err;
+  main_name = NULL;
 
   if (!(read_name = malloc(sizeof(bc_lang_func_read)))) {
     s = BC_STATUS_MALLOC_FAIL;
@@ -873,8 +874,8 @@
 
   strcpy(read_name, bc_lang_func_read);
   s = bc_program_addFunc(p, read_name, &idx);
-  read_name = NULL;
   if (s || idx != BC_PROGRAM_READ) goto var_err;
+  read_name = NULL;
 
   if ((s = bc_vec_init(&p->vars, sizeof(BcNum), bc_num_free))) goto var_err;
   s = bc_veco_init(&p->var_map, sizeof(BcEntry), bc_entry_free, bc_entry_cmp);
@@ -1292,9 +1293,7 @@
     if (byte) val |= ((unsigned long) byte) << (CHAR_BIT * sizeof(uint8_t) * i);
   }
 
-  printf(" (%lu) ", val);
-
-  return BC_STATUS_SUCCESS;
+  return printf(" (%lu) ", val) < 0 ? BC_STATUS_IO_ERR : BC_STATUS_SUCCESS;
 }
 
 BcStatus bc_program_printName(uint8_t *code, size_t *start) {