commit 747aa5b288189043b59e1a755269f26b75938a10
author Gavin Howard <yzena.tech@gmail.com> Wed Mar 14 02:41:43 2018 -0600
committer Gavin Howard <yzena.tech@gmail.com> Tue Aug 28 17:11:01 2018 -0600
tree 5c78e7dd40b65e556c2648df3271fcfe5125494f
parent 4148d3f18430cca4332ee9a1ea13f7745c2d71a7

Fix bug where obase was triggering wrongly

include/num.h

diff --git a/include/num.h b/include/num.h
index c1837e3..58442e8 100644
--- a/include/num.h
+++ b/include/num.h
@@ -46,8 +46,6 @@
 
 #define BC_NUM_MAX_INPUT_BASE (16)
 
-#define BC_NUM_MAX_OUTPUT_BASE (99)
-
 #define BC_NUM_DEF_SIZE (16)
 
 #define BC_NUM_FROM_CHAR(c) ((c) -'0')

src/bc/num.c

diff --git a/src/bc/num.c b/src/bc/num.c
index 62ff22e..e5a0dde 100644
--- a/src/bc/num.c
+++ b/src/bc/num.c
@@ -1570,7 +1570,7 @@
 
   if (!n || !f) return BC_STATUS_INVALID_PARAM;
 
-  if (base_t < BC_NUM_MIN_BASE || base_t > BC_NUM_MAX_OUTPUT_BASE)
+  if (base_t < BC_NUM_MIN_BASE || base_t > BC_BASE_MAX_DEF)
     return BC_STATUS_EXEC_INVALID_OBASE;
 
   if (!n->len) {

src/bc/program.c

diff --git a/src/bc/program.c b/src/bc/program.c
index 06ce70f..fe902a6 100644
--- a/src/bc/program.c
+++ b/src/bc/program.c
@@ -968,9 +968,9 @@
 
       if (status) return status;
 
-      max = left->type == BC_RESULT_IBASE ? 16 : p->base_max;
+      max = left->type == BC_RESULT_IBASE ? BC_NUM_MAX_INPUT_BASE : p->base_max;
 
-      if (base < 2 || base > max)
+      if (base < BC_NUM_MIN_BASE || base > max)
         return left->type - BC_RESULT_IBASE + BC_STATUS_EXEC_INVALID_IBASE;
 
       *ptr = (size_t) base;