commit be88459d3d4019555568a4fa8cc9e6ed5b2fb4f8
author Gavin Howard <yzena.tech@gmail.com> Mon Apr 29 15:07:49 2019 -0600
committer Gavin Howard <yzena.tech@gmail.com> Mon Apr 29 15:07:49 2019 -0600
tree 1231241f330cc28b246c7f9c0205b9536151336e
parent 11e0120fba1dca9a6396907ba104435c3bf3fe7a

Make shift work

I thought it was working, but exponential printing broke it.

src/num.c

diff --git a/src/num.c b/src/num.c
index 1b2dda4..91597bd 100644
--- a/src/num.c
+++ b/src/num.c
@@ -431,11 +431,11 @@
 	n->num -= places_rdx;
 }
 
-static BcStatus bc_num_shift(BcNum *restrict n, BcDig *restrict ptr,
-                             unsigned long dig, size_t len)
-{
-	size_t i;
+static BcStatus bc_num_shift(BcNum *restrict n, unsigned long dig) {
+
+	size_t i, len = n->len;
 	unsigned long carry = 0;
+	BcDig *ptr = n->num;
 
 	assert(dig < BC_BASE_POWER);
 
@@ -460,14 +460,14 @@
 
 	BcStatus s = BC_STATUS_SUCCESS;
 	unsigned long dig;
-	bool shift;
 	size_t places_rdx;
+	bool shift;
 
 	if (!places) return s;
 
 	dig = (unsigned long) (places % BC_BASE_POWER);
 	shift = (dig != 0);
-	places_rdx = BC_NUM_RDX(places + n->scale) - n->rdx - shift;
+	places_rdx = BC_NUM_RDX(places);
 
 	if (n->scale >= places) {
 		n->scale -= places;
@@ -476,17 +476,19 @@
 	else if (BC_NUM_NONZERO(n)) {
 
 		if (places_rdx > n->rdx) {
-			bc_num_expand(n, n->len + places_rdx - n->rdx + shift);
-			memmove(n->num + places_rdx - n->rdx, n->num, BC_NUM_SIZE(n->len));
-			memset(n->num, 0, BC_NUM_SIZE(places_rdx - n->rdx));
-			n->len += places_rdx;
+			bc_num_expand(n, n->len + places_rdx - n->rdx + 1);
+			memmove(n->num + places_rdx - n->rdx - 1, n->num, BC_NUM_SIZE(n->len));
+			memset(n->num, 0, BC_NUM_SIZE(places_rdx - n->rdx - 1));
+			n->len += places_rdx - n->rdx - 1;
 		}
 
+		//bc_num_printDebug(n, "n", true);
+
 		n->scale = n->rdx = 0;
 	}
 	else n->scale = 0;
 
-	if (shift) s = bc_num_shift(n, n->num + places_rdx, dig, n->len - places_rdx);
+	if (shift) s = bc_num_shift(n, dig);
 
 	bc_num_clean(n);
 
@@ -521,7 +523,7 @@
 	n->scale += places;
 	n->rdx += places_rdx;
 
-	if (shift) s = bc_num_shift(n, n->num, BC_BASE_POWER - dig, n->len);
+	if (shift) s = bc_num_shift(n, BC_BASE_POWER - dig);
 
 	assert(n->rdx <= n->len && n->len <= n->cap);
 	assert(n->rdx == BC_NUM_RDX(n->scale));